[11:29:24] 10WMCZ-Tracker: Bootstrapize button in comment preview - https://phabricator.wikimedia.org/T214187 (10Nathan_fraignt) a:03Nathan_fraignt [11:32:44] (03PS1) 10Nathan fraignt: Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) [11:34:16] (03CR) 10jerkins-bot: [V: 04-1] Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [11:37:10] (03PS2) 10Nathan fraignt: Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) [11:38:29] (03CR) 10jerkins-bot: [V: 04-1] Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [11:39:08] The python tests are broken ^^ [11:41:08] AFAIK The file is indented with tabs, but the tests don´t seem to think so. Will have a look after lunch. [13:02:10] (03PS3) 10Nathan fraignt: Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) [13:03:33] (03CR) 10jerkins-bot: [V: 04-1] Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [13:05:56] (03PS4) 10Nathan fraignt: Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) [13:07:11] (03CR) 10jerkins-bot: [V: 04-1] Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [13:08:43] Alright. Fixed the HTML Lint errors, not sure what to do about the Flake8 errors in python files I did not touch. [13:10:15] Nathan_fraignt, that sounds like a global problem. Looking what causes that [13:25:38] Looks flake8 configuration in tox.ini is ignored... I see no new flake8 version here https://pypi.org/project/flake8/#history [14:09:06] Submitted a dummy patch to Pywikibot (https://gerrit.wikimedia.org/r/c/pywikibot/core/+/486475), that also uses flake8 ran by tox and the error is there too. I sent a msg in #pywikibot to alert them, maybe somebody would know something more. [14:17:47] (03CR) 10Urbanecm: "recheck" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [14:18:31] what's on [14:18:40] this is `shreyasminocha` [14:18:46] locked out of my nick atm [14:18:53] Hi Guest/Shreyas [14:19:09] Hi Urbanecm [14:19:26] good q. flake8 seems to be ignoring/ignored flake8 configuration in tox.ini [14:20:02] (also ignored --config parameter to force a config file regardless where it was, it even didn't complain on --config=/a/b/c/d) [14:20:55] suddently, out of nothing, everything started to functional again [14:21:01] Nathan_fraignt, your patch has +2 [14:21:10] No idea what happened, didn't do anything [14:21:52] I was able to reproduce the issue at my dev vps, and while debugging, I noticed it started to work with no change, so I tried to issue recheck - and it succeeded [14:25:44] funny [14:26:46] (03PS1) 10Urbanecm: [DNM] Test [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486479 [14:27:56] hmm, maybe saying "it works" was premature, the dummy patch in Pywikibot I submitted to test how big the issue just failed. Tried a dummy patch in Tracker, let's see [14:28:36] (03Abandoned) 10Urbanecm: [DNM] Test [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486479 (owner: 10Urbanecm) [14:29:10] I'm confused. Works here... [14:30:31] at least nothing blocks Nathan's patch [15:03:40] (03PS5) 10Urbanecm: Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [15:47:57] (03PS6) 10Urbanecm: Bootstrapize button in comment preview [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [15:48:53] (03PS7) 10Urbanecm: Bootstrapize comment preview form [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [15:51:04] Nathan_fraignt, I've made some changes to your commit, a) it adds form-control to field, so it's bootstrapized more b) removes the sentence with buttons above the form, I don't think that's pretty. I know it was there previously (w/o bootstrap), I just consider this as a good improvement to the form :-). [15:51:14] (03CR) 10Urbanecm: [C: 03+2] Bootstrapize comment preview form [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [15:52:36] (03Merged) 10jenkins-bot: Bootstrapize comment preview form [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/486445 (https://phabricator.wikimedia.org/T214187) (owner: 10Nathan fraignt) [18:42:41] Urbanecm, Sure! I also didn´t like the sentence with buttons above the form, but didn´t really know how else to do it [18:47:02] 10WMCZ-Tracker, 10Patch-For-Review: Bootstrapize button in comment preview - https://phabricator.wikimedia.org/T214187 (10Nathan_fraignt) 05Open→03Resolved