[00:21:57] !admin [04:29:30] (03PS1) 10Aude: Add covers tags and minor cleanup in Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 [04:30:15] (03CR) 10jenkins-bot: [V: 04-1] Add covers tags and minor cleanup in Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 (owner: 10Aude) [04:31:00] ack [04:37:37] (03CR) 10Aude: [C: 032] "although I think jenkins will fail, let's see ...." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94916 (owner: 10Jeroen De Dauw) [04:38:22] (03CR) 10jenkins-bot: [V: 04-1] Update package requirements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94916 (owner: 10Jeroen De Dauw) [08:43:04] six months after having asked a LDAP group for wmde, it is finally created. [08:43:17] I will grant folks in that group some more privileges. [08:48:58] aude: ^^^^ :-] [08:49:07] that solves https://bugzilla.wikimedia.org/show_bug.cgi?id=47734 "allow wmde members to rebuild jobs" [08:49:18] though folks have to be added to the wmde LDAP group obviously [08:53:01] hello [08:55:20] I can not specify the Commons Category:Alice Taglioni on https://www.wikidata.org/wiki/Q265232 [08:55:29] "The specified item was not found on the corresponding website" [08:55:45] https://commons.wikimedia.org/wiki/Category:Alice_Taglioni [09:00:46] oh, it's ok now :) [09:52:02] (03PS2) 10Addshore: Cleanup api GetEntities and surrounding clasess [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 [09:52:03] (03PS1) 10Addshore: Cleanup of ClaimModificationHelper and related.. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95125 [09:52:51] (03CR) 10jenkins-bot: [V: 04-1] Cleanup api GetEntities and surrounding clasess [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 (owner: 10Addshore) [09:53:12] (03CR) 10jenkins-bot: [V: 04-1] Cleanup of ClaimModificationHelper and related.. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95125 (owner: 10Addshore) [09:56:07] (03PS4) 10Jens Ohlig: (bug 54324) sequence in Lua should start with 1 Patch set 2: Reformatted Patch set 3: Oops, I meant to reformat it like this. Patch set 4: ... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 [09:56:41] (03CR) 10jenkins-bot: [V: 04-1] (bug 54324) sequence in Lua should start with 1 Patch set 2: Reformatted Patch set 3: Oops, I meant to reformat it like this. Patch set 4: ... [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 (owner: 10Jens Ohlig) [09:59:46] (03PS2) 10Tobias Gritschacher: Basic cucumber tests for statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94915 [10:00:20] (03CR) 10jenkins-bot: [V: 04-1] Basic cucumber tests for statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94915 (owner: 10Tobias Gritschacher) [10:10:14] grrrit-wm help [10:13:03] !help [10:13:07] @help [10:13:07] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 1.20.2.0 my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [10:15:58] its interesting that in the first created WD items are Q42, Q80, Q666, Q1337, Q1868, Q1971, Q2001, Q2012 and Q2013 [10:16:19] I thought the ID is autoincrementing [10:35:22] (03PS3) 10Henning Snater: jQuery.valueview minor options optimization [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/92423 (owner: 10Daniel Werner) [10:40:29] (03CR) 10Henning Snater: [C: 032] jQuery.valueview minor options optimization [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/92423 (owner: 10Daniel Werner) [10:40:42] Hi all. I try to make template for articles about Wikipedia without params, only using templates with lists (which we already have) and WD. [10:41:43] hashar: around? [10:42:43] And I use labels for native names. But for some languages I can't use it for some reason. [10:43:57] e.g. [[Q3568069]] and [[Q1211233]]. I think native language codes for this elements should be bat-smg and als. Am I right? [10:43:58] 10[3] 10https://www.wikidata.org/wiki/Q356806913 => [10:44:00] 10[4] 10https://www.wikidata.org/wiki/Q1211233 [10:44:13] putnik: what do you mean "for some languages"? The label would always be shown in the client wiki's content language [10:44:28] aude: yup [10:44:33] https://gerrit.wikimedia.org/r/#/c/95106/ [10:44:44] could you kindly merge that? :) [10:45:05] and thanks for setting up our ldap group for doing stuff in jenkins [10:45:17] ahabhahah [10:45:19] bb [10:45:52] putnik: hm, i think i don't quite understand what you are trying to do [10:46:12] aude: where are Ask and Serialization libs nowadays ? :-) [10:46:16] this time, i looks like the submodules are already gone [10:46:25] and nothing to do in mediawiki/extensions [10:46:37] it* looks [10:48:12] DanielK_WMDE, I'm trying to use label for als language code as native name for als Wikipedia. [10:53:35] aude: you got rid of Validator as a dependency although the project is still around and has jobs for it. Maybe you deleted that dependency by mistake? https://gerrit.wikimedia.org/r/#/c/95106/ [10:53:47] it's not used by wikibase [10:53:58] best to remove it as a dependency [10:54:30] e.g. test with what's actually deployed :) [10:58:46] and what happened to Ask and Serialization ? :-] [10:58:58] they are on github, apparently [10:59:19] …. [10:59:20] we'll have to figure out a solution for them, if they are to be deployed [10:59:31] * aude realizes it's a problem [11:00:08] putnik: use it where? to do what? what does "native name" mean? [11:00:36] aude: luckily there is a bunch of solution to solve it, one possibility is to use a dedicated git repo that would hold all the dependencies using composer. In prod we can just clone / submodule that repo and done :-] [11:01:05] hashar: that's the idea of the Wikidata git repo [11:01:12] we're still figuring out details [11:01:29] DanielK_WMDE, use it in Russian Wikipedia for Wikipedia infoboxes. Native name is "Deutschsprachige Wikipedia" for German Wikipedia. [11:01:40] aude: and please please make sure Reedy is in the loop :-] [11:01:45] he is our mw deployment expert [11:01:49] but you know about that already hehe [11:01:51] we could probably commit the vendor (or whatever) directory [11:01:54] yeah :) [11:01:57] hashar: i'd love to be able to use such a pre-build repo with jenkins, but the question is how to get the patch that is to be tested integrated into the pre-build thing. [11:02:10] we are taking baby steps and next step is to have this Wikidata repo on beta [11:02:19] DanielK_WMDE, name on language that Wikipedia uses. [11:02:56] DanielK_WMDE, I think that for als-wp this language should be als, but maybe I'm wromg. [11:03:51] anyone who can answer http://lists.wikimedia.org/pipermail/wikidata-l/2013-November/003096.html ? [11:04:17] aude: extensions are gone from both jjb and zuul :) [11:04:20] you could get the name of the wikipedia from the wikidataitemL e.g. for english wikipedia it would be: https://www.wikidata.org/wiki/Special:EntityData/Q328.json [11:04:21] thanks hashar :) [11:04:28] * aude owes another beer [11:05:12] putnik: i gather you are using Lua to get the correct label from the data structure? based on the "wikimedia language code" property? [11:05:13] DanielK_WMDE: the only issue I can think of is that we can't use composer on the continuous integration box for now. [11:05:25] hashar: right [11:05:34] DanielK_WMDE: but one could edit the composer, run it locally and send the whole vendor directory for review. Then the ci box would fetch the code from gerrit. [11:05:44] exactly [11:05:46] DanielK_WMDE, yes. [11:05:55] i think Flow does that [11:06:07] they have Pimple (i think) [11:06:11] but I need to get a pool of isolated Jenkins slaves to be able to run composer into [11:06:16] :) [11:06:30] and I suspect it is not going to happen anytime soon :/ [11:06:38] it's okay [11:06:42] putnik: hm, for one thing, Q1211233 has "Alsation" set fir "language". That's wrong. [11:07:24] ...i think [11:07:26] * DanielK_WMDE is confused [11:08:36] DanielK_WMDE, I'm not using code from language, but from Wikimedia language code. Maybe I should use language code? [11:09:26] (03PS2) 10Aude: Add covers tags and minor cleanup in Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 [11:09:31] putnik: no, i think "Wikimedia language code" is right. [11:09:34] * aude see if jenkins is happy [11:09:48] putnik: als.wikipedia.org uses "gsw" as it's content language code. [11:10:00] (03CR) 10jenkins-bot: [V: 04-1] Minor cleanup and add covers tags in Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 (owner: 10Aude) [11:10:00] i suppose that's what you'd want to use for the label [11:10:12] Ugh, it's strange. [11:10:14] but there's of course always a good chance that the label just isn't set in that language [11:10:22] putnik: yes, it is. [11:10:27] ok, have to wait for puppet maybe [11:11:52] putnik: to find out the language code, look at the HTML code of the wikipeda's main page, and search for wgPageContentLanguage (or wgContentLanguage) [11:14:33] DanielK_WMDE, I'll try to compare language codes with WM language codes. [11:15:16] Maybe common language codes would work for me. [11:15:55] (03PS3) 10Aude: Minor cleanup and add covers tags in Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 [11:16:11] putnik: "language" isn't a code, it's an item reference [11:16:13] (03PS9) 10Henning Snater: (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [11:16:29] (03CR) 10jenkins-bot: [V: 04-1] Minor cleanup and add covers tags in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 (owner: 10Aude) [11:16:46] patience.... [11:17:21] (03CR) 10jenkins-bot: [V: 04-1] (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [11:18:15] DanielK_WMDE, I know =) It means that I should import ISO codes for all language items first. [11:18:34] that would be cool :) [11:18:55] *and* wikimedia code for all languages [11:28:24] (03CR) 10Daniel Kinzler: [C: 04-1] "(5 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [11:30:25] (03CR) 10Daniel Kinzler: [C: 032] "What does this even do, exactly?..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94907 (owner: 10Jeroen De Dauw) [11:30:56] (03CR) 10Daniel Kinzler: [C: 032] Remove one more usage of EntityId::newFromPrefixedId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94920 (owner: 10Jeroen De Dauw) [11:31:04] (03CR) 10jenkins-bot: [V: 04-1] Remove unused SearchEntityArtefacts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94907 (owner: 10Jeroen De Dauw) [11:31:28] (03Abandoned) 10Aude: skip SiteLinkLookupTest in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94923 (owner: 10Aude) [11:32:14] (03CR) 10jenkins-bot: [V: 04-1] Remove one more usage of EntityId::newFromPrefixedId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94920 (owner: 10Jeroen De Dauw) [11:32:39] hashar: how long does it take for jenkins to have the new config? [11:32:52] (03CR) 10Daniel Kinzler: [C: 032] Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 (owner: 10Jeroen De Dauw) [11:33:11] * aude assumes puppet needs to run [11:33:31] (03CR) 10jenkins-bot: [V: 04-1] Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 (owner: 10Jeroen De Dauw) [11:37:14] (03CR) 10Daniel Kinzler: [C: 031] "hm, no jenkins?..." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94730 (owner: 10Jeroen De Dauw) [11:38:45] (03CR) 10Daniel Kinzler: [C: 032] Optimized imports [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94917 (owner: 10Jeroen De Dauw) [11:42:35] (03CR) 10Aude: "(2 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [11:44:00] (03CR) 10Aude: [C: 032] (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [11:44:02] (03CR) 10jenkins-bot: [V: 04-1] (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [11:44:07] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [11:46:18] aude: I managed to configure my wiki as a client and a repo :) [11:46:30] yay! [11:46:48] now I see the "Add links" link on a page without any links, but I don't see it on a page with existing links. [11:47:03] then you should see "Edit links" [11:47:10] yes, but I don't. [11:47:23] Also, the widget appears for adding links appears, but doesn't let me add any links. [11:47:39] By itself it's not important, but it probably means that the wiki is not aware of any other clients. [11:47:45] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94049 (owner: 10Addshore) [11:47:54] How do I make it aware? [11:48:11] did you populate the sites table? [11:48:27] and make sure you set your siteGlobalID to something [11:48:51] e.g. 'hewiki' if you want to have it be hebrew wikipedia :) [11:50:18] aude: how do I populate the sites table? [11:50:32] Wikibase/lib/maintenance/populateSitesTable.php [11:52:17] (03PS4) 10Aude: Minor cleanup and add covers tags in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 [11:52:35] * aude tries again [11:52:38] (03PS5) 10Daniel Kinzler: Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 (owner: 10Jeroen De Dauw) [11:52:59] (03CR) 10jenkins-bot: [V: 04-1] Add covers tags and minor cleanup in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 (owner: 10Aude) [11:53:03] wtf! [11:53:06] hashar: poke [11:53:32] oh, ok [11:54:05] no it seems jenkins is still using the old config [11:54:17] (03CR) 10jenkins-bot: [V: 04-1] Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 (owner: 10Jeroen De Dauw) [11:54:57] aude: oh my [11:55:01] forgot to refresh the dependencies [11:55:02] sorry [11:55:05] oh ok [11:55:15] it seemed it was takign a very long time :) [11:57:42] DanielK_WMDE: if i let the exceptions "bubble" up, then all i know is we have a generic "InvalidArgumentException" [11:57:55] and have the exception message, but not the error message key [11:58:19] aude: then convert the exception to a more meaningful one, and throw that [11:58:26] hmmmmm [11:58:36] i have to make a new exception class? [11:58:40] aude: refreshing a bunch of jobs mwext-Wikibase-client-tests mwext-Wikibase-qunit mwext-Wikibase-repo-tests mwext-Wikibase-repoapi-tests mwext-Wikibase-testextensions-master [11:58:40] exceptions are *really* nicer for error handling, they leave you with a much cleaner control flow [11:58:52] hashar: thanks [11:59:06] aude: you could (ab)use ErrorPageError [11:59:08] an exception class that has error message keys? [11:59:11] ok :) [11:59:54] it takes $msg [12:00:54] yep [12:01:27] (03PS3) 10Daniel Kinzler: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 [12:03:10] (03CR) 10jenkins-bot: [V: 04-1] (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [12:06:59] (03PS3) 10Zfilipin: Basic cucumber tests for statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94915 (owner: 10Tobias Gritschacher) [12:07:31] (03CR) 10Zfilipin: "Added new line to commit message to force Jenkins to run linters again." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94915 (owner: 10Tobias Gritschacher) [12:15:20] off for lunch [12:21:35] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [12:23:36] aude: I ran populateSitesTable.php , but I still don't see the link. [12:24:18] Do I need to set siteGlobalID? Isn't it enough to use require_once( "$IP/extensions/Wikibase/client/ExampleSettings.php" ); ? [12:34:11] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1189 (master - 33dbf9c : Tobias Gritschacher): The build was fixed. [12:34:11] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c5c00ee2f2d4...33dbf9c087e7 [12:34:11] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13909933 [12:39:05] aude: ^ :) [12:56:23] (03PS6) 10Jeroen De Dauw: Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 [12:56:29] (03PS3) 10Jeroen De Dauw: Remove one more usage of EntityId::newFromPrefixedId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94920 [12:57:52] (03PS2) 10Jeroen De Dauw: Remove unused SearchEntityArtefacts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94907 [12:58:04] (03CR) 10Jeroen De Dauw: [C: 032] "CR by danilek" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94907 (owner: 10Jeroen De Dauw) [13:06:40] (03Merged) 10jenkins-bot: Remove unused SearchEntityArtefacts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94907 (owner: 10Jeroen De Dauw) [13:07:26] Henning_WMDE: Hallo. Maybe you'll know: I installed Wikibase client on my local testing wiki. I see the "Add links" link in the interlanguage area when there are no links, but I cannot add any links using the widget, and I don't see the "Edit links" link if I add some links manually to the article. [13:07:35] Do you know how to make that work? [13:13:30] aharoni: Just yesterday, I installed the client manually (the documentation is missing quite some steps). I can only think of some missing configuration. Tobi_WMDE helped me setting it up. [13:15:16] aharoni: if the page on the client is not connected to the wikidata item yet, you won't see the "edit links" button [13:15:55] Tobi_WMDE: makes perfect sense! I should have thought about it. [13:17:02] Actually, Tobi_WMDE, now that I think of it, if there are only links in the page's source, shouldn't I see an "Add links" link? [13:18:26] aharoni: let me check what it currently does [13:20:13] aharoni: you're right. currently the "add links" widget isn't shown when there are local sitelinks defined.. [13:20:33] Aha, so that's probably the problem. Do you agree that it should appear there? [13:23:46] aharoni: I'm not sure what was the intention here in the beginning. I think we intentionally left that out. So the "add links" is only shown if there are no links displayed at all [13:24:11] would probably confusing to users to have the widget displayed when there are already links shown [13:24:51] OK, so I'll leave that for now, although this issue should probably be explored. (I'll report a bug. [13:25:31] Basically, I am trying to refactor the code that adds this link - both as Add and as Edit. [13:25:51] The way it is now, it interferes with ULS. [13:26:05] But of course, I want to test what I'm coding. [13:26:23] So I'm trying to set up my wiki to show links using Wikidata. [13:26:43] It's a problem of synchronisation. When site links are defined in the page it will be very confusing for the user to trigger "add/edit links" since it manages the site links on a different level. [13:27:00] Yeah, I understand. I'll leave that direction for now. [13:27:10] OK, something much simpler: [13:27:56] (I hope) [13:37:16] Henning_WMDE, Tobi_WMDE - How can I make the links adding widget in my client work? [13:51:42] aude: is it possible to just see links from wikidata.org on my local client? [13:52:05] all I really need is to see some real links coming from a repo, and the "edit links" link. [15:03:58] (03PS5) 10Aude: Add covers tags and minor cleanup in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 [15:04:22] aharoni: sorry, we've been in a meeting [15:04:31] np :) [15:04:34] aharoni: what does still not work with the widget? [15:05:59] "add links" is shown, right? [15:06:07] what happens when you click it? [15:11:57] Tobi_WMDE: "add links" is indeed shown. [15:12:37] If I click it, I see the widget's box, but the button is disabled, and there are not s to add the links. [15:18:50] aharoni: do you have a link to test this? [15:20:25] lbenedix: no, it's my local wiki [15:27:41] aude: did you get around to looking at the ULS API changes? [15:46:40] aharoni: about to do that [15:47:30] greg-g: around? [16:15:19] aude: what's up? (just got in) [16:15:58] greg-g: i am reading https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap and.... [16:16:07] wonder if we are really deploying on thanksgiving? :) [16:16:17] or will we pretend that week doesn't exist [16:16:31] heh, no, just haven't updated. The canonical place to look is [[wikitech:Deployments]] [16:16:32] 10[5] 04https://www.wikidata.org/wiki/wikitech:Deployments [16:16:37] i saw [16:16:40] we'll pretend that week doesn't exist, indeed [16:16:50] sorry... /me updates now [16:16:51] , so we deploy wmf5 to test2 / test wikidata on nov 21 [16:17:06] and then to wikidata etc on december 3(?) [16:17:17] also, i see wikidata has switched to tuesdays [16:17:20] yep [16:17:23] yeah, that too [16:17:25] ok [16:17:29] we moved the monday deploy to tuesday [16:17:33] that's fine [16:17:49] so we will probalby deploy quanities to test.wikidata next thursday [16:17:50] to give one more day of bug finding before big wikis like you and commons [16:18:02] and then that gives our community a week and half to try it / find bugs [16:18:08] * greg-g nods [16:18:10] sounds good [16:18:14] perfect for us [16:18:24] :) [16:18:25] * aude has to check with lydia and tobi [16:18:42] we originally wanted to make a branch today, but things are just not ready for that (in my opinion) [16:19:11] gotcha [16:19:38] unless one of them objects, i think that is the plan (next thursday) [16:19:55] https://gerrit.wikimedia.org/r/94795 reviewwww [16:19:58] :D [16:35:14] (03PS4) 10Daniel Kinzler: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 [16:35:30] (03PS3) 10Daniel Kinzler: (bug #56682) Use DecimalMath for getUncertaintyMargin [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 [16:35:41] (03CR) 10jenkins-bot: [V: 04-1] (bug #56682) Use DecimalMath for getUncertaintyMargin. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 (owner: 10Daniel Kinzler) [16:38:17] (03CR) 10jenkins-bot: [V: 04-1] (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 (owner: 10Daniel Kinzler) [16:43:39] Wikidata Office hour starts over in #wikimedia-office in 15 mins!!!!! =] [16:57:06] addshore: http://tools.wmflabs.org/wikidata-analysis/daily.html is broken [16:57:18] first link on http://tools.wmflabs.org/wikidata-analysis/ [16:57:30] tree links are also broekn [16:57:33] broken* [16:57:48] and "other" link is broken [16:57:57] but the maps work :D [16:58:24] aude: feel free to poke the code ;p its on github [16:58:33] Lydia_WMDE: where's the staff chat? [16:58:36] yeah.... [16:58:41] addshore: ^ (i.e. which channel?) [16:58:45] Sven_Manguard: #wikimedia-office [16:58:47] -office [16:58:47] 04Error: Command “office” not recognized. Please review and correct what you’ve written. [16:58:54] :O [16:58:54] * aude stabs the bot [16:59:06] Ah, I was trying to get into #wikimedia-staff\ [16:59:10] I wasn't talking to you AsimovBot. [16:59:13] lol [16:59:15] that is probably secret [16:59:18] That is a private channel. [16:59:23] Yeah [17:07:18] (03PS3) 10Daniel Kinzler: (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 [17:22:30] (03CR) 10Henning Snater: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [17:29:21] (03PS6) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 [17:33:09] (03PS7) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 [17:35:16] (03CR) 10Aude: "I would like to add tests and improve on error handling, but do so in a follow up. (already this patch is doing a slight bit more than fi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [17:44:12] (03CR) 10Aude: [C: 032] (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [17:44:46] (03Merged) 10jenkins-bot: (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [17:45:51] is there a way to create a lot of meaningless items for testing? [17:46:05] set up your own Wikibase [17:46:10] I have [17:46:16] use a bot [17:46:38] is there no testdata? [17:47:04] we used to have chemicals [17:47:13] might still be around, together with a script to upload them, in php [17:47:22] probably in the maintenance folder [17:47:48] not sure if this still works, though [17:48:27] simple-elements.csv is there [17:48:49] and there should be some php script close by [17:49:15] but i dont think anyone tests that if it still works, as said [17:49:23] they work, but only for sitelinks sadly [17:49:33] there is only importInterlang.php and importProperties.php [17:49:40] they don't bring statements with them or anything (they used to, but that's broken) [17:50:19] damn [17:50:40] indeed, but nobody found the time to fix it yet [17:59:12] Special:EntitiesWithout... is more broken than I thought [17:59:45] for installations where you dont have short urls, but index.php?title=... [18:04:31] (03PS5) 10Daniel Kinzler: (bug #56903) Introducing EntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94738 [18:04:42] aude: this one should work now ---^ [18:06:55] * aude going home [18:10:41] (03CR) 10Aude: Update package requirements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94916 (owner: 10Jeroen De Dauw) [18:10:46] (03CR) 10Aude: [C: 032] Update package requirements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94916 (owner: 10Jeroen De Dauw) [18:12:22] https://gerrit.wikimedia.org/r/#/c/95105/ would be awesome to have merged [18:12:25] easy chocolate [18:12:53] makes code coverage reports more accurate [18:13:16] (03PS4) 10Daniel Kinzler: (bug #56682) Use DecimalMath for getUncertaintyMargin. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 [18:13:57] (03CR) 10Addshore: [C: 032] Minor cleanup and add covers tags in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 (owner: 10Aude) [18:14:05] \o/ [18:14:20] (03CR) 10jenkins-bot: [V: 04-1] (bug #56682) Use DecimalMath for getUncertaintyMargin. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 (owner: 10Daniel Kinzler) [18:15:16] (03Merged) 10jenkins-bot: Update package requirements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94916 (owner: 10Jeroen De Dauw) [18:18:26] Goodbye everyone. I'll be back later tonight! [18:18:59] (03Merged) 10jenkins-bot: Minor cleanup and add covers tags in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/95105 (owner: 10Aude) [18:37:40] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1192 (master - 1a93d2c : jenkins-bot): The build was broken. [18:37:40] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/5ef23ad15f28...1a93d2ced6b6 [18:37:40] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13927384 [18:37:57] (03CR) 10Bene: [C: 04-1] "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [18:46:51] DanielK_WMDE: hi [18:54:59] (03CR) 10Lbenedix: "The siteselector gives strings like "Deutsch (dewiki)", I see that "dewiki" is no language, but neither is "de", this is only a language C" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [18:55:52] hoo: is there a languageselector? something like siteselector but only for languages? [18:57:29] lbenedix: No, you would have to implement that on your own... you can use jQuery ui's suggester as a base, though [18:58:41] In my opinion the siteselector is good enough, and definitly better than entering a languagecode into an input field with the label "Language:" [19:00:25] lbenedix: hm... but in reality you still want languages, don't you? The siteselector just isn't for languages [19:01:32] I agree that it's not the best tool for this job, but it does its job very very good [19:02:19] heh, thank Henning then for writing it... but I doubt it will go through review that way (at least I don't dare to approve such a change) [19:07:01] (03PS5) 10Daniel Kinzler: (bug #56682) Use DecimalMath for getUncertaintyMargin. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 [19:08:56] do you think that there will be a languageselecotor someday? [19:09:45] lbenedix: Probably, if it's needed... but one has to bring that up [19:10:51] I think I'll give up [19:11:21] I'll reduce the change to the bugfix for index.php?title= installations [19:12:05] mh, ok :( [19:13:07] I'm not able to write the languageselector by myself [19:13:37] I doubt I have the time for that sorry, you could open a bug, though and CC Henning and me [19:16:21] lbenedix: ULS is a language selector [19:16:50] dennyvrandecic: Well, we need a selector so that a user can select a language on a special page [19:17:02] a language to query something for, not the UI lang [19:17:16] ULS should be able to be used as a widget for that [19:17:25] Might be [19:17:37] it is one of the use cases for that :) [19:18:19] maybe check with siebrand or one of the devs for details, but it definitively is designed for that [19:18:22] mh, is it ok if we have dependencies on ULS in wikibase? [19:18:36] not really [19:18:46] why? [19:18:50] don't make it a hard dependency [19:19:01] if it is there, use it, if not, just show a box [19:19:04] at least have a fallback [19:19:06] mh, I think resource load throws if it can't find a dependency [19:19:07] not sure [19:19:16] * resource loader [19:25:31] I still don't see that siteselector is completely wrong... allmost all sites are different language wikipedias and it would improve the usability of this specialpages [19:26:25] I doubt we want that, that's just to hacky [19:27:03] and "de" as a "language" is wrong [19:27:24] deu is more appropriate, I know [19:27:38] but de is unique, so that shouldn't matter... standards :P [19:27:42] the language is called "Deutsch" [19:28:09] yeah, but that doesn't really matter, we need a machine readable form [19:29:38] because machines use specialpages? [19:29:52] nah, but the special page has to parse them [19:30:02] it does [19:30:14] plus humans can use it now [19:30:40] really? [19:31:11] that's nice... so where's the problem here? [19:31:32] with now, I meant "with the patch" [19:33:52] the problem is that the specialpage expects the user to enter "de" as a language [19:34:33] (03CR) 10Daniel Kinzler: [C: 032] Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 (owner: 10Jeroen De Dauw) [19:34:52] (03CR) 10Daniel Kinzler: [C: 032] Remove one more usage of EntityId::newFromPrefixedId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94920 (owner: 10Jeroen De Dauw) [19:38:03] (03Merged) 10jenkins-bot: Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 (owner: 10Jeroen De Dauw) [19:38:31] So finally got some time to fix all those missing globes :-) [19:39:09] \o/ [19:39:20] It turned out to be really easy [19:39:23] yea [19:39:24] s [19:39:44] (at least in pywikibot) [19:39:52] better you than a staff person (even in my free time) [19:40:12] now we need null precisions fixed [19:40:21] in coordinates [19:40:37] Is that an error? Will it give a warning? [19:40:53] (03CR) 10Daniel Kinzler: "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [19:40:54] we make it so it does not cause error [19:40:59] (03Merged) 10jenkins-bot: Remove one more usage of EntityId::newFromPrefixedId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94920 (owner: 10Jeroen De Dauw) [19:41:21] however we should "hard" deprecate it and have it cause error at some point [19:41:27] I'm looking into importing coordinates for location. What precision should I use? Do we have an overview somewherE? [19:41:46] Take for example https://ca.wikipedia.org/wiki/Estaci%C3%B3_del_Masnou [19:41:56] {{coord|41|28|37.07|N|2|18|37.43|E|region:ES-CT_type:railwaystation|display=inline,title}} [19:41:57] 10[6] 10https://www.wikidata.org/wiki/Template:coord [19:44:30] aude: Precision should be better documented [19:45:04] aude: Is 0.00001 for a landmark correct? [19:47:20] multichill: if i enter 40° 44′ 54.36″ N, 73° 59′ 8.36″ W [19:47:22] then i get precision":2.7777777777778e-6 [19:47:26] if i .... [19:47:56] enter 40.748433, -73.985656 [19:48:02] i get precision":1.0e-6 [19:48:23] I'm coverting from above so 41 + 28/60 + 37.07/3600 etc. That gives false precision [19:48:24] my bot is working with decimal degrees [19:48:35] so something like 0.000001 [19:48:59] The extra zero is intentional? [19:49:03] no [19:49:07] just example [19:49:49] i think addshore has a method for calculating decimal degree precision [19:49:57]