[07:49:37] good moaning [07:50:14] awake ... at home ... using m old computer as my "new" one is broken [08:04:41] (03PS1) 10Henning Snater: Removed detaching of entityview DOM while initializing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94861 [08:11:36] (03Draft2) 10Henning Snater: Refactored inputAutoExpand jQuery plugin [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94769 [08:20:21] (03Draft5) 10Henning Snater: Implemented "eachchange" event using the jQuery.event.special API [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93736 [08:20:27] (03Draft3) 10Henning Snater: Implemented "eachchange" event using the jQuery.event.special API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 [08:28:25] (03PS3) 10Henning Snater: Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 [08:29:49] (03CR) 10jenkins-bot: [V: 04-1] Adjusted ChangeOpClaim/SetClaim to be able to reorder groups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91189 (owner: 10Henning Snater) [08:32:55] (03PS4) 10Henning Snater: Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 [08:33:06] (03Draft4) 10Henning Snater: Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 [08:34:20] (03CR) 10jenkins-bot: [V: 04-1] Implemented ordering of statement groups in the UI [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91191 (owner: 10Henning Snater) [08:40:13] (03PS1) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 [08:42:03] (03CR) 10jenkins-bot: [V: 04-1] Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 (owner: 10Aude) [08:44:29] (03PS1) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 [08:47:11] (03CR) 10jenkins-bot: [V: 04-1] Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [08:47:18] (03PS6) 10Aude: (bug 49434) Support diff=0 in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92648 [08:56:47] (03PS2) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 [09:23:32] (03PS2) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 [09:25:24] (03CR) 10jenkins-bot: [V: 04-1] Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 (owner: 10Aude) [09:33:53] zeljkof: I had to fix a few things in https://gerrit.wikimedia.org/r/94737 you might want to have a quick look again if it's ok. then I can merge it. [09:34:20] Tobi_WMDE: I am in a meeting with aharoni, will take a look later [09:35:15] ok, thx [09:48:33] hi [09:49:07] is there a quck way to get a list of all lakes in germany with german label and coordinates in json? [09:49:42] i allready have a query: CLAIM[31:(TREE[15324][][279])] AND CLAIM[17:183] AND CLAIM[625] [09:49:58] but wikidata only returns ids [09:50:14] (03PS2) 10Daniel Kinzler: (bug #56714) option for disabling rounding. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94717 [09:52:35] Any devs around who can check ULS compatibility with me wrt http://lists.wikimedia.org/pipermail/wikitech-l/2013-November/073045.html ? [09:54:50] morning hashar :) [09:55:03] did you spot the patch I added you too? :) [09:56:19] aude: can you help Nikerabbit? ^ [09:57:38] Hi, someone know why in http://www.wikidata.org/wiki/Q490 (Milano) I don't see any properties? [09:58:37] (03CR) 10Daniel Kinzler: "@jeroen: the static method would check whether bcmath is present, and construct the appropriate implementation accordingly." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [10:00:44] solved, sorry [10:04:07] aharoni: Nikerabbit noted [10:05:21] thanks, aude . it's urgent-ish, because it should be done before the next deployment, but coding the updates is not supposed to be hard. [10:05:26] ok [10:05:50] as far as I can tell, the important thing for Wikidata is to check that all the calls to uls.data functions work. [10:06:02] they are used quite a lot in ULS' JavaScript [10:06:09] ok [10:06:27] thanks [10:06:34] thanks for poking :) [10:07:02] ;) [10:32:38] (03CR) 10Siebrand: "(3 comments)" [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 (owner: 10Aude) [10:32:45] (03CR) 10Siebrand: [C: 031] Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 (owner: 10Aude) [10:37:41] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 (owner: 10Aude) [10:40:07] (03PS9) 10Daniel Kinzler: Add data type to JSON output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 [10:40:56] (03CR) 10Daniel Kinzler: "PS 9 is a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [10:42:34] (03PS3) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 [10:44:24] (03CR) 10jenkins-bot: [V: 04-1] Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 (owner: 10Aude) [10:45:00] (03PS3) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 [10:54:16] (03CR) 10Addshore: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94385 (owner: 10Daniel Kinzler) [11:04:38] (03CR) 10Addshore: [C: 031] (bug #56714) option for disabling rounding. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94717 (owner: 10Daniel Kinzler) [11:07:57] (03CR) 10Daniel Kinzler: [C: 04-1] "(9 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [11:10:41] (03PS1) 10Aude: Fix typos in dumpJson command options [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94879 [11:12:50] (03CR) 10Daniel Kinzler: [C: 032] (bug 49434) Support diff=0 in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92648 (owner: 10Aude) [11:14:55] (03CR) 10Aude: "so, basically we want a big refactoring? (I think that is needed but only want to address the bug in this patch)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [11:16:18] (03Merged) 10jenkins-bot: (bug 49434) Support diff=0 in Wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92648 (owner: 10Aude) [11:26:25] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1178 (master - 728e48e : jenkins-bot): The build is still failing. [11:26:25] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/7f872d0615e1...728e48ecbe31 [11:26:25] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13852572 [11:32:48] (03CR) 10Daniel Kinzler: [C: 031] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94829 (owner: 10Aude) [11:34:25] (03CR) 10Henning Snater: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [11:40:39] (03Abandoned) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] (mw1.23-wmf3) - 10https://gerrit.wikimedia.org/r/94864 (owner: 10Aude) [11:41:00] (03PS4) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 [11:41:11] (03CR) 10Aude: "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [11:42:23] (03CR) 10Aude: "(5 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [11:42:27] (03CR) 10Daniel Kinzler: [C: 032] Add byPropertyListSerialization Options and use [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92916 (owner: 10Addshore) [11:44:03] (03PS4) 10Aude: Fix action=info in client, split logic to own class, add tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94829 [11:46:14] (03Merged) 10jenkins-bot: Add byPropertyListSerialization Options and use [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92916 (owner: 10Addshore) [11:56:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1179 (master - a545af8 : jenkins-bot): The build was fixed. [11:56:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/728e48ecbe31...a545af8ef8e4 [11:56:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13853454 [12:06:14] Lydia_WMDE: https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibase.git/refs%2Fheads%2Fmw1.23-wmf3 [12:06:37] probably most notable is diff site links are now linked to pages [12:06:52] and fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=55667 [13:16:57] aude: I need your opinion... [13:17:40] createclaim currently returns a single claim, therefore the key is simply 'claim' [13:17:49] yeah [13:17:55] compared to everything else that returns multiple claimhere the key is claims [13:18:16] * aude thinks that is clear [13:18:26] but open to ideas [13:18:28] keep the distinction between returning single objects and multiple objects? or just make createclaim returnna list of claims that only contains a single claim [13:19:00] i would not change it (also might break bots) but see rationale for changing it also [13:19:31] indeed, making them both just return the list would keep our code cleaner, but then it is another change and I see benefits of both.. [13:19:32] aude: when is the next time we branch? Tomorrow? [13:19:41] JeroenDeDauw: yes [13:19:42] tomorrow [13:20:28] JeroenDeDauw: how do we move forward with https://gerrit.wikimedia.org/r/#/c/94355/ ? [13:20:34] meeergeee https://gerrit.wikimedia.org/r/#/c/94730/ [13:20:45] I do not want that to be merged on the same day of the branching [13:23:02] DanielK_WMDE: well, use your own judgment. I just gave you some advice here, nothing that blocks the current approach from being merged [13:25:16] (03CR) 10Jeroen De Dauw: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [13:25:54] (03PS1) 10Aude: Some cleanup in LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94894 [13:27:52] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [13:30:23] JeroenDeDauw: but you won't merge it? [13:30:49] also, i'd still like to know whether you think the static factory approach would be better. [13:31:00] i have started to kind of like it. would at least be a bit cleaner. [13:31:55] (03PS7) 10Addshore: Got rid of "private" callback parameter in jQuery.ui.inputextender's draw [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79153 (owner: 10Daniel Werner) [13:33:24] (03CR) 10Jeroen De Dauw: [C: 04-1] "(5 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [13:33:29] (03CR) 10Jeroen De Dauw: [C: 032] added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [13:33:35] (03CR) 10Jeroen De Dauw: [C: 04-1] added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [13:33:41] (03PS11) 10Addshore: Introduces GenericSet.js [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/76079 (owner: 10Daniel Werner) [13:33:42] (03PS2) 10Addshore: jQuery.valueview minor options optimization [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/92423 (owner: 10Daniel Werner) [13:33:44] (03PS3) 10Addshore: Some documentation updates [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/92422 (owner: 10Daniel Werner) [13:33:45] (03CR) 10Jeroen De Dauw: "This also needs tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [13:34:01] (03CR) 10Jeroen De Dauw: "This also needs tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [13:35:08] DanielK_WMDE: not as long as my last two comments are not addressed [13:35:48] oh, the documentation stuff? ok, sure [13:35:49] JeroenDeDauw: I wonder about your last comment in SpecialEntitiesWithoutPage.php, I havn't changed anything but one variable... [13:36:28] lbenedix: you did quite a bit more [13:36:46] not in line 198 [13:37:22] lbenedix: indeed, you did not introduce this issue [13:37:34] lbenedix: however if you are amending it anyway, you can just as well fi it [13:37:40] okidoki [13:39:00] (03CR) 10Jeroen De Dauw: [C: 04-1] "No tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [13:42:28] (03CR) 10Jeroen De Dauw: "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [13:43:55] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94894 (owner: 10Aude) [13:45:04] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94894 (owner: 10Aude) [13:47:37] next thing I don't understand is the comment for the if-clauses [13:47:50] (03CR) 10Jeroen De Dauw: [C: 032] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94829 (owner: 10Aude) [13:48:24] should I really make a function only to call SiteSQLStore::newInstance()->getSites()->hasSite( $this->site )? [13:53:53] (03CR) 10Jeroen De Dauw: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [13:54:02] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1180 (master - 76284d9 : aude): The build was broken. [13:54:02] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a545af8ef8e4...76284d9cd2f1 [13:54:02] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13857623 [13:55:12] addshore: y u rebase danwes patchsets? [13:55:23] to run the qunit tests on them [13:55:32] datavalue has non voting qunit on jenkins now [13:56:03] if nothi breaks over the next few days we can move it to voting [13:56:12] (03CR) 10Jeroen De Dauw: [C: 032] Some documentation updates [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/92422 (owner: 10Daniel Werner) [13:56:26] addshore: \o/ [13:56:48] indeed [= [13:56:54] (03PS2) 10Jeroen De Dauw: Remove verbose headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94782 (owner: 10Addshore) [13:57:04] (03CR) 10Jeroen De Dauw: [C: 032] Remove verbose headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94782 (owner: 10Addshore) [13:57:16] addshore: https://gerrit.wikimedia.org/r/#/c/94050/ [13:57:50] (03CR) 10Lbenedix: "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [13:58:18] (03PS3) 10Lbenedix: added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 [13:58:32] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94776 (owner: 10Addshore) [13:59:10] (03PS2) 10Addshore: Add api param descriptions where missing [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94050 [13:59:14] JeroenDeDauw: ^^ [13:59:28] (03CR) 10jenkins-bot: [V: 04-1] Add api param descriptions where missing [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94050 (owner: 10Addshore) [13:59:47] (03CR) 10Jeroen De Dauw: [C: 04-1] "The new behaviour is not tested" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94775 (owner: 10Addshore) [14:00:18] addshore: please -2 https://gerrit.wikimedia.org/r/#/c/94755/ [14:00:35] (03CR) 10Addshore: [C: 04-2] APIBREAK wblinktitles uses serialized entityId DNM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94755 (owner: 10Addshore) [14:00:39] (03CR) 10Jeroen De Dauw: [C: 032] Add missing @authors to LinkTitles api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94750 (owner: 10Addshore) [14:01:02] (03CR) 10Addshore: [V: 032] Add api param descriptions where missing [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94050 (owner: 10Addshore) [14:01:10] (03CR) 10Jeroen De Dauw: [C: 032] Add api param descriptions where missing [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/94050 (owner: 10Addshore) [14:01:22] (03CR) 10Henning Snater: [C: 04-1] "(24 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [14:02:23] (03Merged) 10jenkins-bot: Remove verbose headers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94782 (owner: 10Addshore) [14:04:49] hoo: I'm not sure in which way factoring out the if clause would improve the readability of the code [14:05:25] lbenedix: do it and you'll probably see... not going to be much work, I suppose [14:06:28] if ( $this->site !== '' && $this->hasValidSite( $this->site ) ) instead of if ( $this->site !== '' && !SiteSQLStore::newInstance()->getSites()->hasSite( $this->site ) ) [14:07:23] read only mode /// [14:07:40] ? [14:08:13] * aude can edit [14:08:16] The wiki is currently in read-only mode [14:08:19] is what I get [14:08:26] * aude can still edit [14:08:30] so can i :/ [14:08:32] could be db replag [14:08:37] momentarily high or something [14:08:59] 14:07 <+icinga-wm> PROBLEM - MySQL Replication Heartbeat on db1021 is CRITICAL: CRIT replication delay 329 seconds [14:09:05] * aude sees a bunch of messages like that [14:09:17] :D [14:09:21] now says QL Slave Running on db1021 is OK: OK replication Slave_IO_Running: Yes Slave_SQL_Running: Yes Last_Error: [14:09:24] 14:09 <+icinga-wm> RECOVER [14:09:26] etc [14:09:37] lbenedix: Like that: function hasInvalidSite() { return $this->site !== '' && !SiteSQLStore::newInstance()->getSites()->hasSite( $this->site ); } then you can do if ( $this->hasInvalidSite() ) { /* error code here */ } [14:09:46] ops staff are aware [14:09:49] ok [14:10:05] thanks for poking us :) [14:10:33] but does this improve the code in any way? [14:10:48] I have to scroll to see what hasInvalidSite does [14:11:05] lbenedix: Well, it makes it more readable and better testable [14:11:05] sounds like lbenedix needs a bettr editor ;p [14:11:44] * lbenedix is using sublimetext [14:12:03] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1182 (master - eb81ef0 : Jeroen De Dauw): The build was fixed. [14:12:03] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/9202391b75a8...eb81ef00540d [14:12:03] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13858453 [14:13:39] curruntly databace is locked? [14:13:50] replag is high [14:13:59] should be okay now [14:14:15] ok. I deleted items now [14:14:23] good [14:14:23] means now works:) [14:16:15] (03PS4) 10Henning Snater: Implemented "eachchange" event using the jQuery.event.special API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93928 [14:16:49] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#83 (master - a283193 : addshore): The build is still failing. [14:16:49] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/ea15d8cf2dab...a28319334dd5 [14:16:49] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/13858477 [14:19:21] aude: addshore: I would like to shutdown wmf Jenkins / Zuul next week during our mornings. Is there a day that is more suitable for your team ? [14:19:34] what day are we moving? [14:19:36] Lydia_WMDE: ^ [14:19:37] aude: addshore: I am going to upgrade Zuul, expecting 2 hours of downtime. [14:19:46] i assume i will be inactive that day [14:19:48] hey [14:19:48] whats in the new zuul? ;p [14:19:48] or at home :) [14:19:57] monday [14:19:58] well [14:20:00] how can i get wikidata items in json format? [14:20:00] monday is good [14:20:03] actually this weekend [14:20:08] Schisma___: through the api? :D [14:20:14] will everything be ready on monday morning? [14:20:14] (03PS4) 10Lbenedix: added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 [14:20:23] I'm trying to find out where it is [14:20:31] i assume we will be busy setting up our stuff, even if at new office [14:20:35] Schisma___: go to http://www.wikidata.org/w/api.php [14:20:40] search for wbgetentities [14:20:43] hashar: monday is good :) [14:20:46] (03CR) 10Jeroen De Dauw: [C: 032] Fix typos in dumpJson command options [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94879 (owner: 10Aude) [14:21:38] aude: excellent, I love monday deploys :-] [14:21:49] hope the new office is better than the current one! [14:21:50] ok [14:22:00] * aude hasn't seen it yet [14:22:37] Henning_WMDE: needs rebase https://gerrit.wikimedia.org/r/#/c/93736/ [14:22:38] DanielK_WMDE: follow up suggestion for https://gerrit.wikimedia.org/r/#/c/94717/2/DataValuesCommon/src/ValueFormatters/QuantityFormatter.php [14:22:45] has getOption method in class as shortcut [14:22:47] * aude claims corner office :D [14:22:56] (03CR) 10Jeroen De Dauw: [C: 032] (bug #56714) option for disabling rounding. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94717 (owner: 10Daniel Kinzler) [14:23:33] hashar: We should write a test for it, so we are sure there are no regressions when moving to the new office [14:23:47] (03PS5) 10Lbenedix: added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 [14:24:11] aude: you can have the front right upper corner of our room, ok? [14:24:36] hah [14:25:08] (03CR) 10Jeroen De Dauw: [C: 032] (bug #56686) Use exponent to represent sig digits [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94385 (owner: 10Daniel Kinzler) [14:25:09] (03Merged) 10jenkins-bot: (bug #56714) option for disabling rounding. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94717 (owner: 10Daniel Kinzler) [14:26:02] aude: How can I make the "Edit links" link appear on my wiki? I have Wikibase, but I don't see it. [14:26:14] I'm talking about the one under the interlanguage links list. [14:26:42] login only, since the widget depends on central auth [14:26:47] errrr [14:26:58] that the user is logged in on both wikis [14:27:22] hoo is working on the widget now, making it better :) [14:27:52] Yep, but still you'll probably need centralauth or some other global auth plugin to make it work ;) [14:28:11] true [14:28:28] aharoni: you also need to set CORS [14:28:50] (if the wikis are using different second level domains) [14:29:14] aude: was the line about CentralAuth for me? [14:29:28] aharoni: yes [14:29:30] yep [14:29:32] maybe hoo is changing it [14:29:47] but it was not required, but was required to be logged in on both wikis [14:29:49] aude: that would be for later, since next monday / tuesday there is a language summit/hackton in India =D [14:29:51] hrrhrhrhrhhrhr, I have bad memories from configuring CentralAuth. [14:29:52] OK. [14:29:58] hashar: oh [14:29:59] I'll try. [14:30:04] that's important [14:30:36] aharoni: if you can configure a wikibase client, then central auth is easy [14:30:44] aharoni: With some modifications the widget could work without a global auth system, but then the client user wouldn't know the user name (/IP) he's using on the repo [14:30:44] its just another db in the load balancer config [14:31:09] :) [14:31:42] I am trying to refactor some things around the links list and I need to take that link into account. [14:31:45] it's just for testing. [14:31:49] ok [14:32:26] aharoni: It's probably enough to just show it then (the widget doesn't actually have to work, I guess) [14:33:07] the JS widget? hmm, it would be nice if it would show *something*, just to check that the correct events are applied to it. [14:33:33] aharoni: Go then... it will still show you a "you must be logged in on the repo" message [14:33:35] aharoni: also don't use IE6 or some ancient browser [14:33:52] they don't work with the widget and thus users of those browsers do no see the widget [14:33:54] o why would I do such a thing! [14:33:58] :D [14:34:14] Yes, we exclude browsers w/o CORS support [14:35:04] ok, so I have Central [14:35:15] ok, so I have CentralAuth enabled, but I don't see the link yet. [14:35:39] aharoni: log in [14:35:50] (03PS8) 10Addshore: Refactor Api Output to use ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 [14:35:56] oh, right :) [14:36:00] you would already have seen it w/o CA by just login in :P [14:38:40] (03CR) 10jenkins-bot: [V: 04-1] Refactor Api Output to use ResultBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 (owner: 10Addshore) [14:39:53] hoo, now I'm confused. [14:40:01] do I need to enable CentralAuth or not? [14:40:14] I'm logged in, without CentralAuth, and I don't see it. [14:40:29] aharoni: You certainly should [14:40:44] how can i get the properties and labels of a given item [14:40:47] ? [14:40:48] ok, let's see. [14:41:10] action=query? [14:42:36] (03PS9) 10Addshore: Refactor Api Output to use ResultBuilder Pt1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 [14:44:00] Schisma___: wbgetentities [14:44:17] will provide yo with the labels, descriptions, claims, aliases, sitleinks of a given item or property [14:44:58] (03PS5) 10Aude: Check id entered in SpecialSetSiteLink is an ItemId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 [14:45:02] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [14:45:15] (03PS6) 10Jeroen De Dauw: added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [14:45:40] (03CR) 10Aude: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [14:46:03] (03PS10) 10Addshore: Refactor Api Output to use ResultBuilder Pt1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 [14:46:27] (03CR) 10Addshore: "PS10 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 (owner: 10Addshore) [14:47:09] reviewwww! https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/WikibaseDataModel,n,z [14:47:46] (03PS7) 10Lbenedix: added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 [14:49:00] (03CR) 10Jeroen De Dauw: [C: 032] added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [14:49:07] (03CR) 10Jeroen De Dauw: [C: 031] added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [14:49:51] addshore: this starts with PS8? https://gerrit.wikimedia.org/r/#/c/94825/ wtf? [14:50:00] drafts ;p [14:50:10] :D [14:50:11] add yourself as a reviewer and they will appear [14:50:37] amazing! [14:51:28] Tobi_WMDE: 94737 looks good to me, feel free to merge it (if you have tested that the code runs on your machine) [14:51:35] (03CR) 10Zfilipin: [C: 031] Using the new Ruby Hash API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94737 (owner: 10Zfilipin) [14:52:05] hoo, aude - so now I have CentralAuth enabled and configured, and I am logged in, but I still don't see the link. [14:52:14] huh [14:52:37] mh, the setting defaults to true these days [14:52:53] aharoni: Are you on a wiki with client configured properly? [14:52:55] (03CR) 10Addshore: [C: 04-1] "curreny rebasing ontop of https://gerrit.wikimedia.org/r/#/c/89852/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 (owner: 10Addshore) [14:53:03] hoo - good question :) [14:53:03] and ofc. on a page with no langlinks yet [14:53:04] addshore: no!!! [14:53:08] addshore: review! https://gerrit.wikimedia.org/r/94727 [14:53:13] aude: why not? :P [14:53:13] * aude about to approve [14:53:16] whahahaa [14:53:19] aude: review https://gerrit.wikimedia.org/r/94747 [14:53:25] but that means i just gave daniel a nasty rebae :P [14:53:27] Tobi_WMDE: review https://gerrit.wikimedia.org/r/94730 [14:53:29] I feel bad :P [14:53:31] addshore: no [14:53:33] hoo - there is supposed to be "edit links" and "add links" - i'd love to see both. [14:53:34] not again [14:53:45] addshore: review my change and you will feel good [14:53:46] fine :P [14:53:47] this time, you rebase on 89852 [14:53:52] aharoni: You will see them depending on the number of langlinks [14:54:10] (03PS1) 10Tobias Gritschacher: Revert "Some documentation updates" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94904 [14:54:18] okay aude i wont rebase :P [14:54:25] hoo - yes, that makes sense, but now the question is how do i know whether I have a client configured correctly. [14:54:41] well, [14:54:49] aharoni: Do langlinks from WD appear? If so it's probably ok [14:54:56] i might need tocleanup the constructor of resultbuilder then [14:54:57] also check for JS errors maybe [14:55:10] addshore: when you run phpunit on daniel's patch (in repo) do you get something like http://dpaste.com/1457983/ ? [14:55:24] phpunit considers these errors [14:55:26] I hadnt got around to testing it yet [14:55:44] * addshore will just buy DanielK_WMDE cookies or something :/ [14:55:45] (03CR) 10Henning Snater: [C: 032] Revert "Some documentation updates" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94904 (owner: 10Tobias Gritschacher) [14:55:46] * aude might have to -1 daniels patch [14:55:51] :D [14:56:34] (03PS1) 10Henning Snater: Revert "Revert "Some documentation updates"" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94905 [14:57:15] hoo: no, I don't think that wikidata.org is my repo. [14:57:25] (03CR) 10Aude: [C: 04-1] "phpunit considers stuff like http://dpaste.com/1457983/ as errors." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [14:57:43] hoo: I want the same wiki to be the repo for the sake of simplicity... is it silly of me? :) [14:57:49] aharoni: Doh, I mean your repo... sorry... multitasking is bad [14:58:10] that's supposed to work AFAIK, but I've nerver tested that myself [14:58:16] (03PS11) 10Addshore: Refactor Api Output to use ResultBuilder Pt1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 [14:58:16] aude: do you know if SearchEntityArtefacts is still used? [14:58:17] my LocalSettings configuration is basically require_once( "$IP/extensions/Wikibase/repo/ExampleSettings.php" ); [14:58:24] The maintenance script [14:58:24] aude: ^^ has the tiny bit of cleanup i had left [14:58:26] JeroenDeDauw: never heard of it [14:58:56] (03PS1) 10Jeroen De Dauw: Remove unused SearchEntityArtefacts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94907 [15:02:04] (03PS2) 10Henning Snater: Documentation updates with assignment consistency [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94905 [15:03:46] hoo - my LocalSettings configuration is basically `require_once( "$IP/extensions/Wikibase/repo/ExampleSettings.php" );' [15:04:00] mh, I but AFAIR that should work [15:04:07] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89852 (owner: 10Daniel Kinzler) [15:04:18] (03CR) 10Tobias Gritschacher: [C: 032] Documentation updates with assignment consistency [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94905 (owner: 10Henning Snater) [15:04:21] aharoni: You also need to import that client stuff [15:04:37] hoo what do you mean by "that"? [15:04:43] aude might know better than me, but I doubt that we have a single example conf. for repo+client wikis [15:04:51] * the client [15:05:00] (03Merged) 10jenkins-bot: Documentation updates with assignment consistency [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94905 (owner: 10Henning Snater) [15:06:28] aharoni: you mean you have client + repo on same wiki? [15:06:45] in theory it should work and in most cases, but for widget, don't know [15:07:02] aude. - yes. is that conceivable? :) [15:07:24] aude: The widget should work fine there, it's using the same API abstraction repo uses anyway (yay) [15:07:30] ok [15:07:47] (03PS6) 10Henning Snater: Implemented "eachchange" event using the jQuery.event.special API [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93736 [15:10:13] (03CR) 10Aude: [C: 032] Remove broken and pointless test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94727 (owner: 10Jeroen De Dauw) [15:10:34] (03Merged) 10jenkins-bot: Remove broken and pointless test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94727 (owner: 10Jeroen De Dauw) [15:11:37] (03CR) 10Aude: [C: 032] Add tests for Property::getId [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94747 (owner: 10Jeroen De Dauw) [15:11:49] (03Merged) 10jenkins-bot: Add tests for Property::getId [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94747 (owner: 10Jeroen De Dauw) [15:17:42] (03CR) 10Henning Snater: [C: 04-1] "(5 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [15:18:32] (03PS2) 10Daniel Kinzler: (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 [15:18:34] (03CR) 10jenkins-bot: [V: 04-1] (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [15:18:45] DanielK_WMDE: did you see the last comment in https://bugzilla.wikimedia.org/show_bug.cgi?id=54369 ? [15:18:59] maybe make an todo item for that? [15:19:07] or instuct us on what to do [15:24:00] aude: replied on the bug [15:24:16] ok [15:25:25] reviiiiiieiwwwwww https://gerrit.wikimedia.org/r/#/c/94730/ [15:25:27] addshore: ^ [15:25:28] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/94355 [15:25:43] DanielK_WMDE: I already reviewed over9000 commits today [15:25:51] \o/ [15:26:05] JeroenDeDauw: but you already reviewed that one [15:26:09] i just addressed you comments [15:26:32] (03CR) 10Jeroen De Dauw: [C: 032] (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [15:26:36] (03CR) 10jenkins-bot: [V: 04-1] (bug 56682) DecimalMath now uses bcmath if available [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [15:26:52] aude: kill the code! https://gerrit.wikimedia.org/r/#/c/94907/ [15:26:58] :D [15:28:07] Lydia_WMDE: whats the status of FOSDEM stuff? [15:29:59] (03CR) 10Aude: [C: 04-1] "PHP Fatal error: Call to undefined method Wikibase\DataModel\Entity\EntityId::getNumericId() in /Library/WebServer/Documents/wikidata/ext" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94730 (owner: 10Jeroen De Dauw) [15:31:21] my computer reparation will cost me EUR 200,- at a minimun broke [15:33:58] DanielK_WMDE: question [15:34:05] DanielK_WMDE: can you come over? [15:35:45] (03PS1) 10Jens Ohlig: (bug 54324) sequence in Lua should start with 1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 [15:37:48] (03PS1) 10Jeroen De Dauw: Remove unused caching facilities in Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94910 [15:38:06] addshore: ^ try to beat that in line-removal! ;p [15:41:28] aude: if you want to kill the code, be fast, before addshore beats you to it! [15:42:04] (03CR) 10Aude: [C: 04-1] "probably good to also remove WikibaseCache.sql and where it is registered in WikibaseClient hooks :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94910 (owner: 10Jeroen De Dauw) [15:42:05] (03CR) 10Daniel Kinzler: [C: 032] Remove unused caching facilities in Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94910 (owner: 10Jeroen De Dauw) [15:42:41] (03CR) 10Aude: "my concerns can be done in a follow up :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94910 (owner: 10Jeroen De Dauw) [15:45:37] (03Merged) 10jenkins-bot: Remove unused caching facilities in Wikibase Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94910 (owner: 10Jeroen De Dauw) [15:45:43] (03PS1) 10Aude: remove sql files in client for unused tables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94913 [15:47:36] (03CR) 10Jeroen De Dauw: [C: 032] remove sql files in client for unused tables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94913 (owner: 10Aude) [15:48:32] (03CR) 10jenkins-bot: [V: 04-1] remove sql files in client for unused tables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94913 (owner: 10Aude) [15:48:39] grrr [15:48:53] DanielK_WMDE: fyi, https://www.mediawiki.org/wiki/Extension:Capiunto [15:49:37] addshore: spot the place where we removed a few verbose headers: https://www.ohloh.net/p/wikibase/ [15:49:40] very basic yet, but I guess it carries the main point [15:50:00] hah [15:51:10] aude: when do you get that error? [15:51:17] (03PS2) 10Jeroen De Dauw: Remove getNumericId altogether from EntityId [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94730 [15:51:29] JeroenDeDauw: obvious oversight [15:51:42] * aude also forgot to remove a use statement  [15:51:46] aude: where [15:51:49] (03PS2) 10Aude: remove sql files in client for unused tables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94913 [15:52:01] if you run update.php or install [15:52:38] aude: err, not for me [15:53:34] depends on settings perhaps [15:53:43] whatever jenkins uses... [15:53:54] (03CR) 10Jeroen De Dauw: "Aude: do you have Wikibase Query enabled? That error should not occur for Item or Property ids." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94730 (owner: 10Jeroen De Dauw) [15:54:03] oh, that error [15:54:13] i got it running phpunit [15:54:18] i do not have query enabled [15:54:29] aude: during which test did you get this? [15:54:42] agggggg [15:54:52] * aude runs tests again [15:56:53] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1185 (master - c58f467 : jeroendedauw): The build was broken. [15:56:53] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/b67e8c40a7e2...c58f467e3f2c [15:56:53] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13863496 [15:57:53] (03PS1) 10Jeroen De Dauw: Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 [15:58:13] (03CR) 10Tpt: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 (owner: 10Jens Ohlig) [15:59:33] (03CR) 10Jeroen De Dauw: [C: 032] remove sql files in client for unused tables [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94913 (owner: 10Aude) [15:59:51] JeroenDeDauw: talk proposal not done yet - still on my todo [16:00:01] Lydia_WMDE: till when time? [16:00:11] JeroenDeDauw: end of the month [16:00:42] (03CR) 10jenkins-bot: [V: 04-1] Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 (owner: 10Jeroen De Dauw) [16:01:35] (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [16:03:07] (03CR) 10Hoo man: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 (owner: 10Jens Ohlig) [16:03:35] (03CR) 10Jeroen De Dauw: [C: 04-1] "No tests, style issues, logic is incorrect" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 (owner: 10Jens Ohlig) [16:04:09] (03PS1) 10Tobias Gritschacher: Basic cucumber tests for statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94915 [16:04:34] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94865 (owner: 10Aude) [16:06:11] (03PS1) 10Jeroen De Dauw: Update package requirements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94916 [16:06:54] aggg [16:07:24] (03PS1) 10Jeroen De Dauw: Optimized imports [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94917 [16:08:00] addshore: https://github.com/wmde/WikibaseDatabase/pulls [16:08:03] aude: arrrrrrrrrrrrrrrrrrr [16:10:09] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1186 (master - 1b572f8 : Jeroen De Dauw): The build is still failing. [16:10:09] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/c58f467e3f2c...1b572f8c692d [16:10:09] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13864164 [16:10:44] addshore: [16:10:46] + 72 additions [16:10:48] - 132 deletions [16:10:50] meeergeee [16:13:40] (03PS2) 10Jeroen De Dauw: Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 [16:16:22] (03CR) 10jenkins-bot: [V: 04-1] Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 (owner: 10Jeroen De Dauw) [16:18:20] (03CR) 10Tobias Gritschacher: [C: 032] Using the new Ruby Hash API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94737 (owner: 10Zfilipin) [16:18:36] (03PS3) 10Jeroen De Dauw: Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 [16:20:06] (03PS1) 10Jeroen De Dauw: Remove one more usage of EntityId::newFromPrefixedId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94920 [16:21:59] (03Merged) 10jenkins-bot: Using the new Ruby Hash API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94737 (owner: 10Zfilipin) [16:23:20] aude: Still here? Do we support some page to link with multiple site groups? If so, what will WikibaseClient::getLangLinkSiteGroup do in these cases? [16:23:42] don't think so [16:23:55] not yet [16:23:57] Ok... so the value for that on commons then is wikipedia? [16:24:15] yes [16:24:39] Ok, thought about making linkItem support multiple site groups, but the backend just doesn't seem to be ready for this yet [16:24:45] Less work :) :D [16:24:51] :) [16:32:37] Tobi_WMDE reviewww https://github.com/wmde/WikibaseDatabase/pull/6 [16:33:27] <45PAAKR9O> [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1187 (master - 1f82420 : jenkins-bot): The build was fixed. [16:33:28] <45PAAKR9O> [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/1b572f8c692d...1f8242081535 [16:33:28] <45PAAKR9O> [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13865346 [16:35:06] (03PS1) 10Aude: skip SiteLinkLookupTest in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94923 [16:35:22] (03CR) 10Tobias Gritschacher: "so, no tests for the new methods?" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94730 (owner: 10Jeroen De Dauw) [16:39:59] (03PS4) 10Jeroen De Dauw: Get rid of deprecated method usage in WikipageEntityLookupTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94914 [16:40:01] (03PS2) 10Jeroen De Dauw: Update package requirements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94916 [16:40:10] (03PS2) 10Jeroen De Dauw: Remove one more usage of EntityId::newFromPrefixedId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94920 [16:48:41] Tobi_WMDE: \o/ [17:03:39] (03PS12) 10Addshore: Refactor Api Output to use ResultBuilder Pt1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94825 [17:03:40] (03PS1) 10Addshore: Cleanup api GetEntities and surrounding clasess [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94930 [17:08:17] "The public destroy() method cleans up all common data, events, etc. and then delegates out to _destroy() for custom, widget-specific, cleanup." [17:08:22] that doesn't seem to work :/ [17:08:24] Henning_WMDE: ^ [17:10:07] * jQuery UI 1.8.24 [17:10:35] Yay for legacy software [17:13:10] hoo: We overwriting destroy() all over the place... even native jQuery.ui widgets do that finally calling $.Widget.prototype.destroy.call( this ); [17:13:30] (03PS2) 10Jens Ohlig: (bug 54324) sequence in Lua should start with 1 Patch set 2: Reformatted [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 [17:14:13] mh, not very nice, but I guess it'll work [17:14:28] bye :D [17:14:52] we are going to vanish :/ [17:14:57] Well, it's JavaScript. :D [17:15:08] nooooo! [17:15:09] :D [17:15:19] * addshore feels the internet slipping from his grasp [17:19:16] (03CR) 10Hoo man: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 (owner: 10Jens Ohlig) [17:23:08] (03PS3) 10Jens Ohlig: (bug 54324) sequence in Lua should start with 1 Patch set 2: Reformatted Patch set 3: Oops, I meant to reformat it like this. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 [17:26:16] (03CR) 10Jens Ohlig: [C: 031 V: 031] Remove unused SearchEntityArtefacts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94907 (owner: 10Jeroen De Dauw) [17:31:05] (03PS2) 10Jeroen De Dauw: (bug #56682) Use DecimalMath for getUncertaintyMargin [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 (owner: 10Daniel Kinzler) [17:31:07] (03CR) 10jenkins-bot: [V: 04-1] (bug #56682) Use DecimalMath for getUncertaintyMargin [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94367 (owner: 10Daniel Kinzler) [17:37:20] aude, hoo - If you're still there - how do I configure the client and the repo to see each other? [17:38:04] aharoni: Same wiki? Or do you have multiple ones now? [17:38:10] דשצק [17:38:12] same [17:38:20] (Hebrew keyboard FTW) [17:39:57] mh, actually that should automatically happen if you include the client in your localsettings [17:40:11] default settings should be doing the hard work for you (unless they're broken) [17:40:17] hoo - oh, I probably didn't. [17:40:28] I have require_once( "$IP/extensions/Wikibase/repo/Wikibase.php" ); [17:40:47] add the same with client instead of repo ;) [17:42:27] cool [17:46:06] wow, one can save gerrit comments with ctrl + s [17:46:09] \o/ [17:46:12] awesome [17:47:07] time to eat a few bites... going to be back later in case further assistance is needed [17:49:20] (03CR) 10Tpt: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94355 (owner: 10Daniel Kinzler) [17:54:06] Saluton brion! Mi klopodas reaktivigi e-ajn vikipedistojn. Bv. aldoni [[project:Diskutejo#kie_komenci]] al via atentaro (Chrome, FF ktp.) [17:54:07] 10[1] 10https://www.wikidata.org/wiki/project:Diskutejo%23kie_komenci [17:54:31] :D [17:56:03] Estas listo de pagxoj ligitaj per (properties) [17:56:27] malmultaj e-istoj kunlaboras tie [17:56:50] mi aldonu kelkajn tradukojn :D [17:57:27] mi faris 14,000 sxangxojn ekde komenco de oktobro [17:57:46] mi cxefe laboras rilate bibliotekistajn informojn [17:58:07] ho, vi estas verkema denove :D [18:00:00] yes. Mia pagxo estas https://www.wikidata.org/?curid=16717382 cxe https://www.wikidata.org/?curid=16717382#support estas ligoj por novaj proponoj [18:00:48] Mi devas petadi cxiuloke por la kreo de unuopaj (property) [18:01:31] Vi certe rememoras ke la cxefa e-liingva eldonejon estas en Antverpono, Belgio [18:01:58] amaso da auxtoraj ekzistas nur en la VLACC katalogo [18:02:24] (03PS1) 10Bene: (bug 56693) special page for setting sitelinks needs to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 [18:02:54] brion eble vi povas aldoni vian apogon {{support}} al https://www.wikidata.org/wiki/Wikidata:Property_proposal/Authority_control#VLACC [18:02:55] 10[2] 10https://www.wikidata.org/wiki/Template:support [18:05:01] brion mi cxefe verkis cxe http://www.librarything.com/profile/gangleri dum la lastaj jaroj lastjare mi longtempe malsanis [18:05:30] (03CR) 10jenkins-bot: [V: 04-1] (bug 56693) special page for setting sitelinks needs to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 (owner: 10Bene) [18:10:11] gxis ian brion! [18:10:34] gxis **iam** brion! [18:38:23] hoo: can you tell me what Henning means with "do not declare fields dynamically"? [18:38:29] https://gerrit.wikimedia.org/r/#/c/94794/7/repo/includes/specials/SpecialEntitiesWithoutPage.php [18:39:32] lbenedix: A C++ compiler would kill you for that... the class doesn't have a site and languagecode member variable, you have to (you should) declare it [18:39:57] Do that like it is done with language, type and possible types at the top of the class definition [18:40:23] ahh [18:40:25] okay [18:40:26] like you would do in header file in cpp (if you know about that language... if you don't ignore it) [18:41:40] can I delete the comment for protected $language = ''; ? [18:42:10] Feel free to throw them over anyway you want (as long as it makes sense) [18:42:29] or I add two comments that are as meaningful as "The language used" [18:42:53] heh [18:47:35] one other thing I don't understand is the comment on the i18n.php [18:47:55] * hoo looks [18:48:49] lbenedix: Probably something like "Message shown when the user specified an invalid site. Params... $1 site identifier the user entered [18:48:50] " [18:49:05] something like that, which is more like a user would describe the scene [18:49:50] Its allmost the same description as "wikibase-entitieswithoutlabel-invalid-language" [18:50:28] Yeah... :/ [18:50:32] That one isn't nice either [18:52:24] (03PS2) 10Bene: (bug 56693) special page for setting sitelinks needs to allow setting of badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94939 [19:02:27] (03PS6) 10Bene: (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 [19:19:34] (03CR) 10Hoo man: [C: 04-1] "Code format still messed up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94909 (owner: 10Jens Ohlig) [19:20:37] (03PS7) 10Bene: (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 [19:30:32] (03PS2) 10Bene: (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 [19:32:04] (03CR) 10jenkins-bot: [V: 04-1] (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 (owner: 10Bene) [19:33:23] (03PS8) 10Bene: (bug 46538) keyboard shortcut to get to Wikidata item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89698 [19:37:36] (03CR) 10jenkins-bot: [V: 04-1] (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [19:46:31] aude: there? [19:53:12] (03PS2) 10Bene: (bug 46217) Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 [19:53:29] hoo: thnaks for merging before someone starts nitpicking :D [19:53:40] :D That one was obvious [19:54:03] hoo: I already submited a fix for it once and ended up abandoning it due to to much idiocy in the CR [19:54:29] oO [19:58:12] (03CR) 10jenkins-bot: [V: 04-1] (bug 46217) Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 (owner: 10Bene) [19:59:09] (03PS3) 10Bene: (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 [20:02:30] (03CR) 10jenkins-bot: [V: 04-1] (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [20:02:41] (03PS3) 10Bene: (bug 46217) Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94830 [20:19:49] (03PS4) 10Bene: (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 [20:22:57] (03CR) 10Jeroen De Dauw: [C: 04-1] "Still lacks tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [20:24:42] (03CR) 10Jeroen De Dauw: "Looks good otherwise" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [20:27:38] (03PS5) 10Bene: Add an option in the user preferences to choose additional languages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89859 [20:39:43] (03PS5) 10Bene: (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 [20:51:17] aude: Not done yet with the trains in DC? ;-) [20:53:17] Hello. [20:53:40] Does anyone here know how to create lists of Wikidata pages by number of interwiki links? [20:54:14] * hoo screams SQL and runs [20:54:30] * Sven_Manguard stares confusedly at hoo [20:54:48] Sven_Manguard: A database query ;) [20:55:03] SQL? Is that the three letter abbreviation that sports broadcasters use to represent the Squirrels? [20:55:25] structured query language, that is [20:55:50] Some pronounce it as sequel.... and others want to kill these people, so don't do that :D [20:56:04] Do you know how to do those? [20:56:05] hoo :( I was going to say 'It is quite structure, a query and is also a language' [20:56:07] Because I'd like one [20:56:14] *It is quite structured [20:56:33] JohnLewis: Sorry, my crystal ball recently broke ;) [20:56:54] Sven_Manguard: I don't really ahve the time... maybe JohnLewis can help? [20:57:04] Sven_Manguard: select ips_item_id, count(*) as c from wb_items_per_site group by ips_item_id order by c desc limit 10 [20:57:54] Dude, I'm a third of the way into introduction to Python and have never done anything of value in coding. I have no idea what you just said [20:58:00] (03CR) 10jenkins-bot: [V: 04-1] (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 (owner: 10Bene) [20:58:07] Besides, my query is a bit more specific. [20:58:35] I'm looking for the items that are *in the Portal namespace* that have the most interwiki links [20:58:49] hoo: Well fix it. Until then you are hazard to those who have reasonably good answers to give instead of blatant facts. [20:59:05] :p [20:59:20] Sven_Manguard: i would guess russia [21:00:17] Merlissimo: Maybe I'm not explaining this as well as I need to. What I'm looking for is a list of which portals have the most interwiki links. Not which project, but rather which subjects have portals on the highest number of projects [21:00:34] Sven_Manguard: I probably have it somewhere in my test crap, hold on [21:00:38] cool [21:00:49] create a https://jira.toolserver.org/browse/DBQ and I'll maybe come to that sometime :P [21:01:20] * Merlissimo spams [21:01:25] Toolserver? hoo: Get labs man :p [21:01:27] +-------------+-----+ [21:01:27] | ips_item_id | c | [21:01:27] +-------------+-----+ [21:01:27] | 5296 | 303 | [21:01:27] | 6293548 | 303 | [21:01:29] | 4844001 | 289 | [21:01:31] | 4847311 | 288 | [21:01:33] | 4299475 | 287 | [21:01:35] | 159 | 285 | [21:01:37] | 5400303 | 284 | [21:01:40] | 5461620 | 275 | [21:01:42] | 30 | 272 | [21:01:44] | 16467 | 272 | [21:01:46] +-------------+-----+ [21:01:47] Merlissimo: Pastebin you idiot! [21:01:47] JohnLewis: meh, that project hasn't yet moved... [21:01:51] 3 minutes runtime [21:01:54] :P [21:01:57] although I'm already using labs for the actual queries mostly [21:02:23] JohnLewis: Version management, bug tracker, cross database joins. Three things that labs doesn't have yet [21:02:31] hoo: Toolserver is moving. Backwards that is. It is hell at times :/ [21:02:41] mediawiki main page ist the winner [21:02:42] multichill: I agree but, screw those three things ;) [21:02:42] I know that very well [21:02:53] but I just like Jira a lot (although it's not OSS) [21:03:07] Merlissimo: I'm looking for things in the Portal namespace though [21:04:00] Oh, right [21:04:10] some projects put the main page as a portal? [21:04:39] In the Portal namespace? Hm. I've not seen many if any. [21:07:03] complicated because every wiki has another portal namespace number. so collecting all portal namespace names isn't easy [21:07:27] toolserver got a DB which you can use for that [21:08:51] And pywikipedia contains that info too [21:08:56] Well, would it be easier if you searched for which pages that begin with "Portal:" on English Wikipedia have the most interwiki links? [21:17:29] Sven_Manguard: again wikimedia main page [21:17:36] http://kpaste.net/486a3 [21:19:54] Thanks [21:20:46] Sven_Manguard: Please close the DBQ in case you don't really need it ;) [21:21:29] hoo: how [21:22:20] Workflow -> Resolve issue [21:22:32] I hope that you have the rights to do that [21:23:29] Oh, I had to assign it to myself first [21:23:54] (03PS6) 10Bene: (bug 46353) Forbid to label properties as valid property IDs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94824 [21:23:54] thx [21:24:32] Hoi [21:25:35] I wrote about the typhoon today ... how do you like the idea of having every day a topic that is in the news and make it today's item / [21:25:37] ? [21:26:00] Wikidata item of the day? [21:26:20] sure [21:36:40] Sven_Manguard: like in this way ... http://ultimategerardm.blogspot.nl/2013/11/wikidata-howto-add-value-by-labelling.html [21:59:34] Umm... hi again. [21:59:43] Can someone tell me when I dropped from IRC? [21:59:52] [21:47] * Quits: Sven_Manguard (~Perhaps@wikipedia/Sven-Manguard) (Quit: ChatZilla 0.9.90.1 [Firefox 25.0/20131025151332]) [21:59:55] UTC. [22:00:00] Right. [22:00:09] so 15 mins ago [22:00:17] * Sven_Manguard stares angrily at internet [22:11:32] (03PS3) 10Hoo man: Overhaul jquery.wikibase.linkitem.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 [22:11:55] (03CR) 10Hoo man: "(24 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [22:14:07] Hoi Sven [22:14:18] Hey GerardM- [22:14:23] What language is Hoi ? [22:14:33] Dutch [22:14:45] it is informal [22:14:56] it is friendly [22:15:19] Am thinking on the presentation that I will give this weekend [22:15:26] going to Slovakia [22:15:38] to talk about Wikidata [22:15:59] (03CR) 10Hoo man: "Addressed Henning's comments, split up some big functions, minor clean ups" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94795 (owner: 10Hoo man) [22:16:07] what would YOU say to our East European friends / [22:16:13] ? [22:21:57] * Sven_Manguard stares angrily at internet again [22:22:00] how long this time? [22:22:09] Hello guys [22:22:14] Sven_Manguard: My client doesn't display seconds :/ [22:22:22] Only seconds? [22:22:31] [22:21] * Quits: Sven_Manguard (~Perhaps@wikipedia/Sven-Manguard) (Disconnected by services) [22:22:33] Yeah :p [22:22:37] 22 --> 51 [22:22:46] Cool. I caught that one. [22:23:04] Apparently Panera kicks you out and makes you reconnect after six hours [22:23:25] heh, yeah i've run into that before :/ [22:36:56] JeroenDeDauw: hi [22:37:52] JeroenDeDauw: I have added tests at https://gerrit.wikimedia.org/r/#/c/94824/ [22:51:13] (03CR) 10Lbenedix: "(5 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [22:51:47] (03PS8) 10Lbenedix: added autocompletion to SpecialEntitiesWithout* and fixed bug for index.php?title=Special:... URL-Style for the same Specialpages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 [23:01:26] (03CR) 10Hoo man: "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [23:07:06] (03CR) 10Bene: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [23:08:11] benestar: I removed tha comments, because they add no information that can not be read from the variable names [23:09:09] ok, fair enough [23:09:22] lbenedix: what means the $languageCode ? [23:09:50] its the language code, e.g. de for dewiki [23:17:22] (03CR) 10Lbenedix: "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 (owner: 10Lbenedix) [23:18:59] lbenedix: but I think it is stored in $language already??? [23:19:28] nope, language is "Deutsch (dewiki)" [23:20:12] (03PS9) 10Lbenedix: added autocompletion and fixed a bug [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94794 [23:34:37] Hi Lydia_WMDE