[01:17:12] (03PS1) 10Aude: Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 [01:17:58] Hello [01:21:47] * YuviPanda waves at aude [01:22:16] thanks for the help with setting up wikibase! I managed to submit the patch :D [01:22:28] will work on the vagrant role sometime this weej [01:28:55] YuviPanda: yay! [01:29:23] aude: what do I have to do to get it into your next deployment? [01:29:29] when is the code cutoff? [01:29:38] * aude expects people to rage about tests for what you added, if you didnt' include them [01:29:53] same time, it's legacy code in that class [01:30:07] so tests are not so easy [01:30:15] that's where i think addshore can help out :) [01:30:17] yeah i looked at the tests seemed rather messy [01:30:31] he has been refactoring much of the api and improving tests [01:30:31] I... don't want to block this on rewriting that entire class :D [01:30:36] right [01:30:37] absolutely :) [01:31:40] we are deploying code to wikidata today (later), which means we have 1 1/2 weeks til next cutoff [01:32:10] though its thanksgiving holidays coming up so that might be delayed, maybe* [01:32:10] ah sweet [01:32:20] * aude confused about the calendar [01:32:27] it's sunday for you right? [01:32:34] it's monday [01:32:39] technically [01:32:43] as in right now? [01:32:45] ah [01:32:47] yes [01:32:49] of course [01:32:58] monday 7 am for me :D [01:32:59] * aude is still awake [01:33:16] me too! :D [01:33:23] hah [01:33:29] it's only 3 1/2 hours difference [01:33:36] aude: yeah [01:33:37] maybe not [01:33:41] * aude confused [01:33:50] +0530 [01:33:52] for me [01:34:02] ok [01:34:35] aude: I'll try to add tests if you think it won't get merged without tests [01:35:23] (03PS1) 10Aude: Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 [01:35:59] aude: thanks for the help! [01:37:00] (03PS2) 10Aude: Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 [01:37:27] YuviPanda: if you can, otherwise i think it's likely addshore can assist [01:37:33] wooo! [01:37:39] or i can look (in the evenings) [01:37:42] aude: I guess I can find him tomorrow? [01:37:50] probably [01:38:03] sweet! [01:38:28] (03CR) 10jenkins-bot: [V: 04-1] Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 (owner: 10Aude) [01:38:33] * aude can't pick up new sprint items during work hours, unless i finish everything else :) [01:38:56] :D [01:39:08] sortof me neither, but this is part of our sprint [01:39:20] which technically starts only on Tuesday... :D [01:39:28] hmmmm, mystery jenkins failure [01:39:50] the best kind :D [01:41:04] "UsageException: You need read permission to use this module" hah :P [01:41:42] (03PS3) 10Aude: Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 [01:41:43] (03PS2) 10Aude: Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 [01:41:49] (03CR) 10jenkins-bot: [V: 04-1] Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 (owner: 10Aude) [01:41:54] hoo: what? [01:42:10] aude: one of the exception occured in jenkins [01:42:28] odd [01:42:29] * on [01:44:47] (03CR) 10jenkins-bot: [V: 04-1] Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 (owner: 10Aude) [01:44:59] aude: I got the bad feeling that master's broken... :/ [01:45:14] alright, whatever for tonight [01:45:32] more time than i want to spend right now [01:45:34] probably :P [01:45:43] Same here... wanted to be in bed hours ago... [01:46:12] hmmm "testSetLiteLinkWithNoId" [01:46:31] i don't think that is in a place where it matters, however [01:47:20] Might also be core change... but I'm not willing to perform a big git bisect across several components tonight :D [01:48:18] not me either [01:50:28] YuviPanda: huh, jenkins doesn't run tests for you? [01:50:48] aude: apparently not [01:50:58] even though legoktm added me to the whitelist y'day [01:51:17] I don't use my wikimedia.org email for git [01:51:44] ok, not deployed yet then [01:51:50] I'm using a custom address either... that's not the issue [01:51:50] * aude sees you in zuul config [01:52:04] probably when hashar comes back? [01:52:12] yes [01:52:20] * aude always adds people to zuul [01:53:16] :D [01:53:31] alright, i should sleep :) [01:53:52] aude: night! [01:54:06] nacht [01:54:59] gute Nacht, aude ;) [05:30:20] Good Morning! [08:58:01] (03PS3) 10Aude: Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 [09:01:23] (03CR) 10jenkins-bot: [V: 04-1] Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 (owner: 10Aude) [09:16:05] (03PS4) 10Aude: Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 [09:57:14] Tobi_WMDE, aude: i'm online for the daily. [09:57:30] hey [09:57:31] ok [10:00:50] DanielK_WMDE: now? [10:27:14] (03CR) 10Addshore: [C: 032] Removed unnecessary nodes from "wb-statement" template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92651 (owner: 10Henning Snater) [10:27:30] (03PS10) 10Addshore: Simplified toolbarcontroller.definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93029 (owner: 10Henning Snater) [10:30:59] (03Merged) 10jenkins-bot: Removed unnecessary nodes from "wb-statement" template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92651 (owner: 10Henning Snater) [10:37:00] (03CR) 10Addshore: [C: 032] Removed "toolbarParentSelector" option from toolbarbase widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92652 (owner: 10Henning Snater) [10:40:32] (03Merged) 10jenkins-bot: Removed "toolbarParentSelector" option from toolbarbase widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92652 (owner: 10Henning Snater) [10:42:10] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1158 (master - 029183f : jenkins-bot): The build was fixed. [10:42:10] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/4dec34d86232...029183f8d06f [10:42:10] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13798736 [10:43:21] (03CR) 10Addshore: [C: 032] Initializing toolbar controller before entity view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92860 (owner: 10Henning Snater) [10:46:48] (03Merged) 10jenkins-bot: Initializing toolbar controller before entity view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92860 (owner: 10Henning Snater) [10:49:21] (03PS6) 10Addshore: Introduced toolbarcontroller.destroyToolbar function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93441 (owner: 10Henning Snater) [10:49:27] (03PS6) 10Addshore: Removed interactionWidgetName option from "addtoolbar" widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93460 (owner: 10Henning Snater) [10:49:32] (03PS4) 10Addshore: Re-focus "add" button after having added/cancelled adding a claim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93465 (owner: 10Henning Snater) [10:49:39] (03PS4) 10Addshore: Re-focus "add" button after having added/cancelled adding a reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93466 (owner: 10Henning Snater) [10:51:03] (03CR) 10Addshore: [C: 032] Simplified toolbarcontroller.definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93029 (owner: 10Henning Snater) [10:51:12] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1159 (master - 915aa66 : jenkins-bot): The build was fixed. [10:51:12] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/029183f8d06f...915aa665d2fe [10:51:12] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13799069 [10:52:31] (03CR) 10Addshore: [C: 032] Introduced toolbarcontroller.destroyToolbar function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93441 (owner: 10Henning Snater) [11:00:28] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1160 (master - e3f1f19 : jenkins-bot): The build was broken. [11:00:28] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/915aa665d2fe...e3f1f19b9d4a [11:00:28] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13799324 [11:01:28] (03PS1) 10Daniel Kinzler: (bug #56714) option for disabling rounding. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/94717 [11:01:59] Tobi_WMDE: ^--- please move to "feedback" [11:02:13] (03Merged) 10jenkins-bot: Simplified toolbarcontroller.definition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93029 (owner: 10Henning Snater) [11:04:33] (03Merged) 10jenkins-bot: Introduced toolbarcontroller.destroyToolbar function [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93441 (owner: 10Henning Snater) [11:07:43] DanielK_WMDE: ok :) [11:09:40] (03CR) 10Addshore: [C: 032] Removed interactionWidgetName option from "addtoolbar" widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93460 (owner: 10Henning Snater) [11:12:07] Tobi_WMDE: mail to springle: done. or set it on "feedback" until we have a reply? [11:12:19] ok [11:15:24] Lydia_WMDE: uh, we are having the entity refactoring discussion *today*? [11:15:37] * aude doubts [11:15:46] well, i have an invite in my calendar [11:15:50] DanielK_WMDE: that was the plan but it seems unlikely [11:15:50] I hate to do that remotely :/ [11:15:52] (03Merged) 10jenkins-bot: Removed interactionWidgetName option from "addtoolbar" widget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93460 (owner: 10Henning Snater) [11:16:01] lydia is distracted and no jeroen [11:17:26] DanielK_WMDE: i sent a mail to folks [11:17:33] can you answer sometime today, please :) [11:17:49] Lydia_WMDE: aude: DanielK_WMDE: How important do you think https://bugzilla.wikimedia.org/show_bug.cgi?id=48389 is? Fixing that properly would require changing core and CentralAuth (and not Wikibase... that's not a Wikibase problem) [11:18:09] I'm not going to hack CentralAuth client logic into any of wikibase [11:18:42] would be good to fix me, but not up to me to say priority [11:19:42] mh... hard to tell how many use which cookie settings... [11:21:07] addshore: hey [11:21:24] * YuviPanda waves at addshore [11:22:12] aude: How do I find out which sitegroup I can link to (in PHP)? I want to hand that through into JS... [11:22:26] needed for commons [11:23:15] getLangLinkSiteGroup [11:23:20] WikibaseClient::getLangLinkSiteGroup() [11:23:27] defaultinstance ..... [11:23:49] it could probably be a config var in js [11:24:09] I wanted to integrate it into wbCurrentSite [11:24:14] ok [11:24:28] addshore: there is ApiBase::PARAM_ALLOW_DUPLICATES (I know that it won't work, case-sensitive it is) but it silently removes duplicates [11:24:46] wouldn't then failing with error for badges be inconsistent? [11:24:55] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1161 (master - 389f12d : jenkins-bot): The build was fixed. [11:24:55] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/e3f1f19b9d4a...389f12d37a92 [11:24:55] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13799904 [11:25:01] (03CR) 10Addshore: [C: 032] Re-focus "add" button after having added/cancelled adding a claim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93465 (owner: 10Henning Snater) [11:27:02] (03CR) 10Addshore: [C: 032] Re-focus "add" button after having added/cancelled adding a reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93466 (owner: 10Henning Snater) [11:28:32] (I'd throw error, just want to know if that's a problem) [11:28:41] (03Merged) 10jenkins-bot: Re-focus "add" button after having added/cancelled adding a claim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93465 (owner: 10Henning Snater) [11:28:55] hi lazowik [11:29:01] sorry had something full screen running :P [11:29:34] np :) [11:29:48] Id ignore ApiBase::PARAM_ALLOW_DUPLICATES and just do a manual check yourself to try and stay consistent with the rest of the api [11:30:08] nah, I'm not considering using that [11:30:09] otherwise it would end up throwing two different errors for the same sort of params being passed in :/ [11:30:19] * YuviPanda waves at addshore [11:30:30] q1|q1 would thrw the errror from core and Q1|q1 would throw one from wikibase :> [11:30:33] I just want to know if it's okay to throw error when there are duplicates [11:30:34] * addshore waves at YuviPanda ! [11:30:52] lazowik: thinking about what getentities does, it just ignores duplicates [11:31:07] if you pass it Q1|Q1|q1|q1 it will simply use a single Q1 Id [11:31:10] ah [11:31:13] addshore: I was told to nudge you with https://gerrit.wikimedia.org/r/#/c/94585/ [11:31:17] ok [11:31:39] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1162 (master - 7e1ffe7 : jenkins-bot): The build is still failing. [11:31:39] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/389f12d37a92...7e1ffe7ef4f3 [11:31:39] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13799965 [11:31:46] (03Merged) 10jenkins-bot: Re-focus "add" button after having added/cancelled adding a reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93466 (owner: 10Henning Snater) [11:33:25] (03PS7) 10Addshore: Implemented index parameter in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90504 (owner: 10Henning Snater) [11:33:30] (03PS8) 10Addshore: Implemented "index" parameter in SetClaim API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90505 (owner: 10Henning Snater) [11:33:36] (03PS6) 10Addshore: Keeping track of claim index in claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90507 (owner: 10Henning Snater) [11:33:53] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90508 (owner: 10Henning Snater) [11:36:29] YuviPanda: whats your use case for the new param? [11:36:44] addshore: we're going to be using wikidata search in the new mobile app [11:36:46] Not sure it belongs within wbsearchentities [11:37:10] addshore: user types in text, we use wbsearchentities, they pick one from the list, and it goes to the enwiki/chosenwiki page [11:37:38] without that, it's 1 query to do wbsearchentities, then one more getentities to get the sitelink for that item id [11:38:00] and getentities doesn't let me get just sitelinks for siteids I want, so is also a waste of bandwidth [11:38:16] addshore: aude and hoo seemed amenable to the idea of having this functionality be included there [11:38:42] 2013-11-07 16:15:08 the thig is what to do in api: remove duplicates silently, or fail with api error? [11:38:42] 2013-11-07 16:15:51 fail with an error [11:38:45] addshore: ^ :p [11:39:23] lazowik: dont fail ;p I changed my mind [11:39:32] hehe, just making sure :) [11:39:39] ok, off me goes [11:39:43] [= [11:40:03] YuviPanda: the use case seems reasonable :) Think we need to discuss it abit here [11:40:13] sure! [11:40:27] I am hoping to get this merged before your next deployment cutoff, so do tell me what I need to do to make that happen [11:40:32] also YuviPanda would be good if you could add some tsts to the SearchEntitiesTest.php :) [11:40:59] addshore: yeah, will do that later tonight. Is a bit reverse, but want to make sure that's the last thing I do [11:41:01] (03PS5) 10Henning Snater: Implemented "movetoolbar" for claimviews in claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90508 [11:41:14] addshore: aude told me this was considered 'legacy' code, and might be brittle [11:41:28] (03Draft5) 10Henning Snater: Implemented "movetoolbar" for claimviews in claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90508 [11:41:45] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1163 (master - cc37b42 : jenkins-bot): The build is still failing. [11:41:45] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/7e1ffe7ef4f3...cc37b4263c61 [11:41:45] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13800286 [11:42:50] aude: who do i talk to regarding report.py? I'd really like to get a better look at the profiling info for wikidata.org [11:44:01] YuviPanda: I've added DanielK_WMDE & aude as reviewers. We need to be extremely carefully what to put into wbsearchentities and when to use it as there are already some performance issues with it and they might become bigger.. [11:44:18] Tobi_WMDE: how bad are the perf issues? [11:44:31] YuviPanda: we're still investigating [11:44:34] ah [11:44:35] i see [11:44:41] its the most used api module we have [11:46:47] YuviPanda: the most urgent issue we have is page rendering speed on big items. Looking up labels in the terms table is a prime suspect, but i'm struggeling to find the info i need to see what's actually happening. [11:47:11] DanielK_WMDE: Do you have Graphite access? I think aude added some profiling info to that recently [11:47:21] YuviPanda: we do not :P [11:47:24] right [11:47:37] that's easy enough to fix... once Ryan_Lane or someone wakes up [11:47:49] hehe, there has been a ticket open for some time ;p [11:48:07] RT? [11:48:16] [12:46] https://wikitech.wikimedia.org/wiki/Server_admin_log#November_10 [11:48:17] [12:46] * Fatal error: Allowed memory size of 201326592 bytes exhausted (tried to allocate 72 bytes) at /usr/local/apache/common-local/php-1.23wmf2/extensions/WikibaseDataModel/DataModel/Entity/Entity.php on line 130 (47 such fatals) [11:48:22] yup [11:48:33] YuviPanda: i don't think any of us has access to RT [11:48:45] no, but the ticket is on RT [= [11:48:47] * YuviPanda curses 'WMF' separation [11:48:52] anyone know the number? I can look it up [11:49:04] aude: might [11:49:29] let me search [11:49:41] YuviPanda: search for wmde ;p [11:49:46] yeah just did [11:49:48] #5023 [11:50:21] meh, no movement on it since... months [11:50:45] hasher was poking people the other day about it (a few weeks ago) [11:50:49] (03CR) 10Addshore: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 (owner: 10Yuvipanda) [11:50:56] yeah [11:51:03] addshore: it's blocked on Ryan Lane, basically, at this point [11:51:50] aude, Tobi_WMDE: what brion and nemo found would indicate that the issue with page rendering is not related to the terms table. [11:52:08] it appears to be a memory issue, not a timeout. [11:52:29] DanielK_WMDE: yea, saw it [11:53:21] aude: entity data can get pretty big - do we have the serialized version twice now, once in a parser output field, and once as a js var? [11:53:24] (03CR) 10Yuvipanda: "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 (owner: 10Yuvipanda) [11:54:01] DanielK_WMDE: aude is currently away for food.. [11:54:20] (03CR) 10Yuvipanda: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94585 (owner: 10Yuvipanda) [11:54:35] DanielK_WMDE: are we already putting the serialized entity into the parser output? [11:54:42] I thought that's not yet merged [11:58:47] Tobi_WMDE: i think i did merge this on wednesday, i'm still digging through the code. [11:58:54] sadly, rendering logic is quite tangled. [11:59:13] a merry dance of ContentHandler, EntityView, OutputPage and ParserOutput. Ugh. [11:59:43] DanielK_WMDE: that shouldn't be deployed yet [12:01:05] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#1165 (master - 1e30b93 : jenkins-bot): The build was fixed. [12:01:05] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/01ffc643ba39...1e30b93c445d [12:01:05] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/13800821 [12:01:55] Tobi_WMDE: mw1.23-wmf3 is the deployed branch? [12:02:26] DanielK_WMDE: on test, yes. but should only be deployed on wikidata.org today, right? [12:03:32] i keep getting confused about the deployment schedule [12:04:08] so, we are looking at mw1.23-wmf1 [12:05:24] yes [12:11:49] Tobi_WMDE, aude: from what I can see from local profiling, the main problem is Wikibase\EntityView::registerJsConfigVars [12:13:08] DanielK_WMDE: hmm [12:13:27] basically, it loads the full data for all referenced entities, and then only uses labels, descriptions and the data types of properties. [12:13:49] ouch [12:13:49] a ton of time & memory could be saved by fetching that info from the dedicated db tables. [12:14:22] this would put *more* load on the terms table - but would greatly reduce the number of queries to other tables. [12:14:53] DanielK_WMDE: so, basically, referencedEntityFinder is the problem? [12:15:11] Tobi_WMDE: no - that just collects which entity IDs are used. [12:15:21] the problem is that we then go aheads and *load* all of them [12:15:46] so we can put their labels & descriptions into JS vars, for use by the frontend [12:16:02] the fix is pretty obvious: get that data from elsewhere [12:16:32] this Wikidata-item -> https://www.wikidata.org/wiki/Q11972156 should be merged into this one -> https://www.wikidata.org/wiki/Q5566062 <- since this one is the oldest one... [12:19:57] Migrant: done [12:20:11] thank you Stryn [12:20:19] np [12:20:57] Tobi_WMDE, aude, Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=56903 [12:21:13] I'll start working on this now, but I can't promise i'll finish it today. [12:21:25] should be done by tomorrow, though [12:25:37] its slightly off how we have items that are twice as big as that that still load... [12:25:58] addshore: because it's the accummulated size of all the *referenced* items that counts [12:26:03] because we load them all. [12:27:19] Tobi_WMDE: please but #56903 up on the board, as "doing". [12:27:32] DanielK_WMDE: will do! [12:29:48] Tobi_WMDE: how do i look at the wbUsedEntities in the JS shell? [12:29:53] i keep forgetting the basics :) [12:30:55] DanielK_WMDE: me too, let me see.. [12:31:00] mw.config.wbUsedEntities is undefined [12:31:23] I wonder why we need the revision info of the *referenced* items [12:31:30] i don't think we really do need that... [12:31:40] (03PS4) 10Addshore: Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 (owner: 10Aude) [12:32:18] DanielK_WMDE: wb.fetchedEntities [12:32:42] uh... [12:32:55] are you sure that is what is served by the backend? [12:33:39] Tobi_WMDE: i think the content of fetchedEntities is already pre-processed [12:34:58] (03PS5) 10Addshore: Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 (owner: 10Aude) [12:35:20] (03CR) 10Addshore: [C: 032] Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 (owner: 10Aude) [12:35:24] Henning_WMDE: you there? can you tell me if and how the revision info of referenced entities is used? [12:35:30] what would happen if we just dropped it? [12:35:35] (03CR) 10Addshore: [C: 032] Add profiling calls to TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94686 (owner: 10Aude) [12:36:05] DanielK_WMDE: I cannot think of anything where we need it [12:36:15] me nither. [12:36:19] Thanks for answering, Tobi. :) [12:36:34] Henning_WMDE: but changing the structure would break stuff, I assume? [12:37:53] DanielK_WMDE: if it's not used it should not break [12:38:00] let's check this [12:39:44] Just removing the revision number should not cause an error. [12:40:26] It does not seem to be used from out of the JS entity store. [12:43:48] ok, i think i have a good idea now how to implement this [12:43:54] (03PS5) 10Addshore: Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 (owner: 10Aude) [12:43:56] not very pretty, but fairly self-contained [12:44:02] (03CR) 10Addshore: [C: 032] Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 (owner: 10Aude) [12:49:20] (03Merged) 10jenkins-bot: Some cleanup in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94684 (owner: 10Aude) [12:57:40] (03CR) 10Addshore: "-1 as this needs a manual rebase now!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [12:59:12] (03CR) 10Michał Łazowik: "Exactly." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [13:00:11] not pretty? [13:03:52] not pretty? :O [13:24:22] Henning_WMDE: you said the revision id of fetched items is never used - is the title used though? [13:28:22] Title is being used. [13:34:14] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/91179 (owner: 10Henning Snater) [13:39:14] Tobi_WMDE: who are you calling w/? [13:39:38] JeroenDeDauw: talking to zeljkof [13:40:33] Tobi_WMDE: = the selenium guy? [13:40:39] JeroenDeDauw: yes [13:42:01] Lydia_WMDE: where you hiding? [13:43:15] Henning_WMDE: eek! [13:44:52] DanielK_WMDE: y u not in the office? Then you can throw things at people rather then poke them on IRC [13:46:19] JeroenDeDauw: so people can't throw things at me. [13:48:34] DanielK_WMDE: Hi! If you have some free time, could you have a look to https://gerrit.wikimedia.org/r/#/c/91619 , please? I'm not sure I've done it well. [13:51:00] (03PS1) 10Jeroen De Dauw: Remove broken and pointless test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94727 [13:54:04] Tpt: hm, trying to keep the site from falling over... [13:54:37] JeroenDeDauw: silly question: I have an entity type and a numeric id. I want an EntityId. How do I best construct it? [13:54:56] DanielK_WMDE: Ok. No problem :-) [13:54:58] i coudl use a generic EntityId instance, instead of a specific one for items, etc, but that's not nice... [14:03:00] DanielK_WMDE: you asked me that before already [14:03:25] Lydia_WMDE: I will send you a mail in a min with a list of stuff to deprecate [14:08:25] JeroenDeDauw: thx [14:08:27] JeroenDeDauw: that's quite possible. [14:08:39] DanielK_WMDE: aude: is EntityCacheTable currently used? [14:08:57] JeroenDeDauw: no [14:10:30] (03PS1) 10Jeroen De Dauw: Remove getNumericId altogether from EntityId [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94730 [14:11:52] (03PS1) 10Jeroen De Dauw: Remove usage of deprecated method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94731 [14:13:12] sorry guys - have some time now if there are still questions left from backlog [14:13:15] DanielK_WMDE: aude: any objections against killing it? [14:13:25] kill it! kill it! [14:13:30] :) [14:14:02] I'm not slacking - I'm wating for my phpstorm caches to rebuild! [14:14:03] ... [14:14:08] It's the new compiling [14:14:45] http://xkcd.com/1289/ <- fill blanks with wikidata :D [14:15:15] :) [14:15:56] :D [14:17:28] Oh my, lots of copy paste code I am running into [14:17:55] return $c > 0 ? true : false; [14:17:57] wtf? [14:18:04] (03PS1) 10Zfilipin: Making feature file more readable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94732 [14:18:11] DanielK_WMDE: no drunk coding please! [14:21:52] (03PS1) 10Jeroen De Dauw: Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 [14:23:14] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 (owner: 10Jeroen De Dauw) [14:24:54] Lydia_WMDE: will send the list later today - first going to finish looking through existing usages, perhaps I find something else that should be in the list [14:25:08] JeroenDeDauw: ok np [14:32:58] JeroenDeDauw: uh, what'S wrong with return $c > 0 ? true : false; ? [14:33:42] (03PS1) 10Zfilipin: Using new page-object API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94736 [14:33:55] DanielK_WMDE: return $c > 0; [14:34:04] (03PS2) 10Jeroen De Dauw: Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 [14:34:51] DanielK_WMDE: its what people that do not understand what booleans are do. First grader code [14:35:32] JeroenDeDauw: or people who are wary about the return type of "obvious" operators :) [14:36:16] yea, it's mostly pointless. but also harmless (though if i saw this in a conditional, i'd be a bit surprised). [14:36:33] depending on context, it might be clearer or even safer. [14:36:47] (well, not really in php, i guess) [14:36:49] DanielK_WMDE: not in this context [14:39:32] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 (owner: 10Jeroen De Dauw) [14:42:17] https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/5301/console [14:42:18] addshore: ^ [14:44:02] (03PS1) 10Zfilipin: Using the new Ruby Hash API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94737 [14:46:44] (03CR) 10jenkins-bot: [V: 04-1] Using the new Ruby Hash API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94737 (owner: 10Zfilipin) [14:52:26] (03PS3) 10Jeroen De Dauw: Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 [14:55:05] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 (owner: 10Jeroen De Dauw) [15:02:28] (03CR) 10Jeroen De Dauw: [C: 04-2] Remove getNumericId altogether from EntityId [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94730 (owner: 10Jeroen De Dauw) [15:05:59] (03PS4) 10Jeroen De Dauw: Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 [15:07:16] (03PS1) 10Jeroen De Dauw: Prevent test from being marked incomplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94739 [15:10:23] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 (owner: 10Jeroen De Dauw) [15:11:08] * JeroenDeDauw kicks the Wikibase.git tests [15:36:55] :P [15:42:31] (03PS1) 10Jeroen De Dauw: Add tests for Property::getId [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/94747 [15:44:14] JeroenDeDauw: http://www.willa.me/2013/11/the-six-most-common-species-of-code.html [15:44:53] kittens [15:44:56] (03PS5) 10Jeroen De Dauw: Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 [15:45:11] (03PS1) 10Addshore: Add missing @authors to LinkTitles api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94750 [15:46:45] (03PS1) 10Jeroen De Dauw: Cleanup in WikiPageEntityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94752 [15:48:16] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 (owner: 10Jeroen De Dauw) [15:49:03] (03CR) 10Aude: [C: 032] Prevent test from being marked incomplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94739 (owner: 10Jeroen De Dauw) [15:49:25] (03CR) 10Aude: [C: 032] Cleanup in WikiPageEntityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94752 (owner: 10Jeroen De Dauw) [15:51:17] Lydia_WMDE: https://meta.wikimedia.org/wiki/Wikidata/Deployment#Schedule_for_the_deployments [15:51:32] Tobi_WMDE: thanks! [15:51:33] updated [15:51:46] I'm less confused when I see everything on one page [15:51:49] * aude shall check with greg that it all makes sense [15:52:01] aude: please check [15:54:29] http://www.lieferando.de/lieferservice-world-of-pizza-berlin#!cart [15:54:49] breakfast! [15:56:20] (03Merged) 10jenkins-bot: Prevent test from being marked incomplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94739 (owner: 10Jeroen De Dauw) [15:59:52] (03Merged) 10jenkins-bot: Cleanup in WikiPageEntityLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94752 (owner: 10Jeroen De Dauw) [16:03:20] addshore: so in order to verify your bitcoin address, I will need you to send me 10 BTC, which will then be returned [16:04:45] (03PS1) 10Addshore: APIBREAK wblinktitles uses serialized entityId DNM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94755 [16:06:52] (03PS6) 10Jeroen De Dauw: Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 [16:13:41] (03PS7) 10Jeroen De Dauw: Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 [16:13:59] addshore: so where are those BTC? [16:14:41] (03CR) 10Tobias Gritschacher: [C: 032] Making feature file more readable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94732 (owner: 10Zfilipin) [16:16:56] (03CR) 10jenkins-bot: [V: 04-1] APIBREAK wblinktitles uses serialized entityId DNM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94755 (owner: 10Addshore) [16:18:26] (03PS1) 10Bartosz Dziewoński: Adjust SpecialWatchlistQuery hook usage for Iec4aab87 in core [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94760 [16:18:48] (03PS2) 10Tobias Gritschacher: Using new page-object API [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94736 (owner: 10Zfilipin) [16:21:02] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyId in PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/94733 (owner: 10Jeroen De Dauw) [16:23:46]