[07:06:57] good morning [09:00:36] Lydia_WMDE: ping [09:28:52] lbenedix1 she is still off line [09:30:30] lbenedix1: she just walked in [= [09:31:02] Everyone hide! [09:33:19] (03Abandoned) 10Addshore: Wikidata Build from 12:00 09.OCT.2013 DNM [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/88701 (owner: 10Addshore) [09:37:49] lbenedix1: hey [09:44:46] (03PS12) 10Addshore: Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 [09:45:15] (03PS1) 10Jeroen De Dauw: Add a nice diagram [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/93663 [09:45:42] (03PS13) 10Addshore: Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 [09:46:25] (03CR) 10Addshore: [C: 032] Add a nice diagram [extensions/Serialization] - 10https://gerrit.wikimedia.org/r/93663 (owner: 10Jeroen De Dauw) [09:47:48] (03PS9) 10Addshore: Implement List Serializer and Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92873 [09:51:34] (03PS10) 10Addshore: Implement List Serializer and Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92873 [09:51:53] (03PS5) 10Addshore: Add byPropertyListSerialization Options [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92916 [09:52:09] rebase ALL of the commits [09:52:32] and follow up :DF [09:53:54] (03CR) 10Addshore: "The tests requested are added in the commit that depends on this" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92916 (owner: 10Addshore) [09:54:15] (03PS5) 10Addshore: Accept both types of lists when deserializing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93044 [09:54:25] (03CR) 10jenkins-bot: [V: 04-1] Implement List Serializer and Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92873 (owner: 10Addshore) [09:56:49] (03CR) 10jenkins-bot: [V: 04-1] Add byPropertyListSerialization Options [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92916 (owner: 10Addshore) [09:59:10] (03CR) 10jenkins-bot: [V: 04-1] Accept both types of lists when deserializing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93044 (owner: 10Addshore) [10:05:19] * DanielK_WMDE_ wibbles [10:05:49] Tobi_WMDE, aude: daily? [10:09:52] hi DanielK_WMDE_ [10:10:08] we forgot you ..... [10:10:34] sorry :) [10:10:57] * DanielK_WMDE_ sulks [10:11:10] ouchi ouchi ... [10:11:33] so, i just found we are missing an important component for quantity support: [10:11:44] there's no formatter [10:11:55] i'll write one over the next hour or two. [10:12:46] ok [10:13:42] basically, it's me, addshore and henning today (and lydia) [10:14:45] * addshore dislikes tests that pass locally and fail on jenkins [10:14:47] addshore: what happened to the SetStatementRank module? [10:14:51] have I ever told anyone that? [10:14:55] i think we killed it [10:14:57] DanielK_WMDE_: that got nuked a while back [10:15:23] ok - then i better kill SetStatementRankTest.php while rebasing my patch :) [10:15:32] haha!! [10:15:46] how old is this patch? :P [10:16:21] if anyone can make this pass I will give them chocolate >> https://gerrit.wikimedia.org/r/#/c/92873/ .... [10:16:49] * aude has own chocolate :) [10:16:54] =[ [10:17:00] * addshore takes audes chocolate [10:17:04] hah [10:18:14] addshore: https://gerrit.wikimedia.org/r/#/c/89810/ [10:18:22] just a draft, there are a couple of fixmes [10:18:33] would be nice to get some feedback on this though [10:18:48] (especially from jeroen, wrt the pending entity redesign) [10:18:50] ah, that one [10:19:05] i rebased and polished it a bit [10:21:34] oh! Henning_WMDE did write a QuantityFormatter! [10:21:43] I'll extend that a bit, then [10:21:45] \o/ [10:22:05] ...and write tests :) [10:24:52] II HATE THIS LEAKY THINGS! :< [10:32:52] I needed some kind of QuantityFormatter placeholder for the UI to attach to. Needs to be extended of course... [10:35:17] addshore: lets just "accidentally" delete Wikibase.git [10:36:20] :O [10:40:46] (03CR) 10Addshore: "I have no idea what to do or how to hunt down these failures..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92873 (owner: 10Addshore) [10:40:53] * addshore admits defeat.. [10:57:25] (03PS4) 10Aude: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 [11:00:06] (03CR) 10jenkins-bot: [V: 04-1] Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [11:05:44] (03PS5) 10Aude: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 [11:05:47] (03CR) 10Addshore: [C: 032] Move Entity specific classes into EntityStore NS [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/93427 (owner: 10Jeroen De Dauw) [11:06:12] (03CR) 10jenkins-bot: [V: 04-1] Move Entity specific classes into EntityStore NS [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/93427 (owner: 10Jeroen De Dauw) [11:07:40] (03CR) 10Addshore: [V: 032] Move Entity specific classes into EntityStore NS [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/93427 (owner: 10Jeroen De Dauw) [11:08:35] (03CR) 10jenkins-bot: [V: 04-1] Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [11:11:23] (03PS6) 10Aude: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 [11:17:17] (03CR) 10Addshore: [C: 032] Style cleanup in WikibaseClient hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92161 (owner: 10Aude) [11:17:23] (03CR) 10jenkins-bot: [V: 04-1] Style cleanup in WikibaseClient hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92161 (owner: 10Aude) [11:17:30] wtf [11:17:41] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92161 (owner: 10Aude) [11:18:02] (03PS6) 10Addshore: Implemented index parameter in ChangeOpClaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90504 (owner: 10Henning Snater) [11:18:07] (03PS7) 10Addshore: Implemented "index" parameter in SetClaim API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90505 (owner: 10Henning Snater) [11:21:42] (03PS2) 10Addshore: TODO for bug 54021, Snakview should not switch between edit modes on its own! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92310 (owner: 10Daniel Werner) [11:21:54] (03CR) 10Addshore: [C: 032] TODO for bug 54021, Snakview should not switch between edit modes on its own! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92310 (owner: 10Daniel Werner) [11:22:50] (03PS30) 10Addshore: Extend API to support editing badges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [11:25:44] (03PS2) 10Aude: Style cleanup in WikibaseClient hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92161 [11:28:26] (03Merged) 10jenkins-bot: TODO for bug 54021, Snakview should not switch between edit modes on its own! [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92310 (owner: 10Daniel Werner) [11:30:06] (03CR) 10Addshore: [C: 04-1] "-1 When using setsitelink and passing in a badges parameter such as 'Q3|q3' we end up with duplicate badges." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 (owner: 10Michał Łazowik) [11:33:27] (03CR) 10Addshore: [C: 032] Style cleanup in WikibaseClient hooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92161 (owner: 10Aude) [11:36:19] (03PS5) 10Addshore: Cleanup and improve RepoLinker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91601 (owner: 10Aude) [11:36:25] (03CR) 10Addshore: [C: 032] Cleanup and improve RepoLinker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91601 (owner: 10Aude) [11:39:14] (03PS2) 10Addshore: (bug 44876) add a table of content to item pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90755 (owner: 10Bene) [11:41:20] (03CR) 10Addshore: "It would be nice if http://grab.by/rKYi could look slightly nicer with the TOC and [Mark this page as patrolled] both trying to use the sa" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/90755 (owner: 10Bene) [11:41:57] (03Merged) 10jenkins-bot: Cleanup and improve RepoLinker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/91601 (owner: 10Aude) [11:42:56] (03PS9) 10Aude: Factor out getHtmlForClaim from EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72909 (owner: 10Pragunbhutani) [11:54:15] (03PS1) 10Addshore: Fix use.. in setclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93676 [11:54:16] aude ^^ :D [11:54:36] oooh [11:55:20] fixes a bug I was just about to file xD [11:56:02] (03CR) 10Addshore: "Fixes a Fatal error: Class 'Wikibase\Api\IllegalValueException' not found in" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93676 (owner: 10Addshore) [11:56:58] * aude wonders where jenkins is [11:58:33] (03CR) 10Aude: [C: 032] Fix use.. in setclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93676 (owner: 10Addshore) [12:01:56] (03Merged) 10jenkins-bot: Fix use.. in setclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93676 (owner: 10Addshore) [12:12:32] (03PS1) 10Addshore: Fix more missing use statements in /api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93679 [12:23:36] hmm aude, I guess I shouldnt seeing Added a language link to connect pages [↔$3]: rowiki:Poletinți, Kiustendil, bgwiki:Полетинци in recent changes? :d [12:23:45] any idea if thats been fixed already? [12:25:04] odd [12:25:23] in repo? [12:25:45] addshore: ^ [12:25:50] yup [12:26:17] hmmmm [12:26:40] oh, that sounds like the widget [12:27:29] i wonder which api module it uses... i think linkitems [12:27:32] wblinkitems [12:38:31] (03CR) 10Aude: [C: 032] Fix more missing use statements in /api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93679 (owner: 10Addshore) [12:41:58] (03Merged) 10jenkins-bot: Fix more missing use statements in /api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93679 (owner: 10Addshore) [12:42:19] aude: does test.wikidata have a test client linked to it? and if so whats the siteid? [12:42:33] not yet but will be test2 [12:42:45] test2wiki [12:43:08] or it might be there actually [12:43:25] nope :< [12:43:32] but not hooked the other way [12:43:36] oh [12:43:57] on my todo :) [12:46:52] hmm, will the whole moving pages thing work on test.wikidata aude? :P [12:47:03] when i set it up [12:47:13] I mean if I move stuff on enwiki ;p [12:47:35] moving stuf on test2 does not affect anything [12:47:44] stuff* [12:47:50] configured that way [12:48:02] no if I add a sitelink on test to enwiki, then move the page on enwiki, will test.wikidata be updated? :P [12:48:09] nope [12:48:10] or shall I go and do this testing on the live site? ;p [12:48:13] okay [= [12:48:22] if you move a page on enwiki, then wikidata is updated [12:48:31] we don't have it possible for the client to have 2 repos [12:48:47] test.wikidata should be the repo for test2 [12:49:10] although it might break some pages on test2 [12:49:11] cant add sitelinks for test2 though :) [12:49:31] true [12:49:43] what are you trying to test? [12:49:52] ill tell you if it works ;p [12:49:57] ok [12:56:59] aude: test ended up working as expected which is good [= are any of beta labs setup as client and repo ? ;p [12:59:22] * aude doing [12:59:30] :D [13:08:20] Hi are there some Authority Control contributors / experts here? [13:18:33] JeroenDeDauw: wikibase database is gone from gerrit? [13:24:09] DanielK_WMDE_: can you approve https://gerrit.wikimedia.org/r/#/c/93687/ please ? [13:44:20] [travis-ci] wmde/WikibaseDatabase#15 (FieldDefinition.AssertIsValidNull-fix - 9df1c70 : addshore): The build has errored. [13:44:20] [travis-ci] Change view : https://github.com/wmde/WikibaseDatabase/commit/9df1c70d6d85 [13:44:20] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDatabase/builds/13525115 [13:50:51] [travis-ci] wmde/WikibaseDatabase#15 (FieldDefinition.AssertIsValidNull-fix - 9df1c70 : addshore): The build has errored. [13:50:51] [travis-ci] Change view : https://github.com/wmde/WikibaseDatabase/commit/9df1c70d6d85 [13:50:51] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDatabase/builds/13525115 [13:56:27] [travis-ci] wmde/WikibaseDatabase#15 (FieldDefinition.AssertIsValidNull-fix - 9df1c70 : addshore): The build passed. [13:56:27] [travis-ci] Change view : https://github.com/wmde/WikibaseDatabase/commit/9df1c70d6d85 [13:56:27] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDatabase/builds/13525115 [14:12:32] (03PS1) 10Daniel Kinzler: Implementing proper formatting for quantity values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 [14:26:03] (03PS1) 10Daniel Kinzler: Fix builder for QuantityFormatter (constructor changed) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93697 [14:26:34] (03PS2) 10Daniel Kinzler: Fix builder for QuantityFormatter (constructor changed) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93697 [14:26:45] (03CR) 10jenkins-bot: [V: 04-1] Fix builder for QuantityFormatter (constructor changed) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93697 (owner: 10Daniel Kinzler) [14:26:58] (03CR) 10jenkins-bot: [V: 04-1] Fix builder for QuantityFormatter (constructor changed) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93697 (owner: 10Daniel Kinzler) [14:27:41] (03PS2) 10Daniel Kinzler: Implementing proper formatting for quantity values. [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/93694 [14:29:18] aude: looking now [14:30:55] [travis-ci] wmde/WikibaseDatabase#17 (FieldDefinition-coverage - 18cf8da : addshore): The build has errored. [14:30:55] [travis-ci] Change view : https://github.com/wmde/WikibaseDatabase/commit/18cf8daa13b0 [14:30:55] [travis-ci] Build details : http://travis-ci.org/wmde/WikibaseDatabase/builds/13527318 [14:32:35] DanielK_WMDE_: probably hashar should look [14:32:45] i wonder if it's that simple :) [14:42:12] aude: i guess it is this simple, but i don't know enough about the setup to give a +2 [14:43:33] DanielK_WMDE_: ok [14:45:13] (03PS1) 10Aude: Check Wikidata build install path for dispatchChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93711 [14:45:41] DanielK_WMDE_ addshore or anyone, can you please look at https://gerrit.wikimedia.org/r/#/c/93711/ and https://bugzilla.wikimedia.org/show_bug.cgi?id=56618 [14:45:51] i wonder if there is a better way than that? [14:46:29] (03CR) 10Aude: "if we can't come up with a better way, then all the other maintenance scripts should be updated similarly as here." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93711 (owner: 10Aude) [14:54:50] aude: when is that causing a problem? [14:54:59] addshore: running the dispatcher? [14:55:02] or any script [14:55:27] maybe windows sets MW_INSTALL_PATH [14:56:53] nope, it doesnt for me [14:57:07] but you only get this when trying to run thing from the wikidata repo right? [14:57:12] yes [14:57:18] everything in production has MW_INSTALL_PATH set [14:57:34] or so i have been told [14:57:38] yes but do we want to rely on that and require everyone using the build to set it? [14:57:50] yes :P [14:57:55] there is no other nice way of doing it :D [14:57:56] evil! [14:58:25] we had this problem initally running the tests on jenkins until hashar added it :) [14:58:49] so what if i have multiple wikis using the build? [14:58:56] https://gerrit.wikimedia.org/r/#/c/89168/ https://gerrit.wikimedia.org/r/#/c/89838/ [14:58:56] in different install directories? [14:59:24] Not sure I quite follow.. [14:59:38] if a wiki is using the build, the build will be in the wikis install path [14:59:49] how? [15:00:00] well, its in the extensions dir :P [15:00:28] no wikibase is in a sub sub directory [15:03:05] hmmmmm [15:03:29] (03CR) 10Jeroen De Dauw: [C: 04-1] "This path is based on MW_INSTALL_PATH. So it should always be the same as it refers to a core file no?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93711 (owner: 10Aude) [15:03:30] the maintenance scripts are directly called [15:04:21] this is used in all maint scripts at the top to [15:04:21] require_once $basePath . '/maintenance/Maintenance.php'; [15:04:35] if the install path is set there is no issue [15:04:58] then the maintenance scripts need to be wrapped in something [15:05:05] that sets MW_INSTALL_PATH [15:05:05] why?? [15:05:11] they do not work directly [15:05:19] wmf has a wrapper [15:05:21] MW_INSTALL_PATH should just be set though.. [15:05:26] no [15:06:03] why not? :P [15:06:59] if anything we should just make core force set the ENV var if it isnt set [15:07:02] * aude makes a wrapper [15:07:10] personally I think its silly that it isnt done already.. [15:07:24] addshore: these scripts *are* the entry point [15:07:28] it does not know about core yet [15:07:45] true! hence MW_INSTALL_PATH should be set xD [15:07:56] the scripts can't be directly run [15:08:13] they can if MW_INSTALL_PATH is set :P [15:08:35] * aude has a bazillion wikis in a bazillion install paths :) [15:08:57] there is no single install path [15:09:06] no, there is an install path per wiki ~:P [15:09:07] wmf also has multiple install paths [15:09:19] meh, these maint scripts are ugly :P [15:09:36] * aude gives up for now [15:09:37] maybe recursivly go back through the folders until you find the parent maintenance folder? :d [15:10:11] also whatever you do will have to be changed in all maintanence files within the build then I guess [15:11:36] (03CR) 10Aude: "what core file? these scripts are the entry point. they know nothing about core at time they are called." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93711 (owner: 10Aude) [15:16:32] Lydia_WMDE: you changed the severity of this https://bugzilla.wikimedia.org/show_bug.cgi?id=49554 what is the implication ? [15:17:22] GerardM: that it moves up on my list of things to do [15:18:21] Lydia_WMDE: I had an idea yesterday... logging the error messages in the UI... the red boxes like "An error occurred while trying to perform save and because of this, your changes could not be completed." [15:18:49] as far as I know you dont do that at the moment [15:21:13] i think we don't indeed [15:22:22] would be good to know what problems users go through [15:23:07] * Lydia_WMDE points lbenedix1 to the 500+ bugs in bugzilla for the answer to that :P [15:23:35] there are only ~400 open bugs ;) [15:23:55] you're missing products then [15:25:26] right [15:26:16] nevertheless is it important for user satisfaction to know what errors occur [15:29:12] Lydia_WMDE: we should tidy up out bugzilla! [15:29:20] we have Wikimedia/Wikidata [15:29:37] Extensions/WikibaseRepo and Extensions/WikibaseClient [15:29:40] its all ewwwwwy [15:33:21] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93711 (owner: 10Aude) [15:33:22] hello there. Was wondering what happened to WikibaseDatabase extension ? [15:35:19] (03CR) 10Daniel Kinzler: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72909 (owner: 10Pragunbhutani) [15:35:20] it hasn't been removed from mediawiki/extensions.git :/ [15:35:55] hashar: https://gerrit.wikimedia.org/r/#/c/93687/ [15:37:04] holy hell [15:38:00] that is a dependency for some other extensions [15:38:33] hence https://gerrit.wikimedia.org/r/#/c/93428/ [15:38:48] (03Merged) 10jenkins-bot: Factor out getHtmlForClaim from EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72909 (owner: 10Pragunbhutani) [15:38:59] which is crazy [15:39:56] ^^ JeroenDeDauw :D [15:42:22] hashar: not everyone things having more then one package is crazy [15:42:41] hashar: and our team is certainly moving away from that practice [15:45:38] (03CR) 10Daniel Kinzler: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [15:45:44] (03CR) 10jenkins-bot: [V: 04-1] Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [15:47:21] * aude kicks jenkins [15:47:27] =[ [15:49:01] poor Jenkins [15:49:27] (03CR) 10Daniel Kinzler: [C: 032] Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 (owner: 10Addshore) [15:49:35] (03PS5) 10Daniel Kinzler: Remove use of deprecated apibase result methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92636 (owner: 10Addshore) [15:49:50] (03CR) 10Daniel Kinzler: [C: 032] Remove use of deprecated apibase result methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92636 (owner: 10Addshore) [15:53:23] (03Merged) 10jenkins-bot: Implement Api ResultBuilder and basic tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84990 (owner: 10Addshore) [15:53:54] addshore: JeroenDeDauw: there one sure thing is that if QueryEngine rely on WikibaseDatabase, then WikibaseDatabase has to be hosted on Gerrit for Wikimedia deployment. Unless we accept using github which I doubt. [15:54:04] that should be double checked with greg-g / reedy [15:54:19] mmm [15:54:23] Yeah, we can't use external reapos [15:54:25] *repos [15:54:54] which should even run git using a null http/https proxy to make sure it dies horribly whenever someone add an external dep :D [15:55:25] I tried to do that before (url-downloader I think) but it didn't seem happy [15:55:47] to do what? restrict git? [15:56:12] make git use a proxy to get stuff from github etc [15:56:19] all_proxy=127.0.0.66 git ... [15:56:27] then you would never hit github [15:56:33] addshore: DanielK_WMDE_ https://gerrit.wikimedia.org/r/#/c/93737/ [15:56:41] as possible alternative [15:57:28] (03Merged) 10jenkins-bot: Remove use of deprecated apibase result methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/92636 (owner: 10Addshore) [15:57:33] that looks reasonable :D [15:57:43] addshore: i can tell you what the problem is with the mystery failure of https://gerrit.wikimedia.org/r/#/c/92873/ [15:57:50] what is it???? [15:57:51] we actually already discussed it last week [15:57:51] hashar: Reedy the plan is to creater a wikidata "build" where we assemble all the dependencies into one git repo on gerrit [15:58:29] ... [15:58:32] in that case, though we have submodules [15:58:42] so not sure how it works with github and being deployable [15:58:53] * hashar wears Tim hat: of course you could have kept all the code in the same extension instead of splitting them. [15:59:05] addshore: well, testNewFromSerializationInvalid tests with a paramewter that violates a type hint. that's triggers a PHP "fatal error". BY default, this would abort the script, but PHPUnit intercepts the error and converts it to an exception - which matches the setExpectedException stuff [15:59:06] well, then it's not very reusable [15:59:09] but the plan wasn't to move everything to github, though [15:59:34] bots, for example, can use all the data model code without needing mediawiki :) [15:59:39] addshore: HOWERVER, if any previous test messed with the error handler that PHPUnit injected, the violation of the type hint will gain be a "real" fatal error, and kill the script. [16:00:03] anyway, we need to do something like ULS where it syncs jquery.i18n into our stuff on gerrit [16:00:28] addshore: basically, don't write tests that expect fatal errors. Not until we can guarantee that nothing messes with the error handlers [16:01:32] DanielK_WMDE_: thats why I removed the testcase, and you then commented asking why I had removed it ;p [16:01:53] give me 2 ticks, I think there wa another issue :/ [16:01:53] greg-g: i think the idea is to open some of these generic libraries to a wider audience [16:01:56] addshore: well, in my comment i said to test *structurally* invalid input, instead of the wrong type [16:02:08] i was actually thinking about this exact problem when i wrote that :) [16:02:15] but we need to figure out how to incorporate them in a good way for wikidata [16:02:17] aude: yeah, but that doesn't mean leaving gerrit behind.... (I think we're on the same page here, we need the mirroring bit) [16:02:17] :D [16:02:29] greg-g: probably can't avoid [16:02:40] can't avoid...? [16:02:44] the mirroring bit? [16:02:48] having a mirror on gerrit [16:03:05] right, must have a mirror on gerrit for testing/deploy [16:03:15] addshore: quote: "test cases for failing type hints may cause phpunit to fail silently (if a previous test messed with the error reporting flags). It's probably not necessary to test this, but we should still test with structurally invalid input." [16:03:45] JeroenDeDauw: is that possible? can we maintain a mirror of these libraries on gerrit? [16:04:14] the canonical one can be github, like jquery.i18n but we need something accessible in deployment environment [16:04:28] hmm DanielK_WMDE_ I actually should be able to narrow down to identify which test is messing with the error handeling [16:05:05] aude: we would just need something that doesnt the oposite of what currently happens now with mirroring gerrity to github? [16:05:09] *does the [16:05:18] addshore: yep [16:05:25] would be good for easyRdf also [16:05:40] * aude no idea how to do but can't be difficult [16:06:11] just need a webhook on the github side I guess, and then something that pulls when it gets the webhook and then pushes to the gerrit repo [16:06:22] ok :) [16:07:03] sounds like it could be done in under 10 lines really ;p [16:07:08] cool [16:07:50] (03CR) 10Daniel Kinzler: [C: 031] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89607 (owner: 10Bene) [16:09:22] aude: mirror manually inside Gerrit whenever something is released I guess :D [16:09:26] DanielK_WMDE_: its one of the testcases in this log ;p http://pastebin.com/BxWPqPHh [16:09:53] hashar: probably [16:09:53] but hashar, why not a live mirror ? :D [16:09:54] aude: or use gerrit and mirror to github just like everything else. [16:10:18] addshore: cause you don't want someone to take over a github account, publish something, have it automatically replicated in Gerrit and magically deployed [16:10:36] addshore: the same could happen in Gerrit, but at least we would have trace / logs / actions possibles. [16:10:42] hashar: well, the idea is to open to wide [Drcontribitions [16:10:45] wider* [16:10:50] so I would recommend updating the Gerrit mirrors manually whenever a tag is released, should be good enough. [16:11:02] addshore: what is? for finding a failure, just look at the last test that got started but not finished :) [16:11:07] i suppose that could happen with jquery.i18n and mobile stuff on github [16:11:18] hashar: then beat would never be updated other than for releases :, [16:11:20] ;< [16:11:23] addshore: oh, you mean the one that mangled the handler [16:11:40] probably a good idea still to mirror to gerrit and verify/test there in addition to whatever we do with github [16:11:54] addshore: make hashar approve https://gerrit.wikimedia.org/r/#/c/74170/ :) [16:12:00] DanielK_WMDE_: well, the bypropertylistdeserializer has exactly the same testcase with type hint and it doesnt die there (at the top of the log) so something changes inbetween than been run and the listdeserializer(at the bottom of the list) [16:12:03] addshore: using a stable branch of these things would be fine [16:12:11] and update manually [16:12:16] i guess we'd need to expend this to include actual error handlers, not just the error-reporting level [16:12:20] but it would be a start [16:13:05] addshore: try to detect calls to register_shutdown_function - i guess that's what does it. [16:14:08] addshore: Maintenance and MaintenanceTest are likely candidates (I just grepped for register_shutdown_function) [16:14:32] other users include ObjectCacheSessionHandler and SyntaxHighlight_GeSHi [16:15:08] just eating atm but will take a look in a bit or in the morning :) [16:25:19] (03PS7) 10Aude: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 [16:25:42] (03PS8) 10Aude: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 [16:26:15] (03CR) 10jenkins-bot: [V: 04-1] Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [16:26:20] gah [16:30:18] (03PS9) 10Aude: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 [16:37:34] (03CR) 10Aude: "https://gerrit.wikimedia.org/r/#/c/93737/ as a possible alternative for installs that do not have MW_INSTALL_PATH set" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93711 (owner: 10Aude) [16:41:02] aude, addshore: why are we maintaining WikibaseDatabase on github now? [16:41:25] Fragmenting the code base over different maintenance systems with different workflows seems like an extremely bad idea... [16:43:52] DanielK_WMDE_: probably a question better for jeroen and tobi, but i think the idea is to make these components more open to contributors [16:43:57] and easier re-use [16:44:24] like done with jquery.i18n etc [16:44:31] mobile also [16:52:35] ;-( [16:53:23] +1 that's bad [16:55:43] aude: who made this decision, and when? is the reasoning documented? [16:56:04] well, i guess we best discuss this tomorrow [16:56:28] * aude is not best person to be answering, but think there was a wikidata tech mail about it [16:56:33] suggesting the idea [16:56:54] and been discussed before, with things like our js widgets [16:57:09] hm, i have to get better at sifting thourhg my mails :/ [16:57:20] heh [16:57:24] aude: yes, and for something small and isolated, it makes sense [16:57:41] that it still doesn't make me happy [16:57:51] probably good to discuss tomorrow [16:57:59] tobi is not here today and jeroen is on "vacation" [16:59:05] Can't we use that github - gerrit bidirectional sync bot thing? [16:59:12] i only see a mail informing us that the extension was moved to github. with no prior discussion. [16:59:15] * hoo would have suggested that, if asked [16:59:22] * aude hides [16:59:39] hoo: bi directional? :O [17:00:30] addshore: Indeed, comment from gerrit eg. will go to github, so that reviewing can solely happen on gerrit [17:00:38] Like we do with a local chance AFAIK [17:01:03] * comments change [17:01:30] DanielK_WMDE_: hoo in case you are not up-to-date on your mails, https://www.mediawiki.org/wiki/Architecture_meetings/RFC_review_2013-11-06 [17:01:54] kind of late for us but doable (for me at least), vs. the last one si couldn't make [17:02:24] No way, sorry... Wednesdays are very bad :P [17:02:42] hoo: :( [17:03:34] eek. 11PM. [17:03:39] yeah [17:03:50] well, my plans for tomorrow evening didn>'t work out anyway, so why not [17:03:50] I'm only getting home tomorrow at about 4pm... [17:03:57] the last ones were at 1 am and 8am (which i slept through) [17:04:09] Monday or Fridays would have been fine :/ [17:04:17] * aude almost made it at 1am :) [17:04:46] i think 11pm is what works for tim and SF, and barely for us [17:05:20] Someone is always the looser with time zones :/ [17:05:28] yeah [17:05:53] actually usually everyone is... nobody gets a decent time usually... just times that "work" [17:06:05] * aude nods [17:06:11] aude: thanks for the heads up though, i would have missed this [17:06:42] i almost missed it except browsing recent changes on mediawiki.org, which i do sometimes [17:06:54] I read it some days back but already knew I couldn't make it... thanks for letting me know, though... sometimes it's hard to stay on top of the mails [17:07:24] asked quim to send reminder to wikitech [17:07:39] time to fix dinner, bbl [17:07:47] k [17:10:54] oooh, i got a pawn [17:10:55] https://www.mediawiki.org/w/index.php?title=Architecture_meetings%2FRFC_review_2013-11-06&diff=814218&oldid=814216 [17:14:49] who is the right person to talk about the dumps? [17:15:08] Hi any property creator here? Can you please add https://www.wikidata.org/wiki/Wikidata:Property_proposal/Authority_control#BIBSYS [17:21:10] ja, natürlich … hier gibt's Property-Ersteller wie Sand an der Nordsee :) [17:28:04] (03CR) 10Ori.livneh: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [17:30:04] (03PS10) 10Ori.livneh: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [17:37:24] back [17:37:55] addshore: would you mind merging https://gerrit.wikimedia.org/r/#/c/93661/ ? [17:38:12] daniel already +2'ed it but it needed manual rebase [17:38:25] (03CR) 10Addshore: [C: 032] "per previous" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [17:38:25] we're going to backport it [17:38:28] thanks! [17:39:15] JeroenDeDauw, I saw you worked on the wda project [17:39:40] I made the turtle export work with https://github.com/TomT0m/wda [17:39:54] but I don't know the best way to use this export [17:40:33] any idea ? I'm looking into virtuoso to have a sparql, but the import do not seem that easy [17:41:48] (03Merged) 10jenkins-bot: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/93661 (owner: 10Aude) [17:48:43] (03PS1) 10Aude: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] (mw1.23-wmf1) - 10https://gerrit.wikimedia.org/r/93767 [17:49:03] (03CR) 10Aude: [C: 032] Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] (mw1.23-wmf1) - 10https://gerrit.wikimedia.org/r/93767 (owner: 10Aude) [17:53:51] Vogone Bist Du auch ein Property creator? [17:54:14] (03Merged) 10jenkins-bot: Re-introduce siteGroup setting for performance reasons [extensions/Wikibase] (mw1.23-wmf1) - 10https://gerrit.wikimedia.org/r/93767 (owner: 10Aude) [17:54:20]