[00:30:45] nileshc_away: that code is rather badly designed... hard to test... try to avoid having code in anything that derives from ApiBase [00:30:52] That is what Wikibase Query does [00:31:03] You can look at its API module to see how to nicely design this [00:31:07] And how to test the code [00:31:42] you can have API modules that don't extend ApiBase? o.O [00:35:59] legoktm: https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/blob/master/src/Wikibase/Query/Api/EntitiesByPropertyValue.php#L19 [00:36:18] you can put nearly all your code outside of ApiBase deriving classes [00:36:26] ah [00:36:33] And you typically should, since ApiBase is a badly designed legacy API [08:50:05] (03PS8) 10Tobias Gritschacher: Implemented "snaks-order" parameter in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84517 (owner: 10Henning Snater) [08:51:29] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84517 (owner: 10Henning Snater) [08:59:33] (03PS9) 10Tobias Gritschacher: Implemented "snaks-order" parameter in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84517 (owner: 10Henning Snater) [09:16:36] (03CR) 10Tobias Gritschacher: "Why is that Exception uncaught?" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85285 (owner: 10Jeroen De Dauw) [09:21:15] (03PS15) 10Aude: Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [09:24:41] (03CR) 10jenkins-bot: [V: 04-1] Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [09:36:03] https://bugzilla.wikimedia.org/show_bug.cgi?id=38678 [09:37:37] https://bugzilla.wikimedia.org/show_bug.cgi?id=46251 [09:37:57] (03PS1) 10Henning Snater: Selenium test adjustments regarding use of new "animation" event [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85650 [09:39:02] (03PS6) 10Henning Snater: toggler & inputextender: Replaced "animationstep" events with "animation" event [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79147 (owner: 10Daniel Werner) [09:39:42] (03CR) 10Tobias Gritschacher: [C: 032] Implemented "snaks-order" parameter in reference serializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84516 (owner: 10Henning Snater) [09:40:03] (03CR) 10Tobias Gritschacher: [C: 032] Implemented "snaks-order" parameter in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84517 (owner: 10Henning Snater) [09:41:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=47070 [09:42:13] https://bugzilla.wikimedia.org/show_bug.cgi?id=52311 [09:42:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=48937 [09:42:51] https://bugzilla.wikimedia.org/show_bug.cgi?id=54273 [09:44:08] that's a weird email address this bugreport comes from.. [09:44:13] :) [09:44:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=49571 [09:44:20] (03Merged) 10jenkins-bot: Implemented "snaks-order" parameter in reference serializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84516 (owner: 10Henning Snater) [09:44:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=54082 [09:45:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=54085 [09:46:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=47288 [09:47:14] (03Merged) 10jenkins-bot: Implemented "snaks-order" parameter in SetReference API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84517 (owner: 10Henning Snater) [09:47:57] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#884 (master - 30e7682 : jenkins-bot): The build has errored. [09:47:57] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/af0104f19a49...30e76826ca28 [09:47:57] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11681988 [09:48:11] who broke it? [09:48:25] https://bugzilla.wikimedia.org/show_bug.cgi?id=49404 [09:50:02] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#885 (master - 375e8c3 : jenkins-bot): The build has errored. [09:50:02] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/30e76826ca28...375e8c3d269b [09:50:02] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11682056 [09:50:23] https://bugzilla.wikimedia.org/show_bug.cgi?id=50277 [09:51:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=45529 [09:55:40] https://bugzilla.wikimedia.org/show_bug.cgi?id=50803 [09:56:32] addshore: https://gerrit.wikimedia.org/r/#/c/85285/ [10:02:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=47068 [10:02:47] https://bugzilla.wikimedia.org/show_bug.cgi?id=42186 [10:08:44] https://bugzilla.wikimedia.org/show_bug.cgi?id=37754 [10:09:32] (03CR) 10Tobias Gritschacher: [C: 032] Selenium test adjustments regarding use of new "animation" event [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85650 (owner: 10Henning Snater) [10:09:43] (03CR) 10Tobias Gritschacher: [C: 032] toggler & inputextender: Replaced "animationstep" events with "animation" event [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79147 (owner: 10Daniel Werner) [10:09:56] (03Merged) 10jenkins-bot: toggler & inputextender: Replaced "animationstep" events with "animation" event [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79147 (owner: 10Daniel Werner) [10:10:29] https://bugzilla.wikimedia.org/show_bug.cgi?id=41994 [10:10:31] (03CR) 10Tobias Gritschacher: [C: 032] Remove some dead code from a test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85531 (owner: 10Jeroen De Dauw) [10:11:06] (03CR) 10Tobias Gritschacher: [C: 032] Test logic that was not tested yet [extensions/Ask] - 10https://gerrit.wikimedia.org/r/85537 (owner: 10Jeroen De Dauw) [10:11:17] (03Merged) 10jenkins-bot: Test logic that was not tested yet [extensions/Ask] - 10https://gerrit.wikimedia.org/r/85537 (owner: 10Jeroen De Dauw) [10:12:17] (03CR) 10Tobias Gritschacher: [C: 032] Always update position of all visible claim group labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85208 (owner: 10Henning Snater) [10:12:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=41723 [10:12:47] (03Merged) 10jenkins-bot: Selenium test adjustments regarding use of new "animation" event [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85650 (owner: 10Henning Snater) [10:13:02] https://bugzilla.wikimedia.org/show_bug.cgi?id=51172 [10:14:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=48112 [10:14:52] (03PS2) 10Tobias Gritschacher: Prevent calling tooltip's hide() when reference is destroyed already [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84983 (owner: 10Henning Snater) [10:15:53] (03Merged) 10jenkins-bot: Remove some dead code from a test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85531 (owner: 10Jeroen De Dauw) [10:15:58] (03PS4) 10Henning Snater: Moves the jQuery.NativeEventHandler from WikibaseLib into ValueView extension [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79152 (owner: 10Daniel Werner) [10:15:58] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#886 (master - 728836c : jenkins-bot): The build has errored. [10:15:58] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/375e8c3d269b...728836c69521 [10:15:58] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11682918 [10:16:16] https://bugzilla.wikimedia.org/show_bug.cgi?id=50962 [10:16:54] https://bugzilla.wikimedia.org/show_bug.cgi?id=45882 [10:17:29] https://bugzilla.wikimedia.org/show_bug.cgi?id=42913 [10:18:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=51870 [10:18:51] (03Merged) 10jenkins-bot: Always update position of all visible claim group labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85208 (owner: 10Henning Snater) [10:18:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#887 (master - 3c4ef9b : jenkins-bot): The build has errored. [10:18:59] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/728836c69521...3c4ef9bf0c0d [10:18:59] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11682975 [10:19:17] https://bugzilla.wikimedia.org/show_bug.cgi?id=51871 [10:19:59] https://bugzilla.wikimedia.org/show_bug.cgi?id=49944 [10:20:32] https://bugzilla.wikimedia.org/show_bug.cgi?id=53416 [10:22:14] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#888 (master - 65bbc4d : jenkins-bot): The build has errored. [10:22:14] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3c4ef9bf0c0d...65bbc4d705a6 [10:22:14] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11683183 [10:22:47] (03CR) 10Tobias Gritschacher: [C: 032] Prevent calling tooltip's hide() when reference is destroyed already [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84983 (owner: 10Henning Snater) [10:23:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=53533 [10:24:39] Tobi_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=53533 tests available for such issues? [10:25:12] Abraham_WMDE: not for IE8, but I think Henning_WMDE was investigating this issue [10:25:34] there are some js constructs which do bad things to IE8 [10:25:35] https://bugzilla.wikimedia.org/show_bug.cgi?id=51431 [10:26:00] (03Merged) 10jenkins-bot: Prevent calling tooltip's hide() when reference is destroyed already [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84983 (owner: 10Henning Snater) [10:26:13] (03PS6) 10Addshore: Introducing DispatchingValueFormatter and OutputFormatValueFormatterFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84768 (owner: 10Daniel Kinzler) [10:30:44] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#889 (master - a1c8d33 : jenkins-bot): The build has errored. [10:30:44] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/65bbc4d705a6...a1c8d33fde34 [10:30:44] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11683335 [10:31:28] https://bugzilla.wikimedia.org/show_bug.cgi?id=52564 [10:32:27] https://bugzilla.wikimedia.org/show_bug.cgi?id=52942 [10:35:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=51660 [10:37:43] https://bugzilla.wikimedia.org/show_bug.cgi?id=49102 [10:38:14] https://bugzilla.wikimedia.org/show_bug.cgi?id=45563 [10:40:52] https://bugzilla.wikimedia.org/show_bug.cgi?id=45314 [10:42:42] https://bugzilla.wikimedia.org/show_bug.cgi?id=47620 [10:45:21] (03PS3) 10Henning Snater: use jQuery.ui.inputextender's new "animation" event in snakview value variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79150 (owner: 10Daniel Werner) [10:45:48] https://bugzilla.wikimedia.org/show_bug.cgi?id=43899 [10:46:05] https://bugzilla.wikimedia.org/show_bug.cgi?id=41074 [10:46:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=43049 [10:46:36] https://bugzilla.wikimedia.org/show_bug.cgi?id=41845 [10:46:46] (03CR) 10Henning Snater: [C: 032] use jQuery.ui.inputextender's new "animation" event in snakview value variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79150 (owner: 10Daniel Werner) [10:48:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=39936 [10:48:50] (03CR) 10jenkins-bot: [V: 04-1] use jQuery.ui.inputextender's new "animation" event in snakview value variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79150 (owner: 10Daniel Werner) [10:50:30] (03PS4) 10Henning Snater: use jQuery.ui.inputextender's new "animation" event in snakview value variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79150 (owner: 10Daniel Werner) [10:51:16] (03CR) 10Henning Snater: [C: 032] use jQuery.ui.inputextender's new "animation" event in snakview value variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79150 (owner: 10Daniel Werner) [10:54:17] (03PS3) 10Henning Snater: Moves jQuery.NativeEventHandler into ValueViews extension [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79151 (owner: 10Daniel Werner) [10:54:55] (03PS4) 10Henning Snater: Moves jQuery.NativeEventHandler into ValueViews extension [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79151 (owner: 10Daniel Werner) [10:57:15] (03Merged) 10jenkins-bot: use jQuery.ui.inputextender's new "animation" event in snakview value variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79150 (owner: 10Daniel Werner) [10:57:17] (03CR) 10Tobias Gritschacher: "This would also require some update in WikibaseLib.php" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85357 (owner: 10Jeroen De Dauw) [10:59:54] (03CR) 10Tobias Gritschacher: [C: 032] Update constant capitalization [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85357 (owner: 10Jeroen De Dauw) [11:00:07] (03Merged) 10jenkins-bot: Update constant capitalization [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85357 (owner: 10Jeroen De Dauw) [11:00:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#890 (master - 2b4b99f : jenkins-bot): The build has errored. [11:00:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/a1c8d33fde34...2b4b99f63595 [11:00:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11684276 [11:00:56] (03CR) 10Tobias Gritschacher: [C: 032] Add description to DV common and interfaces [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85359 (owner: 10Jeroen De Dauw) [11:01:05] (03Merged) 10jenkins-bot: Add description to DV common and interfaces [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85359 (owner: 10Jeroen De Dauw) [11:11:57] (03PS5) 10Henning Snater: Moves the jQuery.NativeEventHandler from WikibaseLib into ValueView extension [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79152 (owner: 10Daniel Werner) [11:12:58] (03CR) 10Henning Snater: [C: 032] Moves the jQuery.NativeEventHandler from WikibaseLib into ValueView extension [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79152 (owner: 10Daniel Werner) [11:13:23] (03CR) 10Henning Snater: [C: 032] Moves jQuery.NativeEventHandler into ValueViews extension [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79151 (owner: 10Daniel Werner) [11:16:56] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#891 (master - f52df9e : Henning Snater): The build has errored. [11:16:56] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/2b4b99f63595...f52df9e11004 [11:16:56] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11684619 [11:45:45] (03PS1) 10Jeroen De Dauw: Some cleanup in JsonDumpGeneratorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85656 [11:49:28] (03PS1) 10Jeroen De Dauw: Update constant name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85657 [11:50:26] (03CR) 10Tobias Gritschacher: [C: 032] Update constant name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85657 (owner: 10Jeroen De Dauw) [11:54:27] (03PS1) 10Jeroen De Dauw: Update check in ValueView [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85658 [11:55:58] (03Merged) 10jenkins-bot: Update constant name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85657 (owner: 10Jeroen De Dauw) [11:58:12] (03PS1) 10Jeroen De Dauw: Explicitly include ValueView in TravisCI config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85659 [11:58:27] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Explicitly include ValueView in TravisCI config [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85659 (owner: 10Jeroen De Dauw) [11:59:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#892 (master - 7d8da67 : jeroendedauw): The build has errored. [11:59:43] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/f52df9e11004...7d8da6760f2d [11:59:43] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11685820 [12:01:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#893 (master - 3815e98 : jeroendedauw): The build has errored. [12:01:54] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/7d8da6760f2d...3815e98b0325 [12:01:54] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11685883 [12:04:59] (03PS1) 10Jeroen De Dauw: Cleanup in SetStatementRankTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85660 [12:09:10] (03CR) 10Addshore: [C: 032] Cleanup in SetStatementRankTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85660 (owner: 10Jeroen De Dauw) [12:09:38] (03CR) 10Addshore: [C: 032] Update check in ValueView [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85658 (owner: 10Jeroen De Dauw) [12:10:14] (03CR) 10Addshore: [C: 032] Some cleanup in JsonDumpGeneratorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85656 (owner: 10Jeroen De Dauw) [12:13:11] (03PS1) 10Jeroen De Dauw: Update loading of ValueView via Composer [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85662 [12:13:26] (03PS1) 10Jeroen De Dauw: Revert "Explicitly include ValueView in TravisCI config" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85663 [12:13:32] (03CR) 10Jeroen De Dauw: [C: 032 V: 032] Revert "Explicitly include ValueView in TravisCI config" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85663 (owner: 10Jeroen De Dauw) [12:13:46] (03CR) 10Jeroen De Dauw: [C: 032] Update loading of ValueView via Composer [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/85662 (owner: 10Jeroen De Dauw) [12:13:54] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#894 (master - ccd41d8 : Addshore): The build has errored. [12:13:54] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3815e98b0325...ccd41d8436a0 [12:13:54] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11686183 [12:14:34] https://www.wikidata.org/wiki/Property_talk:P747#Creating_entites_used_only_for_this_Property._How_to_name_them.3F [12:14:41] any comments? [12:15:51] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#895 (master - 8a6e67a : Addshore): The build has errored. [12:15:51] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/ccd41d8436a0...8a6e67a4341a [12:15:51] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11686227 [12:23:06] Abraham_WMDE: all of the bugzilla links? :0 [12:23:52] JeroenDeDauw: bug triage [12:23:55] JeroenDeDauw: that was a bugtriage. went through the unconfirmed and reopened ones [12:26:36] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#896 (master - a7676c3 : Jeroen De Dauw): The build passed. [12:26:36] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/8a6e67a4341a...a7676c30a79e [12:26:36] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11686334 [12:29:47] (03PS6) 10Daniel Kinzler: Handle formatting errors gracefully [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84978 [12:45:49] (03PS5) 10Addshore: sqlite tableDefinitaionReader now does stuff [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83411 [12:51:03] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=54467 [13:00:08] (03PS3) 10Daniel Kinzler: Fix validation of snakhash parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85188 [13:05:00] (03PS16) 10Aude: Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [13:06:09] (03CR) 10Jeroen De Dauw: "No regression test" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85188 (owner: 10Daniel Kinzler) [13:09:28] (03CR) 10jenkins-bot: [V: 04-1] Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [13:25:55] (03PS6) 10Addshore: add sqlite tableDefinitaionReader funcionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83411 [13:33:30] https://pypng.googlecode.com/svn/trunk/code/png.py [13:40:55] (03PS1) 10Henning Snater: Claimview "movetoolbar" definition refactoring [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85670 [13:40:56] (03PS1) 10Henning Snater: Show only topmost property label for snakview in snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85671 [14:05:54] (03CR) 10Tobias Gritschacher: [C: 031] Show only topmost property label for snakview in snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85671 (owner: 10Henning Snater) [14:07:36] (03PS4) 10Daniel Kinzler: Fix validation of snakhash parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85188 [14:07:48] JeroenDeDauw: I can haz +2 now? ----^ [14:44:57] (03PS1) 10Henning Snater: Improved snaklistview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85676 [14:53:36] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85188 (owner: 10Daniel Kinzler) [14:55:18] (03PS1) 10Tobias Gritschacher: Split given statement into several statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85677 [14:57:38] (03PS10) 10Tobias Gritschacher: Use cucumber for sitelink tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83651 [14:57:40] (03CR) 10Tobias Gritschacher: [C: 032] Split given statement into several statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85677 (owner: 10Tobias Gritschacher) [15:06:00] (03Merged) 10jenkins-bot: Split given statement into several statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85677 (owner: 10Tobias Gritschacher) [15:07:13] (03PS11) 10Tobias Gritschacher: Use cucumber for sitelink tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83651 [15:11:12] (03PS2) 10Henning Snater: Show only topmost property label for snakview in snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/85671 [15:29:28] (03PS2) 10Nilesh: Added PHP API module. Broken down into classes. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84346 [15:31:31] (03CR) 10Nilesh: "Hey Daniel, I incorporated your suggestions, broke it down into different classes, made some improvements. Looks more complete now, maybe " [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/84346 (owner: 10Nilesh) [17:12:21] https://gerrit.wikimedia.org/r/85683 [17:12:29] DanielK_WMDE: just check it looks sane [17:12:39] * aude removed obsolete setting [17:31:05] aude: we didn't start yet, i guess? [17:31:18] too soon [17:31:39] should be relatively straightforward [17:31:57] sites table can be populated on one of the wikivoyage sites [17:32:38] depending on what's easiest, the script could be run on all the clients [17:33:03] of he can copy the table contents to all the wikivoyages, and the table from test2 to the other cleints [17:33:07] or [17:33:36] although copying the contents does not purge memcached [17:33:59] ok. i try to be around, just in case, but i also don't expect issues if you do not :) [17:34:08] ok :) [17:48:22] DanielK_WMDE: http://wikidata-suggester.instance-proxy.wmflabs.org:8080/ [17:48:29] thinking...... [17:57:53] * aude waves to greg-g and reedy [18:12:51] (03PS2) 10Daniel Kinzler: Added tests for the final java backend. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85535 (owner: 10Nilesh) [18:16:23] aude: Weren't you supposed to deploy Commons today? [18:16:43] patience :) [18:16:59] it's not quite "today" in SF [18:17:17] folks should be here soon [18:17:23] to deploy [18:17:45] Patience? That's a stupid card game :P [18:17:49] only 11 am :) [18:17:50] heh [18:24:49] yeah, ops are barely awake yet in SF ;) [18:24:59] ok :) [18:25:23] Reedy's doing stuff in -operations now [18:25:28] i see [18:25:42] I'm back home [18:25:46] ok [18:25:46] And it's only 25 minutes into the window ;) [18:26:08] :) [18:26:09] i don't think things will take that long, although we need to update the sites / site identifiers tables [18:26:35] does commons have the table populated at all? [18:26:40] not yet [18:26:45] afaik [18:26:53] heh [18:26:56] It doesn't even have the tables [18:27:01] oh [18:27:11] even if it did, the contents would be wrong [18:30:12] (03CR) 10Daniel Kinzler: [C: 032 V: 032] "Merging into experimental application after superficial code review." [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85533 (owner: 10Nilesh) [18:30:26] (03CR) 10Daniel Kinzler: [C: 032 V: 032] "Merging into experimental application after superficial code review." [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85535 (owner: 10Nilesh) [18:31:53] (03CR) 10Daniel Kinzler: [C: 032 V: 032] "Approving for merge into experimental application after superficial code review." [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/77146 (owner: 10Nilesh) [18:34:56] (03PS2) 10Daniel Kinzler: Now we have two Myrrix instances with different context paths, for claims and refs respectively. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/85536 (owner: 10Nilesh) [18:44:46] aude: [18:44:48] reedy@tin:/a/common/php-1.22wmf18$ mwscript extensions/Wikibase/lib/maintenance/populateSitesTable.php --wiki=commonswiki --strip-protocols [18:44:48] PHP Fatal error: Class 'SiteMatrixParser' not found in /a/common/php-1.22wmf18/extensions/Wikibase/lib/maintenance/populateSitesTable.php on line 55 [18:44:48] Fatal error: Class 'SiteMatrixParser' not found in /a/common/php-1.22wmf18/extensions/Wikibase/lib/maintenance/populateSitesTable.php on line 55 [18:45:13] ? [18:45:29] * aude wonders if there is wrong version of something [18:49:58] hmmmmmm [18:51:55] * Lydia_WMDE waves [18:52:04] aude: what's the status? :) [18:52:09] debugging [18:52:14] ok cool [18:53:08] Reedy: that reminds me, for wikipedias on the old version of wikibase, it might be better to copy the table contents over [18:53:34] since the new version of the script unlikely works on wmf17 [18:53:43] but then we'd need / like to purge memcached [18:54:52] for commons, you are sure SiteMatrixParser is there? in lib/includes/sites [18:55:24] It worked fine for testwikidatawiki last week... [18:55:30] yeah [18:55:31] oh [18:55:39] is wikibase enabled on commons [18:55:51] but the script does not require wikibase [18:56:03] reedy@tin:/a/common/php-1.22wmf18$ ls -al extensions/Wikibase/lib/includes/sites [18:56:03] total 16 [18:56:03] drwxrwxr-x 2 reedy wikidev 4096 Sep 20 20:44 . [18:56:03] drwxrwxr-x 14 reedy wikidev 4096 Sep 19 17:46 .. [18:56:03] -rw-rw-r-- 1 reedy wikidev 3419 Sep 20 20:44 SiteMatrixParser.php [18:56:05] -rw-rw-r-- 1 reedy wikidev 2065 Sep 20 20:44 SitesBuilder.php [18:56:26] o_O [18:56:27] if wikibase is not enabled, then might not be available to commons [18:56:33] but it needs to be in the autoloader [18:56:36] yeah [18:56:46] but bad to enable commons without sites piopulated [18:57:20] Reedy: in case of commons, it is okay to copy the contents of test wikidata or test 2 over [18:57:26] What's the dependancy chain like for SiteMatrixParser.php? [18:57:33] we'll be moving the script out of wikibase soon [18:57:40] kind of stupid to have it there [18:57:53] populate sites and site matrix thing do not depend on wikibase at all [18:57:58] no namespaces no nothing like that [18:58:15] but without the autoloader include [18:58:19] then class not found [18:59:06] Uh [18:59:10] I'm even more confused now [18:59:16] :( [18:59:24] testwiki doesn't have a sites or a site_identifier table [18:59:30] test2wiki [18:59:34] or test wikidata [18:59:36] test2wiki does [18:59:45] contents are identical and same as commons gets [19:00:22] * aude wonders how we populated sites for wikivoyage [19:02:58] Reedy: I'd suggest to enable WikiBase on commons *if* the script is called from the command line. [19:03:01] hackish, but will work [19:03:04] heh [19:03:08] but katie doesn't like it :) [19:03:13] i don't care [19:03:16] Error: 1231 Variable 'time_zone' can't be set to the value of 'NULL' (10.64.32.29) [19:03:26] Oh, that's something else [19:03:27] ignore [19:03:27] what? [19:03:29] yeah [19:03:32] no time zone in sites [19:04:05] stupid mysqldump crap [19:04:10] ok [19:04:25] Ok, tables populated on commons [19:04:31] yay! [19:04:32] Query OK, 879 row(s) affected [19:04:36] Query OK, 574 row(s) affected [19:04:40] perfect [19:04:46] now wikivoyage? [19:05:01] or copy the contents to wikidata / wikipedias [19:05:07] wikivoyage needs the script [19:05:33] wikidata can use the script [19:06:08] wikivoyage has the script [19:06:11] ok [19:06:17] PHP Notice: unserialize(): Error at offset 73 of 131 bytes in /usr/local/apache/common-local/php-1.22wmf18/includes/db/ORMTable.php on line 844 [19:06:17] viwikivoyage: [19:06:17] viwikivoyage: Notice: unserialize(): Error at offset 73 of 131 bytes in /usr/local/apache/common-local/php-1.22wmf18/includes/db/ORMTable.php on line 844 [19:06:17] viwikivoyage: done. [19:06:19] reedy@tin:/a/common$ [19:06:24] ugh [19:06:38] DanielK_WMDE: have any idea^ [19:06:53] But done - ran for wikidatawiki and wikivoyage [19:07:02] ok [19:07:05] Reedy: do you have a stack trace? [19:07:10] how many entries? [19:07:12] Nope [19:07:18] 879 / 574? [19:07:28] Reedy: we should have stoped using php serialization for hopefully everything several months ago... [19:07:30] * aude looks at the tables on tool labs [19:07:43] It works second time round [19:07:49] So sounds like old code in the sites table [19:07:56] But it did the same errors for every wikivoyage [19:07:57] could be [19:08:00] yeah [19:08:03] 879/574 [19:08:15] hm, i guess sites does use php serialization... [19:08:18] looks fine [19:08:24] Reedy: guess you are right: new code trying to read old content. [19:08:30] No notices if you run it again [19:08:41] wikipedias... the script probably won't do the correct thing on wmf17 [19:09:00] we could just insert commons into the sites table [19:09:05] that's all that is missing [19:10:20] or.... [19:10:31] nevermind [19:11:58] Hm? [19:12:25] for wikipedia, it needs commons added to the sites table [19:12:40] then memcached purged [19:12:53] since wikipedia is on wmf17, the old code does not handle adding commons [19:13:04] i can think of a few ways to do this [19:13:34] (817,'commonswiki','mediawiki','commons','local','en','','.','a:1:{s:5:\"paths\";a:2:{s:9:\"file_path\";s:28:\"//commons.wikimedia.org/w/$1\";s:9:\"page_path\";s:31:\"//commons.wikimedia.org/wiki/$1\";}}',0,'a:0:{}') [19:13:43] looks right [19:14:06] I guess I need to drop the site_id [19:14:18] yep [19:15:02] 817 on test2wiki, 816 on wikidatawiki [19:15:37] Reedy: one sec [19:15:49] it should auto increment [19:17:33] huh, i wonder if enwiki is missing some sites [19:18:27] Reedy: 796 looks like the next id, unless you want to autoincrement [19:18:31] INSERT INTO `sites`(site_global_key,site_type,site_group,site_source,site_language,site_protocol,site_domain,site_data,site_forward,site_config) VALUES ('commonswiki','mediawiki','commons','local','en','','.','a:1:{s:5:\"paths\";a:2:{s:9:\"file_path\";s:28:\"//commons.wikimedia.org/w/$1\";s:9:\"page_path\";s:31:\"//commons.wikimedia.org/wiki/$1\";}}',0,'a:0:{}') [19:18:35] good [19:20:54] that's running now on all wikipedias [19:20:59] Can you find the memcached key please? [19:21:01] ok [19:21:07] let's see [19:21:23] and/or the purge function on the right object [19:22:36] SiteSQLStore::newInstance()->reset() [19:22:38] Purges the internal and external cache of the site list, forcing the list * of sites to be re-read from the database. [19:24:29] Done... [19:24:33] yay! [19:24:33] (so is the insert) [19:24:46] commons config now/ [19:24:47] *? [19:24:52] yes [19:25:12] https://gerrit.wikimedia.org/r/#/c/85683/ [19:25:19] Jenkins won't merge my wikiversions update [19:25:26] grrrr [19:26:17] And the submit button is greyed out [19:26:28] is there a merge conflict? [19:26:34] can't be rebased? [19:26:49] has a dependency [19:26:58] https://gerrit.wikimedia.org/r/#/c/85696/ [19:27:04] https://gerrit.wikimedia.org/r/#/c/85693/ [19:27:07] Oh [19:27:08] Yes [19:27:09] Haha [19:27:13] :) [19:36:10] \o/ [19:37:28] it be noted the way we present commons in the site link list on wikidata needs improvement, though [19:37:39] site name => code instead of language => code [19:39:19] Reedy: wikibase is not enabled on commons [19:39:31] i added it to the wikidataclient list but wonder if i did something wrong [19:39:46] or do you need to sync that [19:40:18] reedy synchronized wmf-config/ [19:40:23] that would not cover it [19:44:04] hmmmm, i also see 19:36 <+logmsgbot> !log reedy synchronized database lists files: [19:44:33] I might need to touch InitialiseSettings/CommonSettings and sync again [19:44:36] ok [19:45:06] Sep 23, 2013 5:56 PM [19:45:11] you might see some errors if wikidata pushes jobs to commons while wikibase is not enabled there [19:45:12] That would be pre-epoch for caching [19:45:18] only in job queue [19:45:22] Reedy: ok [19:45:36] I just went outside and found a hedgehog by my car [19:45:41] heh [19:45:44] it distracted me to take pictures [19:45:47] :D [19:46:11] I then poked it with a stick and it curled up into a ball [19:46:19] hah [19:46:26] Not sure if it's ill, but it didn't move when i found a light and came out again [19:46:33] it's scared [19:46:35] The poking was intended to see if that would've made him move [19:46:49] I think it was about last night when I came home [19:46:56] But it was lighted and it hurried off into the bushes [19:47:09] oh [19:47:10] Yeah, commons fixed [19:47:30] * aude purges the page [19:47:35] and it has language links! [19:47:43] https://commons.wikimedia.org/wiki/New_York_City [19:47:45] Lydia_WMDE: ^ [19:47:56] yay! [19:48:02]