[00:07:53] Hey. Can I get some people to weigh in on https://www.wikidata.org/wiki/Wikidata:Property_proposal/References#AMG_Game_ID_.28en.29 so that I can create it and start using it? [00:09:07] No [00:11:57] Reedy: no you won't weigh in or no it's a bad idea [00:12:32] whatever [02:02:41] legoktm: have you seen http://tools.wmflabs.org/xtools/pcount/index.php?name=Legoktm&lang=www&wiki=wikidata [02:18:52] hm why did this edit: https://www.wikidata.org/w/index.php?title=Q3918&diff=prev&oldid=69921579 add more bytes to the page? see: https://www.wikidata.org/w/index.php?title=Q3918&action=history [02:24:07] Sk1d: I've been seeing a lot of that. When properties are removed, the difference is positive [02:25:20] yep me too but this is quiet big. [02:31:14] (+3,598) [02:31:16] donno [02:31:26] ping a staffer [02:34:19] Sk1d: can you do me a favor? [02:35:27] The times I've seen it the coordinate location has ended up corrupted for some reason. [02:35:37] Don't know if it's related. [02:36:12] Sky2042: there's an error that aude mentioned [02:36:18] let me see if I can find my logs [02:36:35] bah [02:36:39] aude items here: https://www.wikidata.org/wiki/User:Byrial/Globes#Coordinate_values_with_data_value_type_.22bad.22_in_the_database [02:36:41] I thought we had a filter for " ! 22:26 PowerPoint Viewer (Q9283552)‎ (diff | hist) . . (+24)‎ . . 190.110.152.195 (talk | block) (‎Added [en] description: español) [rollback]" [02:37:16] Sky2042: issue is that those items are missing either the globe or the percision [02:37:36] Sven_Manguard: Ah. [02:37:46] I'm fixing them now [02:44:03] Sky2042: looks like an error with importing from nlwiki ? [02:44:17] That sounds familiar. [02:47:15] anyone here speak dutch? [02:53:13] it looks like KLBot may have imported a bunch of locations that were too precise or something? [02:53:31] Sven_Manguard: Google Translate :P [02:53:45] GTranslate likes to choke on Dutch. [02:53:47] ( [02:53:48] :( [02:53:54] Sky2042: no, it's that they're missing the precision field entirely [02:54:02] Ah. [02:54:13] Sky2042: I figured it out using google maps [02:54:18] :D [03:00:37] It would appear that everything in https://www.wikidata.org/wiki/Q3303044 points to a different article [03:00:49] fuck [03:00:51] I wonder what would happen if I deleted a claim used 4 million times. [03:00:54] :^) [03:01:14] Sven_Manguard: The best kind of disambiguation! :D [03:01:37] I'm not equip to sort it all out [03:01:43] Sven_Manguard: da and nl are the same. [03:01:58] sv is a disambig page [03:02:07] nope [03:02:15] en and sv are the same. [03:02:49] sv is just a stub. [03:03:13] so in reality, that just needs two links moved around. [03:03:19] wait no, yeah [03:03:24] en and sv are the same [03:04:30] you can usually tell by same or similar pictures. if you need to check, you can always dump it through gtranslate [03:04:41] or install an addon, which I did, which can translate things inline. [03:05:09] just because i started working on wikidata. :D [03:09:05] {{fixed}} [03:09:06] 10[3] 04https://www.wikidata.org/wiki/Template:fixed [03:16:50] jeez, fixing these errors is tedious [03:18:34] Sven_Manguard: You're tellin' me! [03:18:46] you working on them too? [03:19:47] No, not your errors. [03:19:49] :) [03:20:02] I'm deprecating a property one page at a time. [03:20:07] :D [03:20:14] Sk1d: because of badges [03:20:20] and cleaning up hierarchal entities on the way up as well. [03:20:27] the internal json is changing [03:41:26] legoktm: is that a big change? [03:43:20] Hey, umm... how do you plug in geocoordinates for Mars? [03:46:29] You don't. [03:46:31] :| [03:46:56] But we have them [03:47:02] and theoretically we can support that [03:47:04] somehow [03:47:17] Sky2042: https://www.wikidata.org/wiki/User:Byrial/Globes#Globes_used_in_values_for_coordinate_properties [03:47:48] Sven_Manguard: convenient item to test on? [03:48:02] it might be that those simply have planet = Mars set on them and the implication is that that's the globe used. [03:48:09] hmmm [03:53:12] There should be a value Globe that I can set to Mars [03:55:35] sigh [03:55:53] Sven_Manguard: All that documentation, am I right? [03:55:57] :^) [03:56:25] I see the on-wiki documentation [03:56:30] but nothing useful [03:57:31] Sven_Manguard: That's the joke. :D [03:58:29] The number of items which link to https://www.wikidata.org/w/index.php?title=Special:WhatLinksHere/Q11446&limit=500 is disturbing. [04:00:39] instance of ship [04:00:57] Sven_Manguard: Yes. [04:01:02] What kind of ship though. [04:01:15] likely not an airship [04:01:34] Quite likely not an airship. [04:05:50] hey MZMcBride [04:05:58] it's Elsie now? [04:07:12] I feel guilty. [04:07:21] Adding two subclass statements that are nearly mutually exclusive. [04:07:27] :( [04:07:44] Sky2042: naughty [04:07:59] what's the situation? [04:08:24] Well, this one was https://www.wikidata.org/wiki/Q14978 , which is either a ship or a boat. [04:08:30] I had a similar situation with some other such type of thing. [04:08:43] It's sometimes a subclass of one thing, sometimes a subclass of another. [04:08:50] An icebreaker is a special-purpose ship or boat designed to move and navigate through ice-covered waters. [04:08:54] Almost as if we need probabilistic qualifiers. [04:08:55] okay, you're fine [04:08:56] :| [04:09:12] The implication of having multiple classes is "AND" not "OR" [04:09:25] Hence why it makes me feel guilty. [04:10:10] Also, people being dumb and using has part where it has no business being used. [04:10:12] * Sky2042 sighs. [04:13:45] Also the ship class property makes me so unhappy. [04:13:54] So much duplicate data. [04:17:23] omg too much data in wikidata shut it down [04:18:39] legoktm: No, too much duplicate data. -_- [04:18:40] * Sky2042 kicks legoktm. [04:21:16] And ships somehow taking the value for P107 "creative work". [04:21:17] * Sky2042 sighs. [04:21:40] * Sky2042 removes that as well. [04:41:40] Sven_Manguard: Shh, don't tell anyone. [06:16:18] good morning [08:47:47] (03CR) 10Daniel Kinzler: [C: 04-1] "Restoring -1 as per comments on PS 16." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [08:50:13] let go fly a kite... [08:50:18] s [08:52:46] (03CR) 10Daniel Kinzler: [C: 04-1] "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [09:33:59] aude: hello [09:34:06] hi [09:34:30] I made a few more changes to the skin [09:34:37] great [09:34:41] and I've pushed them to the instance so you can see [09:34:45] ok [09:35:04] in my opinion, the single column layout works well [09:35:20] I tried it out a couple of phones and an iPad and it doesn't look bad at all! [09:35:23] oooh [09:35:40] nice [09:36:11] and it's a lot easier to include qualifiers [09:36:18] agree [09:36:26] see for yourself! :) [09:36:27] http://wikidata-mobile-tester.instance-proxy.wmflabs.org/wiki/Main_Page [09:36:31] :) [09:37:58] for passing the data, i talked to danielk [09:38:25] we might just put the entity object and referenced entities (e.g. properties) into the parser output (template data) [09:38:45] then it is passed to output page as properties that the skin can use [09:39:04] we have formatters for the data values and those can be used there [09:39:40] the entities could be serialized as json or doesn't need to be [09:39:49] oh awesome, so we have formatted data values that can just be plugged into the skin [09:39:56] we have formatters [09:40:05] and we have data values [09:40:38] as long as we have the entity objects and data values, then it's reasonable to format them in the skin [09:40:39] so I could format them in the skin as well [09:40:41] yes [09:40:54] later on, it would be nice if more of the code can be shared with entity view [09:40:59] don't worry about it yet [09:41:21] yes I agree [09:41:29] and maybe at some point, we'd want to format something in a different way [09:41:34] then that would be possible [09:41:53] yep, otherwise there would be a lot of doubling of efforts [09:42:11] we'd have to manually change things in the skin to mirror entity view [09:42:16] right [09:42:26] if it can be avoided, all the better [09:42:57] also, since the coming week is the last week of GSoC, can we take stock of things to be completed once? [09:43:04] it'll make it easier for me to keep track [09:43:09] sure [09:43:33] so, take the entity data from output page [09:43:43] insert it into the layout [09:43:52] apply formatting to the data values [09:44:10] layout and script tweaks [09:44:13] i don't think it needs to be more complicated than that for now [09:44:17] yes [09:44:30] and add qualifiers to the skin [09:44:46] yes, I'm doing that as we speak actually [09:44:50] ok [09:46:01] do I also need to write some documentation for the skin? [09:46:07] would be good [09:46:31] and any non-trivial php code, ideally we would like some unit tests [09:46:48] perhaps we can help with that but would be good if you were able to do some basic tests also [09:46:56] it's an important part of our process [09:47:09] yes and that's something I'd like to learn as well [09:47:19] I don't have any experience with writing tests [09:47:27] nothing can go into wikibase itself without tests [09:47:35] neither did i until i joined the project [09:47:38] it's a necessary practise [09:47:41] yes [09:48:27] so much easier to deploy code (confidently) when tests cover stuff [09:48:50] true [09:49:39] plus, I think it would also be a nice idea to put down a list of things that we think should be added to the skin in the coming months [09:49:44] yes [09:50:07] off the top of my head, there are special pages [09:50:13] * aude nods [09:50:26] plus, on-page editing of data would be a nice feature [09:50:31] changing language [09:50:36] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/71996/ - there's no comment on PS16 [09:50:36] that's an important one [09:50:48] yep, addshore has also been reminding me of that :) [09:50:56] the mobile skin for wikipedia handles that by sending you to the wikipedia in that other language [09:51:01] wikidata is different [09:51:05] (03CR) 10Daniel Kinzler: [C: 04-1] "The mergeXXX methods that do the actual work are all private and can't be tested individually. That's not good." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [09:52:21] I think I'll have to make a report of some sort at the end of gsoc, so these things could go there [09:52:52] DanielK_WMDE: around? [09:52:58] if not, I'll leave for a while [09:55:20] he's here [09:55:36] (03CR) 10Jeroen De Dauw: "(7 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [09:55:37] away from the desk at the moment but back in a few minutes [09:55:59] aude: ok [09:56:17] pragunbhutani: sounds good [09:56:42] pragunbhutani: errr, daniel was away [09:56:45] he is back [09:57:00] aude: oh :p [09:58:06] (03CR) 10Daniel Kinzler: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 (owner: 10Addshore) [10:02:52] aude: still not here .. and I have to go now [10:02:58] liangent: ok [10:03:22] (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [10:06:27] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [10:07:15] (03CR) 10Jeroen De Dauw: [C: 04-1] "Looking at SnakFormatter and SnakFormatterFactory, it seems that a snak formatter is supposed to format snaks for a given output format. W" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [10:09:51] (03CR) 10Daniel Kinzler: [C: 032] (bug 53367) check that sites and titles params are set before lookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81122 (owner: 10Aude) [10:12:01] (03PS5) 10Daniel Kinzler: (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 [10:12:12] (03PS3) 10Daniel Kinzler: (bug 52799) Dump JSON of entities listed in file. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84000 [10:12:13] (03PS9) 10Aude: Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [10:13:33] (03Merged) 10jenkins-bot: (bug 53367) check that sites and titles params are set before lookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81122 (owner: 10Aude) [10:15:01] (03CR) 10jenkins-bot: [V: 04-1] (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 (owner: 10Daniel Kinzler) [10:16:48] (03CR) 10jenkins-bot: [V: 04-1] Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [10:17:12] * aude stabs jenkins [10:19:43] (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82837 (owner: 10Daniel Kinzler) [10:23:47] haha :p [10:23:54] aude: check out how the qualifiers look [10:23:55] http://wikidata-mobile-tester.instance-proxy.wmflabs.org/wiki/Main_Page [10:24:02] under 'canonization status' [10:24:52] i think it's nice [10:25:48] yay :) [10:27:08] maybe the sources could be aligned consistent with how they are with no qualifiers? [10:27:18] not sure that's better but might be [10:27:33] it looks like the sources go with the qualifiers [10:28:05] don't they? [10:28:31] errr, looks like they are sources for the qualifier part and not the main value [10:28:32] On wikidata, each qualifier entry seems to have its own sources [10:28:43] that's how I thought they work [10:28:44] no [10:28:56] sources are for the main value or statement as a whole [10:29:09] * aude doesn't think qualifiers have references or seems not [10:29:21] for example, https://www.wikidata.org/wiki/Q989 [10:29:32] under 'award received' [10:30:23] the sources are not specific for the date but suppose it's for both what the prize is and the date [10:30:36] or just what the prize is [10:31:00] it's just the way the layout is, they get aligned that way [10:31:39] maybe for mobile, it could indent qualifiers less and also indent the sources consistently? [10:32:05] okay, I'll just do that [10:32:06] or that might be ugly :) [10:32:21] i don't know but consistent with expanded and not expanded might be nice [10:34:19] yep if the sources are specific to the 'qualifier' set, they should be indented less [10:38:03] (03CR) 10Daniel Kinzler: "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [10:38:27] (03CR) 10Daniel Kinzler: "@jeroen: will add canFormatSnak" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 (owner: 10Daniel Kinzler) [10:42:42] (03PD2) 10Addshore: grab a fresh ID before performing changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84115 [10:42:47] :D [10:43:47] aude: how about now? http://wikidata-mobile-tester.instance-proxy.wmflabs.org/w/index.php?title=Main_Page&mobileaction=toggle_view_mobile [10:44:12] pragunbhutani: think that is better and more clear [10:44:31] yep :) [10:45:32] (03PS17) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [10:45:47] (03CR) 10Addshore: "PS17 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore) [10:48:28] (03PS18) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [10:50:07] (03PS25) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [10:50:25] (03CR) 10Addshore: "PS25 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [10:56:22] DanielK_WMDE: re your comment on https://gerrit.wikimedia.org/r/#/c/79988/ , the XXXmerge methods dont actually do anything, they only create an array of changeops, which is where the actions are actually performed [10:56:31] I cant really think og a nice way to factor them out [10:56:52] other than some sort of changeop helper O_o [11:16:00] (03CR) 10Liangent: "There's no comment on PS 16." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [11:54:59] (03PS1) 10Addshore: add use for missing exception [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84116 [11:55:10] aude: Tobi_WMDE DanielK_WMDE can someone please +2 the above quickly :) [11:56:11] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] add use for missing exception [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84116 (owner: 10Addshore) [12:05:10] Lydia_WMDE_, aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=54096 [12:05:34] \o/ [12:09:33] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84115 (owner: 10Addshore) [12:10:28] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84115 (owner: 10Addshore) [12:16:41] (03CR) 10Tobias Gritschacher: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84115 (owner: 10Addshore) [12:19:08] (03CR) 10Liangent: "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [12:22:07] DanielK_WMDE: ^ [12:22:33] (03PS1) 10Aude: allow globe coordinate precision to be null in JS [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 [12:26:49] (03CR) 10Tobias Gritschacher: [V: 04-1] "There was 1 error:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84115 (owner: 10Addshore) [12:28:24] Henning_WMDE: https://gerrit.wikimedia.org/r/#/c/84117/ [12:28:55] it seems to work fine with that change [12:29:15] and there were no tests that covered valid / invalid precision, afaik [12:29:27] e.g. no tests to change [12:30:52] the change will allow values like on https://www.wikidata.org/wiki/Q30645 to render :) [12:51:15] (03CR) 10Daniel Kinzler: "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [12:55:15] (03PS11) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [12:56:28] (03PS12) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [13:08:02] (03PS1) 10Daniel Kinzler: (bug 54096) Apply high limit for bots to wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84119 [13:14:22] aude: https://bugzilla.wikimedia.org/show_bug.cgi?id=54097 <- paper cut or not? [13:15:16] Lydia_WMDE_: yes [13:15:20] thx [13:17:27] (03CR) 10Liangent: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [13:29:51] (03PS3) 10Jeroen De Dauw: Implementation work in SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83815 [13:49:48] (03PS1) 10Daniel Kinzler: (bug 52916) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 [13:50:46] Lydia_WMDE_: --^ [13:53:42] (03CR) 10Aude: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [13:58:46] (03PS1) 10Aude: (bug 52501) don't break diff when dataValue could not be formatted [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84121 [13:59:44] (03CR) 10Aude: "cherry pick of https://gerrit.wikimedia.org/r/#/c/82816/ into master" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84121 (owner: 10Aude) [14:00:03] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/84121/ [14:00:16] i'd prefer that to be in master and you can base your change and formatters on that [14:00:30] don't want it to be forgotten and broken when we branch next week [14:01:10] (03PS2) 10Daniel Kinzler: (bug 52916) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 [14:01:20] (03CR) 10Daniel Kinzler: [C: 04-1] "missing tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [14:10:20] (03PS26) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [14:13:50] (03PS3) 10Addshore: grab a fresh ID before performing changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84115 [14:13:54] Tobi_WMDE: ^^ ;p [14:14:48] (03PS27) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [14:14:49] (03PS19) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [14:15:04] (03CR) 10Addshore: "PS 27 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [14:15:15] (03CR) 10Addshore: "PS19 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore) [14:15:22] (03PS3) 10Daniel Kinzler: (bug 52916) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 [14:23:17] (03CR) 10Addshore: [C: 032] Introduces SpecialWikibaseQueryPage::CACHE_TTL_IN_SECONDS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83097 (owner: 10Daniel Werner) [14:23:22] (03CR) 10jenkins-bot: [V: 04-1] Introduces SpecialWikibaseQueryPage::CACHE_TTL_IN_SECONDS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83097 (owner: 10Daniel Werner) [14:25:34] (03PS2) 10Addshore: Introduces SpecialWikibaseQueryPage::CACHE_TTL_IN_SECONDS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83097 (owner: 10Daniel Werner) [14:25:45] (03CR) 10Addshore: "PS2 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83097 (owner: 10Daniel Werner) [14:26:21] (03CR) 10Addshore: [C: 032] Introduces SpecialWikibaseQueryPage::CACHE_TTL_IN_SECONDS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83097 (owner: 10Daniel Werner) [14:26:22] Danwe_WMDE: Henning_WMDE can you also please look at https://gerrit.wikimedia.org/r/#/c/84117/ [14:26:30] can you think of any issues this might cause? [14:26:51] items like https://www.wikidata.org/wiki/Q30645 do not render coordinates [14:27:16] I guess globeCoordinate.js would need to be adjusted. [14:27:23] hmmm ok [14:27:32] wowooooooo [14:27:58] :) [14:28:37] (03Merged) 10jenkins-bot: Introduces SpecialWikibaseQueryPage::CACHE_TTL_IN_SECONDS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83097 (owner: 10Daniel Werner) [14:29:54] (03PS1) 10Daniel Werner: Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 [14:30:23] (03CR) 10jenkins-bot: [V: 04-1] Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 (owner: 10Daniel Werner) [14:30:33] (03PS13) 10Addshore: (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 (owner: 10Daniel Werner) [14:30:47] (03PS4) 10Daniel Werner: Performance improvement in FetchedEntityContentSerializer::getSerialized [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83689 [14:30:52] (03PS2) 10Daniel Werner: Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 [14:30:57] hi, can anyone answer a question about how to use #property? [14:33:59] (03PS3) 10Daniel Werner: Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 [14:35:59] (03CR) 10jenkins-bot: [V: 04-1] Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 (owner: 10Daniel Werner) [14:39:37] (03CR) 10Addshore: [C: 04-1] "(4 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 (owner: 10Daniel Werner) [14:40:58] addshore: can you please try to reproduce https://www.wikidata.org/wiki/Wikidata:Paper_cuts#.22Jump_to:_navigation.2C_search.22_when_copying_label ? [14:42:34] (03PS4) 10Tobias Gritschacher: Use cucumber for sitelink tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83651 [14:48:46] (03CR) 10Tobias Gritschacher: [C: 032] allow precision to be null in globe coordinate [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/83990 (owner: 10Aude) [14:48:58] Lydia_WMDE_: cant reporduce [14:49:20] (03Merged) 10jenkins-bot: allow precision to be null in globe coordinate [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/83990 (owner: 10Aude) [14:50:39] can someone else reproduce https://www.wikidata.org/wiki/Wikidata:Paper_cuts#.22Jump_to:_navigation.2C_search.22_when_copying_label ? [14:52:22] Lydia_WMDE_: Neither with WebKit based nor with Firefox, maybe IE specific? [14:52:38] hoo: no :( they say they're using ff [14:52:41] Lydia_WMDE_: nope, can't reproduce that with firefox [14:52:47] mpfh [14:52:50] frustrating [14:52:51] :/ [14:52:55] thx for testing peeps [14:52:59] ]: [14:53:36] that one requires keeping an eye on, to hide it via display: none or visibility: hidden is *no* option due to accessibility issues [14:53:40] The value does not comply with the property's definition. // The value's data value type "ununserializable" does not match the property's data type's data value type "globecoordinate". [14:53:43] on wikidata.org? [14:53:58] The community also mustn't do that in their MeidaWiki:common.css [14:54:01] liangent: https://gerrit.wikimedia.org/r/#/c/84117/ [14:54:31] hoo: yeah [15:00:45] (03CR) 10Addshore: "I still feel this method should be marked as deprecated as it needs to be GONE! as it depends on LIB from DataModel.." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 (owner: 10Addshore) [15:00:56] (03PS2) 10Addshore: Deprecate Entity->newClaim [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 [15:06:34] (03PS4) 10Tobias Gritschacher: Introduction of FetchedEntitiesFinder::findDataValueLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84125 (owner: 10Daniel Werner) [15:07:04] (03CR) 10Addshore: "RE daniel. the guid logic is not all over the code. Guids are created by the ClaimGuidGenerator, which is only used in changeops (even if " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore) [15:12:16] (03CR) 10Tobias Gritschacher: [C: 032] grab a fresh ID before performing changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84115 (owner: 10Addshore) [15:13:50] (03Merged) 10jenkins-bot: grab a fresh ID before performing changeops [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84115 (owner: 10Addshore) [15:14:03] (03PS3) 10Addshore: Get rid of the use of Entity->newClaim() in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 [15:14:18] (03CR) 10Addshore: "PS3 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore) [15:14:50] (03PS14) 10Daniel Werner: (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 [15:15:16] addshore: -----~~^^ [15:15:45] (03CR) 10Daniel Werner: "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 (owner: 10Daniel Werner) [15:17:04] (03CR) 10Tobias Gritschacher: "@aude: coordinate support was only done on deployment branch IIRC." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [15:20:04] (03PS4) 10Jeroen De Dauw: Implementation work in SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83815 [15:22:36] (03PS6) 10Daniel Werner: Introduces jQuery.PurposedCallbacks constructor [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79145 [15:22:47] oh [15:22:49] (03PS5) 10Daniel Werner: Introduces jQuery.AnimationEvent and jQuery.fn.animateWithEvent [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79146 [15:22:53] No DanielK? [15:23:00] (03PS4) 10Addshore: Get rid of the use of Entity->newClaim() in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 [15:23:03] so far for my troll :( [15:23:18] Danwe_WMDE: how do you like my alternate approach in the last PS here? https://gerrit.wikimedia.org/r/#/c/83815/ :D [15:23:30] (03CR) 10jenkins-bot: [V: 04-1] Get rid of the use of Entity->newClaim() in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore) [15:23:36] (03CR) 10Daniel Werner: "Rebasing this won't work for some reason, I'll commit it again after the dependency got merged." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/79147 (owner: 10Daniel Werner) [15:23:54] (03CR) 10Addshore: [C: 032] (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 (owner: 10Daniel Werner) [15:25:27] (03Merged) 10jenkins-bot: (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 (owner: 10Daniel Werner) [15:25:48] legoktm: poke [15:26:22] (03PS3) 10Addshore: Deprecate Entity->newClaim [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 [15:27:08] (03PS5) 10Addshore: Get rid of the use of Entity->newClaim() in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 [15:27:09] (03PD3) 10Addshore: Deprecate Entity->newClaim [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 [15:27:37] (03CR) 10jenkins-bot: [V: 04-1] Get rid of the use of Entity->newClaim() in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore) [15:28:22] (03PS4) 10Daniel Werner: (bug 52916) Baseline for Quantity data type. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84120 (owner: 10Daniel Kinzler) [15:31:01] (03PS4) 10Addshore: remove Entity->newClaim from MainSnakChangeOp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82234 [15:31:30] (03CR) 10jenkins-bot: [V: 04-1] remove Entity->newClaim from MainSnakChangeOp [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82234 (owner: 10Addshore) [15:31:50] (03CR) 10Addshore: "Needed by https://gerrit.wikimedia.org/r/#/c/82233/" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 (owner: 10Addshore) [16:09:10] Lydia_WMDE_: poke [16:09:22] JeroenDeDauw: poke [16:45:13] (03PS2) 10Aude: allow globe coordinate precision to be null in JS [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 [16:52:40] (03PS3) 10Aude: allow globe coordinate precision to be null in JS [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 [16:57:23] (03PS4) 10Aude: allow globe coordinate precision to be null in JS [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 [18:29:00] "huggle 3 QT-LX" for one small moment I saw "LQT 3" :) [18:39:04] (03CR) 10Jeroen De Dauw: [C: 04-1] "Not because it is extending bad code that it should not have any tests. All the more reason to do have tests, so that we can easily clean " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/84121 (owner: 10Aude) [18:53:16] (03PS1) 10Aude: allow longitude coordinates up to 360 in JS globe coordinate [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84140 [19:39:35] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84140 (owner: 10Aude) [19:41:34] (03CR) 10Jeroen De Dauw: [C: 031] allow globe coordinate precision to be null in JS [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/84117 (owner: 10Aude) [20:19:06] Lydia_WMDE_: hi [20:19:36] legoktm: She's away for a bit. [20:19:47] legoktm: the bot for the new properties in the weekly summary still doesn't seem to work :( [20:20:00] Wait, shes back :O [20:20:04] gr [20:20:10] JohnLewis: kinda back again [20:20:18] ;-) [20:20:19] Lydia_WMDE_: :P [20:23:06] aah [20:23:13] this is pretty stupid [20:23:24] my code was looking for '* Newest properties: ' <-- with a trailing space [20:23:32] -.- [20:34:13] Lydia_WMDE_: ok, fixed. it should work if there is a trailing space or not :P [20:34:29] great [20:34:34] thanks [22:13:34] Lydia_WMDE_: still around? [23:14:11] https://test.wikidata.org/wiki/Q4976634 [23:37:33] legoktm: What am I looking at? [23:38:04] A broken page [23:38:10]