[05:32:26] is there a place where the new properties can be found ? [05:34:13] special:newpages, set namespace filter to property [06:00:29] http://ultimategerardm.blogspot.nl/2013/09/wikimedia-foundation-has-official.html [06:00:34] there is only one [06:01:47] awkward. [06:01:55] maybe we should rename it to "main website"? [06:02:15] I think it is an appropriate name [06:02:25] for most cases yes [06:02:48] it is the one where official news et al is stated [06:03:10] aimed at the outside of the organisation [06:45:24] (03Abandoned) 10Tpt: (bug 47071) Allow use of the Lua API on a Wikibase repository [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/62321 (owner: 10Tpt) [07:44:24] (03PS15) 10Tobias Gritschacher: Use cucumber for aliases tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83089 [08:34:22] Sounds odd parts of summaries have vanished.. [08:59:50] (03CR) 10Addshore: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore) [09:00:26] (03CR) 10Jeroen De Dauw: [C: 032] Reuse duplicate code in LinkTitles [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82596 (owner: 10Addshore) [09:09:28] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#783 (master - 3bee0a2 : Jeroen De Dauw): The build has errored. [09:09:28] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/65f5d3ac5648...3bee0a2545f0 [09:09:28] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11228512 [09:18:28] Tobi_WMDE, addshore: https://bugzilla.wikimedia.org/show_bug.cgi?id=54005 [09:25:35] (03CR) 10Jeroen De Dauw: [C: 032] Stop using deprecated contentfactory singleton [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82597 (owner: 10Addshore) [09:27:50] Lydia_WMDE_: can you check with people about https://bugzilla.wikimedia.org/53395 ? [09:27:57] works for me [09:28:18] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore) [09:30:15] (03CR) 10Jeroen De Dauw: "Why does this have a -2? Looks like it should have a -1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82234 (owner: 10Addshore) [09:31:25] (03CR) 10Jeroen De Dauw: [C: 04-1] Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [09:32:02] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#784 (master - b7f790d : Jeroen De Dauw): The build passed. [09:32:02] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/3bee0a2545f0...b7f790dfd96a [09:32:02] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11229282 [09:32:43] addshore: https://www.wikidata.org/w/index.php?title=Q327991 [09:33:29] (03CR) 10Jeroen De Dauw: "This change adds a pile of procedural code. Please create new classes if your new behaviour does not fit in existing ones, rather then add" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [09:33:29] huh, i wonder if it's a particular api module that's causing that [09:33:33] setclaimvalue? [09:33:42] does not occur with setclaim [09:34:00] or in the UI [09:35:26] looks like the user was editing rapidly, probably with a gadget or script [09:35:54] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore) [09:35:57] * aude suspects wbcreateclaim [09:37:51] (03PS4) 10Jeroen De Dauw: Let ClaimsSerializer implements Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 (owner: 10Umherirrender) [09:39:31] (03CR) 10Jeroen De Dauw: [C: 032] "Indeed, already tested." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 (owner: 10Umherirrender) [09:41:07] (03Merged) 10jenkins-bot: Let ClaimsSerializer implements Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 (owner: 10Umherirrender) [09:43:58] aude: will have a look [09:59:52] (03PS11) 10Daniel Werner: (bug 52387) Introduction of FetchedEntityContentSerializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83646 [10:00:04] (03PS2) 10Daniel Werner: Performance improvement in FetchedEntityContentSerializer::getSerialized [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83689 [10:01:02] (03PS1) 10Tobias Gritschacher: Support coordinate and entityidvalue in autossummaries [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83780 [10:04:01] (03CR) 10jenkins-bot: [V: 04-1] Support coordinate and entityidvalue in autossummaries [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83780 (owner: 10Tobias Gritschacher) [10:13:14] (03PS2) 10Tobias Gritschacher: Support coordinate and entityidvalue in autossummaries [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83780 [10:13:39] (03CR) 10jenkins-bot: [V: 04-1] Support coordinate and entityidvalue in autossummaries [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83780 (owner: 10Tobias Gritschacher) [10:15:01] (03CR) 10Aude: [C: 032] Match changes in Wikibase QueryEngine [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83629 (owner: 10Jeroen De Dauw) [10:16:34] (03Merged) 10jenkins-bot: Match changes in Wikibase QueryEngine [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83629 (owner: 10Jeroen De Dauw) [10:18:57] (03PS8) 10Aude: (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [10:18:58] (03PS2) 10Aude: Remove SimpleQuery::CACHE_TTL_IN_SECONDS [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83098 (owner: 10Daniel Werner) [10:19:09] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#40 (master - 7bfdecf : jeroendedauw): The build has errored. [10:19:09] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/741079183e32...7bfdecfa0979 [10:19:09] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/11230422 [10:20:46] (03CR) 10Daniel Werner: "Could we perhaps start putting those definitions in their own files? Would be a much better feeling to have smaller widget files." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80543 (owner: 10Henning Snater) [10:23:45] DanielK_WMDE: aude: https://gerrit.wikimedia.org/r/#/c/83780/ bugfix for the broken summaries [10:24:11] it's ugly, hoefully we could use formatters soon [10:34:26] aude: hello! [10:36:38] (03PS1) 10Jeroen De Dauw: Added getClaimGuidParser and initial usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83781 [10:36:39] (03PS1) 10Jeroen De Dauw: make getEntityIdForClaim use ClaimGuidParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83782 [10:37:40] (03CR) 10Daniel Kinzler: [C: 04-1] "Just use a TypedValueFormatter? That would be slightly less ugly :)" [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83780 (owner: 10Tobias Gritschacher) [10:38:26] Tobi_WMDE: better still, help reviewing the SnakFormatter stuff :) [10:38:36] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/82400/ [10:38:51] (03CR) 10Addshore: [C: 032] Added getClaimGuidParser and initial usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83781 (owner: 10Jeroen De Dauw) [10:39:24] DanielK_WMDE: the fix/change is for the deployment branch only [10:39:59] (03CR) 10Addshore: [C: 032] make getEntityIdForClaim use ClaimGuidParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83782 (owner: 10Jeroen De Dauw) [10:41:08] (03Merged) 10jenkins-bot: Added getClaimGuidParser and initial usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83781 (owner: 10Jeroen De Dauw) [10:42:29] (03Merged) 10jenkins-bot: make getEntityIdForClaim use ClaimGuidParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83782 (owner: 10Jeroen De Dauw) [10:48:24] (03CR) 10Tobias Gritschacher: "I guess it did also not work for coordinates in wbcreateclaim and wbremoveclaim. It did work for wbsetclaim (which is used by the UI) beca" [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83780 (owner: 10Tobias Gritschacher) [10:48:50] DanielK_WMDE: // FIXME: this is using the deprecated EntityId constructor and a hack to get the [10:49:59] i pragunbhutani [10:50:01] hi [10:52:44] hello [10:52:49] how did the deployment go? [10:53:04] pragunbhutani: pretty well, it seems! [10:53:32] DanielK_WMDE: that's good to know! :) [10:54:14] aude: can you help me with the getting of the actual data today? [11:03:54] (03PS1) 10Tobias Gritschacher: Support multiple browsers when running cucumber tests locally [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83790 [11:04:27] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Support multiple browsers when running cucumber tests locally [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83790 (owner: 10Tobias Gritschacher) [11:17:27] pragunbhutani: sure [11:24:04] (03PS17) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 [11:24:11] that was an ugly rebase ;_; [11:24:13] (03CR) 10jenkins-bot: [V: 04-1] Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 (owner: 10Addshore) [11:24:16] oh... [11:24:18] :> [11:25:26] (03PS18) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 [11:28:17] (03Abandoned) 10Addshore: Add badges check to getentities test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82246 (owner: 10Addshore) [11:28:42] (03CR) 10jenkins-bot: [V: 04-1] Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 (owner: 10Addshore) [11:34:12] liangent: whats recently been merged to do with languages? :/ [11:34:58] ie. if i pass these alnguages to wbgetentities what will now fail..? :P 'de', 'zh', 'it|es|zh|ar', 'de|nn|no|en|en-gb|it|es|zh|ar' [11:40:35] liangent: :/ https://integration.wikimedia.org/ci/job/mwext-Wikibase-testextensions-master/4363/consoleFull [11:44:43] ahhh, I guess you can no longer set entites with a lang of no... therefor the tests never manage to create the language to check it can be 'got' again.. [11:46:07] (03PS19) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 [11:49:21] (03CR) 10jenkins-bot: [V: 04-1] Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 (owner: 10Addshore) [11:52:49] (03PS20) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 [11:53:09] (03PD1) 10Addshore: use lang nb instead of no in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83791 [11:57:20] (03PS7) 10Addshore: Restrict ItemByTitleHelper site/title combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 [12:04:23] (03PS8) 10Addshore: Restrict ItemByTitleHelper site/title combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 [12:10:04] hi guys [12:10:05] um [12:10:23] hi :P [12:10:44] could somebody tell me, why is the last edit on „Barack Obama” (Q76) https://www.wikidata.org/w/index.php?title=Q76&action=history "(+7290)", when my bot only modified the description in polish? [12:10:56] because i'm all like, wtf [12:11:09] its due to changes in the structure of the data as it is stored in the database [12:11:14] which is not visible ;p [12:11:22] how did the format change this much? D: [12:11:37] i almost had a heart attack when i saw this, y'know. [12:11:45] its due to a new array for sitelinks that will contain badges [12:12:00] currently it would appear everysitelink has this array even if empty [12:12:17] it looks like it might be an idea to only add it if badges are present though :P [12:12:47] why is the byte size even shown on histories etc. if it makes no sense? [12:13:02] couldn't you show some "things count" in there instead? [12:13:10] heh, well usually it is quite accurate :P there is a bug for it btw :) [12:13:12] (claims, sitelinks, descriptions, badges, everything) [12:13:34] heh [12:13:37] https://bugzilla.wikimedia.org/show_bug.cgi?id=39189 [12:13:45] [= [12:22:17] huh, i've just seen the weirdest bug. one of edit summaries on https://www.wikidata.org/wiki/Special:Contributions/MatmaBot didn't show [12:22:21] it appeared when i refreshed [12:22:32] (it was the one for Q9372024) [12:25:17] MatmaRex: i think we are aware, if it's what i'm thinking of [12:25:50] oh, i think i have seen that (it's something else) and not sure why [12:26:12] could be links update or some secondary update maybe [12:29:09] hm. okay. [14:17:38] Lydia_WMDE_, aude: https://www.mediawiki.org/wiki/Requests_for_comment/TitleValue [14:18:57] Is it possible to to put template data in Wikidata? e.g. Taxobox it has many argument for conservation status system. [14:19:43] (03PS1) 10Jeroen De Dauw: Split method in ByPropertyValueEntityFinder [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83800 [14:22:11] addshore: can haz merge https://gerrit.wikimedia.org/r/#/c/83800/1 ? Fixes the outlier here https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-WikibaseQuery/code-structure/search/worst-rated-operations [14:23:45] (03CR) 10Addshore: [C: 032] "small functions :D" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83800 (owner: 10Jeroen De Dauw) [14:25:09] (03Merged) 10jenkins-bot: Split method in ByPropertyValueEntityFinder [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83800 (owner: 10Jeroen De Dauw) [14:28:01] aude: addshore: DanielK_WMDE: so, do we want to get this fix deployed today, or not? https://gerrit.wikimedia.org/r/#/c/83780/ [14:28:54] * aude was just giving it a +1 [14:29:10] i'd prefer DanielK_WMDE remove the -1 before i give it +2 :) [14:29:47] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#41 (master - eb4fcf1 : jeroendedauw): The build has errored. [14:29:47] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/7bfdecfa0979...eb4fcf112226 [14:29:47] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/11239042 [14:44:07] addshore: so now the most evil thing is https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-WikibaseQuery/code-structure/operation/Tests%5CIntegration%5CWikibase%5CQuery%5CQueryEntitySerializationTest%3A%3AnewQueryEntitySerialization [14:44:13] hard to improve that though [14:44:27] Tobi_WMDE: is the intended behavior of summary to append the user/bot summary after the automatic summary [14:44:30] e.g. coordinates [14:45:17] aude: yes [14:45:26] hmmm [14:45:27] ok [14:45:39] doesn't appear to do that in create claim [14:45:42] it will be e.g. "Created caim: [14:45:51] no coordinates? [14:45:53] (03PS1) 10Jeroen De Dauw: Add Scrutinizer config [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83802 [14:46:06] not Created claim: -37, 48 [14:46:07] (03CR) 10Jeroen De Dauw: [C: 032] Add Scrutinizer config [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/83802 (owner: 10Jeroen De Dauw) [14:46:22] aude: no, usersummary -replaces- autosummary [14:46:25] ok [14:46:32] (03PS3) 10Jeroen De Dauw: SimpleTableSchemaUpdater [DNM] [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83645 [14:46:32] then not a bug :) [14:46:35] no [14:46:41] but could be smarter [14:47:01] we decided to do it the easy way first [14:47:03] fyi, set claim does not accept my summary [14:47:07] that is a bug [14:47:15] addshore: seriously, if you want to find the most critical things to fix in some component, look at phpunit --coverage-html [14:47:20] otherwise we have to check the length, and if the user summary fits add both, if not, remove the autosummary aso [14:47:23] ok [14:47:25] makes sense [14:47:40] (03PS2) 10Jeroen De Dauw: Remove system tests from phpunit config as this group cannot be run via the normal runner [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83408 [14:47:49] (03CR) 10Jeroen De Dauw: [C: 032] Remove system tests from phpunit config as this group cannot be run via the normal runner [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83408 (owner: 10Jeroen De Dauw) [14:47:54] (03CR) 10Jeroen De Dauw: [V: 032] Remove system tests from phpunit config as this group cannot be run via the normal runner [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/83408 (owner: 10Jeroen De Dauw) [14:48:02] aude: setClaim is the only module not using changeops yet and so it does not support custom summaries yet [14:48:17] ok [14:48:34] but there's a patch from addshore I think [14:48:39] that's fine [14:48:53] not an oversight [14:49:02] but I think it's held back until the claim guid stuff is merged/fixed/discussed [14:49:18] i think only my bot uses set claim :) [14:49:31] or at least only my bot creates claims with it [14:49:48] * aude happy with the auto summaries [14:50:16] (03CR) 10Aude: [V: 032] "verified" [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83780 (owner: 10Tobias Gritschacher) [14:53:01] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#42 (master - 308a285 : jeroendedauw): The build has errored. [14:53:01] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/eb4fcf112226...308a285577c2 [14:53:01] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/11239915 [14:55:24] legoktm: did you see my mail on the data model? [14:56:17] Abraham_WMDE1: y u invite my wmde account? ;p [14:57:25] DanielK_WMDE: do you mind if i +2 https://gerrit.wikimedia.org/r/#/c/83780/ ? [14:57:40] can you please revisit that [15:03:58] JeroenDeDauw: Yeah I did, just never got around to responding to it. will do tonight. [15:06:16] legoktm: hmm sure. If there is no interest in this, that's to bad, but not a big deal :) [15:12:48] JeroenDeDauw: yes. that was intended for the google doc [15:12:50] :) [15:21:16] Abraham_WMDE1: oh ok [15:29:07] (03PS4) 10Jeroen De Dauw: Added basic test for SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83645 [15:30:00] (03CR) 10Jeroen De Dauw: [C: 032] use lang nb instead of no in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83791 (owner: 10Addshore) [15:34:01] (03CR) 10Jeroen De Dauw: "(5 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore) [15:34:15] (03PD2) 10Addshore: Put all specialpages in their own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83804 [15:34:49] (03PS3) 10Jeroen De Dauw: Put all specialpages in their own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83804 (owner: 10Addshore) [15:36:13] (03CR) 10Jeroen De Dauw: [C: 032] Put ALL specialpages in their own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83804 (owner: 10Addshore) [15:37:47] (03Merged) 10jenkins-bot: Put ALL specialpages in their own namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83804 (owner: 10Addshore) [15:38:10] :D [16:06:03] addshore: that is not merged yet [16:07:02] see what I said afterwards :) [16:13:32] addshore: didn't find it... [16:13:42] omnom http://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [16:16:52] omnom http://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [16:21:32] Danwe_WMDE: DanielK_WMDE addshore http://www.lieferando.de/lieferservice-pizza-bulls-hohenstaufen-berlin#! [16:24:10] JeroenDeDauw: Pizza Otawa [16:24:19] ("single") [16:36:13] DanielK_WMDE: check entityview again? [16:37:59] (03PS1) 10Jeroen De Dauw: Implementation work in SimpleTableSchemaUpdater [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83815 [16:38:03] liangent: just finishing up the json dumper and then doing reviews [16:39:44] (03PS1) 10Daniel Kinzler: (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 [16:41:26] (03CR) 10jenkins-bot: [V: 04-1] (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 (owner: 10Daniel Kinzler) [17:02:38] DanielK_WMDE: btw does it matter if I break the interface of PropertyParserFunction class? [17:03:25] or what's the generic answer for a unspecific class? [17:04:31] liangent: it depends on the numbder of users of the interface. PropertyParserFunction only has one user (it's triggered by the parser hook) [17:04:35] so it really doesn't matter [17:05:44] Daok [17:05:47] DanielK_WMDE: ok [17:07:11] 4 Warning: assert() [function.assert]: Assertion failed in /usr/local/apache/common-local/php-1.22wmf16/extensions/WikibaseDataModel/DataModel/Claim/Claims.php on line 276 [17:07:37] Reedy: on the live site? [17:07:42] yeah [17:07:49] how often? [17:09:09] JeroenDeDauw, addshore: might be due to upper case IDs in claim IDs ----^ [17:09:41] oh god, not that assert... [17:09:46] :P [17:11:17] Reedy: please file it if it isn't screwing with the site [17:16:56] (03PS2) 10Daniel Kinzler: (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 [17:18:42] (03CR) 10jenkins-bot: [V: 04-1] (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 (owner: 10Daniel Kinzler) [17:30:24] (03CR) 10Daniel Kinzler: [C: 04-1] "As per jeroen's comments." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore) [17:38:15] (03CR) 10Daniel Kinzler: [C: 032] Support coordinate and entityidvalue in autossummaries [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/83780 (owner: 10Tobias Gritschacher) [17:38:58] does this look ok as a reference to the claim which MediaWiki version is stable ? :) https://www.wikidata.org/w/index.php?title=Q83&diff=prev&oldid=69688319 [17:47:03] mutante: I'd use https://www.mediawiki.org/wiki/MediaWiki_stable or https://www.mediawiki.org/wiki/Template:MW_stable_release_number tbh. [17:47:32] The first one states the branch while the second one states the actual stable version. [17:47:54] Also the MediaWiki main page doesn't say x.xx.x is the stable version :p [17:47:55] JohnLewis: i like that, i'll change it to the template. thanks [17:48:01] Welcome. [17:48:46] aude: so how can I start getting the actual data? [17:49:18] I see a missing tooltip [17:49:44] Next to Add source [17:49:51] JohnLewis: added both:) [17:50:11] mutante: Fair enough :p [17:50:21] Reedy: we could keep langlist in wikidata? :p [17:50:29] Reedy :O Misleadind you say? [17:50:52] Wait, Mis read :p [17:51:15] Reedy: https://gerrit.wikimedia.org/r/83678 ... :P [17:51:16] Hovering over [?] gives an empty speech bubble [17:51:23] Yeah [17:51:29] Should I file a bug? [17:51:33] Or just beat hoo and addshore? [17:52:00] I didn't ~~break~~ touch these in quite a while [17:52:39] Should I file a bug? [17:53:02] I didn't really follow up, where's it broken? [17:53:21] https://www.wikidata.org/wiki/Q4063270 [17:53:23] Add source [17:53:33] [save|cancel][?] [17:53:41] Mouse over the [?] get an empty bubble [17:54:25] DanielK_WMDE: I am sorry, I have no clue why https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/3804/consoleFull fails :( [17:54:39] Reedy: I see [17:54:42] hashar: doesn't fail for me locally [17:54:48] You fix? [17:54:49] :p [17:54:52] hashar: can you make jenkins run with --debug-tests and check the logs? [17:55:13] DanielK_WMDE: is that a parameter to our phpunit.php ? [17:55:49] hashar: yes. you need to actually send the log somewhere though. $wgDebugLogGroups['PHPUnitCommand'] = "/tmp/tests.log"; [17:55:55] Reedy: On it [17:55:56] hashar: you merged that change, btw :) [17:55:59] Thanks! [17:56:24] oh man wgDebugLogGroups .. [17:56:54] DanielK_WMDE: I should inject some configuration to log everything and publish the resulting debug log file somewhere [17:57:31] Reedy: buying pizza might help [17:57:49] DanielK_WMDE: test pass now https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/3806/consoleFull [17:58:18] DanielK_WMDE triggering it again without --debug-tests https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/3807/consoleFull [17:59:00] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=51575 [17:59:35] hashar: huh. thanks :P [17:59:38] (show/hide) 17:47, 11 September 2013 (diff | hist) . . (+1,980)‎ . . AutoWikiBrowser (Q4063270) ‎ (‎Changed claim: stable version (P348): 5.5.1.3) [17:59:45] https://www.wikidata.org/w/index.php?title=Q4063270&diff=prev&oldid=69689926 [17:59:49] Uhh, what? +1980!? [18:00:01] DanielK_WMDE: passing now. No idea what went wrong. [18:00:20] Reedy: its a lot of empty arrays for storing badges >.< [18:00:29] DanielK_WMDE: maybe one of the dependencies or mediawiki has been changed in between? [18:00:31] Oh.. [18:00:39] more worrying is when you remove a few chars and it goes up by 8000... [18:01:02] (03PS3) 10Hashar: (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 (owner: 10Daniel Kinzler) [18:01:16] (03CR) 10Hashar: "submitting new patch to retrigger test suite." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 (owner: 10Daniel Kinzler) [18:01:42] Is it OK that the "[Help with translations!]" links shows through the search autocomplete dropdown? [18:02:39] addshore, Reedy: we could fix that by changing how the size is counted. EntityContent::getSize [18:02:41] AVRS: It shouldn't really. [18:03:04] (03CR) 10jenkins-bot: [V: 04-1] (bug 52799) Introducing dumpJson. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83816 (owner: 10Daniel Kinzler) [18:03:19] hashar: ---^ [18:04:24] AVRS: where? [18:05:19] addshore: There is an announcement "Let your voice be heard!" with that link. Enter something in the Search field at the top, the drop-down covers the announcement, but not the link.. [18:06:24] addshore: the ann. is not at Watchlist. [18:07:40] not sure i follow :/ [18:08:14] addshore: will you be able to fix it? [18:08:24] (should I make a screenshot?) [18:08:58] ahh wait *switches to vector* [18:09:04] ah, right [18:09:34] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83815 (owner: 10Jeroen De Dauw) [18:09:36] I let the thought about themes away because it's Wikidata [18:09:38] (03PS1) 10Hoo man: Fix tooltip dependencies for jquery.wikibase.snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83835 [18:09:41] Reedy: ^ [18:10:02] untested, though (I don't have working WB environment atm... to many extension splits) [18:10:04] hoo: by chance, will that also fix the "URL" autocompletion at language-specific domains? [18:10:18] hoo: as mentioned in https://bugzilla.wikimedia.org/show_bug.cgi?id=51575 [18:10:36] Maybe that bug can also be fixed then. [18:10:49] addshore: are badges not exposed in the API? i assume https://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q4063270&format=jsonfm should have empty arrays in it... [18:11:59] AVRS: Works for me... what's broken there? [18:12:47] hoo: Nothing is broken. Just text appearing over the search box :p [18:12:54] hoo: at en.wikidata.org, ru.wikidata.org, the property field for "URL" won't appear. [18:12:55] legoktm: hmm, looks like the badges arrays are not actually the cause of the massive change in size [18:13:10] just the shuffle of the sitelinks from a string into an array [18:13:18] hoo: — just like one for the "language" property sometimes. But it works at www.wikidata.org [18:14:10] legoktm: they should be exposed, and should appear as "badges": [] in the sitelinks array [18:14:11] We have sub domains O_O [18:14:21] JohnLewis: I just noticed. Unfortunately [18:14:24] addshore: https://gerrit.wikimedia.org/r/83835 [18:14:38] addshore: do they automatically get added or do i have to add/remove a sitelink? [18:14:47] (03PS2) 10Hoo man: Fix tooltip dependencies for jquery.wikibase.snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83835 [18:15:34] JohnLewis: not sure what the point of them is [18:16:03] legoktm: honestly at this stage I have no idea :P [18:16:05] AVRS: the goal is/was? that en.wikidata.org/wiki/Barack Obama would redirect to the item for Barack in english [18:16:18] new entities should have them, and old entities should get them when needed [18:16:27] legoktm: ah, ok [18:16:44] everything should redirect to www though [18:16:53] there were issues with tokens and stuff on non www. domains [18:17:50] AVRS: someone is going to fix the link for you :) [18:18:56] addshore: thanks :) [18:19:20] (03PS16) 10Liangent: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [18:21:08] (03CR) 10jenkins-bot: [V: 04-1] Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [18:21:30] Is there a proposal or something else for software versions? Currently only describing the latest most stable version is described. [18:21:41] *The latest version of the most stable branch [18:21:42] legoktm: ui guess you actually only see the badges array wyhen it is used. see https://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q14901041&format=jsonfm also doesnt have them [18:22:02] AVRS: Stable version only really. [18:22:09] hmmm [18:22:27] addshore: has the API for adding them been merged yet? [18:22:37] nope [18:22:39] not as far as I know [18:22:43] can i do it with editentity though? [18:22:52] i just dont know what the serialization would look like... [18:22:53] not as far as I know :P [18:22:57] Wikipedias have "latest test version" field in the infobox… [18:22:57] infact, no you cant [18:23:14] cant add badges anywhere yet [18:23:25] AVRS: You are more than welcome to suggest it. [18:23:51] There is, of course, more than can be described. But at least a codename property may be useful. [18:24:05] History, however, is not considered at all atm. [18:24:15] Except for "foundation/creation date". [18:24:52] (03PS17) 10Liangent: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [18:25:50] JohnLewis: without thinking of the people making Lua templates for Wikipedias, I'd rename the property into ≈"a version" and specify the type with a qualifier, and whether it is still a supported latest version [18:26:08] But I don't know Lua, so I won't. [18:26:27] Even English Wikipedia doesn't use the version from Wikidata, IIRC. [18:26:40] So I'd rather not make it more complicated. :/ [18:27:51] (03PS18) 10Liangent: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [18:28:12] Maybe having a complete history would make templates slower, too? [18:28:52] (03PS19) 10Liangent: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [18:29:23] What is clearly needed is support for "long term support" releases. [18:30:26] I can just add it as another version, but templates will break. [18:30:30] (03CR) 10jenkins-bot: [V: 04-1] Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [18:30:53] putnik: ^ [18:31:00] Maybe that's a problem of the templates though. [18:31:44] (03CR) 10Liangent: "The old "PropertyParserFunction" class was mostly renamed to “PropertyParserFunctionRenderer” except for some static logic, which was left" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [18:33:06] (03PS20) 10Liangent: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [18:49:32] liangent: as often, my brain is too mushy to fully understand your changes once i get around to reviewing. will try to start out with that tomorrow. [18:53:43] DanielK_WMDE: is there something I should do to make my change easier to understand? [18:54:33] AVRS, hi. I think it's a good idea to use stable/test/etc as qualifier. [18:54:59] DanielK_WMDE: and see https://gerrit.wikimedia.org/r/#/c/71996/ : an initially 25 line change has finally grown to +489, -214 [18:56:19] putnik: the date property breaks then: only one date is used [18:56:28] hi [18:56:44] Or something like that happens. [18:56:53] AVRS, anyway we need the method to get one of the property values by the qualifier. Version is not the exeption. [18:57:09] AVRS, why it will break? [18:57:36] putnik: I mean, when I tried adding more versions like that, the existing templates in ruwiki didn't work [18:57:56] DanielK_WMDE: actually the PropertyParserFunction refactoring work can be done in a separate change, and do variant stuff after refactoring is merged (depending on a refactoring isn't a good idea, which would create massive conflicts) [18:58:13] but that would of course take longer [18:58:33] and the current reviewing waiting time is already long enough [18:58:40] AVRS, of course, ruwiki template is very simple, and just die in hard cases =) [18:59:18] AVRS, we should extend Wikidata module for cases like this, but I have no time just now. [19:00:15] AVRS, and without module I can't improve version template, sorry. [19:00:25] ok [19:01:26] (03PS1) 10Aude: Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 [19:01:28] AVRS, but it's not the reason to do nothing in Wikidata =) [19:03:54] (03CR) 10jenkins-bot: [V: 04-1] Store serialized entity in parser output (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/83846 (owner: 10Aude) [19:04:07] AVRS, I can change template to use first value, if you want. [19:05:29] putnik: I wouldn't trust any order in Wikidata [19:06:43] putnik: even if it's "first" by date, it could be LTS/ESR [19:08:18] AVRS, no, firts by order. I can't order of filter properties by qualifiers using current templates or modules =( [19:09:18] AVRS, maybe somebody from other Wikipedia already create module for this, but I really don't have time for research it now. [19:09:35] putnik: that reminds me: I tried to add some date value to some infobox, and couldn't because there was no template [19:11:05] AVRS, ha-ha, I know. I tried too =) [19:31:09] pragunbhutani: poke [19:38:18] (03CR) 10Jeroen De Dauw: "(1 comment)" [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/83815 (owner: 10Jeroen De Dauw) [19:38:20] aude: hello [19:39:27] aude: I saw the patch! [19:40:08] addshore: skimmed though logs from today [19:40:14] and just today I began modifying the skin to read from a serialized input instead of being hard-coded :D [19:40:19] edits size, hehe [19:40:35] re getting and empty badges -> there's a prop for them [19:40:41] just not in defaults now [19:40:46] editing patch changes that [19:41:11] but it's still DNM, will work on weekkend to get it ready for review [19:41:29] legoktm: ^ [19:41:39] ah ok [19:41:41] thanks [19:41:55] Ahh yes xD totally forgot about the prop.... [19:42:05] I even wrote the test for it..... [19:42:11]