[00:12:25] (03PS3) 10Aude: (bug 53678) add backwards compatiblity for change dispatcher with badges [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/82235 [00:26:56] (03PS4) 10Aude: (bug 53678) add backwards compatiblity for change dispatcher with badges [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/82235 [00:39:03] (03CR) 10Aude: [C: 04-1] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82638 (owner: 10Daniel Kinzler) [00:46:52] (03PS5) 10Aude: (bug 53678) add backwards compatiblity for change dispatcher with badges [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/82235 [07:39:57] (03CR) 10Zfilipin: [C: 031] Cucumber: simplify css selectors for labels and descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81926 (owner: 10Tobias Gritschacher) [08:37:30] (03CR) 10Tobias Gritschacher: [C: 032] Cucumber: simplify css selectors for labels and descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81926 (owner: 10Tobias Gritschacher) [08:39:22] (03Merged) 10jenkins-bot: Cucumber: simplify css selectors for labels and descriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81926 (owner: 10Tobias Gritschacher) [08:49:11] http://ultimategerardm.blogspot.nl/2013/09/10-questions-about-viaf-wikidata-and.html [09:17:32] (03PS1) 10Daniel Kinzler: Make ExternalChangeLine more robust. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82812 [09:24:34] (03PS3) 10Addshore: Get rid of old EntityId Usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81652 [09:24:51] (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82638 (owner: 10Daniel Kinzler) [09:29:17] (03PS2) 10Daniel Kinzler: Fix B/C mode of SiteLinkCommentCreator. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82638 [09:30:41] (03PS2) 10Addshore: Fix SQLiteTableSqlBuilderTest default values. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82606 [09:30:42] (03PS2) 10Addshore: Add sqlite indexes support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82609 [09:32:20] (03CR) 10Addshore: [C: 032] Match EntityId changes in DataModel [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/82617 (owner: 10Jeroen De Dauw) [09:32:34] (03Merged) 10jenkins-bot: Match EntityId changes in DataModel [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/82617 (owner: 10Jeroen De Dauw) [09:33:10] (03CR) 10Addshore: [C: 032] Add foundations for schema updating functionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82633 (owner: 10Jeroen De Dauw) [09:33:14] (03Merged) 10jenkins-bot: Add foundations for schema updating functionality [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82633 (owner: 10Jeroen De Dauw) [09:34:10] (03CR) 10Addshore: [C: 032] Move b/c code for ClaimObject and StatementObject to a better location [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81951 (owner: 10Jeroen De Dauw) [09:36:07] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQueryEngine#78 (master - aa53f20 : jeroendedauw): The build was fixed. [09:36:07] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQueryEngine/compare/f62b686e679d...aa53f20b2fdf [09:36:07] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQueryEngine/builds/11008774 [09:42:09] (03CR) 10Daniel Kinzler: [C: 04-1] "(3 comments)" [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/82235 (owner: 10Aude) [09:49:26] 50% of the cemeteries are in France :D http://toolserver.org/~magnus/ts2/wdstats/?q={%22r%22:[{%22p%22:31,%22i%22:39614}],%22p%22:%22p17%22} [09:57:05] (03CR) 10Tobias Gritschacher: [C: 032] Fix B/C mode of SiteLinkCommentCreator. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82638 (owner: 10Daniel Kinzler) [09:58:38] (03Merged) 10jenkins-bot: Fix B/C mode of SiteLinkCommentCreator. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82638 (owner: 10Daniel Kinzler) [10:01:55] (03CR) 10Daniel Kinzler: [C: 032] Get rid of old EntityId Usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81652 (owner: 10Addshore) [10:03:23] (03Merged) 10jenkins-bot: Get rid of old EntityId Usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81652 (owner: 10Addshore) [10:05:39] (03PS2) 10Addshore: Implement ClaimGuid class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 [10:07:38] (03CR) 10Tobias Gritschacher: [C: 032] Make ExternalChangeLine more robust. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82812 (owner: 10Daniel Kinzler) [10:09:10] (03Merged) 10jenkins-bot: Make ExternalChangeLine more robust. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82812 (owner: 10Daniel Kinzler) [10:14:39] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 (owner: 10Addshore) [10:23:46] (03CR) 10Daniel Kinzler: [C: 04-1] "As per comments to PS 11; These should be addressed or at least get a reply." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore) [10:24:48] Tobi_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=52501 [10:28:43] (03CR) 10Daniel Kinzler: [C: 04-1] "as per earlier comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore) [10:31:10] aude: you're here? [10:33:40] (03PS3) 10Addshore: Implement ClaimGuid class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 [10:58:57] (03PS16) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [10:59:24] (03CR) 10Addshore: "Addressed the comments left in PS11 (sorry these were missed)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore) [10:59:36] (03CR) 10Addshore: "(6 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore) [11:01:24] (03PS24) 10Addshore: Implement merge api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 [11:01:45] (03CR) 10Addshore: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79988 (owner: 10Addshore) [11:07:30] (03CR) 10Daniel Kinzler: [C: 032] Improvements to EntityPerPageBuilderTest. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81557 (owner: 10Jeroen De Dauw) [11:08:59] (03Merged) 10jenkins-bot: Improvements to EntityPerPageBuilderTest. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81557 (owner: 10Jeroen De Dauw) [11:09:40] (03CR) 10Daniel Kinzler: [C: 04-1] "As per Tobi's comment." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 (owner: 10Addshore) [11:11:02] (03CR) 10Daniel Kinzler: [C: 04-2] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore) [11:12:32] (03PD16) 10Addshore: Add editentity claims support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 [11:12:56] (03CR) 10Daniel Kinzler: [C: 04-2] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82234 (owner: 10Addshore) [11:16:11] (03PS4) 10Addshore: Restrict ItemByTitleHelper site/title combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 [11:16:17] (03CR) 10jenkins-bot: [V: 04-1] Restrict ItemByTitleHelper site/title combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore) [11:17:03] (03PS5) 10Addshore: Catch div zero error in ItemByTitleHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 [11:17:26] (03PS1) 10Tobias Gritschacher: (bug 52501) don't break diff when dataValue could not be formatted [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82815 [11:18:03] (03Abandoned) 10Tobias Gritschacher: (bug 52501) don't break diff when dataValue could not be formatted [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82815 (owner: 10Tobias Gritschacher) [11:18:06] (03CR) 10Addshore: [C: 04-2] "This is the wrong patch.." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore) [11:19:30] (03PS1) 10Tobias Gritschacher: (bug 52501) don't break diff when dataValue could not be formatted [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82816 [11:21:57] (03CR) 10Denny Vrandecic: [C: 032] (bug 52501) don't break diff when dataValue could not be formatted [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82816 (owner: 10Tobias Gritschacher) [11:22:13] (03PS6) 10Addshore: Restrict ItemByTitleHelper site/title combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 [11:23:30] (03Merged) 10jenkins-bot: (bug 52501) don't break diff when dataValue could not be formatted [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82816 (owner: 10Tobias Gritschacher) [11:24:58] (03CR) 10Daniel Kinzler: [C: 04-1] "Much better, thanks! But please make the new functions public and provide test cases." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [11:25:00] (03CR) 10Addshore: Restrict ItemByTitleHelper site/title combinations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore) [11:25:33] liangent: ^--- i feel a bit bad about pushing that back to you again, but i think having tests for this is important. [11:26:17] DanielK_WMDE: generally what's the consideration between private/protected/public? [11:26:49] (03CR) 10Addshore: [C: 032] Move b/c code for ReferenceObject to a better location [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81949 (owner: 10Jeroen De Dauw) [11:26:58] (03Merged) 10jenkins-bot: Move b/c code for ClaimObject and StatementObject to a better location [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81951 (owner: 10Jeroen De Dauw) [11:26:59] (03Merged) 10jenkins-bot: Move b/c code for ReferenceObject to a better location [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/81949 (owner: 10Jeroen De Dauw) [11:28:51] (03PS6) 10Daniel Kinzler: (bug 53678) add compatiblity for change dispatcher with badges [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/82235 (owner: 10Aude) [11:29:01] Tobi_WMDE: ---^ [11:29:07] (03CR) 10jenkins-bot: [V: 04-1] (bug 53678) add compatiblity for change dispatcher with badges [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/82235 (owner: 10Aude) [11:30:37] liangent: use private to share code between public functions. use protected very sparingly - it's usually better to use composition, so these functions are public in some helper/component objects [11:30:43] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#750 (mw1.22-wmf16 - b612445 : Tobias Gritschacher): The build passed. [11:30:43] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/f83ded44901f...b6124453bd39 [11:30:43] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11011919 [11:31:38] liangent: protected functions can't be tested, so it's best to avoid them. but cluttering an object's public interface with public methods isn't nice either, so composition/delegation is a good mechanism [11:32:07] in a case like the ParserFunction, which isn't really used anywhere else, it's ok to have the public methods directly there. [11:38:19] hi! [11:39:52] DanielK_WMDE: and how can I test the getInstance function I added just now? [11:40:14] it's returning an object which is impossible to give an "expected" to compare [11:40:19] (03CR) 10Daniel Kinzler: "never mind jenkins, it's using the wrong branch." [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/82235 (owner: 10Aude) [11:40:39] actually it's already tested together with render() [11:41:08] hmm render() is not tested either [11:41:25] addshore: hello :) [11:41:31] afternoon! [11:41:38] liangent: testing smaller functions individually as well as together with the "big" functions is useful because it a) allows us to better locate errors and b) allows us to cover more obscure code pathes more easily. [11:42:08] liangent: for getInstance, it's probably fine to just have a very trivial test that just checks that the object returned has the correct type [11:42:08] addshore: UI for badges is set to be as in mockups from early stages of wd [11:42:16] so a column of starts [11:42:23] such a test mostly makes sure there are no errors or warnings triggered. [11:42:49] and whole sitelink enters edit mode at once [11:42:55] liangent: the other (currently protected) new methods are more interesting, and easier to test, I'd think [11:43:05] DanielK_WMDE: yeah [11:43:17] addshore: so it'd be probably better to extend wbsetsitelinks? [11:43:32] I would guess so :) so the Ui can do it all in one edit [11:43:38] yep [11:43:41] but how? [11:43:48] DanielK_WMDE: can I assume a global object's states in tests? [11:43:49] hmm [11:43:50] badgesset, badgesadd, badgesremove? [11:43:57] seems a bit clutterish [11:44:10] give me 2 ticks, looking for a commit I have burried and I dont want to pile any more stuff on top if it and loose it :> [11:44:21] sure [11:44:31] DanielK_WMDE: or should I set them explicitly? [11:44:32] liangent: no. either make the code not use any global state (which is one reason we try to use dependency injection), or set up the global state before the test. [11:44:38] (and ideally, restore it after) [11:44:55] liangent: but not using any global state is much better [11:45:21] DanielK_WMDE: it seems impossible to save $wgParser's state before resetting it [11:45:28] or should I just use a new parser object? [11:46:18] yes, a new parser object [11:46:39] in fact, $wgParser should be avoided like the plague. [11:50:24] is there assertIsInstance() in phpunit? [11:50:35] or just assertTrue( xxx instanceof yyy ) [11:50:55] liangent: there is something [11:50:57] wait a sec [11:52:36] liangent: http://phpunit.de/manual/3.7/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.assertions.assertInstanceOf [11:53:07] note that you need to provide the class as a string together with namespace [11:54:25] lazowik: thanks [12:12:09] addshore: I'm off to eat [12:12:15] will ping you when I'm back [12:12:19] kk :) [12:14:56] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] (bug 53678) add compatiblity for change dispatcher with badges [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/82235 (owner: 10Aude) [12:15:30] (03PS9) 10Liangent: Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [12:15:38] (03CR) 10jenkins-bot: [V: 04-1] Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [12:19:32] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#751 (mw1.22-wmf14 - c1e96d3 : Tobias Gritschacher): The build has errored. [12:19:32] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/437058622f3a...c1e96d366a5e [12:19:32] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/11013641 [12:19:40] (03PS10) 10Liangent: Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [12:22:17] (03CR) 10jenkins-bot: [V: 04-1] Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [12:24:52] ^ what's the failure here? [12:24:55] I can't find it [12:26:37] (03PS1) 10Tobias Gritschacher: Support coordinate and entityidvalue when generating claim autosummary [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82820 [12:27:17] (03PS2) 10Tobias Gritschacher: Support coordinate and entityidvalue when generating claim autosummary [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82820 [12:27:45] DanielK_WMDE: we need this for deployment: https://gerrit.wikimedia.org/r/#/c/82820/ [12:28:32] DanielK_WMDE: help needed :p [12:34:00] (03PS11) 10Liangent: Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [12:35:36] (03CR) 10jenkins-bot: [V: 04-1] Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [12:38:13] (03PS1) 10Liangent: EMPTY [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82821 [12:41:04] (03Abandoned) 10Liangent: EMPTY [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82821 (owner: 10Liangent) [12:42:13] :O [12:43:25] addshore: ? [12:43:36] for my EMPTY commit? [12:43:36] funny commit ;p EMPTY! :D [12:43:48] addshore: https://gerrit.wikimedia.org/r/#/c/71996/ failed for unknown reason [12:43:56] I was checking whether master is brokwn [12:44:44] addshore: any idea about the reason for that jenkins faiure? [12:44:57] hmm no, youll have to run the tests locally to find out! [12:46:42] liangent: looking [12:50:13] Tobi_WMDE: 3d17f01589de0f0b3cad7c668d1a035f555d5f49 [12:52:27] DanielK_WMDE: but why doesn't an empty commit trigger this error [12:54:57] Tobi_WMDE: https://integration.wikimedia.org/ci/job/mwext-Wikibase-testextensions-master/4217/console [12:56:47] liangent: we arn't sure why this error is always triggered, but we do know the aliases are defined the wrong way around. addshore is fixing it now. [12:57:47] (03PS1) 10Addshore: Fix Aliasing direction [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82823 [12:57:59] DanielK_WMDE: liangent ^^ [12:58:44] (03CR) 10Daniel Kinzler: [C: 032] Fix Aliasing direction [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82823 (owner: 10Addshore) [12:59:15] (03Merged) 10jenkins-bot: Fix Aliasing direction [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82823 (owner: 10Addshore) [13:04:03] DanielK_WMDE: how was it done to request another jenkins run? [13:11:12] liangent: submit another patch (just change the commit message) :) [13:11:23] or rebase [13:11:28] yea, rebase or change the commit message [13:11:34] Tobi_WMDE: which one? [13:11:46] aude: hello [13:11:58] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/82820/ [13:13:04] addshore: I haven't seen daniel do so at https://gerrit.wikimedia.org/r/#/c/71996/ [13:13:40] liangent: i removed and re-added jenkinsbot as a review [13:13:44] that also works, usually [13:14:09] but apparently, it doesn't here [13:14:16] (or it changed at some point, who knows) [13:15:17] (03CR) 10Daniel Kinzler: [C: 032] Support coordinate and entityidvalue when generating claim autosummary [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82820 (owner: 10Tobias Gritschacher) [13:16:49] (03Merged) 10jenkins-bot: Support coordinate and entityidvalue when generating claim autosummary [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82820 (owner: 10Tobias Gritschacher) [13:26:27] addshore: re [13:26:33] hey! [13:26:35] so what do you think? [13:28:29] youll have to ask me again ;p whatever you siad has vanished from my mind! [13:28:36] :D [13:28:47] how to extend wbsetsitelinks [13:29:15] hmm right! [13:29:25] what was your idea? :> [13:29:36] some prefixed props [13:29:46] like badgesset, badgesadd, badgesremove [13:30:03] but this just doesn't seem right [13:30:12] i agree, it seems ugly ;p [13:30:40] nested props? [13:30:58] mhhhm [13:31:14] thats "hmm" or "mhm"? [13:31:17] :[ [13:31:20] ugh [13:31:22] * ;p [13:31:32] its a bit of both :/ :P [13:32:09] is there anyone else to ask? [13:32:25] just a badges param, if it is set it will set the sitelink badges to the array of badge ids passed? if its not set the module doesnt touch the badges? [13:32:33] Tobi_WMDE: may have a suggestion? :) [13:34:04] addshore: this would mean depending on bots code correctness with adding/removing (not replacing) [13:34:38] indeed :< [13:34:55] addshore: lazowik: what was the question? [13:35:10] where to add the badges information in the request from the UI? [13:35:14] yeo [13:35:17] i guess the only / best / ugly way is addbadges, removebadges, setbadges.. [13:35:18] *p [13:35:37] so, does the api already support adding/removing/setting badges? [13:35:44] no [13:35:49] ok [13:35:58] so the question is, how to extend the api? [13:36:00] thats what this is about ;p expanding setsitelink [13:36:13] Tobi_WMDE: I've thought about separate module before [13:36:30] but then one [save] in UI could create two edits... [13:36:35] but as the UI will have a single save button for changes to the sitelink and the badges it all really needs to be in one [13:36:53] no, better would be to have it in one call [13:37:10] setSitelink api module needs to be extended.. I'll have a short look [13:37:49] for now, we would only support setting one badge per sitelink, right? [13:38:02] Tobi_WMDE: well, yus [13:38:29] then it shoud be easy [13:38:58] but I think that it'd be better to write a proper api now [13:38:59] now the module gets site and title [13:39:18] it would then get site, title and badge [13:39:29] for adding a badge or changing it [13:40:06] removing a badge from a sitelink would then get site, title and an empty badge-param [13:40:21] Tobi_WMDE: ugh, not good [13:40:24] bots [13:40:25] why? [13:40:45] whats the deal with bots? [13:40:56] the bots that modify sitelinks... [13:41:09] they'd delete badges [13:41:13] hmm, but lazowik they wouldnt add the badge param so they wouldnt alter the badges [13:41:13] unless modified [13:41:19] no, they have to be changed to support badges [13:41:21] oh empty [13:41:22] ok [13:41:26] [= [13:41:27] Tobi_WMDE: You are testing on a swarm now? [13:42:21] I think it'd be better to ask Denny before I proceed with that then [13:43:02] * jeblad pulls open one of Tobi_WMDE 's eyes to check if there is anyone home [13:43:03] lazowik: badge-param not set: don't do anything with the current badge [13:43:10] yeh, I got it [13:43:20] badge-param == empty string: remove the current badge [13:43:40] badge == "whatever" - add/set the badge to "whatever" [13:43:46] kk [13:43:46] that sounds like a good solution [13:43:55] but we could ask denny [13:44:01] Tobi_WMDE: but then expanding that would break api if I'm correct... [13:44:08] just reply to the email [13:44:16] lazowik: how? [13:44:17] https://gerrit.wikimedia.org/r/#/q/owner:Liangent+project:mediawiki/extensions/Wikibase+-status:abandoned,n,z doesn't work? [13:44:34] jeblad: yes, we're moving towards this [13:44:35] 500 Internal server error [13:44:48] lazowik: expanding it how? [13:45:01] Tobi_WMDE: if support for multiple badges is added then what badges param would do? [13:45:09] (I mean in the future) [13:45:15] Moving? I heard you already was using a swarm? [13:45:29] lazowik: we could make the badges-param be an array [13:46:12] Tobi_WMDE: this would mean depending on bots code correctness with adding/removing [13:46:21] liangent: needs a manual rebase: https://gerrit.wikimedia.org/r/#/c/72225/27 [13:46:25] just written that to addshore few minutes ago [13:46:26] A badge should be a snak list, but whatever.. [13:46:38] liangent: ...and after that, this one too: https://gerrit.wikimedia.org/r/#/c/74954/14 [13:46:43] i think tey are good to merge, then [13:46:48] lazowik: hmm, yes. [13:46:51] I was only interested in what kind of tests swarm you guys are uusing [13:47:08] >>poff<< [13:47:24] (03PS28) 10Liangent: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 [13:47:32] lazowik: bots will have to be modified in any case if they want to support badges [13:47:40] DanielK_WMDE: does it? [13:47:52] Tobi_WMDE: I know [13:48:20] lazowik: so, a solution where they only have to be modified once would be the preferred one [13:48:44] liangent: ha, sorry, you are right: it'S just the api patch that needs a rebase [13:48:51] and that would be, as I suggested, if the badges-param is not set, keep the behaviour like it is now [13:48:53] yep, and I can't find one :/ [13:49:15] ...and the piglatin patch [13:50:17] if they are going to support badges, they have to set the badges param to an array (which holds just one element for now) containig the badges they want to set and not containing the ones they want to remove [13:50:25] like it is done with aliases [13:50:53] logic could be similar to the one used for aliases [13:51:06] Tobi_WMDE: yep, but aliases also have add and remove [13:51:23] and with only badges param, the logic of adding and removing would be moved to api clients [13:51:25] but they also have "set" [13:51:29] DanielK_WMDE: why are you do eager to rebase piglatin [13:51:37] it can't be merged with languageconverter fixes [13:52:06] lazowik: yes, understand [13:52:17] liangent: just because it makes it easier for me to test. but it's not important [13:52:23] so, if that's ok, then there's not problem [13:52:25] but for now this would not be a problem [13:52:40] ok [13:52:43] thanks :) [13:52:47] it is unclear when we will move to support multiple badges [13:52:47] (03CR) 10Daniel Kinzler: [C: 032] Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [13:53:19] lazowik: if you want we could chant again together with denny tomorrow [13:53:26] *chat [13:53:32] liangent: if this is merged, you can rebase the api patch on master, and i can merge it [13:54:05] liangent: ...and this one too, i guess https://gerrit.wikimedia.org/r/#/c/72751/ [13:54:09] (03PS10) 10Daniel Kinzler: Allow mw.wikibase.label( ) to find labels written in variants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 (owner: 10Liangent) [13:54:12] (03PS15) 10Liangent: api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 [13:54:16] Tobi_WMDE: the problem is that I can only stay here until the end of this week [13:54:17] (03Merged) 10jenkins-bot: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [13:54:23] so I want to do as much as possible [13:55:15] lazowik: understand [13:55:29] I guess for now you could start doing as we just discussed [13:55:34] yep [13:56:10] addshore: so I'm doing setbadges for now [13:56:30] (03CR) 10Liangent: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 (owner: 10Liangent) [13:56:43] is JeroenDeDauw here? [13:56:47] lazowik: so the logic has to go into setSiteLink api module and the ChangeOpSiteLink [13:57:14] Tobi_WMDE: I know :) https://gerrit.wikimedia.org/r/#/c/82637/ [13:57:18] on the client side you'll have to extend wikibase.RepoApi::setSiteLink to also take the badges param [13:58:10] for getting the needed elements into the UI, you best ask Danwe_WMDEand Henning_WMDE [13:58:46] Tobi_WMDE: ok, thank you [13:59:28] Tobi_WMDE: one last thing [13:59:31] summary [13:59:36] (edit summary( [13:59:50] (03PS1) 10Daniel Werner: Add missing dependency 'wikibase.dataTypes' > 'dataTypes' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82829 [14:00:27] lazowik: hm, yes, not sure about that [14:01:28] lazowik: the easiest way would be to just extend the message for setting a sitelink to always contain badges [14:01:40] I thought about something like "Changed link to [enwiki]: page: Blah, badges: blah, blah" [14:01:51] lazowik: yes [14:02:11] and badges are ItemIds now [14:02:19] lazowik: could be tricky though [14:02:27] and as jeblad said they probably should be snaks [14:02:33] because of how the summary class works.. [14:03:12] lazowik: I could have a deeper look into the summaries tomorrow if you want [14:03:19] ok [14:03:37] I'll write something that works for now [14:05:38] liangent: i don't see a good way to get the parser's target language in Lua. Too bad, there should be. [14:07:30] liangent: i'm wondering if we should have a "basline fallback" configurable for every client. e.g. dewiki could specify to fall back to en if de isn't there, als and nds would fall back to de, etc. [14:07:48] but it would be a per wiki setting, basically a "content language fallback" [14:07:58] (could be multiple fallback languages though) [14:08:14] liangent: that would be used by lua and the parser function. what do you think? [14:08:43] liangent: i'm ready to merge the lua patch and the api patch, if you are done with them [14:08:51] DanielK_WMDE: displaying text in another language is a different story [14:09:04] (variant fallbacks still give final output in the same language) [14:09:14] may be neede now [14:10:02] lua should be fine [14:10:14] liangent: yes, i know it's different, but it's very useful in the context of wikidata. remember that we rarely have text, and labels from another language are often useful (at least for places and people) [14:10:43] liangent: i would like to have this option. perhaps think about adding it. [14:10:59] but only if there is time. i or someone else can workj on this later. [14:11:21] I can work on it later too [14:11:39] but it may need more design than coding [14:13:21] DanielK_WMDE: the api thing: I hope that my patch doesn't spoil the ability to create a better / flexible interface later [14:13:28] if so - it's fine to merge [14:14:44] aude: Are we using wmf14 branches in wmf16? [14:15:00] Just wondering if I need to update the conf before I run it, so I then don't have to update it ;) [14:15:16] liangent: i think if we want to make it more flexible, we'll just change languagefallback from a boolean to something else [14:16:50] Reedy, addshore: DataTypes is now a separate module, right? [14:17:04] * DanielK_WMDE really wants to have a deployment assembly before we do this next time [14:17:17] DanielK_WMDE: I had to clone it this morning so i'd say yes [14:17:45] :) [14:17:49] DanielK_WMDE: if everyone is using languagefallback with no param after this merge, it's fine [14:17:55] attack of the clone repos [14:18:11] terrible joke ;p [14:18:13] if different people use different value, it doesn't found so fun [14:18:21] liangent: is there any code that actually uses that parameter? [14:18:34] liangent: we should make sure that the ui is consistent with static html generation [14:18:39] DanielK_WMDE: no [14:18:52] but that'll only become possible once the formatter stuff i'm working on goes in [14:18:55] but people may start using it once they find it live [14:19:05] liangent: ok [14:19:27] DanielK_WMDE: iirc, api bool param accepts any value [14:19:43] sure, it just throws them away [14:19:45] and it's true as long as it's set, regardless of its value [14:20:11] yea, fine for now. i just meant we can still start to use the value at some point [14:20:20] so people could set &language=en&languagefallback=de, which we may decide to use it as something else later [14:20:57] (03CR) 10Daniel Kinzler: [C: 032] Allow mw.wikibase.label( ) to find labels written in variants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 (owner: 10Liangent) [14:21:14] (03CR) 10Daniel Kinzler: [V: 032] api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 (owner: 10Liangent) [14:21:27] DanielK_WMDE: my plan is / was to start use this value in entity fetches in ui javascript [14:22:08] (03PS4) 10Daniel Kinzler: Implement ClaimGuid class [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 (owner: 10Addshore) [14:22:10] once the javascript is fixed to understand 'de':{'language':'en','value':'foobar'} [14:22:28] (03Merged) 10jenkins-bot: Allow mw.wikibase.label( ) to find labels written in variants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 (owner: 10Liangent) [14:22:29] (currently it doesn't. it just assume 'foobar' is in de. [14:23:21] brb [14:23:36] liangent: the is not trivial to do in the UI. you'd want to show the value using the fallback, but when editing, set the user's language. but you still want to use the fallback value as a suggestion for editing. and all of this should be obvious to the user [14:23:57] liangent: actually, i'd like to invite the user to provide traqnslations whenever they see fallback values [14:28:27] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 (owner: 10Addshore) [14:28:31] :D [14:28:51] Ah, I see a wmf16 branch now [14:28:58] (wasn't one last night) [14:29:00] So I guess that's a yes [14:31:17] [15:30:55] (PS1) Reedy: Update Wikidata related extension branches to use [tools/release] - https://gerrit.wikimedia.org/r/82831 [14:33:02] (03CR) 10Daniel Kinzler: "(1 comment)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 (owner: 10Addshore) [14:46:25] addshore: badges "array" should be pipe-divided? [14:46:30] yup [14:46:57] tata for now :) [14:47:13] Reedy: hey. are you already working on deploying to test.wikidata.org? [14:47:40] Reedy: the thing is that none of us is going to be online after 8pm berlin time [14:47:55] so, if you do it now, it's great, but if you plan on doing it later, we'd rather push it to tomorrow [14:48:06] I've already branched etc now [14:48:22] I could possibly do it "now" depending on when I have the l10n cache pushed and synced [14:49:03] Reedy: i'm around for 3 more hours or so. let me know whether you think that'll be enough [14:49:14] oh, and we found a JS issue. we'd need to backport a (hopefully small) patch [14:49:25] Danwe_WMDE is working on it [14:49:50] DanielK_WMDE: if we find the issue.. [14:50:41] Tobi_WMDE: if we don't, so much the better to have it on a test system for others to look at :) [14:51:30] DanielK_WMDE: we have it on http://wikidata.beta.wmflabs.org/wiki/Wikidata:Main_Page [14:58:24] (03PS2) 10Michał Łazowik: Add badges support to wbeditentity [DRAFT, DNM] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82637 [15:12:56] Tobi_WMDE: how should badges be returned if shouldUseKeys === true ? [15:13:30] can it be indexed by value? [15:13:48] e.g. "Q2" => "Q2", "Q42" => "Q42" [15:23:14] (03PS1) 10Daniel Werner: Fix path for value parser resources [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/82836 [15:25:29] DanielK_WMDE: anything related to "when editing" is the second step [15:25:45] DanielK_WMDE: entities in statement view can be done first [15:25:53] and it benefits more [15:26:23] because there's already a "In other language" section [15:26:25] (03CR) 10Tobias Gritschacher: [C: 032] Fix path for value parser resources [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/82836 (owner: 10Daniel Werner) [15:26:33] (03Merged) 10jenkins-bot: Fix path for value parser resources [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/82836 (owner: 10Daniel Werner) [15:26:39] (03CR) 10Tobias Gritschacher: [C: 032] Add missing dependency 'wikibase.dataTypes' > 'dataTypes' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82829 (owner: 10Daniel Werner) [15:26:50] (03CR) 10Jeroen De Dauw: [C: 04-1] "(3 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 (owner: 10Addshore) [15:28:10] (03Merged) 10jenkins-bot: Add missing dependency 'wikibase.dataTypes' > 'dataTypes' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82829 (owner: 10Daniel Werner) [15:29:13] JeroenDeDauw: heeeeloooo ;p [15:29:59] where is the correct place to _not_ modify badges if they are not provided by api? I'm doing that now in api [15:30:13] (03PS1) 10Daniel Werner: Remove unnecessary call to EntityContentFactory::singleton() in EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82838 [15:30:48] (03PS1) 10Tobias Gritschacher: Add missing dependency 'wikibase.dataTypes' > 'dataTypes' [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82839 [15:31:57] (03PS1) 10Tobias Gritschacher: Fix path for value parser resources [extensions/DataValues] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82840 [15:31:58] (03CR) 10Jeroen De Dauw: "(3 comments)" [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82405 (owner: 10Addshore) [15:33:32] DanielK_WMDE: would you merge? https://gerrit.wikimedia.org/r/#/c/82840/ & https://gerrit.wikimedia.org/r/#/c/82839/ [15:33:52] Tobi_WMDE: need cookies first [15:34:14] Tobi_WMDE: could you see my question to you? :) [15:36:22] (03CR) 10Jeroen De Dauw: "> Claims should not have use the entity ID in their own ID internally." [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82237 (owner: 10Addshore) [15:37:04] fewnwfn\oij39rj;oi\fnme;oie\ [15:37:05] ARRGH [15:37:16] ?! [15:37:20] Warning: include_once(): Failed opening '/a/common/php-1.22wmf16/extensions/DataValues/DataTypes/DataTypes.i18n.php' for inclusion (include_path='/a/common/php-1.22wmf16/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg:/a/common/php-1.22wmf16:/usr/local/lib/php:/usr/share/php') in /a/common/php-1.22wmf16/maintenance/mergeMessageFileList.php on line 110 [15:37:20] Unable to read /a/common/php-1.22wmf16/extensions/DataValues/DataTypes/DataTypes.i18n.php [15:37:20] Update of MediaWiki localisation messages failed [15:37:56] $IP/extensions/DataValues/DataTypes/DataTypes.i18n.php [15:37:56] $IP/extensions/DataValues/DataValues/DataValues.i18n.php [15:37:56] $IP/extensions/DataValues/ValueFormatters/ValueFormatters.i18n.php [15:37:56] $IP/extensions/DataValues/ValueParsers/ValueParsers.i18n.php [15:37:56] $IP/extensions/DataValues/ValueValidators/ValueValidators.i18n.php [15:37:58] $IP/extensions/DataTypes/DataTypes.i18n.php [15:38:04] The first one wants to die [15:40:09] (03CR) 10Jeroen De Dauw: [C: 04-2] "Agree with DanielK." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82233 (owner: 10Addshore) [15:41:41] (03CR) 10Jeroen De Dauw: [C: 032] Remove unnecessary call to EntityContentFactory::singleton() in EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82838 (owner: 10Daniel Werner) [15:42:47] (03PS1) 10Michał Łazowik: Fix getting badges by api when usekeys is true [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82842 [15:43:23] DanielK_WMDE: are you going to merge? [15:43:29] the backports.. [15:43:33] Tobi_WMDE: MEEEEEEERGEEEEEEEE https://gerrit.wikimedia.org/r/#/c/81217/ [15:43:40] lazowik: I'm not here! [15:43:48] JeroenDeDauw: ok [15:44:01] Unable to read /a/common/php-1.22wmf16/extensions/DataValues/ValueFormatters/ValueFormatters.i18n.php [15:44:05] * Reedy goes to find somewhere to cry [15:44:59] Reedy: that file no longer exists [15:45:04] I know [15:45:07] Same for the ValueValidators and ValueParsers one [15:45:14] lazowik: yes, I think you can do that [15:45:15] I'm just chasing things around in circles [15:45:27] Reedy: what is trying to read it? Is there some dumb extra config that needs updating? [15:45:27] Tobi_WMDE: https://gerrit.wikimedia.org/r/82842 [15:46:53] Reedy: oh, I'm so typing that fewnwfn\oij39rj;oi\fnme;oie\ into your laptop next time I see it :D [15:47:07] Reedy: "fewnwfn\oij39rj;oi\fnme;oie\" << looks like a PW? [15:47:28] Can we now login to the servers and deploy ourselves? [15:47:34] What could possibly go wrong? [15:47:47] (03CR) 10Daniel Kinzler: [C: 032] Fix path for value parser resources [extensions/DataValues] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82840 (owner: 10Tobias Gritschacher) [15:47:54] (03Merged) 10jenkins-bot: Fix path for value parser resources [extensions/DataValues] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82840 (owner: 10Tobias Gritschacher) [15:50:25] [travis-ci] wikimedia/mediawiki-extensions-DataValues#218 (mw1.22-wmf16 - a0aceef : Daniel Werner): The build passed. [15:50:25] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/ed6340ee70d9...a0aceef71837 [15:50:25] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/11022114 [15:51:52] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Add missing dependency 'wikibase.dataTypes' > 'dataTypes' [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82839 (owner: 10Tobias Gritschacher) [16:06:11] (03PS1) 10Tobias Gritschacher: Fix selenium test for Special:EntitiesWithoutLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82847 [16:07:00] Tobi_WMDE: it's _really_ trivial: https://gerrit.wikimedia.org/r/#/c/82842/ [16:08:26] lazowik: wont come to it today, sorry. could chack tomorrow [16:08:29] *check [16:09:27] (that's only fix for getting with usekeys) [16:10:03] Tobi_WMDE: ^, but ok if you can't [16:10:20] lazowik: I just discovered something else while testing the deployment branch which could have to do with badges [16:10:29] ups [16:10:42] what's that? [16:10:55] if you look at a diff where a sitelink got added there used to be the header "links / enwiki" or something like that [16:11:11] now there is something like "links / enwiki / name" [16:11:15] that's ok [16:11:18] where does this "name" come from [16:11:32] and what does it mean? [16:11:50] the "name" of the sitelink changed? [16:11:58] Tobi_WMDE: yes [16:12:03] it should be rather "page" [16:12:18] eh, that's a "path" created from going inside array [16:12:22] can't even locxalize that [16:12:24] yes [16:12:46] hm.. but why is it then "name" inside the array [16:12:54] we never called the "page" name [16:13:01] Tobi_WMDE: well, there's pageName [16:13:12] that would make more sense [16:13:13] ok [16:13:16] nevermind [16:13:17] and now there's page['name'] and page['badges'] [16:13:31] but the selenium tests have to be adjusted [16:13:36] they are testing that [16:13:49] ok [16:13:57] I'm goind to adjust the tests then [16:14:01] that shouldn't be exposed to user, but the whole header creating code needs refactoring [16:14:04] Tobi_WMDE: ok, thanks [16:14:17] to be able to localize things [16:14:29] lazowik: yes, true, that code is pretty old, from the very beginning of the project [16:14:39] at least that path-thingy [16:14:59] I even wanted to do at least something with that, but I was told that what is now is OK [16:15:04] (for now ofc.) [16:15:11] DanielK_WMDE: We could do testwikidatawiki now.. [16:17:00] Reedy: the issues with the JS dependencies got resolved and the fixes were backported.. we're still not finished with testing but I think deploying to test should be fine [16:17:25] DanielK_WMDE is in the wmf call at the moment.. [16:17:55] Are the changes only in Wikibase? [16:18:17] Reedy: the important change was in DataValues [16:18:45] https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibase.git/refs%2Fheads%2Fmw1.22-wmf16 [16:18:48] So both? [16:19:29] (03PS1) 10Tobias Gritschacher: Fix Undo Selenium test that broke due to badges support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82850 [16:19:41] Reedy: yes, both [16:19:52] there was one backport to DataValues and one to Wikibase [16:21:57] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Fix selenium test for Special:EntitiesWithoutLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82847 (owner: 10Tobias Gritschacher) [16:22:12] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Fix Undo Selenium test that broke due to badges support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82850 (owner: 10Tobias Gritschacher) [16:24:04] (03PS1) 10Tobias Gritschacher: Fix selenium test for Special:EntitiesWithoutLabel [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82852 [16:24:05] (03PS1) 10Tobias Gritschacher: Fix Undo Selenium test that broke due to badges support [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82853 [16:24:19] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Fix selenium test for Special:EntitiesWithoutLabel [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82852 (owner: 10Tobias Gritschacher) [16:24:31] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] Fix Undo Selenium test that broke due to badges support [extensions/Wikibase] (mw1.22-wmf16) - 10https://gerrit.wikimedia.org/r/82853 (owner: 10Tobias Gritschacher) [16:39:05] (03PS1) 10Michał Łazowik: Fix ItemId invalid serialization message. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82855 [16:54:51] (03CR) 10Jeroen De Dauw: [C: 032] Fix ItemId invalid serialization message. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82855 (owner: 10Michał Łazowik) [16:55:32] !nyan [16:55:32] ~=[,,_,,]:3 [16:55:38] !nyandata [16:55:43] wot [17:02:34] (03PS1) 10Jeroen De Dauw: Match renaming changes in Serialization component [extensions/Ask] - 10https://gerrit.wikimedia.org/r/82861 [17:02:44] (03CR) 10jenkins-bot: [V: 04-1] Match renaming changes in Serialization component [extensions/Ask] - 10https://gerrit.wikimedia.org/r/82861 (owner: 10Jeroen De Dauw) [17:03:29] Danwe_WMDE: meeergeee https://gerrit.wikimedia.org/r/#/c/82860/ [17:05:13] (03PS2) 10Jeroen De Dauw: Match renaming changes in Serialization component [extensions/Ask] - 10https://gerrit.wikimedia.org/r/82861 [17:09:14] Danwe_WMDE: meeeergeeeee https://gerrit.wikimedia.org/r/#/c/82861/ [17:10:45] (03CR) 10Daniel Werner: [C: 032] Match renaming changes in Serialization component. [extensions/Ask] - 10https://gerrit.wikimedia.org/r/82861 (owner: 10Jeroen De Dauw) [17:11:40] JeroenDeDauw: so, as you're not here, can you merge trivial patch https://gerrit.wikimedia.org/r/#/c/82842/ that is trivial? [17:12:26] Danwe_WMDE: thnx [17:13:00] lazowik: uhm, we have no tests for this? :( [17:13:35] JeroenDeDauw: that's quite funny [17:13:42] but api tests use api to create entities [17:14:13] so I can't add badges to entities for tests, because api editing badges is what I'm actually wiring right now [17:25:21] JeroenDeDauw: ^ ^ ^ ^ ^ ^ ;p [17:31:50] (03PS2) 10Daniel Kinzler: Introducing SnakFormatter and SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82400 [17:40:45] (03PS1) 10Jeroen De Dauw: Remove test class that was moved to another component a while back [extensions/Ask] - 10https://gerrit.wikimedia.org/r/82867 [17:44:53] It'd be also nice if someone reviewed https://gerrit.wikimedia.org/r/#/c/81003/ [17:46:57] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by 5.66.137.75 link https://www.mediawiki.org/w/index.php?diff=776925 edit summary: [+145] /* Installation */ [17:49:09] (03PS1) 10Daniel Kinzler: Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 [17:49:31] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by 5.66.137.75 link https://www.mediawiki.org/w/index.php?diff=776930 edit summary: [+71] /* Installation */ [17:49:41] (03CR) 10jenkins-bot: [V: 04-1] Make EntityIdLabelFormatter more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82869 (owner: 10Daniel Kinzler) [17:50:17] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by 5.66.137.75 link https://www.mediawiki.org/w/index.php?diff=776932 edit summary: [+11] /* Diff and DataValues */ [17:51:13] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by 5.66.137.75 link https://www.mediawiki.org/w/index.php?diff=776934 edit summary: [+36] /* Requirements */ [17:54:26] (03PS12) 10Liangent: Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [17:55:01] (03PS16) 10Liangent: api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 [17:55:42] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/74954/ - you chose V+2 instead of CR+2 by mistake? [17:56:14] (03CR) 10jenkins-bot: [V: 04-1] Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [18:01:41] (03PS1) 10Jeroen De Dauw: Add some documentation [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/82872 [18:04:59] (03PS35) 10Liangent: Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 [18:12:56] (03PS1) 10Jeroen De Dauw: Match EntityId and Serializer changes so the tests apss once again [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82873 [18:14:57] (03PS1) 10Daniel Werner: (bug 52387) Special page for querying by property value [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 [18:15:11] (03CR) 10jenkins-bot: [V: 04-1] (bug 52387) Special page for querying by property value [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [18:16:01] (03PS36) 10Liangent: Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 [18:16:02] (03CR) 10Daniel Kinzler: [C: 032] api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 (owner: 10Liangent) [18:16:05] liangent: haha, yea [18:16:18] * DanielK_WMDE is going to leave soon [18:17:12] DanielK_WMDE: I can't find the cause of jenkins failure at https://gerrit.wikimedia.org/r/71996 again [18:17:38] (03CR) 10Daniel Werner: [C: 032] Match EntityId and Serializer changes so the tests apss once again [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82873 (owner: 10Jeroen De Dauw) [18:17:48] DanielK_WMDE: some trivial review for goodbye https://gerrit.wikimedia.org/r/#/c/82842/ ;p [18:19:11] (03Merged) 10jenkins-bot: api.php?action=wbgetentities gets a new parameter 'languagefallback' [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/74954 (owner: 10Liangent) [18:19:14] (03PS2) 10Daniel Werner: (bug 52387) Special page for querying by property value [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 [18:20:02] Danwe_WMDE: you've got some time? I have a few questions about UI for badges. [18:20:05] liangent: no idea about the jenkins failure, ask hashar [18:20:41] (03CR) 10jenkins-bot: [V: 04-1] (bug 52387) Special page for querying by property value [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [18:21:01] (03PS37) 10Liangent: Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 [18:21:05] lazowik: sure [18:21:38] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#38 (master - 647e513 : jeroendedauw): The build has errored. [18:21:38] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/e39d11c80d4d...647e51347b12 [18:21:39] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/11028037 [18:21:50] it's decided that for now UI will be now only for FA / GA [18:22:08] following this: http://meta.wikimedia.org/wiki/File:20120621_wikidata_layout_edit-label.png [18:22:25] ok [18:22:34] is the place for column ok? [18:22:53] I guess. This can be changed easily anyhow [18:22:59] mhm [18:23:24] in view mode there are to be stars and in edit mode a dropdown list [18:23:26] I would think about moving it before the buttons though [18:23:45] lazowik: sorry, that's a not so trivial dicision, actually [18:24:10] Danwe_WMDE: maybe have a look at https://gerrit.wikimedia.org/r/#/c/82842/ [18:24:42] It doesn't seem very intuitive to 1. choose the site, then tab into the badge dropdown, then enter the page [18:24:58] (03CR) 10Liangent: "Jeroen De Dauw: I think I found a better way to switch for WB_EXPERIMENTAL_FEATURES." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [18:25:00] choosing the badge or not should be the last step I guess [18:25:05] DanielK_WMDE: ? Tobi_WMDE said that it's ok (not the patch, but what it does) [18:25:13] Danwe_WMDE: ok [18:25:37] these stars should be images or some characters? [18:25:58] Both fine with me [18:26:23] ok, now how to mark difference between badges? [18:26:44] now I think that characters with different colors might not be sufficient [18:26:44] how do you mean? [18:26:51] (in the view mode) [18:27:19] just the same icons as are now on wp probably [18:27:26] yes [18:27:33] ok [18:28:02] now for dropdown [18:28:03] Actually, in edit mode, I am not sure a dropdown would be best. What would you show within the dropdown? And I am concerned there won't be enough space either [18:28:16] mhm [18:28:22] (03CR) 10Liangent: "Though it might be possible to move it further into LanguageFallbackChainFactory, I guess it looks better to let it pollute it here than a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent) [18:28:27] that's not something decided actually [18:28:39] but what are the other options? [18:30:16] Perhaps a dropdown with the pictures instead of text (don't know what you had in mind) [18:30:27] hmm [18:30:37] could confusse [18:30:44] if someone has no idea what that is [18:30:47] perhaps not a dropdown but a button like thing that will then show some popup where you can choose from [18:31:02] that seems much better [18:31:32] with only these two badges it won't be edited too often probably [18:32:15] it had to be obvious that clicking there or hovering there would allow you to make a selection, so simply showing blank space for "no badge" won't be good. Perhaps show the shape of a star there as placeholder for "no badge" and as a signal for the user that there is some interaction [18:32:37] mhm, I thought about dotted shape [18:32:48] sounds good [18:33:04] and whatever chosen would pop in there [18:33:11] yes [18:33:15] (03CR) 10GWicke: [C: 04-2] "Doing the variant conversion during regular rendering will fragment caches. Ideally, we'd like to render a page only once and then (re-)do" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [18:33:35] the popup could even contain images with captions [18:33:50] yeah, that would be the advantage of the popup [18:34:10] similar to what we have when editing geo values or time values perhaps [18:34:19] mhm [18:34:35] are some mockups needed? [18:34:43] could be a huge modal state popup as well of course [18:34:58] ugh, noo [18:35:12] but that'd be a way to go when multiple badges are allowed [18:35:20] would be faster to implement but ugly of course [18:35:50] One way of multiple badges would just be to have multiple columns, one per "kind of batch". [18:36:02] We could then just extend this with another kind of batch and so on [18:36:18] in that case though, space could become real tight [18:36:18] probably wouldn't work [18:36:25] any item can be a badge [18:36:40] (in data model & api) [18:36:42] ? [18:37:06] Then, what is defining the image to display there etc.? A property of the item? [18:37:22] noo, for now UI will only support FA / GA [18:37:34] so multiple badges are for future [18:37:37] (in UI) [18:38:04] ah what's defining [18:38:07] sorry, misread [18:38:24] probably hardcoded for now [18:38:27] need to ask [18:38:30] soudns a little weird to be able to choose any item as a badge but ok [18:38:59] I know, but then some other uses for badges can be found [18:39:10] In some wiki, I might not even want to have an item about a certain badge since the badge itself is meta data for organization, not part of the content my wiki is about [18:39:14] lets leave furure for future :) [18:39:34] alright [18:39:41] ooops [18:39:57] wmf is not the whole world [18:40:07] exactly what I am saying [18:40:08] can't really hardcode that... [18:40:44] no, but can use programming techniques to allow extending (or configure) badges otherwise [18:41:00] mhm [18:41:10] some administrative interface [18:41:16] the same for client [18:41:40] probably just link itemid with image of badge [18:41:52] but saying items can be badges sounds like something very wikidata specific since wikidata will have items for all kind of small things, even badges in wikipedia and other wikis, while some non-wmf wikis might not want to have items about those badges. [18:42:23] hmm [18:44:26] but if these items exist and are not linked anywhere else than to badges? [18:44:37] would they affect anything except dumps? [18:45:36] If you say this wiki is only about some kind of items, then those items will not fit into that schema, right? Basically, they would be items for configuration purposes. [18:45:51] If there were a separate namespace for those, a separate type of item, then this might be fine [18:45:58] mhm [18:47:59] then a property could indicate a image for badge [18:51:26] Danwe_WMDE: separate namespace and type seems the right way to do this [18:51:33] but also a bit of overkill [18:51:34] a special entity with a special property for the image. Lots of special stuff just for badges? [18:52:22] lazowik: another way to do it could be having a flexible system but defining badges in PHP configuration [18:54:06] argh, gerrit is off? [18:54:37] seems so [18:55:10] Reedy [18:55:10] Data is being moved [18:55:45] * that's in parentheses [19:01:46] (03PS3) 10Daniel Werner: (bug 52387) Special page for querying by property value [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 [19:03:14] (03CR) 10jenkins-bot: [V: 04-1] (bug 52387) Special page for querying by property value [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [19:03:17] Danwe_WMDE: do you happen to know api enough to review something (small)? [19:03:21] https://gerrit.wikimedia.org/r/#/c/82842/ [19:04:48] lazowik: I looked at it but don't feel to confident right now [19:05:00] ok [19:05:29] Jeroen will be back in a few minutes, you could probably poke him about it [19:05:40] thanks [19:06:05] can at least for now assume that all instances of repo won't have tons of badges? [19:06:18] and start preparing with UI? [19:07:02] Danwe_WMDE: ^ [19:08:03] I don't quite understand? What instances of repo have what badges? [19:08:10] non-wmf [19:08:29] can UI for now support up to few badges [19:08:49] of course, just supporting FA/GA is better than supporting nothing, right? [19:09:28] Danwe_WMDE: hmm, maybe even make badges as a whole an option? [19:09:46] maybe [19:09:53] s/badges/viewing and editing/ [19:12:23] (03CR) 10Umherirrender: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81671 (owner: 10Addshore) [19:12:32] Hi, there. [19:13:08] As... most of you probably do not know, I write the Tech report for the [English] Wikipedia Signpost. [19:13:23] I want to do more on Wikidata in it. Any news that should go in? [19:13:30] o/ [19:13:33] So far, I have the url datatype. [19:13:38] Lydia_WMDE: ^ [19:13:51] yep, definitely Lydia_WMDE [19:14:07] (03CR) 10Jeroen De Dauw: [C: 032] "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79345 (owner: 10Daniel Werner) [19:14:10] And I'm linking Gerard's posts on, acronym beginning with V... um, second [19:14:16] (03PS4) 10Jeroen De Dauw: (bug 52387) Special page for querying by property value [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [19:14:21] viaf [19:14:27] Yes [19:15:17] AdamCuerden: http://blog.wikimedia.de/2013/09/04/wikidata-quality-and-quantity/ [19:15:38] AdamCuerden: this could be a help: http://www.wikidata.org/wiki/Wikidata:Status_updates [19:15:43] also https://www.wikidata.org/wiki/Wikidata:Comparison_of_Projects_and_Proposals_for_Wiktionary was published 2? days ago [19:15:46] (03CR) 10jenkins-bot: [V: 04-1] (bug 52387) Special page for querying by property value. [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [19:16:05] (03PS1) 10Umherirrender: Style the flag 'D' on watchlist and recentchanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82886 [19:17:25] * '''URL datatype''' Wikidata uses datatypes to organise what kind of data goes into the systematic information for different groupings, such as Presidents of Germany, or species of plants. At the moment, the "url" datatype is being tested, which will allow Wikidata to begin providing ready-made links to references and other useful links. <- Would you call this a fair [19:17:25] description? [19:17:41] Reviewing [19:19:33] JeroenDeDauw: Danwe raised something _very_ important [19:19:43] badges vs. non-wmf instalations [19:19:54] Er, i don't think thats it. basically wikidata has properties, and each property can either be another item (author --> Famous person), string (imdb id --> blahblah), geocoordinate, time, etc [19:19:58] url is just another datatype [19:20:29] https://www.wikidata.org/wiki/Special:ListDatatypes [19:20:39] (03CR) 10Siebrand: [C: 04-1] "(1 comment)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [19:21:53] Right [19:22:04] How would you phrase it, then? [19:22:44] Also, does anyone know, offhand, Denny Vrandecic 's username? Preferably on en-wiki, but I could also link to Wikidata. [19:22:56] ...I think. Is that [[d:User:]] [19:22:57] 10[15] 04https://www.wikidata.org/wiki/User: [19:22:57] ? [19:23:02] Oh, good. [19:23:04] d:User:Denny [19:23:10] Hoqdy lazowick danwe_wmde and legoktm :) [19:23:18] also https://www.wikidata.org/wiki/User:Denny_Vrande%C4%8Di%C4%87_%28WMDE%29 [19:23:25] Howdy... [19:23:28] o/ [19:24:34] I guess I'll link to his WMDE username [19:26:16] addshore: well heeeloooo [19:27:25] Danwe_WMDE actually got pinged out [19:27:51] What's this about non wmf wikis then? :p [19:27:52] badges require items [19:27:52] and not everyone needs to be happy with that [19:28:06] at least not in the same namespace as "core" items [19:28:11] are there actually non-wmf wikibase installs? [19:28:37] I have no idea [19:29:10] addshore: even leaving them being itmes there's a problem with UI [19:29:18] can't hardcode anything [19:29:34] need to do some administrative interface to connect items with badges images [19:30:01] also (that's my own afterthought) not every install might want badges [19:30:09] "* '''Using Wikidata to support Wiktionary''': A dictionary is basically a structured set of data about words. Wikidata, as a method of structuring data, could make an excellent fit, but care needs to be taken to work out the exact data structure in advance. An analysis of the issue is available [[Wikidata:Comparison_of_Projects_and_Proposals_for_Wiktionary|here]]." [19:30:41] bbl [19:37:19] Indeed [19:37:44] Burgh fail internet... [19:37:54] :D [19:38:15] addshore: maybe to keep thing simple at first I'll just add a page to set itemid of FA and GA badges [19:38:29] and enable / disable badges UI [19:38:43] (or even a setting in localsettings for enabling s [19:38:47] and disabling [19:39:00] (03CR) 10Jeroen De Dauw: [C: 04-1] "(3 comments)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [19:39:16] ao wmf will have it's badges and other installs can disable [19:39:24] or rather can enable [19:41:27] * lazowik goes to eat [19:42:50] addshore: https://gerrit.wikimedia.org/r/#/c/82842/ <- I asked Tobi if something like Q42 => "Q42" is ok, he said yes [19:43:05] (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner) [19:43:20] then JeroenDeDauw asked why there are no tests [19:43:40] and then DanielK said that it's not so obvious that it should be like that... [19:44:16] (to clear thigs: tests need api editing support badges) [19:45:26] (03PS13) 10Liangent: Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [19:47:09] (03CR) 10jenkins-bot: [V: 04-1] Use requested variant language instead of target language to fetch labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [19:48:47] https://en.wikipedia.org/wiki/Wikipedia:Wikipedia_Signpost/2013-09-04/Technology_report#Wikidata How's this look to everyone? [19:54:32] !dennyno | legoktm [19:54:37] huh [19:54:40] !denyno [19:54:45] I've already seen it :P [19:54:46] !denny-no [19:54:55] Someone deleted it?! :<0 [19:55:26] !dennyno is https://bit.ly/dennyno [19:55:26] Key was added [19:55:30] muhahah [19:55:37] ohwait [19:55:39] !no [19:55:40] https://bit.ly/dennyno [19:55:46] me.failed [19:56:19] lazowik: are you saying that the badges support is currently WMF specific? [19:56:28] That is indeed problemtic [20:02:09] (03PS14) 10Liangent: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [20:03:47] (03CR) 10jenkins-bot: [V: 04-1] Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent) [20:09:03] (03CR) 10Jeroen De Dauw: [C: 032] Add index support to createTable [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/80544 (owner: 10Addshore) [20:09:39] (03CR) 10Jeroen De Dauw: [C: 032] Add indexes to TableCreationAndDeletionTest [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82605 (owner: 10Addshore) [20:10:05] (03CR) 10Jeroen De Dauw: [C: 032] Fix SQLiteTableSqlBuilderTest default values. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82606 (owner: 10Addshore) [20:10:06] (03CR) 10jenkins-bot: [V: 04-1] Fix SQLiteTableSqlBuilderTest default values. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82606 (owner: 10Addshore) [20:10:35] (03CR) 10Jeroen De Dauw: [C: 032] Add sqlite indexes support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82609 (owner: 10Addshore) [20:10:48] (03CR) 10jenkins-bot: [V: 04-1] Add sqlite indexes support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82609 (owner: 10Addshore) [20:10:53] (03PS3) 10Jeroen De Dauw: Fix SQLiteTableSqlBuilderTest default values. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82606 (owner: 10Addshore) [20:11:04] (03CR) 10Jeroen De Dauw: [C: 032] Fix SQLiteTableSqlBuilderTest default values. [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82606 (owner: 10Addshore) [20:11:10] (03PS3) 10Jeroen De Dauw: Add sqlite indexes support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82609 (owner: 10Addshore) [20:11:14] (03CR) 10Jeroen De Dauw: [C: 032] Add sqlite indexes support [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/82609 (owner: 10Addshore) [20:12:21] (03PS15) 10Liangent: Have labels shown in variants for {{#property: }} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 [20:20:51] JeroenDeDauw: the concept [20:22:06] it requires items to be created in the main item namespace to be used as badges [20:22:50] Danwe_WMDE: I came with sort of a workaround [20:23:02] enable badges in UI in LocalSettings [20:23:40] and have page to map items with FA & GA [20:24:10] enable badges in UI in LocalSettings = add configuration option to enable ui for badges [20:28:16] lazowik: why cannot we use current items for badges like https://www.wikidata.org/wiki/Q19765 ? [20:36:58] legoktm: that's the target for wikidata [20:37:13] hello all [20:37:15] but where to connect these items with UI? [20:37:24] can't hardcode that [20:37:36] lazowik: MediaWiki:Wikibase-defaultbadges :P [20:37:41] i am trying to edit wikidata but im getting this error: "Internal Server Error" when i try to save [20:38:51] legoktm: something along this lines, yep [20:38:59] HenriqueCrang: whooops... [20:39:06] what exactly you tried to do? [20:39:14] (what item and what edit) [20:39:20] i am editing https://www.wikidata.org/wiki/Q17479 [20:39:26] lazowik: or you could just make it a global like $wgWikibaseDefaultBadges[] = 'Q###' i guess? [20:39:57] and i was trying to add a source to "home venue" information [20:40:06] legoktm: that'd probably be the easiest way, but also the hackiest :p [20:40:16] and when i try to save a "stated in" i get this error [20:41:00] seems to work for me https://www.wikidata.org/w/index.php?title=Q17479&diff=68597821&oldid=68597547 [20:42:01] good [20:42:11] maybe i was doing something wrong [20:43:03] in a case like this - a soccer team changed its home venue - what'd be the correct way to reference a online newspaper? [20:43:10] HenriqueCrang: you tried more than once? [20:44:05] lazowik, 3 times [20:44:13] okay, taht's not normal [20:44:46] maybe wd was short of power or sth [20:44:50] no idea [20:45:06] but please do shout here if this keeps repeating :) [20:45:35] then maybe someone more competent than me will look into this [20:45:40] thanks lazowik :) [20:46:04] np [20:46:07] when i add a source, should i add the url ? [20:47:48] now, when i try to add a "title" it keeps 'loading' but the field for the value never appear [20:48:06] HenriqueCrang: I think that URL data type is still in development/testing [20:48:52] PHP Catchable fatal error: Object of class Wikibase\Reference could not be converted to string in /usr/local/apache/common-local/php-1.22wmf15/extensions/Wikibase/repo/includes/changeop/ChangeOpReference.php on line 183 [20:49:44] HenriqueCrang: for now you should probably add the wikidata item about source [20:49:48] though I'm not sure [20:50:10] * lazowik relized just now how little does he know about actual use of wikidata [20:50:23] i was trying to add the title, but it is not showing me the field [20:50:29] i'll trying again in an hour [20:50:35] HenriqueCrang: the title of? [20:50:52] if it happens again i'll come back here [20:51:07] lazowik, the title of the publication that i am using as a source [20:51:08] HenriqueCrang: it suggests only existing items [20:51:23] HenriqueCrang: then check if an item for this publication exists [20:51:26] yes, but it is not even show me the html form field to type [20:51:32] showing* [20:51:53] hmm [20:52:01] could you take a screenshot? [20:52:49] yep [20:52:51] 1s [20:54:25] lazowik, sending [20:54:38] huh, network not reachable [20:54:54] ;-/ [20:55:55] lazowik, http://www.tiikoni.com/tis/view/?id=b41f010 [20:56:54] hmm, works for me [20:57:43] HenriqueCrang: try writing only "tit" and then choose title from the list [20:57:47] if it shows up... [20:58:37] wow, worked [20:59:01] if i type "title" and select the item from the list, it keeps loading eternaly [20:59:17] but if i only type "titl" and select the same item, it works [20:59:24] yay \o/ [21:01:22] should i report this as bug somewhere? [21:01:48] hmm, not sure [21:01:56] but go ahaed [21:02:13] *ahead [21:12:53] * lazowik yawns [21:12:58] good night! [21:17:56] (03CR) 10Daniel Werner: "(1 comment)" [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/82874 (owner: 10Daniel Werner)