[01:41:53] <legoktm>	 JeroenDeDauw: thanks :)
[07:53:27] <GerardM>	 http://ultimategerardm.blogspot.nl/2013/08/mariano-baptista-president-of-bolivia.html I am in the habit of creating new items ... what do you think ?
[08:34:44] <grrrit-wm>	 (03CR) 10Liangent: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 (owner: 10Liangent)
[08:37:55] <grrrit-wm>	 (03CR) 10Liangent: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81001 (owner: 10Liangent)
[08:55:39] <lazowik>	 addshore: u here?
[08:56:39] <addshore>	 He he, internet just started working :p
[08:57:09] <addshore>	 So yes :)
[09:00:22] <addshore>	 *ping lazowik ;p
[09:00:57] <lazowik>	 addshore: tennis :)
[09:01:14] <lazowik>	 ok, so one question for now
[09:01:35] <lazowik>	 if I'm to write badges editing in wbsetsitelink
[09:01:58] <lazowik>	 this would mean adding sth along lines of badgesadd, badgesremove and badgesset
[09:02:09] <lazowik>	 for adding, removing and replacing
[09:02:29] <addshore>	 So when adding a badge it is an id of an item?
[09:02:35] <lazowik>	 yep
[09:02:40] <lazowik>	 and what concerns me is that there are no other modules with "prefixed" names
[09:03:19] <addshore>	 What you could do is have the optional parameter of link badge
[09:03:29] <addshore>	 If it isn't set, do nothing with the badge
[09:03:40] <addshore>	 If it is set, update the badge accordingly
[09:03:46] <legoktm>	 er?
[09:03:57] <legoktm>	 just do what wbsetreference and wbsetqualifier do
[09:03:59] <addshore>	 This would mean only 1 more parameter and its optional
[09:04:19] <legoktm>	 oh
[09:04:25] <legoktm>	 hm
[09:04:26] <addshore>	 Legoktm, as in? :p
[09:04:33] <legoktm>	 i was thinking of a different api module
[09:04:39] <lazowik>	 legoktm: me too
[09:04:40] <legoktm>	 i didn't read the part of wbsetsitelink
[09:05:07] <lazowik>	 addshore: can you write how adding removing and replacing would look like
[09:05:22] <lazowik>	 well, replacing (with list) is optional
[09:05:43] <lazowik>	 addshore: remember there can be more badges than one
[09:05:46] <addshore>	 Hmm, that's a good point, a sitelink can have more than one badge?
[09:05:50] <lazowik>	 yes
[09:05:52] <addshore>	 :p
[09:06:06] <lazowik>	 telepathy :)
[09:06:13] <addshore>	 Is there some sort of validation for which ids can be used somewhere? :)
[09:06:21] <lazowik>	 I asked for that
[09:06:25] <legoktm>	 just any item that exists right?
[09:06:30] <lazowik>	 and Denny said that any item is eglible
[09:06:45] <legoktm>	 i like that idea
[09:07:01] <addshore>	 Hmm, what would happen if I added a badge for a sitelink and used the I'd q1?
[09:07:17] <legoktm>	 addshore: i think that's the point?
[09:07:36] <legoktm>	 it would just say "Universe" or however it gets displayed
[09:07:37] <addshore>	 I'm thinking more on the ui side now ;p
[09:07:50] <addshore>	 Ahh, so it just uses the label? :p
[09:07:54] <lazowik>	 I think there will be an interface on client to connect badges with "reactions" on site
[09:08:06] <lazowik>	 so they might choose that Q1 means add star
[09:08:07] <grrrit-wm>	 (03CR) 10Liangent: "From Parser.php:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71996 (owner: 10Liangent)
[09:08:24] <lazowik>	 (image)
[09:08:33] <lazowik>	 addshore: yes, label
[09:08:44] <addshore>	 Ahh, okay , and in the ui it would just say something like badges:label1,lable2
[09:08:46] <addshore>	 Okay :)
[09:08:48] <lazowik>	 yes
[09:09:02] <lazowik>	 in the end editing will be probably like aliases
[09:09:09] <lazowik>	 but for items
[09:09:18] <legoktm>	 lazowik: re the API module: I think you should have your own module like wbsetbadge where the user gives an id and then a list of sitenames -> badge, badge2
[09:09:35] <lazowik>	 legoktm: that's how I wanted to do this
[09:09:52] <lazowik>	 but I'd go with wbsetbadges
[09:09:56] <lazowik>	 that's critical :)
[09:09:56] <addshore>	 Lazowik now I have been reminded you need multiple badges I would agree :p
[09:09:57] <grrrit-wm>	 (03CR) 10Liangent: "Test this with test cases..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent)
[09:10:13] <legoktm>	 yes :D
[09:10:33] <lazowik>	 hmm
[09:10:36] <lazowik>	 now I wonder
[09:10:42] <lazowik>	 (not related to api)
[09:11:01] <lazowik>	 if someone changes page to which sitelink points
[09:11:04] <lazowik>	 what with badges?
[09:11:30] <lazowik>	 on the other side, badges are quite rare
[09:11:41] <addshore>	 Hmmm
[09:11:49] <lazowik>	 but with this new interface they might be extended....
[09:12:01] <lazowik>	 stubs could be also marked using them
[09:12:34] <lazowik>	 and then imagine fixing two misplaced sitelinks
[09:12:43] <lazowik>	 (interchanging them)
[09:12:53] <grrrit-wm>	 (03CR) 10Liangent: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent)
[09:13:22] <lazowik>	 then it would make probably more sense to connect badges with articles
[09:13:51] <addshore>	 Hmmm
[09:14:01] <lazowik>	 but that would need a ground-up rewrite
[09:14:15] <addshore>	 The badges are part of the serialized sitelink are they not?
[09:14:34] <lazowik>	 yes
[09:15:23] <legoktm>	 i don't think thats *that* big of a usecase to worry about right now
[09:15:30] <lazowik>	 mhm
[09:15:33] <addshore>	 Hmm, I don't think it is any different to the situation to claims etc currently
[09:15:49] <lazowik>	 yep
[09:15:58] <legoktm>	 you could have it that if the sitelink gets modified, users can provide an api parameter to optionally remove all badges
[09:16:07] <addshore>	 Which to move you have to totally recreate currently
[09:16:13] <addshore>	 The same would be done for sitelinks with badges
[09:16:18] <lazowik>	 ok
[09:16:43] <addshore>	 Lego, a clear param ;p similar to in wbeditentities but this time just for wbsetsitelink
[09:16:49] <legoktm>	 yup!
[09:17:08] <legoktm>	 addshore: ooh. idea! someway to copy claims from one item to another. you could provide the claim GUID and the new item's id, and it would copy all the qualifiers and references too :D
[09:17:13] <lazowik>	 addshore: wbsetbadges :)
[09:17:26] <legoktm>	 lazowik: no, wbsetsitelink
[09:17:43] <legoktm>	 i was saying that if i modify a sitelink, the badges would be retained, unless i pass a clear parameter
[09:17:49] <lazowik>	 ah
[09:17:51] <lazowik>	 sitelink
[09:17:52] <lazowik>	 ok
[09:18:06] <addshore>	 Lazowik, are you going to try and implement it today?
[09:18:16] <lazowik>	 addshore: I'll see
[09:18:29] <addshore>	 :) I'll hang around irc then :)
[09:18:32] <lazowik>	 if yes, then rather in the evening
[09:18:42] <addshore>	 Legoktm, I was thinking this on Friday!
[09:18:51] <legoktm>	 yay!
[09:19:02] <legoktm>	 it shouldn't be *that* hard to write....
[09:19:04] <addshore>	 So, the merge module works, needs a few pokes and prods as changes
[09:19:05] <legoktm>	 i'll take a look tomorrow
[09:19:05] <lazowik>	 addshore: I have some algorithmic training to do :)
[09:19:26] <addshore>	 And effectively copying isn't very different...
[09:19:53] <addshore>	 You just c
[09:20:07] <addshore>	 You just leave the original in place ;p
[09:20:24] <addshore>	 So I was thinking of renaming it wbmove and adding some extra functionality (maybe)
[09:20:43] <legoktm>	 addshore: no, copying is pretty effective
[09:21:04] <legoktm>	 say i want to add the same claim to 500k items (which my bot did earlier this year)
[09:21:29] <legoktm>	 if i dont have to pass an entire serialized claim + ref to the API, it becomes much faster
[09:22:04] <addshore>	 Hmm, so wbcopyclaim?
[09:22:10] <lazowik>	 addshore: legoktm: and this clearing on sitelink change would be enabled by default
[09:22:18] <addshore>	 Pass it a guid and a new entity I'd?
[09:22:25] <legoktm>	 lazowik: o.O i'm not sure that would be the intended behavior
[09:22:43] <addshore>	 Lazowik, I would have it off by default
[09:22:43] <lazowik>	 hmm
[09:22:47] <lazowik>	 ok
[09:22:53] <legoktm>	 lazowik: say a page gets moved and the software didn't auto update the link because the SUL account wasn't the same. when a human moves it, the badge is gone :/
[09:23:12] <lazowik>	 ah, yes
[09:23:23] <lazowik>	 that's more frequent than misplaced sitelinks
[09:23:24] <lazowik>	 sure
[09:24:35] <addshore>	 Legoktm, the copy module should be rather easy ;p
[09:24:44] <legoktm>	 addshore: can i try writing it?
[09:25:13] <addshore>	 Yup, you might want to build on top of my merge module patchset though
[09:25:21] <legoktm>	 hm, ok
[09:25:29] <addshore>	 I have just created a claimchangeop and it needs a few changes
[09:26:00] <legoktm>	 also something else i was thinking about
[09:26:09] <addshore>	 Got another patchset from Toby I need to steal into it
[09:26:11] <legoktm>	 it would be nice if we had a special page where we could filter properties by datatype
[09:26:43] <addshore>	 Make it then ;p
[09:27:09] <addshore>	 I probably won't be able to fix up my patchsets till Monday :/
[09:29:10] <legoktm>	 oh. why not?
[09:30:57] <addshore>	 I don't really have internet on weekends
[09:31:12] <addshore>	 If I plug my laptop into my phone it tends to vanish ;p
[09:31:23] <addshore>	 I'll, give it a shot now ;p
[09:31:31] <legoktm>	 o.O
[09:31:33] <legoktm>	 why not?
[09:31:45] <legoktm>	 https://bugzilla.wikimedia.org/53618
[09:32:15] <addshore>	 I saw the email ;p
[09:34:34] <addshore>	 Internet's working today :)
[09:34:39] <addshore>	 Woo!
[09:35:03] <legoktm>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=53619 
[09:38:12] <addshore>	 Right *loads stuff*
[09:39:34] <legoktm>	 I recently configured my laptop to use a VPN, so now everything I visit on the internet is in dutch xD
[09:39:47] <addshore>	 XD
[09:42:40] <lazowik>	 addshore: I won one internetz recetly (for submitting #80000 patch in gerrit), I can give you it :)
[09:42:47] <lazowik>	 I'll manage with one
[09:44:44] <legoktm>	 addshore: https://bugzilla.wikimedia.org/show_bug.cgi?id=45509 looks easy
[09:47:48] <aude>	 moin!
[09:48:11] <GerardM>	 legoktm: mag ik nu Nederlands tegen je spreken ?
[09:48:37] <legoktm>	 GerardM: I had to use google translate for that, so no :P
[09:49:15] <GerardM>	 <grin> I did add two bugs for harvest_template.py
[09:49:59] <GerardM>	 I am still running on one value for a run
[09:52:36] <legoktm>	 addshore: https://bugzilla.wikimedia.org/show_bug.cgi?id=52732
[10:07:39] <lazowik>	 legoktm: looks like they've taken internetz from him :(
[10:07:45] <legoktm>	 :(
[10:43:22] <addshore>	 Legoktm lazowick its back ;p
[10:44:20] <addshore>	 But not for my laptop so I am now in a park :
[10:44:22] <addshore>	 :)
[10:45:31] <addshore>	 Lazowik I took a quck prod at my get entities test refractor and it now supports checking for the URLs and badges
[10:46:05] <lazowik>	 yay :)
[10:46:11] <addshore>	 All you'd need to do is add.site links/badges to the list of good props :)
[10:51:22] <addshore>	 Won't be able to put it on gerrit till Monday :) but its all done ;p
[10:52:23] <lazowik>	 addshore: hmm, so maybe I'll do getting and editing in separate patches
[10:52:50] <addshore>	 Sounds like a plan :)
[10:53:02] <lazowik>	 with your's tests getting is ready for merge
[10:53:30] <lazowik>	 it goes quicker than I thought it would be :)
[10:53:33] <addshore>	 Now go make the setting module ;p
[10:53:55] <lazowik>	 for client?
[10:54:05] <lazowik>	 that's gonna be tough...
[10:54:15] <addshore>	 A pi module for repo ;p
[10:54:36] <lazowik>	 *ui ?
[10:55:08] <lazowik>	 I've written to wikidata-tech 'cause I have virtually no idea where to stick that :/
[10:55:40] <lazowik>	 addshore: ^ any ideas?
[10:56:03] <addshore>	 Well, you can do the api module to set badges first :) without touching the ui :)
[10:56:15] <lazowik>	 ah, setting
[10:56:19] <lazowik>	 setting=editing
[10:56:21] <lazowik>	 right
[10:56:31] <addshore>	 I'd have to think a bit about the client, not sure
[10:56:46] <lazowik>	 that's another one to discuss broader
[10:56:48] <lazowik>	 but not for now
[10:57:38] <addshore>	 Set/edit :p yes :)
[11:00:15] <addshore>	 Ping me if you need me ;p
[11:00:41] <lazowik>	 ok
[11:01:04] <lazowik>	 addshore: not until evening so you don't have to stick here
[11:07:25] <addshore>	 That's fine :p I'm lying in a park anyway ;p
[11:10:42] <lazowik>	 hehe
[11:10:47] <lazowik>	 that's a proper weekend
[12:43:52] <grrrit-wm>	 (03PS9) 10Liangent: Allow mw.wikibase.label( ) to find labels written in variants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 
[14:58:30] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by 149.200.222.64 link https://www.mediawiki.org/w/index.php?diff=774529 edit summary: [+1099] /* Screenshots */
[14:59:43] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Tegel link https://www.mediawiki.org/w/index.php?diff=774530 edit summary: [-1099] Reverted edits by [[Special:Contributions/149.200.222.64|149.200.222.64]] ([[User talk:149.200.222.64|talk]]) to last revision by [[User:Vogone|Vogone]]
[14:59:47] <AsimovBot>	 10[2] 04https://www.wikidata.org/wiki/Special:Contributions/149%2E200%2E222%2E6413 =>
[14:59:49] <AsimovBot>	 10[3] 04https://www.wikidata.org/wiki/User_talk:149%2E200%2E222%2E6413 =>
[14:59:51] <AsimovBot>	 10[4] 10https://www.wikidata.org/wiki/User:Vogone
[15:04:59] <grrrit-wm>	 (03PS10) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81003 
[15:05:25] <lazowik>	 addshore: :O
[16:26:23] <addshore>	 lazowik: indeed ;p
[16:30:42] <grrrit-wm>	 (03PS1) 10Umherirrender: Let ClaimsSerializer implements Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 
[16:32:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Let ClaimsSerializer implements Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 (owner: 10Umherirrender)
[17:34:22] <grrrit-wm>	 (03PS2) 10Umherirrender: Let ClaimsSerializer implements Unserializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 
[18:13:26] <grrrit-wm>	 (03CR) 10Umherirrender: "Patch Set 3: Fixed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 (owner: 10Umherirrender)
[19:10:04] <grrrit-wm>	 (03CR) 10Umherirrender: "Please have a look at the xml format of the api:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77862 (owner: 10Henning Snater)
[19:11:22] <grrrit-wm>	 (03PS3) 10Aude: Split code for handling site link comments in client (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 
[19:12:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Split code for handling site link comments in client (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 (owner: 10Aude)
[19:24:21] <grrrit-wm>	 (03PS4) 10Aude: Split code for handling site link comments in client (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 
[19:26:38] <lazowik>	 aude: yay \o/
[19:27:09] <lazowik>	 and how's the disabled test(s)?
[19:28:31] <aude>	 lazowik: this works with badges
[19:28:42] <aude>	 i need to now ensure it's backwards compatible
[19:29:01] <aude>	 and the code is still ugly though tested and a bit improved
[19:29:01] <lazowik>	 aude: yep, also see my comments for ps 2
[19:29:05] <aude>	 sure
[19:45:05] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "Looks good, though I'd need to verify behaviour of the used unserializer." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 (owner: 10Umherirrender)
[20:07:54] <grrrit-wm>	 (03PS5) 10Aude: Split code for handling site link comments in client (DRAFT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/81924 
[22:02:44] <grrrit-wm>	 (03CR) 10Umherirrender: "A ClaimsSerializerTest class exists. The method SerializerBaseTest::testGetSerializedValid of the parent class, is "roundtripping" the ser" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/82096 (owner: 10Umherirrender)