[00:20:38] (03CR) 10Legoktm: "Made a mistake in the bug number, it should have been bug 53309" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm) [01:49:14] (03PS1) 10Jeroen De Dauw: Add files with no coverage at all to the coverage report as well [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/80948 [01:53:34] (03PS1) 10Jeroen De Dauw: Update README [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/80949 [01:53:45] (03CR) 10Jeroen De Dauw: [C: 032] Update README [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/80949 (owner: 10Jeroen De Dauw) [01:53:59] (03Merged) 10jenkins-bot: Update README [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/80949 (owner: 10Jeroen De Dauw) [05:13:43] Change on 12meta_wikimedia a page Wikidata was modified, changed by Allen4names link https://meta.wikimedia.org/w/index.php?diff=5746734 edit summary: [+69] Strikeout dead link, add a link to the test Wikidata, and use protocol relative URLs. [10:25:48] http://ultimategerardm.blogspot.nl/2013/08/reviving-my-bot-for-wikidata-ii.html [10:27:22] could someone take a look at [[Q23]] and tell me whether it's protected or not? [10:27:23] 10[4] 10https://www.wikidata.org/wiki/Q23 [10:29:04] I am unable to tell [10:29:38] YairRand: don't think it is [10:29:43] nothing in the protection log for it [10:29:47] strange [10:29:57] I'm not able to edit it while logged out [10:30:06] hmmm [10:30:42] and you can edit other items? [10:31:06] yes [10:31:52] i really don't know but maybe something bad in the caches [10:32:08] e.g. squid [10:32:11] varnish [10:33:09] do you get any javascript errors? [10:33:34] nope [10:34:21] hm, with debug=true the page becomes editable [10:34:46] that indicates something stuck in the caches [10:34:57] but i can't say for certain [10:35:06] (03PS2) 10Tobias Gritschacher: Add success marker to claim API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80962 (owner: 10Addshore) [10:36:44] (03CR) 10jenkins-bot: [V: 04-1] Add success marker to claim API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80962 (owner: 10Addshore) [10:37:45] (03CR) 10Henning Snater: [C: 04-1] "(4 comments)" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/77479 (owner: 10Daniel Werner) [10:41:30] (03PS7) 10Addshore: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79785 [10:42:22] Raymond_: repo: http://wklej.org/hash/0cfa2cdda85/ [10:42:34] you have to adjust things in "<>" brackets [10:42:42] and db settings [10:44:11] (03PS3) 10Addshore: Add success marker to claim API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80962 [10:44:21] I think it's better when you run the installation and then follow http://www.mediawiki.org/wiki/Extension:Wikibase_Repository [10:45:51] (03CR) 10jenkins-bot: [V: 04-1] Add success marker to claim API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80962 (owner: 10Addshore) [10:47:42] (03PS4) 10Addshore: Add success marker to claim API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80962 [10:47:49] and client: http://wklej.org/id/1116746/ [10:47:58] also better to follow http://www.mediawiki.org/wiki/Extension:Wikibase_Client [10:48:05] note that this is not a production code [10:48:08] debugging is added [10:48:19] Raymond_: ^ [10:50:13] (03PS5) 10Addshore: Add success marker to claim API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80962 [10:50:47] lazowik: thanks, will have a look [10:51:19] np [10:53:35] Lydia_WMDE: a bit funky formatting, but https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/docs/options.wiki [10:54:16] localClientDatabases is the important one but only for dispatching changes [10:54:19] (03CR) 10Tobias Gritschacher: [C: 032] Add code coverage ignore [extensions/Diff] - 10https://gerrit.wikimedia.org/r/80368 (owner: 10Jeroen De Dauw) [10:54:27] (03Merged) 10jenkins-bot: Add code coverage ignore [extensions/Diff] - 10https://gerrit.wikimedia.org/r/80368 (owner: 10Jeroen De Dauw) [10:54:29] (03CR) 10Tobias Gritschacher: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/Diff] - 10https://gerrit.wikimedia.org/r/80426 (owner: 10Jeroen De Dauw) [10:54:36] (03Merged) 10jenkins-bot: Add files with no coverage at all to the coverage report as well [extensions/Diff] - 10https://gerrit.wikimedia.org/r/80426 (owner: 10Jeroen De Dauw) [10:54:46] and changesDatabase and repoDatabase are important in the client [10:55:24] this options file is kept updated [10:58:15] (03CR) 10Tobias Gritschacher: [C: 032] Remove INSTALL file, as this info is already in the README [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80194 (owner: 10Jeroen De Dauw) [10:58:26] (03Merged) 10jenkins-bot: Remove INSTALL file, as this info is already in the README [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80194 (owner: 10Jeroen De Dauw) [11:00:39] (03CR) 10Tobias Gritschacher: [C: 032] Have the entry point make sure the dependencies are loaded [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80196 (owner: 10Jeroen De Dauw) [11:00:49] (03Merged) 10jenkins-bot: Have the entry point make sure the dependencies are loaded [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80196 (owner: 10Jeroen De Dauw) [11:22:12] (03CR) 10Tobias Gritschacher: [C: 032] Add success marker to claim API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80962 (owner: 10Addshore) [11:23:29] hi, I have some troubles working with API: I sent this snak:{"latitude":35.92306,"globe":"http://www.wikidata.org/entity/Q2","precision":1e-05,"longitude":46.64611} or even this:{"latitude":35.923056,"longitude":46.646111} [11:23:35] both returns this: [11:23:41] (03Merged) 10jenkins-bot: Add success marker to claim API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80962 (owner: 10Addshore) [11:23:52] API query error: {u'servedby': u'mw1194', u'error': {u'info': u'Invalid snak: IllegalValueException', u'code': u'invalid-snak'}} [11:24:12] Amir1: on wikidata or test wikidata? [11:24:17] wikidata [11:24:38] not sure about the precision [11:24:57] i give it something like 0.000001 [11:24:59] I tested it even without the precision [11:25:03] ok [11:25:54] (I tested it even with 0.00001 too) [11:26:00] huh [11:26:58] Amir1: which api module are you using? [11:27:20] I sent it via pywikibto [11:27:27] pywikibot [11:27:39] mhhm, okay, which pywikibot function are you sending it with? :P [11:28:09] 'action': 'wbsetclaimvalue', [11:28:10] 'snaktype': 'value', [11:28:12] 'value': value, [11:28:15] okay [11:28:18] oh [11:28:25] that's the one api module i've not used yet [11:28:30] sorry this: [11:28:33] 'action': 'wbcreateclaim', [11:28:33] should all work the same [11:28:34] 'entity': self.title().replace("Q", "q"), [11:28:36] oh, yes [11:28:36] 'snaktype': 'value', [11:28:37] 'property': "p%d" % propertyID, [11:28:39] 'value': value, [11:28:59] so wbcreateclaim? [11:29:09] addshore: yeah [11:29:10] let me generate a link to test it [11:29:39] well looking at the example in api.php your snak does indeed look wrong [11:29:53] the example value is {"entity-type":"item","numeric-id":1} [11:30:07] so...# [11:31:04] addshore: that's for item data values [11:31:09] he's creating geocoordinate [11:31:21] format=json&bot=1&value=%7B%22latitude%22%3A35.923056%2C%22longitude%22%3A46.646111%7D&entity=q6419602&token=91a4fc619400425a0545d55b6ffb01c3%2B%5C&snaktype=value&action=wbcreateclaim&property=p57 [11:31:35] I think I find the problem [11:31:44] Amir1: you need to json encode the value [11:31:47] '{"p1234":[ {"latitude":35.92306,"globe":"http://www.wikidata.org/entity/Q2","precision":1e-05,"longitude":46.64611} ]}'; ?? [11:31:54] '{"latitude":40.748433,"longitude":-73.985656,"globe":"http://www.wikidata.org/entity/Q2"}', [11:32:05] value = '{"latitude":40.748433,"longitude":-73.985656,"globe":"http://www.wikidata.org/entity/Q2"}', [11:32:20] http://www.mediawiki.org/wiki/Extension:Wikibase_Repository/API#wbcreateclaim [11:32:20] ahh yes, if your passing property in the api param :) [11:32:27] I'm looking for the bug for five hours [11:32:34] stupid [11:32:35] shit [11:33:02] * aude spent a long time reverse engineering all the api calls, due to poor documentation [11:33:19] can you believe that [11:33:21] tried to make the documentation better when possible but it's still something to improve [11:33:25] five hours on nothing [11:33:34] * aude believes [11:33:43] I just set the property wrong [11:33:57] :D [11:34:00] ok [11:34:06] (03CR) 10Tobias Gritschacher: [C: 032] Optimized copyright warning message output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80961 (owner: 10Henning Snater) [11:34:41] (03CR) 10Tobias Gritschacher: [C: 032] Remove result object which was no longer loaded anyway [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80375 (owner: 10Jeroen De Dauw) [11:34:52] (03Merged) 10jenkins-bot: Remove result object which was no longer loaded anyway [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80375 (owner: 10Jeroen De Dauw) [11:35:42] (03Merged) 10jenkins-bot: Optimized copyright warning message output [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80961 (owner: 10Henning Snater) [11:35:53] (03CR) 10Tobias Gritschacher: [C: 032] Style fixes in LanguageFallbackChain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80382 (owner: 10Jeroen De Dauw) [11:36:22] It's working now [11:36:24] http://www.wikidata.org/wiki/Q6419602 [11:36:44] a question: how many coordinates do you have? [11:37:01] yay, coordinates from fawiki :) [11:37:14] (03PS1) 10Addshore: Add further example to wbcreateclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80979 [11:37:19] aude ^^ ;p [11:37:21] we harvested some databases for fawiki many years ago [11:37:24] :) [11:37:29] (03Merged) 10jenkins-bot: Style fixes in LanguageFallbackChain [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80382 (owner: 10Jeroen De Dauw) [11:37:31] I really wanted to import them to wikidata [11:37:45] not all the wikis are as easy for extracting coordinates as enwiki [11:38:01] fawiki especially has lots of places that are not in enwiki [11:38:45] yeah almost 30K items [11:39:09] Lydia_WMDE, aude: re "[Wikitech-l] unexpected error info in HTML": is this still happening? Do we have a bug for this? [11:39:13] * addshore wonders if he should run his bot over fawiki quickly ;p [11:39:18] DanielK_WMDE: no idea [11:39:36] liangent: do you know? [11:39:39] DanielK_WMDE: looking [11:39:59] (03CR) 10Tobias Gritschacher: [C: 032] Cleanup in some formatting related classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80218 (owner: 10Jeroen De Dauw) [11:40:07] addshore: not on my watch :D [11:40:34] DanielK_WMDE: no should be solved and only left in some caches maybe [11:40:40] (03CR) 10Tobias Gritschacher: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/80948 (owner: 10Jeroen De Dauw) [11:40:55] that one...., yes should be solved [11:41:08] (03Merged) 10jenkins-bot: Add files with no coverage at all to the coverage report as well [extensions/WikibaseQueryEngine] - 10https://gerrit.wikimedia.org/r/80948 (owner: 10Jeroen De Dauw) [11:41:19] (03CR) 10Aude: [C: 032] Add further example to wbcreateclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80979 (owner: 10Addshore) [11:41:22] (03CR) 10Tobias Gritschacher: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/Ask] - 10https://gerrit.wikimedia.org/r/80425 (owner: 10Jeroen De Dauw) [11:41:42] Lydia_WMDE: ok, i'll just untag that mail, then :) [11:41:44] (03Merged) 10jenkins-bot: Add files with no coverage at all to the coverage report as well [extensions/Ask] - 10https://gerrit.wikimedia.org/r/80425 (owner: 10Jeroen De Dauw) [11:41:45] (03Merged) 10jenkins-bot: Cleanup in some formatting related classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80218 (owner: 10Jeroen De Dauw) [11:41:50] k [11:43:12] (03Merged) 10jenkins-bot: Add further example to wbcreateclaim [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80979 (owner: 10Addshore) [11:44:33] (03CR) 10Tobias Gritschacher: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80423 (owner: 10Jeroen De Dauw) [11:45:17] (03CR) 10Tobias Gritschacher: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/80422 (owner: 10Jeroen De Dauw) [11:45:28] (03Merged) 10jenkins-bot: Add files with no coverage at all to the coverage report as well [extensions/WikibaseDatabase] - 10https://gerrit.wikimedia.org/r/80422 (owner: 10Jeroen De Dauw) [11:46:06] (03Merged) 10jenkins-bot: Add files with no coverage at all to the coverage report as well [extensions/WikibaseQuery] - 10https://gerrit.wikimedia.org/r/80423 (owner: 10Jeroen De Dauw) [11:46:12] hehe aude *runs it anyway* ;p [11:47:19] about 86,000 possible coords :O [11:49:24] Amir1: I'll let you know how many it manages to add! [11:49:32] [travis-ci] wikimedia/mediawiki-extensions-Ask#71 (master - d99a37a : jenkins-bot): The build passed. [11:49:33] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Ask/compare/7494c594a0b7...d99a37a266e2 [11:49:33] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Ask/builds/10620617 [11:49:45] * aude deletes all the gnd types :) [11:52:18] addshore: I want to know how many coordinates are imported from fawp [11:52:26] can you get that [11:53:58] (03CR) 10Tobias Gritschacher: [C: 032] Add files with no coverage at all to the coverage report as well [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/80427 (owner: 10Jeroen De Dauw) [11:54:06] (03Merged) 10jenkins-bot: Add files with no coverage at all to the coverage report as well [extensions/DataTypes] - 10https://gerrit.wikimedia.org/r/80427 (owner: 10Jeroen De Dauw) [11:54:12] mhhhm, dont think so Amir1 :/ [11:54:22] best off asking someone that scans the DB dumps! [11:54:43] can you give an example [11:54:49] who is working DB [11:55:09] in wikidata Byrial was very active in this filed [11:55:14] *field [11:55:14] https://www.wikidata.org/wiki/User:Byrial [11:55:19] (03CR) 10Tobias Gritschacher: [C: 032] Make methods that should be implemented abstract [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80199 (owner: 10Jeroen De Dauw) [11:55:20] :> [11:55:28] (03Merged) 10jenkins-bot: Make methods that should be implemented abstract [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80199 (owner: 10Jeroen De Dauw) [11:57:46] added 250 so far :O [11:57:48] (03CR) 10Tobias Gritschacher: [C: 032] Clean SpecialListDatatypes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80247 (owner: 10Jeroen De Dauw) [11:57:55] anyway, back to work [11:59:13] aude did you first convert ? the gnd codes ?? [11:59:22] (03Merged) 10jenkins-bot: Clean SpecialListDatatypes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80247 (owner: 10Jeroen De Dauw) [11:59:32] GerardM: just joking :) [11:59:50] i don't know the plan for handling gnd [12:00:15] pfff [12:00:54] probably a discussion i stay out of [12:05:04] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#36 (master - b7e1188 : jenkins-bot): The build has errored. [12:05:04] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/890dd40da386...b7e1188c9340 [12:05:04] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/10620746 [12:05:33] it will probably a lot of work [12:07:10] gah, too many mails marked TODO. giving up for today [12:08:56] GerardM: for the record, i think the GND type should be there; we can use any number of 3rd party classification systems, just like we incorporate different systems of canonical IDs. [12:09:15] DanielK_WMDE: community disagrees with you [12:09:20] Basing wikidata's basic structure on the GND type may be bad, but that doesn't mean the GND type shouldn't be recorded. [12:09:25] aude: silly them. [12:09:28] :) [12:10:10] just because GND isn't very useful for structuring wikidata shouldn't mean it is VERBOTEN [12:13:51] what is wrong in my local wikibase installation when I get "'List of values is complete.'" on an item? [12:14:11] Raymond_: populate the sites table? [12:14:23] Wikibase/lib/maintenance/populateSitesTable.php [12:14:36] aude: I have done it. still this error. [12:14:42] hmmmm [12:19:17] Raymond_: values = site links? [12:19:34] aude: what do you mean? [12:19:44] Raymond_: in the site link section of the page? [12:20:52] aude: I am not sure but I think the answer is no [12:20:58] hmmm [12:22:27] in the js console, what do you see if you try "wb.getSites();" [12:22:45] i get something like "Object {aawiki: WbSite..." [12:26:50] Tobi_WMDE: http://www.wikidata.org/wiki/Wikidata:Events [12:27:01] please add :) [12:31:57] (03PS3) 10Daniel Kinzler: Inject access to entities into EntityView. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/75886 [12:32:01] aude: --^ [12:32:31] DanielK_WMDE: ok [12:32:34] (03PS11) 10Henning Snater: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 [12:32:54] Raymond_: the name of the site group is probably not the group name used in the sites table [12:33:02] Raymond_: so wikibase would consider the group to be empty [12:33:49] Raymond_: compare what you have in $wgWBRepoSettings['siteLinkGroups'] to what you have in the sites table. [12:34:03] DanielK_WMDE: yeah. aude explained it to me in a query already. I will add an entry to the sites table [12:34:15] ok [12:34:29] thanks [12:34:39] not as easy as we'd like this to be, but on our todo to make it easier [12:35:23] (03PS4) 10Henning Snater: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 [12:36:32] (03CR) 10Daniel Kinzler: "PS 3 is a rebase with minor manual cleanup." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/75886 (owner: 10Daniel Kinzler) [12:47:39] (03PS12) 10Henning Snater: Using listview widget to group qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/78246 [12:47:44] (03PS5) 10Henning Snater: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 [13:05:21] Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=39154 and https://bugzilla.wikimedia.org/show_bug.cgi?id=37771 <- could you have a look please and give me a status update? [13:13:08] DanielK_WMDE: the GND record number SHOULD be there, it is the "main type (GND)" we need to get rid of. [13:14:01] (03CR) 10Daniel Kinzler: [C: 04-1] "(3 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/79928 (owner: 10Nilesh) [13:15:19] Lydia_WMDE: is http://www.wikidata.org/wiki/Special:EntitiesWithoutLabel sorted for prevalence from high to low ? [13:16:06] GerardM: not yet i think [13:16:41] That would make it a paper cut because by working from high to low you have impact [13:17:01] and that is what stimulates people to do it [13:17:36] yeah [13:17:39] i will file a bug later [13:17:59] Lydia_WMDE: Personally, I would consider them "outdated" since the UI is scheduled to experience a major redesign in the mid-term future anyway. [13:18:01] when you have done so let me know [13:18:16] agree with Henning_WMDE [13:18:23] Or do you want me to do this for you ... happy to oblige [13:18:24] let's close both as resolved fixed, Lydia_WMDE [13:18:38] ok will do [13:19:03] GerardM: no need to :) [13:19:44] I will blog about this once implemented ... it is so helpful [13:19:59] adding the number of uses would also be great [13:21:32] Lydia_WMDE: Then I guess you probably want to close at least https://bugzilla.wikimedia.org/show_bug.cgi?id=39127 as well. [13:22:06] ok [13:35:17] (03PS6) 10Henning Snater: Implemented ordering of snaks within SnakList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80005 [13:37:53] (03CR) 10Daniel Kinzler: [C: 04-1] "(8 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/79936 (owner: 10Nilesh) [13:40:40] DanielK_WMDE: know what? [13:41:27] aude: Lydia_WMDE ^ [13:41:40] liangent: solved :) [13:41:42] never mind [13:42:44] (03CR) 10Daniel Kinzler: [C: 04-1] "(2 comments)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/77060 (owner: 10Nilesh) [13:43:44] (03CR) 10Daniel Kinzler: [C: 032 V: 032] Added doc to createtables.py, removed trailing whitespace. [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/77361 (owner: 10Nilesh) [13:47:20] (03CR) 10Daniel Kinzler: [C: 04-1] "(1 comment)" [extensions/WikidataEntitySuggester] - 10https://gerrit.wikimedia.org/r/77146 (owner: 10Nilesh) [13:48:04] does anyone know if precision in globe coordinate is allowed to be null? [13:48:13] Henning_WMDE: Tobi_WMDE Denny_WMDE DanielK_WMDE ^ [13:48:30] it shouldn't but I don't know about the implementation [13:48:37] hmmm, ok [13:48:40] Henning_WMDE: knows.. :) [13:49:01] in the old code, is ee ( isset( $data['precision'] ) ) ? $data['precision'] : null [13:49:15] which means if the api user does not supply then it can be null? [13:49:17] it is allowed to be 0 though [13:49:27] hmmm [13:49:35] i don't see where it got set to a default if null [13:49:46] i am talking data model spec here, not implementation [13:49:49] ok [13:50:30] in the old code, null was allowed ... it seems [13:50:47] in the new code, precision appears optional but then is default to null [13:51:00] and then an assert is made to check it's numeric [13:51:06] so then null is not alloed [13:51:08] hum? [13:51:08] allowed [13:51:24] it needs a default numeric value or needs to allow null [13:51:28] it should default to 0 [13:51:33] ok [13:51:35] and then the assert wouldnt fail [13:51:40] k [13:51:47] there's also an issue with globe [13:51:52] * aude preparing backport [13:52:11] same issue with null, that it accepts null and then currently does not set a default [13:52:16] in the old code, a default was set [13:53:23] aude: Denny_WMDE: got changed here https://gerrit.wikimedia.org/r/#/c/79992/ [13:53:25] "0" indicates infinite precision, right? Is that sensible? [13:53:30] so, null is not possible anymore [13:53:34] looking [13:53:46] Semantically, null would indicate "unknown", which seems more appropriate, there is no such thing as infinite precision... [13:53:53] DanielK_WMDE: it's the API [13:54:06] if the API edit says it is 0, it is 0 [13:54:09] if it's required, then we supply a default? [13:54:19] or api returns an error to the user? [13:55:08] the UI should be smarter about this, though [13:55:23] aude: not sure about the globe [13:55:27] Denny_WMDE: bots don't know about ui [13:55:34] a good bot should supply precision [13:55:38] aude: agreed [13:55:53] globe should default to earth [13:56:12] so, we'll make precision required and return api error [13:56:21] globe default to earth [13:56:25] wait [13:56:39] I have the feeling it should be the same [13:56:50] either make both required or both optional and defaulting [13:57:08] a default for precision seems bad, now that i think about it [13:57:13] for globe, it's reasonable [13:57:18] gut feeling would be to make both required [13:57:37] hmmmm, ok [13:57:57] this relieves us from configuring the default globe [13:58:08] that means a change in my bot code, which is fine [13:58:19] and it makes the bot developers have to think about globes in the first place [13:58:20] and that we need to properly catch the exceptions in the api [13:58:23] sure [14:01:46] (03CR) 10Tobias Gritschacher: [C: 032] Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79785 (owner: 10Addshore) [14:03:28] (03PS1) 10Aude: globe param cannot be null, update exception message [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80988 [14:04:24] (03Merged) 10jenkins-bot: Refactor GetEntities Test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79785 (owner: 10Addshore) [14:04:58] Lydia_WMDE: it needs to be announced that precision and globe params are required for globecoordinates as of tonight [14:05:05] breaking change [14:15:45] Tobi_WMDE: addshore want to approve https://gerrit.wikimedia.org/r/80988 ? [14:16:04] null is not allowed, so let's not be misleading [14:16:26] (03CR) 10Tobias Gritschacher: [C: 032] globe param cannot be null, update exception message [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80988 (owner: 10Aude) [14:16:27] (03CR) 10Addshore: [V: 032] globe param cannot be null, update exception message [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80988 (owner: 10Aude) [14:16:31] :) [14:17:04] otherwise, my bot is working fine on test.wikidata [14:17:14] well, whoops... [14:17:15] just had to add globe parameter [14:17:24] no regressions [14:18:50] addshore: i'll backport legoktm 's patch and the data values thing [14:18:55] :> [14:18:56] then we are good [14:19:04] the datavalues thing? [14:19:06] then settings, but not till later [14:19:10] the misleading error [14:19:15] it's annoying [14:19:17] ahh okay :0 [14:19:19] :) [14:19:25] bot authors will see it [14:19:51] if you feel like it you could backport my change to add success flags to all claim api modules too ;p [14:20:13] that can probably wait 2 weeks [14:20:16] not a regression [14:20:18] :P [14:21:17] addshore: i can backport the create claim example [14:21:23] * aude thinks it is helpful [14:23:42] indeed, the more examples the better! [14:24:02] If I ever find myself wondering about something and its not down as an example already I add it ;p [14:24:26] i didn't put mine in the api.php docs but put them on the wiki [14:26:33] Added 4500 coords from fawiki :) [14:26:55] (03PS1) 10Aude: Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80989 [14:27:00] (03PS1) 10Aude: Add further example to wbcreateclaim [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80990 [14:27:09] (03CR) 10Aude: [C: 032] Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80989 (owner: 10Aude) [14:27:10] *3500 [14:27:19] (03CR) 10Tobias Gritschacher: [C: 032] Selenium: fix waitForApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79972 (owner: 10Tobias Gritschacher) [14:27:24] (03CR) 10Aude: [C: 032] Add further example to wbcreateclaim [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80990 (owner: 10Aude) [14:27:51] (03CR) 10Tobias Gritschacher: [C: 032] Selenium: add tags to tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79973 (owner: 10Tobias Gritschacher) [14:29:07] (03PS1) 10Aude: globe param cannot be null, update exception message [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80991 [14:29:17] (03CR) 10Aude: [C: 032] globe param cannot be null, update exception message [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80991 (owner: 10Aude) [14:29:27] (03Merged) 10jenkins-bot: globe param cannot be null, update exception message [extensions/DataValues] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80991 (owner: 10Aude) [14:29:52] (03CR) 10Tobias Gritschacher: [C: 032] Rename steps directory to be standard conform [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80062 (owner: 10Tobias Gritschacher) [14:31:20] [travis-ci] wikimedia/mediawiki-extensions-DataValues#208 (mw1.22-wmf14 - acf7c41 : aude): The build passed. [14:31:20] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/5fcc5518fe77...acf7c4132d66 [14:31:20] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/10625977 [14:31:34] (03Merged) 10jenkins-bot: Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80989 (owner: 10Aude) [14:34:08] (03Merged) 10jenkins-bot: Selenium: fix waitForApi [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79972 (owner: 10Tobias Gritschacher) [14:35:32] (03Merged) 10jenkins-bot: Add further example to wbcreateclaim [extensions/Wikibase] (mw1.22-wmf14) - 10https://gerrit.wikimedia.org/r/80990 (owner: 10Aude) [14:37:59] (03Merged) 10jenkins-bot: Selenium: add tags to tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/79973 (owner: 10Tobias Gritschacher) [14:40:27] (03Merged) 10jenkins-bot: Rename steps directory to be standard conform [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80062 (owner: 10Tobias Gritschacher) [15:00:20] (03CR) 10Aude: [C: 032] Deprecate badly designed methods that inherently use global state [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80867 (owner: 10Jeroen De Dauw) [15:00:31] (03Merged) 10jenkins-bot: Deprecate badly designed methods that inherently use global state [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80867 (owner: 10Jeroen De Dauw) [15:10:29] (03CR) 10Aude: [C: 032] Inject access to entities into EntityView. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/75886 (owner: 10Daniel Kinzler) [15:13:05] (03Merged) 10jenkins-bot: Inject access to entities into EntityView. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/75886 (owner: 10Daniel Kinzler) [15:13:35] (03PS25) 10Liangent: Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 [15:14:20] (03PS7) 10Liangent: Allow mw.wikibase.label( ) to find labels written in variants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 [15:16:30] (03CR) 10jenkins-bot: [V: 04-1] Label and description serialization now accepts LanguageFallbackChain as the language option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72225 (owner: 10Liangent) [15:17:36] aude: yay, thanks :D [15:17:42] :) [15:19:03] (03CR) 10jenkins-bot: [V: 04-1] Allow mw.wikibase.label( ) to find labels written in variants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72751 (owner: 10Liangent) [15:19:18] ^ why [15:19:28] rebase creates -1? [15:20:08] liangent: Tests are failing now: https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests/3230/console [15:20:27] hoo: that is, why are they failing now [15:20:35] that's indeed weird [15:20:41] has anyone added new tests? [15:20:47] hmmmmm [15:21:11] aude: Those are some of the tests I spend ages getting to work on Travis... [15:21:33] addshore wanted to refactor them, but I didn't follow up... did he? [15:21:38] https://gerrit.wikimedia.org/r/#/c/79785/ [15:21:49] they passed on jenkins [15:21:50] :P [15:22:44] addshore: uhm, I hope you kept all the normalization ones in there? [15:23:17] as far as I am aware [15:23:51] (03PS1) 10Liangent: EMPTY [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80997 [15:23:52] also the ones for item id normalization? [15:26:28] hmm the id normalization ones..? [15:26:44] addshore: Yes... q123 and Q123 are the same actually [15:27:20] hm that might have slipped out! [15:27:26] (03Abandoned) 10Liangent: EMPTY [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80997 (owner: 10Liangent) [15:28:08] addshore: I know why now! [15:28:13] addshore: Please try to make them better understandable... you should really have added me as reviewer, you even removed me from authors, so you should have seen that i've worked on that before [15:28:16] addshore: you shouldn't use no in tests [15:28:23] it's a deprecated one [15:28:35] liangent: 'no' ? [15:28:40] language 'no' [15:28:42] as lang code [15:29:16] addshore: Going to revert if you don't mind, you can resubmit it fixed later?! [15:29:35] mhhhm, it would be easier to submit a patch that fixes it [15:29:43] well, go ahead then [15:29:57] and also please document it better and add tests for everything you removed [15:30:07] my patch fixes that code by using nb instead "aggressively" [15:30:09] I had some very specific tests in there [15:30:27] hoo, as far as I am aware I have [15:30:48]