[02:16:58] <DangSunM>	 ! Is !
[02:17:16] <Amqui>	 hi DangSunM`
[02:17:30] <DangSunM>	 Hi
[02:17:37] <Revi>	 hey DangSunM you must have no permission
[02:17:47] <Revi>	 like this.
[02:17:49] <Revi>	 !test is test
[02:17:49] <wm-bot>	 You are not authorized to perform this, sorry
[02:17:53] <Revi>	 yeap
[02:17:55] <DangSunM>	 ㅋㅋㅋㅋ
[02:20:25] <Amqui>	 lol
[02:23:14] * Hazard-SJ  sighs

[02:23:14] <Hazard-SJ>	 No simple querying mechanism, I'll have to use the db
[02:23:31] * Revi  spank DangSunM

[02:26:14] <Hazard-SJ>	 :| I had a 45.71 second lag
[04:47:35] <LA2>	 what's up with you idiots? Why do you create Wikidata entries for articles that have no interwiki links?
[04:47:52] <LA2>	 now I get an error, and a long and complicated instruction for merging
[04:47:58] <LA2>	 make it easy
[04:53:03] <legoktm>	 …..
[04:53:04] <legoktm>	 ????
[04:53:10] <legoktm>	 Well.
[06:14:24] <GerardM>	 good morning ...
[06:14:44] <GerardM>	 India does also not have good information on its presidents
[06:15:09] <GerardM>	 arguably, Wikidata does NOT have enough data
[06:15:50] <legoktm>	 that's news to me ;-)
[06:16:57] <GerardM>	 <grin> what part ... 
[06:17:34] <legoktm>	 not having enough data :P
[06:17:42] <legoktm>	 can we get this data from an infobox somewhere?
[06:18:15] <legoktm>	 https://www.mediawiki.org/wiki/Manual:Pywikipediabot/harvest_template.py is very easy to use
[06:26:07] <GerardM>	 <grin> so you say... so fix it ?
[06:30:12] <GerardM>	 http://tools.wmflabs.org/pywikibot/ is not clear what to download ...
[06:31:25] <legoktm>	 https://www.mediawiki.org/wiki/Manual:Pywikipediabot/Installation
[07:19:52] <legoktm>	 addshore: https://bugzilla.wikimedia.org/53309 fix plz
[08:18:50] <grrrit-wm>	 (03PS1) 10Legoktm: Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 
[08:19:07] <legoktm>	 addshore: ^ like that :P
[08:19:24] <legoktm>	 i have no clue if it'll work, i don't have a local install set up
[08:19:34] <addshore>	 :P
[08:19:43] <legoktm>	 oh
[08:19:46] <legoktm>	 that won't work.
[08:19:46] <legoktm>	 ugh
[08:20:07] <addshore>	 :D
[08:20:32] <addshore>	 well, jekins still might pass it xD the getentities tests is one of the sets of tests I havn't overhauled yet :P
[08:20:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[08:21:57] <addshore>	 or not ;p
[08:30:00] <grrrit-wm>	 (03PS2) 10Legoktm: Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 
[08:30:19] <legoktm>	 lets see if that works...
[08:31:39] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[08:31:44] <legoktm>	 bahhh
[08:32:11] <addshore>	 :D
[08:33:41] <legoktm>	 08:31:35 1) Wikibase\Test\SnakTest::testToArrayRoundtrip with data set #3 (Wikibase\PropertyValueSnak)
[08:33:42] <legoktm>	 08:31:35 getArray newFromArray roundtrip should work
[08:33:42] <legoktm>	 08:31:35 Failed asserting that false is true.
[08:33:49] <legoktm>	 i don't see how that's my fault
[08:34:19] <addshore>	 indeed that does look a bit odd...
[08:34:39] <legoktm>	 08:31:35 3) Wikibase\Test\Api\GetEntitiesTest::testGetEntitiesByBadSite
[08:34:40] <legoktm>	 08:31:35 Failed asserting that exception of type "UsageException" is thrown. <-- that one probably is
[08:39:07] <legoktm>	 Blah
[08:39:17] <legoktm>	 I don't know why that one is failing either.
[08:41:21] <legoktm>	 addshore: help plz :/
[08:43:21] <addshore>	 gimmie 2 ticks
[08:46:11] <legoktm>	 ✓✓
[08:46:13] <legoktm>	 ;-)
[08:46:15] <addshore>	 xD
[08:46:48] <grrrit-wm>	 (03PD1) 10Addshore: fix where we get the EntityIdParser from [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80792 
[08:47:02] <addshore>	 jenkins fails on this too...
[08:47:30] <addshore>	 getArray newFromArray roundtrip should work is something unrelated so you only have to fix the other failing test (the exception)
[08:47:46] <addshore>	 and Ill go and see why this has suddenly started failing >.<
[08:48:31] <legoktm>	 im not sure why the other test isn't raising the exception…i can't figure out what function should be raising the UsageException....
[08:50:27] <addshore>	 *takes a look*
[08:55:07] <addshore>	 hmm, indeed rather odd
[08:58:22] <addshore>	 oh legoktm I might have filed a bug about this xD
[08:58:27] <addshore>	 HAH
[08:58:30] <legoktm>	 o.O
[08:58:55] <addshore>	 this is one I found the other day but it wasnt breaking tests, itembytitle helper throws a div0 error instead of a usage exception ;p
[08:59:32] <addshore>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=53037
[08:59:57] <addshore>	 havn't had time to look at it at all yet
[09:00:25] <addshore>	 ironically I found it while I was rewriting the getentitiestests!
[09:00:52] <legoktm>	 lolwut
[09:02:09] <addshore>	 heh, it confused me at firs too ;p and jenkis isn't very helpfull as it just says there was no expected UsageException... when run localy I see Failed asserting that exception of type "PHPUnit_Framework_Error_Warning" matches expected exception "UsageException". Message was: "Division by zero"
[09:02:09] <addshore>	 .
[09:05:47] <addshore>	 legoktm: if you want to fix that bug also just add http://pastebin.com/Eah9zNyd on line 91ish of itembytitlehelper
[09:06:00] <legoktm>	 oh
[09:06:02] <addshore>	 then your tests should pass ;p
[09:06:07] <legoktm>	 :D
[09:08:01] <addshore>	 then the snaktest thats failing is related to wikibasedatamodel
[09:10:35] <addshore>	 which is odd as they pass lcoally
[09:11:25] <addshore>	 $this->assertTrue( $snak->equals( $copy ), 'getArray newFromArray roundtrip should work' );
[09:12:53] <legoktm>	 oh
[09:12:55] <legoktm>	 i think i know.
[09:13:27] <grrrit-wm>	 (03PS3) 10Legoktm: Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 
[09:14:43] <Amir1>	 legoktm: hi, how are you?
[09:14:50] <legoktm>	 hey Amir1 
[09:14:55] <legoktm>	 pretty good, you?
[09:15:00] <Amir1>	 fine.
[09:15:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[09:15:29] <Amir1>	 legoktm: what needs to be done about PWB?
[09:16:14] <legoktm>	 Uh, I've been doing some other stuff lately
[09:17:17] <Amir1>	 خن
[09:17:19] <Amir1>	 ok
[09:17:37] <Amir1>	 I merged some of your patches
[09:21:02] <legoktm>	 thanks :)
[09:21:08] <Amir1>	 yw
[09:24:19] <Amir1>	 legoktm: I'm thinking about rewriting the whole instillation manual 
[09:27:24] <legoktm>	 i don't think the whole thing needs to get re-written, just enhanced
[09:28:18] <addshore>	 hmm legoktm so apparently the snaks have different hashes on recreation
[09:29:31] <addshore>	 which makes it look like it was actually a change in datavalues xD
[09:33:23] <grrrit-wm>	 (03PS1) 10Addshore: Revert "Remove additions to deprecated global variable that are not in use anyway" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80794 
[09:33:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Revert "Remove additions to deprecated global variable that are not in use anyway" [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80794 (owner: 10Addshore)
[09:33:30] <addshore>	 ..
[09:37:18] <grrrit-wm>	 (03PS2) 10Addshore: Revert "Remove additions to deprecated global ..." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80794 
[09:42:39] <grrrit-wm>	 (03PS1) 10Addshore: Improve snak testToArrayRoundtrip test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80795 
[09:42:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Improve snak testToArrayRoundtrip test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80795 (owner: 10Addshore)
[09:43:40] <addshore>	 legoktm: once https://gerrit.wikimedia.org/r/80794  is merged your PS can be rebased and should be fine :)
[09:44:09] <legoktm>	 yay :D
[09:44:39] <legoktm>	 mind reviewing it in the meantime? :P
[09:45:43] <addshore>	 willdo ;p
[09:49:40] <grrrit-wm>	 (03CR) 10Addshore: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[09:49:59] <addshore>	 legoktm: ^^
[09:50:06] <legoktm>	 i got pinged by that too :P
[09:50:14] * addshore  slaps self ;p

[09:51:40] <grrrit-wm>	 (03CR) 10Legoktm: "(1 comment)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[09:51:52] <eikes>	 legoktm: ^^
[09:52:01] * legoktm  slaps eikes 

[09:52:05] <eikes>	 :(
[09:52:11] <legoktm>	 addshore: vv
[09:52:17] <grrrit-wm>	 (03PS4) 10Legoktm: Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 
[09:52:23] <legoktm>	 nailed it.
[09:52:26] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[09:52:31] <addshore>	 :P
[09:52:32] <legoktm>	 oh fu.
[09:52:39] <addshore>	 ignore the failing test ;p
[09:53:44] <addshore>	 oh wait, syntax error xD
[09:55:47] <legoktm>	 on my end?
[09:55:48] <legoktm>	 ugh
[09:56:03] <addshore>	 :>
[09:56:10] <grrrit-wm>	 (03PS5) 10Legoktm: Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 
[09:57:50] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[09:58:28] <addshore>	 legoktm: you need to add the fix for itemByTitleHelper also!
[10:01:01] <legoktm>	 huh?
[10:01:07] <legoktm>	 what?
[10:01:20] <addshore>	 you still get the div0 error ;p
[10:01:50] <legoktm>	 but that one isn't my fault i thought
[10:02:07] <addshore>	 yes, but your patchset can be merged without it ;p
[10:02:42] <addshore>	 mhhm, or ill make a patchset and you rebase ontop of it
[10:03:26] <legoktm>	 that sounds like a better plan :D
[10:05:30] <grrrit-wm>	 (03PS1) 10Addshore: Catch div zero error in ItemByTitleHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 
[10:05:43] <addshore>	 which no doubt will fail jenkins xD
[10:07:13] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Catch div zero error in ItemByTitleHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore)
[10:11:56] <grrrit-wm>	 (03CR) 10Addshore: "Also requires" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[10:13:19] <multichill>	 GerardM: Je moet party p102 doen, niet andersom
[10:28:33] <hoo>	 aude: hey ;)
[10:39:57] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Revert "Remove additions to deprecated global ..." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80794 (owner: 10Addshore)
[10:40:04] <grrrit-wm>	 (03Merged) 10jenkins-bot: Revert "Remove additions to deprecated global ..." [extensions/DataValues] - 10https://gerrit.wikimedia.org/r/80794 (owner: 10Addshore)
[10:40:09] <addshore>	 aude: :D
[10:40:52] <grrrit-wm>	 (03PS2) 10Addshore: fix where we get the EntityIdParser from [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80792 
[10:40:59] <grrrit-wm>	 (03PS2) 10Addshore: Improve snak testToArrayRoundtrip test [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80795 
[10:41:04] <grrrit-wm>	 (03PS2) 10Addshore: Catch div zero error in ItemByTitleHelper [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 
[10:41:13] <hoo>	 aude: Could you do the non-text tests with spam blacklist now? Only piece that's missing to merge it, IMO
[11:20:03] <aude>	 hoo: i'll take a look in a few minutes
[11:20:13] <hoo>	 \o/ :)
[11:20:21] * aude  code reviewing on my mobile phone earlier :)

[11:20:26] <aude>	 need a gerrit app
[11:21:03] <hoo>	 Oh yes, that would be great...
[11:21:28] <hoo>	 From time to time I even merged trivial stuff from my android (typos and stuff like that, never logical changes)
[11:21:33] <aude>	 i don't think it would be too hard
[12:05:15] <Amir1>	 can someone block this IP for non-logged in users?
[12:05:18] <Amir1>	 http://www.wikidata.org/wiki/Special:Contributions/10.4.0.220
[12:05:25] <Amir1>	 It's for Labs
[12:05:38] <Amir1>	 and not-logged bots edits
[12:05:39] <hoo>	 not again -.-
[12:06:38] <hoo>	 Amir1: Done
[12:06:50] <Amir1>	 hoo: thank you :)
[13:07:58] <grrrit-wm>	 (03CR) 10Aude: [C: 032] Improve snak testToArrayRoundtrip test. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80795 (owner: 10Addshore)
[13:08:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve snak testToArrayRoundtrip test. [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80795 (owner: 10Addshore)
[13:22:59] <aude>	 alright, if anyone can reproduce the issues in https://gerrit.wikimedia.org/r/#/c/77183/ then we need to look at that more
[13:24:24] <hoo>	 aude: as Tobi uses windows, and this might be some strange PHP issue (dunno which functions you are using internally and how these are implemented)
[13:24:41] <hoo>	 - and
[13:24:41] <AsimovBot>	 04Error: Command “and” not recognized. Please review and correct what you’ve written.
[13:25:34] <hoo>	 So, if you got a Windows system around for testing, I'd use it
[15:04:08] <Sky2042>	 Can someone in the channel tell me if RexxS's problem espoused in http://en.wikipedia.org/wiki/Wikipedia_talk:Wikidata#Auto-population_of_wikidata_into_infoboxes has been fixed?
[15:30:40] <liangent>	 aude: JeroenDeDauw: ping?
[16:26:51] <JeroenDeDauw>	 liangent: pong
[16:31:28] <liangent>	 JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/72226/31/repo/includes/EntityView.php
[16:31:44] <liangent>	 what's the correct way to make WB_EXPERIMENTAL_FEATURES ?
[16:33:05] <grrrit-wm>	 (03PS1) 10Jeroen De Dauw: Deprecate badly designed methods that inherently use global state [extensions/WikibaseDataModel] - 10https://gerrit.wikimedia.org/r/80867 
[16:42:59] <Sky2042>	 JeroenDeDauw: Not sure if you're the person to ask, but do you know of a bug/fix which describes the problem RexxS describes at http://en.wikipedia.org/wiki/Wikipedia_talk:Wikidata#Auto-population_of_wikidata_into_infoboxes
[16:48:26] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] fix where we get the EntityIdParser from. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80792 (owner: 10Addshore)
[17:00:39] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 (owner: 10Liangent)
[17:01:36] <JeroenDeDauw>	 liangent: replied
[17:04:14] <liangent>	 JeroenDeDauw: with useFeatureX, you still need some place to read $wgUseSquid and WB_EXPERIMENTAL_FEATURES
[17:06:17] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "Another Helper class, yay!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80797 (owner: 10Addshore)
[17:10:08] <hoo>	 oh come on, that helper class is bearable :P
[17:12:28] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/77183 (owner: 10Daniel Kinzler)
[17:19:53] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[17:23:21] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 04-1] "(3 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/71811 (owner: 10Daniel Kinzler)
[17:24:41] <JeroenDeDauw>	 liangent: yes of course they need to be read somewhere. It should just not be in the middle of runtime production code, esp not when using global access and putting it into a switch
[17:25:09] <JeroenDeDauw>	 liangent: read what I wrote on polymorphism, this is how to nicely solve it
[17:25:30] <JeroenDeDauw>	 hoo: perhaps. I'm just concerned about the recent profiliation of helper classes
[17:25:54] <JeroenDeDauw>	 hoo: they shout bad design. If you do things right, you'll not have much "helper" classes
[17:26:02] <JeroenDeDauw>	 At least they will not be named helper
[17:26:17] <hoo>	 ... problem is that the API needs a lot of "weird" things
[17:26:26] <JeroenDeDauw>	 hoo: no shit ;p
[17:26:54] <JeroenDeDauw>	 API.legacy.badness = >9000
[17:30:11] <Amir1>	 hi, do you think this user is right? or I just ignore him?
[17:30:12] <Amir1>	 http://www.wikidata.org/wiki/User_talk:Dexbot#Stop_the_bot_adding
[17:30:20] <Amir1>	 or her
[17:31:46] <Sky2042>	 Amir1: Being that user, see the results of the RFC. :)
[17:32:07] <hoo>	 JeroenDeDauw: :D
[17:33:02] <Amir1>	 Sky2042:  despite the fact that I can't understand the conclusion I'll stop my bot
[17:33:32] <Sky2042>	 Amir1: The conclusion is pretty plain; see the paragraph after the bullets.
[17:34:15] <Amir1>	 Sky2042: technically I can understand it but I mean don't get why
[17:34:21] <JeroenDeDauw>	 liangent: if something is not clear to you, do ask questions. I can elaborate on things if needed
[17:35:46] <Sky2042>	 Amir1: The why is that the closer found the !vote (and vote) against the GND pretty persuasive. If you do a head count, over 2/3 say that GND main type must go. If you check the arguments, (and I was one arguing that it should go), I think you would find more than 2/3 support against it.
[17:36:02] <liangent>	 JeroenDeDauw: eh I was doing something else. sorry for reading without replying :)
[17:36:48] <Amir1>	 Sky2042: In wiki we don't count votes
[17:36:56] <Amir1>	 I voted for b option
[17:37:53] <Sky2042>	 Amir1: Sure, I don't count votes either. I was simply making the statement that if you did, you would see greater than 1 to 2 majority opposition to GND main type. I /also/ made the statement that those opposed to it probably have multiple persuasive arguments about why it shouldn't be used.
[17:38:41] <Sky2042>	 (And I'm a he, btw.)
[17:38:55] <Amir1>	 anyway I stopped my bot I'll run it again without GND adding
[17:38:59] <Amir1>	 I have to go bye 
[17:39:24] <Sky2042>	 Sure, bye.
[17:50:27] <liangent>	 JeroenDeDauw: " If in experimental mode you inject one instance, " then another piece of code creating that instance is facing the same problem to access global or booleans
[17:50:40] <liangent>	 and where should it live?
[17:51:52] <liangent>	 EntityView looks already a messy enough place to throw them
[18:05:42] <JeroenDeDauw>	 liangent: putting a config switch in a top level factory class is much less problematic then putting it in the middle of a domain+presentation class
[18:05:51] <JeroenDeDauw>	 liangent: and yeah, EntityView is already a big mess
[18:05:59] <JeroenDeDauw>	 That does not mean we should just continue to add to it
[18:07:55] <JeroenDeDauw>	 liangent: in this particular case I think it is not worth the effort to spend much time on it though, as this is a temporary switch anyway
[18:08:06] <JeroenDeDauw>	 Idally we can just avoid having it altogether
[18:08:19] <liangent>	 that wgUseSquid is not temporary
[18:09:45] <JeroenDeDauw>	 liangent: I was talking about the exp constant
[18:11:19] <JeroenDeDauw>	 liangent: for the squid thing, you can already reduce its impact by injecting the language fallback chain
[18:11:30] <JeroenDeDauw>	 Then EntityView no longer needs to care about this thing at all
[18:13:03] <liangent>	 JeroenDeDauw: then the class who creates EntityView needs to care so..
[18:13:05] <JeroenDeDauw>	 liangent: if you push it out, the global ends up in ViewEntityAction and EntityContent
[18:13:15] <liangent>	 and its EntityContent
[18:13:24] <liangent>	 so that's better?
[18:14:05] <JeroenDeDauw>	 yes, global usage is forced upon less users
[18:14:22] <JeroenDeDauw>	 In these two classes it is hard to push it out further
[18:14:29] <JeroenDeDauw>	 Since they are not well designed either
[18:14:38] <JeroenDeDauw>	 And we basically do not have control over their lifecycle
[18:15:00] <JeroenDeDauw>	 Global access often cannot be avoided when dealing with luch legacy apis 
[18:16:04] <JeroenDeDauw>	 oh man, EntityView makes me want to cry :|
[18:20:08] <liangent>	 JeroenDeDauw: for exp: you think it's ok to leave it there for now?
[18:20:18] <liangent>	 as "it's temporary"
[18:23:04] <JeroenDeDauw>	 liangent: how temporary is it going to be? And is it really needed? Can't we just use the new behaviour?
[18:23:30] <JeroenDeDauw>	 liangent: just saw the LanguageFallbackChainFactory class. Why don't you have the code to switch on this global there?
[18:23:33] <liangent>	 JeroenDeDauw: current javascript works incorrectly with the new behaviro
[18:23:39] <JeroenDeDauw>	 You can inject the global as a switch into that factory
[18:23:48] <JeroenDeDauw>	 And then have the factory be constructed via WikibaseRepo
[18:23:54] <JeroenDeDauw>	 Oh wait
[18:23:58] <JeroenDeDauw>	 lib class
[18:24:14] <liangent>	 it's already in repo registry
[18:24:21] <JeroenDeDauw>	 Well, have it be constructed by the top level factory of whatever app is using it
[18:24:52] <JeroenDeDauw>	 liangent: ah, nice
[18:24:58] <JeroenDeDauw>	 so have the global in there
[18:25:12] <JeroenDeDauw>	 feed it to the constructor of LanguageFallbackChainFactory
[18:25:20] <JeroenDeDauw>	 And have the factory switch on it appropriately
[18:25:40] <liangent>	 you mean the squid one?
[18:28:05] <liangent>	 so I guess l124-l132 in repo/includes/EntityView.php patch 72226/31 would become something like $this->languageFallbackChain = $factory->newForEntityView( $context );
[18:28:15] <liangent>	 (or suggest a better name :p)
[18:28:39] <JeroenDeDauw>	 liangent: yeah, the squid one
[18:29:05] <JeroenDeDauw>	 liangent: no...
[18:29:12] <JeroenDeDauw>	 liangent: this factory should not know about EntityView
[18:29:44] <liangent>	 it's not really EntityView
[18:30:15] <Kolega2357>	 Can anyone administrator protect my user page?
[18:30:20] <JeroenDeDauw>	 liangent: entity view would have $fallbackChain = WikibaseRepo::globalInstance()->newFallbackChainFactory()->newFromContext( $this->getContext() );
[18:30:24] <liangent>	 its content would be just if ( $squid ) { return $this->newSomething() } else { return $this->newSomethingElse() }
[18:30:33] <eikes>	 Kolega2357: why?
[18:30:45] <liangent>	 JeroenDeDauw: so I said "suggest a better name"
[18:31:18] <JeroenDeDauw>	 liangent: you wrote something that has a different structure
[18:31:20] <Kolega2357>	 eikes: Self request. My user page vandalized cross Wiki
[18:31:40] <liangent>	 JeroenDeDauw: I don't understand what you said
[18:31:54] <JeroenDeDauw>	 liangent: ahhhh. confusion
[18:32:07] <Kolega2357>	 eikes: Like this (‎[edit=autoconfirmed] (indefinite) ‎[move=autoconfirmed] (indefinite)))
[18:32:25] <eikes>	 k
[18:35:20] <liangent>	 JeroenDeDauw: and .. ?
[18:37:11] <Kolega2357>	 Administrators please fix error http://www.wikidata.org/w/index.php?title=User_talk:Vogone&diff=66802322&oldid=66599440
[18:37:59] <eikes>	 ?
[18:38:17] <eikes>	 you're page is editprotected
[18:38:34] <eikes>	 *your
[18:38:36] <JohnLewis>	 Kolega2357: Fixed.
[18:38:57] <liangent>	 JohnLewis: hi
[18:39:28] <Kolega2357>	 JohnLewis: Thank you very much.
[18:39:31] <JohnLewis>	 liangent: Hi.
[18:39:47] <liangent>	 https://www.wikidata.org/wiki/User_talk:John_F._Lewis#GND - any idea?
[18:49:16] * Sky2042  looks at liangent's question.

[18:49:57] <Sky2042>	 liangent: You should use the most "close" claim. If a thing is an administrative unit, but it is also a US state, use instance of US state rather than instance of admin unit.
[18:50:05] <Sky2042>	 s/close/specific/
[18:50:16] <Sky2042>	 This is true of any item.
[18:52:06] <Sky2042>	 liangent: Though, your question is a little abstract. Is there a particular case as an example of whatever it is you're doing?
[18:53:17] <JohnLewis>	 liangent: Apolgoies for not answering that. I must have missed it. Sky2042 seems to have a more active idea than me right now so bug him :)
[18:58:20] <liangent>	 Sky2042: then what's its difference from https://www.wikidata.org/wiki/Property:P132 now?
[18:58:35] <Sky2042>	 liangent: P132 is a duplicate of P31 / P279. :D
[18:58:59] <liangent>	 Sky2042: then delete it?
[18:59:06] <Sky2042>	 liangent: We've tried. :D
[18:59:14] <liangent>	 but what?
[19:00:08] <Sky2042>	 People, for some reason, can't get over the notion that P31 / P279 can allow /any/ value. They seem to have forgotten that Wikidata has a particular set of 4 letters at the beginning of its name.
[19:01:12] <liangent>	 Sky2042: ok so should I use the same value for p132 and p31 now?
[19:02:03] <Sky2042>	 liangent: Sure.
[19:31:07] <tommorris>	 Sky2042: pass the smelling salts. People might edit it!
[19:31:23] * Sky2042  runs to get some salts.

[19:31:43] * Sky2042  returns without salts, for tommorris clearly does not need them.

[19:32:06] <Sky2042>	 That's the other problem with a main type or with GND main type: it encourages people to be lazy.
[19:32:21] <Sky2042>	 Which that was never voiced, but that makes it no less true.
[19:55:08] <jem->	 Hello everyone
[19:55:45] <jem->	 I guess we still have no way to tell which different values a given property takes in all the items which define them
[19:55:58] <jem->	 define it*
[19:59:28] <Sky2042>	 jem-: Hmm?
[20:02:24] <jem->	 Sky2042: I would like to know which different values property P132 (in this case) takes around Wikidata
[20:02:44] <jem->	 That would be easy in a SQL query, of course :)
[20:04:10] <Sky2042>	 jem-: Ah, no, no we don't. :)
[20:04:50] <jem->	 :)
[20:05:13] <jem->	 Ok, I can guess it is planned for the future
[20:05:15] <Sky2042>	 jem-: Just P132, or is this a more general question?
[20:05:23] <Sky2042>	 And for what use? Just "knowing"?
[20:05:24] <jem->	 Well, for the moment just P132
[20:05:30] <jem->	 I can explain
[20:05:55] <jem->	 The problem is that for the municipalities, in some cases the name of the country is added
[20:06:09] <jem->	 "Muncipality of the Netherlands" is the concrete case
[20:06:30] <jem->	 But "Municipality" is what appears fot Spanish municipalities
[20:06:33] <jem->	 for*
[20:07:05] <jem->	 So we have a problem when showing that in the infoboxes: add the country by ourselves or not?
[20:07:33] <jem->	 Knowing the % of cases with or without country would help to know what would make less harm for the moment
[20:07:34] <grrrit-wm>	 (03PS32) 10Liangent: Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 
[20:08:57] <Sky2042>	 jem-: You can probably drop a note at [[WD:DBR]] as a request, unless you want to do the query yourself.
[20:08:58] <AsimovBot>	 10[3] 10https://www.wikidata.org/wiki/WD:DBR?redirect=no - Redirection to 10https://www.wikidata.org/wiki/Wikidata:Database_reports
[20:15:00] <jem->	 Hmmmm, now that you mention it, maybe I can do a query in Toolserver myself
[20:15:42] <Sky2042>	 :D
[20:18:14] <grrrit-wm>	 (03PS33) 10Liangent: Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 
[20:22:08] <grrrit-wm>	 (03PS34) 10Liangent: Include preferred labels / descriptions for entities in JS on EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/72226 
[21:31:21] <grrrit-wm>	 (03CR) 10Legoktm: "(2 comments)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[21:31:24] <grrrit-wm>	 (03PS6) 10Legoktm: Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 
[21:31:46] <legoktm>	 JeroenDeDauw: ^
[23:17:25] <grrrit-wm>	 (03CR) 10Jeroen De Dauw: [C: 032] Allow for both ids and sites/titles to be set for wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/80790 (owner: 10Legoktm)
[23:17:33] <legoktm>	 yay :)