[00:03:09] ... and another run -.- [01:25:46] New patchset: Hoo man; "Drastically reduce the number of RL modules in clients" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70115 [01:26:06] that was harder than I thought -.- [01:32:12] New patchset: Hoo man; "Drastically reduce the number of RL modules in clients" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70115 [01:33:08] New review: Hoo man; "Stopped moving around declarations in lib/resources/Resources.php" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70115 [08:26:45] hi. who can I add as reviewer to https://gerrit.wikimedia.org/r/69874 ? [08:32:30] se4598_2: did you look https://bugzilla.wikimedia.org/show_bug.cgi?id=49887 already? [08:33:59] linnea: yes, whats about it? [08:36:05] se4598_2: oh sorry I missunderstand what you were talking about [09:01:22] Lydia_WMDE: moin. ick bin all hier. [09:02:37] hi DanielK_WMDE, da du dich gerad als aktiv geoutet hast, kannst du meine Frage 4 Zeilen hierüber beantworten? :) [09:05:04] se4598_2: ill add some [09:05:21] thanks [09:09:21] New review: Daniel Kinzler; "Some observations:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69874 [09:20:43] New review: Henning Snater; "JS change looks alright and it's good to have the messages separated. As mentioned, it would be nice..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69874 [09:22:33] Lydia_WMDE, Henning_WMDE: no daily today? [09:23:40] folks, do you know who maintains the wikidata vagrant config? [09:24:41] it seems to be based on an older mediawiki-vagrant config, and i'm hoping to persuade whomever is maintaining it to merge it back to mediawiki-vagrant as a role definition [09:25:07] ori-l: silke did, but she's no longer in the wikidata team. and she's just started a 5 week vacation... [09:25:38] i'm afraid it's orphaned for now. i suppose abraham would be the one to ask about it. i though he'd be back this week. [09:26:27] DanielK_WMDE: well, I could spend some time on it if it's useful. Do you have any sense of how useful it has been? [09:27:09] i.e., is it worth the time, in your opinion? [09:27:12] a few people have played with it... i don't know. perhaps Lydia_WMDE can give you an idea [09:27:23] for now, perhaps just file a bug [09:27:35] yeah, good idea [09:29:09] Denny_WMDE: hey! denny! [09:29:25] DanielK_WMDE: hey DanielK_WMDE hey hey! :) [09:29:53] :P [09:30:23] Denny_WMDE: are we going to have a daily hangout? i have a few issues [09:30:47] oh, we already did, sorry [09:30:55] i thought abraham would have you covered [09:31:11] the office is rather empty anyway, Tobi_WMDE and Henning_WMDE are here [09:31:29] let's talk? [09:31:35] i tried to ping via irc a couple of times, but abraham isn't here either [09:31:43] yea [09:32:06] sorry, i only switched my computer on after the daily [09:32:15] i will remind abraham to be around in IRC [09:32:46] .,..and in the hangout :) [09:33:01] ok, let'S talk briefly... hangout? skype? [09:33:24] as you prefer [09:34:04] i'm still in the hangout for the daily, just join that [09:34:44] joining...... [09:46:38] New patchset: Tobias Gritschacher; "Make use of Serializers in API results for sitelinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69689 [09:47:24] Denny_WMDE: https://gerrit.wikimedia.org/r/#/c/68952/5 [09:47:32] the discussion is mostly inline in the code comments [09:47:47] Denny_WMDE: i see that danwe has retracted his -1, but i'd be interested in your take on the issue. [09:48:14] ah, that is the one where you introduce the badsnak [09:48:23] yea [09:48:28] generally, there are quite a few patches for both low level and high level validation pending review. [09:48:47] usually i'd ask danwe and jeroen to review these, but they are both off this week. [09:48:56] i read the code already last week, and decided not to be qualified for it. jeroen should be incoming today [09:48:57] not sure how to procede there :/ [09:49:23] i will ask him to do it today. if he does not i will unblock you on this tomorrow [09:49:59] Denny_WMDE: well, the main question is whether the problem that makes the snak "bad" needs to be localizable or otherwise machine-readable. or if a simple error message is sufficient. [09:50:09] New patchset: Tobias Gritschacher; "Make use of Serializers in API results for sitelinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69689 [09:50:24] oh, well. [09:50:28] ok, thanks for now :) [09:50:56] what is the advantage of a badsnak over an exception? [09:51:13] if you want to discuss it with me today. it might be more efficient, not to :) [09:51:21] and you can discuss with jeroen later, or with me tomorrow [09:51:27] after that it will be resolved anyway [09:52:04] New patchset: Tobias Gritschacher; "Make use of Serializers in API results for sitelinks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69689 [09:53:53] New patchset: Tobias Gritschacher; "Fix @covers & @since tags" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70131 [09:54:56] New patchset: Tobias Gritschacher; "Fix @covers & @since tags" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70131 [09:57:30] Denny_WMDE: if a snak is bad because it's data somehow got corrupted, or the code changed, or a property got deleted, the we'd still want to be able to load and show the rest of the entity. [09:57:50] and when editing that entity, the bad snak shouldn't just be ignored and vanish [09:57:58] it should be there,m and be shown, so people can repair it [09:58:43] in cases where we don't want to allow that (e.g. snaks created from bot input), we can still fail when such a snak is present (there's a patch for this on gerrit already) [09:59:22] i fully agree with that, but i am unsure that the same behaviour can not be done with an exception that is caught and handled at the appropriate moment [09:59:45] but as said, I am not sure this needs to be discussed with me, but rather with jeroen later [10:01:06] Denny_WMDE: fyi: http://www.wikidata.org/wiki/Wikidata:Project_chat#minimizing_Item.27s_UI [10:01:14] * Lydia_WMDE waves from train back to berlin [10:01:27] will be back in the office tomorrow [10:06:38] Denny_WMDE: i don't see any way to do this with an exception [10:06:47] the info has to be in the structure somehow [10:09:02] since it has to be handed over from the backend to the frontend, and an exception couldn't do that? [10:12:04] Henning_WMDE: maybe you want to take a look at http://www.wikidata.org/wiki/Wikidata:Project_chat#minimizing_Item.27s_UI [10:16:14] New patchset: Se4598; "Add separate messages for wikibase-deletedentity" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69874 [10:20:00] New review: Se4598; "Taken your feedback into account." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69874 [10:29:08] New patchset: Tobias Gritschacher; "Fix client's add-link-widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70134 [10:48:38] New patchset: Daniel Kinzler; "(bug 46867) trim bad utf-8 sequences before normalizing." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70139 [10:50:04] New patchset: Daniel Kinzler; "(bug 46867) skip bad search keys and report them." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70140 [10:53:55] New patchset: Daniel Kinzler; "(bug 46867) trim bad utf-8 sequences before normalizing." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70139 [10:54:52] New patchset: Daniel Kinzler; "(bug 46867) skip bad search keys and report them." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70140 [11:02:32] New patchset: Tobias Gritschacher; "Fixed Special:SetSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70141 [11:04:18] New patchset: Tobias Gritschacher; "Fixed Special:SetSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70141 [11:04:45] New patchset: Daniel Kinzler; "(bug 49832) i18n for input validation." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69844 [11:29:50] DanielK_WMDE, Denny_WMDE1: I've created a page about how Wikidata may support Wikisource: https://www.wikidata.org/wiki/Wikidata:Wikisource What do you think about it? [11:33:49] New patchset: Henning Snater; "Removed obsolete JavaScript globe coordinate parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69112 [11:34:17] New patchset: Henning Snater; "Enhanced input string splitting in GeoCoordinate parsers" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69630 [11:34:29] Tpt_: thanks for writing it! i will keep it on my to read list. Would you mind to remind me if I don't answer by the end of the week? [11:34:55] Denny_WMDE1: Thanks :-) Ok. [11:40:18] Tpt_: one request, if possible — could we move the discussion to the discussion page and have the content page reflect the current state of the proposal in a concise way? [11:40:41] Denny_WMDE1: Yes, of course.I'll do it. [11:40:49] some of the previous proposals for wiktionary had the big issue that due to the discussion being interspersed, it was basically impossible to figure out the actual proposal [11:42:45] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70141 [11:45:51] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69049 [11:45:54] hello Denny_WMDE1 [11:49:40] liangent: hi! [11:49:45] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69637 [11:49:58] i have 10 minutes exclusively for you right now if you want, liangent :) [11:50:19] Denny_WMDE1: review that patch [11:50:32] especially the naming issue [11:50:34] aye [11:50:48] lots of followup stuff will use that name [11:51:00] this one? https://gerrit.wikimedia.org/r/#/c/67453/ [11:51:44] yeah [11:52:15] New patchset: Tobias Gritschacher; "ajax_wait needs to sleep" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70143 [11:52:27] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70143 [11:54:44] LanguageWrapper does not only represent a language [11:54:51] it also offers translation services, right? [11:55:49] Denny_WMDE1: right [11:56:20] do you have alternative names for this class? [11:57:03] ExtendedLanguage the first name occurring to me [11:57:31] btw class Language also has a bunch of method related to translation [11:57:42] New patchset: Tobias Gritschacher; "make selenium statements_basic tests really basic" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70144 [11:57:49] most of them are simply mapped to corresponding LanguageConverter methods [11:57:57] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70144 [11:58:30] shouldn't that all be part of Language anyway? [11:59:08] Denny_WMDE1: what all? [11:59:24] what's in LanguageWrapper? [12:00:10] it's for some abstraction between two types of fallbacks [12:01:15] so would LanguageWithFallback be more appropriate? or an actual subclass of Language that can deal with this fallback, but otherwise acts exactly like Language? [12:02:31] liangent: I am really sorry, i have to go for now. I will try to be online later, and will check the patch again. for now, you will find a few comments. please regard them as suggestions - in general it looks good [12:03:06] I also thought about LanguageWithFallback but it seems too long [12:03:27] rather long and descriptive than ambiguous and short [12:03:31] and I don't really see (many) classes named in this style [12:04:08] sorry, i have to go off [12:04:12] hello [12:04:14] see you later [12:07:15] New patchset: Henning Snater; "Delaying GlobeCoordinate input expert's API request" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69638 [12:07:44] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69048 [12:08:22] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69827 [12:09:19] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69854 [12:19:40] New patchset: Henning Snater; "Fixes jslint and doxygen errors introduced in Ie12d526 and I57a6ad9" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70147 [12:35:34] New review: Henning Snater; "Good work." [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/69874 [12:35:35] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69874 [12:37:13] New patchset: Tobias Gritschacher; "Improvements to Selenium coordinate tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70150 [12:39:10] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69112 [12:39:23] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69630 [12:41:04] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69638 [12:42:18] Change merged: Tobias Gritschacher; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/70147 [12:42:20] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70134 [12:46:35] New patchset: Daniel Kinzler; "Fix client tests to pass on repo." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70154 [12:47:13] Tobi_WMDE; ---^ [12:47:45] hashar: since we adjusted our JS code, to pass the lint and jslint jobs, could we have these jobs voting on our Wikibase & DataValues repository please? [12:48:09] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70150 [12:50:51] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70131 [12:51:17] DanielK_WMDE: seems it's still broken, or do I miss something? https://integration.wikimedia.org/ci/job/mwext-Wikibase-testextensions-master/2532/console [12:52:05] off for lunch [12:54:18] Tobi_WMDE: yes :-] [12:59:55] Tobi_WMDE: done :-] [13:00:03] https://gerrit.wikimedia.org/r/#/c/70156/ [13:13:47] Tobi_WMDE: i can't reproduce this locally, but i'll have a look [13:16:00] Tobi_WMDE: i think it'S getting the settings right. i'm now working on sensible defaults that work when client and repo are on the same wiki [13:26:33] hashar: thx! [13:30:30] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69848 [13:30:43] New patchset: Tobias Gritschacher; "(bug 49832) i18n for input validation." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69844 [13:47:05] New patchset: Daniel Kinzler; "Fix client tests to pass on repo." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70154 [13:48:35] New patchset: Daniel Kinzler; "Force some client settings if repo is same wiki." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70163 [13:51:20] New patchset: Daniel Kinzler; "Remove hacks from jenkins entry point." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70164 [13:54:51] hashar: any idea why this fails? https://gerrit.wikimedia.org/r/#/c/70164/1 [13:55:02] DB connection error: Unknown error () [13:55:09] ^--- not very helpful :) [13:55:39] hashar: i'm trying to allow repo+client tests to be run on the same instance. the commit removes the evil hacks from the entry points. [13:55:58] obviously, i missed some details... but i don't see what that would be. [13:56:19] Tobi_WMDE: do you have an idea? [13:58:05] hm... [13:58:10] looking [13:58:11] i suppose i should test with sqlite [13:58:20] * DanielK_WMDE goes to do that [13:58:35] oh yeah we are using sqlite :( [13:58:50] I still haven't found out the time to write a wrapper to install a database using mysql [13:58:54] hashar: an idea: for LBFactory, the dbname is set to false to mean "default". maybe that doesn't go well with sqlite... [13:58:54] DanielK_WMDE: must take a look [13:58:57] and to trigger integration tests against both sqlite and mysql [13:59:34] hashar: would be great if you could dig up more details about that error. what database did it try to connect to, and where and when? [14:00:02] I guess to ''.sqlite [14:00:36] well, it *should* be using the default from wgDBName or whatever... but it doesn't. [14:00:40] can reproduce it locally [14:00:56] i actually suspect a bug with LBFactory and SQLite... [14:00:59] I'll dig. [14:01:06] or in LoadBalancer [14:04:55] right [14:17:50] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69844 [14:43:52] New patchset: Tobias Gritschacher; "(bug 49105) Add toolbox link and js config var for connected wikibase item" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66908 [14:44:33] New review: Tobias Gritschacher; "PS 5: added selenium tests." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66908 [14:46:09] New review: Jeroen De Dauw; "I'm rather wary of this change - it is not clear to me at all that this is the right approach to tak..." [mediawiki/extensions/WikibaseDataModel] (master) C: -1; - https://gerrit.wikimedia.org/r/68952 [14:46:17] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/66908 [14:53:12] Tobi_WMDE: easy review is easy: https://gerrit.wikimedia.org/r/#/c/68652/ [14:57:54] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68002 [14:58:19] New review: Jeroen De Dauw; "No tests for the new behaviour?" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68002 [15:02:11] Change merged: jenkins-bot; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/68652 [15:13:41] New patchset: Daniel Kinzler; "Force some client settings if repo is same wiki." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70163 [15:14:30] New patchset: Daniel Kinzler; "Remove hacks from jenkins entry point." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70164 [15:15:11] New patchset: Daniel Kinzler; "Remove hacks from jenkins entry point." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70164 [15:22:41] JeroenDeDauw: look, no fail! https://gerrit.wikimedia.org/r/#/c/70164/3 [15:26:28] JeroenDeDauw: btw, i send a mail about the PropertyBadValueSnak stuff to wikidata-tech a week ago or so, got no replies. [15:26:43] DanielK_WMDE: I noticed, just replying niow [15:27:48] ok. [15:27:57] i understand your concerns, but i don't really see an alternative [15:28:46] JeroenDeDauw: could you have a look at some of the other stuff i have in the queue? like https://gerrit.wikimedia.org/r/#/c/69847/ and https://gerrit.wikimedia.org/r/#/c/69845/ [15:28:55] or somethign really quick: https://gerrit.wikimedia.org/r/#/c/69846/ [15:29:04] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70164 [15:29:14] DanielK_WMDE: AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA [15:29:28] DanielK_WMDE: re jenkins: awesome! [15:29:40] :P [15:29:48] \o/ [15:29:54] | [15:29:59] \\ [15:33:16] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70164 [15:38:09] DanielK_WMDE: in spy state USA, inbox has a new you [15:40:41] Which tables do I have to dump/load for a backup of the data in Wikibase? [15:43:13] JeroenDeDauw: thanks. I'll reply tomorrow. are you in the office tomorrow? [15:44:25] Granjow: the primary data is stored as wiki pages, so the dumpBackup script should work. Note however that I have not tried re-importing them. There might be some issues there. [15:45:15] But in any case, if you make such a dump, you will have all data as JSON wrapped in XML. Even if the direct re-import doesn't work smoothly, it should be easy enough to dig the data out. [15:46:48] DanielK_WMDE: Ok. I'd just need it for development, so that in case something fails I can restore the previous version. Is it portable, i.e. can I load the backup on a different machine as well? [15:51:09] the XML dumps are fairly robust and should also work across mediawiki versions [15:52:02] Granjow: for development and quick recovery, i'd use an operational backup - that is, use mysqldump for the entire database [15:55:43] DanielK_WMDE: I'm in the office again on Tuesday next week [15:55:49] Or Monday [15:57:32] DanielK_WMDE: Will do that. The amount of data is not quite as huge as I thought :) [15:57:47] New review: Jeroen De Dauw; "Some serious copy-pasting going on here with splitString. This could be made parametric and put into..." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69630 [16:06:33] Granjow: bzip is your friend [16:10:10] DanielK_WMDE: only 50 % ;) [16:10:25] thanks for the help and good evening! [16:10:32] New review: Daniel Kinzler; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69689 [16:19:10] what api query is to add property and to check if it already added? [16:27:29] Change on 12mediawiki a page Extension:WikibaseLib was modified, changed by 90.218.233.141 link https://www.mediawiki.org/w/index.php?diff=716277 edit summary: [+29] [16:27:42] Base-w: you mean add a statement to an item? or create a new property? [16:44:17] DanielK_WMDE: to item [16:44:50] in xml format [17:04:44] [17:04:44] omg [17:04:55] since when? [17:05:27] hm [17:05:33] but it was posted.... [17:14:50] aude: Hello [17:22:20] why i cant log in to wd but can login elsewhere via the same piece of code? [17:24:31] ah all right [17:59:45] pragunbhutani: hello [18:02:34] hello liangent! [18:05:24] [18:05:25] what to do with it? [18:05:38] http://www.wikidata.org/w/api.php?maxlag=5600&format=xml&action=wbcreateclaim&bot=&entity=Q4099050&property=p107&snaktype=value&token=foo&value="Q618123" [18:05:50] how is right [18:05:51] ? [18:06:05] addshore, i think you know the answer [18:07:07] Base-w: value={"entity-type":"item","numeric-id":618123} [18:07:27] if value includes a letter, it's not going to be an integer [18:07:59] ah [18:08:07] thanks [18:11:16] As an anti-spam measure, you are limited from performing this action too many times in a short space of time, and you have exceeded this limit. Please try again in a few minutes [18:11:16] lol [18:11:22] ok [18:11:34] i'll find rfp page [18:16:44] ah but its less than 50 [18:31:05] well, you may disscuss it here http://www.wikidata.org/wiki/Wikidata:Requests_for_permissions/Bot#BaseBot :) [18:34:06] hi pragunbhutani [19:19:39] aude: hi! sorry, was afk [19:20:05] I was hacking around a little today and I did a git pull on all my repos [19:20:11] I've been stuck with a weird error since [19:20:25] Fatal error: Class 'Wikibase\EntityId' not found in /Users/pragunbhutani/Desktop/Dev/mw/extensions/Wikibase/lib/WikibaseLib.php on line 164 [19:20:29] yes [19:20:48] we split out some components into separate extensions / git repos [19:21:06] you need to clone WikibaseDataModel [19:21:47] ah okay, and install it like any other extension? [19:22:04] yes [19:22:20] i think it automatically gets included if you have WikibaseLib [19:22:23] * aude not 100% sure [19:22:29] I'll check [19:22:36] I created an account on labs as well [19:22:44] https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FWikibaseDataModel [19:22:44] ok [19:22:44] will request shell access shortly [19:22:50] we'll need to add you to the wikidata project [19:22:57] and I'm pretty close to making my first mobile skin, been working on that as well today [19:23:01] cool :) [19:23:30] :) [19:23:32] https://git.wikimedia.org/repositories/ [19:23:34] and this is slightly off-topic, but do you know anything about TU Darmstadt? [19:23:50] if you look there, we have a few other wikibase git repos (Query and Query Engine) [19:24:00] you don't need them yet but probably worth having htem [19:24:13] and mediawiki/extensions/WikibaseDatabase [19:24:27] and solr yeah [19:24:31] pragunbhutani: Aude isn't from Germany, so she probably doesn't, as that is to far off from Berlin [19:24:37] solr we don't need [19:24:44] oh so everything is being split up into separate extensions? [19:24:48] hoo is right :) [19:24:57] hoo: how about you then? :) [19:24:59] pretty much [19:25:05] not yet for the stuff in DataValues [19:25:23] awesome [19:25:35] I'll clone that repo and then test the Skin hacks I made today [19:25:45] ok [19:25:47] pragunbhutani: I don't either... although I've already been there/ near to it several time [19:25:48] s [19:25:58] data model is the only essential one at this point [19:26:56] aude: ah yes, that fixed it! [19:27:12] good [19:27:39] btw, i am on the bus with unreliable wifi [19:27:47] no problem [19:28:01] with this fixed, I'm back to working on the mobile skin for a while [19:28:03] if i disappear, it's not intended to be rude:) [19:28:13] gotcha :) [19:28:17] ok [19:28:30] i am back in the office either wednesday afternoon or thursdya [19:28:42] oh awesome [19:28:52] I intend to have something ready to show by then [19:29:02] a basic mobile skin [19:29:17] :) [19:29:17] yay! [19:29:44] aude: People keep complaining about the linkItem widget and IE9/8... they want it to work or a workaround [19:30:00] hmmmm [19:30:08] There's a way to make CORS with $.ajax work in IE9/8 but that's really hacky and probably unstable [19:30:42] I don't really want to do it, as that might introduce a bunch of new bugs (with encoding or so) [19:31:04] IE8/9 is something particular i'm not suited to work on [19:31:09] since i'm working on mac [19:31:34] if they have a degraded but working experience, maybe it's better [19:31:38] I'm working on Fedora mostly... got a Windows VM for these kind of things [19:31:44] or at least restore the link to the repo [19:31:55] can see if i can get a vm [19:32:06] * aude not sure how it works [19:32:08] Yeah... we could do that using the new JS config vars probably [19:32:33] sure [19:32:36] Haven't yet done that on Mac, but if you have Windows license it's trivial [19:32:46] i'm sure the office could get one [19:33:03] it's important to try to support IE best as possible [19:33:11] henning knows about that :) [19:33:18] Probably ... Silke will support that :D [19:33:23] heh [19:35:39] aude: how is IE generally broken? [19:36:03] liangent: We're talking about client things [19:36:04] liangent in the link item widget int he client [19:36:21] and henning has had trouble making aspects of the repo ui (js ) work [19:36:31] spent a lot of time on it] [19:36:45] Yes... there are ugly workarounds in the code for IE :/ [19:37:17] different JS api, or page rendering .. or what? [19:37:34] i really dont knoow [19:37:36] know [19:38:05] liangent: One problem is about cloned object and instanceof [19:38:17] ah yes [19:38:43] * was about cloned objects [19:38:47] oh even different js syntax/interpretation? [19:39:12] that sounds nasty... [19:39:29] liangent: No... these are very subtle differences, but if you got a code base with this much code you can be sure to hit such minor bugs [19:39:53] and sadly often everything breaks then [19:41:36] btw https://www.mediawiki.org/wiki/Compatibility#Browser has been marked historical but no new version show up? [19:43:31] liangent: Probably that was done as the version numbers change to often these days [19:44:42] We (at least I), didn't really follow that... it's more often a fully broken vs. fully working decision rather than a "how much do we want to support" one (in Wikibase, as all our editing is done via JS) [19:45:30] Base-w: lol, /me looks [19:48:08] hoo: well let Grade A = editing and Grade B = viewing [19:48:12] Base-w: I left a comment [19:53:53] legoktm: well, if you say me how to do it i'll do :) [19:54:03] Base-w: what framework are you using? [19:54:07] Wiki.java [19:54:18] i add functions [19:54:25] say query [19:54:37] ah ok [19:54:37] so [19:54:52] https://www.wikidata.org/w/api.php look for "wbsetreference" [19:56:20] New patchset: Hoo man; "Drastically reduce the number of RL modules in clients" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70115 [19:57:04] New review: Hoo man; "Addressed Krinkle's comments, fixed a qunit test dependency." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/70115 [19:59:05] legoktm: so it's a separate query? [19:59:14] yes [19:59:17] you add the claim [19:59:23] then add the reference [20:00:09] aude: Did you see https://gerrit.wikimedia.org/r/70115 ... Krinkle complained about that [20:01:50] hoo: last i looked he had only minor comments [20:02:16] if henning is around he should review and approve [20:02:26] Yes, I just fixed them... that's not really a bad thing for the client I presume.... we can't use most of them anyway [20:03:09] * aude been raging about too much js in the clients [20:03:12] so happy to see this [20:03:33] widget does not neet to know about the entire data model, etc. [20:03:40] :D Yes, it shouldn't be a problem, as we really don't need them and can move them again, if we need them [20:03:47] sure [20:04:06] Yes, it doesn't... took me some refactoring afford to get these awry dependencies resolved [20:05:59] alright, wifi is unbearably slow [20:06:25] aude: Where are you atm? Probably still enough for IRC [20:07:46] i will be in nyc later and then back to berlin [20:08:04] wifi, really too slow for irc at the moment [20:08:15] oO [20:08:37] * aude back later or tomorrow [20:08:48] :) [20:09:02] Hope you have a nice time in NYC [20:09:10] k [20:09:34] it's hot! and stormy [20:09:38] legoktm: GUID for the statement= GUID for claim? [20:09:53] Over here it's neither [20:10:06] good [20:11:48] New patchset: Jeroen De Dauw; "Do not allow PHP 5.5 failures anymore" [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/70310 [20:12:38] New review: Hoo man; "trivial one" [mediawiki/extensions/WikibaseDatabase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/70310 [20:12:39] Change merged: Jeroen De Dauw; [mediawiki/extensions/WikibaseDatabase] (master) - https://gerrit.wikimedia.org/r/70310 [20:12:45] :D [20:19:56] oups [20:26:14] Base-w: yes i think [20:33:04] legoktm: are last edits ok? [20:33:10] * legoktm looks [20:34:21] New patchset: Jeroen De Dauw; "Work on unserialization [DO NOT MERGE]" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/54024 [20:34:34] Change abandoned: Jeroen De Dauw; "(no reason)" [mediawiki/extensions/Ask] (master) - https://gerrit.wikimedia.org/r/54024 [20:34:43] Base-w: so on https://www.wikidata.org/wiki/Q12092493, you want to add the source to both claims [20:35:54] legoktm: thats wery last - seems that i killed bot before it added it [20:36:06] *very [20:36:41] ah ok [20:37:17] looks good to me then, ill wait a day before approving it, because the last time i went quickly bad things happened :/ [20:37:37] what things? [20:37:53] https://www.wikidata.org/wiki/Wikidata:Requests_for_permissions/Bot/Dexbot_3 [20:39:05]