[06:35:21] https://bugzilla.wikimedia.org/show_bug.cgi?id=49859 [06:35:44] i think thats pretty interesting [06:36:55] actually I think that's good functionality [07:52:01] New patchset: Henning Snater; "Prevent callback via listrotator's selected event in input experts" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/68677 [07:52:01] New patchset: Henning Snater; "Switching from JS globe coordinate parser to back-end parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69048 [07:52:01] New patchset: Henning Snater; "Removed obsolete JavaScript globe coordinate parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69112 [07:52:02] New patchset: Henning Snater; "Enhanced input string splitting in GeoCoordinate parsers" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69630 [08:44:09] New patchset: Daniel Werner; "Introduction of $.wikibase.claimgrouplabelscroll" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69632 [08:52:51] Tobi_WMDE: could you have a look at https://gerrit.wikimedia.org/r/#/c/69294/ and its dependencies? [08:52:56] would be nice to have that in before it goes stale [08:53:17] this would allow us to greatly simplyfy the code used to load entities, in api modules and elesehwere [08:56:09] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69512 [08:58:07] [travis-ci] wikimedia/mediawiki-extensions-DataValues#108 (master - d2dae0c : jenkins-bot): The build was broken. [08:58:07] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/45cb30f49772...d2dae0cefe65 [08:58:07] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/8269225 [09:13:44] New patchset: Henning Snater; "Fixed initialization of site link tables" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69633 [09:19:57] New patchset: Henning Snater; "Fixed initialization of site link tables" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69633 [11:20:24] New patchset: Henning Snater; "Adjusted Selenium tests to GlobeCoordinate input expert's request delay" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69637 [11:21:07] New patchset: Henning Snater; "Delaying GlobeCoordinate input expert's API request" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69638 [11:21:38] New patchset: Henning Snater; "Adjusted Selenium tests to GlobeCoordinate input expert's request delay" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69637 [11:27:50] New patchset: Jeroen De Dauw; "Use the correct concaternation operator" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69640 [11:28:05] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69640 [11:29:31] [travis-ci] wikimedia/mediawiki-extensions-DataValues#109 (master - c5c208b : jeroendedauw): The build is still failing. [11:29:31] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/d2dae0cefe65...c5c208b3e0d9 [11:29:31] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/8272808 [11:33:38] New patchset: Jeroen De Dauw; "Use the correct concaternation operator" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69641 [11:35:58] New patchset: Nikerabbit; "Use the correct concatenation operator" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69641 [12:00:17] New patchset: Daniel Kinzler; "Use SnakConstructionService to wrap SnakFactory." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68963 [12:01:18] Lydia_WMDE: [12:01:25] Lydia_WMDE: https://www.youtube.com/watch?v=tCDFBiVBfNY [12:03:10] Lydia_WMDE: did the event start? [12:03:21] jeroen will do an intro to travisci there in 4 mins if you're interested [12:03:31] zeljkof: in 4 mins [12:04:13] Lydia_WMDE: thanks, I am watching the youtube stream, but there is just an editor and strange music at the moment :) [12:04:19] hehe [12:04:28] if that is music [12:04:32] lol [12:04:33] maybe air conditioning :) [12:08:13] starting any second now [12:09:35] Lydia_WMDE: I still only hear strange noise [12:09:41] I can see the screen just fine [12:09:46] New patchset: Daniel Kinzler; "Use SnakConstructionService to wrap SnakFactory." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68963 [12:09:52] ok, the voice started [12:10:15] ok now? [12:10:27] Lydia_WMDE: works fine now, thanks [12:11:12] JeroenDeDauw: you should be able to mute other people in the hangout [12:25:36] New patchset: Henning Snater; "Improved rounding of globe coordinates" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69644 [12:28:14] New patchset: Henning Snater; "Fixed globeCoordinate's decimalText()" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69645 [12:29:20] Is it possible, for example, to exclude l10n-bot from receiving notifications of build success/failure? [12:29:51] Nikerabbit: ok - will ask for you [12:31:33] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67251 [12:32:28] (well, failures would be okay for me if there are only few false positives) [12:32:29] selenium on travis: http://about.travis-ci.org/docs/user/gui-and-headless-browsers/ [12:50:28] New review: Daniel Kinzler; "some small issues and simplifications." [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/69633 [12:50:43] Lydia_WMDE: is the event over? [12:52:03] zeljkof: jep :) [12:52:08] hope it was useful for you [12:52:15] it was, thanks [12:52:19] great [12:57:22] New patchset: Henning Snater; "Fixed initialization of site link tables" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69633 [13:16:09] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69633 [13:16:25] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69641 [13:19:05] New patchset: Daniel Kinzler; "Revert "Basic tests for DataTypes\DataTypesModule"" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69647 [13:20:53] [travis-ci] wikimedia/mediawiki-extensions-DataValues#110 (master - 149f1a7 : jeroendedauw): The build is still failing. [13:20:53] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/c5c208b3e0d9...149f1a78d46d [13:20:53] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/8275535 [13:21:16] New patchset: Daniel Kinzler; "Revert "Basic tests for DataTypes\DataTypesModule"" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69647 [13:21:54] New review: Daniel Kinzler; "self-approving revert" [mediawiki/extensions/DataValues] (master) C: 2; - https://gerrit.wikimedia.org/r/69647 [13:22:08] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69647 [13:23:37] [travis-ci] wikimedia/mediawiki-extensions-DataValues#111 (master - aae69fd : Daniel Kinzler): The build was fixed. [13:23:37] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-DataValues/compare/149f1a78d46d...aae69fdf9fcc [13:23:37] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-DataValues/builds/8275787 [13:24:28] DanielK_WMDE: nitpicks: https://gerrit.wikimedia.org/r/#/c/67256/ [13:30:42] New patchset: Daniel Kinzler; "Add EntityRevision functionality" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67256 [13:31:06] Tobi_WMDE: --^ [13:31:12] New patchset: Daniel Kinzler; "EntityLookup::hasEntity for quick checks." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69294 [13:47:24] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67256 [13:47:35] New patchset: Tobias Gritschacher; "EntityLookup::hasEntity for quick checks." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69294 [13:51:25] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69294 [13:55:25] Denny_WMDE: please look on your user disc in wikidata. thanks. [13:56:34] New patchset: Daniel Kinzler; "Fix check for wrong version." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69649 [14:01:22] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69649 [14:07:11] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/69301/ [14:18:31] New patchset: Jeroen De Dauw; "Vraious fixes to DataTypesModulesTest" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69658 [14:18:32] Pyfisch: please put such stuff on the contact the dev team page :) more likely to get an answer [14:19:15] Lydia_WMDE: youself said me that I should ask Denny ;-/ [14:19:26] New patchset: Jeroen De Dauw; "Vraious fixes to DataTypesModulesTest" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69658 [14:19:30] Pyfisch: hmmm? [14:19:31] Pyfisch: thx for the ping. it would not be too hard [14:19:57] Pyfisch: i must have taken something ;-) [14:20:18] Lydia_WMDE: it is only the heat :-P [14:20:25] quite possibly [14:20:54] Pyfisch: answered there [14:21:08] New patchset: Daniel Kinzler; "(bug 49264) Handle corrupt data values gracefully." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68002 [14:23:02] meh havent been logged in [14:23:14] DanielK_WMDE: arrr! y u revert? I told you I had a fix :p https://gerrit.wikimedia.org/r/#/c/69658/ [14:23:23] It somehow rebased nicely though [14:23:34] So now its re-revert+fix :D [14:29:22] New patchset: Daniel Kinzler; "(bug 49264) SnakValidator fail for PropertyBadValueSnak." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69659 [14:35:02] JeroenDeDauw: as long ass it works now... [14:35:33] JeroenDeDauw: there's a serious problem with the SerializerFactory/EntitySerialers/EntitySerializerOptions [14:35:51] currently, the Lua modules is broken [14:35:58] and i'm not sure how this issue should best be resolved [14:39:04] DanielK_WMDE: did you just revert in DataValues or also wikibase? [14:39:19] DanielK_WMDE: better merge the actual fix now: https://gerrit.wikimedia.org/r/#/c/69658/ [14:41:02] DanielK_WMDE: re Lua broken: this is why the stuff should be in a seperate repo and should have tests [14:41:32] JeroenDeDauw: yes. but the entire logic around EntitySerializerOptions seems flawed. [14:41:44] see https://bugzilla.wikimedia.org/show_bug.cgi?id=49878 [14:42:14] DanielK_WMDE: re EntitySerializerOptions: I heard what you said about that. Agree. At least the logic is no longer pasted all over the API, but it still needs some improvements before it is nice [14:45:25] JeroenDeDauw: well, currently, it's fatally broken. [14:47:20] JeroenDeDauw: currently, SerializerFactory is fatally broken [14:48:13] JeroenDeDauw: why? DataTypes/tests/modules/DataTypesModuleTest.php [14:50:18] DanielK_WMDE: SerializerFactory: how so? In any case, using the canUse thing would be better here [14:53:22] Reedy: you there? just curious if https://bugzilla.wikimedia.org/show_bug.cgi?id=48506 has happened (re Call later) [14:54:59] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69658 [14:55:23] New patchset: Daniel Werner; "Switching from JS globe coordinate parser to back-end parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69048 [15:11:01] DanielK_WMDE: What's the name of the script, and where does it live? (ie path/to/script.php) [15:28:23] New patchset: Daniel Werner; "Switching from JS globe coordinate parser to back-end parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69048 [15:28:29] New patchset: Jeroen De Dauw; "Fix passing of serialization options in lua library" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69676 [15:29:59] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/69672/ [15:32:42] Reedy: "the script"? [15:33:01] "the solution is to run the rebuild entity per page script." [15:33:08] ah [15:33:34] Reedy: /extensions/Wikibase/repo/maintenance/rebuildEntityPerPage.php [15:33:50] * DanielK_WMDE hasn't looked at this script [15:33:57] * DanielK_WMDE trusts aude got it right [15:34:15] New patchset: Jeroen De Dauw; "Fix passing of serialization options in lua library." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69676 [15:34:16] reedy@terbium:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildEntityPerPage.php wikidatawiki [15:34:16] ...Update 'Wikibase\RebuildEntityPerPage' already logged as completed. [15:34:17] lol [15:34:20] * Reedy runs with --force [15:35:22] No output.. leaving it running in a screen session [15:37:14] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQuery#7 (master - c6811a3 : jeroendedauw): The build has errored. [15:37:14] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQuery/compare/1f116c37513d...c6811a3148ea [15:37:14] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/8280088 [15:37:58] New patchset: Daniel Werner; "Switching from JS globe coordinate parser to back-end parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69048 [15:40:54] New review: Daniel Kinzler; "NOTE: removing Jenkins from this, since it will always fail due to the fact that this change require..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68963 [15:41:52] New review: Daniel Kinzler; "NOTE: removing Jenkins from this, since it will always fail due to the fact that this change require..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68002 [15:42:42] New review: Daniel Kinzler; "NOTE: removing Jenkins from this, since it will always fail due to the fact that this change require..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69659 [15:43:19] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/69679/ [15:43:35] New patchset: Daniel Werner; "Switching from JS globe coordinate parser to back-end parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69048 [15:43:58] Change abandoned: Daniel Kinzler; "it's unclear whether i18n on this level is actually useful." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69526 [15:44:32] New patchset: Jeroen De Dauw; "Attempt to unfail jenkins" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69680 [15:46:22] New patchset: Daniel Kinzler; "(bug: 49878) Fix passing of serialization options in lua library." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69676 [15:47:22] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/68677 [15:47:43] New patchset: Jeroen De Dauw; "Attempt to unfail jenkins" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69680 [15:48:23] New patchset: Jeroen De Dauw; "Remove deletion of broken test as apparently is no longer there on Jenkins." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69680 [15:48:31] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/69680/ [15:48:35] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQueryEngine#52 (master - b73a3c5 : jeroendedauw): The build is still failing. [15:48:35] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQueryEngine/compare/f778ec34568f...b73a3c5014cc [15:48:35] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQueryEngine/builds/8280516 [15:49:24] JeroenDeDauw: coud you have another look at https://gerrit.wikimedia.org/r/#/c/68962/ and https://gerrit.wikimedia.org/r/#/c/68963/ ? [15:49:30] it removes a nasty dependency [15:49:57] ...and there's a nice opportunity for some bikeshedding there [15:50:27] (come up with a better name for "SnakConstructionService" that does not involve the terms "factory" or "builder") [15:50:32] Tobi_WMDE: https://gerrit.wikimedia.org/r/#/c/69681/ [15:51:30] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69680 [15:51:43] DanielK_WMDE: lets postfix everything with Service or Object [15:52:03] * David_Stevenson wonders if there is some serious issues going on right now [15:52:47] David_Stevenson: lots of little bugs in the development version [15:52:55] but i'm not aware of any issue with the live version [15:53:04] DanielK_WMDE: SnakConstructor is way better [15:53:05] http://www.wikidata.org/wiki/Q13417633 [15:53:17] existing properties and items are not showing up [15:53:21] we decided to push deployment of the next snapshort by a week because of the current bugginess of the master development branch [15:53:36] New patchset: Jeroen De Dauw; "Use SnakConstructionService to wrap SnakFactory." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68963 [15:53:38] JeroenDeDauw: Constructorator? [15:54:02] New patchset: Jeroen De Dauw; "Use SnakConstructionService to wrap SnakFactory" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68963 [15:54:02] uh... [15:54:03] Reedy: ---^ [15:54:06] Constructosaurus [15:54:18] Boa Constructor? [15:54:22] Reedy: did you tell the script to rebuild everything, or just the missing stuff? [15:54:27] ( i go in a corner and shut up) [15:54:28] New patchset: Jeroen De Dauw; "Use SnakConstructionService to wrap SnakFactory." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68963 [15:54:46] Reedy: i think the "rebuild all" mode works be blanking the table first. [15:54:52] hrm... [15:55:22] well I hope these bugs are solved soon, editors could start removing properties and items that exist but show up as deleted [15:55:26] I did everything [15:55:27] reedy@terbium:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildEntityPerPage.php wikidatawiki --force [15:55:27] Start rebuild... [15:55:27] Processed 100 pages up to 244. [15:55:27] DB connection error: No working slave server: Unknown error (10.64.16.153) [15:55:35] Reedy: how fast/slow is it going? looks like it's causing breakage [15:55:43] it died with that error [15:56:00] reedy@terbium:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildEntityPerPage.php wikidatawiki --force --only-missing [15:56:00] Start rebuild... [15:56:00] DB connection error: No working slave server: Unknown error (10.64.16.153) [15:56:00] reedy@terbium:~$ mwscript extensions/Wikibase/repo/maintenance/rebuildEntityPerPage.php wikidatawiki --force --only-missing [15:56:00] Start rebuild... [15:56:00] DB connection error: No working slave server: Unknown error (10.64.32.17) [15:56:02] Not happy [15:56:10] oh great. [15:56:18] Reedy: now the table is empty and the site is in a limbo state [15:56:21] New patchset: Jeroen De Dauw; "(bug: 49878) Fix passing of serialization options in lua library." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69676 [15:56:58] DanielK_WMDE: fail in https://gerrit.wikimedia.org/r/#/c/68963/ [15:57:59] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#221 (master - da23e30 : jeroendedauw): The build was broken. [15:57:59] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/af662b6ccd41...da23e30233c5 [15:57:59] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8280705 [15:58:14] Reedy: if the script is broken, restoring that tyble from backup may be an option [15:58:22] Reedy: that would at least be less broken than the current situation [15:58:53] JeroenDeDauw: fail what where? [15:59:23] JeroenDeDauw: ignore jenkins. this is a cross repo patch. like most of my patches now are, since Datamodel was moved out of the main repo [15:59:31] i'm getting the feeling that this was a mistake [15:59:47] it makes jenkins useless [15:59:53] DanielK_WMDE: what still needs to be merged then? [16:00:00] The stuff in DataModel got merged already [16:00:35] ah. hm, then jenkins should work [16:00:35] let me double-check [16:00:39] but the cross repo stuff is a real issue :/ [16:01:31] wtf? i fixed that error! [16:02:52] I'm guessing stuff showing up as deleted in http://www.wikidata.org/wiki/Q142035 is a temporary error? [16:03:00] reosarevok: yes [16:03:06] Ok, thanks :) [16:04:59] New patchset: Daniel Kinzler; "Use SnakConstructionService to wrap SnakFactory." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68963 [16:05:02] JeroenDeDauw: ---^ [16:05:17] JeroenDeDauw: i fixed that problem before, no idea why it happened here again [16:05:22] looks like a merge artifact to me [16:08:16] New patchset: Daniel Werner; "Removed obsolete JavaScript globe coordinate parser" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69112 [16:09:03] New patchset: Daniel Werner; "Enhanced input string splitting in GeoCoordinate parsers" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69630 [16:09:11] New patchset: Daniel Werner; "Delaying GlobeCoordinate input expert's API request" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69638 [16:09:25] added sitenotice letting them know there's technical difficulties right now [16:10:23] thanks David_Stevenson [16:20:25] New review: Daniel Werner; "(1 comment)" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/69638 [16:44:26] woah, that sitenotice is scary [16:44:30] * legoktm reads scrollback [16:44:50] sorry, I didn't mean it to be xD [16:45:01] was meant to grab attention [16:48:24] hmmmm, wtf? [16:48:56] so, we have to wait for the slaves to catch up and then rebuild the entire entity per page table??? [16:48:59] DanielK_WMDE: ^ [16:50:07] aude: apparently? [16:50:19] ugh [16:50:24] it will take a while then [16:50:35] aude: i don't know what went wrong, i only know that the table is now empty. [16:50:42] aude: well... i thought it would only do the missing ones per default? [16:50:45] the default is rebuild the *entire* table [16:50:49] --only-missing [16:50:50] >_< [16:51:02] aude: was that specified in the bug report? i didn't look [16:51:03] * aude repeatedly mentioned we need that [16:51:10] no idea [16:51:20] *sigh* [16:51:29] * aude should add big scary warnings if that option is not put [16:51:41] aude: it should just be the default [16:51:46] perhaps [16:53:19] aude: i can't even find it on bugzilla - do you have a link? [16:53:31] It's not completely empty [16:53:39] Processed 250 pages up to 98721. [16:53:44] yay, sync-dir finished [16:54:05] Reedy: good [16:56:34] Reedy: well, we have about what, 50 million pages? got an ETA for that? [16:56:56] 13.5 million [16:57:09] only items [16:57:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=48506 [16:57:30] Hi. Can you delete the wording Q6463931 plz ? https://www.wikidata.org/wiki/Q6463931 [16:59:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=48503 [16:59:14] apparently also [16:59:30] but no ticket with a concrete shell request [16:59:42] Superjuju10: please leave a request at [[WD:RFD]] [16:59:42] [8] 10https://www.wikidata.org/wiki/WD:RFD [16:59:49] legoktm: OK. Thank :) [16:59:51] that would be rather important to have [16:59:52] huh? [17:00:25] Localisation update is going to be broken for Wikibase.. [17:00:34] aude: there's no bug in the wikimedia product with "run this script with these paraters to fix that" [17:00:36] Warning: file_get_contents(/var/lib/l10nupdate/mediawiki/extensions/Wikibase/Database/Database.i18n.php): failed to open stream: No such file or directory in /a/common/php-1.22wmf7/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 263 [17:00:46] Warning: file_get_contents(/var/lib/l10nupdate/mediawiki/extensions/Wikibase/Query/WikibaseQuery.i18n.php): failed to open stream: No such file or directory in /a/common/php-1.22wmf7/extensions/LocalisationUpdate/LocalisationUpdate.class.php on line 263 [17:00:56] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/68963 [17:01:11] DanielK_WMDE: didn't think that's necessary to have yet another bug report [17:01:41] but concrete requests/instructions [17:01:48] gah [17:02:13] Reedy: LocalisationUpdate has these pathes hardcoded? [17:02:45] Reedy: who maintains that? Should we fix it? Can I merge there? [17:02:50] * aude knows next time i go on vacation, to do a shell bug report [17:02:53] JeroenDeDauw: ---^ [17:03:03] [travis-ci] wikimedia/mediawiki-extensions-WikibaseQueryEngine#54 (master - 972fc70 : jeroendedauw): The build was fixed. [17:03:03] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-WikibaseQueryEngine/compare/646f0c1e8a2f...972fc704a2c6 [17:03:03] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQueryEngine/builds/8282947 [17:03:05] I think it follows where they are in that branch version [17:03:29] Reedy: so, for wmf7 that should be fine [17:03:46] even for wmf8, since we are not deploying [17:03:53] Where is this i18n path defined? [17:04:00] isn't wmf7 using wmf6 code? [17:04:02] Now WikibaseQuery/WikibaseQuery.i18n.php [17:04:34] Reedy: the wmf7 and wmf8 deployments should use the wmf6 wikibase branch, yes [17:04:43] So it won't match for master [17:04:48] So no new message updates [17:04:57] i'm confused now [17:05:25] localisation update pulls messages from master of extensions [17:05:39] master of LocalisationUpdate should detect where the localization files are on the master branch of wikibase, right? [17:06:06] Not if you've moved them to seperate extensions [17:06:30] i'm still confused. but maybe i don't need to understand this [17:06:38] the question is: is there anything we can & should do now? [17:07:23] Reedy: these extensions are not currently used (which is why we have removed them from that repo) [17:07:31] [travis-ci] wikimedia/mediawiki-extensions-Wikibase#222 (master - 779cd70 : daniel): The build was fixed. [17:07:31] [travis-ci] Change view : https://github.com/wikimedia/mediawiki-extensions-Wikibase/compare/da23e30233c5...779cd70f59b3 [17:07:31] [travis-ci] Build details : http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/8283001 [17:07:35] so we don't care about missing messages [17:07:43] is there any other issue that needs to be fixed? [17:07:52] ...and... [17:08:00] what's the progress of the rebuild script? [17:08:32] Reedy: if it's slow, i'm still in favor of restoring from backup and then running it in --only-missing mode [17:08:43] Backup? [17:08:44] Reedy: stuff missing from that table means no language links on wikipedia [17:09:10] Reedy: well, i hoping there is a backup somewhere... [17:09:27] tbh, I've completely no idea [17:09:28] killing toolserver replication right away would have worked ;) [17:09:43] New patchset: Tobias Gritschacher; "Make use of serializers when generating result in the API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69317 [17:10:24] unfortunately entity per page is not in the dumps (yet) [17:10:39] items per page and terms is, and i thought entity per page would be added [17:10:45] maybe it *is* somewhere [17:10:52] New patchset: Jeroen De Dauw; "(bug: 49878) Fix passing of serialization options in lua library." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69676 [17:11:37] "EQIAD slave replication, LVM snapshots every 8 hours (have we tested restoring from one?)" [17:11:39] * aude sighs [17:11:56] hmmmm, interesting [17:13:51] DanielK_WMDE: I'm done with this except for the serialization of sitelinks, but I will do that in a follow-up. https://gerrit.wikimedia.org/r/#/c/69317 [17:14:14] Tobi_WMDE: ok, will have a look [17:14:26] doesn't have that high prio [17:16:57] aude: i think the rebuild script should never empty the table. in "all" mode it sahould iteratively replace the entries [17:17:10] alternatively, it should at least dump a backup somewhere. [17:18:02] DanielK_WMDE: And at minimum, the behaviour should be swapped [17:18:14] ie replace --missing-only with --rebuild-all or something [17:19:01] Reedy: got any idea how long it is going to take the way it is runnign now? [17:19:28] Reedy: hm, wait. are we despretate enough for a really really nasty hack? [17:19:33] Processed 250 pages up to 274113. [17:19:52] That's maybe 20 minutes or so of running [17:20:47] 1500 minutes are... roughly 24 hours [17:20:47] DanielK_WMDE: agree, though i didn't change that part of the script [17:20:49] that sucks [17:20:57] legoktm: done https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#Q6463931 :) [17:20:58] bye [17:20:59] i think all the rebuild scripts do that [17:21:38] Blah [17:21:41] Asher is at a conference [17:21:53] Reedy: the table can be constructed with a single db query. much faster than programatically, but making a lot of assumptions [17:22:08] and would probably have to be chunked to avoid messing with slaves anyway [17:22:19] and /me has only 1 hour left here [17:22:39] I'll email asher and see if it's worth trying to get it from the snapshots [17:23:19] wb_entity_per_page right? [17:25:00] Reedy: yes. [17:25:54] and here's the magic hack (don't try before consulting asher): [17:25:55] insert ignore into wb_entity_per_page ( epp_entity_id, epp_entity_type, epp_page_id ) [17:25:55] select substr( page_title, 1 ), 'item', page_id [17:25:55] from page where page_namespace = 0; [17:25:55] Reedy: ---^ [17:25:56] that *should* work [17:26:01] it's an *evil* hack [17:26:06] and it'll lock the table and block out the slaves. [17:26:20] but it's going to be a *lot* faster than the rebuild screipt [17:26:33] (which we'd still need to run for anythign we missed with that query, notably all properties) [17:27:55] I've just emailed asher for starters [17:27:59] batch-size can also be increased [17:28:14] Reedy: ...and that query is wrong [17:28:42] Reedy: needs to be substr( page_title, 2 ) [17:29:01] --batch-size 1000 (for example) [17:29:04] or larger [17:31:33] Reedy: working version (my need chunking based on page_id): insert ignore into wb_entity_per_page ( epp_entity_id, epp_entity_type, epp_page_id ) select substr( page_title, 2 ), 'item', page_id from page where page_namespace = 0; [17:34:18] I upped it to 250 [17:34:28] I'm not sure what the best speed/size ratio is [17:35:09] nobody is without trying [17:35:31] heh [17:42:50] Hmm [17:43:16] I wonder if it's worth creating a different version of that script... [17:43:21] So it can can do it backwards or something [17:43:33] New review: Daniel Kinzler; "Some nitpicks. Code looks fine in general." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/69317 [17:43:59] Reedy: what do you mean? [17:44:39] When I run large scripts over many wikis, I tend to do one over dbnames ASC and a second over dbnames DESC [17:44:46] so they then meet in the middle or so [17:45:01] so you've got 2 scripts doing the work, not just one [17:45:26] Though, this would require more code hacks [17:45:27] meh [17:46:04] makes sense if the scripts are bound by something other than writing to the database. otherwise, they'll just slow each other down. [17:46:16] in this case, they are probably mostly bound by loading from external storage, so yea [17:46:55] Reedy: i'm about to leave, unless you request an emergancy session - then i can add about 90 minutes. [17:47:10] i kind of like my one-query hack [17:47:12] New patchset: Aude; "set default for entity per page script to rebuild only missing" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69697 [17:47:20] give it a try if the script is too slow. [17:47:30] I'm just wondering what side effects that may bring [17:47:44] too late now, but https://gerrit.wikimedia.org/r/69697 to try and improve [17:48:18] Reedy: if you chunk it to do about 1000 ids at once, probably nothing too bad. though it should wait for slaves after each chunk. [17:49:24] the rebuild terms table also needs to be changed to have a rebuild all instead of only-missing option [17:49:40] * aude agrees 1000 would be fine [17:50:57] Over 0.5M now [17:50:58] DanielK_WMDE: are we still on wikibase version 0.4? [17:51:11] aude: for what it's worth, yea [17:51:11] do we never update it, even when splitting components out? [17:51:14] heh [17:51:21] that version number is meaningless, we should just use branch ids [17:51:24] anyway, i'm off [17:51:26] ok [17:51:31] and i don't have a decent phone [17:51:36] call me if there's anything urgent. [17:51:47] (not that i can do much when sitting on the train) [17:51:47] * aude will be off to eat and exercise soon, but around some also [17:52:15] * aude going to the park to enjoy the nice cool weather [17:55:44] New patchset: Aude; "set default for entity per page script to rebuild only missing" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69697 [18:06:33] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: 2; - https://gerrit.wikimedia.org/r/69697 [18:06:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/69697 [18:43:25] Hey, any staffers here? [18:44:01] Lydia_WMDE: [18:44:22] Sven_Manguard: they all disappeared like an hour ago [18:44:25] Sven_Manguard: hey [18:44:28] wasup? [18:44:48] Lydia_WMDE: I'm getting a page where a lot of properties that aren't deleted are showing up as being deleted [18:44:54] legoktm: heh yeah because it is late and they left the office ;-) [18:44:55] Sven_Manguard: did you miss the sitenotice? [18:44:56] at home now [18:44:56] https://www.wikidata.org/wiki/Q523604 [18:45:03] what sitenotice? [18:45:08] Sven_Manguard: see sitenotice and project chat [18:45:12] https://www.wikidata.org/wiki/MediaWiki:Sitenotice [18:46:02]