[06:28:28] Hi? [08:17:34] New patchset: Daniel Kinzler; "Introduce IllegalValueException" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67812 [08:17:34] New patchset: Daniel Kinzler; "Fix exception checking in test cases" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67813 [08:33:40] New patchset: Daniel Kinzler; "(bug 49264, bug 48965) validate time format." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67816 [08:59:34] DanielK_WMDE: daily? [09:21:30] Lydia_WMDE: https://git.wikimedia.org/log/mediawiki%2Fextensions%2FWikibase/refs%2Fheads%2Fmw1.22-wmf6 [09:21:37] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=43870 [09:21:52] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=45244 [09:34:07] Nice ... some of the statistics of http://pt.wikipedia.org/wiki/Arantxa_Rus are now up to date for all languages available... thanks to wikidata ... [09:42:55] edoderoo: \o/ [09:44:09] only on :nl there was a discussion last week... as according to some people *this* was not what wikidata was meant for ... [09:44:26] but to my idea this weekly changing data makes way more sense than a birth date that is fixed for eternity [09:53:45] edoderoo: eh why do they say this isn't what wikidata is meant for? [10:02:47] something silly about _no codes in an infobox as no one knows how to edit/update data_ ... [11:34:32] New review: Daniel Kinzler; "needs rebase?" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/67303 [11:40:46] New review: Daniel Kinzler; "what now, geocoordinate or globecooredinate? I'm confused about what is sued where, and what got ren..." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67072 [11:53:07] New patchset: Siebrand; "Special page for entities without description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [11:55:06] New review: Siebrand; "If the message keys changes are to be undone, I'd prefer that." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [12:15:26] New review: Daniel Kinzler; ""Alphabetic characters in vendor names, namespaces, and class names may be of any combination of low..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67099 [13:01:39] Abraham_WMDE, all: i'd like to see the presentation, please join the hangout :) [13:02:24] what presentation [13:02:28] nobody here [13:02:32] to present [13:03:38] * aude still waiting to learn how to play go :) [13:06:11] DanielK_WMDE: Jeroen just arrived [13:09:08] DanielK_WMDE: join the hangout again :) [13:11:53] DanielK_WMDE: we wait for you [13:13:20] Abraham_WMDE: now the entry is gone from the calendar and I don't have the link any more :) [13:16:44] New review: Siebrand; "L10n/i18n review done." [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/67432 [13:53:01] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67506 [14:07:52] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67432 [14:08:00] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67432 [14:11:28] New review: Jeroen De Dauw; "> I'm fine with upper case / CamelCase namespaces, but it's worth dicussing first, especially since ..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67099 [14:15:07] New patchset: Jeroen De Dauw; "Introduce IllegalValueException" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67812 [14:16:12] DanielK_WMDE: what is the retionale behind IllegalValueException? [14:17:02] * JeroenDeDauw kicks DanielK_WMDE [14:17:08] And everyone else in the Wikidata team [14:17:09] ahhhhh [14:17:15] to full review queue is to full [14:17:22] New patchset: Jeroen De Dauw; "Fix exception checking in test cases" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67813 [14:19:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67812 [14:19:38] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67813 [14:21:02] New patchset: Jeroen De Dauw; "(bug 49264, bug 48965) validate time format." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67816 [14:22:31] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67816 [14:29:19] New review: Jeroen De Dauw; "Needs rebase" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65768 [14:29:54] New patchset: Jeroen De Dauw; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [14:30:01] New review: Jeroen De Dauw; "No tests" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67453 [14:30:14] New patchset: Jeroen De Dauw; "Automatically register all Wikibase Client tests " [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67543 [14:32:00] Change merged: Ataherivand; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67542 [14:35:20] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67543 [14:39:02] Hey there! Any devs online? [14:39:42] I'm writing my Master thesis, which is an identification key for trees. The current version is (atm) here: http://ec2-54-226-230-101.compute-1.amazonaws.com/filter.php [14:40:05] All data can be edited, here: http://ec2-54-226-230-101.compute-1.amazonaws.com/editor.php [14:40:51] The structure is such that the program cannot only be used to identify trees, but also other plants, animals, etc. [14:41:14] New patchset: Jeroen De Dauw; "Automatically register all Wikibase Repo tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67541 [14:42:32] Now I would like to put this into a wiki to allow multiple users to work on it, have history, etc., and Wikidata, or the underlying software, could fit very well [14:49:28] Abraham_WMDE: now the NSA can see what I am coding! https://www.youtube.com/watch?v=4qNFOW1uxyY [14:50:01] JeroenDeDauw: :D [14:50:35] New patchset: Jeroen De Dauw; "Automatically register all Wikibase Repo tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67541 [14:51:55] Abraham_WMDE: so where are those merges? You want to make the led go blink! :P [14:52:23] ;) [14:53:28] Change merged: Ataherivand; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67536 [14:55:09] Change merged: Ataherivand; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67532 [14:56:52] Change merged: Ataherivand; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67500 [14:57:43] Change merged: jenkins-bot; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67155 [15:00:58] Change merged: Ataherivand; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67515 [15:04:27] The idea in [[Wikidata:Requests for comment/References and sources#Option: each edition as a different item]] was rejected by the majority of votes (5:2) but this option is now in the proposed guideline used. At the bottom of the page Snipre says that it is consensus of discussion. Should not the result of a RFC respect the descision of the majority?! [15:04:31] [1] 10https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/References_and_sources%23Option:_each_edition_as_a_different_item [15:36:46] New patchset: Jeroen De Dauw; "Implemented TimeInput expert default messages" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67404 [15:36:53] New patchset: Jeroen De Dauw; "Improved Time object's string representation" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67431 [15:37:29] aude: are you around? [15:38:43] or any dev? [15:38:46] *other [15:38:58] I have a question according Siebrand's comment at https://gerrit.wikimedia.org/r/#/c/67634/ [15:40:00] is it better not to rename the keys but have wrong keys instead? [15:40:21] New review: Jeroen De Dauw; "(1 comment)" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/67404 [15:57:47] benestar: what's the issue there? [15:59:09] Lydia_WMDE: hte old keys started with "wikibase-entitieswithoutlabel-..." [15:59:32] now they start with "wikibase-entitieswithoutpage-..." which fits better to the class name [15:59:49] ok [16:00:17] in general i'd listen to siebarand on all things language [16:00:42] ok, so I will rename the keys again [16:01:04] maybe you also wanna poke someone to review the change... ;) [16:01:19] hehe yeah [16:07:40] New patchset: Bene; "Special page for entities without description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [16:07:47] Lydia_WMDE: done :) [16:08:02] \o/ [16:08:14] https://www.wikidata.org/wiki/Wikidata:Requests_for_deletions/Bulk/6 is linked on https://www.wikidata.org/wiki/Q12912929 ... WTF ?? [16:09:55] New review: Bene; "@Siebrand: Message keys changes are undone." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [16:12:04] Are such requests for deletion acted upon ... and how does that work ?>? [16:12:37] GerardM: "Warning: May be used now." [16:13:27] Right .... I have been working hard to add occupations and I would positively want to remove a head from a rump when they are "used" [16:16:57] Can someone explain the rationale ? [16:30:54] hmmm ... it looks like many of the items that I created ended up on this list and still exist ... [16:41:50] New review: Aude; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/66129 [17:23:06] aude: ping [17:26:04] hi benestar [17:26:25] aude: would you like to review https://gerrit.wikimedia.org/r/#/c/67634/ ? [17:28:53] benestar: ok [17:29:09] the most obvious issue just from looking.... [17:29:23] aude: what do you think about Siebrand's comment? [17:29:32] * benestar listens to the issue [17:29:37] 1) i realized you only moved code to the base class, but the execute function is complicated and does a lot [17:29:43] can we split it up? [17:30:05] not code created by me, but of course [17:30:07] 2) we will need phpunit tests for these pages [17:30:10] i know [17:30:16] wtf is phpunit? [17:30:31] all the stuff in the /tests/phpunit folder [17:30:38] hu [17:30:52] can you explain or give me a documentation? [17:30:59] sure.... [17:34:22] It might just be me, but I think that https://www.wikidata.org/wiki/Wikidata:Requests_for_comment/References_and_sources might be the most important RfC of 2013 thus far [17:34:52] lot of spam on http://wikidata-test-repo.wikimedia.de/ ... if no one wants to clean it up, could someone give me admin rights there? Once I'm done I'll happily resign [17:35:50] or someone who has admin rights there could just do it, but y'all probably have more important things to do. :P [17:36:07] benestar: perhaps jeroen's new SimpleSiteLink class in DataModel is a good simple example [17:36:28] tests are in Wikibase/DataModel/tests/phpunit [17:36:39] aude: I will take a look, thanks [17:36:50] may I aks again If I have questions? [17:37:10] yes you can ask [17:37:15] aude, benestar, wouldn't #wikidata-technobabble be a better location for this? [17:37:15] :) [17:37:18] :P [17:37:24] heh [17:37:34] ... [17:37:36] :P [17:37:44] * aude see about tests for the SetSiteLink page [17:37:58] * Sven_Manguard tires and fails to understand aude and benestar [17:38:00] just so we can be more sure we don't break it when we change other parts of the code [17:38:05] :) [17:38:17] ok :) [17:38:55] aude: sometimes I think it is more work for you to explain me all the technologies than I can ever give back... [17:39:29] aude: benestar: http://search.dilbert.com/comic/Fleem [17:39:41] kind of bad that the without labels page has no tests [17:39:47] benestar: don't mind [17:39:54] ;) [17:46:29] New review: Liangent; "I'm adding some tests but they'll fail due to lack of Language::getParentLanguage() in core (mention..." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [17:47:28] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [17:49:22] PinkAmpersand: might be easier to just reset it? [17:49:35] i'll see that we get to that tomorrow if possible [17:49:41] Lydia_WMDE: cool :) [17:49:52] ok [17:50:05] PinkAmpersand: yes i can do that [17:50:06] that being said you can have admin there [17:50:08] btw, we passed 50M edits yesterday. i'm updating WD:NEWS in a second, once I can figure out how many other WM sites have ever done this [17:50:16] not that there is anything useful to do with it i guess :P [17:50:25] PinkAmpersand: nice! [17:50:32] Lydia_WMDE: nah, I forgot you clear the whole database so often. it's fine. i've got sysop on enough test sites as it is ;) [17:50:37] hehe [17:50:38] ok [17:50:49] although looks like it's just one spammer [17:51:16] aude: good idea to reset it anyway i think to get rid of some not so nice test stuff [17:51:23] like wrongly set up properties [17:52:03] * Lydia_WMDE goes to prepare some food - laters :) [17:52:38] New patchset: Liangent; "New LanguageWrapper class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67453 [17:54:55] aude: isn't there any constant value in the form array( 'item', 'property', 'query' ) ? [17:55:06] currently it is hardcoded in the special page class... :/ [17:56:30] New review: Daniel Kinzler; "Made redundant by I8cf39fd8f3" [mediawiki/extensions/Wikibase] (master) C: -2; - https://gerrit.wikimedia.org/r/65969 [17:56:56] PinkAmpersand: Lydia_WMDE cleaned up [17:57:04] thanks! :) [17:57:16] and disabled ip editing. you can use the test account [18:05:27] Change abandoned: Aude; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/65969 [18:13:07] benestar: i'm sure there is a better way but EntityFactory contains a typeMap [18:13:21] aude: already found it ;) [18:17:06] ok [18:17:39] thx aude [18:19:06] we have geocoordinates [18:19:10] and Special:SetSiteLink [18:19:25] aude: deployed? [18:19:31] yep [18:19:32] wohooooooo [18:19:35] :D [18:19:40] I <3 Special:SetSiteLink :) [18:19:45] my baby... xD [18:19:48] * aude too [18:19:53] now? [18:24:23] psst, no docs @ http://www.wikidata.org/wiki/Special:ListDatatypes [18:25:10] * aude rages [18:25:37] it's here http://www.wikidata.org/wiki/MediaWiki:Wikibase-listdatatypes-geo-coordinate-head [18:25:55] and here [18:25:56] http://www.wikidata.org/wiki/MediaWiki:Wikibase-listdatatypes-geo-coordinate-body [18:26:06] but we renamed geo-coordinate to "globe-coordinate" [18:26:44] aude: cool. you gonna fix that server-side, or want me to just transclude the messages for now? [18:27:13] i can ask Reedy .... [18:27:28] thanks :) [18:28:31] it seems broken in the deployment branch [18:30:26] nothing reedy can fix [18:31:13] aude: okay. so should I go ahead and set the wrong messages to {{int:}}s of the right ones? [18:31:14] [2] 04https://www.wikidata.org/wiki/Template:int: [18:33:03] there a location property? [18:33:30] New patchset: Aude; "Update i18n message to use globe-coordinate instead of geo-coordinate" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67851 [18:33:43] PinkAmpersand: for now, ok [18:34:16] rschen7754|away: there's the data type [18:34:28] * aude does not know if any location properties are created yet [18:34:47] aude: just created one [18:34:56] [[P:P625]] [18:34:57] [3] 10https://www.wikidata.org/wiki/P:P625 [18:35:54] nice [18:42:52] New patchset: Bene; "Special page for entities without description" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67634 [18:43:05] aude: wonna review again? [18:44:05] Tpt_: did you see the pull request on github? [18:44:14] my bot was running with the new code stable... ;) [18:52:55] aude: ping [18:56:35] geocoordinates are live! awesome [19:03:36] :) [19:05:22] New patchset: Daniel Werner; "(bug 38201) Fixed assumption of SiteLinksEditTool of single edit tool per page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67303 [19:07:35] New patchset: Daniel Werner; "(bug 38201) Display site-link group specific heading per SiteLinksEditTool in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67308 [19:07:38] New patchset: Daniel Werner; "(bug 38201) Added JS wikibase.getSitesOfGroup" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67393 [19:07:42] New patchset: Daniel Werner; "(bug 38201) Introduction of "allowedSites" option in SiteLinksEditTool" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67394 [19:07:46] New patchset: Daniel Werner; "Refactoring of SiteIdInterface test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67559 [19:07:52] New patchset: Daniel Werner; "less error prone jQuery.wikibase.siteselector matching character highlighting" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67560 [19:07:53] New patchset: Daniel Werner; "(bug 38201) Deprecated wb.Site functionality related to "global" site ID in JS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67561 [19:07:57] New patchset: Daniel Werner; "(bug 38201) working counters for multiple SiteLinksEditTool instances" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67572 [19:10:35] benestar: back [19:14:46] New patchset: Bene; "fixed edit link in ItemView class to Special:SetSitelink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67862 [19:15:16] aude: minor fix [19:15:59] could you review this and the other patch? [19:16:03] @ aude [19:17:07] aude: the minor fix should be merged very fast because the link to Special:SetSiteLink is broken when javascript disabled [19:17:55] benestar: it can be merged for the next deployment but not sure about backport [19:18:05] backport? [19:18:09] there's always stuff imperfect [19:18:38] backport = deploy now or soon [19:18:49] but not broken [19:18:52] broken, yes [19:19:07] aude: but it can be merged now but we can wait for next deployment?! [19:19:14] *and [19:19:35] probably :/ [19:19:50] * aude don't want to annoy ree-dy too much :) [19:19:58] ;) [19:20:39] anyway, need to eat [19:20:46] * aude back later [19:21:15] k [19:21:28] bon appetit [19:23:50] benestar: aude: see last comment on project chat saying it is possible to set sitelinks that already are in use in another item with the special page [19:23:52] is earth the only acceptable globe type right now? [19:23:55] that is pretty bad if true [19:24:17] i dont see an option to change it in the GUI [19:24:25] legoktm: the coordinates should also apply to others? [19:24:50] https://www.mediawiki.org/wiki/Extension:GeoData supports a ton more globes [19:25:19] and when looking at the API it says "globe": "http://www.wikidata.org/entity/Q2", which suggests you can use other globes. [19:25:40] ill just code in earth for now [19:25:48] ListDatatypes also says you can use other globes [19:26:12] Lydia_WMDE: I think there's a bug [19:26:19] from a quick look at the code... [19:26:38] benestar: easy to fix? [19:26:42] quite [19:26:46] * benestar hopes so [19:26:47] ok cool [19:26:58] i think this is important and would warant a backport [19:27:07] and hotfix [19:27:27] :) [19:41:02] aude: Thanks for the /core code review, btw :) [19:44:00] Lydia_WMDE: not sure I've fixed the problem [19:44:11] my localhost does not work strangely :( [19:44:30] benestar: ok - maybe hoo can test? [19:44:39] huh? [19:44:41] Link [19:45:02] hoo: not uploaded yet [19:45:20] benestar: Ok, feel free to add me as reviewer whenever you like [19:45:48] Can some one merge http://www.wikidata.org/wiki/Q3703136#sitelinks and http://www.wikidata.org/wiki/Q5799886#sitelinks ? [19:46:19] ugh this is confusing [19:46:24] in some places the datatype is "globe-coordinate" [19:46:32] and someplaces its "globecoordinate" [19:46:46] lego: I think the message messed up [19:46:56] Pink did something quick to fix the description [19:47:05] no, i mean from the API end [19:47:15] Not again [19:47:33] I think my fucking mediawiki version is too old... [19:47:57] benestar: You should always use master for testing/ developing Wikibase [19:48:03] I know... [19:48:13] but now there's no time to install a new version [19:48:55] if dtype == 'globe-coordinate': [19:48:55] dtype = 'globecoordinate' [19:48:58] * legoktm facepalms [19:49:13] benestar: You can also already push the change to gerrit and just note that it's untested in the commit summary [19:49:57] people do that from time to time, it's not especially nice to the reviewers of course, but it's ok ;) [19:49:59] legoktm: narf! that's bad indeed [19:50:07] New patchset: Bene; "hotfix: Special:SetSiteLink not set already used sitelinks (untested)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67862 [19:50:09] hoo: there's teh link [19:50:21] hoo: please test it for me... [19:50:34] legoktm: I'll poke people about it tomorrow [19:50:40] Lydia_WMDE: thanks :) [19:51:25] hoo: it is *very* hot... [19:51:34] heh [19:52:18] New review: Daniel Kinzler; "Well I guess it's easier to change the directories than the namespaces, so that's the way to go." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67099 [19:52:53] https://www.wikidata.org/w/index.php?title=Q4115189&diff=50127762&oldid=50125533 [19:52:55] :DD [19:54:40] New review: Hoo man; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67862 [19:56:25] New patchset: Daniel Werner; "Added tests for SiteLinksEditTool value row insertion behavior" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67870 [19:56:56] hoo: does it work? [19:57:03] besides the qxx messages... :P [19:57:16] benestar: Haven't yet tested :P [19:57:20] Change abandoned: Jeroen De Dauw; "blah, evil test needs to be fixed first" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67541 [19:57:26] legoktm: Check out http://tools.wmflabs.org/reasonator/?q=466868 now in the right channel [19:57:39] Am on something else atm, but I can do that tonight [19:57:51] multichill: :D [19:58:03] I was playing around with qualifiers, time and politicians so I asked Magnus if he could add it [19:58:12] hoo: but it is a kind of huge problem... :/ [19:58:18] isnt it Lydia_WMDE ? [19:58:31] jep :( [19:58:34] If it qualifies for a backport it's more urgent of course [19:58:36] Lydia_WMDE: ^? [19:58:42] it does imho [20:05:52] hoo: so? [20:06:20] benestar: Could you please remove the utf8 normalization (I doubt it makes sense) and add some qqq messages= [20:06:22] *? [20:07:00] please keep it minimal for a hotfix [20:07:12] and put cosmetic stuff in another commit for later [20:07:26] hoo: the normalizePageName? [20:07:35] This will require a i18n cache rebuild anyway [20:07:58] benestar: Sorry, I meant the Utils::trimToNFC call [20:08:09] ah, k [20:08:20] but it is used in api module, too... [20:08:42] gnah [20:08:49] Ok, it wont harm, either [20:09:35] New patchset: Bene; "hotfix: Special:SetSiteLink not set already used sitelinks (untested)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67862 [20:09:37] hoo: done now anyways [20:09:56] can you still set already existing sitelinks? [20:10:16] I wonder how you do a cold fix [20:10:27] :P [20:11:44] Reedy: Using liquid nitrogen, I guess ;) [20:12:28] I think it was the $siteObject->normalizePageName( $page ) thing [20:13:14] that one's doing an API request to the target wiki, to normalize/ validate the page name [20:13:18] pretty slow, of course [20:13:35] yeah, but I think it is the reason [20:13:43] in the example once it is "test" and once "Test" [20:15:53] hoo: any results? [20:17:12] benestar: Only pulling it now [20:17:16] super busy today :/ [20:17:22] ... :( [20:17:30] please ping me if there are any results [20:23:32] benestar: You got a merge conflict [20:23:42] I see [20:27:03] benestar: If you can't I can rebase that one for you [20:27:10] What exactly used to be broken= [20:27:48] Adding and editing a sitelinks works with the special page [20:28:05] But how do you remove one? [20:28:39] New patchset: Bene; "Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase into fixitemview" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67879 [20:28:48] damned [20:28:52] something got broken :( [20:29:02] hoo: rebase failed :(((( [20:29:03] benestar: I'll fix it for you, don't worry [20:29:07] thanks [20:29:31] hoo: look at project chat [20:29:35] Am I supposed to be able to remove a site link by leaving the input empty [20:29:38] ? [20:29:45] it is possible to add sitelinks which are already in use [20:29:53] this is the problem [20:30:31] sorry, have to go for a short time [20:30:31] "Site link [http://an.wikipedia.org/wiki/Oro Oro] already used by item [[Item:Q82]]." [20:30:33] [4] 04https://www.wikidata.org/wiki/Item:Q82 [20:30:34] be back soon [20:30:38] Sadly it's not parsed [20:30:40] wohoooooooooooooooooo [20:30:50] try wiht uppercase/lowercase [20:34:37] New review: Hoo man; "(1 comment)" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67862 [21:07:25] hoo|away: away... [21:07:38] benestar: I'm here [21:07:44] yey :) [21:07:48] hoo: did it work? [21:08:54] benestar: I've mentioned problems in the patch set [21:09:07] I see [21:09:21] hoo: but the main bug with the existing sitelinks is fixed? [21:09:40] benestar: Indeed [21:09:46] nice [21:10:29] so lets find this simple problem and then do a backport [21:11:59] hoo: can you find out from where the unparsed error message comes? [21:12:09] I cannot find the section in the code [21:12:44] hoo: and can you please make the rebase? [21:13:43] benestar: I'm on that... the Status class is weird here -.- [21:13:51] :( [21:13:59] I think I cannot fix it today.. [21:14:04] but the fix is so important [21:14:21] hoo: do you think we can take the small bug of not parsing hte error message? [21:15:19] If Lydia's fine with that, I think so [21:16:14] Lydia_WMDE: poke [21:16:21] are you fine with that? [21:16:38] hi benestar [21:16:50] hi aude [21:16:52] :) [21:17:24] aude: can you explain me what happened here: https://gerrit.wikimedia.org/r/#/c/67879/ ? [21:17:55] and can anybody please rebase this: https://gerrit.wikimedia.org/r/#/c/67862/ ? [21:18:28] where is the item view patch? [21:18:56] Fixed the message parsing thing... but I'm not sure, that my patch is actually sane [21:19:02] doesn't matter ;) [21:19:14] hoo: where was the bug? [21:19:17] From the security point of view [21:19:24] Editentity [21:19:29] :/ [21:19:42] hoo: line? [21:20:03] 920: function showStatus [21:20:31] benestar: i don't understand https://gerrit.wikimedia.org/r/#/c/67879/ :/ [21:20:38] aude: :'( [21:20:53] Change abandoned: Hoo man; "Mistake by author, no longer needed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67879 [21:21:04] hoo: thanks :) [21:21:12] you're the best ;) [21:21:38] I thought I am :( [21:21:50] benestar: aude: Let's ignore the unparsed messages for know and just get this merged and deployed? [21:22:02] Vogone: you're the best in wiki and hoo is the best at fixing my mistakes ;) [21:22:08] *in [21:22:13] ^^ [21:22:15] hoo: sure [21:22:46] If aude agrees I'm going to amend the patch and then she can push the button (as I lay my hands on it) [21:22:57] aude: do you? [21:23:35] hoo: let's see what we have [21:23:52] i'm not sure the ideal way of fixing the parsing but think i got a way [21:24:15] aude: Let's do that in a separate patch set please [21:24:26] New patchset: Aude; "Fix site link edit link in ItemView" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67887 [21:25:14] New review: Hoo man; "Redundant with Iaa3d0718efa34db08c770ca1eb768560ff0e37a0" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/67887 [21:25:48] hoo: ok [21:26:19] New patchset: Hoo man; "hotfix: Special:SetSiteLink not set already used sitelinks (untested)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/67862 [21:26:49] ok, that's where the item view thing went :) [21:27:09]