[00:01:38] woah weird i just had layout issues exactly at midnight UTC [00:03:04] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50715 [00:10:50] what is the new policy on creating items just so they can be used as references? [00:10:55] or properties [00:11:26] legoktm: hmm has the discussion been closed yet? [00:11:33] idk [00:11:35] i'm working on [00:11:43] getting my bot to add the "Imported from" property [00:13:53] right now i'm just gonna hardcode the ones that exist [00:28:07] New patchset: John Erling Blad; "(Bug 45013) Remove duplicate aliases" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49670 [00:29:17] New review: John Erling Blad; "Tests for later" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49670 [00:35:21] itwiki doesn't have a village pump??? https://www.wikidata.org/wiki/Q16503 [00:37:03] we do... [00:37:26] italiano it Wikipedia:Bar [00:37:33] legoktm: ^ [00:37:42] hm [00:37:44] thanks [00:39:17] oh wait [00:39:18] i misread [00:39:22] someone removed the dewiki link [00:39:23] >.< [00:39:37] ^^ [00:40:27] and their VP seems to be linked at https://www.wikidata.org/wiki/Q4026300 [00:40:51] ahhh :/ [00:56:28] Cool feature on enwiki - watchlist + RC shows edits from Wikidata (see your prefs) [00:57:31] except it's not on by default [00:58:01] well it isn't too relevant to those who don't edit Wikidata, right? [01:02:13] it's broken [01:02:25] :( /me found out as soon as he said that [01:23:12] remember how i was saying how i like recursion? well i currently have 1010 unread emails. or 10 in binary. and 10 is 2 in binary. and 2 is how many digits there are in binary. [01:23:50] PinkAmpersand: have you ever tried to draw a fractal tree? [01:24:04] no, but i like fractals :) [01:24:29] i've had some fun with Pascal's Triangle, too [01:24:55] * Jasper_Deng is currently sweating over trying to understand http://en.wikibooks.org/wiki/Calculus/Multivariable_calculus [01:26:04] PinkAmpersand: you'd like Pascal's Pyramid even better [01:26:12] ooooohhh [01:46:10] Jasper_Deng: mind updating [[MediaWiki:Gadget-markAdmins.js]] to move Vogone from GS to A? [01:46:11] 10[6] 10https://wikidata.org/wiki/MediaWiki:Gadget%2DmarkAdmins%2Ejs [01:47:27] PinkAmpersand: done.... although this implementation sucks IMO [01:47:41] * Jasper_Deng uses a better version that actually uses the API AFAIK [01:47:43] i don't like the hardcoded stuff [01:48:19] https://www.wikidata.org/wiki/User:Liangent/userhighlighter.js doesn't mark GS or stewards but is much cleaner and uses the real API [01:48:46] Jasper_Deng: is that global? [01:48:59] i'd support an adminbot that would update it (and would never use any other right than editprotected) [01:49:04] rschen7754: ? [01:49:14] PinkAmpersand: in its original version it updates itself [01:49:27] mmm [01:49:27] Jasper_Deng: if i took the code to my global.js on meta, would it work everywhere? [01:50:27] rschen7754: I haven't tried it but it looks like it would, since it has no reference to any specific URL [01:50:34] ok [01:51:52] aha it does [02:11:06] https://www.wikidata.org/wiki/Special:RecentChanges can someone please autopatrol the Bushranger and [上海市九 ? [02:12:55] both done [03:30:45] irccloud bugged out again? [03:31:00] not for me it didn't [03:31:04] it doesnt seem like nearly as many people were affecred as last time [03:31:11] but at least 3 were [03:31:18] since they all have "uid" userIDs [03:31:36] * Swob pings JD|cloud [03:31:42] [JD|cloud PING reply]: 0secs [03:31:49] success! [03:32:10] thanks a lot Swob [03:34:38] New patchset: John Erling Blad; "(Bug 45111) Fix the squashing of whitespace and control chars" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50365 [03:39:15] hm [03:39:18] someone said adminbot? [03:39:22] Pink|Oscars: [03:41:55] New patchset: John Erling Blad; "(Bug 45111) Fix the squashing of whitespace and control chars" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50365 [03:42:54] heh [03:42:56] not doing that [03:48:53] have you ever seen spelling correction red marks on a webpage? [03:49:05] yes [03:49:07] as if the webpage is warning you that it contains misspelled words ? [03:49:11] oh [03:49:11] even though it's not editable [03:49:12] no [03:53:46] http://www.brierleygroom.co.uk/ does for me [05:59:41] Pink|Oscars: ask on IRC [05:59:53] huh? [06:00:03] for your page protection [06:00:23] oh lol. for some reason felt like doing this one onwiki [06:00:46] try to avoid seeming IRCabalish for things that might be contested [06:00:49] :/ [06:00:52] i conflicted with jasper [06:00:59] legoktm: 2 weeks [06:01:03] ok [06:01:07] give me a sec [06:01:40] and you just got reverted again [06:02:01] heh [06:02:05] i prefer 1 week [06:02:08] but couldnt care less [06:03:17] lol Wikidata, the land of 1,000 inadvertent wheelwars [06:04:19] though they're not as frequent as reviewer wheelwars on En [06:04:30] since there's no obvious way to tell if someone's unaccepted a revision [06:05:31] * Jasper_Deng sincerely hopes the community won't get mad, create an arbcom, and desysop all three of us [06:05:58] * rschen7754 files an emergency desysop request at meta [06:06:10] haha [06:06:14] * legoktm blocks rschen7754 for "abuse" [06:06:21] * legoktm revdel's the log as well [06:06:43] * rschen7754 blocks legoktm for "abuse" on enwp [06:06:54] wait, where all the "potentially compromised account" blocks? no wheelwar's complete without them [06:07:14] :P [06:07:55] Reedy: can i get you to merge https://gerrit.wikimedia.org/r/#/c/49704/ ? [06:08:07] * PinkAmpersand PinkAmpersand fast-forwards 24 hours and blocks everyone for potential compromise [06:08:11] there we go [06:11:35] PinkAmpersand: what is a good threshold for autopatroller, 25 edits and not blocked? [06:11:44] * Jasper_Deng goes by 30+ [06:11:50] optimally 50+ [06:11:59] i'd say the bot should be waiting for 50. [06:12:03] i go lower if they have a good crosswiki record [06:12:08] me too [06:12:12] though there's nothing wrong with admins going earlier, of course [06:12:29] Jasper_Deng / rschen7754: i was going to set up something like https://en.wikipedia.org/wiki/Wikipedia:Database_reports/Editors_eligible_for_Autopatrol_privilege [06:12:37] just need a threshold to set it to [06:12:39] pl [06:12:42] legoktm: maybe also check to see if they're blocked on any other wikis? that stuff can sometimes matter [06:12:51] heh doncram's at the top of the list [06:12:55] legoktm: if you can't check on other wikis, 50+ and not blocked is safest [06:13:14] checking other wikis is possible, but annoying [06:13:19] like Michaeldsuarez has 25 edits, but definitely needs a little watching [06:13:30] legoktm: you can't like query SULutil or something? [06:13:39] there's 700 wikis to check [06:13:41] oh god no [06:13:43] legoktm: and to answer your question at http://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard#IP_vandalism , you basically cannot on an individual basis [06:13:56] i usually look for flags specifically [06:13:59] Jasper_Deng: :/ how would i have been able to tell in that case? [06:13:59] not just edits [06:14:04] but what /is/ true is the general rule that it's most likely for RIPE + APNIC [06:14:26] legoktm: therefore you stay cautious and make blocks short - 31 hours probably would've been more than enough [06:14:35] gotcha [06:15:26] block lengths depend on my mood [06:15:30] LOL [06:15:37] * Jasper_Deng imagines that one day he'll do a 1000-day block [06:15:57] as long as we dont go worse than enwikinews [06:16:13] lol i think i'll do some fun Materialscientist-style blocks, assuming no one manages to tank my RFP in the next 24 hours [06:16:49] PinkAmpersand: "You have been blocked indefinitely from editing for abuse of editing privileges"? [06:16:53] or enwikivoyag with their 2 hours blocks [06:17:15] Jasper_Deng: no i mean his arbitrary times. [06:17:25] nah I think he blocks pretty normally [06:17:37] he just picks funny numbers [06:17:52] like 182 days, 4 hours, 17 minutes and 12 seconds. stuff like that. [06:17:58] that's the software [06:18:03] ohhhhh [06:18:06] he probably meant 6 months [06:18:21] * PinkAmpersand wonders if localhost is still blocked on en [06:18:44] lol yep [06:18:58] http://en.wikipedia.org/w/index.php?title=User_talk:142.227.153.3&action=edit [06:19:54] this is always a fun page https://en.wikipedia.org/wiki/Special:BlockList?wpTarget=&wpOptions%5B%5D=userblocks&wpOptions%5B%5D=tempblocks&limit=50 [06:20:36] woah that top one does *not* deserve indef. [06:20:52] rschen7754: ^ [06:21:03] we need more enwiki admins :P [06:21:26] nor the second-from-top one. i mean, give it a year or two if you must, but indef? [06:21:28] * Jasper_Deng knows a few people on this channel who should run [06:21:51] (likewise on the third from top) [06:23:36] hm [06:23:37] so [06:23:47] you know how we got the "Imported from" property? [06:23:58] I think it was manually created [06:23:59] would it make sense for my bot to go back and retroactively add it? [06:24:33] you're lucky this isn't enwiki (otherwise you'd need approval) [06:25:18] that's not what i'm asking... [06:26:13] btw legoktm https://www.wikidata.org/wiki/Special:AbuseFilter/10 - you yourself was caught in this filter [06:26:27] oh nvmd [06:26:32] * Jasper_Deng saw that it was a test [06:26:36] https://www.wikidata.org/wiki/Special:AbuseFilter/history/10/item/117 [06:26:37] :P [06:26:48] i just needed to check what the summary would look like [06:26:52] legoktm:getting back to the bot thing, how'd you know ehre it came from? [06:27:03] because my bot was the one that imported it [06:27:12] hm [06:27:39] should it point to the 'pedia, like "English Wikipedia"? or "Category:Highways in Maine"? [06:27:53] the former doesn't give much info [06:27:59] but the latter doesn't say which site it came from [06:28:41] hey umm.... is this user known on any other wikis? https://www.wikidata.org/wiki/Special:Contributions/GigaJew666 and, if not, could someone please give them a gentle nudge in the direction of [[m:SRUC]]? [06:28:41] 10[1] 10https://meta.wikimedia.org/wiki/SRUC [06:29:10] I'd do a username block [06:29:20] contribs are constructive, though [06:29:28] and blocks hurt people's feelings [06:29:31] {{softestblock}} [06:29:32] 10[2] 10https://wikidata.org/wiki/Template:softestblock [06:29:48] actually no [06:29:53] it really isn't that offensive [06:30:02] however, https://en.wikipedia.org/wiki/User:GigaJew666, on the other hand.... [06:30:20] as i say, just a slight nidge. [06:30:38] we need crats at some point [06:30:45] I'm not going to do anything - that username isn't that bad [06:30:59] oh shit [06:31:02] re your en link [06:31:21] clearly WP:UPNOT [06:31:29] "But if you are an intelligent and a shining example of Mankind, then the Jews plan to eliminate you from the gene pool so that you don't breed any other descendants who are smarter or better than they. The Jews hate anybody who is superior to them which is why they hate all of Mankind. So, they try to eliminate the competition through down-breeding and [06:31:29] culling." [06:31:37] G10 [06:31:42] oh cool [06:31:50] so if you click save it gets added to the watchlist [06:31:59] but not if you hit enter :( [06:32:01] "In this way, their places back at home can be taken over by Mexicans, Chinese and Pakistani immigrants who are all led by the Jews and by the Jew-controlled Leftist politicians." [06:32:18] nominated for CSD [06:32:50] rschen7754: that sounds like a JS bug.... [06:33:14] legoktm: it's helpful for me! [06:33:18] i have it turned on in prefs [06:33:29] rschen7754: feel like blocking the guy on en, or would that be premature? [06:33:45] I'd say if he makes that again, indef [06:33:52] it's otherwise good-faith [06:34:08] sacked [06:34:13] "good faith" is a stretch. "not blatant vandalism" i'd accept, though [06:34:26] other pages, not the userpage [06:34:51] ahh [06:35:11] i'll stalk his wikidata contribs on ##PinkAmpersand [06:35:11] 10[3] 10https://wikidata.org/wiki/ [06:35:35] * Jasper_Deng 's #jasper-WM sits empty... [06:35:52] * rschen7754 doesn't have a personal channel [06:36:40] though i am +F on the roads channel [06:36:58] which is more impressive, since don't you have to actually register for a one-# ? [06:37:12] no you can just start one [06:37:22] i do it all the time when i make a typo [06:38:11] oh [06:38:41] i thought that was the difference between # and ## [06:38:42] 10[4] 10https://wikidata.org/wiki/ [06:38:54] no [06:38:57] # is mainspace [06:39:00] ## is chatspace [06:39:00] 10[5] 10https://wikidata.org/wiki/ [06:39:18] /kb #wikimedia-wikidata AsimovBot [06:40:02] legoktm: ahh [06:41:18] you can /ignore it [06:41:26] which brings me to another topic [06:41:33] we need an {{unblock}} [06:41:34] 10[6] 10https://wikidata.org/wiki/Template:unblock [06:41:56] with that i'd be careful… that sort of is an enwiki thing [06:42:06] well it's used on Commons + Meta too [06:42:18] both multi-lingual like WD [06:42:53] yeah but i'm not sure if everyone else will be ok with it [06:43:06] enwikivoyage was not happy when we brought that over [06:43:09] hence we'd need to discuss [06:43:32] (WV shouldn't necessarily be used as an example - they're one of the most eccentric projects since they're new to Wikimedia) [06:44:04] we /do/ already have an {{unblock}}. imported from Commons. I had to remove some links to commons policy [06:44:04] 10[7] 10https://wikidata.org/wiki/Template:unblock [06:44:21] Well it isn't policy yet [06:44:43] b/c we need to create the actual process [06:44:55] * Jasper_Deng wonders if legoktm wants to start the proposal [06:45:10] about unblocking? [06:45:11] sorry [06:45:15] im working on my bot [06:45:34] yeah [06:45:37] take your time, no rush [06:46:20] i think we should have a policy that admins have to notify users when they're blocked. it's just common sense, and it keeps people in an AGF mentality [06:46:43] which brings me to another topic I brought up tonight [06:46:44] well, not in every case [06:46:45] block templates [06:46:46] say a spambot [06:46:55] would anyone like https://www.wikidata.org/wiki/Wikidata:Database_reports/Missing_links extended to any other languages? [06:47:54] eswiki [06:48:13] rschen7754: yeah, fair enough. but even then, only unambiguous spambots. sometimes a human spammer can just seem botlike [06:48:28] well there's other reasons too - LTAs, socks [06:48:37] that's why it failed on enwiki [06:48:39] rschen7754: https://en.wikipedia.org/w/index.php?diff=540205096&oldid=540203880 btw [06:48:56] heh [06:49:31] and yeah. well, i think enwiki ADMIN policy is currently that admins should communicate all actions with affected users, with common-sense exceptions [06:49:45] which is probably what we should have on WD [07:30:09] https://www.wikidata.org/wiki/Wikidata:Project_chat/FAQ [07:34:10] write some FAQs! [09:14:48] http://www.wikidata.org/wiki/User:Rschen7754/js_toolbox.js [09:14:57] all right, have a vandal patrol toolkit [10:35:24] New patchset: John Erling Blad; "(Bug 45111) Fix the squashing of whitespace and control chars" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50365 [11:00:40] Change abandoned: Anja Jentzsch; "backported later to the branch" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49692 [11:33:53] Hello. [11:33:55] legoktm: https://gerrit.wikimedia.org/r/#/c/50709/1..2//COMMIT_MSG [11:34:16] legoktm: the first line of your commit message is like a changelog summary entry [11:34:26] it makes sense to include the target site [11:35:04] The same repository (and file) contains configuration for 200+ projects. [12:46:49] New patchset: Tobias Gritschacher; "(testing) necessary adjustment to blockeduser selenium test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50746 [13:34:50] JeroenDeDauw: https://bugzilla.wikimedia.org/show_bug.cgi?id=45234 [14:15:35] hi Reedy, are you responsible for tonight's deployment? [14:16:42] moin! [14:17:57] hi aude :))) [14:18:33] aude, will you be around for the deployment? [14:18:34] really nothing is needed from us tonight except [14:18:46] stick around in case there are any problems [14:18:48] we have 2 backports [14:18:53] :o [14:19:02] already in the branch? [14:19:08] one css thing and one that is actually only repo (term search related) [14:19:14] ok [14:19:16] yep, the last one in there from henning [14:19:23] that should fix ie8 problems [14:19:29] then we'll update the submodule stuff [14:19:31] will you be around later? [14:19:45] I need to leave now and will be back online in 2-3h [14:19:55] then when reedy switches enwiki over to wmf10, then stuff automagically happens :) [14:20:05] ok cool [14:20:19] we will be around from 7pm german time on [14:20:21] we stick around in case of issues but code changes for the client are rather minimal [14:20:34] and we can already poke around on test2 to see how things are [14:20:50] e.g. make sure dispatching changes is still fine [14:20:50] ok [14:20:55] can we talk later? [14:20:57] * aude will probably be around [14:21:00] ok [14:21:01] * aude promised [14:21:16] k, enjoy your time [14:21:23] if you're not around we will handle this ;) [14:21:29] (hopefully ;) [14:21:32] ok [14:21:36] should be boring [14:21:53] switching enwiki over is the easiest one, from here forward [14:22:03] since it's just one (although the biggest) [14:22:13] no rebuilding localisation, etc. [14:22:53] Tobi_WMDE: poke [14:23:36] aude: huhuu [14:23:51] Tobi_WMDE: i worked on claim diffs last monday so we had *something* to deploy [14:24:16] wonder if you want to follow up on that, since claim diffs are still "stuck" and not in master yet [14:24:43] aude: as far as I see, the initial version covering main snaks got deployed, is this correct? [14:24:44] https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/Wikibase+branch:claimdiffs,n,z [14:25:01] Tobi_WMDE: it did but i worked in a branch only because some stuff is still stuck with -2, WIP [14:25:18] * aude fought with git and got it into the branch so i could work on it [14:25:24] errr, gerrit :) [14:25:34] aude: saw it already. you removed the html generation, right? [14:26:19] Change restored: Aude; "this should not be abandoned. it got put in the claim diffs branch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49628 [14:26:32] huh? [14:26:41] commits that got into the branch are [14:26:44] https://gerrit.wikimedia.org/r/#/c/49628/ [14:26:51] squashed with your stuff and jeroen's [14:27:03] 'cause denny liked jeroen's stuff and wanted to build upon it [14:27:15] https://gerrit.wikimedia.org/r/#/c/49636/ [14:27:26] and https://gerrit.wikimedia.org/r/#/c/49639/ [14:27:39] danielk has various comments on those patches (i agree with them) [14:29:29] aude: so, what's the right change to work on? [14:29:37] still https://gerrit.wikimedia.org/r/#/c/48459/ [14:29:40] * aude sees that https://gerrit.wikimedia.org/r/#/c/49639/ never got approved for the branch [14:29:44] or https://gerrit.wikimedia.org/r/#/c/49628/? [14:29:45] i'll rebase it and approve it [14:30:17] * aude click [14:31:58] 48459 is same as 49628 [14:32:02] * aude confused :) [14:32:08] yes, saw that [14:32:18] so we can abandon one of those? [14:32:34] https://gerrit.wikimedia.org/r/#/c/49628/1 is the one referenced by another patch [14:34:20] i think it's best to abandon https://gerrit.wikimedia.org/r/#/c/48459 [14:34:27] but it has a -2 so i didn't want to touch it [14:34:40] 49628 is exactly the same [14:36:03] aude: and what's about https://gerrit.wikimedia.org/r/#/c/49502/ [14:36:13] I'm totally confused [14:36:47] * aude click [14:36:55] * aude got confused too [14:37:44] Tobi_WMDE: that one got squashed into 49628 [14:38:04] * aude struggled greatly with gerrit and managed to do that [14:38:12] ok, so what to do with it? abandon? [14:38:15] yes [14:38:37] it has a -2 so no way i could really work with that as a dependency and get something done [14:38:58] * aude dislikes the long chain of dependencies and locking stuff like that [14:39:07] aude: but https://gerrit.wikimedia.org/r/#/c/49504/ is not squshed yet [14:39:45] what i did essentially replaces that [14:39:51] no way to really squash it [14:40:04] or maybe it did get squashed [14:40:23] aude: no, that's not in 49628 [14:40:28] there's still the todo [14:41:01] hmmm [14:42:07] https://gerrit.wikimedia.org/r/#/c/49636/ does the same thing and has one todo [14:42:35] * aude factored out the generate html part, which (todo) should be shared with stuff in diff view [14:43:46] aude: ok, let's see: I'm going to abandon https://gerrit.wikimedia.org/r/#/c/48459/ first (reason: it's the same as 49628), ok? [14:43:50] New patchset: Aude; "(bug 44095) enhanced claim diff visualizaion including refs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49628 [14:43:51] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50747 [14:43:51] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50748 [14:43:52] rebasing now [14:43:58] ok [14:44:32] Change abandoned: Tobias Gritschacher; "this is the same as 49628/, further work is done there." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [14:45:01] gah, messing things up more [14:45:21] forgot the branch [14:45:26] aude: next I'm abandoning https://gerrit.wikimedia.org/r/#/c/49502/ (reason: this got already squashed into 49628) [14:45:40] Change abandoned: Aude; "this supposed to go into the branch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50747 [14:46:00] New review: Aude; "submitted to wrong branch!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50748 [14:46:35] ok [14:47:06] hi [14:47:43] I have a problem with an user in french wikipedia [14:48:04] Change abandoned: Tobias Gritschacher; "this got squashed into 49628." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49502 [14:48:57] he removes languagelinks to an anchor paragraph because it says that wikidata can't handle it [14:49:04] trying to merge master into my branch [14:49:50] aude: hm, why not making a changeset on master which depends on https://gerrit.wikimedia.org/r/#/c/49628/ [14:50:27] My questions: can it ? If not is there anything which is can be done ? [14:50:45] Tobi_WMDE: i could do that now [14:51:08] aude: yes, please [14:51:23] ok :) [14:51:41] xcombelle: wikidata can't do it indeed [14:51:44] those need to stay local [14:51:53] or the articles changed [14:52:45] but they can stay local no need to remove it ? [14:53:21] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50187 [14:53:42] right [14:54:02] thanks a lot [14:54:03] just keep i mind that whatever is local overwrites what comes from wikidata [14:54:06] no problem [14:54:16] New patchset: Daniel Werner; "Gives names to all important constructors for improved debugging experience." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/50186 [14:54:27] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/50186 [14:56:38] ok, struggling with gerrit again [14:56:41] give me 5 min [14:56:48] aude: np [15:00:09] failed to push some refs to [15:02:14] :-( [15:05:12] New review: Aude; "approve this then it can be cherry picked" [mediawiki/extensions/Wikibase] (claimdiffs); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49639 [15:05:13] Change merged: Aude; [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [15:07:51] not going well... [15:07:55] 5 more min [15:08:11] this is exactly what last monday was like with pressure to get something done :( [15:14:28] aude: isn't it just about rebasing the "further work" from the claimdiff branch to the "simple diff visualization" (50747)? [15:14:56] Change restored: Aude; "nevermind, we want this :)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50747 [15:15:24] ok, that was stupid [15:15:34] https://gerrit.wikimedia.org/r/#/c/50748/ was already submitted to master [15:16:06] New patchset: John Erling Blad; "(Bug 45353) Add ItemDisambiguation to the list of special pages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/50749 [15:17:45] aude: looks good now [15:17:54] or is there still something missing [15:18:13] no, it's good [15:18:40] there's still follow up needed for danielk's comments and the todos noted in the commit message and in the code [15:18:43] aude: 49628, 50748 and 50747 - that's all we have so far, right? [15:18:49] yep [15:18:55] everything else can be abandoned [15:19:20] aude: so we abandon https://gerrit.wikimedia.org/r/#/c/49504/ [15:19:21] * aude like it in good shape for wednesday [15:19:24] sure [15:20:40] Change abandoned: Tobias Gritschacher; "this is done in 50747 and 50748" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49504 [15:20:41] in the future, i recommend smaller patches and pieces [15:20:47] and not build long dependencies like this [15:20:57] we must iterate and improve [15:21:15] there was just one change last week when I left [15:21:16] * aude wasted couple hours with gerrit [15:21:16] :-) [15:21:20] true [15:22:04] anyway, if you want to work on this, that would be awesome and i'm working on the client widget and fix some bugs [15:22:12] while bored on vacation :) [15:22:30] and I'm glad I did a first iteration which got merged - that's basically the stuff which is online right now [15:22:36] yes [15:22:48] i was just about to approve your second iteration too [15:22:53]