[00:03:52] hoo: yes experimental for now [00:04:14] as it is now, it will appear on wikipedia even though it's not quite ready :/ [00:04:48] so we'll at least need to backport an "experimental" patch for wmf10 [00:05:03] aude: Ok [00:05:18] I got a patch for that, will push it to gerrit in a few seconds [00:05:19] we can take a look more at it this week, to get it out of experimental [00:05:24] great [00:05:40] aude: Shall we show (None) under langlinks or don't show langlinks at all? [00:05:49] First one is easier to hack [00:09:02] None is okay, is suppose [00:09:17] Ok, will do [00:09:26] it'd be nice to have a link to special:createentity [00:09:34] not required [00:10:41] err createitem [00:11:07] mhm, yeah [00:11:21] New patchset: PleaseStand; "Remove dependency on Services_JSON class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49604 [00:12:44] New review: Hoo man; "Patch Set 1: Code-Review+1" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/49604 [00:13:04] https://www.wikidata.org/w/index.php?title=Special:CreateItem&site=enwiki&page=Bradley%20Creek [00:13:20] in a little, (not ready) script i have on enwiki, it has a link like that one [00:13:25] if there is no item for a page [00:13:41] it populates the first sitelink in the form [00:15:03] aude: Why does the format with get params differ from https://www.wikidata.org/wiki/Special:CreateItem/enwiki/Bradley_Creek [00:15:22] http://demos.filbertkm.com/wikidata/itemlink.js [00:15:24] it's hacky [00:15:48] no idea about the form params though seems doable to support both ways [00:17:45] * aude gets -2 for tabs :o [00:17:48] and spaces [00:20:15] aude: I'll do that link server side [00:22:46] That has the upside that we get a non-JS fallback "for free" on top :P [00:23:07] hoo: agree [00:23:26] * aude can't do that with scripts [00:26:51] hoo, could it be possible to place an ItemDisambiguation-like table in the lower half of the dialog? [00:27:41] Jeblad_WMDE: What should that be good for? [00:27:48] I don't think I get what you want [00:28:05] To see other similar items [00:28:42] It would force the user to have some form of double checks [00:29:07] Jeblad_WMDE: And where should it get those similar items from? [00:31:00] wbsearchentities and then a lookup with wbgetentities [00:31:36] We could also change wbsearchentities so it can return some props for the found entries [00:31:45] New review: John Erling Blad; "Patch Set 2:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/47033 [00:32:42] New patchset: Hoo man; "Make wbclient.linkItem experimental for now + non-JS fallback" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49606 [00:33:12] Jeblad_WMDE: Mhm... I don't really think that's a very good idea... could you compose some fake screenshots maybe? [00:33:14] KISS [00:33:35] aude: ^ [00:35:00] I think it is important, and it will avoid a lot of duplicates [00:35:30] Jeblad_WMDE: But what exactly shall I search for? [00:35:37] While testing the dialog I actually created a lot of duplicates that wasn't intentional [00:36:03] There are two ways to search on wikidata [00:36:31] One is to search for items by labels, another is to search for items by sitelinks [00:36:50] We already search by sitelinks [00:37:06] When you create the first sitelinks you do it by checking external sites, not wikidata [00:37:07] and I don't really think searching by label would give us a great benefit? [00:37:09] hoo: i'd say no for now [00:37:18] we need something for tomorrow [00:37:25] or asap [00:37:40] aude: Made it experimental in gerrit [00:37:44] Searching by label is the only way to verify that there are no duplicates [00:37:45] we can discuss after tomorrow about what goes in the widget and denny might have an opinion [00:37:53] hoo: thanks [00:38:04] Sad that I can't be with you :/ [00:42:42] take a look in a few minutes [00:50:11] New patchset: John Erling Blad; "Fix API rights, that is permissions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/47033 [00:55:00] Hey, I need a German speaker please [00:55:28] Sven_Manguard: Yes? [00:55:33] Can someone help me disambiguate http://www.wikidata.org/wiki/Q827222 and http://www.wikidata.org/wiki/Q1419760 [00:55:42] for the English description [00:56:07] also http://www.wikidata.org/wiki/Q1419776 and http://www.wikidata.org/wiki/Q575262 [00:59:21] hoo: ? [00:59:24] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49604 [00:59:26] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49604 [00:59:53] Sven_Manguard: First two are rivers, both [01:00:08] right, but I need help differentiating between the two [01:00:29] The English articles are crap, so all I have for both are "river in Bavaria, Germany" [01:00:40] Sven_Manguard: Ah, I see [01:01:04] They flow into the river within the brackets [01:01:13] oh, cool [01:01:20] So the first one flows into the "Pegnitz" [01:01:32] second one into "Lindner" [01:01:38] * Linder [01:02:19] and so on :P [01:03:36] God dammit Jasper_Deng! Every time I find a good user to give autopatrolled to, you've already given it to them :P [01:03:51] There was something else with your dialog hoo [01:04:01] Sven_Manguard: what me? I haven't even done that many user rights changes! [01:04:07] Some messages didn't parse as they should [01:04:09] Jeblad_WMDE: The message parsing thing? I closed that [01:04:15] Fixed in master [01:04:16] Apparently you've done enough... [01:04:20] I wrote a bug about it, .. [01:04:22] ok [01:04:37] Did you set it to fixed? [01:05:03] I think so [01:05:09] ok [01:05:25] Because we want to verify all bugs [01:05:26] yes https://bugzilla.wikimedia.org/show_bug.cgi?id=45107 [01:05:38] Ie that they are actually solved [01:05:50] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49598 [01:05:51] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49598 [01:06:22] Jeblad_WMDE: Yeah, I know ;) [01:12:44] hoo: what's http://de.wikipedia.org/wiki/Fischbach_bei_N%C3%BCrnberg ? [01:12:56] Google Translate is useless today :( [01:13:43] and there are like 30 things named Fischbach on the project, so I need to disambig them [01:14:30] Sven_Manguard: A former small town. Now part of Nürnberg [01:14:46] perfect, thankx [01:19:26] New patchset: Hoo man; "Give wbclient.watchlist some love (jshint + code style)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49607 [01:21:55] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49606 [01:21:56] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49606 [01:35:30] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49608 [01:38:26] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49608 [01:42:08] aude: https://gerrit.wikimedia.org/r/49607 That should go for a fast merge :D [01:43:09] hoo: agree but i'll have to stop for tonight [01:43:47] :D Good night, then ;) [01:44:13] trying to get diff visualization done and autosummaries in shape for deployment :) [01:44:42] the client doesn't have to be perfect but see what we get in there too [01:45:15] Yes... many things to work on... [01:45:17] there probably will be another few client backports after tomorrow or at least opportunity.... [01:49:41] In other languages is an überkewl feature [01:57:59] New review: John Erling Blad; "Patch Set 2: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49594 [01:58:00] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49594 [02:00:59] pssst can someone change the sitenotice to not say "including the sources interface"? [02:02:06] ? [02:03:36] I ? your ? [02:03:59] why change the sitenotice? [02:04:22] isn't the sources interace working now? at least partially? [02:04:38] no [02:05:38] oh.. [02:11:40] I have returned [02:11:53] * Sven_Manguard draws blade, charges at Pink|Away [02:12:27] * Sven_Manguard slashes the |Away off of Pink [02:12:33] aww, a tad late [02:12:39] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49607 [02:12:40] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49607 [02:12:58] * PinkAmpersand ducks, and directs Sven_Manguard toward his 50-minute old deletion request [02:13:55] * Sven_Manguard slashes Q4007044 into 4007044 pieces [02:14:31] pretty hard to have 4007044 pieces of an empty item. or was there still an Italian label or something? [02:14:59] do you have a mustache? [02:15:16] PinkAmpersand? [02:15:37] * Sven_Manguard supergules a mustache onto PinkAmpersand [02:15:43] Sven_Manguard: a sparse one, yes. why? [02:16:01] * Sven_Manguard slashes PinkAmpersand's mustache into 4007044 pieces [02:16:11] *that's* how [02:16:28] * PinkAmpersand is just confused now [02:16:40] yes! [02:18:09] if I ever get around to filing an RFP, and it passes, my first action will be to block you for using URLs instead of wikilinks https://www.wikidata.org/w/index.php?title=Q4007044 [03:11:21] what's the Scope page's link [03:11:40] and PinkAmpersand if it needed to be a link, I'd have made it a link [03:51:57] apparently sports channels have decided that strobe lights are the "in" thing for commercials this year. Excuse me while I go vomit... [04:26:21] whoa big roon [04:26:23] *room [04:26:36] welcome Swob [04:26:49] hello Swob [04:26:49] its a redirect, too [04:26:56] how come not #wikidata ? [04:27:14] I think it's been discussed [04:42:44] Swob: absolutely no good reason [04:44:13] techman224: oc and nn, what languages are they? [04:44:39] isn't there a bot for that? [04:44:46] occitan and Norsk [04:44:48] never mind [04:48:24] ok [06:10:04] FYI all - I just moved a bunch of properties that have been /approved/ but for which the datatype isn't live yet to https://www.wikidata.org/wiki/Wikidata:Property_proposal/Pending [06:10:17] to keep them all in once place and not, well, lost [06:12:31] James_F: still awake? [06:12:50] Sven_Manguard: A bit. Is it urgent? [06:12:56] not really [06:14:09] just a quick question: where do I go to find the list of future datatypes? [06:28:21] Sven_Manguard: Don't think it's written down anywhere other than the discussion of outline types on the model pages on meta. [06:31:00] groan, I'll look tomorrow then [07:06:32] Hi [07:09:21] Is there already some discussion about how exactly to deal with disambiguation-page-items? [07:10:06] e.g. [[Q241775]] [08:04:33] * aude waves [08:07:06] New patchset: Aude; "(bug 44095) visualize claim differences" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49502 [08:07:06] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49608 [08:07:07] New patchset: Aude; "(bug 44095) enhanced claim diff visualizaion including refs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [08:08:14] New review: Aude; "Patch Set 3:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49608 [08:09:32] morning aude [08:09:56] happy presidents day! [08:10:24] our most important holiday :) [08:11:15] really? [08:11:20] lol :) [08:11:56] * aude welcomes any days off, except i'm not off today :/ [08:12:33] it's usually time of year for a mega snow storm, and then we get the whole week off [08:13:26] * aude back to coding.... [08:48:45] * yurik is frozen in NY [09:13:14] DanielK_WMDE: moin [09:19:16] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49608 [09:30:02] moin Abraham [09:44:51] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Purodha link https://www.mediawiki.org/w/index.php?diff=648302 edit summary: [+4] Grammar [09:50:43] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Purodha link https://www.mediawiki.org/w/index.php?diff=648305 edit summary: [+48] /* Usage */ Grammar [09:51:52] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Purodha link https://www.mediawiki.org/w/index.php?diff=648306 edit summary: [+4] /* Requirements */ Grammar [10:08:24] is there a javascript-only based langlinks editor planned? Something that can be used on a lang wiki without hitting wikidata site? [10:18:02] yurik: it's in the plans. there is something we have almost finished for when a page does not have langlinks yet. based on that it should be easy to have what you request. [10:22:36] thx! Another q: how difficult will be to switch to the proper title parsing: [[w:fr:Title]] instead of the "magic" frwiki:Title [10:36:30] https://gerrit.wikimedia.org/r/#/c/47396/ [10:36:34] aude [10:37:15] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49608 [10:38:16] AnjaJ_WMDE: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git;a=commit;h=1b586e01a4b1b112b030614c635a0ded4d36a339 [10:45:23] AnjaJ_WMDE: that's unrelated to my q, right? [10:45:49] yes yurik, we are preparing tonight's branch, sorry [10:46:08] no worries, i will send an email with it later, good luck :) [10:46:24] New patchset: Aude; "(bug 44095) enhanced claim diff visualizaion including refs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [10:47:45] New review: Aude; "Patch Set 16:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [10:50:12] * aude hates gerrit [10:53:05] New patchset: Aude; "(bug 44095) enhanced claim diff visualizaion including refs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49628 [10:57:26] New review: Aude; "Patch Set 1:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49628 [11:00:20] New patchset: Anja Jentzsch; "(bug 44665) start/stopEditing events for claimview widget" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49629 [11:01:28] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49629 [11:01:30] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49629 [11:03:40] New patchset: Anja Jentzsch; "css: Coloring for reference errors" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49630 [11:04:05] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49630 [11:04:07] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49630 [11:08:55] yurik: i don't understand your question about title parsing. where are titles parsed? [11:09:02] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49608 [11:09:28] DanielK_WMDE: for example, in the api, the site is set up as ruwiki + page title [11:09:45] so a search would be site=ruwiki, titles=page [11:09:59] question is, can it be switched to a more "wiki style" [11:10:02] yurik: yes, these are two separate parameters. no parsing involved. [11:10:07] of w:ru:page [11:10:33] that "wiki style" is ambiguous. [11:10:47] depending on which wiki you use it, the prefixes may mean different thing [11:10:48] s [11:10:55] we use global wiki identifiers. [11:10:56] this way there is a clear path for non-wiki langlinks, etc [11:11:00] global? [11:11:03] i suppose aliases could be set up, but why? [11:11:32] is that the goal - to have global links for every WMF site+language? [11:11:37] global in the sense that they are the actual ids of the wikis, no a local prefix assigned to them [11:11:49] New review: Jens Ohlig; "Patch Set 1:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49263 [11:11:54] yes, a global identifier for every wmf site [11:12:18] i don't understand what you mean with "a clear path for non-wiki langlinks" [11:12:33] where would you use it? [11:12:43] again, i do not see any place where such links get parsed [11:12:45] for example "ruquote:Blah" for the Blah article [11:12:53] yes. [11:13:02] but such links do not exist in that form [11:13:21] we use title=Blah, site=ruquote. NO parsing involved. [11:13:43] which table contains the "ruquote" [11:13:52] New review: Aude; "Patch Set 1:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49628 [11:13:52] the sites table [11:13:54] is that the same interwiki table? [11:14:11] sites is to replace the interwiki table. the interwiki table is unsufficient and broken by design [11:14:14] but is that table in wikidata-pro? [11:14:33] is that table going into the core? [11:14:34] the global identifiers we use were not in the database before. but they were used in the configuration e3xtensively [11:14:40] e.g. they are also the actual database names [11:14:53] the sites table has been in core for about 6 months now [11:15:01] but it's not used by anything but wikibase yet [11:15:14] do you know if Title object will support it? [11:15:17] the idea is to move from interwiki to the sites table completely, at some point [11:15:36] i hope it will eventually, but global ids are not (automatically) prefixes [11:15:39] they are ids [11:15:42] so [[ruquote:Blah]] will not work in a local page? [11:15:53] if you want to use them as link prefixes in wikitext, you have to declare them as valid prefixes [11:16:13] not at the moment, but we could, as a stop gap, just add the global identifiers to the interwiki table [11:16:18] (kind of sucky, but would work) [11:16:21] ju8st file a request for that [11:16:24] exactly what i was just thinking [11:16:37] i think i have suggested that before, in the project chat or something [11:16:57] i think it will be a very good stop gap solution to ensure that all such identifiers are placed into config at this point [11:17:09] hm? [11:17:15] i don't really see why [11:17:32] when and where are users exposed to the global wiki ids? [11:17:42] how would they even know the correct id to use in wikitext? [11:18:09] trying to unstick -2 stuff :/ [11:18:17] I think it will be a much better (from the usability perspective) to use enwiki:PageA|ruwiki:PageB in the api requests [11:18:43] yurik: and... having the identifiers in the config isn't really a goal, it's just a way to reach a goal (unambiguous adressing of wikis) [11:19:19] yurik: that's a whole different story. and i suppose you are right - that style is more convenient [11:19:30] i'm not exactly sure how the migration from [[w:ru:xxx]] -> [[ruwiki:xxx]] will happen [11:19:31] but it's unrelated to interwiki prefixes used in wikitext [11:20:21] yurik: please, do not mix arguments about links in wikitext with ids used in API requests. They are unrelated, and can be completely different. [11:20:25] Change abandoned: Aude; "make a remote feature branch with this and can submit to wmf10" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49628 [11:21:04] a) support [[ruwiki:X]] in addition to [[w:ru:X]] [11:21:08] possibly [11:21:28] no, definitely :) [11:21:34] b) support title=ruwiki:X vs. title=X&site=ruwiki [11:21:35] i mean - i see your point. What i do worry is that it might be more complex to [11:21:40] these two things really have no connection [11:21:41] convert from one to another [11:21:52] convert when where and why? [11:22:00] i see no need for any conversion [11:22:02] by the bots -- when they analyze pages [11:22:10] o_O [11:22:15] sorry, slow typing :) [11:22:33] give me a sec to phrase it right (and get it straight in my head) [11:22:44] ah, now i think i know where you are coming from [11:23:01] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49632 [11:23:13] if the bot reads a wiki9pedia page, it has language prefixes. it needs to convert them to global wiki ids, so it can set the sitelinks on wikidata.org [11:23:16] Change abandoned: Aude; "working on a branch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49608 [11:23:17] is that it? [11:23:27] yes, that's basically it :) [11:23:35] that conversion depends on the wikipedia you are reading the links from [11:23:39] i should be sleeping at 6:30am :) [11:23:51] (language prefixes for all wikipedias *should* be the same *on* all wikipedias, but there is no guarantee) [11:24:02] alright got a feature branch for claim diffs that is unstuck, with stuff for deployment [11:24:03] true, and i think it is pretty much so [11:24:10] and on sister projects, it's going to be different still [11:24:26] but the bots already understand the language links [11:24:30] so, to get it right, the source wiki's api would need to make the translatiuon [11:24:30] if i had $10 for every time someone asked about sister projects and wikidata i'd be rich [11:24:40] that's actually something we could have a request for on bugzilla :) [11:24:41] by examining the "local" interwiki table through the api [11:25:14] rschen7754: you'll have to talk to denny, i should keep my mouth shut :P [11:25:19] lol [11:25:39] oh, i've seen requests from wikisource, wiktionary, wikivoyage now [11:25:48] getting a little annoying lol [11:25:53] yurik: yea - they get the URLs, but not the site IDs. Because the API doesn't expose these yet. Because it doesn't use the new sites table [11:25:54] ideally, i think we should start promoting all wikies to use a global identifiers ( ruwiki instead of w:ru: ) [11:26:15] (a bot could also start fixing them) [11:26:27] rschen7754: i replied to a question about wikitionary on the project chat, i think [11:26:57] yurik: i'd be very careful with that, and i would not ties this request to the basic one (exposing the global ids through the API) [11:27:01] but at the end of the day, i am not trying to get the sites problem resolved (diff discussion), what i do want is a more intuitive api :) [11:27:12] i would wnat support for them as prefixes on wikidata, but probably not on wikipedia etc [11:27:14] exactly :) [11:27:17] New review: Aude; "Patch Set 16:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [11:27:41] wiktionary is actually the exact example of where wikidata should be deployed the soone the better [11:28:05] hmm... i'm just worried that bots will start hardcoding weird stuff like if coming from wikiquotes, w:ru:xxx means ruwiki:xxx [11:28:51] IMO, wikidata is the MOST destabilizing project in wiki history :) [11:31:43] destabilizing in good sense, i assume [11:32:24] anyway, i see your point about the global ids, and i like the stopgap solution [11:32:32] Denny_WMDE: of course :) [11:32:37] https://www.mediawiki.org/wiki/Requests_for_comment/Wikidata_API#list.3Dwdsearch_.28wds.29 [11:32:47] i just adjusted the sitespec [11:32:56] this is where i'm going with the api for the search [11:33:06] (expand the last result) [11:33:24] i mean - just look at the list=wdsearch (wds) header [11:33:24] New patchset: Daniel Kinzler; "(bug 44744) copyright tooltip will now always be shown" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49633 [11:35:13] Lydia_WMDE: done [11:35:19] Abraham_WMDE1: thx [11:39:38] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49633 [11:39:40] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49633 [11:45:53] New patchset: Anja Jentzsch; "(bug 44744) Site links table: Attaching table headers earlier" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49634 [11:46:14] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49634 [11:46:16] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49634 [11:47:40] New patchset: Anja Jentzsch; "(bug 44744) copyright tooltip can now be disabled (using a cookie)" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49635 [11:47:59] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49636 [11:48:14] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49635 [11:48:17] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49635 [11:48:39] git fail [11:49:28] New patchset: Anja Jentzsch; "(bug 44744) copyright warning now using its own message instead of EditPage::getCopyrightWarning" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49637 [11:49:48] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49637 [11:49:50] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49637 [11:50:18] New review: Aude; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (claimdiffs); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49636 [11:50:19] Change merged: Aude; [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49636 [11:50:45] Change abandoned: Aude; "don't need this one" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49632 [12:05:05] Denny_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=45116 [12:07:04] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [12:07:30] New review: Jeroen De Dauw; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49492 [12:07:32] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49492 [12:07:35] In Norwegian we switch object-action pairs compared to english [12:07:42] That is real fun in code [12:07:49] * Jeblad_WMDE goes crazy [12:09:12] New patchset: Anja Jentzsch; "(bug 41163, 44165, 44166) autocomments for claims." [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49640 [12:09:36] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49640 [12:09:38] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49640 [12:14:23] is there a bug in your bugzilla-system for the issue with IE8? [12:14:46] it was mentioned sunday in the office-hour [12:17:09] New patchset: John Erling Blad; "(Bug 41882) Add restrictions for special pages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49641 [12:25:02] New patchset: John Erling Blad; "(Bug 41882) Add restrictions for special pages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49641 [12:28:41] Denny_WMDE: so, I0fd1ea5f98d3 (autocomments) is in master, but has not been backported yet [12:28:56] having it in wmf10 would make it easier for me to make a patch [12:29:09] can i just packport it, or would that interfere with anyone? [12:30:21] New patchset: Daniel Kinzler; "(bug 41163, 44165, 44166) autocomments for claims." [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49643 [12:30:59] aude: are you ok with DanielK_WMDE backporting it? [12:31:15] Anja has gone to the doctor, so the only one working on the branch still is aude [12:33:40] fine to backport what we have [12:34:08] if someone has time in the next hour or so to make it show something nicer than the snak guid, that would be awesome but might not be realistic [12:35:05] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [12:41:01] New patchset: Daniel Kinzler; "(hotfix) Auto-comments: Show nothing rather than cryptic GUIDs." [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49644 [12:42:31] Denny_WMDE1: https://gerrit.wikimedia.org/r/#/c/49644/ [12:42:39] New patchset: John Erling Blad; "(Bug 41882) Add restrictions for special pages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49641 [12:43:13] DanielK_WMDE: thanks, verifying [13:13:33] Danwe_WMDE: your EntitySerializer patch doesn't cleanly merge into wmf10. i'll have a look... [13:15:11] hm, trivial conflict wrt "use" clauses. [13:18:07] good [13:18:33] gah. namespace Wikibase\Lib\Serializers? seriously? [13:18:48] ? [13:19:20] we were using a single namespace until now. now you make this 3 levels deep. seems overkill [13:19:27] does this solve any actual problem? [13:19:38] DanielK_WMDE: whom are you talking to? [13:19:40] can we discuss this another time? [13:19:45] I don't know anything about new namespaces [13:20:19] i also prefer a different "tone" in the discussion [13:20:29] what is my gerrit account? [13:23:05] Denny_WMDE1, Danwe_WMDE: Yes, we can discuss this another time. And i did not mean to be unfreindly. I'm surprised, and a bit annoyed, but didn't mean to sound aggessive. [13:23:34] Danwe_WMDE: and right: your original patch doesn't have them, hence the conflict. sorry. i'll look again who i should talk to about it. [13:23:40] * DanielK_WMDE has an idea who it could be... [13:24:01] aude: Hey. Can you point me to what we're deploying today? And/or update make-wmf branch for me. Version of Diff, Data Values, and Wikibase? Thanks :) [13:24:08] or at least, an initial revision [13:26:21] New patchset: Daniel Kinzler; "(bug 44636/hot fix) added EntitySerializer option setIncludeValuesWithMissingReferences" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49647 [13:27:05] New review: Daniel Kinzler; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49647 [13:27:05] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49647 [13:27:38] Denny_WMDE1, Danwe_WMDE: merged backport of danwe's patch [13:28:09] Denny_WMDE1, Danwe_WMDE: backport + patch of my own stuff is pending approval [13:30:20] i can't login in gerrit [13:30:28] i am trying to figure out my password and login [13:30:32] otherwise i would +2 it [13:30:45] someone can +2 it instead of me, i had it locally checked and everything [13:33:05] ah, logged in! [13:33:24] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49644 [13:33:37] DanielK_WMDE: merged [13:34:07] de [13:34:09] err [13:34:20] the login is confusing... you need to use your git name with your labs password :P [13:34:40] git name = shell login name, i think [13:34:53] anyway [13:34:55] thanks Denny_WMDE1 [13:35:16] the autocomments aren't too helpful this way, but at least they are pretty :P [13:35:44] well, before they were not helpful and not pretty [13:35:46] i'll work on the autocomment stuff some more today. really want to get the api refactoring in too, though. makes things a lot easier [13:36:08] and the diff is just one click away, anyway, so it is an improvement [13:36:11] Denny_WMDE1: they are not more helpful now, the same info was there before. but they are prettier now :) [13:36:46] Reedy: we are still working on some backports [13:37:00] aude: which one is still pending`? [13:37:02] it will be mw1.21-wmf10 [13:37:04] DanielK_WMDE: claim diffs [13:37:14] * aude almost done with something good enough [13:37:50] we can also get the translation table inside [13:37:52] * aude curious about autocomments [13:38:00] will try them out again soon [13:38:40] aude: nothing much to see there. the good stuff is still in the pipeline [13:40:18] * aude nods [13:42:18] dev is on mw1.21-wmf10 now - please tell me when you are ready so I pull again [13:43:57] New patchset: John Erling Blad; "(Bug 41882) Followup for restrictions for special pages" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49641 [13:45:42] New patchset: Henning Snater; "(bug 44755) Language terms reacting on page edit mode event" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49648 [13:46:32] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [13:46:44] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/49639/ [13:46:48] if you want to see.... [13:47:09] i'm trying to make the references a little better but at some point have to stop, i suppose [13:47:31] there's a series of 3 patches on that branch with claim diff stuffs [13:47:46] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49648 [13:47:47] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49648 [13:51:17] New patchset: Henning Snater; "(bug 44755) Removing "experimental" check for language terms" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49650 [13:52:29] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49650 [13:52:30] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49650 [13:53:48] is that really urgent enough for a backport?... [13:54:02] i mean, i definitely want it in, but backports always scare me :/ [13:54:54] uh... and there's a dev branch for this? which we want to merge shortly before deployment? [13:55:24] uh, i'll shut up now :) [13:57:08] DanielK_WMDE: well, stuff in master was locked with a -2 WIP [13:57:23] the autocomments scare me! [13:59:03] JeroenDeDauw: it's the lower one [13:59:04] http://192.168.2.251:8080/view/Alle/job/wikibase-phpunit/168/console [14:00:24] Denny_WMDE1: you do realize I'm on holiday right? ;) [14:00:36] aude: Notice: Undefined variable: html in /DATA/var/www/daniel/wikidata/extensions/Wikibase/lib/includes/claim/ClaimDifferenceVisualizer.php on line 119 [14:02:54] New patchset: Jeroen De Dauw; "Add check to see if we can test with Query class" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49653 [14:03:01] Denny_WMDE1: ^ [14:03:04] New review: Daniel Kinzler; "Patch Set 3: Code-Review-1" [mediawiki/extensions/Wikibase] (claimdiffs) C: -1; - https://gerrit.wikimedia.org/r/49639 [14:03:18] Now If I did not get a ton of fatals when running the client tests on mysql, I'd actually have spotted that long before [14:04:46] Denny_WMDE1: you approved, but you didn't merge: https://gerrit.wikimedia.org/r/#/c/49644/ [14:04:51] please click "submit" :) [14:05:04] (this is different in core... we have no auto-merge via jenkins set up) [14:05:20] same for https://gerrit.wikimedia.org/r/#/c/49643/1 [14:05:28] or maybe someone else can merge them? [14:05:44] i could do it myself, after all, denny has approved them... still, feels icky :) [14:06:19] ?? [14:06:35] it tells me "can merge" no [14:06:38] i did push submit [14:07:21] and it gives me checks, not +2's [14:07:23] i am confused [14:08:34] Denny_WMDE1: the check marks are normal. [14:08:45] but if you see "can merge: no", you probably don't have the right permissions [14:09:05] i'll just merge them myself [14:09:25] ah, wait, no. [14:09:26] :( [14:09:27] Denny_WMDE1: https://gerrit.wikimedia.org/r/#/c/49643/1 [14:09:28] Denny_WMDE1: https://gerrit.wikimedia.org/r/#/c/49594/ [14:09:34] you didn't approve the dependency [14:09:56] Denny_WMDE1: without the dependency, the patch can't be merged [14:10:16] ah [14:10:21] didn't check that one [14:11:34] that one is just a plain, clain backport from master [14:12:01] ok [14:12:09] i trust you on that. looked funky to me, though [14:12:19] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49643 [14:12:20] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49643 [14:12:34] Denny_WMDE1: it did? how? [14:12:56] like the mustBePosted etc. are removed from CreateClaim [14:13:04] Denny_WMDE1: factored into a base class [14:13:12] so i wouldn't have to do everything trice [14:13:22] but yea, it makes the review less simple [14:13:59] well, someone reviewed it already you say [14:14:00] Denny_WMDE1: there will be a lot more refactoring of this kind very soon :) [14:14:33] hooray [14:14:39] :P [14:14:45] should get rid of a few hundred lines of code [14:15:03] ah screw it [14:15:11] New review: Daniel Kinzler; "Patch Set 1:" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49644 [14:15:13] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49644 [14:15:15] my branch doesnt work right now [14:15:33] ok, merged the anti-guid-patch now [14:15:51] i won't bother to put that on master [14:16:08] all of that code will be gone after the refactoring [14:16:09] my branch doesnt work at all right now [14:16:28] on wmf10 branch [14:16:34] repo [14:17:12] internal server error [14:17:20] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [14:18:58] New review: Daniel Werner; "Patch Set 1:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49263 [14:19:38] [Mon Feb 18 15:19:24 2013] [error] [client ::1] PHP Fatal error: Class 'Wikibase\\Lib\\Serializers\\EntityContentFactory' not found in /Users/denny_WMDE/Sites/t1/extensions/Wikibase/lib/includes/serializers/SnakSerializer.php on line 54 [14:19:48] :( [14:19:53] we are missing some backport i assume [14:22:45] my feeling is it is this one [14:22:45] https://gerrit.wikimedia.org/r/#/c/44975/ [14:23:38] that's a big change [14:24:02] i'll take alook in a minute [14:24:08] just about done with diffs [14:25:53] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [14:26:25] DanielK_WMDE: did you test your patchset on the branch? [14:27:25] Denny_WMDE1: yes [14:27:42] Denny_WMDE1: i tested it *only* on the branch. it doesn't exist on master [14:27:43] Denny_WMDE1: where do you get the error? [14:27:48] nevermind. [14:27:55] you can reproduce? [14:28:09] the patchset i suspected earlier should not be the problem [14:28:13] this was merged february 8 [14:28:19] ugh, mega cherrypick conflicts for 44975 [14:28:31] o_O [14:28:40] DanielK_WMDE: you willing to sort those out? [14:28:41] sorry, why are we backporting architectural changes? [14:28:43] don't cherry pick it [14:28:56] are you sure this is not already merged? [14:28:57] Denny_WMDE1: well, the branch is broken then [14:29:10] we don't know if this would fix the issue [14:29:13] i just said i suspectit [14:29:21] aude: willing to sort what out? the serializer stuff? i don't even know what that is or why we need it [14:29:23] basically because it had the word "serializer" [14:29:29] ah, nevermind that patch is in already [14:29:33] yes [14:29:39] it was not the culprit [14:29:49] aude, do you reproduce my error? [14:29:55] that one is quite old [14:30:02] i get a blank screen, yes [14:30:07] * aude looks at the error logs [14:30:18] DanielK_WMDE: you are on the branch as well, right? [14:30:25] do you also get an error, or does it work for you? [14:30:34] same issue [14:30:52] Class 'Wikibase\\Lib\\Serializers\\EntityContentFactory' not found [14:31:16] Denny_WMDE1, aude: the class is not registered with that namespace. [14:31:26] repo/Wikibase.php [14:31:27] 152:$wgAutoloadClasses['Wikibase\EntityContentFactory'] = $dir . 'includes/content/EntityContentFactory.php'; [14:31:39] odd [14:31:46] how'd that get in there [14:31:48] the autoloader only knows it in the Wikibase namespace, not in Wikibase\Lib\Serializers [14:31:59] aude: it's not the only place. [14:32:02] repo/tests/phpunit/includes/actions/ViewEntityActionTest.php [14:32:03] 8:use Wikibase\EntityContentFactory; [14:32:08] ^--- this one doesn't work either [14:32:08] DanielK_WMDE: do you also get the error? [14:32:32] Denny_WMDE1: i didn't try, i just grepped across the source for EntityContentFactory, and seeing inconsistent namespace use [14:33:01] let me ask again: why are we backporting this kind of thing at all? [14:33:11] we are *not* backporting it [14:33:13] it is already inside [14:33:14] backporting refactorings, moves, renames, and namespace changes are bound to cause no end of pain [14:33:21] i don't even know where to find the missing dependency or what not [14:33:25] yes, and we are not doing it [14:33:37] did we accidentally backport something we shouldn't? [14:33:42] that might be [14:34:32] New patchset: Jeroen De Dauw; "use strpos instead of deprecated in_string" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/49658 [14:34:35] hm... wait... [14:34:44] there is something else very wrong here [14:34:51] could https://gerrit.wikimedia.org/r/#/c/49647/ be the problem? [14:34:55] so, it works on pages without references [14:35:06] without statements [14:35:07] sorry [14:35:10] not lookign at it closely [14:35:18] oh? [14:35:31] aude: yes, it could be the error [14:35:35] my wiki works in general [14:35:45] but an item with a statement lead to the error [14:35:50] hmmm [14:35:54] i am just trying to add a statement to another item [14:36:08] Denny_WMDE1, aude: i think the mistake is the other way around. EntityContentFactory is not supposed to be in the Serializer namespace. But *something* is apparently looking for it there [14:36:17] can you give me a backtrace? or a hind how to reproduce?= [14:36:34] one sec [14:36:56] any item page with a statement [14:37:32] my guess: class X gove moved into the Serializer namespace, and still addresses EntityContentFactory without a prefix and without use statement. [14:37:43] that will look for that class in the Serializer namespace, and fail [14:37:55] http://pastebin.com/w7cHceJ3 [14:38:07] bingo [14:38:22] daniel@brightpad [mw1.21-wmf10] ~/www/wikidata/extensions/Wikibase> ack-grep EntityContentFactory lib/includes/serializers/ [14:38:24] lib/includes/serializers/SnakSerializer.php [14:38:25] 54: $entityContent = EntityContentFactory::singleton()->getFromId( $propertyId ); [14:38:27] lib/includes/serializers/ByPropertyListSerializer.php [14:38:28] 106: && EntityContentFactory::singleton()->getFromId( $propertyId ) === null [14:38:58] looks legit [14:39:07] i mean, looks like the right place [14:39:17] aude: you don't have stack traces?... anyway, i guess i found it. [14:39:26] http://pastebin.com/w7cHceJ3 [14:40:00] aude: a, sorry - couldn't see the stack trace buried in the log lines >_< [14:40:45] anyway [14:41:06] aude, Denny_WMDE1: just add "use Wikibase\EntityContentFactory" to those files, that should fix it. [14:42:27] i am done with claim diffs, except testing them and poke around for any potential issues with it [14:44:22] yes, looks good [14:44:27] i don't get the error anymore [14:44:36] i will make a patchset [14:45:06] orr. found another one. [14:45:09] PHP Fatal error: Class 'Wikibase\ClaimSerializer' not found in /DATA/var/www/daniel/wikidata/extensions/Wikibase/lib/tests/phpunit/serializers/ClaimSerializerTest.php on line 120 [14:45:25] Denny_WMDE1: i'm at it. i'll fix the other one too. [14:46:07] thx [14:46:21] i was already unnerving johl with git questions [14:46:41] I love git questions! [14:46:50] nothing unnerving about it! [14:46:53] now it's public.. [14:47:17] that I'm a gitophile? hardly a secret [14:48:27] * DanielK_WMDE made a pretty diagram to explain git last night. just as a mental excersize. should put it on wikipedia or something. [14:48:41] Denny_WMDE1: http://wheningit.tumblr.com/post/31693381964/when-i-use-git-stash [14:50:25] alright, back in a few minutes [14:51:26] New patchset: Daniel Kinzler; "Fix missing namespace declarations." [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49664 [14:51:50] Denny_WMDE1: https://gerrit.wikimedia.org/r/#/c/49664/ [14:52:53] DanielK_WMDE: the classic explaination of git is of course https://twitter.com/agnoster/status/44636629423497217 [14:54:13] pssst, what are the colors of the Wikidata logo? like the hex values [14:54:27] PinkAmpersand: check the SVG. [14:54:37] how do i do that? :/ [14:54:45] * PinkAmpersand is clueless with image stuff [14:55:08] New review: Daniel Kinzler; "Patch Set 5: Code-Review-1" [mediawiki/extensions/Wikibase] (claimdiffs) C: -1; - https://gerrit.wikimedia.org/r/49639 [14:55:43] johl: hehehe... i bet that it's correct :) [14:55:46] Hit view source on your browser of https://upload.wikimedia.org/wikipedia/commons/6/66/Wikidata-logo-en.svg [14:55:58] 990000 [14:56:02] 339966 [14:56:06] 006698 [14:56:16] text is 484848 [14:56:48] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49664 [14:56:50] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49664 [14:57:45] i think 006698 should actually be 006699. [14:57:52] these colors are the official wmf colors [14:58:19] hmmmm [14:58:29] duh, PinkAmpersand: https://wikimediafoundation.org/wiki/Wikimedia_visual_identity_guidelines#Color_specifications [14:58:44] should i update the logo on commons then? [14:58:56] i'd say yes, but ask Denny_WMDE1 [14:58:59] duh: are you a Commons sysop? [14:59:05] oh i'm not [14:59:21] file a bug about it :) [14:59:22] it's upload-protected [14:59:41] yeah i just saw that [15:00:27] it feels like we are almost there [15:01:29] Denny_WMDE1: too many too large packports in the last minute. scares me. [15:01:52] me too [15:02:06] i thought we'd only backport the changes serialization and autocomment stuff. where did all the other things come from? [15:02:25] which other things? there's only the terms table [15:02:28] anything else? [15:02:36] claim diffs, for example [15:02:46] no, claim diffs was on the list the whole time [15:02:51] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [15:03:00] o_O [15:03:10] hey, duh addshore James_F|Away Riley rschen7754|away, y'all mind if I add you to a list of Wikidatans willing to help resolve interwiki conflicts on en? [15:03:22] :/ so many pings [15:03:22] yes [15:03:23] PinkAmpersand: Sure [15:03:25] sure [15:03:36] * aude sees what happens when i delete a property [15:03:38] Denny_WMDE1: I'll stop whining now. [15:03:40] :o [15:03:59] (for those of you who are away, come yell at me later if you didn't want to be listed.) [15:05:37] Danwe_WMDE: does https://gerrit.wikimedia.org/r/#/c/49248/ need to be backported as well? [15:05:45] or else no correct message, right? [15:06:39] Denny_WMDE1: i think so [15:06:46] Denny_WMDE1: jes [15:06:48] yes [15:08:26] New patchset: Henning Snater; "(bug 44755) Show copyright warning when editing language terms" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49666 [15:08:28] Danwe_WMDE, PinkAmpersand: https://bugzilla.wikimedia.org/show_bug.cgi?id=45120 [15:09:03] duh: couldn't you just do that via a Commons edit request? [15:09:14] no because there are a lot more things that need to be updated [15:09:19] oh [15:09:46] and you cant just change a projects logo :P [15:09:57] pretty sure logos pull from bits.wikimedia [15:10:19] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [15:11:01] duh: I think you mean DanielK_WMDE [15:11:05] New patchset: Henning Snater; "(bug 44755) Show copyright warning when editing language terms" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49666 [15:11:16] Danwe_WMDE: oops sorry, [15:11:24] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=45120 [15:11:40] New review: Denny Vrandecic; "Patch Set 2: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49666 [15:11:41] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49666 [15:12:41] aude: which changeset? [15:12:56] https://gerrit.wikimedia.org/r/#/c/49639/ [15:13:20] i'm just trying deleting properties, items, anything else i can think of [15:13:30] but need someone to approve and review [15:13:31] PinkAmpersand: https://en.wikipedia.org/w/index.php?title=Template%3ASister_project_links&diff=538885853&oldid=536672105 [15:14:31] i dont fully understand all those parser functions [15:14:43] but what i did should fix most articles [15:16:39] duh: no, hadn't seen that. doesn't look good. [15:17:30] the bug doesnt look good? [15:18:04] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [15:18:11] duh: huh why the noincludes? [15:18:26] PinkAmpersand: i dont understand how it works do i tried to modify as little as possible [15:18:47] actually, it's fine. [15:19:10] well, looks like it should work for mainspace, at least [15:19:19] (since right now things *only* work for mainspace) [15:19:20] DanielK_WMDE: can you look at claim diffs again? [15:19:39] * aude tested it with deleted properties and items [15:20:33] PinkAmpersand: well non mainspace links using Special:Itembytitle are broken until that fix gets backported [15:20:50] yeah exactly [15:22:24] but it seems most people were specifyin the actual number [15:22:33] aude: seems to work in the browser, but ClaimDifferenceVisualizerTest fails with errors. [15:22:36] https://en.wikipedia.org/wiki/50_cent#External_links [15:22:45] ^that was the one i spotted which originally was broken [15:23:25] New review: Daniel Kinzler; "Patch Set 8: Code-Review-1" [mediawiki/extensions/Wikibase] (claimdiffs) C: -1; - https://gerrit.wikimedia.org/r/49639 [15:24:00] template look good? https://en.wikipedia.org/wiki/Wikipedia_talk:Wikidata#Interwiki_conflicts add yourselves, please, everybody. [15:24:25] duh: iirc, this will be deployed in a few hours [15:24:34] awesome :) [15:26:13] New review: Aude; "Patch Set 8:" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [15:26:47] i can fix the unit tests although they are barebones [15:27:52] broken unit tests make it hard to discover new bugs [15:28:03] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [15:28:03] done [15:28:03] true [15:28:21] should work now [15:29:59] aude: nope, i'm getting a fatal error now [15:30:14] PHP Fatal error: Call to undefined method Wikibase\ClaimDifferenceVisualizer::visualizeDiff() in /DATA/var/www/daniel/wikidata/extensions/Wikibase/lib/tests/phpunit/claim/ClaimDifferenceVisualizerTest.php on line 88 [15:30:34] ugh [15:30:45] * aude tries it [15:30:59] i'm using: php phpunit.php --group Wikibase --filter '/.*Diff.*/' [15:32:45] DanielK_WMDE: [16:24:24] duh: iirc, this will be deployed in a few hours << can you please check? because we really need to fix it and i am not sure it is actually in [15:32:52] (when you're done with katie [15:33:10] https://bugzilla.wikimedia.org/show_bug.cgi?id=44536 [15:33:36] New patchset: John Erling Blad; "(Bug 45013) Remove duplicate aliases" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49670 [15:35:05] DanielK_WMDE: i'm just commenting out that test.... it needs more rework adn to test stuff more fully [15:35:26] New patchset: Aude; "(bug 44095) enhanced claim diff visualizaion including refs" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49671 [15:35:27] New patchset: Aude; "Simple diff visualization" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49672 [15:35:27] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49673 [15:35:48] Lydia_WMDE: yep, it's in [15:35:50] DanielK_WMDE: ok, the patches are now https://gerrit.wikimedia.org/r/#/c/49673/ [15:35:58] DanielK_WMDE: cool - thx [15:36:02] try them against wmf10 (including the tests) [15:37:11] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [15:37:21] New patchset: John Erling Blad; "(Bug 45013) Remove duplicate aliases" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49670 [15:40:27] aude: the visualization is empty for commonsMedia properties [15:40:27] New patchset: John Erling Blad; "(Bug 45013) Remove duplicate aliases" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49670 [15:40:38] other than that, it seems to work [15:42:18] DanielK_WMDE: hmmm [15:42:28] i'll certainly keep poking at it for master [15:43:01] aude: can you confirm the issue? [15:43:32] New patchset: Daniel Werner; "SerializerFactory functions now take options as param and pass it to serializer" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49674 [15:43:32] trying [15:43:37] it might be a quick fix [15:43:43] Denny_WMDE1: can we deploy it with broken display for the commonsMedia type? [15:43:51] not great [15:44:30] i'd say yes for now [15:44:30] DanielK_WMDE: can you give more details [15:44:38] but i saw it working on audes machine [15:44:41] so i am a bit confused [15:44:44] it shows property / Flag [15:44:44] - [15:44:45] Flag of Germany.svg [15:45:10] yay [15:45:13] ok, maybe my test data is funky then [15:45:15] the patch 10 seems to work for me [15:45:16] might just be me [15:45:40] Denny_WMDE1: that would be patch set 1 here? https://gerrit.wikimedia.org/r/#/c/49673/ [15:45:54] that'S the version for the wmf10 branch [15:46:01] let me try that [15:46:19] maybe something differente between master and wmf10 [15:47:50] DanielK_WMDE: looks okay to me [15:48:00] i'm curious why the differnece [15:48:38] aude, Denny_WMDE1: found it. I was using a NoValueSnak in the revision I was looking at. [15:48:49] oh [15:48:55] we should render these as "no value" in cursive, or some such. [15:48:58] but that's not a blocker [15:49:02] let's go with this [15:49:07] more stuff to try :) [15:49:14] s/cursive/italics/ [15:49:18] yep [15:50:01] https://gerrit.wikimedia.org/r/#/c/49673/ [15:50:06] someone want to approve it? [15:50:14] and the two dependencies [15:50:53] i can verify that it works, but i havn't looked at the code much [15:51:07] i'll skim it, but i could use some help looking [15:51:18] i am looking at it too [15:51:24] and playing with it it looks good [15:51:39] let's give it a go so we can start the tests? [15:53:11] ok, i am merging it. we can still make a post-merge check. i hope i won't hate this day :) [15:53:23] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49671 [15:53:25] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49671 [15:53:46] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49672 [15:53:48] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49672 [15:54:14] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49673 [15:54:16] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49673 [15:54:24] merged it all [15:54:33] let's start with the tests [15:55:36] DanielK_WMDE: sure it needs more polish and tests for master [15:55:48] Denny_WMDE1: make sure to merge all dependencies. [15:56:00] i hope i did [15:56:10] aude: why does DiffView::generateAddOpHtml etc now use Html::rawElement? [15:56:11] this time [15:56:29] if the $value parameter is expected to be safe html, this needs to be documented! [15:56:41] that's from tobi's code but can look at it [15:57:32] aude: i'm seeing $this->generateAddOpHtml( $op->getNewValue() ) [15:57:36] so the value is not escaped. [15:57:44] mmmm. [15:57:52] this is an injection vector. [15:58:57] i dont' know if Html::element would work here [15:59:26] phpunit tests are running for wmf9 client and wmf10 repo: http://192.168.2.251:8080/job/wikibase-phpunit/169/console [15:59:36] thx AnjaJ_WMDE [15:59:41] keep us informed on the progress [15:59:46] aude: why not? the only difference is that the content is escaped. which is what we need here. [15:59:51] right [15:59:59] i don't know why it got changed but can change it back [16:00:02] and try it [16:00:22] we don't need to restart the tests for that backport [16:00:57] Denny_WMDE1: right. let's just make sure we have this right once we allow free text properties. [16:01:02] yep [16:01:17] currently, this isn't easy to exploit. but still possible, i think [16:01:31] i think it is not too hard [16:01:37] just put nonsense into a label [16:01:39] no? [16:01:41] phpunit tests: all ok :) [16:01:46] AnjaJ_WMDE: thx [16:02:04] aude: please check for simmilar issues in the files that were touched. and yell at tobi for me ;) [16:02:15] DanielK_WMDE: that's the main place [16:02:28] Denny_WMDE1: if that code is also used for labels... lemme try that [16:02:40] at least i'm trying to reduce duplication of this type of code and then we can get it *right* there [16:02:48] no, what i meant is that items are displayed using their label [16:02:59] i didn't mean for the label of the given item [16:03:03] but the one in the value position [16:03:09] yeah, looks like an issue .... [16:03:21] * aude tries a description [16:03:30] Denny_WMDE1: booom! [16:03:39] yep. can't have that. [16:03:46] :o [16:03:57] if it's broken, gotta fix it [16:04:29] aude: you fix it, i keep reading the code? [16:04:43] doing [16:07:34] New patchset: Aude; "Further work on claim diff visualization" [mediawiki/extensions/Wikibase] (claimdiffs) - https://gerrit.wikimedia.org/r/49639 [16:09:52] New patchset: Aude; "Escape diff output" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49677 [16:10:22] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/49677/ [16:11:28] aude: looks good on a first glance, could use a test case. [16:11:34] DanielK_WMDE: yes [16:14:30] UI team: 3 quint tests are failing http://192.168.2.251/wikidata-repo/index.php/Special:JavaScriptTest/qunit?filter=wikibase [16:14:42] Danwe_WMDE, Henning_WMDE ^^ [16:15:05] oh actually 5 are failing [16:15:34] New review: Jeroen De Dauw; "Patch Set 1: Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) C: 2; - https://gerrit.wikimedia.org/r/49677 [16:17:25] New review: Daniel Kinzler; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49677 [16:17:25] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49677 [16:17:34] aude, Denny_WMDE1: merged [16:17:41] DanielK_WMDE: thanks [16:19:05] http://192.168.2.251/wikidata-client/index.php/Special:JavaScriptTest/qunit?filter=wikibase [16:25:18] New review: Daniel Kinzler; "Patch Set 1:" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49671 [16:25:19] Test: Check functionality of blocking a user => check functionality of blocking a user => should login as blocked user and check he is blocked from item creation [16:25:20] Fils [16:25:22] fails [16:25:56] Test: Check edit-conflicts => check behaviour on edit conflicts (claims) => should login as user 1 again, inject old revid & complain about edit conflict when changing claim value [16:25:56] F [16:25:57] Test: Check edit-conflicts => check behaviour on edit conflicts (claims) => should login as user 1 again, inject old revid & complain about edit conflict when changing claim value [16:25:58] F [16:27:50] again: is there a bug in your bugzilla-system for the issue with IE8 and older? It was mentioned sunday in the office-hour... [16:28:02] lbenedix: i think so [16:28:38] https://bugzilla.wikimedia.org/show_bug.cgi?id=44228 ? [16:28:49] if that's the only issue then we should have fix for it deployed soon [16:29:20] ok [16:29:36] let us know if there still are problems after our code update [16:29:54] is the fix live on the test-system? [16:30:01] i think so [16:30:26] booting the xp-VM [16:31:43] btw: http://wikidata-test.wikimedia.de/Wikidata-logo-demo.png is still > 2000x2000px [16:32:14] :o [16:32:22] Silke_WMDE_: ^ [16:32:30] New patchset: Jens Ohlig; "(Bug 43066) Replace search box with item selector" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49263 [16:32:30] New review: Daniel Kinzler; "Patch Set 1:" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49672 [16:34:05] I mentioned that in november 2012 ;) [16:34:21] Test: Check functionality of add/edit/remove sitelinks => Check sitelinks UI => should check if an error is correctly displayed when the site API is inaccessible [16:34:22] F [16:34:43] editing lang-links is not working with ie8 in the test-system [16:35:34] New review: Aude; "Patch Set 1:" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49672 [16:35:56] DanielK_WMDE: i'll be splitting out the reference and snak formatting i think [16:36:01] diff formatting [16:37:03] neither on http://wikidata-test-repo.wikimedia.de/ and nor on http://wikidata-dev-repo.wikimedia.de/ [16:37:16] lbenedix: hmm [16:37:25] what's the lang code for armenian? [16:39:21] PinkAmpersand: hy [16:39:32] hy Sannita. sup? [16:39:44] oh. [16:39:51] lol. i thought you were saying "hi" [16:39:53] fail [16:39:55] PinkAmpersand: ehm... hi, but "hy" was the code :D [16:39:56] LOL [16:40:08] in retrospect, i should've pretended that was a joke [16:40:16] yep [16:40:22] you should have done that [16:40:27] LOL [16:41:53] too late to say this was *all* a joke? [16:42:14] dunno, I can pretend if you wish [16:42:16] :D [16:43:16] kk :D [16:44:33] lbenedix: A few more words concerning the logo would be helpful... What's the problem with it? [16:44:51] Denny_WMDE1: it's wgRightsUrl and wgRightsText that we want, right? [16:45:00] New review: Daniel Kinzler; "Patch Set 1:" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49673 [16:45:22] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/DataValues] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49658 [16:45:22] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/49658 [16:45:30] aude: commented on the diff visualization patches. there are some things that should be fixed before this goes into core. [16:45:33] Silke_WMDE_: it's 2000x2000px, it takes years to load with EDGE ;) [16:45:40] into master i mean, sorry [16:45:47] aude: no it is not [16:46:06] Silke_WMDE_: and its resized to 200x200px [16:46:20] there's a message called Wikidata-copyright which is used as the copyright message on Wikidata [16:46:23] lbenedix: is that a problem I have to fix NOW? [16:46:27] i am trying to figure out where it comes from [16:46:48] at the bottom: http://www.wikidata.org/wiki/Wikidata:Main_Page?uselang=qqx [16:46:54] Silke_WMDE_: its a problem i mentioned in november ;) [16:46:59] it is translated on translatewiki which is good [16:47:05] but i don't know where it is actually pulled in [16:47:29] Denny_WMDE1: ah, ok [16:47:39] think i know where it is [16:48:07] i bet it's in the config. [16:48:24] somethign used in a magic inline hook :) [16:48:31] i am looking through the config and cannot find it [16:48:41] the config of the live cluster? [16:48:50] well, the one in gerrit [16:49:10] hm... [16:49:24] got it [16:49:25] well, i don't see it in the wikibase repo for sure [16:49:36] aude: great, where? [16:49:38] it's in one of the custom extensions.... [16:49:43] WikimediaMessages [16:49:47] :P [16:49:50] remember reviewing a patch tehre before [16:49:53] ok, great, thanks [16:50:11] i think we can just submit a patch there with new text [16:50:25] i am still confused what other settings are needed [16:54:59] New patchset: Anja Jentzsch; "(minor) Define supports0Height in inputAutoExpand before it is first used." [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49683 [16:56:15] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49683 [16:56:16] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49683 [16:57:08] who can merge wikimedia-messages? [16:57:50] on firefox now [16:57:51] Test: Check functionality of client-repo connection => client-repo adding/removing sitelinks => should check if interwikilinks are shown correctly on client [16:57:52] F [16:57:53] Test: Check functionality of client-repo connection => client-repo adding/removing sitelinks => should check if interwikilinks lead to correct websites [16:57:53] F [16:58:00] Test: Check functionality of client-repo connection => client-repo check behaviour on changing connecting sitelink => should check that no sitelinks are displayed anymore on client [16:58:01] F [16:58:21] huh [16:58:28] Denny_WMDE1: probably reedy [16:58:47] aude: good [17:03:15] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49674 [17:03:16] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49674 [17:04:18] is there a termsofusepage message or sth similar? [17:05:14] no idea [17:05:23] probably [17:05:30] cant find it :( [17:05:50] do you see such thing on one of the wikis? [17:08:24] qqx [17:08:38] yep :) [17:10:56] no, i cant find it on other wikis either [17:11:16] well, that makes it difficult to find [17:11:57] that is why i asked if it even exists :) [17:12:16] i would ask phillippe [17:12:27] or James_F might know, maybe [17:12:44] Terms of use for WMF wikis? [17:12:57] yes, is there a specific message for that? [17:13:03] https://wikimediafoundation.org/wiki/Terms_of_Use [17:13:08] ah [17:13:14] Oh, a MW message? Not sure. [17:13:22] * James_F looks at the VE source. [17:13:49] i just see under the edit window "By clicking the "Save page" button, you agree to the Terms of Use, and you irrevocably agree to release your contribution under the CC-BY-SA 3.0 License and the GFDL. [17:13:53] You agree that a hyperlink or URL is sufficient attribution under the Creative Commons license." [17:14:13] standard language [17:15:07] did it get fixed that we link to the local copy of CC0 and not the one on creativecommons.org ? [17:15:17] Yes, that is . [17:15:39] Which obviously is insufficient for Wikidata. [17:15:59] And we'll need to update that on other wikis when Wikidata is editable through a local wiki. [17:17:31] yep [17:19:18] New review: Daniel Kinzler; "Patch Set 3: Code-Review-1" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/49066 [17:21:47] New review: Aude; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49653 [17:21:48] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49653 [17:22:38] New patchset: Aude; "Add check to see if we can test with Query class" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49686 [17:24:05] New review: Aude; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49686 [17:24:06] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49686 [17:24:57] this occurred again [17:25:00] 5) Check functionality of add/edit/remove sitelinks Check sitelinks UI should check if an error is correctly displayed when the site API is inaccessible [17:25:00] Failure/Error: page.wbErrorDiv?.should be_true [17:25:02] expected: true value [17:25:03] got: false [17:25:04] # C:/xampp/htdocs/wikidata-repo/extensions/Wikibase/repo/tests/selenium/sitelinks/sitelinks_spec.rb:88:in `block (4 levels) in ' [17:25:05] # C:/xampp/htdocs/wikidata-repo/extensions/Wikibase/repo/tests/selenium/sitelinks/sitelinks_spec.rb:71:in `block (3 levels) in ' [17:25:14] huh [17:25:29] one sec [17:26:06] New patchset: Henning Snater; "Using only the custom config in wikibase qunit test environment" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49687 [17:26:25] AnjaJ_WMDE: think we missed a cherry pick [17:26:28] * aude doing [17:31:11] aude: reedy: can you check https://gerrit.wikimedia.org/r/#/c/49688/ ? [17:31:22] (and merge?) [17:31:39] New patchset: Aude; "Make wbclient.linkItem experimental for now + non-JS fallback" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49689 [17:32:00] I can merge it if aude is happy with it [17:32:14] aude, can you check? [17:32:31] Denny_WMDE1: Reedy looks good [17:32:40] assuming.... [17:32:47] Hmm. I probably should go home before trying to run scap [17:32:51] that the message handles parsing wikitext [17:33:34] it does [17:33:38] New review: Aude; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49689 [17:33:39] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49689 [17:33:43] it's wrapped in a ()->parse [17:33:46] Denny_WMDE1: looks good [17:34:16] if we merge that, i have an evil merge for the branch [17:34:21] this needs to be done properly [17:34:24] i will set up the changeset [17:34:35] Denny_WMDE1: ok :) [17:34:41] (i hate it) [17:36:01] aude, Denny_WMDE1: going afk for the dinner routine. i consider myself "on call" for the deployment, but i'm not monitoring the channel. [17:36:50] ok enjoy [17:37:04] New review: Aude; "Patch Set 1:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49606 [17:37:26] * aude wonders about ordering food or waiting until i get home [17:38:03] aude: ask abraham to sponsor takeout for deployment night :) [17:38:09] heh [17:39:08] DanielK_WMDE: Do I get food sent too? :p [17:39:13] New patchset: Jens Ohlig; "(Bug 43066) Replace search box with item selector" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49263 [17:39:28] I tried to get Danese to order food for the remotes when the SF staff were being fed.. [17:39:47] :o [17:40:13] We wouldn't :( [17:40:23] err [17:40:28] We didn't get any :( [17:40:33] awww, booo [17:42:41] I'm gonna escape and drive home... [17:42:48] ok [17:42:55] should be online within an hour or so [17:43:00] alright [17:43:08] See how far scap gets running in a detached screen session.. [17:43:18] hopefully it should build but not push due to no key in the agent.. [17:43:20] heh [17:46:32] New patchset: Henning Snater; "(bug 44228) Using compatible css class option name in suggester" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49691 [17:50:02] New review: Anja Jentzsch; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49691 [17:50:03] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49691 [17:51:32] New patchset: Anja Jentzsch; "(bug 44228) Using compatible css class option name in suggester" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49692 [17:53:31] Hello. [17:53:56] who's about? [17:54:22] Hi [17:55:15] hey sven [17:56:09] hey [17:56:15] so ummm... http://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#Property:P31_.22is_a.22 [17:56:19] that... [17:56:35] Anyone here have any last minute objection to me deleting that? [17:56:44] yes [17:56:47] it needs to be orphaned [17:56:51] has anyone done that yet? [17:56:55] I was planning to [17:57:04] after I asked if anyone had any objections [17:57:06] New patchset: Aude; "Update copyright message for deployment" [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49694 [17:57:18] how many times has it been used? i would guess thousands [17:57:22] i support deletion though [17:58:05] New review: Denny Vrandecic; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49694 [17:58:07] Change merged: Denny Vrandecic; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49694 [17:58:28] legoktm / duh - how long would it take for you to whip up a bot to depreciate it? [17:58:48] I'm trying to figure out how to do that via the API... [17:59:26] aude: here is my apology in a bug for what I made you do right now: https://bugzilla.wikimedia.org/show_bug.cgi?id=45127 [17:59:49] Denny_WMDE1: i'll see how it can be done properly [18:00:08] might even be in the WikimediaMessages extension instead, to substitute one for another message [18:00:19] yes, i think that would be the right approach [18:00:23] make a hook in wikibase [18:00:29] that is called from wikimediamessages [18:00:30] sure [18:00:33] and replaces the message [18:00:41] so [18:00:48] are we ready for deployment? [18:00:58] think so [18:01:22] * Sven_Manguard puts on my deployment helmet [18:01:27] :D [18:01:48] :DDD [18:01:52] So are either of the possible extras you mentioned during office hours going live? [18:02:19] yes, one [18:02:29] what? [18:02:37] which?* [18:02:53] a table displaying the label and descriptions in other languages, given the logged in user has them set up with babel [18:04:18] sounds cool but not too high a priority [18:04:31] considering we have LabelsLister doing that [18:04:49] Sven_Manguard: Gadgets are not as good as the proper interface. [18:04:51] it was a weekend project [18:04:58] ah, k [18:05:05] it never was in our planned sprints [18:05:20] it's a cool feature [18:06:05] Sven_Manguard: aha! it is possible [18:06:09] just will require some work [18:06:29] also since the bot flagging thing wont work until deployment, it should wait a few hours [18:08:00] okay [18:08:12] feel free to run some tests though to make sure it works [18:08:48] Denny_WMDE1: What's the deployment timeline for today? This deployment helmet can get itchy. [18:09:05] Sven_Manguard: another hour [18:09:10] when reedy comes back [18:09:16] it starts in another hour?!| [18:09:21] * Sven_Manguard takes off the helmet [18:09:23] or sooner maybe [18:09:30] hm [18:09:31] * Sven_Manguard dusts it with talcum powder [18:09:35] heh [18:09:36] how do i get a list of pages using a property? [18:09:43] its not stored in the pagelinks table? [18:09:50] duh: you can use special:WhatLinksHere [18:09:57] it's not super elegant but works [18:10:07] right but where is it in the database? [18:10:10] it should be in the pagelinks table [18:10:28] mysql> select * from pagelinks where pl_from=3918489 limit 10; [18:10:28] Empty set (0.01 sec) [18:10:34] thats [[Property:P31]] [18:10:35] hmmm [18:11:06] New patchset: Henning Snater; "Using only the custom config in wikibase qunit test environment" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49687 [18:11:50] hmm. weird. [18:12:26] Oh [18:12:41] its backwards [18:12:44] mysql> select * from pagelinks where pl_namespace=120 AND pl_title="P31" limit 10; [18:12:49] 10 rows in set (0.01 sec) [18:12:58] ah [18:13:10] right that makes sense now [18:13:12] those pages are linking to it [18:13:15] its not linking to them [18:13:50] Sven_Manguard: fyi its in use 5496 times. [18:13:59] New review: Daniel Werner; "Patch Set 2: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49687 [18:14:01] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49687 [18:14:59] and 107 is in use 7k times :D [18:17:44] wtf [18:17:48] wbgetclaims requires a token? [18:18:31] duh: I don't even want to think about what we're going to have to do to clean up the states/provinces/cities/towns properties [18:18:49] heh [18:18:58] * aude not using those when editing items [18:19:12] is there a reason why it needs a token? [18:19:14] wonder how they will end up [18:19:19] otherwise ill submit a patchset for it [18:19:41] duh: JeroenDeDauw might know better [18:20:08] because it technically only requires read writes, but you cant get an edit token without edit rights. [18:20:19] * aude nods [18:20:54] jeblad might also know but he's not around at the moment [18:21:02] Sven_Manguard: after deployment, it will be very easy to orphan properties [18:21:13] all it requires is the id [18:22:40] cool [18:22:52] {u'claims': [u'q4115189$E80EFEB3-4B14-4E23-942A-D561FCF3ECD3'], u'pageinfo': {u'lastrevid': 6889413}, u'success': 1, u'warnings': {u'main': {u'*': u"Unrecognized parameter: 'bot'"}}} [18:23:06] huh? [18:23:07] https://www.wikidata.org/w/index.php?title=Q4115189&diff=6889413&oldid=6888591 [18:23:08] * Sven_Manguard headsplodes [18:23:09] muahaha [18:23:48] it would be nice though [18:23:54] if rather than just mass removing [18:24:00] we could replace it with the right property [18:24:05] but i dont think that is going to be possible [18:24:26] duh: not by bot, no [18:25:24] it would probably take a few weeks to do that manually [18:25:32] personally i think we have better things to do :P [18:26:18] New patchset: Jeroen De Dauw; "ApiGetClaims does not support a token param" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49699 [18:26:26] There you go [18:26:52] :D [18:27:05] New review: Legoktm; "Patch Set 1: Code-Review+1" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/49699 [18:28:32] http://192.168.2.251/wikidata-repo/index.php/Special:JavaScriptTest/qunit?filter=wikibase [18:35:45] oh, Denny_WMDE1 just an FYI, we've got a running count of the properties that have been approved for creation but don't have the datatype for, it's at http://www.wikidata.org/wiki/Wikidata:Property_proposal/Pending [18:36:33] figure you'd want to know where the project is moving in the near future [18:37:04] btw Sven_Manguard, did you ever see Magnus's genewiki tool? [18:37:16] yes, but I've no idea what it means [18:37:21] lots of pretty lines though :D [18:37:28] its parsing wikidata for family trees [18:37:42] multichill expanded it [18:37:44] https://toolserver.org/~multichill/ts2/geneawiki/?q=Q3044 [18:37:59] a few bugs though [18:38:13] New review: Daniel Werner; "Patch Set 3: Code-Review-1" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/49263 [18:38:26] Sven_Manguard: cool [18:38:31] Test: Check functionality of Contributions special page => check for label and ID on Contributions => should check if label and ID are displayed and link leads to the correct item [18:38:32] F [18:38:44] we are working on our timeline for the next few weeks and will communicate it as soon as we feel comfortable with it [18:41:02] ok i am heading home to be available from home for deployment [18:47:08] New review: Aude; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49699 [18:47:09] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49699 [18:48:02] I'm home, but now being sent out to get food [18:48:08] Deployment will be a bit delaaayed [18:48:09] ok [18:48:19] Scap pushing message changes for test2 is now running [18:48:44] ok [18:48:58] Reedy: it's okay, Denny is in transit [18:49:10] before we do anything, we need denny's change to WikimediaMessages deployed [18:49:52] otherwise, no new settings today, no schema changes, etc. [18:53:53] Sven_Manguard: anyways, script is ready, just poke me when you want it run [18:54:25] I guess as soon as Denny clears that the change has been made [18:55:03] its also a smart script, so if someone adds it once its started, itll keep removing it :P [18:56:44] which change? [19:01:02] deployment [19:01:48] I meant which specific change sven needs fit his script [19:02:40] hmm? ok, legoktm's script. we're depreciating the "is a" property [19:03:00] IrcDroidClient: right now anythign to do with claims doesnt support being marked as bot [19:03:08] so a mass script to do that would flood RC [19:03:46] ah, Ok. thx [19:05:05] maybe change the label of is a to is a (deprecated) [19:12:37] and Denny_WMDE is back [19:13:17] Denny_WMDE: aude: Reedy: /puts on deployment helmet/ Let's do this! [19:13:27] and by "let's [19:13:29] " [19:13:37] I mean you all, since I can't code for shit :D [19:14:39] is Reedy back from dinner? ;) [19:14:55] oh, right, he has to go get food... [19:15:05] if he's US based it's probably lunch [19:15:11] he's not [19:15:18] AnjaJ_WMDE: are you a dev? [19:15:57] one could say so, but mainly I am responsible for qa here [19:16:01] I'm here [19:16:05] yay [19:16:05] If you are, http://www.wikidata.org/wiki/Wikidata:Project_chat#Rollbackers - we probably have consensus to create that user right [19:16:18] :o [19:16:36] alright before anything, we need WikimediaMessages updated [19:16:58] do I assume rightly that https://gerrit.wikimedia.org/r/#/c/49691/ is not live on dev or test? [19:17:12] I'll do that as part of your updates before I switch wikidatawiki if you want? [19:17:27] lbenedix: probably not [19:17:30] Sven_Manguard: lets just have that go through the normal means with bugzilla, theres no rush [19:17:33] Reedy: ok [19:17:44] lbenedix: it should be on dev [19:17:53] duh: but i hate filing bugs.... [19:18:13] lol its easy. [19:18:29] i just think we should let the proposal be open for more than 24h [19:18:56] its been like…4? [19:18:59] if it is live on dev, this bug is not closed: https://bugzilla.wikimedia.org/show_bug.cgi?id=44228 [19:20:26] For anyone about, feel free to poke testwiki, test2wiki and mediawikiwiki [19:20:31] lbenedix: it is fixed and I will ask Henning_WMDE to close the bug [19:20:33] ok :) [19:21:07] AnjaJ_WMDE: i tested it 3 hours ago, and its not working [19:21:15] it was merged an hour ago [19:21:20] Reedy: No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php. [19:21:23] on test2 [19:21:29] whaaa [19:21:37] * aude not surprised [19:21:52] mediawiki.org is fine :/ [19:21:56] it's back [19:21:57] i'll try again [19:21:57] phew [19:21:58] https://test2.wikipedia.org/w/index.php?title=New_York_City&action=edit [19:22:42] Wonder if you hit a dodgy apache [19:22:46] could be [19:25:57] i have seen missing messages during scap before [19:26:06] it's usually just a fluke [19:26:08] * aude too [19:26:23] aude's link works half the time, half not [19:26:36] 2013-02-18 19:25:03 mw1185 mediawikiwiki: [584dd7f5] /wiki/Special:WhatLinksHere/MediaWiki Exception from line 441 of /usr/local/apache/common-local/php-1.21wmf10/includes/cache/LocalisationCache.php: No localisation cache found for English. Please run maintenance/rebuildLocalisationCache.php. [19:26:37] DAMN IT [19:26:41] hmmm [19:27:23] same old same? [19:29:36] https://gerrit.wikimedia.org/r/#/c/49706/ would be the commit point for the extensions [19:29:49] * aude waiting for jenkins to say it's a good patch [19:30:42] Reedy: ^ no hurry and once everything else is good [19:33:09] aude: Should we really check for the WB_EXPERIMENTAL_FEATURES constant in the production files? [19:33:21] I thought the separate files should be used [19:33:28] (re to https://gerrit.wikimedia.org/r/#/c/49606/1/client/WikibaseClient.hooks.php) [19:33:31] hmmm [19:34:09] I did it in https://gerrit.wikimedia.org/r/#/c/49606/1/client/config/WikibaseClient.experimental.php [19:34:19] that's the right way [19:34:29] for the hooks, not sure [19:34:57] I left it commented out as it's only temporary (so that it's easier to restore) [19:35:04] that's fine [19:35:13] Did you talk to Denny_WMDE about the roadmap for it, btw? [19:35:15] although i can't try it in experimental mode :( [19:35:28] probably tomorrow or wednesday [19:35:38] aude: You have to set the constant before including the extension... that's wrong in Vagrant [19:35:50] * eg. [19:35:51] hoo: you are right [19:36:10] * aude has not used vagrant but jens (johl) or silke would know more how to fix it [19:36:18] someday i'll poke at it [19:36:58] I'd fix it myself but the vagrant is managed on github and I've never contributed to a github project which I couldn't push to directly [19:37:46] i think you just do a pull request but it's a bit different than gerrit [19:38:05] hoo: fork it, push your your copy [19:38:13] then go to the web gui and hit the "pull request" button [19:39:23] duh: Mhm, sounds doable... I'll have a look by the time I got time :P [19:39:52] push to your copy* [19:40:02] it seems complicated, but is super easy [19:40:50] There are more things I wanted to do [19:42:07] seems we are waiting to make sure the localisation caches are okay [19:42:13] hoo: No world domination tonight. kthx [19:42:29] The set of things I want to do and the set of things I actually have time to do are (sadly) rather different :P [19:48:32] duh: as an ideal future candidate, what are your thoughts on http://www.wikidata.org/wiki/Wikidata_talk:Requests_for_permissions#Open_ended_bot_approval [19:48:39] aude: Do you know where I can find the wikibase database layout description? [19:48:50] hoo, aude: using WB_EXPERIMENTAL_FEATURES to skip registration of stuff we don't want in production is the preferred way. [19:48:51] multichill: it's on metawiki [19:48:58] Meta? Wtf [19:49:00] Sven_Manguard: ill take a look [19:49:01] multichill: as a current candidate, what are your thoughts on http://www.wikidata.org/wiki/Wikidata_talk:Requests_for_permissions#Open_ended_bot_approval [19:49:06] meta.wikimedia.org/wiki/Wikidata/Development [19:49:09] but it's fine to check that in production code, too, if there's no simple way to avoid that. or to double-check. [19:49:13] DanielK_WMDE: Sure... but check for that cont. within the production files [19:49:21] or use the special exp. files? [19:49:27] * constant [19:49:37] DanielK_WMDE: agree [19:49:57] hoo: as i saif: in the special file is preferred, but there's no big problem with doing this in production files too. [19:50:11] it's more convenient, and more secure, sto simply no register stuff we don't want in production [19:50:40] I guess the way I did it now is fine as it's not going to last for long (hopefully) [19:51:14] Sven_Manguard: I'm used to the nlwp and Commons when it comes to bots. A bot flag is a statement of trust. Don't break the wiki. [19:51:27] hoo: since it's in experiment, that's good [19:51:30] oh hi multichill! [19:51:35] experimental [19:51:36] long time no see [19:51:48] * multichill has been a bit busy [19:51:56] i'm used to the enwiki way in where you have to get everything approved, but i like commons way of doing it much better [19:52:18] I was just looking for a good old database table description [19:52:38] multichill: i've been using "describe table" on the toolserver lately and just figuring my way around [19:52:48] i havent figured out how to get claims though [19:53:04] multichill: the key thing is the json blobs [19:53:08] I was raised on Wikipedia, where some bot ops need more careful watching than others [19:53:16] those are the entities [19:53:18] duh: I was looking for a page like https://www.mediawiki.org/wiki/Manual:User_table [19:53:47] multichill: i dont think anyone has written that seeing as the API docs are still missing [19:53:47] hmmm...... don't think we have such a wiki page for the extension tables [19:54:12] In what table can we find the claims aude? [19:54:26] multichill: in no table [19:54:49] multichill: data items are stored as json structures. claims are part of that structure [19:54:52] they are currently not indexed [19:54:53] the json blobs [19:55:03] yes, no nice way to query yet [19:55:03] they will be, for phase 3, but at the moment, they are not. [19:55:08] Ok, just like pages [19:55:11] yes [19:55:14] exactly [19:55:19] crap [19:55:29] multichill: full claim IDs have the form $ [19:55:32] yeah that would be nice [19:55:41] so you always know which entity blob to look into. [19:55:48] http://www.wikidata.org/w/api.php?action=wbgetentities&sites=enwiki&titles=Berlin&languages=en&format=json [19:55:51] for example [19:55:55] multichill: what are you trying to do? [19:56:07] that's pretty much what you find a blob [19:56:44] aude: internal and external representations are quite different. [19:56:44] I've been inserting parent->child info into the database. I wondered if I could easily extract the whole tree structure to play around a bit [19:56:51] DanielK_WMDE: somewhat [19:56:57] I was planning on writing a query that found items where P106=person, but the gender property isnt set. [19:57:02] multichill: when we have phase3, then yes. but not yet. [19:57:16] https://www.wikidata.org/wiki/Special:Contributions/BotMultichill [19:57:52] So everyone should be a child of https://www.wikidata.org/wiki/Q3044 . Just wondering how to confirm that :-) [19:58:08] ah [19:58:37] Father/Mother -> = <- child etc [19:59:26] DanielK_WMDE: Are you also looking into how to enhance search based on data in wikidata? [20:00:00] aude: Updated code synced to wmf10. Scap running now [20:00:16] deploy! :D [20:00:46] :9 [20:00:48] * :) [20:00:51] :D [20:01:03] * duh puts Sven_Manguard's deployment helmet on his head [20:01:26] ahh, I didn't shake out the talcum powder first :S [20:01:53] Sven_Manguard: Seen a ghost? [20:02:28] yes, the ghost of my perfectly maintained hair just flew by, crying and pointing at legoktm angrily [20:02:51] legoktm? who's that? [20:03:08] no one important :P [20:06:15] when is the next time we are going to try git-deploy again, anyway? [20:08:31] so we're still on wmf9, though the extensions are updated on wmf10 [20:08:43] the next step would be to switch wikidata to wmf10 [20:08:46] * aude waits.... [20:09:41] but core is still wmf= [20:09:44] wmf9? [20:10:22] * aude confirms wmf10 test2wiki works with wmf9 repo :D [20:10:36] :) [20:10:39] good [20:20:21] New review: Anja Jentzsch; "Patch Set 4: Code-Review-1" [mediawiki/extensions/Wikibase] (master) C: -1; - https://gerrit.wikimedia.org/r/49641 [20:20:58] wait all extensions got updated? [20:21:10] duh: not yet [20:21:14] we are still on wmf9 [20:21:19] oh ok [20:21:29] * aude clicked around before realizing that :D [20:22:40] DanielK_WMDE: In what table can i find https://www.wikidata.org/wiki/Special:WhatLinksHere/Q215627 ? [20:23:08] multichill: pagelinks? [20:23:12] lol [20:23:18] indeed [20:23:18] Is it normal pagelinks? [20:23:22] yes [20:23:22] yep [20:23:30] It's on normal WhatLinksHere ;) [20:23:52] heh [20:24:02] multichill: hehe, smart guy :) but that tabgle lacks the info which property links the items. [20:24:19] yeah [20:24:19] might be good enough, depends on what you need, i guess [20:25:19] Yeah, so in the case of https://www.wikidata.org/wiki/Special:WhatLinksHere/Q53117 I just know it's a relative, but now what kind [20:25:51] * DanielK_WMDE is waving around, pointing at https://bugzilla.wikimedia.org/show_bug.cgi?id=43780 [20:26:05] multichill: yes. [20:26:18] multichill: you could however then selectively load the json data and look. [20:26:38] depending on how much data you want, that might be feasible [20:30:46] most popular properties: http://dpaste.de/s7hgV/raw/ [20:31:56] duh: use the wb_terms table to add labels [20:32:13] http://www.wikidata.org/w/api.php?action=wbgetentities&sites=enwiki&titles=Baldwin_V,_Count_of_Flanders&languages=en&format=json <- did I just find myself a bug? ;-) [20:32:21] duh: ...if the toolserver has that. [20:32:23] (api should accept _ as speacase) [20:32:26] *spaces [20:32:33] multichill: yes. [20:32:41] DanielK_WMDE: it does, thanks! [20:33:42] oh hm. [20:33:49] so many languages. [20:34:02] Existing or do I need to file a new one? [20:36:02] DanielK_WMDE ? [20:37:01] multichill: filed https://bugzilla.wikimedia.org/show_bug.cgi?id=45131 [20:37:22] duh: english would be sufficient for now :) [20:38:09] Ah, ok. Something else. q333384$F46BAA70-64B6-4D75-9897-A142C2853D0B is something hex right? Is that case sensitive? [20:38:13] yup using that. [20:38:43] If not, you might want to do some normalization there too (reminds me of a nasty SHA160 bug we had in the api coupld of weeks ago) [20:39:08] multichill: it's case sensitive (for now) [20:39:17] we could do normalization. it's hex, it's robust against that [20:39:21] 1.21wmf10 is live on wikidatawiki [20:39:23] same for the "q" prefix [20:39:37] Reedy: for core, I assume? or wikidata also? [20:39:42] err, wikibase, i mean? [20:39:42] Both [20:39:47] oh, yay! [20:39:57] go poke at it, everyone :) [20:40:05] * DanielK_WMDE goes afk and chuckles [20:40:57] yay :D [20:41:02] thanks Reedy [20:41:11] and everyone else who wrote the code :) [20:41:15] https://www.wikidata.org/w/index.php?title=Q2511421&diff=6899061&oldid=6899042 [20:41:19] yay [20:41:36] Ah, edit summaries! [20:41:54] Now I just need to figure out to add something useful to it with the api [20:42:13] https://www.wikidata.org/w/index.php?title=Q446711&curid=421484&diff=6898876&oldid=970931 <- awesome [20:42:25] :D [20:42:29] aude: are the summaries autoset? [20:42:30] | DB Name | DB Size in GB | [20:42:30] +--------------+-----------------+ [20:42:30] | wikidatawiki | 23.397903442383 | [20:42:31] Ooh [20:42:33] can i override them in the api? [20:42:35] duh: they are [20:42:39] ask DanielK_WMDE [20:42:46] he just went afk :/ [20:42:57] i dont see a parameter for it so i guess not [20:42:59] DanielK_WMDE: We want to override edit summaries! ;-) [20:43:00] they are somewhat basic so far [20:43:05] oh well [20:43:09] as long as i can &bot [20:43:12] duh: yes, you should be able to override it [20:43:15] * duh removes all his manual throttles [20:43:16] :o [20:43:21] is it &summary ? [20:43:23] heh [20:43:35] not sure, but sounds good [20:43:35] multichill: some api modules may support an undocumented summary parameters, try it :P [20:44:10] multichill: no guarantee that it will keep working, though [20:44:15] well, they should always be in the self-describing api description [20:44:26] Denny_WMDE: not listed there [20:44:28] multichill: btw, i have been thinking about way to automatically add item descriptions... [20:44:35] ...from categories. [20:44:36] hmm, then they don't exist i guess [20:44:40] pity, i thought we had that [20:45:05] DanielK_WMDE: have you seen https://www.wikidata.org/wiki/User_talk:Legoktm#bot_descriptions ? [20:45:47] Denny_WMDE: if only i could just code for a couple of days :P [20:45:58] WARNING: API warning (main): Unrecognized parameter: 'summary' [20:45:59] oh well [20:46:18] DanielK_WMDE: heh. feel the same :) [20:46:34] DanielK_WMDE: Summary has no effect [20:48:00] that new popup for when I edit, that makes me confirm that I'm releasing under CC0, that's annoying [20:48:16] thankfully I have banished it [20:48:24] Sven_Manguard: it's one time [20:48:31] lawyers demanded it [20:48:32] mhmm [20:48:37] orly? [20:48:40] that seems odd [20:48:45] unlike wikipedia, there's no notification about copyright [20:48:50] no edit window [20:49:32] yeah, sorry, it is annoying [20:50:10] how did the "In other languages" thing pick up what languages i set in my babel? [20:50:16] because thats cool [20:50:29] well, i put a function in babel that provides that [20:50:39] and wikidata checks if babel is around [20:50:39] hm [20:50:41] and then asks it [20:50:42] minor bug [20:50:46] just one? :) [20:50:47] when hitting remove [20:50:48] Autocomment::pickValuesFromParams( $params, 'property' ), nope, that won't work [20:50:58] it says "hit save" [20:50:59] lol [20:51:00] There's a link at Special:NewPropery that goes to Special:PropertyDisambiguation, a redlink [20:51:02] ill file a bug [20:51:46] gna [20:51:51] i did that [20:51:56] my fault. daniel had it right [20:51:59] i know how to fix it [20:52:17] but not tonight [20:52:57] duh, did you see that the request for apihighlimits was approved already? [20:53:02] i did! [20:53:09] goodie :) [20:53:10] i'm just working on a few code optimizations [20:53:17] sure, no rush [20:54:06] Denny_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=45134 super minor :P [20:54:59] Do you know if any statistics exist on the number of articles with and without a wikidata link? [20:55:48] on what language [20:56:09] enwp or any other? [20:56:11] you could try compare {{NUMBEROFARTICLES}} and a COUNT(*) on wb_items_per_site where site="enwiki" or something [20:56:45] I know how to do it, I just hoped someone else already did it ;-0 [20:57:08] ah, dont think so :/ [20:59:38] * multichill waits for the query killer [20:59:52] Reedy: thx! aude DanielK_WMDE anja henning danwe abraham — thx for the last minute work today! [21:01:00] Is everything look alright? [21:01:07] as far as i see [21:01:20] yep, so far yes [21:01:23] are the logs quiet? [21:01:37] yup [21:01:41] yay! [21:01:52] select COUNT(*) from wb_items_per_site WHERE ips_site_id='nlwiki' LIMIT 10; -> 1093707. Total: 1,149,634 = 95% [21:02:00] That's a lot! [21:02:50] not all pages are articles though [21:03:00] but yeah that is [21:03:08] I guess it also contains categories and other things [21:03:11] multichill: IT'S OVER 9000! [21:03:37] 9000 what? [21:04:43] Reedy? [21:05:03] nevermind ;) [21:05:20] duh: enwp 1968367 [21:05:26] :o [21:05:29] we're behind [21:05:43] multichill: how long are the queries taking? i can stick them in a database report [21:05:56] 1 row in set (1 min 35.05 sec) [21:06:12] You should but these things in a rrd too [21:06:19] rrd? [21:06:58] Like http://en.wikipedia.org/wiki/RRDtool [21:07:19] no clue how to do that. [21:07:22] You make things like http://toolserver.org/~bryan/stats/replag/ [21:07:26] but yeah, that would be cool [21:07:30] actually wikidata has more content pages than en wikipedia since a few days [21:07:36] (not surprising) [21:07:38] Win [21:07:49] yeah but were trying to figure out how many pages are covered [21:08:08] ah sorry [21:08:08] lots [21:08:11] now i se [21:08:13] just half [21:08:15] :-/ [21:08:17] multichill: is there an easy way to set up rrd's? [21:08:21] Denny_WMDE: You've got a long way to match enwikis 732.010650634766 GB database :D [21:08:46] that's good :) [21:08:47] i can look into it after midterms probably [21:08:57] duh: Not sure, haven't done that for a while [21:09:16] I can't believe that Wikipedia still fits on a 1TB external hard drive... [21:09:22] Should probably have a simple manual how to grab data from the database, put it in a rrd file and make pretty graphs [21:09:45] Sven_Manguard: less if you don't include things like ANI and AfDs [21:09:56] Sven_Manguard: easily. i downloaded the latest dump, it was around 700 MB [21:10:02] ah forget it [21:10:06] wrong context again [21:10:08] it's late [21:10:19] i am going to the shop to get some food and drink [21:10:22] Denny_WMDE: this is not a serious issue now, but will be later on in the project's lifespan. The more statements a page has, the longer it takes to load. [21:10:22] see you later [21:10:42] Eventually pages with 40 statements are just going to take 5 minutes a piece to load [21:10:49] Reedy: is that a challenge to fill the db as quick as possible? ;p [21:10:57] Sven_Manguard: that would be terrible [21:11:28] Denny_WMDE: everything loaded much faster before statements, and I definately see a correlation between load time and number of statements [21:12:21] and I'm on bloody fast university internet [21:12:34] http://en.wikipedia.org/wiki/Worldwide_LHC_Computing_Grid , that's big data ;-) [21:14:28] uhoh [21:14:31] my bot crashed [21:14:32] pywikibot.data.api.APIError: internal_api_error_MWException: Exception Caught: No handler for model 'wikibase-query'' registered in $wgContentHandlers [21:14:45] duh, do you know anything about setting up a wiki family on different subdomains? [21:14:51] there's a note in the guide to watch out for it [21:14:58] but the note is in smartese [21:15:09] Sven_Manguard: is it actually load time that's high, or perhaps the JavaScript which needs time to initialize the editing UI? [21:15:16] http://www.mediawiki.org/wiki/Manual:Wiki_family - if you have a minutes :D [21:15:17] Ajraddatz: you should try asking Isarra, she worked on setting it up for uncyclopedia [21:15:24] ok, thanks [21:15:41] Danwe_WMDE: Javascript maybe? I get the circle with the eight lines that indicates loading times [21:15:47] oh wait [21:15:52] my bot was trying to safe a normal page [21:16:15] wtf. [21:16:47] Sven_Manguard: So, fast internet won't really improve that, only a fast machine might. But there is still lots of potential for performance improvements in our JavaScript [21:18:12] duh: by the way, this is my helmet http://imgur.com/OuyHb [21:18:23] ahaha [21:18:24] alright, back in ~an hour [21:18:26] that seems so you. [21:20:08] you've never even *met* me! [21:20:14] allegedly [21:20:28] Danwe_WMDE: http://imgur.com/hG1VwdB <-- That [21:20:35] that's where the slowdown is [21:20:40] is that the js? [21:21:07] yeah thats js [21:21:18] its finding out the localized names for what you're looking at [21:21:20] https://www.wikidata.org/w/index.php?title=Q39054&diff=6902183&oldid=492620 <- lol [21:21:38] haha [21:21:50] the new double click is going to reduce vandalism i bet [21:22:52] Has anyone thought of getting Twinkle to start working here? [21:23:02] * Jasper_Deng now thinks vandalism warning templates are in order [21:23:04] Sven_Manguard: yes, it is [21:24:00] Sven_Manguard: in the background you can see the non-JS UI, while the spinner is spinning, the JS UI will be built locally on your machine [21:24:08] ok [21:24:10] i think theres a bug [21:24:12] in editing via API [21:24:16] my bot cant save normal pages [21:25:46] https://bugzilla.wikimedia.org/show_bug.cgi?id=45136 [21:25:58] Sven_Manguard: I'm disappointed that you recommending deleting P31's deletion, and more so that no-one mentioned it to me and I just spotted it in the RfD page. :-( [21:26:21] James_F: its on WD:PC and on Prop talk:P31... [21:26:22] it's so broad that it's unusable [21:27:11] duh: And watchlisting doesn't work very well. Pinging the creator's user talk page in normal on other wikis, and it should start to be for us for non-trivial ones (i.e., not for [[Qxxxx]]s). [21:27:22] Sven_Manguard: It's a super-type. [21:27:35] Sven_Manguard: That's like saying [[Category:Person]] is so broad that it's unusable. [21:28:00] no, the definition of what P31 should be used for is so broad [21:28:07] www.wikidata.org/w/index.php?title=Wikidata:Project_chat&curid=394&diff=6902601&oldid=6901873 <--- hold your horses PinkAmpersand [21:28:07] 117 is at least constrained [21:28:14] Sven_Manguard: So fix it? [21:28:15] the proposal is less than 24 hours old [21:28:26] Sven_Manguard: It specifically says (said) not to use it except sparingly. [21:28:39] Jasper_Deng: i just said that :P [21:28:41] 5500 uses is not sparingly [21:28:45] Sven_Manguard: 107 is laughably trivial. [21:29:03] Sven_Manguard: So people have been abusing it, instead of educating users your solution is to break the ability of Wikidata to express concepts? [21:30:12] Sven_Manguard: Tell me how P107 will let me label Canada as a country. Or Monarchy of the United Kingdom as an office of head of state? Or ... [21:31:01] Sven_Manguard: And P107 shouldn't have been created until restricted-item types were supported in the software. [21:31:36] James_F: you mean never? because Denny_WMDE is rather insistent that that will never happen [21:31:46] we do not plan to support restricted item types... [21:31:50] Oh. [21:31:52] Why not? [21:32:35] cause there are almost always exceptions, and a better suggester would do the same job, but without restricting [21:32:49] and implementing a better suggester is trivial [21:33:00] just count how often which item is used for a property [21:33:02] Denny_WMDE: OK, a restricted-but-overrideable item type. :-) [21:33:06] and suggest that by frequency [21:33:27] that would be imaginable, but i think a suggester makes the need for that moot either [21:34:15] I suppose once the property is created, we wouldn't be able to adjust its restriction, so yes. [21:34:51] also, i don't want to have people fighting what useful fillers for "gender" would be... [21:35:30] Denny_WMDE: Well, actually, stopping people setting "gender" when they mean "sex" would be very helpful, but I guess we'll just have to create a bot to do it. :-( [21:36:30] Sven_Manguard: Anyway, my point about P31 stands. P107 is a nice start at a small area underneath P31, but it's not a replacement. [21:36:37] i also like p31 [21:36:39] a lot [21:36:40] Reedy: is https://bugzilla.wikimedia.org/show_bug.cgi?id=45136 something that is set in localsettings.php? [21:36:44] but no one cares :P [21:36:49] because my bots are all stalled [21:36:53] We set nothing in LocalSettings [21:36:59] or commonsettings [21:37:02] Denny_WMDE: Feel free to comment. :-) [21:37:09] Presumably Wikibase should do it [21:37:20] 'wikibase-query'' [21:37:22] that looks weird [21:37:27] duh: ouch [21:37:39] that's a proper bug [21:37:47] some missing backports [21:37:47] it has some urgency.... [21:37:49] darn [21:38:37] any ideas? [21:38:44] [21:37:47] some missing backports [21:39:29] :/ [21:39:33] can we figure out what they are? [21:39:58] i am more surprised that the wikibase-query code is ever touched [21:40:23] does this happen whenever you use the api to save a normal page? [21:41:55] only on normal pages [21:42:10] my bot can set properties and stuff [21:42:18] i bet it can do langlinks too [21:42:35] but editing any wikitext page is broken [21:42:43] and only via API. [21:43:04] a bit weird [21:43:12] trying to reproduce it locally [21:44:12] do you want me to test it on other wmf10 wikis? [21:45:59] no [21:46:04] it's a wikidata issue [21:46:07] ok [21:46:16] you wont get the issue on other wikis [21:47:50] Jasper_Deng_away: yeah yeah. didn't notice how recent it was [21:49:19] duh: oh, weird [21:49:22] i cannot reproduce it [21:49:25] locally [21:49:36] can you reproduce it on www.wikidata.org? [21:49:40] i'll try on wikidata.org [21:49:46] wait [21:49:58] god bless the api sandbox [21:50:49] :) [21:50:55] yes, i can reproduce it there [21:51:06] :( [21:51:19] * Lydia_WMDE waves from home [21:52:17] hey Lydia_WMDE [21:52:35] hi Lydia_WMDE :) [21:53:18] everything still in order i see \o/ [21:54:42] duh: it is a bit unfortunate that i cannot reproduce the bug locally. Reedy can you check if there is anything in the logs? a stacktrace might be useful [21:55:06] i guess duh or I can reproduce it anytime, if you need more signals :P [21:55:12] :) [22:01:34] Denny_WMDE, aude: i dropped out when the fun started. can you point me to a description of the issue? [22:01:58] go not-logged in here: [22:01:59] http://www.wikidata.org/wiki/Special:ApiSandbox#action=edit&format=json&title=User%3ADenny&text=Test&token=%2B%5C [22:02:03] Don't think it's gonna be much use.. [22:02:12] i cannot reproduce it locally [22:02:18] jeroen is also looking into it [22:02:28] probably some dependency missing [22:02:34] http://p.defau.lt/?yz7Q9wf8kM_XsN59F0nYMg [22:03:10] wtf? [22:03:15] query stuff should be marked experimentakl [22:03:21] it shouldn't run in production [22:04:31] ah, i see [22:04:45] Reedy, Denny_WMDE, aude: we might be able to fix this with a config hack [22:04:47] hold on [22:04:47] well it is the same as with properties. they should never be called because you cannot create them yet [22:05:03] Scary [22:05:43] Reedy: what setting do we have for entityNamespaces? [22:05:59] remove anythng related to queries from that array, then we should be fine. [22:06:22] that's wgWBSettings['entityNamespaces'] [22:06:35] aude: that's probably why you can't reproduce it [22:06:55] hm... [22:06:59] one thing is odd, though [22:07:03] QueryHandler does exist [22:07:21] ah, but it's probably not registered [22:07:39] back [22:08:01] ah, but it's probably not registered [22:08:03] repo/config/Wikibase.experimental.php [22:08:04] 55:$wgContentHandlers[CONTENT_MODEL_WIKIBASE_QUERY] = '\Wikibase\QueryHandler'; [22:08:07] hm... [22:08:19] could it be that we are running experimental code for some reason? [22:08:26] ? [22:08:28] ? [22:08:33] Reedy: please also check the contents of $wgContentHandlers [22:08:35] i dount that a lot [22:08:38] doubt [22:08:43] I suspect the WMF config contains the registration which we are only doing in exp mode [22:08:47] hm... [22:08:53] Something like $wgWBRepoSettings['entityNamespaces'][CONTENT_MODEL_WIKIBASE_QUERY] = WB_NS_QUERY; [22:08:54] Denny_WMDE: i think you are right. [22:09:03] Where can we see the WMF config? [22:09:04] basically, the issue seems to be inconsistent config [22:09:09] ye [22:09:17] http://p.defau.lt/?soYQpOu3GU6yxhfzHkbLRQ [22:09:19] there is a namespace assigned for queries, but no content handler (because it's experimental) [22:09:28] yep [22:09:39] Reedy: yea, that's good. [22:09:42] reedys var dump has not queries [22:09:56] Reedy: can you give me $wgWBSettings['entityNamespaces'] ? [22:10:16] ["wikibase-item"]=> [22:10:16] int(0) [22:10:16] ["wikibase-property"]=> [22:10:16] int(120) [22:10:16] ["wikibase-query"]=> [22:10:18] int(122) [22:10:19] JeroenDeDauw: my thought exactly, yes [22:10:26] cba pastebinning that ;) [22:10:34] Reedy: kill that wikibase-query entry, and the issue is fixed [22:10:48] Where's it set? [22:11:03] it's somewhere in the config. may be using Query::ENTITY_ID instead of the litteral, in case you want to grep [22:11:10] err, ENTITY_TYPE, sorry# [22:11:13] can override it [22:11:21] commons settings [22:11:22] aude: depends on where it is set [22:12:02] i wonder how that setting got there :/ [22:12:25] I also wonder how to protect against that. [22:13:48] DanielK_WMDE: $wgWBSettings['entityNamespaces'][CONTENT_MODEL_WIKIBASE_QUERY] = WB_NS_QUERY; [22:13:55] wouldn't it be enough to kill htat line? [22:15:24] Change on 12meta_wikimedia a page Wikidata was modified, changed by Eloquence link https://meta.wikimedia.org/w/index.php?diff=5255209 edit summary: [+139] more prominently link wikidata.org, slight reorder [22:15:38] hoo: yes, if you can find it, tell Reedy [22:16:47] DanielK_WMDE: Reedy: We have gerrit for conf. these days: https://gerrit.wikimedia.org/r/49784 [22:17:07] lolol [22:17:15] Reedy: ? [22:17:16] long live svn [22:18:25] is that deployed now, the change? [22:19:17] (i don't fully know how git is connected to the actual config) [22:19:28] Denny_WMDE: Needs to be deployed per hand using scap [22:19:39] Reedy is probably doing that just now [22:20:31] " 22:20 logmsgbot: reedy synchronized wmf-config/CommonSettings.php " [22:20:48] works now [22:20:54] duh can you reproduce? [22:21:01] trying [22:21:05] testing* [22:21:47] it works for me via apisandbox [22:22:15] DanielK_WMDE: hoo JeroenDeDauw aude thanks for the late night fixing [22:22:22] awesome works :) [22:22:25] thank you everyone :DDDDD [22:22:32] i am off to sleep [22:22:36] g'night! [22:22:44] You're welcome ;) [22:23:52] should i mark the bug as resolved? [22:24:37] duh: yes please :) [22:25:13] and thanks to Reedy [22:25:37] done :D [22:26:49] https://www.wikidata.org/wiki/Wikidata:Database_reports/Popular_properties [22:26:55] New review: John Erling Blad; "Patch Set 4:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49641 [22:27:26] lol highway system is 1344 [22:27:38] hmmm. so query namespace is now proper wikitext pages? [22:27:49] can we block creating pages there? [22:28:16] rschen7754: sad that we have more highways than brothers. [22:28:16] or we'll have to move any pages (hopefully none) before we allow queries [22:28:30] aude: we can use title blacklist i guess. [22:28:32] duh: and that's only about 1/10 of the US roads project :) [22:28:39] duh: that would be good [22:29:29] are querypages created in the normal fashion? ie is the right hook called? [22:29:30] New review: John Erling Blad; "Patch Set 4:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49641 [22:30:52] duh: now they are [22:30:54] https://www.wikidata.org/wiki/Q4885851 [22:31:00] aude: ok ill add the entry in [22:31:01] they will be like entity pages (items, etc.) [22:31:09] duh: at the moment, they are regular wiki pages, so yes. [22:31:27] that's the reason the setting was there but obviously it [22:31:32] is a problem now :o [22:31:48] duh: well we must make highway system #1! :) [22:31:56] muahahaha [22:31:58] denny wanted the namespaces reserved from the beginning [22:32:00] rschen7754: i give you full permission to abuse the bot. [22:32:08] aude: because the content type is derived from that, and the handler for that type is experimental [22:32:22] nasty edge case [22:32:29] we should handle this more nicely [22:32:31] obvious now [22:34:59] hm [22:35:14] well it wont display a warning to users will it? [22:35:23] er to sysops* [22:36:01] maybe abusefilter would be better here? [22:36:11] article_namespace=something [22:36:40] not sure [22:36:55] well it said i could create the page Query:Hi [22:37:00] so not sure [22:37:13] i know abusefilter hits everyone so [22:37:33] hoo probably knows [22:37:37] https://www.wikidata.org/wiki/Query:Hi [22:37:43] just created it... [22:37:47] heh [22:37:54] :/ [22:38:09] if it's deleted, that's fine [22:38:15] aude: Sorry, didn't follow... what's the question? [22:38:16] or moved [22:38:31] hoo: whats the best way to prevent all users from editing the Query: namespace? [22:38:37] titleblacklist doesnt warn sysops [22:39:12] abusefilter would work, but i dont like using abusefilter for non "abuse" things. [22:39:27] it's the edit filter :) [22:39:32] duh: tbl and AF on top for sysops [22:40:51] edge case: The various global groups running out there [22:41:26] We have vars for those as well, but checking those sounds like overkill to me [22:41:28] can we just abusefilter for everyone then? [22:41:37] article_namespace=something [22:41:39] duh: do we have a bugzilla for the confirmed usergroup? [22:41:40] trigger warning [22:41:43] rschen7754: yes [22:41:46] ok [22:41:55] patch is in gerrit [22:41:58] duh: Sure, that's going to work... not exactly what AF is for, but it obviously works [22:42:03] and we can show a nice warning [22:42:21] https://www.wikidata.org/wiki/MediaWiki:No-query-yet [22:42:59] duh: s/Should not/Can not/ [22:43:02] or must not [22:43:12] impossible basically [22:44:44] !nyan [22:44:44] ~=[,,_,,]:3 [22:44:44] !nyandata [22:44:45] https://bit.ly/nyandata [22:45:02] * hoo LOLs [22:46:30] https://www.wikidata.org/wiki/Special:AbuseFilter/9 [22:46:47] best runtime on a filter ive seen :P [22:47:41] duh: Dunno if that's the integer for the NS... looks fine, though [22:47:47] i checked [22:48:06] https://wikidata.org/w/api.php?action=query&meta=siteinfo&siprop=namespaces [22:48:17] thanks duh and hoo [22:48:23] np [22:48:28] duh: ok it rejected my edit [22:48:33] :D [22:48:34] duh: Looks fine to me ;) [22:49:25] uh-oh... [22:49:50] Changed the message a bit, hope you're fine with that [22:49:59] duh: just broke something :( [22:50:08] what broke? [22:50:27] lolwat [22:50:44] oh isee [22:50:46] i know why [22:50:51] i was able to create a page in another namespace and move it into query :P [22:50:52] because moved pages have different variables [22:51:04] and then i had to disable the filter to delete it [22:51:06] agh, damn [22:51:08] you could have just moved it back and deleted. [22:51:09] hmm, when i "slurp" and import links, it now populates British and Canadian English labels :o [22:52:19] duh: move vars are the same as title vars, but are prefixed with MOVED_TO AFAIR [22:52:20] so there's a translation namespace too? [22:52:27] just in case you want to expand the filter [22:52:29] hoo: yeah [22:52:38] nah its too much of an edge case [22:52:40] rschen7754: yes [22:52:49] i found that out by fiddling with the translate extension [22:53:04] it's in the move box too [22:53:47] https://wikidata.org/w/api.php?action=query&meta=siteinfo&siprop=namespaces [22:53:52] all of them :) [22:54:22] heh [22:55:00] also, [22:55:06] there are a TON of cities in Kansas. [22:55:08] and Iowa. [23:03:48] rschen7754: for inputting multiple properties to category, what do you think of the syntax: |P106=Q1000 ? [23:05:06] sure, possibly [23:05:48] any other ideas? [23:06:41] yeah, it seems fine [23:08:37] ok, that should make it like 2x faster [23:08:47] it cuts down the number of API calls a lot [23:09:02] how soon will this be implemented? [23:09:15] once i finish my CS homework due in 2 hours :P [23:09:21] lol [23:09:39] on a holiday? [23:09:44] I HAD CLASS TODAY [23:09:53] haha lol [23:09:55] >.< [23:11:04] * duh is still pissed about that [23:14:57] rschen7754: oh but doign that would break the /row template on the talk and archive pages... [23:15:07] yeah, that's why i was asking... [23:15:09] :/ [23:15:35] is lua coming to wikidata? lol [23:15:47] what about something like |p1=P106|q1=Q123|p2=P31|q2=Q234 ? [23:16:04] i can do that [23:27:52] woo, hack [23:28:00] back* [23:28:05] * duh hacks up Sven_Manguard  [23:28:10] I mean.. [23:28:13] glad you're back!