[01:09:17] Strange, The translate extension deletes a page, then says there was a problem [01:11:00] It looks like Ajraddatz deleted it seconds before me [01:22:27] https://www.wikidata.org/wiki/Special:Contributions/BlueDJCat050 [01:22:29] ooo [01:28:50] Git him blocked for a day, and we have a new one, http://www.wikidata.org/wiki/Special:Contributions/108.32.197.251 [01:28:54] *Got [01:31:30] at least we're getting most of the bots fixed for wikidata [01:31:39] and this isn't becoming like the huwiki launch [01:32:40] buonasera [01:32:58] ciao [02:49:19] question: are there any bot frameworks for working on Wikidata, or are all of the bots running now custom-made (i.e. not so customisable)? [03:37:02] Pink|TV: errr probably :P [03:49:49] Pink|TV: fixed [03:57:57] New patchset: Hoo man; "Make wbclient.linkItem more user friendly" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48997 [03:58:41] New review: Hoo man; "Patch Set 2:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48997 [04:00:04] * hoo made it worse :P [04:02:02] New patchset: Hoo man; "Make wbclient.linkItem more user friendly" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48997 [04:02:40] New review: Hoo man; "Patch Set 3:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48997 [06:01:16] New patchset: Legoktm; "(bug 44857) Add default ApiModifyEntity params to ApiSetClaimValue" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [06:01:29] if you cant find someone to fix your bug…you fix it yourself :P [06:11:14] New patchset: Legoktm; "(bug 44857) Add default ApiModifyEntity params to claim modules" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [06:12:30] New patchset: Legoktm; "(bug 44857) Add default ApiModifyEntity params to claim modules" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [06:13:03] which one is this? [06:13:14] when setting claims, you cant mark the edit as a bot [06:13:21] oh [06:13:35] i *think* what i did will fix it [06:26:35] is sb able to remove the en-sitelink on http://wikidata.org/wiki/Q4357191 ? [06:26:47] ill try [06:27:00] no... [06:27:08] maybe theres a duplicate? [06:27:54] how can a duplicate prevent removing the sitelink? [06:28:05] the en article belongs to http://ceb.wikipedia.org/wiki/Rhodacarellus [06:28:25] because it wont let you save the page if a sitelink is already in use [06:28:47] but normally it tells you what sitelink is in use [06:29:01] try deleting and undeleting it? [06:30:42] my last try to remove the sitelink was succesful [06:31:17] wow NJ fell out of the top 5 [06:32:12] rschen7754: hm? [06:32:20] the leaderboard [06:32:27] which leaderboard...? [06:32:27] oh, wrong channel :P [06:32:29] :P [06:37:33] New review: John Erling Blad; "Patch Set 3: Code-Review-2" [mediawiki/extensions/Wikibase] (master) C: -2; - https://gerrit.wikimedia.org/r/49205 [06:39:05] :o [06:39:14] hm [07:37:28] New patchset: Legoktm; "(bug 44857) Add &bot param to ApiCreateClaim and ApiSetClaimValue" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [07:38:22] New review: Legoktm; "Patch Set 4:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [07:38:25] lol [07:38:31] how about the watchlisting bug? :P [07:39:17] which one is that? [07:42:32] where you can't watchlist an item you create or edit automatically [07:43:14] bugzilla link? [07:44:26] https://bugzilla.wikimedia.org/show_bug.cgi?id=41573 [07:47:14] Hm [07:47:52] if you can't don't worry about it, it's just annoying :P [07:48:57] well [07:49:12] I'd have to figure out how user prefs are set [07:49:19] or fetched [07:49:21] oh :( [07:49:36] and i'm kinda lazy right now [07:49:40] maybe one day i should figure this mediawiki thing out and do some coding [07:49:42] since that bug doesnt really bother me :P [07:49:59] its not that hard [07:50:09] i dont know php either [07:50:18] i did php about a year ago [07:50:23] but it wasn't that complicated of a system [07:50:38] hacking on extensions is much easier than hacking on core [07:50:45] how do you test though? [07:51:05] normally for other extensions, i have a testwiki running on my laptop with vagrant [07:51:12] i havent been able to test this patch yet [07:51:24] https://github.com/wikimedia/mediawiki-vagrant [07:52:11] hm ok [08:21:04] New review: John Erling Blad; "Patch Set 4: -Code-Review" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [08:31:51] New review: Legoktm; "Patch Set 4:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [08:32:08] New patchset: Legoktm; "(bug 44857) Add &bot param to ApiCreateClaim and ApiSetClaimValue" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [09:04:35] New patchset: Tobias Gritschacher; "(bug 44095) enhanced claim diff visualizaion including refs (DNM)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [09:11:58] New patchset: Daniel Kinzler; "Document configuration settings." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49030 [09:16:19] New review: Daniel Kinzler; "Patch Set 3:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49030 [09:39:19] Jeblad_WMDE: https://gerrit.wikimedia.org/r/#/c/49211/2 [10:30:19] New review: John Erling Blad; "Patch Set 5:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [10:31:58] New patchset: Daniel Kinzler; "Rename Autocomment class to Summary" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49219 [10:33:29] Change abandoned: Daniel Kinzler; "Abandoned in favor of I315d884e38e44e. More to follow." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/47716 [10:35:33] New review: John Erling Blad; "Patch Set 1:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48484 [10:35:52] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48484 [10:35:54] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48484 [10:42:35] New patchset: Tobias Gritschacher; "(bug 44095) enhanced claim diff visualizaion including refs (DNM)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [10:47:43] New review: John Erling Blad; "Patch Set 4:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45574 [10:47:52] New patchset: Legoktm; "(bug 44857) Add &bot param to API modules that are missing it" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [11:06:56] New patchset: Tobias Gritschacher; "(bug 44095) enhanced claim diff visualizaion including refs (DNM)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [11:08:06] JeroenDeDauw: can I haz review again plz? https://gerrit.wikimedia.org/r/#/c/48459/ [11:09:35] New review: John Erling Blad; "Patch Set 6: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49205 [11:09:36] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49205 [11:11:49] New review: John Erling Blad; "Patch Set 2:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45336 [11:16:23] New review: John Erling Blad; "Patch Set 2:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45336 [11:29:34] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48815 [11:29:35] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48815 [11:32:12] removing aliases is not possible atm (like few hour ago) [11:32:20] :o [11:33:14] Merlissimo: where? [11:33:26] * aude can remove aliases on wikidata.org [11:33:36] i tried to remove two aliases at http://wikidata.org/wiki/Q1747026?uselang=de [11:33:38] Hi. [11:33:44] Merlissimo: use www.wikidata.org [11:34:02] we're having known issues when the "www" is not there in your url [11:34:03] Could I ask basic question on wikidata or it should be only for advanced topic here? [11:34:16] Zil: please ask :) [11:34:36] Well, I'd just click the Edit links from en.wp [11:34:43] yes [11:34:48] I add a link but it doesn't seem to appear. [11:35:01] aude: with www it is ok [11:35:07] Zil: it may take a few minutes for the change to appear [11:35:19] Ok. [11:35:22] can you give a link --- either enwiki or wikidata for what you edited [11:35:46] But I have to manually add it on the other projects or it will be added by the bots ? [11:35:55] eventually we will have a widget on wikipedia itself for editing the links and that will take care of purging the wikipedia page [11:36:00] so the links will appear immediately [11:36:19] Ok. It has appeared now... [11:36:21] https://en.wikipedia.org/wiki/Mireia_Miró_Varela [11:36:25] you can also add ?action=purge to the wikipedia page to see the links immediately, ahead of our synchronization script [11:36:33] Ok. [11:36:41] Zil: the bots will eventually get to it, although they are adapting to wikidata [11:36:52] aude: Ok. [11:37:30] seems to have worked now [11:37:46] if you purged it or our script processed it [11:37:52] So in this example... it is normal that I've got in the source code only the wikis to ca.wp and de.wp ? [11:38:08] that is fine [11:38:28] i assume bots will eventually come around to remove the local links in the wikitext or you can do that [11:38:42] having both is not a problem but the ones in the wikitext override the ones in wikidata [11:38:48] in case they are different [11:39:16] Ok. but missing ones in the source will be displayed from wikidata... [11:39:24] Zil: yes [11:40:13] So in this situation, either I don't bother anymore or I could add interwiki on fr.wp... [11:40:45] sure, either way works i think [11:40:51] not sure how quick the bots will be [11:40:54] Cool. [11:41:30] alright, i'll be back in a half hour or so.... [11:41:34] Ok when will it be diployed on more projects ? [11:41:38] feel free to come here with more questions [11:41:40] deployed [11:41:51] tentatively the first week of march [11:41:51] Thanks aude. [11:42:07] assuming no performance or other issues appear before then [11:42:12] but everything looks fine so far [11:42:25] ok [11:42:36] back in a bit... [11:47:25] New patchset: John Erling Blad; "Revert "Set 1 hour timeout for entities cached on the client."" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49221 [11:49:46] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49221 [11:49:47] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49221 [11:52:35] rschen7754: around? [11:55:13] New patchset: Daniel Werner; "(minor) added radix parameter to parseInt in inputAutoExpand" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49222 [11:58:30] DanielK_WMDE: you around? [12:33:41] New review: Daniel Kinzler; "Patch Set 1: Code-Review-2" [mediawiki/extensions/Wikibase] (master) C: -2; - https://gerrit.wikimedia.org/r/49219 [12:47:55] New review: Jeroen De Dauw; "Patch Set 1: Code-Review+1" [mediawiki/extensions/Wikibase] (master) C: 1; - https://gerrit.wikimedia.org/r/49068 [13:32:55] New patchset: Tobias Gritschacher; "(bug 44095) enhanced claim diff visualizaion including refs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [13:44:23] New patchset: Daniel Werner; "(minor) Define supports0Height in inputAutoExpand before it is first used." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49222 [13:47:24] DanielK_WMDE: you there? [13:56:29] i can't add descriptions [13:56:49] whenever i want to add one, >>An error occurred while trying to perform save and because of this, your changes could not be completed.<< comes [13:57:14] and in de-mode Beim Speichern ist ein Fehler aufgetreten. Die Änderungen konnten daher nicht vollständig durchgeführt werden. [13:58:34] MiladA380: try with "www", see also http://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Changes_of_an_item_can_not_be_saved_when_on_.22wikidata.org.22_.28without_.22www..22.29 [13:59:11] thx [14:00:53] New review: Jeroen De Dauw; "Patch Set 11:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [14:03:21] Stryn: thx - and sorry for the trouble with this :/ hopefully we'll have this figured out soon [14:06:29] yes, this is a frustrating problem, hope it will be fixed soon [14:22:12] really wrong edit summary: http://www.wikidata.org/w/index.php?title=Q615&diff=6598327&oldid=6598222 [14:30:10] New patchset: Daniel Kinzler; "(bug 41163, 44165, 44166) autocomments for claims." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49238 [14:34:14] Jeblad_WMDE: back now, what's up? [14:34:26] I sent an email on the list [14:34:49] I merged and then revoked your changeset [14:34:51] =) [14:34:57] * Jeblad_WMDE is evil today [14:35:17] DanielK_WMDE: we need to update tests to account for deleted revisions when coalescing [14:35:19] But it doesn't seems to be that changeset that causes the breakage [14:35:24] * aude poking at them [14:35:55] Whoever fixes this, remerge the changes when everything works =) [14:35:56] Jeblad_WMDE: well, if that changeset wasn't the problem, then revoke the revoke :) [14:36:03] Jeblad_WMDE: but anyway - what exactly is the problem? [14:36:07] They do fail [14:36:09] you just say "client is broken" [14:36:54] Jeblad_WMDE: what fails? when? where? how? [14:36:57] Yes there aree a list of erroirs in the reveoke changeset [14:37:29] Five errors and it is the same code path as the other changeset [14:37:43] DanielK_WMDE: can we haz tests for deleted revisions :) [14:37:45] Jeblad_WMDE, aude: aaaaahhhh! [14:37:46] ? [14:37:54] I'll not revoke the revoke before it merges without failures in the tests [14:37:56] aude: sure, go ahead :) [14:38:00] it throws an exception and the tests don't like it [14:38:08] needs to test for that [14:38:15] q [14:38:28] Tests that print warnings will fail hard.. [14:38:34] Failed to load revision 1111 of q1 [14:38:35] Jeblad_WMDE, aude: as far as I see, the patches don't break anything. The "deleted revisions" patch triggers an explicite warning though, that would have been silent before [14:38:42] and that makes the tests fail [14:38:56] if it takes me more than another 30 minutes or so to make a patch, then i'd like help [14:39:01] it's worth investigating what exactly is happening, but i think it's just the tests that are broken [14:39:09] it is just the tests [14:39:14] Well I'm not gonna merge something that reports errors [14:39:53] * aude goes back to coding [14:40:14] we obviously need this fixed before i can review next patch for change serialization, but maybe it won't take too long [14:40:15] Jeblad_WMDE: the issue is I3a29b3b7dfe7363e28e0c9a9d42f15d7c854e41c - it should have also fixed the test. but it's already merged, so we need a new change to fix this., [14:40:19] That was what my email was about, it reports erros, and whatever the cause it should be fixed [14:40:23] Jeblad_WMDE: the other patch is unrelated, i think [14:40:39] yep [14:41:00] I merged, got errors on master, and then revoked [14:42:24] aude: poking now [14:42:37] ok [14:43:00] i think the tests both need to account for the warning [14:43:19] Jeblad_WMDE: you would also have gotten these errors on master before merging that. in fact, there were already in the nightly jenkins mail yesterday, denny showed me. [14:43:20] 2) be adjusted for test cases with item deleted changes [14:43:48] * DanielK_WMDE just forgot about those [14:44:17] Yes, I was on an older patchset when I run tests before I tried the last one [14:44:48] That doesn't chang that I merged, doublechecked the master, found errors and reverted [14:46:18] Jeblad_WMDE: master was broken when you merged. no reason to revert what you merged. but whatever. just remember to put it back, please. [14:46:38] Jeblad_WMDE: you could make the revert-revert, but not submit it yet. makes sense? [14:47:16] I would like the tests to pass on client before I do anything more ;) [14:47:24] New patchset: Tobias Gritschacher; "(bug 44095) enhanced claim diff visualizaion including refs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [14:47:30] New review: Tobias Gritschacher; "Patch Set 11:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48459 [14:48:31] hey Silke_WMDE_ [14:48:48] hi [14:48:52] if you are around, I am hunting down cronspam, and was told you are the one to talk to about the wikidata labs instances [14:48:58] do you manage those? [14:49:03] yes [14:49:06] nice [14:49:18] ok, the jobs producing output (which is one email every 1-2 minutes) are: [14:49:31] Cron sudo -u www-data /usr/bin/php /srv/mediawiki/extensions/Wikibase/lib/maintenance/pollForChanges.php --since "yesterday" >> /var/log/wikidata-replication.log [14:49:45] Cron sudo -u wikidata /usr/bin/php /srv/devclient/w/maintenance/runJobs.php >> /tmp/runJobs.log [14:49:53] Cron sudo -u wikidata /usr/bin/php /srv/testclient-en/w/extensions/Wikibase/lib/maintenance/pollForChanges.php --since "yesterday" >> /var/log/en-wikidata-replication.log [14:50:03] the output (in case you care, it's pretty meaningless) is [14:50:12] No entry for terminal type "unknown"; [14:50:20] using dumb terminal settings. [14:50:29] what? [14:50:37] anyways the thing is that any output to stderr/out from any cron job goes to all of ops' mailboxes [14:50:39] ooooppppssss.... [14:50:43] erm... do you get these emails from our servers? [14:51:02] so if you could just capture that (and pass this on to other folsk you know with instances) [14:51:07] all our mailboxes will thank you [14:51:08] aude: ChangeHandler.php, line 149. That should not be there. that was a test. [14:51:11] * DanielK_WMDE hides in shame. [14:51:31] yeah it's a side effect of labs not being able to do the usual 'mail to the owner' mechanism, that feature isn't there yet [14:51:41] DanielK_WMDE: ah, ok [14:51:43] aude: ....and.... flawless! [14:52:05] apergos: If I redirect the output into a log file why does it send e-mails at all??? [14:52:10] stderr [14:52:16] o_O [14:52:19] if you add MAILTO="" at the top of your cron, all mails will go to that address [14:52:20] gotta do both stdout and stderr [14:52:22] its what i did [14:52:22] Lydia_WMDE: Poke poke.. check the doc [14:52:23] * Silke_WMDE_ hides in shame, too [14:52:29] DanielK_WMDE: i'd also put \ [14:52:30] apergos: I will [14:52:33] $parent = $parentRevId ? $this->entityLookup->getEntity( $entityId, $parentRevId ) : null [14:52:34] ..and the messages on the right bar [14:52:35] duh did you actually get mail? [14:52:38] after the ( !$entity ) [14:52:40] apergos: yeah i did [14:52:43] ah sweet [14:52:44] Jeblad_WMDE: thx! [14:52:51] :D [14:52:52] locla email or remote? [14:53:05] er it went to my gmail if thats what you're asking [14:53:10] and it worked? ok then [14:53:18] aude: shouldn't matter, but yea [14:53:27] DanielK_WMDE: just noticed that [14:53:28] (I saw a recent whine where there was some sort of cross realm mailing issue but if it's working then perfect) [14:53:40] no point in doing entity lookup there if there is no entity [14:53:51] even for the parent, since it will fail [14:53:57] Silke_WMDE_: thanks for taking care of it :-) [14:59:13] DanielK_WMDE: FYI, what's in wmf9 is good and passes tests [15:05:28] New patchset: Daniel Kinzler; "Fix ChangeHandler and ChangeHandlerTest." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49241 [15:05:50] aude: *phew* [15:06:08] ok, patch is up. and the patch for the autocomments is also up. [15:07:33] is there anything i can do to get the robust serialization thin in? [15:09:48] DanielK_WMDE: thanks [15:09:56] now i can review your other patch [15:11:35] duh Do you mean that I could have my cron output em-ailed to an address outside labs? [15:11:46] yes [15:12:02] * Silke_WMDE_ wants that [15:12:03] :) [15:12:04] my cron currently goes to my gmail address [15:12:08] cool [15:12:09] though somehow it got marked as spam :P [15:12:10] nice [15:12:16] haha [15:13:58] Silke_WMDE_: echo "yourmail@yourplace.com" > ~/forward [15:14:13] Silke_WMDE_: at least, that's the old school way. i'd hope that it still works on labs [15:14:20] err, that should be ~/.forward [15:14:27] read "dot forward" [15:15:02] thanks [15:15:21] this is so lovely and 80s :P [15:15:55] New review: Aude; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49241 [15:15:56] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49241 [15:16:38] New review: John Erling Blad; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48985 [15:16:39] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48985 [15:17:11] * Silke_WMDE_ is trying to spam herself [15:17:54] New review: John Erling Blad; "Patch Set 1:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49073 [15:18:28] the 80s weren't all bad [15:18:30] http://www.classicrockforums.com/forum/f49/top-100-rock-songs-80s-8420/ [15:19:15] :) [15:22:40] Reedy: would it be possible to move the update of the wikidata.org repo-extension from monday to wednesday? there are a few features that we would like to test a bit more [15:23:15] that would be nice [15:23:27] * aude scrambles to arrange all the backports [15:23:34] :) [15:26:19] apergos: DanielK_WMDE: For cronspam, the 80s way doesn't work, the MAILTO duh described works. [15:27:03] New patchset: Aude; "Fix ChangeHandler and ChangeHandlerTest." [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49246 [15:27:21] let me know when you've set them all up [15:27:28] then I'll watch my inbox for a few mins [15:27:31] New review: John Erling Blad; "Patch Set 1:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48997 [15:32:51] Denny_WMDE: sure, it doesn't make much difference to me [15:33:04] Do you still want to go to wmf10 on monday? [15:33:13] Reedy: thanks, that would be great to move. [15:33:20] I'd rather keep them in sync, if possible [15:33:27] so on wmf9? [15:33:34] just because we havent tested the extension wmf9 with core wmf10 [15:33:37] i don't see a problem with wmf10 core on monday, but [15:33:45] same time we've not tested stuff together [15:33:55] agree with Denny_WMDE [15:33:59] That's fine [15:34:03] thanks [15:34:06] ok, then let's move [15:34:22] i would change it in techwiki but i dont have the rights yet [15:34:23] :( [15:34:27] i did get my account though :) [15:34:32] i'll send an email [15:34:33] Denny_WMDE: huh? [15:34:40] I can fix wikitech rights [15:34:41] you should be able to edit wikitech [15:34:56] that would be great [15:35:00] i am Denny WMDE [15:35:09] New patchset: John Erling Blad; "Make wbclient.linkItem more user friendly" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48997 [15:35:14] is there a step after making an account for someone there? [15:35:38] Possibly [15:35:40] i still didnt have edit rights when i was logged in in the morning [15:35:46] oh [15:36:17] Yeah, we have an "editor" grou[ [15:36:18] it seems it's a protected wiki anyway so don't see the need for yet more protection, but whatever :) [15:36:20] Denny_WMDE: fixed [15:36:27] ok [15:36:42] yes, fixed, thanks. changing it [15:36:52] Lol, they do look a bit skewed [15:36:59] http://wikitech.wikimedia.org/view/Special:ListGroupRights [15:37:06] ah screw it [15:37:13] heh [15:37:15] New review: John Erling Blad; "Patch Set 4: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/48997 [15:37:16] on wednesday there is the schema change [15:37:16] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/48997 [15:37:29] we can't do both things at the same time [15:37:42] hrm [15:37:53] apergos: I think I changed all crontabs now. Sorry again! [15:38:05] so, no, wednesday won't work [15:38:33] New review: John Erling Blad; "Patch Set 3:" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49030 [15:38:51] New review: John Erling Blad; "Patch Set 3: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49030 [15:38:53] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49030 [15:39:47] * apergos looks expectedly at their inbox [15:39:53] tick.. tick.. tick.. [15:40:21] New review: Aude; "Patch Set 1: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (mw1.21-wmf10); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49246 [15:40:23] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf10) - https://gerrit.wikimedia.org/r/49246 [15:40:32] New patchset: Daniel Werner; "(bug 44744) copyright warning now using its own message instead of EditPage::getCopyrightWarning" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49248 [15:43:02] gnah, reality sucks [15:43:10] hahaha yes it does [15:43:25] Jeblad_WMDE: will you put the cache timeout back in, or do i need to re-submit it? [15:43:39] thought he did [15:43:45] Denny_WMDE: what are you trying to find a date for? [15:43:52] oh?... [15:44:02] Reedy: sorry, I think we have to stick with Monday, Wednesday will not work. We will work towards making Monday happen [15:44:28] aude: i don't see it. [15:44:28] DanielK_WMDE: we have a bit trouble with ensuring that we can test everything appropriately for Monday deployment [15:44:40] hmhm [15:44:46] but moving to Wednesday does not work as Wednesday is the DB update [15:44:59] DanielK_WMDE: i can take care of it [15:45:04] thanks [15:45:08] * DanielK_WMDE needs to go afk [15:45:25] DanielK_WMDE: how are autocomments going? [15:46:00] aude: the patch is up, and i though i added you as a reviewer [15:46:07] DanielK_WMDE: yay [15:46:13] i didn't finish the refactoring but did a quick & dirty instead [15:46:17] it has an x on it [15:46:28] it looks great Silke_WMDE_, thanks! [15:46:28] that refactoring is indeed important, but i wasn't going to finish it today. [15:46:41] can you give me a link [15:46:54] apergos: hehe, I'm a bit shocked right now. How did you support that for months? [15:46:59] nah, found it [15:47:04] https://gerrit.wikimedia.org/r/#/c/49238/ [15:47:05] aude: not the "rename" one, i postponed that [15:47:07] aude: https://gerrit.wikimedia.org/r/#/c/49238/ [15:47:12] indeed [15:47:12] delete button [15:47:30] ok, i'll review that and the change "robustness" one before i go home [15:47:35] I have 'delte button finger' (kinda like blackberry thumb) [15:47:39] * aude working on the change one [15:47:44] aude: the autocomments are not pretty, but we need the refactoring to handle this nicely [15:47:53] so i suggest to go with the ugly version for now [15:47:59] DanielK_WMDE: if it's somethign that's better than nothing [15:48:08] aude: usually, but not always :P [15:48:11] or Lydia_WMDE would be sad (and the community) [15:48:12] What does everyone think of http://www.wikidata.org/wiki/User:Addshore/Wikidata:Bots and all of its subpages? [15:48:15] DanielK_WMDE: true [15:49:01] DanielK_WMDE: what about 43990? we are wondering how far that is - has a red dot here [15:49:25] AnjaJ_WMDE: working on it [15:49:35] DanielK_WMDE: the one where ross makes wb_changes robust against version differences [15:49:50] * aude shuts off irc [15:50:07] back once i review stuff [15:50:59] all right, outa here.. see folks later :-) [15:53:32] New review: John Erling Blad; "Patch Set 2: Verified+2 Code-Review+2" [mediawiki/extensions/Wikibase] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/49222 [15:53:34] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/49222 [15:54:21] AnjaJ_WMDE: it has been waiting for reviews for several days now [15:54:38] I see one change set is merged, the other is waiting [15:54:43] are there more than those 2 ? [15:54:47] wait... [15:54:53] yea, looks like the patch isn't linked [15:54:55] one sec [15:55:30]