[02:20:29] Hi there :) on the Wikidata FAQ there is: "writing code;" what kind of code is this specifically? [02:21:13] PHP and JS mostly [02:21:24] Either for Wikidata itself and it's related extensions [02:21:30] Or userland JS writing tools for end users [02:21:52] https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/Wikibase.git [02:24:50] Okay, thanks! [02:26:44] Reedy: http://www.wikidata.org/wiki/Wikidata:Requests_for_deletions#On_hold_pending_developer_comment [02:27:37] I'm not sure I'm the right person to OK it [02:27:53] Though, I'm fairly sure there's a bug open for these edge case duplicates that occur [02:28:35] Uhh. Is anyone else seeing Wikidata is apparently loading stuff over http on a https request? [02:29:10] And no CSS [02:30:40] I login, then make an edit as an ipv6 address [02:30:41] GG [02:31:19] Reedy: your browser is giving an unsecured-content-in-https warning? [02:31:27] As anon [02:32:22] strange indeed [02:32:45] in fact, weren't IPv6/https the same LVS? [02:34:12] Err, ipv6 for wikidata hits eqiad [02:35:02] (it should, shouldn't it?) [02:35:06] yeah [02:35:13] I think [02:35:15] sounds about right [02:35:25] I know we can't serve https for wikidata from esams atm [02:36:02] see if the same problem occurs over IPv4 [02:36:33] That requires turning off my ipv6 tunnel [02:36:51] Which will likely mean my router then wants a restart [02:37:20] I think it could be chrome with a screwed cache again [02:37:23] canary is alright [02:37:55] * Jasper_Deng is also using an IPv6 tunnell [02:40:35] Clearing cache fixed it [02:40:42] Might've been a remnant of the recent bits issues [02:51:00] !logs [02:51:00] http://bots.wmflabs.org/~wm-bot/logs/ [02:51:25] wm-bot: the page doesn't load for me [03:13:58] steven is faster than me... ;-) [03:47:16] you know, it might be worth it to have a bot auto-generate a list of red-links, then we can manually edit the list to say what the item was, in case we want to re-create the subject of the deleted entry again [03:47:52] (well, an administrator could see what the item was, not the average user) [03:55:59] we'd have to make sure, in the future at least, that it can't be abused to get around things that need oversight [03:56:23] Jasper_Deng: how does https://www.wikidata.org/wiki/User:PiRSquared17/Sandbox2 look? [03:57:19] what is it for? [03:57:53] Jasper_Deng: do you see "Language select" in the top left? [03:58:03] Under the "discussion" page tab [03:58:12] * Jasper_Deng gets what huh is getting at [03:58:22] solves half the problem [03:58:35] Look at the page source :P [03:59:34] huh: I do [03:59:44] but the problem is that a translator is still needed [04:00:38] just bother people until they translate it [04:04:03] Jasper_Deng: I'm sure we'll be able to get people to do the main linguae francae (as long as we keep comments on the page short and simple) [04:04:37] Would require much coordination [04:04:47] also trust - we don't want someone putting words in another's mouth [04:10:12] The second thing is unlikely [04:14:44] Jasper_Deng: if you split up the community of WIkidata into smaller language communities [which will inevitably end up with some arguments, like the Bronze Soldier of Tallinn, the land area of India, or the population of some disputed territories], you are moving the community into a dysfunctional state. Take Belgium's government, for example. There are three regions (Wallonia, for Frenchies, Flan [04:14:46] ders, for Dutchies, and Brussels). Each language community (French, Dutch, and a German minority) have their own government too. Now the Flemish want to be independent from the Walons, etc. But, I completely digress. That was off-topic. [04:15:37] As for putting words in one's mouth, we let volunteers translate fundraising appeals and so far there have been no big problems. Why would Wikidata be any different? [04:16:58] huh: translate extension has /some/ oversight over that [04:17:45] When the important discussions happen, we want to let non-Anglophones comment and read the discussion don't we? [04:18:00] True [04:18:24] but I have paranoia about even a good-faith translator making a fundamental error [04:25:58] on firefox, I keep getting lots of unresponsive script errors for longer data pages, like Q30 [04:26:06] unresponsive script: Script: https://bits.wikimedia.org/www.wikidata.org/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.triggerQueueCallback%2CloadingSpinner%2CmwEmbedUtil%7Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20130116T214945Z:8 [04:27:33] Moe_Epsilon: b/c FF is choking on too much JS [04:27:43] yes :/ [04:29:16] on an unrelated note, who put "Murrica" as a united states alias? [04:29:16] |: [04:29:37] vandalism [04:29:41] Moe_Epsilon: hehe [04:31:12] Moe_Epsilon: someone removed the alias "Columbia" ... and why is "The Colonies" there? [04:31:51] o_O [04:31:52] hmm [04:32:16] Columbia is at least still used [04:32:34] (cf. District of Columbia) [04:33:24] that's usually to refer to Washington D.C. not really the whole country.. I've never heard anyone call the whole United States Columbia before [04:33:40] but that's just me [04:34:13] "Columbia", a name popular in poetry and songs of the late 1700s,[22] derives its origin from Christopher Columbus; it appears in the name "District of Columbia". [04:35:07] An issue is that we have no hard-coded policy on this [04:36:15] I went ahead and removed the Colonies reference in the aliases as well [04:36:30] Moe_Epsilon: you're not logged in [04:36:31] The thirteen colonies are not the United States, but they were the entities prior to it [04:36:33] oh [04:36:34] rofl [04:36:41] I'll revdel it for you if you'd like [04:36:48] sure, go ahead [04:36:56] I don't really care though [04:36:57] :p [04:37:37] * Jasper_Deng won't do it [04:37:41] besides it's latest revision [04:37:49] so it's not possible I'd think [04:38:20] I'm putting in my password and it's saying I'm logged in, then I change a page and it says log in again [04:38:21] |: [04:44:44] * Moe_Epsilon knows he's not crazy lol [04:46:37] * Moe_Epsilon checks cookie settings [04:47:25] Moe_Epsilon / Jasper_Deng https://www.wikidata.org/w/index.php?title=Q30&diff=prev&oldid=1237108&diffonly=1 [04:47:32] It wasn't added by a vandal [04:47:40] firefox hates me, it disabled my cookies [04:47:47] It was added by an autopatroller [04:48:01] with 508 edits [04:48:14] I'm going to ask him why [04:48:17] b/c this might be legitimate [04:48:20] huh!? [04:48:31] o_O [04:49:07] well, I know it's called Murrica as a joke, as slang etc. [04:49:13] but as a legitimate alias, no [04:50:37] i'm a bit concerned [04:50:48] if it persists, i'd be inclined to pull autopatrolled [04:51:07] well they haven't been around since before Christmas [04:51:09] :s [04:57:33] rschen7754: it is what it is [04:58:17] yeah, if it's a one-off goof, that's one thing, but if he doesn't get what that field is for, the flag should be pulled [04:58:56] then again, i'm from enwp, a very hardliner project, so take that as you will :P [04:59:25] * huh remembers the days before policies, or even suggestions, on how to use labels, descriptions, and aliases :P [04:59:59] I remember the days before slurpInterwiki, when you had to manually add sitelinks.You new users have it easy. [05:00:58] lol [05:03:30] Moe_Epsilon: https://www.wikidata.org/wiki/User:Jeblad/first_3130_items <- the good old days are toward the bottom (under 1000) [05:04:58] interesting [05:05:13] 29. okt 2012 kl. 21:52 ‎Lopado­temacho­selacho­galeo­kranio­leipsano­drim­hypo­trimmato­silphio­parao­melito­katakechy­meno­kichl­epi­kossypho­phatto­perister­alektryon­opte­kephallio­kigklo­peleio­lagoio­siraio­baphe­tragano­pterygon (Q101) (hist) ‎[4 019 bytes] ‎Reedy (Diskusjon | bidrag) (Created page with "") [05:05:32] 29. okt 2012 kl. 18:18 ‎Douglas Adams (Q42) (hist) ‎[2 534 bytes] ‎127.0.0.1 (Diskusjon) (Import) [05:06:08] ^ author of The Hitchhiker's Guide to the Galaxy [05:06:15] ahh [05:06:18] lol [05:23:11] Moe_Epsilon: can youz fixes the https://www.wikidata.org/w/index.php?title=Wikidata:Interwiki_conflicts&diff=5056738&oldid=5035718 ???????????? [05:23:54] oops, I mean https://www.wikidata.org/w/index.php?title=Wikidata:Interwiki_conflicts&diff=5056894&oldid=5056738 [05:24:09] o_o [05:24:11] * Moe_Epsilon looks [05:24:42] Moe_Epsilon: why you do o_o ? [05:25:10] I.. don't know, but I'll look [05:25:10] :p [05:25:23] you don't know how to fix da intawiky kunflyktz? [05:26:00] I've done it before [05:26:11] I've done them for frr and hu wiki [05:26:42] Frr? [05:26:52] Franco0Provençal, non? [05:27:05] https://frr.wikipedia.org/wiki/Wikipedia:Hoodsid [05:27:24] Ah, Frisian [05:27:29] I was thinking of frp [05:27:33] yes [05:28:51] North Frisian apparently [05:29:31] Moe_Epsilon: Snååkest dü Frasch? [05:30:13] don't speak a lick of North Frisan, I just help with the conflicts [05:30:13] :P [05:30:21] Fertrüt me! [05:30:23] Frisian* [05:30:33] Min luftdümpetbüüdj as ful ma äil :S [05:34:45] I just had a closer look at the interwiki conflict report and all the data pages were the same number [05:34:49] Items implied [[Q45393/]][[Talk:Q45393/|[1]]], [[Q45393/]][[Talk:Q45393/|[1]]], [[Q45393/]][[Talk:Q45393 [05:34:58] are these supposed to be different? [05:36:01] I see the entries on lt wikipedia [05:36:47] Moe_Epsilon: I know some Lithuanian so if you don't understand the problem I can explain [05:37:33] I can see, only page is about piracy and one about pirates, but do we already have an entry for pirates and piracy individually on wikidata? [05:37:36] Moe_Epsilon: basically: which one of [[lt:Piratai]] or [[lt:Piratavimas]] should be Q45393? [05:37:56] Moe_Epsilon: no, all the other Wikipedias have one for both piracy and pirates [05:38:02] there's currently only one wikidata item [05:38:03] ahh okay, I see [05:38:44] So what should be done? [05:39:16] http://lt.wikipedia.org/wiki/MediaWiki:Sitenotice <- this is the only reason I even noticed the page [05:40:21] Really unsure at this point, I guess we'd have to define what pages at the data entry we have are titled "piracy" or "pirates" and split from there. That would be the most logical [05:40:33] Since the title of the article will be whatever the other is merged into [05:40:52] and lt wikipedia would have entries on both [05:40:55] They're very closely related topics [05:41:06] yes, that's what makes this difficult [05:41:07] :/ [05:41:10] It's almost as if they're the same topic, so... [05:42:10] Moe_Epsilon: if we split them, that would mean fewer interwiki links on either name even though they're about pretty much the same topic [05:43:01] pretty much, but there's the only one other option really, and thats for a lt wiki article to have its own entry and that really isn't optimal either [05:43:12] hm [05:43:22] I guess I'll do what you said tomorrow [05:44:04] Like the English Wikipedia has Piracy, not pirates, so the topic of the entry (and the en.wiki) is Piracy, which I suspect most of the projects are going to be like [05:44:12] lt wiki seems to have split it a bit [05:44:44] maybe :s [05:45:06] bs.wiki has Pirati (eng. pirates) [05:48:29] it could be harder to decifer some languages which the article title is, pirates or piracy [05:51:17] duh: come on over ;) [05:51:22] hi [05:51:51] ok so [05:51:56] repeat in less words? :P [05:52:08] the question is, essentially [05:52:19] does Special:Search know how to ignore diacriticals and accents? [05:52:52] (i.e. read "é" as "e" and "ķ" as "k") [05:52:58] iirc yes [05:53:11] * duh tests it [05:53:40] works for me on enwiki's dropdown [05:54:05] ahh ok. so then - *raises voice in general direction of admins* - does the Help:Aliases guideline perhaps need to be changed to drop the Unicode part? [05:55:20] well [05:56:06] idk why you want to drop unicode [05:56:59] i mean drop the part of the page that says "You should always include ... Unicode free versions of items where the label contains unicode (accent marks are all done by unicode, and chemistry formulas that have subscript are doing so by using unicode)" [05:57:23] or at least the part of that that references accent marks [05:57:38] no idea :P [05:59:47] PinkAmpersand: well, I'd prefer to have the full-Unicode version [05:59:55] PinkAmpersand: you do have to give consideration to the fact that Wikidata is multi-lingual [06:00:01] instead of the Latin-1 or whatever spelling [06:00:26] Yeah, yeah I like having the diacriticals and accents in the labels [06:00:43] My question is if there's any reason to include the non-diacritical/accent versions as aliases [06:00:43] In many languages diacritic marks give a VERY different pronunciation [06:01:10] so just removing them is losing information [06:01:41] PinkAmpersand: I agree, but does it work with Cyrillic and other scripts? [06:01:58] unicode > everything [06:02:03] does what work? [06:02:18] PinkAmpersand: Special:Search and whatnot [06:02:51] hmm. I don't know. Does Cyrillic have diacritics? I wouldn't even know. [06:03:26] Belarusian has a letter ў. [06:03:38] Russian has the http://en.wikipedia.org/wiki/Short_I [06:03:40] etc. [06:04:45] Russian used to use http://en.wikipedia.org/wiki/Yo_(Cyrillic) more commonly but it's still used (but not as much as it used to be) [06:05:26] enwiki goes fine w/ accents [06:05:32] hmm. can you give me an item we have that would use one of them? should be pretty easy to test [06:05:39] are you talking about adding accent-free aliases? [06:07:04] PinkAmpersand: Михаи́л Серге́евич Горбачёв <- Russian spelling, but try the spelling Горбачев [06:07:19] (not the lack of ¨ above the e) [06:07:28] *note [06:07:51] For me it doesn't work [06:08:29] do we have an item on it? [06:08:45] uh, former Soviet Premier, yes [06:09:08] https://www.wikidata.org/wiki/Q30487 [06:09:14] haha can't read Russian. hmm Item by Title isn't giving me anything for the /right/ version [06:09:38] But who cares about Cyrillic anyway? :P [06:10:30] ahhh but ok, now I get it, actually [06:10:47] PinkAmpersand: the Russian label is "Горбачёв, Михаил Сергеевич" [06:10:57] search works fine on accents, but Item by Title /doesn't/ [06:11:01] e.g. https://www.wikidata.org/wiki/Special:ItemByTitle?site=enwiki&page=Les+Miserables&submit=Search [06:11:36] Perhaps it should redirect ItemByTitle for redirects... if that makes any sense [06:12:02] okay, so, now that I've cleared up /why/ we should have Unicode-free aliases... duh: sounds like a pretty easy bot to code, right? [06:12:08] Since [[en:Les Miserables]] is a redirect [06:12:20] PinkAmpersand: Er to do what? I wasn't following it :P [06:12:44] duh: find labels with diacritics/accents in them, and unaccented versions as labels [06:12:48] viso gero! [06:12:48] *as aliases [06:12:51] Ok [06:12:53] Thats easy [06:12:54] Just [06:13:04] I'll look into it this weekend [06:13:09] ok [06:14:07] huh: yeah, it probably should. you can't add a link to a redirect if the target is already in use elsewhere, so there's no downside [06:15:34] erm, *Gorbachov wasn't the Premier but was the President and Chairman of the Soviet Union, always get those mixed up [06:16:44] I love how he came back on just to say that. [09:13:08] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45335 [09:58:30] New patchset: Hoo man; "(bug 43997) UI for linking articles to Wikidata entities from the client - WIP" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45114 [09:59:59] Silke_WMDE: https://gerrit.wikimedia.org/r/45114 [10:03:28] Marius_WMDE: OK. Done. [10:09:11] JeroenDeDauw: hey! i have been poking at the object serialization stuff some more on the train yesterday. and when using a differ to verify that two structures are equal, i came across a problem [10:09:35] seems like if the differ compares two objects, it will consider them equal only if they are the same object [10:10:21] now I'm wondering how to best change that. A Comparable interface? But we already have one in DataValues, right? Just check for a equals() method? Or a custom callback? [10:11:33] the callback would be nice, but it has to be handed down to all differs used further down in the strcuture... we may want to have some kind of diff context or diff config thing to pass around, then. [10:15:09] DanielK_WMDE: there's no jeroen here yet.... [10:18:16] aude: but he's awake and online, apparently :) [10:18:32] unless he sends out his daily via cron... [10:44:54] DanielK_WMDE: wouldn't be surprised, but who knows :) [10:45:00] :P [11:01:40] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/45740/ [11:01:48] if you can review that, it would be great [11:03:28] it also means memcached has to be restarted, so should i bump the serial version id? [11:08:37] aude: see my comment there [11:08:54] i'll try & merge it. but... what do you need the internal ID for? [11:08:56] ok [11:09:07] it's used to query the site_identifiers table [11:09:18] and load the interwiki ids [11:09:39] if we wish to get rid of that, it should be a separate commit as this is just a bug fix [11:12:14] Lydia_WMDE: DanielK_WMDE https://bugzilla.wikimedia.org/44339 [11:12:32] if you have any opinion about being a cc or whatnot on core sites-related bugs [11:12:39] aude: thx [11:12:41] yea, we do need it on the database level... [11:12:44] no opinion [11:12:48] hm, i wonder when & how that got loast [11:13:15] aude: hm... can you add a unit test for your fix? [11:13:33] DanielK_WMDE: i'm sure some join query could be done to load the information, but not right now [11:13:37] DanielK_WMDE: ok [11:15:20] yea, i agree, we need this fix [11:15:47] though i guess getInternalId could at least be protected... but that would make the unit test tricky :/ [11:18:02] DanielK_WMDE: thanks for the sql-statements. But i dont think i have a toolserver-account. Can you run that querys? btw: count(*) is not realy efficient [11:18:47] lbenedix: go get one, you'll need it :) [11:19:14] lbenedix: i can run that query for you now, but i bet there will be more. would be good if you could do that yourself. [11:19:20] lbenedix: which wiki? wikidata? [11:19:26] yes [11:19:30] want dewiki for comparison? [11:19:55] i dont think that its necessary [11:20:20] i just want an argument for restricting the test-users to logged-in users [11:21:03] "Most of the non-bot-edits are made from logged-in users (bot: 10000, logged-in: 100, anon:4)" [11:26:01] lbenedix: logged in: 179 623; bot: 1 942 584; anon: 2019; total: 2 124 226. [11:26:39] thanks! [11:27:04] that are the last 30 days? [11:27:19] lbenedix: no, 24 days, as in your example [11:27:24] Jan 1 to Jan 24. [11:27:26] ok [11:27:33] select count(*) as n, count( if( rc_user = 0, 1, NULL ) ) as anon, count( if( rc_bot = 1, 1, NULL ) ) as bot from recentchanges where rc_timestamp >= "20130101000000" AND rc_timestamp <= "20130125000000"; [11:27:36] for reference [11:28:08] ah, 24 days and 1 second [11:28:16] hehe [11:28:16] sorry, <= should have been <. [11:55:55] Marius_WMDE: https://gerrit.wikimedia.org/r/#/c/45740/ [11:55:59] * aude adding tests for that [11:56:19] got it, thanks :) [11:57:41] what about bots without the botflag? [11:57:48] New patchset: Jeroen De Dauw; "Added TimeValue" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/45553 [11:59:46] lbenedix: there is no way to know it's a bot, then [12:01:47] i remember, that i have seen an edit by merlbot yesterday... [12:15:54] i requested the toolserver-account just now [12:16:10] there are some other querys i want to run ;) [12:26:43] DanielK_WMDE: avail? [12:32:22] New patchset: Jeroen De Dauw; "Moved jquery.eachchange from Wikibase since its needed here" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/45746 [12:32:25] New patchset: Jeroen De Dauw; "Move jquery.eachchange to DataTypes since code there needs it" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45747 [12:32:48] Abraham_WMDE: yep [12:34:02] aude: are you still working on the test case for SiteSQLStore? [12:34:21] DanielK_WMDE: yes [12:34:51] ah. is it turning out to be tricky? I assumed it would be bretty easy to do... [12:35:01] no, it's not [12:35:17] just check that $site->getInternalId is integer or somethign like that [12:35:22] i think that would be ok [12:39:10] an integer and probably also > 0, yes [12:42:37] yes [12:42:53] give me like 5-10 more minutes... [12:43:06] aude: no rish, i was just wondering [12:43:14] rush, even [12:43:15] * aude has a different wiki for testing and had to update it, populate sites table, etc. [12:43:24] a new test wiki [12:43:43] phpunit and the multiversion stuff doesn't work together [12:49:10] aude: still doesn't? I fixed at least the --wiki parameter a while ago. [12:49:44] it's more complicated than that [12:49:50] someday i'll poke at it [12:50:12] separate test wikis are okay for now [13:04:11] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/c/45740/ [13:04:41] * aude not entirely happy with the performance here of refreshing the cache, though once it's in memcached it's better [13:05:05] looking at the profiling stuff now [13:05:07] New patchset: Hoo man; "(bug 43997) UI for linking articles to Wikidata entities from the client - WIP" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45114 [13:08:12] DanielK_WMDE: I deny sending mails via cron [13:08:37] hehe [13:09:02] but if one can do foursquare checkins via a script.... :) [13:09:02] JeroenDeDauw: got any idea about my object comparison question i asked here on irc a few hours ago? [13:09:38] DanielK_WMDE: so you're saying in_array with third arg true will thing two equal obejcts but differenent instances are not equal? [13:10:22] JeroenDeDauw: i didn't try in_array, i tried ListDiffer in strict mode and/or a MapDiffer in recursive mode. [13:10:32] i didn't lopok closely yet what they do internally [13:10:50] DanielK_WMDE: in_array with third arg true [13:10:50] just test that [13:11:43] DanielK_WMDE: sadly enough there is no suitable comparable interface... [13:11:50] If only PHP had one in SPL... [13:12:13] You could do some evil hack using reflection that would work most of the time [13:12:21] But most of the time is not something acceptable here [13:13:03] JeroenDeDauw: yes, exactly my problem [13:13:53] JeroenDeDauw: and yes, in_array wioth the third arg = true uses === on the objects, and thus fails. [13:14:12] with the third param = true, it works - but that has other nasty implications, like 3 == "3", right? [13:15:56] DanielK_WMDE: yeah [13:16:09] DanielK_WMDE: I'd be fine with having an is_object check and switch the fag based on that [13:16:24] Should celarly document the expected behaviour for objects in that class then though [13:16:38] the problem is that == for objects is pretty ill-defined already. [13:16:46] i'd prefer to be able to provide a callback. [13:16:58] but passing that around between different differs kind of sucks... [13:18:03] "Two object instances are equal if they have the same attributes and values, and are instances of the same class." [13:18:13] that sounds fair enough, though me may want more control than that. [13:18:43] JeroenDeDauw: i'll implement the is_object hack for now, but i have the feeling we'll need a better solution soon. [13:25:49] New patchset: Daniel Kinzler; "Don't use strict comparison for objects." [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45751 [13:26:12] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/45751/ [13:37:28] is it really good to show the edit buttons when looking at the difference between two revisions of an item? [13:37:50] DanielK_WMDE, JeroenDeDauw --^ [13:38:38] DanielK_WMDE: if you need specific comparison of objects, you can create your own Differ [13:38:55] DanielK_WMDE: the two default ones in Diff are meant as sane defaults that deal with moths things [13:39:01] They should not try to covere everything [13:39:04] *cover [13:39:29] JeroenDeDauw: sure. but if i want to handle objects that occur deep down in the structure, not at the top level - how do i inject my custom differ? [13:39:34] DanielK_WMDE: also look at how I completely sidestepped this exact problem with claim diffing [13:39:59] oh right - where do i find that? [13:42:02] DanielK_WMDE: "i want to handle objects that occur deep down in the structure" this is outside the responsibility of the two default Differs. They are aimed at comparing arrays with primitive values. If you want one that has callbacks or paths or whatever stuff to have specific handling for objects, create a new one [13:42:30] hm, ok [13:42:41] i thought they already covered recursive comparison [13:46:17] JeroenDeDauw: is there a bug for a special page which shows items without langlinks? [13:46:42] DanielK_WMDE: recursive comparison of arrays yes [13:47:31] benestar I thought we already had one of those [13:47:38] Written by Tpt [13:47:40] Not sure [13:47:49] is it already merged? [13:48:12] http://www.wikidata.org/wiki/Special:WithoutInterwiki [13:48:13] benestar items do not have langlinks btw, they have sitelinks [13:48:26] ;) [13:48:39] lbenedix: thanks [13:49:00] faiiiil [13:49:04] Incorrect page name [13:49:05] :O [13:49:07] And incorrect page title [13:49:12] Let me fix that ... :/ [13:49:20] This will confuse people even more now [13:49:25] yes [13:49:34] JeroenDeDauw: how to to it? [13:49:42] benestar how to do what? [13:49:43] like that 'search' that is not really a search... ;) [13:49:57] JeroenDeDauw: can you edit an existing special page with the extension? [13:50:28] ohhh [13:50:36] benestar I did not realize this was a core page [13:50:48] :/ [13:50:56] that page makes no sense [13:51:12] is it possible to owerwrite a speical page? [13:51:17] it's meant for the links in the sidebar [13:51:22] doesn't really apply to items [13:51:38] * aude shall see if we can disable this one on wikidata [13:51:58] there should be a wikidata specific one [13:52:01] that should probably be in the client extension [13:52:08] hu? [13:52:15] when you are editing specialpages... can you have a look at: Special:ItemByTitle? [13:52:27] lbenedix: what is the problem there? [13:52:30] https://gerrit.wikimedia.org/r/#/c/45336/ [13:52:35] looks like tpt is wroking on it [13:52:36] it is not a search and not for itemS [13:52:47] true [13:53:00] lbenedix: it isn't called a search, is it? [13:53:01] lbenedix: but that's just a change in the messages. [13:53:07] that is best done on translatewiki.org [13:53:12] "Search for items by site and title" [13:53:18] * DanielK_WMDE can't remember how to do that there, though [13:53:19] :/ [13:53:56] ItemByTitle should probably tell people that they *probably* want to use Special:ItemDisambiguation instead. [13:54:10] anyway, special:withoutinterwiki is cached and rarely updated [13:54:11] +1 [13:54:25] or poke the developers to repair the search in the upper right corner ;) [13:55:57] btw: there was a discussion about that specialpages: http://www.wikidata.org/wiki/Wikidata:Project_chat/Archive/2012/11#Change_name_on_special_pages.3F [13:56:03] lbenedix: something is broken about the lucene search index. we already asked ops to investiagte [13:56:06] developers can't do much about it [13:56:14] (note: developers != operators) [13:56:27] see bug 44111 [13:57:02] New patchset: Tobias Gritschacher; "(hotfix) fixing SetLabel Selenium tests after refactoring" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45753 [13:57:11] okay... i was wondering while reading all the project:chat, that the broken search is mentioned about 10 times [13:58:22] benestar aude Will have a look at Tpts patch [13:58:27] New review: Daniel Werner; "The tests should not use newMbEnvironment anymore, otherwise tests will still not work without Wikib..." [mediawiki/extensions/DataValues] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/45746 [13:58:32] ok [14:03:05] JeroenDeDauw: at your review of my patch [14:03:29] in your opinion the class SpecialSetSiteLink should not inherit from SpecialSetEntity? [14:04:20] JeroenDeDauw: otherwise there will be much copy&paste [14:04:30] benestar SpecialSetEntity has code specific to having a language [14:04:35] benestar: then you need another level of inheritance [14:04:37] It should mprobably not be named "SpecialSetEntity" [14:04:52] And look at alternate ways to share code [14:04:54] that's another point [14:04:54] benestar: your base class does stuff based on a "language" selection. sitelinks do not have languages [14:05:09] Making a big inheritance tree for code sharing causes many problems [14:05:14] or, as jeroen suggested, use composition instead of inheritance [14:05:21] DanielK_WMDE: so how to make another level of inheritance? [14:06:00] I'm already unhappy with current use of inheretance here, please don't go further in that direction [14:06:03] server kittens will die [14:06:24] JeroenDeDauw: I understand you, no problem [14:06:48] benestar: you *could* have a SpecialModifyEntity base class, and derive the SpecialModifyEntityLanguageStuff from that, and use that for labels, descriptions and aliases. the sitelinks spage would derive directly from SpecialModifyEntity. [14:06:56] but as jeroen said, there are other ways to share code [14:07:06] * DanielK_WMDE should look into traits some time [14:07:23] DanielK_WMDE: I tihnk tihs would be a good idea [14:07:45] but which other ways do you meen? [14:08:01] benestar I suggest you start by copying the code, dicthing what you don't need in the sitelink page, then doing general cleanup allowed now due to not having to do two different things in SpecialSetEntity, and after that looking if there is not code in both SetEntity and SetSitelink that should be composited out [14:08:16] Quite possible the amount of duplication will not be that big [14:08:27] And it might not be sensible to composite anything out [14:08:40] Some duplication is not the end of the world [14:08:43] benestar: composition, aggregation, delegation... [14:08:52] i think php trais are good for composition [14:08:53] Trying to hard to get rid of every last bit leads to redicuously complex systems [14:08:57] but i havn't played with them yet [14:09:10] JeroenDeDauw: have you used traits? would they work here? [14:09:13] DanielK_WMDE: traits are not relevant here, we cannot use them [14:09:18] no? [14:09:19] They need PHP 5.4 [14:09:26] hm, maybe i misunderstood something then [14:09:37] oh, well, that *is* a reason :P [14:09:55] New patchset: Daniel Werner; "Makes eachchange tests fully independent from Wikibase" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/45755 [14:10:07] DanielK_WMDE: I have not really played around with them yet [14:10:49] New review: Daniel Werner; "Ignore failing tests when WB is not there since this has been failing before as well. See my follow-..." [mediawiki/extensions/DataValues] (master); V: 2 C: 2; - https://gerrit.wikimedia.org/r/45746 [14:11:02] Change merged: jenkins-bot; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/45746 [14:11:10] sounds like they would be a good fit for the use case [14:11:20] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45747 [14:14:11] DanielK_WMDE: let me predict the future: one year for now we have 5.4 deployed. I write a code using traits to see if they are any good. Someone goes mad on gerrit. Wikitech discussion follows. Some people take the stance "traits are evil". Possibly they get banned in core [14:14:13] :) [14:17:03] traits, ah, memories.. [14:17:22] That was so.. 1994.. [14:17:34] * Jeblad_WMDE floats away on memories [14:18:35] New patchset: Tobias Gritschacher; "(testing) added Selenium tests for setDescription special page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45756 [14:18:49] Back then when I thought I was flawless.. Now I know I do erros every blue moon.. [14:19:56] * JeroenDeDauw pats Jeblad_WMDE on the head [14:20:30] * Jeblad_WMDE smiles while he stands on JeroenDeDauws feets [14:20:41] Abraham has left the room, lets go steal some chocolates! [14:20:56] Good idea! [14:21:04] * JeroenDeDauw throws a tennisball at Jeblad_WMDE [14:21:39] * Jeblad_WMDE phones 911 [14:33:36] Change merged: Jeroen De Dauw; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/45755 [14:39:38] New patchset: Jeroen De Dauw; "Fix name of dataproviders" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45757 [14:43:50] New patchset: Jeroen De Dauw; "Added missing dependency" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/45758 [14:48:04] Change merged: Daniel Werner; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/45758 [14:50:04] New review: Jeroen De Dauw; "Do provide tests if you extend the specified behaviour of the interface. Looks good otherwise" [mediawiki/extensions/Diff] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/45751 [14:50:53] New patchset: Aude; "add bunch of profiling points for LangLinkHandler" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45759 [14:52:03] $arrays = array(); [14:52:04] $arrays[] = array(); [14:52:04] return $this->arrayWrap( $arrays ); [14:52:06] ALL of the arrays [14:53:41] JeroenDeDauw: a better name for SpecialSetEntity [14:53:48] it isn't setting the whole entity [15:05:04] New patchset: Tobias Gritschacher; "(testing) added selenium test for setAliases special page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45761 [15:08:38] New patchset: Tobias Gritschacher; "(testing) added selenium test for setAliases special page" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45761 [15:12:27] New patchset: Jeroen De Dauw; "Added tests that check for exceptions being thrown on invalid data" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45762 [15:21:51] New patchset: Jeroen De Dauw; "Removed obsolete code" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45763 [15:42:07] New patchset: Jeroen De Dauw; "fix type hint" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45764 [15:42:14] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45764 [16:07:44] New patchset: Jeroen De Dauw; "(bug 44287) Added links to referenced entities in pagelinks table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45772 [16:11:33] New patchset: Jeroen De Dauw; "Fix exists check, array elements can be null" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45773 [16:11:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45773 [16:11:49] New patchset: Jeroen De Dauw; "(bug 44287) Added links to referenced entities in pagelinks table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45772 [16:13:44] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45757 [16:20:51] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45772 [16:24:06] New patchset: Jeroen De Dauw; "up rel notes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45774 [16:24:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45774 [16:27:13] New patchset: Jeroen De Dauw; "fixed SnakListTest::testToArrayRoundtrip" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45775 [16:27:35] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45775 [16:28:22] New patchset: Daniel Kinzler; "Don't use strict comparison for objects." [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45751 [16:35:01] Change merged: Jeroen De Dauw; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45751 [16:37:26] New patchset: Jeroen De Dauw; "Improve documentation" [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45776 [16:37:47] Change merged: Jeroen De Dauw; [mediawiki/extensions/Diff] (master) - https://gerrit.wikimedia.org/r/45776 [16:43:51] Jeblad_WMDE: http://www.lieferando.de/lieferservice-burger-factory-berlin [16:53:49] New patchset: Bene; "(bug 43870) new Special:SetSiteLink" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45574 [16:53:56] JeroenDeDauw: now have a look :) [18:06:52] DanielK_WMDE: did you see my patch? [18:07:35] :P [18:08:10] JeroenDeDauw: did you have a look? [18:09:53] benestar no sorry [18:10:00] benestar I'm done with coding for today [18:10:05] ;) [18:10:08] benestar will look at it this weekend probably [18:10:17] just take your time [18:10:24] * aude is done with coding for today :) [18:10:38] * benestar is coding all the time [18:10:41] heh [18:11:40] aude: ? [18:12:50] * aude amused :) [18:13:02] * aude usually coding all the time too [18:13:10] xD [18:24:06] aude: is there any other bug that should be fixed and that isn't too complicated? [18:24:24] Use the keywords! [18:24:34] which ones? [18:26:22] need-volunteer and easy should be ok [18:26:23] https://bugzilla.wikimedia.org/buglist.cgi?keywords=need-volunteer%2C%20easy&query_format=advanced&keywords_type=allwords&resolution=--- [18:26:28] only 1 bug though [18:27:24] well, with universal lang selector off, the user will always be on english when creating an account [18:35:40] * aude going through the bug list [18:35:47] * benestar too [18:40:49] there are several bugs marked as *new* but are fixed [18:41:35] :/ [18:41:35] * aude thinks if any gadgets should be polished and go into the extension, that would be a nice thing to do [18:41:42] :) [18:41:50] aude: which ones? [18:41:54] not sure [18:42:42] I think gadgets like slurp interwik shouldn't be added because they are only used temporary [18:42:43] SitelinkCheck [18:42:46] right [18:43:15] it's annoying to create an item and then find out the site link is already there in another item [18:43:27] * aude not sure the best way to improve that [18:46:09] https://bugzilla.wikimedia.org/show_bug.cgi?id=43298 [18:46:18] i don't know if that is still a bug, but .... [18:46:36] being show the create item page, even when i don't have permission to create items.... not nice [18:47:01] e.g. either permissions or if the site is in read only mode [19:37:55] aude: hi [19:38:01] sorry, i was afk [19:38:28] aude: how should SitelinkCheck be implemented? [21:06:22] New patchset: Tpt; "Add Special:ItemsWithoutSitelinks that list all items without any site link" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/45336 [21:14:14] New review: Tpt; "Patch set 2:" [mediawiki/extensions/Wikibase] (master) C: 0; - https://gerrit.wikimedia.org/r/45336