[08:32:28] New patchset: Tobias Gritschacher; "(hotfix) fix calls to getEntityNamespaces" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43415 [08:38:18] Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43415 [09:19:05] New patchset: Henning Snater; "Tooltips for claim view widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42923 [10:00:04] New patchset: Aude; "add toggle for wikibase edits in watchlist [DO NOT MERGE!]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [10:00:22] New review: Aude; "don't merge yet" [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/43424 [10:01:49] bamsemums [10:27:32] New patchset: Tobias Gritschacher; "(43828) marking specific selenium tests as experimental" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43425 [10:29:16] New patchset: Tobias Gritschacher; "(bug 43828) marking specific selenium tests as experimental" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43425 [11:59:49] New patchset: Tobias Gritschacher; "(minor) simpler way to maximize browser during selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43431 [11:59:52] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43431 [12:18:57] Henning_WMDE: Is there a schreenshot or something of the "right next to" case? [12:19:14] Henning_WMDE: We don't really like indications of location in text. [12:19:33] Henning_WMDE: "right next to" makes it even more specific and awkward. [12:19:44] Re: https://gerrit.wikimedia.org/r/#/c/42923/2/repo/Wikibase.i18n.php [12:20:14] OK, so, would just "next to" be better? [12:21:13] No screenshot at hand. Can upload one. [12:22:16] Henning_WMDE: *nod* that's what I suggested. [12:23:46] OK, I will change it. Would the rephrasing of "value alternative" be alright as well? [12:25:58] Henning_WMDE: I can't assess, because I'm not familiar with the functionality. The string as such sounds pretty technical; if it's a use case you expect will occur often, give some extra thought to the wordingg, and remember that simplifying at the cost of removing details is often worth it :) [12:28:39] aude: i'm working on coalescing changes now [12:29:06] my biggest issue is how to model the merged meta-change. probably needs it's own implementation of the CHange interface [12:29:09] Of course, that is why I did not use the term "snak type"... "value alternative" is still a bit technical, I admit. So, I will probably go for the rephrasing. [12:54:37] DanielK_WMDE: Is the setup of Abuse filter and Translate usable on dev? And do we need pages marked for translation on testrepo, too? [13:00:12] Silke_WMDE: should be usable on dev. and it would be good to haver pages marked for translation, yes [13:02:13] ok [13:05:08] DanielK_WMDE: the entitychange? [13:08:47] Silke_WMDE: git submodule update --init [13:09:17] 1) checkout mediawiki/core [13:09:25] err., git clone [13:09:33] 2) git checkout wmf/1.20wmf7 [13:09:39] 3) git submodule update --init [13:10:00] thx [13:11:48] Ok, announcement: testclient-en is about to be updated to wmf7 now. [13:13:47] AnjaJ_WMDE: http://wikitech.wikimedia.org/view/How_to_deploy_code [13:15:01] https://www.mediawiki.org/wiki/User:Aude/Git#Submodules [13:24:13] any native english speakers around for a very quick query? [13:31:09] Lydia_WMDE: ? [13:34:00] Lydia_WMDE: ? :) [13:34:24] aude: done :) [13:35:53] ok [13:39:00] Hmm [13:39:06] Are Americans native english speakers? [13:39:07] :p [13:39:59] lol [13:54:08] Reedy: are scots? [13:55:33] New patchset: Aude; "add toggle for wikibase edits in watchlist [DO NOT MERGE!]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [13:57:10] Silke_WMDE: can we downgrade one of the dev clients to wmf7, so we can test a wmf7 client with a master repo? [13:58:10] DanielK_WMDE: think that's what silke is doing with testclient [14:00:15] New patchset: Aude; "add toggle for wikibase edits in watchlist [DO NOT MERGE!]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [14:03:03] New patchset: John Erling Blad; "(Bug 43728) Create a max length constraint for language strings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43434 [14:04:11] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42984 [14:21:06] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43207 [14:24:45] DanielK_WMDE: testclient is on wmf7 [14:25:02] Silke_WMDE_: and testrepo? [14:25:11] is on 2012-12-19 [14:25:54] Silke_WMDE_: well, that's the problem. we need to test the *latest* repo code against the old client code. [14:26:04] New patchset: Aude; "add toggle for wikibase edits in watchlist [DO NOT MERGE!]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [14:26:10] ok [14:26:21] wmf7 is the same as 2012-12-19, no? [14:26:43] i.e. in the wmf7 deployment cycle, we are rolling out december's client code. [14:26:46] yes, but in a bundle with core and tagged versions of other extensions [14:26:54] ok, right [14:27:13] we could: [14:27:22] so, again: what we need to test is a wmf8 repo (will be deployed on wednesday) with wmf7 cleint code (as deployed on monday) [14:27:29] a) update testrepo [14:27:52] b) use a brandnew puppet-generated :) repo [14:28:01] but we dont have a wmf8 tag yet [14:28:07] or just downgrade a dev client [14:28:23] yea, instead of the wmf8 tag we'd just use master [14:28:27] (latest code) [14:28:50] just a moment [14:32:32] New patchset: Aude; "add toggle for wikibase edits in watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [14:32:42] ok DanielK_WMDE I will update testrepo to the newest stuff we have [14:34:11] Tobi_WMDE: AnjaJ_WMDE would you like to review? https://gerrit.wikimedia.org/r/#/c/43424/ [14:34:41] * aude providing qunit tests shortly [14:38:38] DanielK_WMDE, see also my mail [14:38:51] that combination will be tested here on monday as well [14:39:02] tagged repo with wmf7 client and tagged repo with tagged client [14:40:44] * aude will ensure the right client version gets tested with the new repo version [14:40:59] quick poll: wiki text or wikitext? [14:41:09] Lydia_WMDE: wikitext [14:41:20] k [14:41:24] * Silke_WMDE_ announces: testrepo is now brandnew, testclient is wmf7 [14:41:32] * aude cheers! [14:42:33] Do you want me to keep the state of testrepo like this or pull regularly until MOnday? [14:42:56] Silke_WMDE_: can you disable the globalblocking extension? [14:42:58] we don't need it on test client [14:43:01] sure [14:43:02] * aude sees (Can't contact the database server: Access denied for user 'wikidata'@'localhost' to database 'globalblocking' (127.0.0.1:3306)) [14:44:04] aude: where can I see the toggle for the watchlist [14:44:12] New patchset: Aude; "add toggle for wikibase edits in watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [14:44:42] New patchset: Henning Snater; "Tooltips for claim view widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/42923 [14:44:50] aude: done [14:45:37] thanks [14:47:12] aude: oh, now I can see [14:47:46] Tobi_WMDE: same place as the recent changes one [14:47:51] aude: the a-tag has no href-attribute [14:47:53] but this one is done with javascript [14:48:01] Tobi_WMDE: ok [14:48:15] so, the mouse cursor does not change when hoovering [14:50:53] New patchset: Anja Jentzsch; "(bug 43828) marking specific selenium tests as experimental" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43425 [14:52:14] aude: you can fust add href="javascript:void(0);" [14:57:29] New patchset: Henning Snater; "Correct parameter order in AutocompleteInterface" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43441 [15:11:00] Tobi_WMDE: ok [15:15:25] New patchset: Henning Snater; "Update commonsMedia widget value on suggester's close event" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43442 [15:19:53] New review: Anja Jentzsch; "Should toggle link from Show to Hide and vice versa." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/43424 [15:24:52] New review: Siebrand; "i18n issue pointed out." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/43434 [15:26:22] New patchset: Aude; "(bug 43124) add toggle for wikibase edits in watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [15:27:30] hi Reedy - asking about problems with the wbsearchentity api [15:27:51] if you can find traces or something [15:28:02] actually, meanwhile we figured out the most likely culprit [15:28:29] so, in case you have time and it is not a big hassle, we would like to see the traces to confirm it's what we suspect [15:30:13] I'll have a look in the fatal logs etc and see if anything pops up [15:31:58] thx [15:32:32] Aha, that was easy [15:32:32] [11-Jan-2013 12:01:42] Fatal error: Allowed memory size of 183500800 bytes exhausted (tried to allocate 81 bytes) [15:33:42] reedy@fluorine:/a/mw-log$ grep -c wbsearchentities fatal.log [15:33:42] 44 [15:33:48] That's 44 in the last 9 hours or so [15:34:04] let me try some older logs [15:35:47] New patchset: Aude; "(bug 43124) add toggle for wikibase edits in watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [15:36:26] Denny_WMDE1: Have you got a bug for this? Want me to post some stack traces to it? [15:36:41] no, just discovered it today [15:36:45] wait will make a bug right now [15:37:06] ok [15:37:38] * Reedy prepares to try some more grep foo [15:37:53] reedy@fluorine:~$ grep -c wbsearchentities fatal.log-20130110 [15:37:53] 0 [15:37:53] reedy@fluorine:~$ grep -c wbsearchentities fatal.log-20130111 [15:37:54] 0 [15:38:02] ^ It's not appeared for the last couple of days. [15:38:17] Reedy: https://bugzilla.wikimedia.org/show_bug.cgi?id=43858 [15:38:38] hm? i was trying it out today, causing http 500 and http 504 responses? [15:38:51] New patchset: Tobias Gritschacher; "(bug 43124) add toggle for wikibase edits in watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [15:39:17] It's there for today [15:39:23] ah, good [15:39:29] Just nothing in yesterdays or the day before logs [15:39:34] yes, wbsearchentities is not used anywhere yet [15:39:47] it is only used in experimental features which are not enabled yet on wikidatawiki [15:39:59] aha [15:40:06] And the cookies seem to be all you ;) [15:40:13] yep, sounds right :) [15:40:25] https://bugzilla.wikimedia.org/show_bug.cgi?id=43858 that's the bug [15:44:56] Attached to the bug [15:45:36] Denny_WMDE1: so do longer search strings work properly? [15:45:44] Denny_WMDE1: and is there a bug for this? [15:46:39] Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43425 [15:46:53] I can increase the memory for Wikidata... But i wonder if it'll just fail a bit further on than it is now [15:48:08] JeroenDeDauw: yes, https://bugzilla.wikimedia.org/show_bug.cgi?id=43858 [15:48:14] and longer strings seem to work [15:48:22] Reedy: no, do not increase the memory [15:48:39] it is a bug in the implementation, it will eat any memory you give us [15:48:44] we are fixing it [15:49:54] Reedy: yeah, but do increase the amount of chocolate, we'll eat that a lot more happily [15:50:43] Jeblad_WMDE: what has the length for labels and so on been restricted to? [15:51:16] configurable [15:51:21] 72010? [15:51:22] I set it to 2500 [15:51:23] default? [15:51:25] thx [15:51:31] 2500? [15:51:38] 2048 [15:51:44] 1337*2! [15:51:49] 90192 [15:51:55] 42^42 [15:51:58] polpr? [15:52:10] 2500 chars i assume? [15:52:17] bytes? [15:52:30] Jeblad_WMDE: ^ [15:52:32] yes, in a new patchset it will be utf8chars [15:52:39] ok [15:52:55] Denny_WMDE1: heh, looks like you added this api module :D [15:53:03] so it can then be 10KB in chinese thingys [15:54:36] New patchset: Aude; "Set client page id in recent changes table" [mediawiki/extensions/Wikibase] (mw1.21-wmf7) - https://gerrit.wikimedia.org/r/43450 [15:54:37] New patchset: Aude; "(bug 43290) link correctly to non-main namespace pages in recent changes" [mediawiki/extensions/Wikibase] (mw1.21-wmf7) - https://gerrit.wikimedia.org/r/43451 [15:54:42] New review: John Erling Blad; "Bug from testing in config." [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/43434 [15:55:21] Denny_WMDE1: oh, this is fun, it actually does have a limit parameter [15:55:29] But it applies it afater fetching the whole table :) [15:58:03] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf7) - https://gerrit.wikimedia.org/r/43450 [15:58:21] Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf7) - https://gerrit.wikimedia.org/r/43451 [15:58:38] JeroenDeDauw: and it was me? [15:58:47] Don't think so [15:58:50] Anyway, does not matter [15:58:55] awesome. i really should be prohibited from programming :P [15:59:21] you have seen the traces reedy posted, JeroenDeDauw? are they consistent with that bug? http://bug-attachment.wikimedia.org/attachment.cgi?id=11617 [15:59:23] Looks like for every row it got it is also doing a separate query to obtain an entity content [15:59:27] That's even worse [15:59:48] :( [16:00:35] Looks like the limit is applies where it was because a filter is happening after the results are obtained, so you might end up with fewer results if you apply it in the query [16:02:53] i understand. but then we could use a limit*x in the first query, and then restrict afterwards with the hard limit? should be reasonably correct... [16:03:15] or change the whole thing [16:06:22] New patchset: Aude; "(bug 43124) add toggle for wikibase edits in watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43424 [16:07:05] New patchset: Daniel Werner; "(minor) Changed jQuery.NativeEventHandler to better work with jQuery.Widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43454 [16:13:37] New patchset: Jeroen De Dauw; "bug: 43858 Do not select the whole terms table and then do a query for each row" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43455 [16:18:47] New review: Siebrand; "I like this better, Henning. Still a complex sentence." [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/42923 [16:24:50] New review: Denny Vrandecic; "Should get in even though it breaks continuation (we are not using continuation right now anywhere a..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/43455 [16:25:39] Reedy: thx. that helped a lot. we will deploy the fix on Wednesday. [16:25:47] Great :) [16:26:08] ("we" as in "you") [16:30:24] New patchset: Daniel Werner; "(minor) Changed jQuery.NativeEventHandler to better work with jQuery.Widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43454 [16:30:44] New patchset: Jeroen De Dauw; "Removed ValueFormatters Result interface" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43456 [16:33:55] New patchset: Jeroen De Dauw; "Removed ValueParsers Error interface" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43457 [16:40:21] New patchset: Jeroen De Dauw; "Get rid of incorrect usage of interfaces in ValueValidators" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43461 [16:40:54] Jeblad_WMDE: got 3 easy to review commits for you on gerrit :) [16:41:56] Easy? Something less that 12345 lines of code? [16:45:55] New patchset: Jeroen De Dauw; "Get rid of singleton pattern in ValueValidatorFactory" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43465 [16:46:18] Jeblad_WMDE: 4 commits now :) [16:46:33] Jeblad_WMDE: yes, not #over9000 [16:46:35] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43454 [16:50:31] Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=43867 [16:53:21] New patchset: John Erling Blad; "(Bug 43728) Create a max length constraint for language strings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43434 [16:59:41] New patchset: John Erling Blad; "(Bug 43728) Create a max length constraint for language strings" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43434 [17:03:53] New patchset: Daniel Werner; "(minor) Moved native event handler code into its own file" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43471 [17:05:20] New patchset: Daniel Werner; "(minor) Moved native event handler code into its own file" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43471 [17:15:55] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43455 [17:21:10] anyone interested in a new script? [17:34:18] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43456 [17:39:05] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43457 [17:41:19] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43461 [17:42:56] New patchset: Daniel Werner; "(minor) Moved native event handler code into its own file" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43471 [17:43:18] Wiki13: Are Wikipedia Categories allowed by Wikidata:Notability ? [18:15:07] is there a reason this bot isn't approved? https://www.wikidata.org/wiki/Special:Contributions/Innocent_bot [18:15:27] (it appears to be making mistakes, too https://www.wikidata.org/w/index.php?title=Q492614&diff=4067649&oldid=4050203) [18:16:06] Ajraddatz Benestar JD|cloud Moe_Epsilon: ^ [18:16:33] it's making test edits, the request is open now [18:16:54] ah ok. saw a redlinked talkpage and got nervous [18:17:08] yeah, its on the RFP page [18:17:40] The owner is aware of the problem and says it is fixed too [18:19:02] ahh, ok, good. someone mind putting a note on the bot's talk page, perhaps? just for anyone else who sees an edit by an unflagged bot and get's curious [18:20:11] or whatever. sorry for not checking RFP first [18:20:53] heh, don't be sorry... I didn't know off the top of my head either [18:21:01] if you haven't already put a note on the talk page then I can [18:21:48] oh, beat you to it [18:21:49] :p [19:00:41] Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/43465 [19:17:57] ...hummm-bom-bastiq... [19:19:20] Jeblad_WMDE: does your function work now? [19:19:31] pageprops? [19:19:45] yes, the one for the stubs special page [19:20:00] just reopened the changeset [19:20:06] k [19:20:42] Lydia_WMDE: hey :) [19:21:23] benestar: hey [19:22:34] Lydia_WMDE: the two emails have the same content, right? [19:22:49] benestar: sorry - which ones? [19:22:50] (the one about the inclusion syntax) [19:22:53] oh [19:22:54] no [19:22:59] they're slightly different [19:23:01] hu? [19:23:10] but i guess denny just copied the text and modified it a bit [19:23:18] or i screwed up the linking [19:23:28] ah, I see [19:23:31] lol [19:23:46] I really like the syntax, by the way [19:23:54] \o/ [19:24:06] that's great [19:24:13] so far people seem very happy with it [19:24:17] unlike we expected [19:24:36] is it already possible to test it life? [19:24:41] no [19:24:56] i don't think anyone started serious work on implementing it yet [19:25:17] so it is an open task yet [19:25:20] because of the needed rework of the draft [19:25:24] yeah [19:25:30] who will work on it? [19:25:47] i don't know - we have not discussed it yet [19:25:57] if you want to know more it is probably best to ask denny when he's here [19:26:11] or email the list and wait for him to reply there [19:26:53] oh i have added 3 bugs for non-JS user interface special pages if you want to hack on something [19:27:03] :) [19:27:20] Special:SetLabel already exists [19:27:26] Note that the set* pages need refactoring [19:27:40] but it is the only one, right? [19:27:54] benestar: jep - and based on that we need the same for aliases, desciptions and language links [19:27:56] jep [19:28:11] there is a bug for each of those in bugzilla [19:28:14] from today [19:28:19] can someone show me how to create a special page? [19:28:19] The special:set* pages should all subclass from one base page [19:28:33] that's true [19:28:57] benestar: probably best to look into the description one by copying the one for lables [19:29:17] ok, but I first have to find them [19:29:36] Jeblad_WMDE probably knows where to look [19:30:17] repo - includes - specials [19:30:37] There is also a page at mediawiki.org about how to write such pages [19:30:48] but we use our own baseclass [19:31:14] SpecialWikibasePage.php [19:31:25] does it already exist? [19:31:31] I am just cloning [19:31:45] That is the baseclass for all of our special pages [19:32:13] The page that exist is SpecialSetLabel.php [19:33:18] There should be a base class SpecialSetEntity.php, and it should probably work for labels, descriptions, and aliases [19:33:48] benestar: if you're working on it please leave a comment in the relevant bugs [19:33:55] so no-one else wastes time [19:34:09] That page would then be subclassed into SpecialSetItem, SpecialSetProperty and SpecialSetQuery [19:34:16] ok [19:34:23] Lydia_WMDE: how to comment? [19:34:56] benestar: just a comment saying you're working on it is fine [19:34:59] let me get you links [19:35:11] There are other ways to organize the pages, but they have other problems too [19:35:14] [20:23:43] benestar I really like the syntax, by the way <-- yeah, feels more simple [19:35:16] I htink i have to create an account first [19:35:17] https://bugzilla.wikimedia.org/show_bug.cgi?id=43870 [19:35:19] https://bugzilla.wikimedia.org/show_bug.cgi?id=43871 [19:35:20] https://bugzilla.wikimedia.org/show_bug.cgi?id=43872 [19:35:26] * Sannita is looking at previous logs [19:35:29] Sannita: \o/ [19:35:44] benestar: oh no bugzilla account yet? yes then you should get one :) [19:35:55] useful to have anyway [19:36:01] ok [19:36:07] Sannita: feel free to leave a comment on the talk page :D [19:36:26] I will, I'm trying to catch up [19:36:43] :) [19:44:19] Lydia_WMDE: is there no username at bugzilla? [19:44:33] benestar: no - it uses your email as identifier [19:44:47] ah [19:46:02] Lydia_WMDE: what should I write there? [19:46:34] benestar: "i'm working on this" or something similar is fine [19:48:14] ok [19:49:11] Jeblad_WMDE: shouldn't it be an interface? [19:49:17] or an abstract class [19:49:34] what should be? [19:49:51] the base class "SpecialSetEntity" [19:52:26] it isn't important I guess.. [19:52:39] It will not be directly accessible anyhow [19:59:02] that is if it is an abstract class [19:59:11] you can't use an interface [19:59:56] New patchset: Jeroen De Dauw; "Removed staticness from test providers" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43492 [20:16:44] New patchset: Jeroen De Dauw; "Added test to check if default casensitivity works for termcache implementations" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43499 [20:19:52] Jeblad_WMDE: SpecialSetLabel has now without comments 7 lines [20:20:13] The usual after refactoring [20:20:42] There is an options object [20:20:49] I have created the ones for set description and set aliases [20:20:52] I don't think it was used in setlabel [20:21:08] what do you mean with options object? [20:21:38] instead of using the xml soup direct, there is an class you can use [20:22:05] can you show me an example? [20:22:09] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/43499 [20:22:20] don't remember where you find it [20:22:37] a lot of special pages in the core does not use it so its not important [20:23:08] ok, noprob [20:23:19] I think SpecialSetLink [20:23:33] cannot be done right now because setClaims does not exist yes [20:23:52] Try to adhere to the naming already used [20:23:59] SetSitelink [20:24:21] but there is no function in Entity class [20:24:31] And there is a difference between claims and statements, not sure if it is important [20:25:00] A SetStatement class would subclass from SetClaim [20:25:12] Possibly with a plural s.. [20:28:46] Jeblad_WMDE: is there a special rule how to create comments? [20:29:21] You should try to use complete sentences [20:29:36] Capital letter and sentence terminators [20:29:36] nothing more? :P [20:30:00] Comment what is difficult and the abstract idea you try to implement [20:30:08] Use phpdoc [20:30:23] Document parameters, throws and return values [20:30:26] php doc? [20:30:36] And add sinse [20:30:49] The stuff above the functions [20:31:39] http://www.mediawiki.org/wiki/Manual:Coding_conventions [20:32:28] And we like it if you structure things so we can use unit tests, and at least integration tests [20:32:42] That means parsable html soup [20:32:57] ..easilly parsable.. [20:33:09] :/ [20:33:33] Jeblad_WMDE: I will create the commit and you look if it is ok? [20:34:10] And prepare for spanking by The Gods of Translations, The Lesser Gods of Sprellchecking, and the minor gods of ball-throwing (Jeroen) [20:34:22] xD [20:34:41] Jeblad_WMDE: what is the current version? [20:35:04] And a word written wrong in the commit message and you will get complaints [20:35:29] Kill the servers and everybody tries to avoid to take the blame.. ;) [20:35:42] 0.4 alpha [20:36:04] Call it 0.4 aka Bamsemums [20:36:37] lol [20:37:02] Jeblad_WMDE: what does "use Wikibase\Autocomment;" mean? [20:37:17] Bamsemums is the goodie stuff we are depending on [20:37:55] Autocomments is the magical stuff that creates localized summaries [20:38:46] It will not work without additions to the i18n file, forget it for now [20:39:31] ok, thankx [20:39:52] Jeblad_WMDE: do you know that developing status of adding static redirects? far away? [20:40:28] I mentioned it the other day but it is said to be a non-blocker for now [20:58:29] Jeblad_WMDE: everywhere are comments [20:58:36] I think it is ready to commit [20:58:43] will you have a look at it? [21:00:11] DanielK_WMDE: Sorry, I was at lunch [21:02:23] benestar, just add [DO NOT SUBMIT] in the first line in the commit message, then other can give you input on it too [21:03:28] ok [21:04:14] Lydia_WMDE: to be honest I think what these guys are doing has a higher awesome factor then our weekly QA: http://www.twitch.tv/uberchannel/b/344229715 [21:04:44] for one, they are using a cheesy greenscreen [21:05:24] jeroendedauw_: lol [21:05:25] ok... [21:07:18] Jeblad_WMDE: what has to be in the commit message? [21:07:51] the first commit message should have a first line like [21:08:08] (Bug #) this is a short desscriptive string [21:08:43] After that you add a newline and then a more complete description of what's contained in the commit [21:09:03] You post the commit with.. [21:09:10] git commit [21:09:27] that is to your local repo [21:09:50] Hm, before that you need something like git add repo/ [21:10:18] That will add your changes in the repo/ subtree to what is commited [21:10:28] already done ;) [21:10:30] Then you use git review [21:10:47] preilly: i'm about to go afk for a few minutes, but you can pick Jeblad_WMDE's and jeroendedauw_'s brain until then :) [21:11:06] Jeblad_WMDE: and [DO NOT SUBMIT] in the first line, right? [21:11:20] that should post it to the upstream repository and then you get a message here [21:11:32] yes, at the end of the line [21:12:10] (Bug somenumber) Descriptive headline [DO NOT SUBMIT] [21:12:47]