[00:20:27] <Jeblad_WMDE>	 sort of, movietime...
[00:54:22] <Sdream>	 Is Wikidata a content project or a backstage project?
[00:57:49] <Riley>	 Sdream: Er both, mainly a content project though (If I am correct)
[08:18:52] <gerrit-wm>	 New patchset: Daniel Kinzler; "(minor) add wfDebugLog calls to onWikiPollHandle." [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/37792
[08:21:56] <gerrit-wm>	 New patchset: Daniel Kinzler; "(minor) add wfDebugLog calls to onWikiPollHandle." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37793
[08:25:30] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42910) load sitelinks from table, not item object." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37794
[08:27:14] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42910) load sitelinks from table, not item object." [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/37795
[08:31:05] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42910) load sitelinks from table, not item object." [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37796
[09:12:11] <gerrit-wm>	 New review: Jeroen De Dauw; "Please fix the docs as described here: https://gerrit.wikimedia.org/r/#/c/37796/" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/37794
[09:53:41] <Silke_WMDE>	 Moin! Has anyone heard "globalblocking" before? Our devclient is complaining about a missing database (sic) with this name.
[10:01:33] <aude>	 moin!
[10:08:34] <johl>	 moin"
[10:08:38] <johl>	 moin.
[10:11:31] <aude>	 Silke_WMDE: $wgGlobalBlockingDatabase = 'globalblocking';
[10:12:01] <aude>	 you can disable the GlobalBlocking extension.... can't see how it's useful for testing to have it enabled
[10:26:39] <Lydia_WMDE>	 DanielK_WMDE: Reedy: http://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#dB_Error
[10:26:43] <Lydia_WMDE>	 can you help with this?
[10:27:17] <Lydia_WMDE>	 or aude?
[10:28:20] <aude>	 Lydia_WMDE: https://bugzilla.wikimedia.org/42547
[10:28:38] <Lydia_WMDE>	 aude: thanks!
[10:28:49] <aude>	 we are aware though DanielK_WMDE_ or someone else would be better to fix it
[10:29:07] <Lydia_WMDE>	 k
[10:29:15] <Lydia_WMDE>	 i'll leave a note on the page
[10:29:17] <aude>	 i think we're going to drop the constraints on label uniqueness, etc. and that might help
[10:29:42] <aude>	 right now, it's doing a bunch of checks when saving and then the error happens somehow, sometimes
[10:54:33] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37227
[11:53:29] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(no bug) added cond.wait for pref tabs in selenium tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37818
[11:54:23] <gerrit-wm>	 New patchset: Anja Jentzsch; "(bug 42817) continuation logic for pollForChanges." [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37819
[11:55:41] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37819
[11:56:25] <gerrit-wm>	 New patchset: Anja Jentzsch; "Use EditEntity in removeclaims and added token requirement" [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37820
[11:57:03] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37820
[11:57:47] <gerrit-wm>	 New patchset: Anja Jentzsch; "(bug 42768) Avoid error for history of missing page." [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37821
[11:58:47] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37821
[12:00:18] <Silke_WMDE_>	 The demo system is going to die and resurrect with a newer php version.
[12:01:55] <gerrit-wm>	 New patchset: Anja Jentzsch; "(Bug 42762) Corrected the message key of wbeditentity" [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37822
[12:02:18] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37822
[12:02:20] <aharoni>	 hallo Silke_WMDE_ 
[12:02:27] <aharoni>	 are you working on the clients? and when you're done, will they be clients for the live wikidata.org?
[12:07:36] <Silke_WMDE_>	 aharoni: I'll start to work on the clients in a few minutes. They will stay client for our test repo, not the live one.
[12:07:49] <aharoni>	 OK, thanks.
[12:08:47] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37245
[12:14:52] <Silke_WMDE_>	 DanielK_WMDE_: Does it make sense to keep the items in the main name space on test?
[12:17:23] <DanielK_WMDE_>	 Silke_WMDE_: i'd say yes, we want to be close to the production setup there
[12:17:28] <Silke_WMDE_>	 ok
[12:18:32] <DanielK_WMDE_>	 aharoni: re cleints for wikidata.org, see bug 42825 and 42911
[12:18:46] <DanielK_WMDE_>	 aharoni: there *is* a client, it just doesn't work :)
[13:08:37] <AnjaJ_WMDE>	 http://192.168.2.251:8080/job/wikibase-phpunit/lastFailedBuild/console
[13:11:07] <gerrit-wm>	 New patchset: Anja Jentzsch; "(Bug 42826) Fix method name in ChangeRowTest due to change in ORMRowTest" [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37830
[13:11:42] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37830
[13:12:32] <gerrit-wm>	 New patchset: Anja Jentzsch; "(Bug 42826) Fix method name in CachedEntityTest due to change in ORMRowTest" [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37831
[13:13:25] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37831
[13:32:27] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42910) load sitelinks from table, not item object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37794
[13:33:07] <gerrit-wm>	 New review: Aude; "When running pollforchanges, I get:" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/37232
[13:33:29] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42910) load sitelinks from table, not item object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37794
[13:35:21] <aude>	 DanielK_WMDE_: you still want https://gerrit.wikimedia.org/r/#/c/37427/ in wmf5?
[13:35:35] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42910) load sitelinks from table, not item object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37794
[13:36:07] <DanielK_WMDE_>	 aude: nope. will abaondon it
[13:36:17] <aude>	 ok
[13:36:17] <gerrit-wm>	 Change abandoned: Daniel Kinzler; "never mind" [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/37427
[13:37:04] <aude>	 i'm okay with the debug log stuff in there, for now (preferably not permanently, though)
[13:38:28] <gerrit-wm>	 Change abandoned: Daniel Kinzler; "wmf5 is about to die, stick with wmf6" [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/37795
[13:41:11] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42910) load sitelinks from table, not item object" [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37796
[13:41:47] <DanielK_WMDE_>	 aude: compare the debug stuff e.g. in ExternalStoreDB
[13:41:55] <DanielK_WMDE_>	 aude: that's just as verbose, I'd say... 
[13:42:13] <DanielK_WMDE_>	 why don't you like that? I'm fine with having debug output all over the place
[13:42:16] <DanielK_WMDE_>	 i see no problem wit hit
[13:43:07] <DanielK_WMDE_>	 we could however use wfDebugLog( __CLASS__, __FUNCTION__ . " ..." ) instead of wfDebugLog( 'wikibase', __METHOD__ . " ..." )
[13:46:02] <gerrit-wm>	 New review: Daniel Kinzler; "@aude: I228161f9 implements access to sitelinsk via the lookup table. No caching (yet), though." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/37232
[13:50:15] <aude>	 DanielK_WMDE_: if i'm debugging, then wfDebug or my own debug stuff is good
[13:50:42] <DanielK_WMDE_>	 and when is it bad?
[13:51:11] <aude>	 if people like it, then suppose we can have it
[13:51:14] * aude  will ignore it

[13:52:58] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42769) No entity data in EntityChange objects." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37232
[13:53:15] <DanielK_WMDE_>	 well, just like wfProfileIn, it's ugly, but useful :)
[13:54:31] <DanielK_WMDE_>	 AnjaJ_WMDE: i'll be off from 16:15 until  about 19:30
[13:55:03] <DanielK_WMDE_>	 i know this sucks, but i have to go admire my daughter perform at school :P
[13:55:40] <AnjaJ_WMDE>	 ok, we shouldn't start before 8pm like usually I think
[13:55:50] <AnjaJ_WMDE>	 have fun and please be back ;)
[13:56:29] * aude  thinks the deployment tonight takes no more than 5 min

[13:56:56] <aude>	 more like 2-3 min
[13:57:13] <aude>	 no database locking
[14:01:53] <DanielK_WMDE_>	 ...and we are not touching the client. as far as i know
[14:02:04] <DanielK_WMDE_>	 AnjaJ_WMDE. aude: tonights deployment is repo only, right?
[14:02:09] <DanielK_WMDE_>	 do we know when the client is due?
[14:02:23] <DanielK_WMDE_>	 would be nice for that to be next monday - you know, alternating weeks
[14:02:37] <aude>	 we can update the client for test2 tonight
[14:02:45] <AnjaJ_WMDE>	 for now phpunit is fine but selenium returns a lot of failures, waiting for the report
[14:02:55] <AnjaJ_WMDE>	 had to back port 2 more things that john fixed on friday
[14:03:01] <aude>	 the first deployment of wmf6 is usually mediawiki.org, test2 and wikidata
[14:03:04] <gerrit-wm>	 New review: John Erling Blad; "One comment, but it verifies and seems sound as it is." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37794
[14:03:09] <aude>	 including all the extensions getting updated
[14:04:05] <gerrit-wm>	 New review: John Erling Blad; "Sorry, verified wrong patchset, will do a rerun." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37794
[14:04:38] <DanielK_WMDE_>	 JeroenDeDauw: how to procede? https://gerrit.wikimedia.org/r/#/c/37233/
[14:05:32] <AnjaJ_WMDE>	 http://192.168.2.251:8080/job/wikibase-selenium-win7-local/357/console firefox failures report is there
[14:05:35] <AnjaJ_WMDE>	 40 
[14:07:11] <gerrit-wm>	 New review: Daniel Kinzler; "@reedy: Jenkins runs SQLite. Anything that's not compatible withh not pass. So either make it compat..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/37485
[14:13:05] <gerrit-wm>	 New review: John Erling Blad; "Seems fine, master still works... ;)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37794
[14:13:37] <gerrit-wm>	 New review: John Erling Blad; "Oh, the merge conflict.. Its not merged at all! :D" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37794
[14:15:21] <gerrit-wm>	 Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37013
[14:17:51] <Jeblad_WMDE>	 DanielK_WMDE_: Sorry for the mess, ..
[14:18:37] <Jeblad_WMDE>	 DanielK_WMDE_: There is a mergeconflict in your changeset https://gerrit.wikimedia.org/r/#/c/37794
[14:20:31] <DanielK_WMDE_>	 Jeblad_WMDE: grr
[14:21:10] <Jeblad_WMDE>	 Pøh, I create fuckups as fast as I can, I can't make them faster! =)
[14:25:13] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42910) load sitelinks from table, not item object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37794
[14:25:22] * aude  wonders why i have some entries missing in wb_entity_per_page but exist in page and wb_changes table?

[14:25:26] <DanielK_WMDE_>	 Jeblad_WMDE: fixed
[14:25:41] <DanielK_WMDE_>	 aude: new ones, or old?
[14:25:49] <aude>	 older ones
[14:26:00] <aude>	 but not that old
[14:26:17] <DanielK_WMDE_>	 aude: wb_entity_per_page isn't updated on edit, only on page creation...
[14:26:36] <DanielK_WMDE_>	 aude: hm, maybe a good opportunity to try out Jens' script? It should find and report them.
[14:26:40] <DanielK_WMDE_>	 finally a way to test that :)
[14:26:49] <aude>	 huh
[14:26:50] <DanielK_WMDE_>	 and then use rebuildEntityPerPage to fix it
[14:27:07] <DanielK_WMDE_>	 (still leaves the question "why")
[14:27:09] <aude>	 first try to replicate
[14:27:23] <DanielK_WMDE_>	 right. but i suspect it was an old error, now fixed
[14:27:40] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37794
[14:27:46] <aude>	 those entities are from wednesday
[14:28:03] <aude>	 ooooh, modern skin when i log into my test repo :D
[14:30:21] * Jeblad_WMDE  pulls out his .44 magnum and shoots Modern in between the eyes

[14:30:46] <aude>	 heh
[14:30:52] <aude>	 it's beautiful skin
[14:32:22] <Jeblad_WMDE>	 It sucks "hesteballe"
[14:32:31] <aude>	 all my test users have a different skin :D
[14:32:43] * aude  now logged in with cologne blue :)

[14:32:46] <Jeblad_WMDE>	 Thats untranslatable
[14:33:07] <Jeblad_WMDE>	 Urgh, my eyes..
[14:34:53] <gerrit-wm>	 New review: Daniel Kinzler; "looks good in general, just a naming issue." [mediawiki/extensions/DataValues] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/37242
[14:35:51] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/37222
[14:54:17] <gerrit-wm>	 New review: Aude; "Works for me, and is general improvement." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37232
[14:54:18] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37232
[15:01:28] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37818
[15:02:20] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/37792
[15:03:19] <gerrit-wm>	 New review: John Erling Blad; "Seems okey." [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37409
[15:03:19] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/37409
[15:05:42] <gerrit-wm>	 New patchset: Aude; "(minor) add wfDebugLog calls to onWikiPollHandle." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37793
[15:05:52] <gerrit-wm>	 New review: Aude; "rebased" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/37793
[15:06:28] <gerrit-wm>	 New review: John Erling Blad; "This has a pending submit and I think it is safe to submit this also if there is only a naming issue..." [mediawiki/extensions/DataValues] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/37242
[15:06:30] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37793
[15:12:19] <gerrit-wm>	 New review: John Erling Blad; "Muahahaha.." [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37242
[15:31:07] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(no bug) selenium tests now injecting old revid to revisionStore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37840
[15:40:33] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37840
[15:48:41] <gerrit-wm>	 New patchset: Aude; "Processign all changes! -> Processing all changes!" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37843
[15:56:34] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37843
[16:28:42] <benestar_>	 ei	[[WD:N]]
[16:28:44] <AsimovBot>	 10[1] 10https://wikidata.wikidata.org/wiki/Wikipedia_Discusi%C3%B3n:N
[16:41:58] <gerrit-wm>	 New patchset: John Erling Blad; "(Bug 42797) Special:CreateItem has 2 createitem-summary labels" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37850
[16:55:53] <gerrit-wm>	 New patchset: John Erling Blad; "(Bug 42868) Remove wikibase-error-relational-save-failed" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37853
[17:21:43] <gerrit-wm>	 New review: John Erling Blad; "Self-submitting this before it collides with updates from TWN." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37853
[17:21:44] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37853
[17:33:34] <gerrit-wm>	 New patchset: Aude; "(bug 42918) use site link table only in poll for changes hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37856
[19:27:47] <gerrit-wm>	 New patchset: Aude; "(minor) add wfDebugLog calls to onWikiPollHandle." [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37865
[19:28:15] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (mw1.21-wmf6) - https://gerrit.wikimedia.org/r/37865
[19:29:43] <aude>	 AnjaJ_WMDE wins the bet! (taking more than 5 min) :/
[19:39:01] <AnjaJ_WMDE>	 aude, didn't want to jinx it :p
[19:42:32] <gerrit-wm>	 New patchset: Daniel Kinzler; "(bug 42918) use site link table only in poll for changes hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37856
[19:42:50] <aude>	 scap takes a bit longer when it's core + extensions
[19:43:45] <aude>	 plus submodules... :)
[19:47:44] <gerrit-wm>	 New review: Daniel Kinzler; "I absolutely agree with always getting links from the table. But I disagree with changing the logic ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/37856
[19:48:05] <kaldari>	 I have a question: Since we're currently scraping most the Wikidata data from en.wiki's interlanguage links, why don't we just import the en.wiki langlinks table?
[19:55:51] <kaldari>	 DanielK_WMDE_: ^
[19:56:45] <DanielK_WMDE_>	 kaldari: import how and into what?
[19:56:56] <DanielK_WMDE_>	 kaldari: also: "because we don't to content, the community does content"
[19:57:59] <kaldari>	 import the same way the bots are importing, just just directly from the database
[19:58:19] <kaldari>	 so that it won't take a year to finish
[19:58:38] <kaldari>	 not sure what you mean about content
[20:00:27] <kaldari>	 like write a script that converts the en.wiki langlinks table into wikidata inserts
[20:00:36] <Lydia_WMDE>	 kaldari: because there needs to be a community to maintain the stuff
[20:00:42] <Lydia_WMDE>	 and write descriptions and so on
[20:00:48] <Lydia_WMDE>	 that is growing now
[20:00:53] <kaldari>	 sure, why wouldn't they be able to do that?
[20:01:09] <Lydia_WMDE>	 because a community needs to grow
[20:01:14] <Lydia_WMDE>	 it doesn't magically appear
[20:01:16] <Lydia_WMDE>	 ;-)
[20:01:25] <kaldari>	 huh?
[20:01:47] <kaldari>	 I'm not sure you're understanding what I'm suggesting
[20:01:53] <gerrit-wm>	 New review: Hashar; "Re triggering gate job due to bug 42916 https://bugzilla.wikimedia.org/show_bug.cgi?id=42916" [mediawiki/extensions/DataValues] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/37246
[20:02:16] <aude>	 DanielK_WMDE_: changeNeedsRendering() really does nothing but check if there is a non-empty site link diff
[20:02:16] <Lydia_WMDE>	 i am saying that just doing the import in one go would be bad
[20:02:35] <Lydia_WMDE>	 because the community needs to grow with the content
[20:02:46] <Lydia_WMDE>	 and not be put infront of a ready-made thing
[20:03:06] <gerrit-wm>	 New review: Hashar; "Re triggering gate job due to bug 42916 https://bugzilla.wikimedia.org/show_bug.cgi?id=42916" [mediawiki/extensions/DataValues] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/37242
[20:03:40] <kaldari>	 the community would grow anyway with the infobox data, since that isn't possible to easily import
[20:03:58] <kaldari>	 i.e. we would still need lots of bot writers for that
[20:04:33] <DanielK_WMDE_>	 aude: the intention is that in phase2, it will return false for changes to labels, and sitelinks, and true for changes to properties.
[20:04:43] <kaldari>	 wouldn't it be better to have all the bot writers writing bots to verify and correct the interlanguage data, rather than scraping it?
[20:04:59] <kaldari>	 seems like a waste of effort
[20:05:07] <Lydia_WMDE>	 in the long run it is not
[20:05:26] <aude>	 DanielK_WMDE_: errr, ok
[20:05:46] <DanielK_WMDE_>	 kaldari: the code is already there. also, if they want to, they can. most bot authors have a toolserver account and can just use the langlink table
[20:05:50] <DanielK_WMDE_>	 several do
[20:06:01] <DanielK_WMDE_>	 or at least,. so *something* with the database
[20:06:25] <DanielK_WMDE_>	 but it's nothing *we* (the development team) would do
[20:06:51] <kaldari>	 Ah, OK, now I understand your comment about "content" :)
[20:10:45] <aude>	 DanielK_WMDE_: so, i suggest for now the stuff i have inside the if ( changeNeedsRendering ) block, 
[20:11:09] <aude>	 it could just be pagesAffected or pagesToUpdate()
[20:11:51] <kaldari>	 So what if a community member who also happens to be a developer was interested in mass importing interlang links by writing a MediaWiki maintenance script to do so directly? Would the wikidata development team object to it?
[20:11:52] <DanielK_WMDE_>	 aude: why did you change the control structure at all? imho it should just stay as it was before. only instead of loading the item, load the sitelinsk directly.
[20:12:30] <DanielK_WMDE_>	 aude: i agree that this can be made nicer by restructuring it, but i think it's not a good idea to mix this into this patch
[20:12:35] <kaldari>	 just curious :)
[20:12:42] <DanielK_WMDE_>	 we need to re-think and re-write this anyway as a proper job.
[20:12:52] <aude>	 DanielK_WMDE_: you have a bit of duplication,e tc.  going on
[20:13:15] <DanielK_WMDE_>	 kaldari: i would object to it as a community member. the dev team really has no say in this.
[20:13:43] <DanielK_WMDE_>	 kaldari: i'd object on the ground of "too fast, beyond capability of review"
[20:13:51] <Lydia_WMDE>	 what DanielK_WMDE_ said
[20:14:18] <kaldari>	 understood, although I would argue we're already beyond capability of review, which is why I suggested the idea.
[20:14:42] <Lydia_WMDE>	 then let's not make it even worse
[20:14:49] <kaldari>	 fair enough :)
[20:15:20] <kaldari>	 thanks for discussing with me anyway
[20:16:25] <Lydia_WMDE>	 np
[20:16:27] <DanielK_WMDE_>	 kaldari: suggest it on the project chat page :)
[20:16:31] <DanielK_WMDE_>	 or on the mailing list
[20:16:40] <DanielK_WMDE_>	 maybe people love it, who knows :)
[20:17:02] <Lydia_WMDE>	 please don't ;-)=
[20:17:09] <kaldari>	 I mentioned the idea on the project chat page a few days ago, but no one responded to it
[20:17:37] <kaldari>	 I think it got lost in another discussion
[20:18:33] <notconf>	 kaldari, I was going to propose such interlang mass importing
[20:19:17] <notconf>	 but via bot, following certain heavily used templates and their analogues on different wiki's, should I still propose this bot?
[20:19:29] <Lydia_WMDE>	 notconf: bots already exist
[20:19:32] <Lydia_WMDE>	 and are running
[20:20:05] <notconf>	 is there any need for more interlang importing by bot?
[20:20:14] <Lydia_WMDE>	 if you ask me no ;-)
[20:20:16] <Lydia_WMDE>	 but...
[20:20:22] <notconf>	 or shall i just skip striaght to phase 2 bots on the test server?
[20:20:38] <Lydia_WMDE>	 that'd be my suggestion
[20:21:02] <notconf>	 do i need to apply for a botflag on the test server?
[20:21:12] <Lydia_WMDE>	 no
[20:21:59] <notconf>	 wikidata-test or wikidata-test-repo?
[20:22:12] <notconf>	 ah nvm, i see
[20:22:19] <Lydia_WMDE>	 :)
[20:23:12] <gerrit-wm>	 New patchset: Aude; "(bug 42918) use site link table only in poll for changes hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37856
[20:24:15] <gerrit-wm>	 New review: Aude; "I think it's not really better to do it this way, but whatever and this also works. :)" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/37856
[20:46:09] <gerrit-wm>	 New review: Daniel Kinzler; "didn't test it, but looks good." [mediawiki/extensions/Wikibase] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/37856
[20:48:43] <gerrit-wm>	 New patchset: Aude; "(bug 42918) use site link table only in poll for changes hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37856
[20:52:58] <gerrit-wm>	 New review: Daniel Kinzler; "didn't test this, but looks good" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2;  - https://gerrit.wikimedia.org/r/37856
[20:54:21] <aude>	 DanielK_WMDE_: thanks for code reviewing
[20:58:46] <DanielK_WMDE_>	 aude: waiting for the deploy to happen has its uses :)
[20:59:29] <gerrit-wm>	 Change abandoned: Aude; "thanks for the comments." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/37226
[21:00:18] <aude>	 DanielK_WMDE_: so, tomorrow i can look at batching changes again and can setup my own external store for testing stuff
[21:00:47] <DanielK_WMDE_>	 aude: i'd like to do job queue stuff before batching. but that's not a strong preference
[21:00:50] <aude>	 try out more directly how external store works
[21:01:12] <aude>	 DanielK_WMDE_: batching is to consolidate some queries, such as recent change saves
[21:01:29] <aude>	 nothing more right now
[21:01:47] <DanielK_WMDE_>	 yea, i understand
[21:02:55] <aude>	 it's silly the way the change handler does a loop now
[21:03:42] <AnjaJ_WMDE>	 aude, DanielK_WMDE_: any idea how much more time deployment will take?
[21:04:02] <DanielK_WMDE_>	 no idea, you'll have to ask ^demon
[21:04:18] <aude>	 http://wikidata.org/wiki/Special:Version
[21:04:20] <aude>	 not done yet
[21:04:34] <aude>	 21:03 <+logmsgbot> !log demon Finished syncing Wikimedia installation... :
[21:04:40] <aude>	 looks like it's done just about
[21:04:42] <AnjaJ_WMDE>	 I'm reloading that too, aude ;)
[21:04:53] <aude>	 21:03 <+logmsgbot> !log demon rebuilt wikiversions.cdb and synchronized wikiversions files: test2wiki also on 1.21wmf6
[21:04:57] <aude>	 test2 first
[21:05:15] <aude>	 https://test2.wikipedia.org/wiki/Special:Version yay!
[21:05:55] <AnjaJ_WMDE>	 :)
[21:06:02] <aude>	 looks functional but still no lang links
[21:07:21] <Abraham_WMDE>	 aude: great!
[21:11:45] <gerrit-wm>	 New review: Daniel Kinzler; "looks like a nice simplification. but I've got a naming nitpick" [mediawiki/extensions/DataValues] (master); V: 0 C: 1;  - https://gerrit.wikimedia.org/r/37239
[21:13:20] <aude>	 AnjaJ_WMDE: is there a reason we didn't backport https://gerrit.wikimedia.org/r/#/c/37796/ ?
[21:13:56] <aude>	 it's probably ok for now, as we can test and debug the external store, but then
[21:14:00] <AnjaJ_WMDE>	 wasn't done until noon today
[21:14:01] <AnjaJ_WMDE>	 ?
[21:14:10] <aude>	 put that one in and the language links should appear
[21:15:07] <aude>	 AnjaJ_WMDE: no big deal
[21:15:50] <AnjaJ_WMDE>	 sorry aude
[21:16:16] <aude>	 it's okay.  we'll at least be able to debug :)
[21:16:18] <AnjaJ_WMDE>	 rerunning the tests just takes some hours and we did all the list from friday plus johns two commits
[21:16:49] * aude  wish the tests were quicker

[21:19:23] <aude>	 deployment is done!
[21:19:29] <aude>	 enjoy the new codes :)
[21:30:37] <aude>	 wow, almost 750,000 items!
[21:40:30] <Vogone|backup>	 tsja, we have busy bots :-)
[22:33:11] <gerrit-wm>	 New review: John Erling Blad; "This should probably work now.." [mediawiki/extensions/DataValues] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/37242