[00:27:22] New patchset: Jeroen De Dauw; "Fixes for 1dcfeea564586940035384688a2813000baf82d7" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36489 [00:27:22] New patchset: Jeroen De Dauw; "(sec audit) Fix permission and token checks in API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36478 [00:27:33] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36478 [00:27:43] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36489 [00:41:22] New review: Jeroen De Dauw; "heh? On all the places you do the cast it already is an int. Look at the constructor, anything not a..." [mediawiki/extensions/Wikibase] (master); V: 0 C: -2; - https://gerrit.wikimedia.org/r/36393 [00:50:16] New patchset: Jeroen De Dauw; "escape var in query construction" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36490 [01:13:01] New patchset: Jeroen De Dauw; "Finisged setqualifier API module and added tests [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36210 [01:13:02] New patchset: Jeroen De Dauw; "Added setqualifier API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35648 [07:26:24] Hallo. [07:26:49] What is the source of the word "snak"? Is it a completely internal Wikidata-invented jargon or is it based on a word or an acronym? [08:59:08] New patchset: Henning Snater; "Optimizing jquery suggester events" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36501 [09:18:11] New review: Daniel Kinzler; "addQuotes is NOT a replacement for intval!" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/36490 [09:18:36] AnjaJ_WMDE: jeroens letzten fix hab ich gerade auf -1 gesetzt. https://gerrit.wikimedia.org/r/#/c/36490/ [09:25:19] Hallo. What is the source of the word "snak"? Is it a completely internal Wikidata-invented jargon or is it based on a word or an acronym? [09:25:47] Hi all & DanielK_WMDE: I'm making us a new dev server right now [09:26:29] aharoni: it's entirely arbitrary. [09:26:52] aharoni: we needed a word that wasn't didn't have a close-but-noit-quite meaning and would thus not be misleading [09:26:59] so we invented one [09:27:48] (it's also a verb in lower german dialect meaning to chat ot chatter, but that's not the reason) [09:28:10] DanielK_WMDE: Thanks. I was wondering how to translate it. There's another question about it at https://www.wikidata.org/wiki/Wikidata_talk:Glossary#SNAK . [09:28:30] New patchset: Daniel Kinzler; "(sec audit) Fix permission and token checks in API" [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36504 [09:28:30] New patchset: Daniel Kinzler; "(no bug) Kill race condition in EntityPerPageTable." [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36505 [09:28:31] New patchset: Daniel Kinzler; "(sec audit) check permissions when creating enitites." [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36506 [09:28:31] New patchset: Daniel Kinzler; "(sec audit) fix several escaping issues." [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36507 [09:29:25] New review: Daniel Kinzler; "self-approving backport to deployment branch" [mediawiki/extensions/Wikibase] (mw1.21-wmf5); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36507 [09:29:33] New review: Daniel Kinzler; "self-approving backport to deployment branch" [mediawiki/extensions/Wikibase] (mw1.21-wmf5); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36506 [09:29:54] New review: Daniel Kinzler; "self-approving backport to deployment branch" [mediawiki/extensions/Wikibase] (mw1.21-wmf5); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36505 [09:30:40] New review: Daniel Kinzler; "self-approving backport to deployment branch" [mediawiki/extensions/Wikibase] (mw1.21-wmf5); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36504 [09:30:40] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36507 [09:30:40] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36505 [09:30:40] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36506 [09:30:40] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36504 [09:35:09] AnjaJ_WMDE: banch mw1.21-wmf5 now has the 4 patches from yesterday merged. [09:35:38] Jeroen's change to pollForChanges is pending (I don't think that fix is a good idea). [09:35:59] There's one or two minor issues I didn't resolve yesterday. I'll work on these now. [09:36:13] anyway... [09:36:22] is reedy back? or who's doing the deployment [09:36:24] ? [09:41:39] New patchset: Daniel Kinzler; "(no bug) limit maxag to 30 days." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36508 [09:44:26] AnjaJ_WMDE: minor follow-up fix: https://gerrit.wikhttps://gerrit.wikimedia.org/r/#/c/36508/imedia.org/r/#/c/36508/ [09:48:33] DanielK_WMDE: I think chad will do the deployment [09:48:47] DanielK_WMDE: you want to dial in for the daily? [09:52:03] Abraham_WMDE: no, i think it makes more sense to skype in later to discuss what we need to do for the deployment [09:52:14] i'll write a quick mail for the daily [09:52:27] we can do that talk right after the daily, if denny is there [09:53:11] DanielK_WMDE: ok, denny is here [09:54:32] New patchset: Henning Snater; "Removing use of jquery.html from suggester jquery widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36510 [09:55:55] New review: Jeroen De Dauw; "Look at the documentation - it's an int, not a string." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36490 [10:01:10] New patchset: Tobias Gritschacher; "(no bug) removed @cover annotation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36511 [10:04:24] JeroenDeDauw: hello :) I am going to apply the new Jenkins workflow on some of your extensions ( DataValues, Diff, Validator ). The old jobs will still be around though :) [10:05:50] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36511 [10:14:17] New review: Hashar; "recheck" [mediawiki/extensions/DataValues] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32768 [10:15:08] New review: Daniel Kinzler; "It doesn't matter whether it's an int, addQuotes will turn it into a string literal, unless it is null." [mediawiki/extensions/Wikibase] (master); V: 0 C: -1; - https://gerrit.wikimedia.org/r/36490 [10:16:39] New review: Hashar; "recheck" [mediawiki/extensions/DataValues] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/32768 [10:17:14] Change abandoned: Hashar; "(no reason)" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/32768 [10:19:10] Change abandoned: John Erling Blad; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36393 [10:24:36] New review: Jeroen De Dauw; "If that's the case I'm misunderstanding the intention of the method and am also using it incorrectly..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36490 [10:42:22] New review: Daniel Kinzler; "I looked into DatabaseBase::makeList(), which is also used for building conditions from arrays, and ..." [mediawiki/extensions/Wikibase] (master); V: 0 C: 0; - https://gerrit.wikimedia.org/r/36490 [10:43:39] Denny_WMDE, Abraham_WMDE1, AnjaJ_WMDE: what's the plan foir the deployment? shall we coordinate about what is todo to get this out the door? [10:44:05] if not now, I'll be off for lunch (missed breakfast) [10:44:26] DanielK_WMDE: as far as I can tell Anja and you have an overview of everything that has to be fixed and backported [10:44:37] then we notify Chris when our tests pass [10:44:56] ok. i think there's one more fix by henning that has to go in. [10:45:09] DanielK_WMDE: the plan is: take your branch, integrate Henning_WMDE s fix (once it's there), run tests, tell Chad to deploy it [10:45:12] yes, i am pinging Henning_WMDE to have this top priority [10:45:17] no [10:45:25] not tell chad to deploy it [10:45:32] wait for Chris to OK it [10:45:41] and then tell Chad to deploy it, pending Chris' OK [10:45:50] ok [10:46:08] do you need me on any of this? otherwise i'll start working on my other stuff. [10:46:45] AnjaJ_WMDE, Denny_WMDE: oh, right, there's also jeroen's fix. we got into an argument there, but it's pretty academic by now. i'll verify and merge. [10:46:50] i'll let you know [10:47:35] so you resolved the argument with JeroenDeDauw? that is good [10:48:02] yes, it hinges now on Henning_WMDE fix and JeroenDeDauw fix merged by you [10:48:07] then we can start running the tests [10:49:08] Denny_WMDE: well, basically, we hit upon a pretty central place in core code that is poorly documented and unclear. the question who to get it right is still unresolved. [10:49:23] but i think we shouldn#t block on this. [10:49:31] so i'll just look whether it works. [10:50:55] ah it is the intval thing [10:51:05] i thought you were talking bout the setting thing [10:51:31] New patchset: Henning Snater; "Removing use of jquery.html from suggester jquery widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36510 [10:51:57] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36276 [10:54:21] New review: Daniel Kinzler; "Ok, verified that this works as expected on MySQL. " [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36490 [10:54:21] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35648 [10:54:22] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36490 [10:54:54] Denny_WMDE: if you're under the impression me and DanielK_WMDE are having some non-friendly argument then that's not the case, at least not from my side [10:55:06] Sorry if anything came off wrong, rather tired [10:55:49] JeroenDeDauw: good to hear that, it's the same for me. [10:55:55] good :) [10:55:59] in that case I am happy [10:56:15] JeroenDeDauw: i just merged the quoting stuff. still thing that at the very least the documentation of addQuotes needs fixing. [10:56:34] DanielK_WMDE: if you are right about the addQuotes thing, that will require changes elsewhere as well. So I want to know for sure that you're wrong, or right [10:56:47] Denny_WMDE: the settings stuff went wrong in more than one way. We should probably talk about how to avoid this kind of mess in the future. [10:57:01] can we take it to wikitech? [10:57:01] Half of the team is confused now :p [10:57:08] Sure [10:57:12] yes, that was my suggestion [10:57:19] i actually have 3 issues for wikitech [10:57:29] will write the mails after lunch [10:57:31] make different mails, not one big one :) [10:57:36] indeed [10:59:17] Denny_WMDE: :( [10:59:35] JeroenDeDauw: about? [10:59:46] Now I can't hang this on DanielK_WMDE his monitor: http://bit.ly/Ub0cFQ [11:00:31] lol [11:00:37] i wont rofl [11:00:43] that would be unprofessional in the office [11:03:08] hehe :P [11:04:31] DanielK_WMDE: You have a comment in https://gerrit.wikimedia.org/r/#/c/36508/ that says this is the same as in RawAction, but after the last change it isn't the same anymore [11:05:14] We now add an constraint that isn't in RawAction, .. [11:06:30] The additional note is not important so I'm going to merge .. [11:07:56] oki, passes.. [11:08:13] Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36508 [11:10:35] New patchset: Henning Snater; "(sec audit) Removing use of jquery.html from siteselector widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36521 [11:11:48] can someone review https://gerrit.wikimedia.org/r/#/c/36521/ ? it is high prio [11:12:04] New patchset: Henning Snater; "(sec audit) Removing use of jquery.html from suggester widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36510 [11:12:13] Danwe_WMDE: TobiasG_WMDE: johl: ^^ [11:12:34] hm? [11:12:41] New patchset: Henning Snater; "(sec audit) Removing use of jquery.html from siteselector widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36521 [11:13:01] Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36510 [11:13:49] Danwe_WMDE: are you on it? https://gerrit.wikimedia.org/r/#/c/36521/ review? [11:14:05] wikidatawiki db on toolserver is unreachable again [11:14:09] johl Denny_WMDE: we're on it. :) [11:14:29] TobiasG_WMDE: thank you! [11:14:35] Merlissimo: anything we can do? [11:15:08] no, only a notice that import speed will go down [11:15:30] maybe Sebaso_WMDE can ping one of the TS-admins? [11:17:16] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36521 [11:17:25] Denny_WMDE: done [11:18:43] Denny_WMDE: should duplicate items be kept for debugging in wikidata.org, or can we delete them? https://bugzilla.wikimedia.org/show_bug.cgi?id=42325#c7 [11:19:17] Merlissimo: I would prefer to delete them. we found a possible race condition that might be responsible for that [11:19:41] AnjaJ_WMDE: DanielK_WMDE: can you backport the two patchsets by Henning as well? [11:19:54] as soon as this is done, we can probably start running the tests [11:21:22] Denny_WMDE: i can, but so can anyone else... [11:21:28] which changes? [11:21:55] Denny_WMDE: I have an idea about what could be causing the duplicates, but I havn't really *found* anything [11:22:09] https://gerrit.wikimedia.org/r/#/c/36510/ [11:22:19] https://gerrit.wikimedia.org/r/#/c/36521/ [11:22:23] DanielK_WMDE: the two changes Henning just posted [11:22:42] DanielK_WMDE: we have been trying to replicate it last week several times [11:23:03] it seems that all errors happened in a short time fram, or am I wrong Merlissimo? [11:23:13] and we cannot reproduce them again [11:23:21] not the first one [11:23:37] they all happened in the same night, no? [11:23:41] and not since then [11:23:44] or am I wrong? [11:24:15] half an hour between Q38790 and Q39272 [11:24:27] yes, but also on 13th of November [11:24:40] i wonder if something else was broken in that night that allowed that [11:24:55] New patchset: Daniel Kinzler; "(sec audit) Removing use of jquery.html from suggester widget" [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36525 [11:24:55] New patchset: Daniel Kinzler; "(sec audit) Removing use of jquery.html from siteselector widget" [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36526 [11:25:24] New review: Daniel Kinzler; "self-approving pack-port" [mediawiki/extensions/Wikibase] (mw1.21-wmf5); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36525 [11:25:25] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36525 [11:25:27] and 10,5h untl duplicate of de:Vineland (New Jersey) was created [11:25:31] New review: Daniel Kinzler; "self-approving pack-port" [mediawiki/extensions/Wikibase] (mw1.21-wmf5); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36526 [11:25:31] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36526 [11:25:52] Denny_WMDE, Henning_WMDE: i merged both into mw1.21-wmf5 [11:26:08] Denny_WMDE: three times on dec. 2nd [11:26:43] AnjaJ_WMDE: we can start the tests then [11:27:12] Merlissimo: that is bad [11:27:17] so it is not just that one night [11:27:25] i hoped :) [11:28:09] ok, so we further need to find it. the problem is we cannot reproduce it, which makes it hard to debug it [11:28:13] :P [11:28:34] on firefox on wikidata i get constantly logged out right now [11:28:37] am i the only one? [11:28:37] a script is needed that can find these duplicates. e.g. by comparing json data with wb_items_per_site [11:28:47] yes [11:29:43] Denny_WMDE: I cannot login since a month, actually [11:30:15] Sannita: it works with Chrome [11:30:23] New patchset: Aude; "add qqq message for special-entitydata" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36527 [11:30:25] all new item that were found were disambigouation pages because only in this case my bot sets label and descriptions. and another script reports item having same label and description [11:30:35] Denny_WMDE: yes, that's why I use that now [11:31:05] Sannita: it worked last week [11:31:15] Merlissimo: this also should not be possible :P [11:31:43] I'll do another try with FF today and let you know [11:31:53] same label + description is possible, but not wanted [11:32:24] DanielK_WMDE: your patchset is also in, right? [11:32:26] Denny_WMDE: i suspect the triggering factor is slave lag [11:32:28] we can start the tests [11:32:33] http://www.wikidata.org/wiki/Wikidata:Labels_and_descriptions_task_force/de#Begriffskl.C3.A4rungskonflikt [11:32:46] Denny_WMDE: my patchset? which one? [11:32:58] i backported my four changes first thing this morning [11:33:06] hm... i guess i should backport jeroen's patch [11:33:39] ok [11:33:43] as soon as this is done [11:33:44] ping us [11:33:57] that's the last thing missing for the tests [11:34:08] New patchset: Daniel Kinzler; "escape var in query construction" [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36531 [11:34:12] i think so, yes [11:34:21] ok [11:34:27] engage [11:34:31] New review: Daniel Kinzler; "self-approving backport" [mediawiki/extensions/Wikibase] (mw1.21-wmf5); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36531 [11:34:31] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36531 [11:34:43] Denny_WMDE: yep, all is merged [11:34:55] 7 changes [11:44:27] New patchset: Daniel Werner; "Can not create instance of abstract wb.Snak anymore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36533 [11:44:27] New patchset: Daniel Werner; "(part of bug 40953) wb.Claim and wb.Statement cleanup and GUID usage" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36534 [11:44:27] New patchset: Daniel Werner; "Refactored wb.Api.createClaim" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36535 [11:44:27] New patchset: Daniel Werner; "(part of bug 40953) Added wb.Api.setClaimValue module in JS API" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36536 [11:58:40] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=612454 edit summary: /* Requirements */ rm postgres [12:01:02] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by 93.220.113.95 link https://www.mediawiki.org/w/index.php?diff=612455 edit summary: deleted deprecated config settings for client (Silke) [12:08:00] New patchset: Henning Snater; "Reinserting improved regular expression into suggester widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36539 [12:54:07] New patchset: Daniel Kinzler; "(bug 42325) Avoid race condition in SiteLinkTable." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36544 [13:02:42] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=612466 edit summary: /* Requirements */ datavalues [13:03:51] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=612467 edit summary: /* Download */ DataValues [13:04:53] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=612468 edit summary: /* Installation */ DataValues [13:06:06] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=612469 edit summary: /* Required settings */ fix syntax [13:11:40] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36527 [13:15:36] bah1 [13:15:45] had a big list of disambiguation pages [13:15:50] and like 20 of them aren't [13:15:58] time to fix my booboos [13:33:07] DanielK_WMDE: are you ok with https://gerrit.wikimedia.org/r/#/c/36205/ ? [13:34:04] Denny_WMDE1: i don't understand the details enough to have a qualified oppinion, but there is one line that looks wrong to me. [13:34:16] i commented on it half an hour ago [13:34:18] the test2wiki => false line? [13:34:22] sorry for not spotting it earlier [13:34:25] yes [13:34:34] ok. but the rest seems ok as far as you can tell, which is not very far [13:35:47] well, $wgWBSettings['useChangesTable'] = false; does need to be changed once the poll script runs [13:35:55] but there's a @todo there [13:36:22] ok. so AnjaJ_WMDE says there are things missing there? [13:36:46] it#s not matching what I have in my LocalSettings [13:37:52] DanielK_WMDE: AnjaJ_WMDE one thing at a time [13:38:03] AnjaJ_WMDE: the "family" config used on the cluster doesn't work like a normal LocalSettings.php file. [13:38:29] then enable changes table [13:38:38] then enable test2wiki [13:38:52] then pollforchanges [13:38:55] that's why I asked you to compile the settings for Chad, DanielK_WMDE [13:38:56] and pruning [13:39:13] errr, they are on gerrit [13:40:42] AnjaJ_WMDE: i don't know much about that stuff either. aude knows more. [13:41:17] it's a bit... involved. I only peeked at it a couple of times, long ago. [13:42:21] i suppose, just make sure we've tested with the client settings.... changesDatabase and repoDatabase, repoUrl and the repoNamespaces [13:42:46] * aude doesn't see any new settings in the repo [13:44:06] New patchset: Henning Snater; "AutocompleteInterface: Not reacting on event after removing input" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36549 [13:51:05] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36533 [14:00:34] New patchset: Daniel Werner; "(bug 40953) Storing value on save on existing Statements" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36553 [14:04:54] New patchset: Henning Snater; "Improving entityselector widget event handling and input validation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36554 [14:04:54] New patchset: Henning Snater; "Improving entity selector widget style" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36555 [14:11:58] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=612476 edit summary: /* WikibaseLib and WikibaseClient */ foreign database [14:18:33] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36534 [14:29:18] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36535 [14:29:35] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36536 [14:37:44] New patchset: Henning Snater; "Improving entity selector widget style" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36555 [14:38:21] New patchset: Tobias Gritschacher; "(no bug) make selenium tests independent from ULS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36562 [14:39:02] New patchset: Anja Jentzsch; "(bug 41624) Add labels to user contributions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36196 [14:47:54] New patchset: Tobias Gritschacher; "(no bug) make selenium tests independent from ULS" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36562 [14:49:24] New patchset: Henning Snater; "Fix for broken suggester/entityselecter QUnit tests in FF" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36564 [14:49:48] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36553 [14:50:55] New patchset: Tobias Gritschacher; "(no bug) add template engine qunit tests to selenium" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36565 [14:53:08] Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36564 [14:54:37] New patchset: Daniel Werner; "Minor cleanup in toolbar.js and claimview" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36566 [14:55:48] New patchset: Daniel Werner; "Minor cleanup in toolbar.js and claimview" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36566 [14:56:07] is anybody itallian speaking here? [14:59:06] e. g. Restu20 ... but I don't know, whether he's active [15:02:08] Vogone|backup: i'm here :-) [15:03:25] Restu20: Sk1d needs you ;-) [15:04:29] is it ok if my bot removes automaticly (disambigua) from the label and sets: "pagina di disambiguazione" to the description? [15:05:01] see: https://de.wikipedia.org/wiki/Benutzer_Diskussion:Sk!d#Disabiguation_pages [15:06:10] Sk1d: I think it's ok [15:07:42] good [15:12:20] is a admin on? [15:12:34] * Jeblad_WMDE wants to be in the office this evening... :( [15:12:47] Sk1d: yes, Restu20 ;-) [15:13:08] Restu20 i fixed the problem with my bot see: https://www.wikidata.org/wiki/User_talk:Sk!d#Sk.21dbot_blocked [15:14:43] Sk1d: I'm an admin :-) [15:15:00] Henning_WMDE, and aude, and johl, and Danwe, and DanielK_WMDE, and jeroendedauw_, and Silke_WMDE_, and Lydia_WMDE, and Abraham_WMDE1, and Denny_WMDE1 has done a great job! [15:15:28] Argh, forgot Anja but she has hide somewhere.. [15:16:34] Sk1d: if you fix all the problems I will unblock your bot :-) [15:17:01] i think i should have fixed all problems ^^ [15:17:08] ok :-) [15:17:38] but bevor i start i will do some test edits and check them manually if everything works now [15:18:18] ok perfect [15:19:05] starting by creating the pages where my bot didnt function correct [15:19:46] Sk1d: I unblocked your bot :-) [15:20:26] gah. Wikibase (Version 0.1 alpha) [15:20:32] should be 0.3 now, shouldn't it? [15:21:16] thx [15:21:24] jeroendedauw_: the extension versioning stuff confuses me. but i think we should update the extension credits. what do you think? [15:25:34] by the way, as planned we will probably roll out an update to the software today. http://www.wikidata.org/wiki/Wikidata:Project_chat#Deployment_schedule [15:30:41] hm... oh, Version 0.1 was the live site. test shows 0.3. never mind me, then [15:31:18] Credits for a complex work is everybody involved, authors are for individual pieces where they have contributed [15:31:18] DanielK_WMDE: be patient :) [15:31:59] But, authors is actual authors, not those that copy-paste, and that makes authorship difficult [15:32:07] Denny_WMDE1: we should announce that on the list too, no? [15:32:55] i think aharoni asked about deployment [15:33:08] did anyone reply to him on the list? [15:33:21] Funny thing is, there will be no authorship on items in traditional sense.. [15:35:53] I will answer aharoni [15:35:56] and send an email to the list [15:36:19] ok [15:42:11] Denny_WMDE1: also take a look at the URL/URI question i just replied to [15:42:19] Denny_WMDE1: we should have at least a ticket open for this stuff [15:42:26] is it possible to see all data for a dataset (=article)? [15:43:32] giftpflanze: you always see all data for one item [15:43:48] DanielK_WMDE: yes, i just answered nick in parallel :) [15:43:50] i only see localized descriptions [15:43:51] we are almost consistent [15:43:59] giftpflanze: that is all we have right now :) [15:44:12] giftpflanze: come back in January for more data [15:44:13] so, that's not all, then ;) [15:44:36] it's all we have now [15:44:41] is it possible to see the internal data representation (e.g. json)? [15:45:42] giftpflanze: yes, using special:export [15:45:53] (and soon, Special:EntityData) [15:46:28] thx :) [15:46:37] giftpflanze: but you really shouldn't rely on that for anything. the internal representation may change, and is not the same as the one used by the api [15:46:56] oh yes, api works too. just ask for the revision content, that works [15:47:54] ! [15:48:29] it *is* just page content, after all. it's just not wikitext [16:07:50] New patchset: Aude; "use write connection for recent changes save hook" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36573 [16:10:43] DanielK_WMDE: can you please review ^ and tell me if i'm doing that right or otherwise suggest [16:21:49] aude: review what? i have gerrit muted, too many highlights [16:24:15] https://gerrit.wikimedia.org/r/36573 [16:24:49] i'm slightly concerned about using a read db connection after writing something, so think we should use write in that spot to select the row [16:25:27] aude: yes, that's better, though I would still like to get around loading the RC entry from the DB alltogether [16:25:48] err, the change entry [16:26:11] agree [16:26:28] that would mean knowing it's a bot edit from the revision i think [16:30:30] aude: what i mean is: when the entry is written to the cahnge table in the first place, don't we have accessw to an RC object there? [16:31:08] no, we don't [16:31:15] * aude double checks [16:32:07] i think we were collecting the info from the revision, user, etc. [16:33:19] recent change is created after the hook point, NewRevisionFromEditComplete [16:33:29] * Jeblad_WMDE crosses fingers and toes [16:34:04] and gets $bot from a variable that is not available to the hook, as far as i can tell [16:34:05] we could probably change that, but it's a core change i think [16:34:43] aude: so, how about doing it the other way around? just create and store the change in the RecentChangeSave handler? [16:35:02] hmmm..... maybe [16:35:02] why do we create it before? do we need to? [16:35:19] hm... well, we'd have to load the old revision and create a diff, i guess. [16:35:22] not good. [16:35:28] * aude recalls an issue with that but checks [16:35:56] aude: probably not worth to do it now. [16:36:00] loading and updating the change should be marked as a hack. [16:36:19] $newEntity = $article->getContent()->getEntity(); [16:36:26] and in the place where the change entry is originally created, there should be a note that that entry will later be updated by injkecting the RC info [16:36:33] stuff like that is really hard to find otherwise [16:36:52] it needs the content to create the change object [16:37:13] yea [16:37:25] it's possible to get that from an RC object, but probably rather inefficient [16:37:29] ok, i can put more documentation there [16:37:45] yes, from the rc object but then wonder if it involves loading from the database again? [16:37:52] the reverse issue? [16:38:31] yes, possibly [16:38:39] no use getting into that now [16:38:46] but more documentation for this would be nice. [16:38:48] if the revision can know it's a bot, that's all that we're missing [16:38:53] ok [16:39:06] and using the write connection there for now...... [16:39:15] anyway - your change looks valid, though it's not very elegant. but it's the best we can do without moving a lot of stuff around, i guess [16:39:18] if it's an issue, then we can do it [16:39:32] agree... [16:39:52] ORMTable doesn't support specifying a connection in the select methods, to override (but nice if it did) [16:40:10] * aude can't think of another way [16:40:32] hm, NewRevisionFromEditComplete could provide the edit flags, including the bot flag, i guess [16:41:08] aude: yes, that would have to be added to ORMTable. maybe. [16:48:07] oooh, my ghost is here.... [16:52:51] New review: Daniel Kinzler; "I wish there was a more elegant way to tell ORMTable to use the write connection. And a moe elegant ..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2; - https://gerrit.wikimedia.org/r/36573 [16:52:52] Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36573 [16:53:06] aude: merged [16:53:21] DanielK_WMDE: thanks [16:53:34] we can poke at it later to improve [17:07:37] my bot got Q333333! [17:08:56] New patchset: Henning Snater; "Improving validation logic in JS template function" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36579 [17:17:38] gz [17:17:56] when will the update start? [17:27:44] Sk1d: the scheduled update time is 19:00-21:00 UTC [17:28:05] e.g. in 1 1/2 hourse from now, but i suspect the actual update won't take that long [17:28:13] it will just happen sometime during that time period [17:33:40] mmm [17:35:43] Could do the merge prep into wmf6 now ish [17:35:53] Reedy: ok [17:36:19] wmf6? or wmf5? or am i confused [17:36:26] oh, 5 [17:36:27] hah [17:36:33] if toolserver replication would be ok, my bot would restart itself and go on automatically. but now it will retry import of many already imported pages. [17:36:34] ok :) [17:56:55] jemand von WMDE da? [18:00:44] Steinsplitter: offensichtlich ja [18:03:52] mysql:wikiadmin@db34 [wikidatawiki]> SELECT table_schema "DB Name", SUM( data_length + index_length) / 1024 / 1024 / 1024 "DB Size in GB" FROM information_schema.TABLES WHERE table_schema = 'wikidatawiki'; [18:03:52] +--------------+----------------+ [18:03:53] | DB Name | DB Size in GB | [18:03:53] +--------------+----------------+ [18:03:53] | wikidatawiki | 4.454513549805 | [18:03:55] +--------------+----------------+ [18:03:57] 1 row in set (2.07 sec) [18:07:36] aude: i am here :) [18:07:53] hab schin Silke erreicht ;-) [18:07:55] New patchset: Aude; "intval in sitelinkremotetable" [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36584 [18:08:17] hi Denny_WMDE [18:08:32] ok, one fix https://gerrit.wikimedia.org/r/#/c/36584/ [18:10:11] Jeblad_WMDE: want to approve https://gerrit.wikimedia.org/r/#/c/36584/ [18:10:26] or Reedy or anyone :) [18:10:45] Change merged: Reedy; [mediawiki/extensions/Wikibase] (mw1.21-wmf5) - https://gerrit.wikimedia.org/r/36584 [18:10:51] thanks :) [18:10:56] * aude likes sanity check and not self merge [18:12:23] hm.. [18:13:09] Jeblad_WMDE: nevermind, we got it [18:13:44] why isn't this in master? [18:14:39] Jeblad_WMDE: the sitelinkremote thing is gone from master [18:15:05] it's already fixed in master [18:16:20] ok [18:17:15] could not find the changeset [18:20:16]