[09:17:18] <gerrit-wm>	 New patchset: Anja Jentzsch; "(bug 42545) Label of Special:EntityData is broken" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35935
[09:34:43] <Silke_WMDE>	 our internal dev wants to be rebooted...
[09:43:41] <Silke_WMDE>	 our internal dev doesn't wnat to reboot...
[10:07:35] <gerrit-wm>	 New patchset: Daniel Kinzler; "(no bug) Introducing DebugSettings.php." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36159
[10:07:58] <gerrit-wm>	 New patchset: Daniel Kinzler; "(no bug) create client cache tables only if needed." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36160
[10:19:10] <gerrit-wm>	 New review: Daniel Kinzler; "There's a syntax error: " [mediawiki/extensions/Wikibase] (master); V: -1 C: 0;  - https://gerrit.wikimedia.org/r/35935
[10:27:42] <gerrit-wm>	 Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35934
[10:28:41] <gerrit-wm>	 New patchset: Anja Jentzsch; "(bug 42545) Label of Special:EntityData is broken" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35935
[10:42:13] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Remove assertException defs due to move to core" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/36161
[10:54:20] <aude>	 Denny_WMDE: https://bugzilla.wikimedia.org/42549
[10:58:04] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35909
[10:59:00] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35935
[11:09:32] <JeroenDeDauw>	 DanielK_WMDE__: can you explain to me the difference between DIrectSQLStore and CachingSQLStore?
[11:09:35] <JeroenDeDauw>	 In client
[11:12:27] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35928
[11:14:14] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36159
[11:15:39] <JeroenDeDauw>	 DanielK_WMDE__: why did you remove getEntity from EntityCache?
[11:18:21] <JeroenDeDauw>	 nvm the later question, did not see the new extends
[11:21:19] <JeroenDeDauw>	 DanielK_WMDE__: are you still working on the same stuff as in https://gerrit.wikimedia.org/r/#/c/35420/3 ? I would like to make a follow up
[11:31:13] <Denny_WMDE>	 DanielK_WMDE__: ping
[11:31:19] <Silke_WMDE_>	 the demo server will be updated to the most recent code later today, as we will tag again. It's still on last week's code right now.
[11:34:17] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35875
[11:41:35] * Silke_WMDE_  is about to reboot the demo system

[11:48:42] <gerrit-wm>	 New patchset: Jeroen De Dauw; "fix documentation" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36166
[11:48:52] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36166
[11:55:39] <gerrit-wm>	 New review: John Erling Blad; "Seems functional to me and I can't find that it breaks anywhere" [mediawiki/extensions/Wikibase] (master); V: 1 C: 1;  - https://gerrit.wikimedia.org/r/35888
[11:56:43] <gerrit-wm>	 New review: John Erling Blad; "pong?" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/33558
[12:12:38] <gerrit-wm>	 New patchset: John Erling Blad; "Fix autocomment for special create" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36169
[12:13:31] <gerrit-wm>	 New patchset: Aude; "(bug 42544) wikibase add actions in recent changes, and include entity link for restore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36170
[12:14:37] <gerrit-wm>	 New review: John Erling Blad; "Self-submit before this collides with translatewiki :)" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/36169
[12:14:37] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36169
[12:14:44] <DanielK_WMDE__>	 hi
[12:17:23] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35915
[12:23:37] <JeroenDeDauw>	 DanielK_WMDE__: please read my rage above :)
[12:24:19] <DanielK_WMDE__>	 JeroenDeDauw: i'm fixing the @since tags now
[12:24:23] <DanielK_WMDE__>	 anything else?
[12:24:28] <JeroenDeDauw>	 DanielK_WMDE__: already did this
[12:24:31] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36160
[12:24:32] <JeroenDeDauw>	 and merged
[12:24:48] <DanielK_WMDE__>	 JeroenDeDauw: the difference between CacheinSqlStore and DirectSqlStore is that DirectSqlStore provides direct access to the repo database.
[12:25:08] <DanielK_WMDE__>	 JeroenDeDauw: oh, well, how will i ever learn, then ;)
[12:25:28] <DanielK_WMDE>	 Denny_WMDE: what's up?
[12:25:55] <Denny_WMDE>	 i didnt understand the items you suggested in your daily mail
[12:26:42] <Denny_WMDE>	 or rather, i understood item 3, but not 1, 2, and 4
[12:27:39] <gerrit-wm>	 New patchset: Jeroen De Dauw; "fix doc" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36171
[12:27:48] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36171
[12:29:46] <DanielK_WMDE>	 Denny_WMDE: mompl
[12:40:01] <DanielK_WMDE>	 Denny_WMDE: i'll explain via mail
[12:40:55] <Denny_WMDE>	 ok
[12:42:08] <JeroenDeDauw>	 DanielK_WMDE: nice job with the DBAccessBase btw
[12:43:38] <JeroenDeDauw>	 DanielK_WMDE: think it would be nicer if it took a database connection rather then a wiki id, pull in a lb and get a connection based on that id. Looks like that's not trivial to change though
[12:45:41] <gerrit-wm>	 New patchset: Jeroen De Dauw; "fixed doc and strict check" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36172
[12:48:03] <gerrit-wm>	 New patchset: Jeroen De Dauw; "fixed doc and strict check" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36172
[12:48:23] <JeroenDeDauw>	 DanielK_WMDE: I am looking at SiteLinkRemoteTable
[12:48:33] <JeroenDeDauw>	 DanielK_WMDE: in what way can it not be ditched yet?
[12:48:48] <JeroenDeDauw>	 DanielK_WMDE: looks like SiteLinkTable can do everything it can do
[12:50:06] <gerrit-wm>	 New patchset: Jeroen De Dauw; "fixed doc and strict check" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36172
[12:50:38] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36172
[12:55:02] <DanielK_WMDE>	 JeroenDeDauw: I think SiteLinkTable can replace both SiteLinkRemoteTable and SiteLinkCache. Talk to Katie about SiteLinkRemoteTable. The only thing that needs some attention is enforcing the read-only mode when used from the client.
[12:55:53] <JeroenDeDauw>	 DanielK_WMDE: what's the point of merging the SiteLinkCache interface into SiteLinkLookup?
[12:56:01] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(no bug) adding sleep after delete/undelete in selenium test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36173
[12:56:10] <JeroenDeDauw>	 DanielK_WMDE: right now you cannot access the non-read methods from client without violating the interface
[12:56:12] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36173
[12:56:30] <JeroenDeDauw>	 Perhaps we do need an extra check since some people are violating the interfaces...
[12:56:40] <JeroenDeDauw>	 Those violations are extremely easy to find though
[12:56:50] <JeroenDeDauw>	 PHPStorm clearly indicates them
[12:58:15] <DanielK_WMDE>	 I don't quite follow... conceptually, we need a) something to look up the item ID for a client page, and b) something we can store such mappings in, update them, delete them, etc.
[12:58:25] <DanielK_WMDE>	 Seems to be b) is an extension of a), no?
[12:59:11] <DanielK_WMDE>	 I don't care that much about the relation between the two interfaces, as long as SiteLinkTable implements both
[12:59:36] <DanielK_WMDE>	 AS to violating the interface...
[13:00:05] <DanielK_WMDE>	 I'd really prefer some programmatic barrier to changing the repo database from the client. The respective object should just refuse to do it, never mind any interfaces,.
[13:00:25] <DanielK_WMDE>	 JeroenDeDauw: as to DBAccessBase taking a DB connection: holding on to a DB connection is frowned upon in core, code is being changed the other way around, so DB objects are only allocated when needed.
[13:01:13] <DanielK_WMDE>	 This is especially important for connections to other database servers, because if we release the connection after every use, it can be re-used by othe code for connections to other dbs on the same server (this is implemented by LB_multi)
[13:01:43] <JeroenDeDauw>	 Seems to be b) is an extension of a), no? => yeah exactly
[13:01:57] <JeroenDeDauw>	 as long as SiteLinkTable implements both => this is currently the case?
[13:02:23] <JeroenDeDauw>	 Agree with programmatic barrier in this case
[13:03:38] <JeroenDeDauw>	 DanielK_WMDE: Yeah, I figured as much after looking at it a bit
[13:08:15] <DanielK_WMDE>	 JeroenDeDauw: I started to make SiteLinkTable support everythign we need to use it on the repo, for the client side cache, and the direct access from the client. I had to push this back for other stuff though, so Katie went ahead and implemented the direct access in SiteLinkRemoteTable. 
[13:08:50] <DanielK_WMDE>	 I think all that is needed is for SiteLinkTable to fully support the readonly mode (I think the clear() method doesn't check, and maybe some others - Katie found thouse).
[13:09:14] <DanielK_WMDE>	 other than that, it should be ready to replace both SiteLinkRemoteTable and SiteLinkCache.
[13:10:03] <DanielK_WMDE>	 oh, btw...
[13:10:17] <JeroenDeDauw>	 DanielK_WMDE: ok thanks, then it's rather easy to remove :)
[13:10:36] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Remove SiteLinkRemote table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36174
[13:10:52] <DanielK_WMDE>	 JeroenDeDauw: I disabled creation of the tracking tables on the client for now.
[13:11:02] <JeroenDeDauw>	 DanielK_WMDE: I saw
[13:13:16] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Use readonly mode in SiteLinkTable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36175
[13:14:21] <JeroenDeDauw>	 DanielK_WMDE: ^^
[13:17:18] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(no bug) move client_repo selenium test from repo to client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36176
[13:19:11] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36176
[13:26:19] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(no bug) using random string for entity description in client tests" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36177
[13:34:05] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36177
[13:36:07] <JeroenDeDauw>	 DanielK_WMDE: looks like the re-insert into the entity_per_page table on undelete has not been fixed yet
[13:36:27] <gerrit-wm>	 New patchset: Henning Snater; "JavaScript template engine function returning jQuery object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36178
[13:36:30] <JeroenDeDauw>	 DanielK_WMDE: I can take care of this in a minute - unless you're poking at it or want to do that
[13:36:49] <gerrit-wm>	 New patchset: Daniel Werner; "Some cleanup for new widgets around Claims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36179
[13:40:27] <DanielK_WMDE>	 JeroenDeDauw: uh... it should be fixed, i verified that it worked yesterday...
[13:40:40] <DanielK_WMDE>	 but i'm not working on it
[13:40:49] <DanielK_WMDE>	 in fact, i have to run out now
[13:40:50] <DanielK_WMDE>	 bbl
[13:41:20] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36179
[13:48:34] <gerrit-wm>	 New review: Aude; "see comments" [mediawiki/extensions/Wikibase] (master); V: 0 C: -1;  - https://gerrit.wikimedia.org/r/36174
[13:49:24] <gerrit-wm>	 New review: Aude; "see comment" [mediawiki/extensions/Wikibase] (master); V: 0 C: 0;  - https://gerrit.wikimedia.org/r/36175
[13:54:58] <johl>	 JeroenDeDauw: thanks for the mail!
[13:55:16] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Remove SiteLinkRemote table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36174
[13:55:30] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Use readonly mode in SiteLinkTable" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36175
[14:00:10] <gerrit-wm>	 New patchset: Aude; "(bug 42544) wikibase add actions in recent changes, and include entity link for restore" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36170
[14:02:01] <gerrit-wm>	 New patchset: John Erling Blad; "There are a few failing tests that seems to be triggered by $wgUser" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36180
[14:04:13] <gerrit-wm>	 New patchset: John Erling Blad; "There are a few failing tests that seems to be triggered by $wgUser" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36180
[14:07:31] <Jeblad_WMDE>	 env 'MW_INSTALL_PATH=/var/www/repo' php phpunit.php --verbose --group DataValueExtensions,Wikibase --conf /var/www/repo/LocalSettings.php
[14:19:11] <gerrit-wm>	 Change merged: Anja Jentzsch; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36170
[14:23:36] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Replaced alternate entry points for experimental behaviour with configuration switch" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36183
[14:24:25] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36180
[14:31:07] * Silke_WMDE_  is about to update the demo system with our latest tag

[14:39:38] <gerrit-wm>	 Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36183
[14:48:45] <gerrit-wm>	 New review: Aude; "I don't know what the issue was before, but it works properly for me now and enables the WikiPageEnt..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/35888
[14:48:45] <gerrit-wm>	 Change merged: Aude; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35888
[14:54:01] <gerrit-wm>	 New patchset: Jeroen De Dauw; "improve docs" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36186
[15:02:20] <AnjaJ_WMDE>	 http://192.168.2.251/wikidata-client/index.php/Main_Page to see the error
[15:04:03] <gerrit-wm>	 New patchset: Henning Snater; "JavaScript template engine function returning jQuery object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36178
[15:06:01] <Silke_WMDE_>	 Demo system is up to date now. (tag 2012-11-30)
[15:08:14] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Exit maintenance scripts with desciptive error when required extension is not loaded" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36187
[15:09:13] <Silke_WMDE_>	 internal dev system will now be upgraded
[15:09:27] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36186
[15:12:08] <AnjaJ_WMDE>	 http://192.168.2.251:8080/job/wikibase-phpunit/76/console
[15:12:15] <AnjaJ_WMDE>	 for today's tag
[15:12:22] <AnjaJ_WMDE>	 so many core errors already?!
[15:12:57] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Restored automatic loading of Lib from Client" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36188
[15:15:15] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36188
[15:24:15] <gerrit-wm>	 New patchset: Henning Snater; "JavaScript template engine function returning jQuery object" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36178
[15:35:15] <gerrit-wm>	 Change merged: Daniel Werner; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36178
[15:44:14] <AnjaJ_WMDE>	 http://192.168.2.251:8080/job/wikibase-selenium-win7-local/338/console
[15:48:50] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Added setqualifier API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/35648
[15:59:04] <benestar>	 lukas23 an ip is currently changing all labels!
[15:59:20] <benestar>	 is there a consensus
[16:00:53] <Jeblad_WMDE>	 what is he doing?
[16:01:11] <benestar>	 Jeblad_WMDE: i'll block him
[16:02:23] <Jeblad_WMDE>	 not sure if upper case/lowercase is important..
[16:02:50] <benestar>	 Jeblad_WMDE: with reason of bot edits
[16:02:57] <Jeblad_WMDE>	 But it is probably nice to follow the article on wikipedia unless it is somehow wrong
[16:04:08] <Jeblad_WMDE>	 The label can be reused on top of the infobox in the article page and then it make sense to use the same styling for upper-/lowercase
[16:05:16] <benestar>	 Jeblad_WMDE: http://www.wikidata.org/wiki/User_talk:130.88.141.34
[16:05:49] <Jeblad_WMDE>	 its a communit issue how to handle that.. /me think..
[16:06:10] * Jeblad_WMDE  know nååthing..

[16:09:31] <aharoni>	 I got disconnected. I'll try again:
[16:09:41] <aharoni>	 I am trying to add a link to Galician to http://www.wikidata.org/wiki/Q219944 . The language code is gl and the article name is "DEUS". And Wikidata seems to force me to write "Deus" there, which is a different article.
[16:11:02] <aharoni>	 autocomplete found "Deus" and "DEUS". I selected "DEUS", but when I saved, it changed to "Deus".
[16:11:50] <aharoni>	 Jeblad_WMDE, JeroenDeDauw ^ - any idea?
[16:12:16] <benestar>	 aharoni: use api :p
[16:12:32] <giftpflanze>	 well
[16:12:37] <JeroenDeDauw>	 hehe
[16:12:56] <JeroenDeDauw>	 Danwe_WMDE: Henning_WMDE TobiasG_WMDE ^ sounds like a UI issue
[16:13:10] <JeroenDeDauw>	 If it indeed does work correctly via the API
[16:13:14] <gerrit-wm>	 New patchset: Tobias Gritschacher; "(no bug) re-adding sleep after delete/undelete in selenium test" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36191
[16:13:25] <gerrit-wm>	 Change merged: Tobias Gritschacher; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36191
[16:13:49] <Jeblad_WMDE>	 upper/lowercase issue in UI
[16:14:39] <Jeblad_WMDE>	 Lookup list is lowercase
[16:16:05] <Jeblad_WMDE>	 Could also be the normalization
[16:16:12] <DanielK_WMDE>	 JeroenDeDauw: You could have asked before turning around the WB_EXPERIMENTAL_FEATURES... it was a conscious decision to do it that way around, not the way you did it now. 
[16:16:21] <DanielK_WMDE>	 Jeblad_WMDE: it's not a big deal, I don't have a strong preference either way.
[16:16:27] <Jeblad_WMDE>	 dEUS is forced to DEUS through the normalization step
[16:16:38] <DanielK_WMDE>	 oops, that was for JeroenDeDauw :P
[16:16:40] <DanielK_WMDE>	 anyway
[16:16:50] <aharoni>	 I understand, of course, that items should usually be created by bots using API. But it does loo like a bug in the UI, which is sometimes needed for manual fixes.
[16:17:00] <JeroenDeDauw>	 DanielK_WMDE: there is good reason to not introduce a second entry point
[16:17:24] <aharoni>	 MediaWiki in Wikipedia forces a change from dEUS to DEUS, but that's a different issue.
[16:17:31] <Jeblad_WMDE>	 No problem if you kick me, I can kick JeroenDeDauw  for you..
[16:17:41] <Jeblad_WMDE>	 :-}
[16:17:46] <DanielK_WMDE>	 JeroenDeDauw: I just think that at least a quick talk is useful before reverting design decision. There we could have talked about your good reasons, and mine (not introducing constants into LocalSettings).
[16:17:54] <JeroenDeDauw>	 Jeblad_WMDE: I have artillery! 
[16:18:13] <DanielK_WMDE>	 I don't see a fundamental probelm with additional setup files (which are not entry points in the HTTP sense)
[16:18:30] <DanielK_WMDE>	 anyway. no need for a big discussion now. i don't care much either way
[16:18:50] <DanielK_WMDE>	 i just think that it's good to ask for reasons before turning stuff around.
[16:19:10] <JeroenDeDauw>	 I do care that we do not have extra entry points like this because it confuses people and can hurt us in the long run
[16:19:12] <aharoni>	 lukas - did you do this - http://www.wikidata.org/w/index.php?title=Q219944&diff=713105&oldid=713092 ?
[16:19:18] <JeroenDeDauw>	 idk if it's a constant or a setting
[16:19:19] <DanielK_WMDE>	 (please do remind me in case I don't follow that myself)
[16:19:23] <lukas23>	 aharoni: yes
[16:19:27] <JeroenDeDauw>	 But people might whine if it's a regular var
[16:19:30] <Jeblad_WMDE>	 aharoni: Thinking about this I believe it comes from a normalization step in the API
[16:19:33] <JeroenDeDauw>	 due to register globals crap
[16:20:06] <JeroenDeDauw>	 DanielK_WMDE: yeah sure, that also applies to what you did then
[16:20:41] <Jeblad_WMDE>	 It is a step to make the title into a canonical form used by wikipedia
[16:20:44] <DanielK_WMDE>	 JeroenDeDauw: did i revert anyone's design decision when I introduces this?
[16:21:08] <DanielK_WMDE>	 JeroenDeDauw: i think the new way is more confusing and less consistent. but that's just a feeling. would have been good to get other people's input. 
[16:21:35] <Jeblad_WMDE>	 The canonical title is with an initial uppercase char
[16:21:39] <aharoni>	 lukas23: how exactly? is it a bot? or some web ui tool?
[16:22:22] <lukas23>	 aharoni: it's a gadget
[16:22:31] <Jeblad_WMDE>	 The display title is not necessarily the same, and we can't easily get to the display title
[16:23:41] <gerrit-wm>	 New patchset: Aude; "(bug 42534) make repo link work with protocol relative" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36193
[16:27:25] <aharoni>	 lukas23: thank you!
[16:27:42] <lukas23>	 aharoni: np
[16:46:19] <Denny_WMDE1>	 Nikerabbit: just wanted to ask if you plan to look at https://gerrit.wikimedia.org/r/#/c/33505/ at some point or if it needs discussion?
[16:48:07] <Nikerabbit>	 Denny_WMDE1: interestingly it is next on my list
[16:48:27] <Nikerabbit>	 Denny_WMDE1: the latest comment raises my eyebrows though
[16:48:31] <Denny_WMDE1>	 :) awesome
[16:48:32] <gerrit-wm>	 New patchset: Anja Jentzsch; "(bug 41624) Add labels to user contributions" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36196
[16:48:40] <Sven_Manguard>	 Good morning
[16:49:15] <Denny_WMDE1>	 Nikerabbit: I think we can leave that for later, to give the order of the languages a meaning
[16:49:27] <Nikerabbit>	 Denny_WMDE1: my comment on preg_quote stand
[16:49:34] <Denny_WMDE1>	 ah, good point
[16:49:41] <Denny_WMDE1>	 wonder why Jeblad_WMDE didn't fix that
[16:49:42] <Sven_Manguard>	 Denny_WMDE1: Your email this morning about the licensing situation (the first of the two) was brilliant
[16:49:51] <Denny_WMDE1>	 probably stubborness? :)
[16:49:55] <Nikerabbit>	 Denny_WMDE1: and I would prefer if the lines would be shorter than 100 chars
[16:50:02] <Denny_WMDE1>	 Nikerabbit: agreed
[16:50:12] <Jeblad_WMDE>	 Its an optional argument
[16:50:26] <Jeblad_WMDE>	 And there is no reason to escape any other chars
[16:50:49] <Jeblad_WMDE>	 So it will only be a superflawous empty string
[16:50:52] <Denny_WMDE1>	 I'd say it is easier to change it then to discuss this :P
[16:51:01] <Denny_WMDE1>	 Sven_Manguard: thank you. I hope I didn't do anything evi
[16:51:07] <Denny_WMDE1>	 evil with that, we will see.
[16:51:33] <Nikerabbit>	  » » // Quote eveerything to avoid unexpected matches due to parenthesis form
[16:51:36] <Nikerabbit>	 typo
[16:51:48] <Nikerabbit>	  // It is not necessary to quote any additional chars except the special chars for the regex
[16:52:03] <Nikerabbit>	 it is also necessary tuo quote the separator char, /
[16:52:11] <Jeblad_WMDE>	 the regexp chars _is_ included
[16:52:18] <Jeblad_WMDE>	 Its what the preg_quote do
[16:52:21] <Nikerabbit>	 but / is not regexp char
[16:52:27] <Nikerabbit>	 it has no special meaning
[16:53:07] <Nikerabbit>	 it is just convention, preg_match( '~foo~', ... ) works as well
[16:54:48] <Nikerabbit>	 and for bonus points add @since date/version
[16:55:57] <Nikerabbit>	 Denny_WMDE1: anything else?
[16:56:40] <Denny_WMDE1>	 nope, thanks, that is helpful
[16:56:54] <Denny_WMDE1>	 will ensure to take it into account
[17:01:53] <Denny_WMDE1>	 DanielK_WMDE: you there?
[17:02:07] <DanielK_WMDE>	 Denny_WMDE1: yes.. .trying to get some reviews done
[17:03:35] <Sven_Manguard>	 Merlissimo: so what do you want to do about MerlBot? At the very least, it's (as soon as it'
[17:03:41] <Denny_WMDE1>	 Denny_WMDE1: always appreciated :)
[17:03:42] <Sven_Manguard>	 s closed) a community approved task
[17:04:07] <Denny_WMDE1>	 i wanted to know, for deploying client on test2, what needs to be setuped in the client so it knows it is enwiki?
[17:04:11] <Nikerabbit>	 Denny_WMDE1: perhaps some one of your side will have time to followup https://gerrit.wikimedia.org/r/#/c/31361/ ? ;)
[17:04:47] <Merlissimo>	 Sven_Manguard: keep it running for creating reports?
[17:04:54] <Sven_Manguard>	 Yeah
[17:05:25] <Sven_Manguard>	 I was more asking if you want the bot flagged or not. If you don't want it flagged, we should put a note on it's userpage linking to the approval discussion anyways
[17:05:29] <Denny_WMDE1>	 DanielK_WMDE: that would be you to follow up on this, I guess https://gerrit.wikimedia.org/r/#/c/31361/ (request per Nikerabbit) to answer SPQR
[17:06:57] <DanielK_WMDE>	 Denny_WMDE1: the necessary settings are here: http://pastebin.com/WQup2WLZ
[17:06:58] <Merlissimo>	 Sven_Manguard: i think unflagged
[17:07:13] <Sven_Manguard>	 That works. 
[17:07:23] <DanielK_WMDE>	 Denny_WMDE1: there's an issue with hard coding https here. these should be protocol relative, ask katie about the status. i think we have a ticket for that
[17:08:06] <Sven_Manguard>	 Merlissimo: I'm going to try and find someone uninvolved to close Wikidata:Requests_for_permissions/MerlBot
[17:08:21] * Sven_Manguard  stares at Denny_WMDE1, grinning evilly

[17:08:34] <Merlissimo>	 Sven_Manguard: i could add the number of items contained in lists somewhere
[17:08:45] <Sven_Manguard>	 hm?
[17:09:01] <Sven_Manguard>	 take a look at the top of http://www.wikidata.org/wiki/Wikidata:Labels_and_descriptions_task_force/en
[17:09:04] <Sven_Manguard>	 is that what you mean?
[17:09:10] <DanielK_WMDE>	 Denny_WMDE1: re 31361: i'll try to look into it, but probably not before monday. if it's important to your, remind me if i havn't done it by tuesday
[17:09:11] <Merlissimo>	 you wrote "These lists cap out at 300 items each, so ..."
[17:09:11] <Sven_Manguard>	 or do you mean the total?
[17:09:17] <Sven_Manguard>	 right
[17:09:23] <Sven_Manguard>	 so there's what, 40,000 items?
[17:09:29] <Sven_Manguard>	 140,000 items?
[17:09:57] <Merlissimo>	 is already at http://www.wikidata.org/wiki/Wikidata:Labels_and_descriptions_task_force#language_subpages but without absolute values
[17:10:20] <Denny_WMDE1>	 DanielK_WMDE: no, not important to me, just would be nice to follow up :) you should know how it is to wait on input and have a stale bug flying around.
[17:15:02] <DanielK_WMDE>	 yea, it sucks. it just dropped off my prio list
[17:16:34] <DanielK_WMDE>	 Denny_WMDE1: does my paste answser your question regarding the client setup? you can also ask katie about it.
[17:16:40] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=611485 edit summary: /* Configuration */ update 
[17:17:55] <Denny_WMDE1>	 DanielK_WMDE: yes, and I did. Aude suggested to prepare a changeset for the config, which is even better
[17:18:22] <DanielK_WMDE>	 yes, sounds good
[17:19:31] <gerrit-wm>	 New patchset: Aude; "remove temporary hack settings, make siteGlobalID default to $wgDBname" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36201
[17:21:25] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=611486 edit summary: /* Configuration */ format, update
[17:23:04] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=611488 edit summary: /* Required settings */ format
[17:23:30] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=611489 edit summary: /* Required settings */ format
[17:26:43] <gerrit-wm>	 New review: Daniel Kinzler; "needs I84ce2413 for safety" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/36174
[17:26:44] <gerrit-wm>	 Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36174
[17:26:50] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=611491 edit summary: /* Available settings */ update
[17:27:24] <wm-bot>	 Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Aude link https://www.mediawiki.org/w/index.php?diff=611492 edit summary: /* sort */ update default
[17:32:32] <gerrit-wm>	 Change merged: Daniel Kinzler; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36175
[17:35:10] <gerrit-wm>	 New patchset: Daniel Kinzler; "(no bug) don't use wfGetDB" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36203
[17:47:39] <gerrit-wm>	 New review: Jeroen De Dauw; "Well, it sort of is a bug no? ;p" [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/36203
[17:47:39] <gerrit-wm>	 Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36203
[18:00:58] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Finisged setqualifier API module and added tests [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36210
[18:04:14] <gerrit-wm>	 New patchset: Jeroen De Dauw; "Avoid confusion by not enabling experimental features when the constant is set to false" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36211
[18:05:47] <gerrit-wm>	 Change abandoned: Aude; "it will be easier to submit a fresh patch, rather than attempt rebase" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34099
[18:17:03] <Jeblad_WMDE>	 DanielK_WMDE: I set up memcached, but I'm not experiencing any huge speedup to say it mildly..
[18:17:12] <Jeblad_WMDE>	 Its more like a speed drop..
[18:37:19] <gerrit-wm>	 New review: John Erling Blad; "The script and setup will anyhow produce a ton of error messages, but an additional one shouldn't do..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/36187
[18:37:20] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36187
[18:56:34] <gerrit-wm>	 New patchset: Aude; "remove temporary hack settings, make siteGlobalID default to $wgDBname" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36201
[19:10:03] <gerrit-wm>	 New review: John Erling Blad; "This will probably break some setups that does not redefine the example urls to work with the correc..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/36193
[19:10:04] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36193
[19:12:27] <gerrit-wm>	 New review: John Erling Blad; "Note that $egWBSettings['siteGlobalID'] must be set to the correct one, typically 'enwiki' for exper..." [mediawiki/extensions/Wikibase] (master); V: 1 C: 2;  - https://gerrit.wikimedia.org/r/36201
[19:16:55] <gerrit-wm>	 New patchset: John Erling Blad; "remove temporary hack settings, make siteGlobalID default to $wgDBname" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36201
[19:30:59] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36201
[19:51:10] <gerrit-wm>	 Change merged: John Erling Blad; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36211
[20:14:56] <Jeblad_WMDE>	 Why collisions with elk is dangerous..
[20:15:02] <Jeblad_WMDE>	 http://gfx.nrk.no/yI5gIFPUToAhczLRWU5rWAkA0hJf1yoWlPCTiZZbyPuw
[20:29:48] <DanielK_WMDE>	 Jeblad_WMDE: hm... you wouldn't notice a big speed increase on a test setup, but it definitly shouldn't get slower...
[20:30:44] <Jeblad_WMDE>	 Perhaps we should set up a test to verify that caching works as expected?
[20:30:59] <Jeblad_WMDE>	 Its kind of difficult to verify that it wors now..
[20:35:05] <aude>	 DanielK_WMDE: in the entity lookup, with your patch, it definitely appears to work
[20:35:20] <aude>	 it's getting stuff from the cache
[20:35:47] <aude>	 haven't tested the rest of the code to verify, though
[20:48:16] <thieol>	 help
[20:48:37] * Jeblad_WMDE  trows out a liferaft for 12 persons

[20:49:38] <DanielK_WMDE>	 Jeblad_WMDE: i settped through with the debugger. it does use the cache. but who knows what side effects there may be
[20:50:14] <DanielK_WMDE>	 Jeblad_WMDE: also, this means that *everything* in mediawiki is using memcached. which shouldn't make things slower, but who knows, edge cases and stuff
[20:50:15] <Jeblad_WMDE>	 Oh, I wasn't thinking about your code
[20:50:45] <Jeblad_WMDE>	 I was thinking about verifying that my setup (or anyones) was properly using the memcache
[20:50:57] <DanielK_WMDE>	 aude: well, the rest seems to work with memcached enabled, too. havn't benchmarked performance, though
[20:51:26] <DanielK_WMDE>	 Jeblad_WMDE: you can see whether the parser cache is used at least by looking at the httpo comments in the output, i think
[20:51:32] * DanielK_WMDE  hasn't looked there in a long time

[20:53:08] <Jeblad_WMDE>	 source code is now extremly messy.. :(
[20:54:17] <thieol2>	 bye
[20:55:29] <Jeblad_WMDE>	 There is memcached-messages in the debug log, so it obviously work
[20:59:34] <DanielK_WMDE>	 getting the caching right in the presence of revision ids isn't entirely streight forward. that's what makes the code a bit baroque.
[20:59:48] <DanielK_WMDE>	 we are not using that yet, though. needs testing soon.
[21:00:11] <DanielK_WMDE>	 thieol: what do you need help with?
[21:05:30] <thieol>	 sorry daniel, just tried to type an irc command but forgot /
[21:12:46] <thieol>	 bye
[21:15:00] <gerrit-wm>	 New patchset: Aude; "kill repo table" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36276
[22:15:06] <gerrit-wm>	 New patchset: Amire80; "English message spelling" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/36305
[22:18:20] <Sven_Manguard>	 gerrit-wm: help
[22:49:05] <Sk1d>	 hey
[23:48:38] <Sven_Manguard>	 Sk1d you around?