[01:42:36] good night [01:45:45] bye [10:16:02] Change merged: Jens Ohlig; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34533 [10:18:18] New patchset: Jeroen De Dauw; "updated todos" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34865 [10:19:09] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34865 [10:26:38] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34582 [10:29:45] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34608 [10:36:04] zzz... [10:38:43] JeroenDeDauw: if you are around, Umherirrender submitted a patch fix to TestORMRowTest https://gerrit.wikimedia.org/r/33859 [10:39:18] JeroenDeDauw: a timestamp is expected to be an integer but that overflow on 32 bits machines. The result ends up not being what is expected :/ [10:39:20] his around [10:39:26] nice [10:39:39] JeroenDeDauw: I have added you as reviewer, probably not urgent :) [10:41:14] hashar: done [10:44:16] DanielK, using your experimental setup fails fir client and when running update it ends in .. [10:44:23] A database query syntax error has occurred. [10:44:25] The last attempted database query was: [10:44:27] "SHOW INDEX FROM `wikidatarepo`.`clientuser`" [10:44:28] from within function "UserDupes::hasUniqueIndex". [10:44:30] Database returned error "1146: Table 'wikidatarepo.clientuser' doesn't exist (127.0.0.1:3306)" [10:44:39] Probably something with my setup [10:44:41] JeroenDeDauw: thanks :-] [10:45:36] Jeblad_WMDE: will look into it. the database error seems very odd, though [10:46:35] New patchset: Tobias Gritschacher; "(bug 42262) tracking revision ids per widget (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34723 [10:46:39] New patchset: Jeroen De Dauw; "rename key to claim" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34867 [10:48:01] New patchset: Tobias Gritschacher; "(bug 42262) tracking revision ids per widget (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34723 [10:48:31] DanielK_WMDE: I don't think this is related to your changeset [10:48:50] It just popped up its ugly head there [10:50:27] :P [10:52:18] Scripts gets confused, tries to find the user table for client database in database for repo [10:52:41] New patchset: Tobias Gritschacher; "(bug 42262) tracking revision ids per widget (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34723 [11:04:55] Jeblad_WMDE: that must be cause by the way you have set up your repo and client... are they sharing configuration? or did you symlink the extension? [11:05:12] they symlink [11:05:34] It seems like its the shared database that creates problems [11:05:51] Jeblad_WMDE: no shared db [11:06:12] there should be no shared db setting... just the LBFactory stuff [11:06:24] Ok, commenting out [11:06:28] Jeblad_WMDE: maintenance scripts use __FILE__ and __DIR__ to find the right LocalSettings file. __FILE__ and __DIR__ resolve redirects, so you'd be going to the same config file. [11:06:46] Jeblad_WMDE: use --conf path/to/LocalSettings.php [11:06:53] (but this is unrelated to my change) [11:06:54] I give the config file with --conf to the scripts [11:07:09] ah - then it's probably what aude suggests [11:07:26] Jeblad_WMDE: does the behavior change with and without my change? [11:08:06] I've thrown out your changes [11:08:26] Makes no sense to test changesets when the setup is failing [11:20:10] New patchset: Tobias Gritschacher; "(bug 42262) tracking revision ids per widget (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34723 [11:34:24] New patchset: Jeroen De Dauw; "Initial poke at setference API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34868 [11:41:04] Seems like there is some assumptions about the setup of the wikis that fails [11:41:07] ;/ [11:43:55] Jeblad_WMDE: so, without my changes, your setup works, but with my changes, it doesn't? [11:44:16] strange - the only thing it assumes is that the lib directory is in the same place as the repo resp clinet directories... [11:45:06] No its the overall setup [11:45:45] Assumption about two different databases, not prefixed tables in a single database [11:46:57] Prefixed tables are common on webhotels, but site ids comes from databases, and its necessary with two site ids for the setup to work when using the poll-stuff [11:47:36] So, I guess I must set up my test servers again [11:48:02] * Jeblad_WMDE steals chockolate and doessomething else [11:49:36] Jeblad_WMDE: you don't need extra servers, just two separate databases [11:51:25] Shure, buy them [11:52:00] Jeblad_WMDE: hm? mysql -e "create database foo" [13:10:09] * Jeblad_WMDE want to sleep after the huge lunch/dinner [13:20:39] DanielK_WMDE: got my email reagarding revisions & editconflicts? [13:33:06] TobiasG_WMDE: yes, already digging in [13:33:19] there's definitely something wrong [13:37:14] DanielK_WMDE: yes, but I don't know if its the JS stuff or the backend. it seems the baserevisions sent/recieved are correct. [13:37:39] actually, i'm not sure that they are correct [13:38:21] checking again... [13:39:33] hmpf [13:39:39] the javascript is getting slower and slower [13:39:53] do you guys have an eye on that? [13:40:09] what do you mean with slower? [13:43:34] it takes longer for the page to load and to become editable. and my fan starts screaming. [13:43:37] anyway. [13:43:53] TobiasG_WMDE: adding de: sent rev 1138, got back rev 1139. fine. [13:44:14] now adding en: sent rev 1138, got back rev 1139. Whut?! [13:44:22] look at the item in another tab: no en link. [13:44:41] checking out the "why" now [13:45:13] hm.. is there probably something wrong in the api, reporting back the wrong rev ids? [13:46:12] apparently - but there's actually no new revision created [13:46:59] I really need coffein pills.. [13:47:16] ..or perhaps I should go for amfetamine.. [13:47:56] TobiasG_WMDE: oh, it was created. but the revision IDs returned do seem to be off. [13:48:00] strange [13:49:59] DanielK_WMDE: this behaviour is only true for the first two sitelinks [13:50:14] for any further sitelink the revids are correct, right? [13:50:21] no. [13:50:30] oh, they're off by one [13:50:39] i consistenly got revision ids that were off by one after that [13:50:41] yes. [13:50:42] cause of the "lost" one from the second sitelink [13:50:44] i think i know why [13:51:02] but it does not loose more [13:51:21] the revision comes from WikiPage::getRevision. there is absolutely no guarantee that that will be the revision we just created [13:51:28] it could be a revision object previously cached. [13:51:41] or, if we reset that case, someone else could have created a revision in the mean time [13:52:03] we really need a secure way to get the ID of the revision that got created by a save operation. [13:52:17] hm... could be that this even needs a core change... [13:52:26] argl [13:52:44] thats bad [13:54:30] is there no way to get the revision I just created? [13:59:21] Check which user is owning the revision [13:59:44] Most of the time the owner is yourself and then the last one will be yours [14:00:09] But you also should check a few to see which one is the last [14:00:37] that is if you don't find that you own the current one [14:01:39] You could also make an offer gift to th God of Code and hope she will fix your code so it work [14:04:57] New patchset: Daniel Werner; "mw.Api's getEntities now uses get request" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34872 [14:05:05] New patchset: Jeroen De Dauw; "Implemented unserialization for snaks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34873 [14:05:24] TobiasG_WMDE: i found a way, will test that now [14:06:01] Jeblad_WMDE: WikiPage::doEditContent actually returns the revision object as part of the status [14:06:49] darn, one of the tests for AbuseFilter keep on cracking [14:13:20] New patchset: Jens Ohlig; "Typo." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34874 [14:14:49] Change abandoned: Jens Ohlig; "(no reason)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/33709 [14:20:51] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34874 [14:24:19] TobiasG_WMDE: ok, my fix works. I'll submit it idependently of your change, so you'll have to rebase to see the effect [14:24:40] i still need to fix some more api modules, though, will take a few minutes [14:29:46] DanielK_WMDE: ok. cool, thx [14:29:58] i'll have a look at it then [14:30:18] DanielK_WMDE: I read through some of the changesets for AbuseFilter, who do I poke to get things done?Any toes I shall/shall not step on? [14:40:00] JeroenDeDauw: we don't have a test case for ApiCreateClaim? [14:40:17] DanielK_WMDE: we do [14:40:25] and for all the components it uses as well :) [14:40:48] hm... why doesn't phpstorm find it? [14:41:30] pull all of the codes! [14:41:32] JeroenDeDauw: i don't see it... or is it very new? [14:41:37] Yesterday [14:41:40] (or maybe tobis patch is very old) [14:42:07] JeroenDeDauw: ah, probably not in this version, then. hm. needs rebase [14:42:58] ok, got it [14:44:31] New patchset: Henning Snater; "No-JS view for entity claims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34879 [14:45:14] DanielK_WMDE: tobi made a patch for which those tests are relevant? [14:46:18] JeroenDeDauw: tobi made a patch which exposed a bug i'm now fixing. to make things consistent, i want to add something to ApiCreateClaim (namely: returning the new revision id). [14:46:31] these changes I want to test [14:54:35] ok. I#m doing a rebase on my patchset, ok? [14:55:19] New patchset: Henning Snater; "No-JS view for entity claims" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34879 [14:56:17] New patchset: Tobias Gritschacher; "(bug 42262) tracking revision ids per widget (DO NOT MERGE)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34723 [14:59:25] New patchset: Daniel Kinzler; "(no bug) Return correct rev ID from API edits." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34880 [15:01:43] Change abandoned: Daniel Kinzler; "no longer needed" [mediawiki/extensions/Wikibase] (wikidata-wmfphase1beta) - https://gerrit.wikimedia.org/r/31849 [15:02:33] New review: Jeroen De Dauw; "Also needed for ApiSetClaimValue" [mediawiki/extensions/Wikibase] (master); V: 0 C: 2; - https://gerrit.wikimedia.org/r/34880 [15:09:51] New patchset: Jens Ohlig; "(Bug 42150) Write script that queries the database for entity artifacts" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34881 [15:11:48] New patchset: Daniel Werner; "wbgetentities API module now takes 'datatype' in 'props' parameter" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34882 [15:23:23] DanielK_WMDE: i'm getting 2 failures on your changeset [15:23:29] 1) Wikibase\Test\ApiEditEntityTest::testEditEntityWithId [15:23:30] Expected key lastrevid under path //entity in the respons [15:23:32] Failed asserting that an array has the key 'lastrevid'. [15:29:47] New patchset: Jeroen De Dauw; "Added methods to interact with References beased on reference hash" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34885 [15:34:52] New patchset: Tobias Gritschacher; "(bug 42262) tracking revision ids per widget" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34723 [15:35:05] Henning_WMDE: https://gerrit.wikimedia.org/r/#/c/34723/ [15:35:52] Change merged: Jeroen De Dauw; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34882 [15:35:52] Change merged: Henning Snater; [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34872 [15:40:26] New patchset: Daniel Werner; "mw.Api's getEntities parameters work with arrays now (broken before)" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34886 [15:46:33] New review: Tobias Gritschacher; "two failures in phpunit tests:" [mediawiki/extensions/Wikibase] (master); V: -1 C: 0; - https://gerrit.wikimedia.org/r/34880 [15:47:23] Forgive my ignorance; does one need +autopatrol if they have +sysop? [15:55:15] New patchset: Jeroen De Dauw; "Updated release notes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34887 [15:55:15] New patchset: Jeroen De Dauw; "Make use of new reference functions in setreference API and fixed removeReference and hasReference" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34888 [15:58:29] New patchset: Jeroen De Dauw; "Implemented unserialization for snaks" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34873 [15:58:29] New patchset: Jeroen De Dauw; "Make use of new reference functions in setreference API and fixed removeReference and hasReference" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34888 [15:58:30] New patchset: Jeroen De Dauw; "rename key to claim" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34867 [15:58:30] New patchset: Jeroen De Dauw; "Added methods to interact with References beased on reference hash" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34885 [15:58:30] New patchset: Jeroen De Dauw; "Updated release notes" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34887 [15:58:30] New patchset: Jeroen De Dauw; "Initial poke at setference API module" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34868 [16:00:08] Danwe_WMDE: https://gerrit.wikimedia.org/r/#/c/34723/ [16:14:15] New patchset: Jens Ohlig; "(Bug 42150) Write script that queries the database for entity artifacts [DO NOT MERGE]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34881 [16:15:35] New patchset: Jeroen De Dauw; "Return correct rev ID from setclaimvalue" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34891 [16:16:00] New review: Jeroen De Dauw; "Done for the module I pointed to in https://gerrit.wikimedia.org/r/#/c/34891/" [mediawiki/extensions/Wikibase] (master); V: 0 C: 1; - https://gerrit.wikimedia.org/r/34880 [16:16:16] Danwe_WMDE: https://gerrit.wikimedia.org/r/#/c/34723/ [16:30:08] New patchset: Daniel Werner; "Added a jQuerz.valueview.hasViewFor() function" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34893 [16:34:01] New patchset: Daniel Werner; "Added a jQuery.valueview.hasViewFor() function" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34893 [16:54:30] TobiasG_WMDE: damn, will amend. not sure i can make it today, got visitors [16:55:29] DanielK_WMDE: no problem. I tried out the functionality and it works. so fixing the test would be the only issue. [16:55:39] \o/ [16:57:19] New patchset: Daniel Werner; "Added a jQuery.valueview.canChooseView() function" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34893 [17:17:20] New patchset: Daniel Kinzler; "(no bug) Return correct rev ID from API edits." [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34880 [17:27:35] alright [17:27:51] Yes? [17:28:07] my idea is to port date data such as dates of flag changes for countries as well as international memberships to organizations such as UN, NATO, EU etc [17:28:20] relationships for international organizations can be quite complex [17:28:52] I have been trying this with templates but it had proven to be a bit too complex [17:32:59] ToAruShiroiNeko: is phase II enabled yet? [17:33:10] I dont understand [17:33:35] I have a good chunk of the work on en.wikipedia in the form of templates [17:33:56] for starters that can be ported in [17:38:39] PiRQuadratus what do you mean by phase II? [17:40:34] Phase I = you can only add interwiki links to wikidata [17:40:47] Phase II = you can add more things, like birth dates [17:41:12] Phase III = Lydia gets a pony [17:41:47] New patchset: Daniel Werner; "(Cleanup) removed some empty constructors in tests when using inherit function" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34901 [17:41:47] New patchset: Daniel Werner; "Implemented number data value in JS" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34902 [17:41:47] New patchset: Daniel Werner; "Added base for number parser in JS, not enabled yet." [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34903 [17:41:56] Phase IV — we get to use V's! [17:42:58] * Jeblad_WMDE is tired and tries to get distracted [17:44:35] PiRQuadratus I am badly distracted by real life (TM)(R)(OMFG) [17:45:07] ToAruShiroiNeko: you forgot (C) [17:45:09] All I wish that my idea gets the needed consideration [17:45:14] Sannita its not copyrighted :p [17:45:18] LOL [17:47:06] Sannita MPAA would be suing us for existing if that were the case :/ [17:59:35] Jasper_Deng/someone — do you know where the interface file (if there even is one) is for the header of http://www.wikidata.org/wiki/Special:Preferences#mw-prefsection-gadgets ? [18:00:00] MediaWiki:prefsection-gadgets? [18:00:28] No.. [18:02:36] Jeblad_WMDE: if i create an item using wbsetitem the number id=123 is returned in result. on wbeditentity a prefixed id=q123 is returned. will this also change in the database tables after update? [18:08:09] We will start using the prefixed version [18:12:20] we will use the prefixed ids on the outside, but not in the database tables [18:16:35] New patchset: Daniel Werner; "StringParserTest does no longer overwrite NullParserTest" [mediawiki/extensions/DataValues] (master) - https://gerrit.wikimedia.org/r/34904 [18:18:14] New patchset: Aude; "More specific comments in recent changes and watchlist" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34692 [18:22:19] New patchset: Daniel Werner; "snakview will now display a message if a property with unsupported type chosen" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34906 [19:44:58] Theopolisme: do you still need help on it or did you figure it already out? [20:39:00] * Jasper_Deng ponders running for bureaucrat [20:39:03] (not immediately) [21:38:13] New patchset: Jeroen De Dauw; "Initial poke at setreference API [DO NOT SUBMIT]" [mediawiki/extensions/Wikibase] (master) - https://gerrit.wikimedia.org/r/34912 [22:07:39] my import bot stopped because many parts of the toolserver are broken since about 1h30m (sge scheduler process, most databases, ...).