[11:34:18] jbond42 moritzm when you get a chance, what do you think of https://gerrit.wikimedia.org/r/c/operations/puppet/+/569570 ? [11:35:03] I'll have a look in a bit [11:35:37] thanks! [11:42:16] volans, chaomodus: I keep getting "Firefox can’t establish a connection to the server at netbox.wikimedia.org." every so often [11:48:31] godog: that is exactly what that function is for and it prevents the error recived in the PCC, but unfortunatly it needs us to enable `rich_data` on the agents https://puppet.com/docs/puppet/5.5/configuration.html#richdata [11:49:34] I have a ticket here https://phabricator.wikimedia.org/T236481 but its not high on my list of priorities at the moment [12:59:45] jbond42: ack, yeah that task is how I found out about the function, although I thought it'd work out of the box since we're using it in apereo_cas (?) [13:00:50] godog: i reverted the change to apereo_cas as it didn't work [13:02:07] ah my bad, I didn't see the revert [13:02:21] mhh ok doesn't looks like we have an option ATM [13:03:07] no unfortunatly not and im pretty sure its not even an option untill cloud upgrade to 5.5 which is why it stalled on my end [13:04:01] ack, thank you! I'll go ahead without pcc for restbase/cassandra for now [13:04:51] well thats not exaclt true we could put in some if statments, migrate the production services and make sure we only ever use wmflib::secret on services exclusivly used by production ... etc [13:05:38] anyway to get it moving a bit further along i could use some review on https://gerrit.wikimedia.org/r/c/operations/software/puppet-compiler/+/557050. its the puppet-compiler code so not sure how (if anyone) is best to review [13:05:51] s/how/who/ [13:07:52] ack, yeah I'm not really familiar with that code [13:08:49] jbond42: although with wmflib::secret even the current version of pcc did compile the catalog for me, expected ? [13:09:45] https://puppet-compiler.wmflabs.org/compiler1002/20585/ that is [13:11:09] godog: it compiles but under the hood it converts the new binary type back to a string [13:11:12] Puppet::Pops::Types::PBinaryType::Binary value. It will be converted to the String [13:11:22] however that may be good enough to get PCC working [13:11:45] ah I see, yeah it looks good enough [13:11:50] from a puppet point of view its sort of a no-op. the catalouge that gets sent to the agent will be the same [13:12:37] happy to +1 it however we should puty a comment refrencing the ticket and add a not to the ticket to say that it sodn;t really work but it fixes pcc [13:15:42] mhhh ok thanks jbond42, I wonder if there is any real downside to using the function now then ? [13:17:02] I think the only real down side is that it doesn't really do what it claims to do. although you code argue the function is working correctly as its honouring the agent config [13:18:30] mmhh ok that's Good Enough™ ! Will followup in a patch [13:20:14] ack [14:32:19] jbond42: revived https://gerrit.wikimedia.org/r/c/operations/puppet/+/569570 [14:39:04] looking [14:39:47] godog: +1 thx [14:40:46] sweet, thanks jbond42 [14:41:01] I'll try that right away [14:41:23] cool and let me know if it goes ok [14:59:00] jbond42: nope :( the file ends up being ascii on the filesystem and not encoded back [14:59:45] ahhh is it the base64 payload?[3~ [14:59:54] yeah [15:00:10] yes that rings a bell ill add a not to the ticket sorry about that [15:01:33] ack! reverting [17:06:37] paravoid: ack, will look at it