[03:15:50] https://tools.wmflabs.org/glam2commons/ is live now [03:16:12] though I am making some minor UI changes [03:16:19] uh, you still haven't fixed my too-many-colors issue [03:16:52] Please tell me which colors you hate [03:16:56] I will remove them [03:17:01] and stick to one color [03:17:13] 4 shades of blue [03:17:18] I mean which blue would you prefer [03:17:24] any [03:17:39] ok I will do it [03:29:58] infobliss: I think I've linked to https://phabricator.wikimedia.org/M82 before, btw [03:30:59] ok thanks for sharing again [03:31:18] ACTION going for breakfast [07:18:02] zhuyifei1999_ https://tools.wmflabs.org/glam2commons/ has one blue throughout [07:18:29] except the logo, buttons [07:19:12] the line below the menu [07:19:36] that one yeah ok [07:19:50] just a min [07:19:51] and /me don't like the logo having distinct colour [07:20:10] we will use a different logo [07:20:25] k [07:20:41] then please finish the logo before gsoc ends [07:21:59] We will discuss with basvb about what kind of logo he wants [07:22:06] k [07:22:07] and finish it [07:29:34] changed the horizontal line too [07:51:23] yeah, looks better [07:51:30] (imo) [07:51:53] the font sizes could have some adjustments [07:52:06] the logout is gigantic [07:52:59] https://tools.wmflabs.org/glam2commons/help_page that's NA-only [07:53:19] and UID almost always means user id. for NA use 'UUID' [07:57:17] I also feel like there should be more spacing vertically between "Hello Zhuyifei1999!" box and the form below [09:23:41] ok [09:23:50] I will modify those [09:26:23] would you specifically mention about the font size changes desired? [09:26:42] 15:52 the logout is gigantic [09:26:57] just make fonts sizes 'make sense' [09:27:32] ok [17:32:37] hi [17:33:31] " and you will be displayed their location in Wikimedia Commons" [17:33:35] displayed -> shown [17:33:50] "Note: Some images may be copyright protected hence the tool will not allow those images to upload to Commons." [17:34:39] if you make that note please note as well that we can not guarantee that all images uploaded are not copyright protected and that users also should be watching that [17:34:57] "rich repositories of famous GLAMs" [17:35:08] rich and famous are not factual and add nothing of value [17:35:19] superlatives like that are better avoided [17:35:58] For the rest some nice improvements [17:36:08] as for the logo, I don't really have that strong of a preference [17:36:58] maybe combine https://commons.wikimedia.org/wiki/File:Museum_black_icon.svg then and arrow and then commons logo [17:37:04] and maybe put some images in that [17:37:41] the about page does not add a lot, you can just remove it and add that info to either front page or help page if it is really needed [17:38:32] sometimes less is more [17:59:07] hello [18:00:46] hi, I'm getting internal server errors [18:01:25] at which step? [18:03:02] clicking upload after entering a serach term [18:04:37] there are too many search results [18:06:40] they are maxed out at 100, why would it matter? [18:06:53] I see with less it does, [18:06:58] well that's something that needs fixing [18:07:05] ValueError: too many values to unpack (expected 1) [18:07:20] yeah I am reading to fix [18:07:51] do you get the logs of errors which are caused by users (me) ? [18:09:19] yes [18:09:20] for amsterdam museum it seems to work [18:09:47] ok [18:10:06] I think I see the issue [18:10:16] at get thumbnail you are fetching the largest image size [18:10:29] https://github.com/infobliss/sibutest2/blob/master/glams/NationaalArchiefGLAM.py#L79 [18:10:32] correct? [18:10:50] or are you fetching the smalles [18:10:52] smallest [18:11:03] aah I see, smallest, sorry [18:12:51] https://github.com/infobliss/sibutest2/blob/master/glams/NationaalArchiefGLAM.py#L181 almost same code, you could reuse that code using a function [18:15:19] basvb can you please tellme the search string that gave the error [18:15:56] ? [18:16:44] amsterdam [18:16:54] ok let me try [18:17:19] sijbrands and tornado do as well I think [18:21:46] gives internal server error? [18:27:39] I need to restart the server [18:46:57] very strange thing [18:47:12] working fine in my local machine but not in toollabs [19:03:19] server issue likely [19:06:39] I am looking into it [19:12:52] Indeed, "amsterdam" works now [19:30:16] what was the issue? [19:30:46] I still get the internal server error [19:30:50] amsterdam for nationaal archief [19:30:56] for amsterdam museum everything works fine [19:31:37] I did not change anything [19:31:55] It seems to be working or not working randomly [19:32:08] but in local it works fine [19:32:56] It likely has to do with server load [19:33:16] we need to do something about it [19:33:22] yep [19:33:40] if possible make a less cost intensive thumbnail loading function [19:33:48] (load smaller thumbnails [19:33:57] or down the max-images a bit [19:34:07] but that is quite the ugly fix [19:34:12] I was hoping for pagination [19:34:43] but there's only 5 days left in the project [19:35:38] I may be able to work after the end of the project and do some more feature additions [19:35:55] but not like working full time [19:39:39] and anyways one has to maintain the tool in the future [19:40:11] I'll do it [19:41:28] hi I disconnected [19:41:51] np [19:42:23] so the pagination feature was a nice to have [19:42:37] but we had it as a low priority task [19:42:39] well I will be evaluating on the things we achieved [19:42:42] true [19:42:50] but the server loading issue is one to fix [19:42:56] but we will need it for performance [19:42:59] yeah [19:43:07] multi-image was planned for quite some weeks ago I believe [19:46:18] we changed the plan quite a bit and made it easier because the progress was a bit slow [19:46:41] https://phabricator.wikimedia.org/T161670 [19:46:59] we had a good bit of time spent to ensure scalability [19:47:12] well that was part of the plan all along [19:47:37] sure I am saying that it took time [19:47:47] true [19:51:48] so do you see anything other than pagination that we are yet to achieve? [19:52:00] there are endless possibilities [19:52:34] I believe the logo was an issue [19:52:40] I like the users to test and provide feedback [19:52:54] I realized that category after multi-image upload has a better user story [19:53:19] that is doable even now [19:53:50] but first this internal server error has to be fixed [19:53:59] and I remember we discussed documentation [19:54:18] of course [19:54:38] well you made it sound like things were almost done [19:54:55] we've provided loads of improvement points but you seem to not remember them [19:55:06] thus we have to repeat them all the time [19:55:20] that's not good [19:55:25] sorry to be a bit harsh there [19:55:37] but keeping track of the work is really important (phabricator was meant for that) [19:56:00] I apologise that I did missed points some times and you had to repeat [19:56:18] just write the to-dos down somewhere [19:56:25] preferably somewhere we can read as well [19:56:31] and mark them as done when finished [19:57:00] we should have been a bit more stern on that, but it's also a learning path for us [19:57:15] from last week I am doing that [19:57:28] where is it? [19:57:29] I had shared a todo list after you both gave comments [19:58:02] please wait let me find it [19:59:21] https://codeshare.io/GqN1yR [19:59:47] I am yet to mark status on them [19:59:50] btw codeshare is not a good place to keep these, phabricator is better [20:00:09] and more in bullet points so you have a better overview [20:01:15] ok [20:01:46] this was more for my quick reference but you are right [20:02:11] well it's why we showed and focussed on phabricator at the start [20:02:11] but it fell behind a bit [20:03:44] "[01:05] I may be able to work after the end of the project and do some more feature additions" [20:04:57] yep that is nice [20:05:08] what comment is that related to? [20:05:10] pagination can be one of them [20:05:43] that was regarding pagination [20:07:12] ok, but you'd have to be a bit more self-sufficient in the working [20:07:21] I will decrease the time I spend on the project by alot [20:07:29] it's taking me around 10-15 hours a week now [20:08:05] true [20:08:20] we may limit our meeting to at most one hour a day [20:08:34] that saves time for work too [20:09:08] one time a week [20:09:23] ? [20:09:36] no daily [20:09:41] or 5 days a week [20:09:47] disconnect again [20:09:52] np [20:09:53] one hour a day is far too much [20:09:57] after the project [20:10:12] oh yeah after the project [20:10:30] After the project it can be much less frequent [20:10:41] once a week will be enough [20:11:00] yes [20:11:02] I was saying for the current days [20:11:12] that's only 4 days [20:11:44] yes [20:11:49] If the meeting stretches too long then it means sleeping late and getting plate [20:11:55] so we just keep the current scedule [20:11:57] *up late [20:12:03] but we don't have to talk that much [20:12:09] you can go and start working now [20:12:16] no need to drag the meeting on [20:12:34] ok [20:13:13] I think I'll go now anyway, it's almost bed time ;) [20:13:27] one min please [20:13:28] success with the work, and be sure to talk with zhuyifei about the project finishing [20:13:49] tomorrow I will discuss with zhuyifei1999_ about the possible solution to the server error [20:14:13] oops you disconnected [20:14:20] that's the other one [20:14:32] o [20:14:52] and do the documentation [20:15:29] By 21 August I will strive to have a submittable code and docs [20:16:06] because after that my semester classes will be started [20:16:15] and I will be time-constrained [20:16:50] that's it from my side today [20:17:53] good night