[02:24:01] infobliss: I think you missed my messages yesterday in https://wm-bot.wmflabs.org/logs/%23wikimedia-sibu/20170811.txt [02:24:45] actually, nevermind [02:25:10] https://github.com/infobliss/sibutest2/blob/master/app.py#L56 <= pointless? [02:26:00] https://github.com/infobliss/sibutest2/blob/master/glamFullList.py#L4 can we just load this dynamically? [02:26:19] urlPrefix and name shaould be a property of the class [02:26:22] *should [02:26:49] and please don't use camelCase except for classes [02:27:09] https://github.com/infobliss/sibutest2/blob/master/app.py#L57 idk what the suffix 1 is for [02:27:23] https://github.com/infobliss/sibutest2/blob/master/app.py#L59 uuid is NA-specific [02:27:31] id is python builtin [02:27:40] pylint would complain [02:28:24] https://github.com/infobliss/sibutest2/blob/master/app.py#L62 if id: elif searchstring: else: [02:28:38] also check of both are provided [02:29:08] https://github.com/infobliss/sibutest2/blob/master/app.py#L72 if not found? [02:29:25] https://github.com/infobliss/sibutest2/blob/master/app.py#L80 what error? explain it [02:29:41] error.html does not help debugging if the error is unknown [02:30:27] https://github.com/infobliss/sibutest2/blob/master/app.py#L73 https://github.com/infobliss/sibutest2/blob/master/app.py#L89 https://github.com/infobliss/sibutest2/blob/master/app.py#L110 repearying code [02:30:32] *repeating [02:30:57] make a util function and throw errors from it [02:32:05] https://en.wikipedia.org/wiki/Don%27t_repeat_yourself [02:33:07] https://github.com/infobliss/sibutest2/blob/master/app.py#L105 what if username /is/ none? [02:33:23] you aren't supposed to upload in that case [02:34:01] make a function decorator that require login, or throw 401 and make a 401 error handler [02:36:22] https://github.com/infobliss/sibutest2/blob/master/app.py#L49 make a generic function for this [02:36:37] and where is the cleanup code? [02:37:07] always cleanup pywikibot login in finally: [10:32:25] hi [10:32:49] he's still not here yet [10:34:13] yep seems to have taken on quite the night rithm [10:34:18] btw, some goat jokes are going on and somehow wm-bot was renamed to goat-bot [10:34:38] https://phabricator.wikimedia.org/project/profile/2926/ [10:35:08] :) isn't everybody busy with wikimania [10:35:17] yeah [10:35:36] idk what's going on there [10:35:56] I think they have taken up on the streaming point a bit [10:40:48] oh, and lots of drama at commons the day before yesterday [10:41:33] yep I've seen it [10:42:00] * zhuyifei1999_ thought you never see drama :P [10:42:05] long term sockpuppets always a tough call [10:42:38] ow I do see it, but I chose not to involve myself (although this time there was no reason to so wasn't that hard) [10:42:49] k [10:43:03] still remember all the sock cases on nlwiki I got involved in with investigating edits and stuff [10:43:26] which has resulted in some long term stalkers over the years [10:43:41] I honestly don't care if one is a sock or not if they are doing dirty work for us [10:43:48] (russavia case) [10:44:51] I'm not so sure if I'd agree with that. The deception of it just makes it problematic, but I won't speak to the cases at hand as I'm not familiar enough with them [10:45:45] actually let's PM. it's offtopic for this channel [10:45:49] true [10:45:57] (sorry just had a disconnect) [12:26:11] hello [12:26:40] hi [12:26:45] see my messages [12:27:00] read them [12:27:35] sorry for the delay [12:27:42] I was sleeping [12:28:11] sleeping in the day [12:28:18] coding at night [12:28:22] => no good [12:35:43] yeah :) [12:38:39] zhuyifei1999_ : https://codeshare.io/2Wew7l [12:39:09] ? [12:39:19] how to catch that warning and show a message to the user or probably show the existing image in commons to the user? [12:39:40] except pywikibot.UploadWarning: [12:40:02] ok [12:48:48] hi. I'm back. went for a run [12:49:22] * zhuyifei1999_ is gonna zzz soon [12:49:49] you live so close in timezone but have a completely opposite schedule ;) [12:50:04] lol [12:51:03] sort of yeah [12:51:13] so there's really only 1 week of real coding left [12:51:27] I'd like for you to start putting the dots on the I's so to say [12:51:54] so the code needs some work to get it to be really scalable [12:52:07] and I'd like to see some (small) changes to the interface [12:52:08] infobliss: I'm wondering if you are willing to continue this project after GSoC [12:52:41] zhuyifei1999_ : sure [12:54:04] nice, it's not a must btw [12:54:14] at this moment I really have doubt if the code can be a production tool by the time of final evaluation. we may or may not fail you, at this moment idk, but if you don't finish it would kind of suck for us to mentor this again for next year, imo [12:56:15] I am optimistic though that we will finish it in time [12:56:49] please be a little more specific as to what is worrying you [12:57:46] the progression [12:58:05] tempo of things, and tempo of picking up on our remarks [12:58:23] I think we'll have to discuss a bit more what the finished product would entail [12:58:33] I hope we can manage to get real scalability in there [12:59:00] that means that a for a new glam only 2 things have to be done [12:59:08] and some basic programming stuffs. I mean, you don't seem to fully understand exceptions and how to use it to control flow [12:59:13] a glammapping has to be created [12:59:33] and a config file has to be edited adding a new line for the new glam [13:00:38] I thought that's pretty much what we have already. [13:02:01] https://github.com/infobliss/sibutest2/commit/b11041a1cce5f7d59531fb0573acf45daad8a5e8 [13:02:10] you add the glam-specific text in the html [13:02:21] that should also be loaded from the single config if possible [13:02:44] now if somebody want to add a glam they have to change app.py, and some html files [13:02:52] we'll have to streamline that the next week [13:04:39] I will find out how to do that [13:05:00] Is there anything else? [13:06:58] the points from zhuyifei [13:07:03] in the log [13:07:05] I think around 10 [13:07:12] as for the interface [13:07:23] I found some things I think can better be slightly changed [13:07:44] below the log-in button at the start we need a small description of what the tool/site is about [13:07:57] and the steps to take [13:08:08] them for the choose glam button [13:08:19] when I enter a search string the button shouldn't say upload [13:08:21] it's confusing [13:08:31] it doesn't look like that button is connected to that [13:08:46] the steps need to be clearly layed out there as well [13:09:00] so it can be something like: [13:09:12] "To upload one or multiple images first select a glam" [13:09:18] then the glam selection drop down [13:09:43] ok [13:09:57] then: you can either enter a single identifier to upload a single file or enter a search term to search for multiple files [13:10:04] single file should be above multiple file [13:10:33] yeah I was thinking that too [13:10:45] then the sample should either be in the typebox [13:10:49] or above [13:11:09] then about the multiple file upload [13:11:25] maybe add categories afterwards? [13:11:29] not before seeing the image [13:11:30] s [13:11:50] more category? should be: add another category or more categories [13:12:26] for multiple images, if you stick to 10 I find the thumbnails rather small [13:12:34] I like that you can click through to the image [13:12:48] I'd prefer the images to take up a default width [13:13:55] it seems for NA it's showing 10 images [13:14:01] and for amsterdam museum it;s showing 100 [13:14:14] I thought you were also going to do pagination [13:14:24] I think for NA there was no limit set [13:14:57] Oh I thought pagination was not a priority [13:15:03] I'm pretty sure there is a limit of 10 [13:15:18] no priority, but I hoped it would be in the scope of the project [13:16:12] ok I will try [13:16:23] the other things have priority [13:17:22] how much default width for an image do you prefer? [13:17:46] I think twice [13:17:49] right now we have height: 100px; width: auto; [13:17:52] ehm twice the hight [13:18:09] or 150px [13:18:20] ok [13:18:22] now I can't really determine what happens [13:18:30] in the picture [13:18:33] gosh, I said use CSS fluxbox like a million times [13:19:11] (just had a long shower) [13:20:26] zhuyifei1999_ sorry I might have missed it [13:20:26] *flexbox [13:20:35] will modify [13:20:42] basvb: http://www.gahetna.nl/beeldbank-api/zoek/?q=dammen [13:20:53] gives only 10 images for me [13:21:00] by default [13:21:02] yes that's default [13:21:18] was the same for amsterdam museum [13:21:24] you can look beyond default [13:22:12] you need to when you want to do pagination [13:22:33] infobliss: https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit [13:22:56] may be we set 100 as done for AM [13:22:58] (or more-browser-compatibility, https://developer.mozilla.org/en-US/docs/Web/CSS/background-size) [13:23:41] yep infobliss 100 sounds good for now [13:25:31] I think other than the dynamic loading of the dropdown others are minor changes [13:26:50] In fact I am not sure how difficult dynamic loading of dropdowns is going to be [13:27:50] dynamic loading of dropdown and help texts [13:27:56] And had zhuyifei1999_ not said that he thinks that the project completion in time is at risk I was thinking that we were doing well [13:28:18] yeah help texts are already dynamic [13:28:33] Just need to change their content [13:28:58] ow well I've learned to always bring the message positive, negative, positive, but I thought we were pretty clear in the communication that a lot had to be done [13:29:12] also in the GSOC comments on the progress during evaluation [13:29:32] I thought the evaluation last time was pretty clear in that we needed to get things better on the rails [13:29:46] yeah sure you did [13:30:01] we've improved in communication definiatly, although the time shifting that much and missing the opportunity to discuss with zhuyifei hurts the process [13:30:23] zhuyifei is much better on the technical and front-end side than me, so it's good to be able to discuss those with him [13:31:28] but overall I feel during the whole process the things we had to discuss were often very basic coding things [13:31:52] zhuyifei1999_ : Do you think other than the dynamic loading of the dropdown there are any major changes required? [13:32:04] I had hoped and thought before the project you would be a bit farther in those aspects, now it often turned into a lot of handholding [13:32:43] it has to be a well working full app/website for commons user [13:32:49] so it has to be clear what they can do [13:33:08] yeah sure those parts will be easy to do [13:33:12] as well as that it has to be easy to add a new glam by any programmer who know python [13:33:22] I mean those are simple front-end changes [13:33:23] in coding easy things can always turn out to be difficult [13:33:43] I know for my thesis the thing I thought would take me 2 months I could do in 2 days [13:33:55] where the thing I thought I could do in 2 days turned out to be 2 months work [13:35:12] Please rest assured that those front-end changes will be done today [13:35:29] ok [13:36:19] I think zhuyifei1999_ is not here [13:37:11] he is sleeping [13:38:56] so from your side after trying the tool do you have any further requirements except making the app a little more documented for ease of use? [13:41:01] preferably pagination, getting a lot of documentation and text in order [13:41:08] fixing user flow [13:41:18] and on the back-end scalability [13:41:27] fixing user flow? [13:41:42] you mean categories ? [13:42:10] since we show images for multiple images only [13:42:33] fixing the issues I mentioned which confuse users [13:42:47] yes that will be done today [13:43:27] I am asking for multiple categories you wished to be be able to choose categories again after seeing the images [13:43:27] ok [13:43:33] right? [13:43:43] then I'm going to do some other things and let you get on to work [13:45:21] that will require to ask the categories once more in the image gallery. Is that what you wish? [13:52:49] hmm, seems like a more logical place for it [13:53:13] after deciding on the images you decide on the category [13:53:24] ow one thing: the handling of duplicates how is that going? [13:53:37] will it return a nice message that the image is duplicate and where to find it? [15:10:14] Yes that I will do today