[10:48:23] hi [13:01:40] Hello [13:08:36] @Basvb I made an upload with the new NationalArchief2.py. [13:08:51] it seems to be working as expected. [13:09:17] the files end up in https://commons.wikimedia.org/wiki/Category:Images_from_Nationaal_Archief [13:10:14] nice [13:11:11] but the tool is not yet working for one reason. [13:12:12] pywikibot looks for the username in the user-config.py. [13:12:40] While simply running it from my local machine, upload is smooth. [13:13:02] But the to add Oauth flow is trickier. [13:13:35] presently a user can be authenticated using the mediawiki credentials. [13:14:06] but finally when the pywikibot is called to upload the chosen file, [13:14:30] it still looks into user-config? [13:14:45] it looks for the username in the user-config.py [13:14:48] yes [13:15:01] that can be an issue yes, I'm not too familiar with tool labs myself, maybe tom29739 or zhuyifei knows this issue from earlier experience [13:15:43] yeah and I thought of just testing for myself as a user. [13:16:06] And added user as infobliss in the user-config.py [13:17:00] zhuyifei has shown me the corresponding code in v2c. [13:17:18] I am yet to look deep into it. [13:21:23] aah but you shouldn't add your pw then? [13:21:32] or is that manually typed each time? [13:21:51] It did not work that way. [13:21:57] raised an error [13:22:34] https://github.com/wikimedia/pywikibot-core/blob/master/pywikibot/config2.py#L1064 [13:23:09] config2.py:1064: UserWarning: Configuration variable table2wikiSkipWarnings is defined but unknown. Misspelled? [13:27:42] by the way shall we define the MVP anytime soon? [13:29:27] https://phabricator.wikimedia.org/T161331 [13:30:12] yep, some general ideas on the design seem to be a good idea [13:30:57] yeah [13:32:20] do you have any preferences about the design of the UI? [13:33:42] some general ideas about the flow, I think I discussed those last week [13:33:57] how things look (colors and shapes) I think that's up to your preferences [13:34:06] alright. [13:58:17] hi zhuyifei [13:58:39] hi [13:58:46] did I miss anything? [13:58:53] no [13:59:12] I mean yeah [13:59:23] ;) [13:59:27] * zhuyifei1999_ looks at the chat logs [14:00:48] btw I was trying to understand what is going to happen to the config file when pywikibot.UploadRobot() is called. [14:01:07] infobliss: for that user-config, keep it to a bare minimum without writing any auth config. that includes username [14:01:24] monkey patch the loaded config on runtime [14:03:17] ok [14:03:20] https://github.com/toollabs/video2commons/blob/master/video2commons/backend/worker.py#L131 [14:03:33] this writes to which config file? [14:05:05] Also during mw oauth the user has been already made to provide his credentials. [14:06:03] https://github.com/toollabs/video2commons/blob/master/video2commons/backend/worker.py#L132 [14:06:15] what will this login() do? [14:06:30] it doesn't write, it does a monkey pach [14:06:35] *patch [14:06:56] https://en.wikipedia.org/wiki/Monkey_patch [14:07:20] ok [14:07:25] it does not actually change the user-config.py, but change the config for that process locally [14:07:42] login() will make sure it's logged in [14:07:50] idk if it's necessary though [14:08:27] ok [14:09:02] So we won't need to ask the user his/her pw again? [14:09:17] we shouldn't ask for pw in any case [14:09:26] oauth is sufficient [14:10:40] alright.