[00:00:05] RoanKattouw, ^d, marktraceur, MaxSem, kaldari: Dear anthropoid, the time has come. Please deploy Evening SWAT (Max 8 patches) (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20141204T0000). [00:00:36] I can do it [00:03:02] (03CR) 10MaxSem: [C: 032] Setting $wgMFEnableWikiGrokOnAllDevices to true on en Beta Labs [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177153 (owner: 10Kaldari) [00:03:17] (03Merged) 10jenkins-bot: Setting $wgMFEnableWikiGrokOnAllDevices to true on en Beta Labs [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177153 (owner: 10Kaldari) [00:04:22] !log maxsem Synchronized wmf-config/: https://gerrit.wikimedia.org/r/#/c/177153/ , noop in production (duration: 00m 07s) [00:04:25] Logged the message, Master [00:04:26] kaldari|2, ^^^ [00:04:51] MaxSem: testing... [00:05:08] tgr, yt? [00:05:22] legoktm, yt? [00:05:31] MaxSem: hey [00:05:48] my backports are just adding a maint. script [00:10:53] !log maxsem Synchronized php-1.25wmf10/extensions/WikiGrok/: https://gerrit.wikimedia.org/r/177393 (duration: 00m 08s) [00:10:57] Logged the message, Master [00:11:07] !log maxsem Synchronized php-1.25wmf11/extensions/WikiGrok/: https://gerrit.wikimedia.org/r/177393 (duration: 00m 05s) [00:11:09] Logged the message, Master [00:11:26] greg-g: ori: TimStarling: We found the problems with sites in Wikibase. Patches are merged. Do you want the backport now or next week, or... ? [00:11:31] Two small patches [00:11:54] how safe are the patches? [00:11:56] MaxSem: that config change doesn't seem to have had any effect :( [00:12:11] Reedy: Did you stash the error log somewhere? (I assume it's disabled again) [00:12:12] One is extremely trivial [00:12:16] the other one rather trivial [00:12:27] Krinkle: They've been rotated, so they're in the archive folder [00:12:29] ori: https://gerrit.wikimedia.org/r/177429 [00:12:32] * ori looks [00:12:34] bd808: now labs_vagrant says "Fatal error: Class 'MWLogger' not found in /srv/vagrant/mediawiki/includes/GlobalFunctions.php on line 1107" [00:12:38] Is that another role I need to add? [00:12:39] that's the not-that-trivial one [00:12:43] Reedy: OK [00:12:46] Reedy: And logstash? [00:12:54] Not done yet for the error log [00:13:05] Reedy: look at git-status in wmf9 on tin. [00:13:08] /a/mw-log/archive/error.log-20141118.gz [00:13:11] andrewbogott: you need to run composer I bet [00:13:22] hoo: do it, imo [00:13:25] ...ok... [00:13:26] Ok [00:13:34] in vagrant? I've never done that [00:13:42] Krinkle: lol. We're not using wmf9 now at least. But yes, that really sucks [00:13:49] andrewbogott: Do you have a /vagrant/mediawiki/vendor directory? [00:14:16] I don't [00:14:51] andrewbogott: The master branch of mw-vagrant would take care of this for you (at least on the first install) but the older branch doesn't know anything about composer dependencies [00:15:45] greg-g: you saw that? [00:16:32] bd808: So vagrant is no longer maintained for precise at all, huh? [00:17:19] andrewbogott: nope [00:17:33] andrewbogott, no - you just need to run vagrant git-update instead of git pull [00:18:05] andrewbogott: The easier thing for you than using composer would be to clone mediawiki/vendor.git into your mediawiki checkout [00:18:26] MaxSem: He's on a 12.04 labs box [00:19:24] blegrgh [00:19:31] then vagrant destroy [00:21:03] (03CR) 10MaxSem: [C: 032] Force CommonsMetadata on beta to recalculate data from prod [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177271 (owner: 10Gergő Tisza) [00:21:25] (03Merged) 10jenkins-bot: Force CommonsMetadata on beta to recalculate data from prod [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177271 (owner: 10Gergő Tisza) [00:21:54] !log maxsem Synchronized wmf-config/: https://gerrit.wikimedia.org/r/#/c/177271/ (duration: 00m 07s) [00:21:59] Logged the message, Master [00:22:04] tgr, please test ^^^ [00:22:47] this is broken in every way :( [00:24:27] omgbutwhy anyone couldpotentiallyneedprecise [00:25:00] Reedy: (sorry, I dropped for a sec, did you reply?) [00:25:14] [00:13:42] Krinkle: lol. We're not using wmf9 now at least. But yes, that really sucks [00:25:28] !log maxsem Synchronized php-1.25wmf10/maintenance/removeInvalidEmails.php: https://gerrit.wikimedia.org/r/#/c/177021/ (duration: 00m 05s) [00:25:30] Logged the message, Master [00:25:31] k :) [00:25:48] !log maxsem Synchronized php-1.25wmf11/maintenance/removeInvalidEmails.php: https://gerrit.wikimedia.org/r/#/c/177021/ (duration: 00m 05s) [00:25:50] Logged the message, Master [00:25:54] legoktm, ^^^ [00:26:07] thanks! [00:26:19] MaxSem: I can't find a non-cached image to test on right now, but the change only affects beta, so no huge deal if it doesn't work [00:26:21] I'll run the script later on [00:26:30] ok [00:26:31] thanks for deploying! [00:26:39] :) [00:28:43] Notice: Unable to unserialize: [a:12:{s:5:"width";i:1004;s:6:"height";i:1416... [00:30:53] MaxSem: Want to push a Wikidata update in a bit? :P [00:31:09] if I have a permssion;) [00:31:18] Well, guess I can also do it myself :P [00:31:29] Last minute patching, ftw [00:35:09] MaxSem: https://gerrit.wikimedia.org/r/177446 and https://gerrit.wikimedia.org/r/177447 ? :) [00:36:11] still need someone to give a permission [00:36:22] ah whatever [00:36:24] SWAT [00:36:33] hoo, please add to calendar [00:36:35] I can +2 myself if that makes oyu more comfortable [00:36:40] will do [00:37:28] hoo, next time please mention commit being cherrypicked in summary [00:37:39] Yeah, forgot that :S [00:37:45] Will mention it on wiki [00:39:41] !log maxsem Synchronized php-1.25wmf10/extensions/Wikidata/: (no message) (duration: 00m 12s) [00:39:44] Logged the message, Master [00:40:00] !log maxsem Synchronized php-1.25wmf11/extensions/Wikidata/: (no message) (duration: 00m 13s) [00:40:03] Logged the message, Master [00:40:06] hoo, ^^^ [00:40:19] watching the graphs [00:41:15] awesome: https://ganglia.wikimedia.org/latest/graph_all_periods.php?c=Memcached%20eqiad&m=cpu_report&r=hour&s=by%20name&hc=4&mc=2&st=1417641558&g=network_report&z=large [00:52:35] springle: is there any page table schema change going on? [00:54:13] AaronS: none. last one was ~month ago [00:55:18] huh, I'm seeing slow selects for page rows in it [00:55:29] springle: e.g. go to a random page with ?forceprofile=true [00:57:29] AaronS: i'm not seeing much difference with forceprofile. certain? [00:58:27] do you see the output in view source? [01:00:35] I keep seeing 200-300ms for WikiPage::loadPageData ... though some of that may be hooks (though I don't see offenders) [01:01:20] (03PS2) 10EBernhardson: Disable LQT on office wiki [mediawiki-config] - 10https://gerrit.wikimedia.org/r/175563 [01:01:39] when I first saw the xhprof stats I thought they're bugged. still not sure they're not:P [01:01:45] AaronS: if i'm reading the html commentcorrectly, i see about 30ms for WikiPage::loadPageData [01:02:26] 77.27% 223.074 19 - wfRunHooks on https://en.wikipedia.org/wiki/Domitianus_II?forceprofile=true [01:02:39] I mean 83.83% 399.348 1 - WikiPage::pageData [01:03:11] 91.70% 299.163 1 - MediaWiki::getAction <-- BS [01:05:44] that ends up calling WikiPage::factory( $title ), which calls methods on the page, which make it load and do the query [01:05:49] please actually follow the call chain [01:06:11] I thought actionName looked odd too, but the chain makes sense [01:07:19] * AaronS goes afk for a bit [01:08:05] PROBLEM - HHVM busy threads on mw1232 is CRITICAL: CRITICAL: 30.00% of data above the critical threshold [115.2] [01:08:06] would be cool to have something like https://lh4.googleusercontent.com/MppDN5ETv7QGO0WoKn7DIH83r364dl2HTEN35X_sgSevRTk5m19W4EhYi4SDVCjj6EVLbNeE7CaOajmYP9nEJl9vnbXMVGyKA9tkGApe3YUzCi2i77SyPbhugqU4r5CN-A [01:09:47] hoo: !! nice! [01:10:06] ori: More in the pipeline: https://gerrit.wikimedia.org/r/177416 [01:10:56] RECOVERY - HHVM busy threads on mw1232 is OK: OK: Less than 30.00% above the threshold [76.8] [01:15:59] (03PS1) 10Ori.livneh: Enable $wgAjaxEditStash on Beta [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177454 [01:16:19] (03PS2) 10Ori.livneh: Enable $wgAjaxEditStash on Beta [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177454 [01:16:27] (03CR) 10Ori.livneh: [C: 032] Enable $wgAjaxEditStash on Beta [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177454 (owner: 10Ori.livneh) [01:16:38] (03Merged) 10jenkins-bot: Enable $wgAjaxEditStash on Beta [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177454 (owner: 10Ori.livneh) [01:17:06] ^ AaronS, fyi [01:21:11] MaxSem: A flame graph would be cool. I think there are some projects that have started working on that for the raw xhprof data. [01:21:50] PROBLEM - puppet last run on virt1007 is CRITICAL: CRITICAL: Puppet has 1 failures [01:22:11] bd808, though it could be ridiculously tall with preprocessor calls:) [01:22:12] PROBLEM - puppet last run on tungsten is CRITICAL: CRITICAL: Puppet has 1 failures [01:22:29] PROBLEM - puppet last run on mw1029 is CRITICAL: CRITICAL: Puppet has 1 failures [01:22:33] MaxSem: http://nathanielhoag.com/blog/2014/11/23/flamegraphs-show-why-fast-404-is-important-for-drupal-performance/ [01:22:59] They use sample mode :( [01:26:26] !log labsdb1003 upgrade & reboot [01:26:30] Logged the message, Master [01:30:26] RECOVERY - puppet last run on virt1007 is OK: OK: Puppet is currently enabled, last run 29 seconds ago with 0 failures [01:30:56] (03PS1) 10Krinkle: Minor code clean up PHP and HTML files in w/ [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177459 [01:31:07] RECOVERY - puppet last run on tungsten is OK: OK: Puppet is currently enabled, last run 59 seconds ago with 0 failures [01:31:25] Reedy: Fancy a quick CR on ^ [01:31:26] RECOVERY - puppet last run on mw1029 is OK: OK: Puppet is currently enabled, last run 33 seconds ago with 0 failures [01:32:53] (03CR) 10Ori.livneh: [C: 04-2] "It's a dependency for php-memcached on Precise, and php-memcached breaks without it." [puppet] - 10https://gerrit.wikimedia.org/r/177431 (owner: 10MaxSem) [01:34:49] (03CR) 10Ori.livneh: [C: 031] Minor code clean up PHP and HTML files in w/ [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177459 (owner: 10Krinkle) [01:35:20] (03CR) 10Reedy: [C: 031] Minor code clean up PHP and HTML files in w/ [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177459 (owner: 10Krinkle) [01:38:49] (03Abandoned) 10MaxSem: Remove igbinary everywhere [puppet] - 10https://gerrit.wikimedia.org/r/177431 (owner: 10MaxSem) [01:40:15] <^d> oh yeah I forgot about that dependency whoops. [01:40:40] <^d> I guess we should make double certain we don't have any stale api apaches writing memcached with igbinary :) [01:41:48] just fucking migrate everywhere:P [01:42:04] MaxSem: yeah [01:56:57] !log labsdb1002 upgrade & reboot [01:57:03] Logged the message, Master [02:01:10] PROBLEM - puppet last run on tungsten is CRITICAL: CRITICAL: Puppet has 1 failures [02:09:46] !log labsdb1001 upgrade & reboot [02:09:49] Logged the message, Master [02:09:50] Reedy: Thanks for touch.php, didn't know about that one. [02:11:02] It was there for a while, I just forgot to plumb it into the apache config [02:12:59] RECOVERY - puppet last run on tungsten is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [02:20:30] (03CR) 10Krinkle: [C: 032] Minor code clean up PHP and HTML files in w/ [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177459 (owner: 10Krinkle) [02:20:42] (03Merged) 10jenkins-bot: Minor code clean up PHP and HTML files in w/ [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177459 (owner: 10Krinkle) [02:20:43] !log l10nupdate Synchronized php-1.25wmf10/cache/l10n: (no message) (duration: 00m 01s) [02:20:47] Logged the message, Master [02:20:47] !log LocalisationUpdate completed (1.25wmf10) at 2014-12-04 02:20:47+00:00 [02:20:52] Logged the message, Master [02:22:01] lies all lies logmsgbot [02:23:49] can someone see if the backtrace for 79208ee3 on enwiki is the same as https://phabricator.wikimedia.org/T76609 ? [02:25:26] <^d> jackmcbarn: Looks like it, yep. [02:25:37] good, thanks. [02:25:43] <^d> yw [02:32:12] !log l10nupdate Synchronized php-1.25wmf11/cache/l10n: (no message) (duration: 00m 01s) [02:32:17] Logged the message, Master [02:32:18] !log LocalisationUpdate completed (1.25wmf11) at 2014-12-04 02:32:18+00:00 [02:32:21] Logged the message, Master [02:40:17] (03PS1) 10Krinkle: Remove w/COPYING and w/CREDITS dead symlinks [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177476 [02:40:47] (03CR) 10Krinkle: "They're dead in git, and dead on tin as well (it's not a local thing that was half in git). http://en.wikipedia.org/w/COPYING is 404 over " [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177476 (owner: 10Krinkle) [02:40:56] (03CR) 10Krinkle: [C: 032] Remove w/COPYING and w/CREDITS dead symlinks [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177476 (owner: 10Krinkle) [02:41:06] (03Merged) 10jenkins-bot: Remove w/COPYING and w/CREDITS dead symlinks [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177476 (owner: 10Krinkle) [02:42:47] heya grrrit Accesspeople ^d AzaToth ori legoktm ... , do I ask for a grrrit deploy ( https://gerrit.wikimedia.org/r/#/c/177371/ ) here or request it in a SWAT window? [02:43:18] <^d> that's a tool thing, should be deployable anytime by someone who knows how. [02:43:22] <^d> no need for a window. [02:44:08] ^d thanks. I'll ask in #wikimedia-labs [02:45:47] (03CR) 10Awight: [C: 031] "+2 -- but leaving merge for whoever deploys it." [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177278 (owner: 10Ejegg) [02:55:05] !log krinkle Synchronized w/: Ifbfb7dfd8fc0cd822b0 and I6594bc82b9de (duration: 00m 05s) [02:55:07] Logged the message, Master [03:21:37] (03PS1) 10Aaron Schulz: Declare profiler in CLI mode (though it is not used) to support --profiler [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177481 [03:52:41] _joe_, ori, et al.: Congrats on the transition to HHVM! :-) [04:01:52] !log on mw1189: restarting hhvm [04:01:59] Logged the message, Master [04:06:28] RECOVERY - HHVM rendering on mw1189 is OK: HTTP OK: HTTP/1.1 200 OK - 68195 bytes in 1.321 second response time [04:06:49] RECOVERY - puppet last run on mw1189 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [04:07:19] RECOVERY - Apache HTTP on mw1189 is OK: HTTP OK: HTTP/1.1 301 Moved Permanently - 440 bytes in 0.124 second response time [04:23:27] !log LocalisationUpdate ResourceLoader cache refresh completed at Thu Dec 4 04:23:26 UTC 2014 (duration 23m 25s) [04:23:31] Logged the message, Master [04:39:03] (03CR) 10KartikMistry: "cx_ tables are added in wikishared DB now, so this patch can go ahead if everything is OK!" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/175979 (owner: 10KartikMistry) [05:01:58] PROBLEM - puppet last run on tungsten is CRITICAL: CRITICAL: Puppet has 1 failures [05:07:58] (03PS1) 10Chad: Expand ConfirmEdit disabling test to all group0 wikis [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177494 [05:11:32] (03PS1) 10Chad: Disable ConfirmEdit on private wikis [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177495 [05:11:55] (03PS2) 10Chad: Disable ConfirmEdit on closed wikis [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177495 [05:12:17] (03CR) 10Chad: [C: 032] Disable ConfirmEdit on closed wikis [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177495 (owner: 10Chad) [05:12:25] (03Merged) 10jenkins-bot: Disable ConfirmEdit on closed wikis [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177495 (owner: 10Chad) [05:12:56] RECOVERY - puppet last run on tungsten is OK: OK: Puppet is currently enabled, last run 38 seconds ago with 0 failures [05:13:00] !log demon Synchronized wmf-config/InitialiseSettings.php: confirmedit disabled on closed wikis (duration: 00m 05s) [05:13:04] Logged the message, Master [05:13:05] <^d> 127 less wikis with confirmedit :p [05:19:21] Nice. [05:23:34] (03CR) 10MZMcBride: "Thanks for this." [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177494 (owner: 10Chad) [05:26:31] <^d> I thought group0.dblist got added. [05:28:59] <^d> Ah, it does but not in commonsettings. [05:32:39] ^d: +1 for the patch apart from the technical bit [05:33:13] <^d> We can add group0 to the commonsettings bit easily enough. [05:34:49] (03PS2) 10Chad: Expand ConfirmEdit disabling test to all group0 wikis [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177494 [05:35:25] ^d: does CirrusSearch pay any attention to searchNs* user preferences? (which indicate whether a namespace should be searched by default for some user) [05:35:39] <^d> That's a MW core thing. [05:36:07] <^d> We just search the namespaces given to us, Special:Search has already figured out prefs/ticked boxes by that one. [05:36:16] <^d> s/one/point/ [05:36:22] aha, ok [05:36:29] <^d> Why you ask? :) [05:36:48] <^d> Fiona: Did we have a bug filed somewhere about cleaning up dblists to some subdirectory? [05:37:17] i have a patch open for it and i boldly declared my intents to see it through, but i haven't actually done anything [05:37:28] (cleaning up dblists) [05:37:47] <^d> For some reason I found myself grepping about for them now. We'll need symlinks for some. [05:37:53] <^d> Lots of puppet. Couple of extensions. [05:38:55] re: search preferences -- the scheme for search preferences is silly; each namespace gets a preference, and the value is boolean, which is unfortunately verbose when encoded as json [05:39:26] so for example on every page on enwiki this is included for me in the html output: [05:39:28] searchNs1":false,"searchNs2":false,"searchNs3":false,"searchNs4":false,"searchNs5":false,"searchNs6":false,"searchNs7":false,"searchNs8":false,"searchNs9":false,"searchNs10": [05:39:28] false,"searchNs11":false,"searchNs12":false,"searchNs13":false,"searchNs14":false,"searchNs15":false,"searchNs100":false,"searchNs101":false,"searchNs108":false,"searchNs109":false,"searchNs118":false,"searchNs119":false,"searchNs446":false,"searchNs447":false,"searchNs710":false,"searchNs711":false,"searchNs828":false,"searchNs829":false,"searchNs2600":false [05:39:50] <^d> Yes, it's an awful preference. [05:40:09] <^d> Also there's some bug about negative numbers being used. [05:40:29] i was going to fix it but then i suddenly had a lazy thought that maybe cirrus had obsoleted these and they could just be removed [05:40:42] but i guess not [05:41:02] <^d> !phab T54777 [05:41:10] <^d> No phab links? Boo. [05:41:28] <^d> !phab is https://phabricator.wikimedia.org/`1 [05:41:28] Unable to modify db, access denied, link to database isn't valid [05:41:33] <^d> Oh boo [05:41:42] <^d> Anyway, that task. [05:42:23] yeah reading it [05:42:31] user prefs can only be boolean, right? [05:44:10] What? [05:44:42] yeah that's not right [05:44:56] ori: Does that extra HTML output matter? [05:44:57] <^d> No, they can be other things. [05:46:17] Not that I disagree with killing overly expressive cruft in the HTML page source, but in terms of performance, I imagine that code isn't really hurting us. [05:47:55] it's half a kilobyte per page, ~150 bytes w/gzip. so no, probably not. but interesting it's a database issue as well [05:48:15] there's a bug about the user_properties table being bloated [05:48:23] that's the one that ^d just linked to [05:48:30] https://phabricator.wikimedia.org/T54777 [05:48:41] i haven't customized my default search namespaces at all so i shouldn't be seeing any of them [05:49:08] oh [05:49:27] Hmmm. [05:49:36] I thought I fixed the trailing newline for en.wikipedia.org. [05:51:40] what the hell? [05:51:59] $defaultPreferences['searchNs' . $n] = array( 'type' => 'api' ); [05:52:05] no wonder [05:52:24] [05:52:24] Does PHP eat the newline? [05:52:38] <^d> I'm experimenting with folding that into one preference. [05:52:52] <^d> And only saving true values, not false. [05:52:56] <^d> Should cut down on db bloat. [05:53:18] ^d: there's a simpler fix, it seems [05:53:37] <^d> Hmm? [05:53:44] the default preferences set each searchable searchNsN to array( 'type' => 'api' ) [05:54:16] but the user default preferences set it to a boolean value [05:54:31] so you end up thinking the user has customized a lot more than she or he actually has [05:55:37] the preference-per-namespace scheme is not awful if you only store preferences that differ from the default [05:56:48] Okay, so I see "\n Where does the \n go... [05:57:56] ^d: you merged it! :P https://gerrit.wikimedia.org/r/#/c/131727/ [05:58:18] <^d> Yeah I know. It used to be a ton of checkboxes on the prefs page. [05:58:20] <^d> And was ugly :) [05:59:21] * ori fixes [06:00:08] Nemo_bis: what is the type => api thing? [06:00:37] API means it doesn't show up on Special:Prefs, but can be set via API:Options [06:01:00] https://www.mediawiki.org/wiki/Manual:Hooks/GetPreferences#API_preferences [06:02:30] Yes, did we still not document that [06:03:10] so it's tri-state, with possible values being: true, false, and array( 'type' => 'api' ) ? [06:06:13] API means it doesn't show up on Special:Prefs, but can be set via API:Options [06:06:32] what is the actual preference value it's array( 'type' => 'api' )? [06:06:40] *when it's [06:06:50] should it be searched or not? [06:07:51] I think so? [06:08:17] Fiona: valid answers are "Yes", "No", or "Array" [06:08:57] !tias [06:10:31] so, really, there should be a config option for which namespaces are shown on Special:Preferences and which are settable via the API alone [06:10:41] and it should have nothing to do with the actual preference value [06:12:20] I think you mean Special:Search? [06:12:41] The namespace checkboxes are no longer at Special:Preferences, I believe. [06:12:54] <^d> There's a lot of types. [06:12:58] <^d> Not just boolean or api. [06:14:12] <^d> Type is mostly stuff like multiselect/radio/etc for the special:preferences page. [06:14:34] aha [06:14:34] <^d> type = api is for things that are explicitly *not* shown on special:preferences and are only available internally and via the API. [06:14:49] <^d> mw core is not the only user of this, there's a few extensions if memory serves too. [06:15:30] <^d> To make it extra fun, we also have stuff like int and float. [06:15:36] If you're looking for preferences work, I have some design tasks. [06:16:29] The HHVM beta feature is still enabled? [06:17:09] d'oh, is it? [06:17:21] i think we should just change: [06:17:24] https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-betafeatures [06:17:27] $defOpt['searchNs' . $nsnum] = !empty( $wgNamespacesToBeSearchedDefault[$nsnum] ); [06:17:42] to: [06:18:42] I just burped and it tasted like sushi. [06:18:49] $defOpt['searchNs' . $nsnum] = empty( $wgNamespacesToBeSearchedDefault[$nsnum] ) ? array( 'type' => 'api' ) : true; [06:19:16] that should fix it [06:19:42] PROBLEM - HTTP error ratio anomaly detection on tungsten is CRITICAL: CRITICAL: Anomaly detected: 10 data above and 8 below the confidence bounds [06:20:07] Patch or it never happened. [06:26:30] yeah i'm on it [06:30:43] Nemo_bis: since the search namespace preferences are no longer at Special:Preferences anyway, and only at Special:Search (when you click 'advanced'), is there really a need to make them api-only? [06:32:03] <^d> Why would you want to set the default preference to an array? [06:32:13] <^d> The default prefs in User are not the same thing as type. [06:32:56] yeah, i just realized that [06:34:22] PROBLEM - puppet last run on db1040 is CRITICAL: CRITICAL: Puppet has 2 failures [06:35:23] PROBLEM - puppet last run on cp1061 is CRITICAL: CRITICAL: Puppet has 2 failures [06:35:24] PROBLEM - puppet last run on mw1042 is CRITICAL: CRITICAL: Puppet has 3 failures [06:36:10] PROBLEM - puppet last run on mw1170 is CRITICAL: CRITICAL: Puppet has 1 failures [06:36:13] PROBLEM - puppet last run on mw1119 is CRITICAL: CRITICAL: Puppet has 2 failures [06:44:32] (03CR) 10MZMcBride: [C: 031] "I think this is fine to try. Just be sure to sync CommonSettings.php first. :-)" [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177494 (owner: 10Chad) [06:45:31] (03CR) 10Jforrester: [C: 031] Expand ConfirmEdit disabling test to all group0 wikis [mediawiki-config] - 10https://gerrit.wikimedia.org/r/177494 (owner: 10Chad) [06:45:40] RECOVERY - puppet last run on mw1042 is OK: OK: Puppet is currently enabled, last run 6 seconds ago with 0 failures [06:46:11] RECOVERY - puppet last run on mw1170 is OK: OK: Puppet is currently enabled, last run 31 seconds ago with 0 failures [06:46:22] ori: so the context is that you're trying to optimise the huge