[00:43:00] (03PS1) 10Ebe123: Add namespace aliases for ang.wikipedia and wiktionary [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112409 [00:49:51] (03PS1) 10SPQRobin: Enable VisualEditor on Wikimedia Incubator [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112410 [01:09:10] (03CR) 10PiRSquared17: [C: 031] Add namespace aliases for ang.wikipedia and wiktionary [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112409 (owner: 10Ebe123) [01:13:55] (03PS2) 10Ebe123: Add namespace aliases for ang.wikipedia and wiktionary [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112409 [01:40:00] (03CR) 10PiRSquared17: [C: 031] Add namespace aliases for ang.wikipedia and wiktionary [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112409 (owner: 10Ebe123) [02:03:16] (03PS1) 10Springle: depool db1002 for schema changes [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112411 [02:06:04] (03CR) 10Springle: [C: 032] depool db1002 for schema changes [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112411 (owner: 10Springle) [02:06:12] (03Merged) 10jenkins-bot: depool db1002 for schema changes [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112411 (owner: 10Springle) [02:07:15] !log springle synchronized wmf-config/db-eqiad.php 's2 depool db1002 schema changes' [02:07:24] Logged the message, Master [02:08:15] !log LocalisationUpdate completed (1.23wmf12) at 2014-02-10 02:08:14+00:00 [02:08:23] Logged the message, Master [02:16:00] !log LocalisationUpdate completed (1.23wmf13) at 2014-02-10 02:15:59+00:00 [02:16:06] Logged the message, Master [02:31:09] !log LocalisationUpdate ResourceLoader cache refresh completed at 2014-02-10 02:31:08+00:00 [02:31:17] Logged the message, Master [02:31:31] (03PS1) 10Springle: repool db1002, depool db1060 schema changes [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112412 [02:32:11] (03CR) 10Springle: [C: 032] repool db1002, depool db1060 schema changes [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112412 (owner: 10Springle) [02:32:20] (03Merged) 10jenkins-bot: repool db1002, depool db1060 schema changes [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112412 (owner: 10Springle) [02:33:10] !log springle synchronized wmf-config/db-eqiad.php 's2 repool db1002, depool db1060 schema changes' [02:33:17] Logged the message, Master [02:43:07] (03PS1) 10Springle: repool db1060 warm up [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112414 [02:43:32] (03CR) 10Springle: [C: 032] repool db1060 warm up [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112414 (owner: 10Springle) [02:43:40] (03Merged) 10jenkins-bot: repool db1060 warm up [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112414 (owner: 10Springle) [02:44:32] !log springle synchronized wmf-config/db-eqiad.php 's2 repool db1060 warm up' [02:44:41] Logged the message, Master [03:00:41] (03PS1) 10Springle: prepare for s2 master rotation db1036 to db1024 [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112415 [03:01:45] (03CR) 10Springle: [C: 032] prepare for s2 master rotation db1036 to db1024 [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112415 (owner: 10Springle) [03:01:53] (03Merged) 10jenkins-bot: prepare for s2 master rotation db1036 to db1024 [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112415 (owner: 10Springle) [03:03:02] !log springle synchronized wmf-config/db-eqiad.php 'prepare for s2 master rotation db1036 to db1024 (eqiad)' [03:03:09] Logged the message, Master [03:03:43] !log springle synchronized wmf-config/db-pmtpa.php 'prepare for s2 master rotation db1036 to db1024 (pmtpa)' [03:03:50] Logged the message, Master [03:11:39] PROBLEM - mysqld processes on db1036 is CRITICAL: PROCS CRITICAL: 0 processes with command name mysqld [03:14:40] (03PS1) 10Springle: s2 switch master to db1024 [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112416 [03:15:08] (03CR) 10Springle: [C: 032] s2 switch master to db1024 [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112416 (owner: 10Springle) [03:15:16] (03Merged) 10jenkins-bot: s2 switch master to db1024 [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/112416 (owner: 10Springle) [03:16:11] !log springle synchronized wmf-config/db-eqiad.php 's2 switch master to db1023 (eqiad)' [03:16:19] Logged the message, Master [03:16:49] !log springle synchronized wmf-config/db-pmtpa.php 's2 switch master to db1023 (pmtpa)' [03:16:56] Logged the message, Master [03:22:35] (03PS1) 10Springle: update dns for s2 master switch to db1024 [operations/dns] - 10https://gerrit.wikimedia.org/r/112417 [03:23:12] (03CR) 10Springle: [C: 032] update dns for s2 master switch to db1024 [operations/dns] - 10https://gerrit.wikimedia.org/r/112417 (owner: 10Springle) [03:34:42] (03PS1) 10Springle: update coredb topology for s2 master switch [operations/puppet] - 10https://gerrit.wikimedia.org/r/112418 [03:35:16] (03CR) 10jenkins-bot: [V: 04-1] update coredb topology for s2 master switch [operations/puppet] - 10https://gerrit.wikimedia.org/r/112418 (owner: 10Springle) [03:40:39] !log springle synchronized wmf-config/db-eqiad.php 's2 switch master to db1023 (eqiad)' [03:40:46] Logged the message, Master [03:41:14] !log springle synchronized wmf-config/db-pmtpa.php 's2 switch master to db1023 (eqiad)' [03:41:19] * springle sigh [03:41:22] Logged the message, Master [04:04:31] (03CR) 10Swalling: [C: 04-1] "See my comments." (032 comments) [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/111460 (owner: 10Phuedx) [04:08:57] (03PS2) 10Springle: update coredb topology for s2 master switch [operations/puppet] - 10https://gerrit.wikimedia.org/r/112418 [04:10:49] (03CR) 10Springle: [C: 032 V: 032] update coredb topology for s2 master switch [operations/puppet] - 10https://gerrit.wikimedia.org/r/112418 (owner: 10Springle) [04:37:50] mark, ping me when you're up and/or have a minute? I have yet another networking puzzle [05:33:09] PROBLEM - MySQL Idle Transactions on db1016 is CRITICAL: CHECK_NRPE: Socket timeout after 10 seconds. [05:33:59] RECOVERY - MySQL Idle Transactions on db1016 is OK: OK longest blocking idle transaction sleeps for 0 seconds [06:26:52] springle, still working? I'm stumped by something that an op with even the most modest apache skills can probably sort out in 5 minutes :( [06:28:01] andrewbogott: what's up? [06:28:27] there ought to be a wiki hosted by virt1000, but 'Firefox can't establish a connection to the server at virt1000.wikimedia.org' [06:28:35] I can access services on other ports on that box... [06:28:44] And sites-enabled &c look right to me. [06:28:46] See anything obvious? [06:29:19] (At some point Ryan intentionally disabled the site, so it's possible there's something actively blocking http(s). Although I /think/ I've already fixed the thing that he changed.) [06:29:43] I disabled it, yeah [06:29:46] is ferm allowing it? [06:30:00] is apache running and configured [06:30:13] most importantly, is mediawiki up to date there? :) [06:30:15] Ryan_Lane: when you disabled, what did you do? Just break the link to the wiki? [06:30:27] I removed the symlink that apache uses [06:30:34] Ah, yep -- I replaced that. [06:30:37] but you should still be able to get to apache [06:30:38] And apache is running [06:30:45] what ip is it running on? [06:31:05] why are you bringing up mediawiki there? [06:31:14] I think virt1000 is 208.80.154.18 [06:31:31] …in anticipation of wikitech moving there. [06:31:39] oh, we're going to do that first? [06:31:41] And, to test OSM and such. [06:31:52] I'd think that would be a relatively late step [06:32:00] It is. [06:32:09] I'm just blocked on other tasks, was going to give OSM + havana a whirl. [06:32:10] PROBLEM - Host mw27 is DOWN: PING CRITICAL - Packet loss = 100% [06:32:24] you may want to consider adding a feature to OSM to let you test other regions, but limit that to a set of users [06:32:33] sure. [06:32:43] but I guess it's good to get some initial testing done :) [06:33:49] RECOVERY - Host mw27 is UP: PING OK - Packet loss = 0%, RTA = 35.34 ms [06:36:03] I don't know anything about ferm, is there a way to query what ports are open? Or should I just dig in puppet? [06:45:14] andrewbogott: port 80 and 443 are closed according to nmap. mite virt1001 need something like webserver::apache in puppet? [06:45:19] * springle guessing a bit [06:45:37] springle: are we talking about 1000 or 1001? [06:45:41] er virt1000 [06:45:43] sorry [06:46:06] It definitely includes a webserver class, but... [06:46:16] well, I'll look around, not sure what would block (or unblock) the port. [06:51:46] oh, springle, you may be right -- looks like the class that includes the webserver is missing. [06:51:54] Must've been there, and then removed… I'll replace it. [06:53:01] (03PS1) 10Andrew Bogott: Added role::nova::manager to virt1000, so I can debug OSM. [operations/puppet] - 10https://gerrit.wikimedia.org/r/112420 [06:55:51] (03CR) 10Andrew Bogott: [C: 032] Added role::nova::manager to virt1000, so I can debug OSM. [operations/puppet] - 10https://gerrit.wikimedia.org/r/112420 (owner: 10Andrew Bogott) [07:02:19] hm… necessary but not sufficient :( [07:05:40] PROBLEM - HTTP on virt1000 is CRITICAL: Connection refused [07:05:58] well, that's not an improvement :( [07:06:10] PROBLEM - MySQL Idle Transactions on db1016 is CRITICAL: CHECK_NRPE: Socket timeout after 10 seconds. [07:06:20] PROBLEM - MySQL InnoDB on db1016 is CRITICAL: CHECK_NRPE: Socket timeout after 10 seconds. [07:07:00] RECOVERY - MySQL Idle Transactions on db1016 is OK: OK longest blocking idle transaction sleeps for 0 seconds [07:07:10] RECOVERY - MySQL InnoDB on db1016 is OK: OK longest blocking idle transaction sleeps for 0 seconds [07:08:43] andrewbogott: ferm just updates iptables, so if there is a rule to block some port, it should probably be visible in "iptables -L". [07:10:59] andrewbogott: If Apache is running, there should be an entry in "netstat -at | less" with ":http" or ":80". [07:12:02] it looks to me like http is working but not https [07:13:00] hm, maybe not [07:14:19] well… I don't see any iptables rules about http on virt0 either, and I know it's working there. [07:16:02] And is Apache listening on :80 or :443? [07:17:08] in netstat you mean? Yes on virt0 and no on virt1000. [07:17:37] but I don't know where to go from there. Apache is clearly running. [07:18:03] andrewbogott: this means your have the service runnign in ps-ef |grep apache [07:18:24] yes, and I can see it coming up in the logs. [07:18:26] but not listening on 80 or 443 with netstat -an ? [07:18:44] seems so, unless I'm looking at the wrong thing. [07:19:05] can you telnet to 127.0.0.1 50? [07:19:09] *80 [07:19:22] nope [07:19:24] i guess connection refused [07:19:31] yep [07:19:49] and in the apache config, is it configured to listen on *:80 ? [07:20:44] Is that a thing you have to specify? Surely that's the default... [07:21:02] wouldn't hurt to check [07:21:08] Anyway, we're talking about /etc/apache2/apache2.conf right? [07:21:16] yes [07:21:49] No. [07:22:03] by 'the default' I mean -- it does it even if nothing is specified in the conf [07:22:03] missing one conf there [07:22:09] On WMF, it's /etc/apache2/sites-enabled/*, IIRC. [07:22:36] (Symlinks to ../sites-available.) [07:22:43] Oh, yeah, /that/ is definitely there, same as virt0. From puppet. [07:22:56] 80 is a rewrite to https [07:26:11] andrewbogott: what is the output of netstat -plnt ? [07:27:09] https://dpaste.de/J3iO [07:27:19] Apache config is here: https://git.wikimedia.org/blob/operations%2Fpuppet/8cf6cd3dca1e9cb45bea2c7be26c2ec91cbc2279/templates%2Fapache%2Fsites%2Fwikitech.wikimedia.org.erb [07:29:28] andrewbogott: apache is listening on ipv6, i see. is it ? [07:29:37] port 8140 [07:30:06] looks like [07:30:21] did you config that? [07:30:47] and what do you get when you try to telnet/netcat to there? [07:31:07] I didn't hand configure anything about this box. It ought to be puppetized as a web server. [07:31:18] If I telnet to 8140? Just a hang. [07:31:48] 8140? that is puppet [07:31:56] that is what i thought [07:32:02] wait, what? [07:32:06] well more like apache passenger configured to serve puppet [07:32:17] Ah, yes, this is a puppet master as well. [07:32:20] morning btw [07:32:21] :-) [07:32:25] 'morning! [07:32:34] yeah, hi akosiaris :) [07:32:53] intersting thing here andrew [07:32:56] akosiaris: my dumb question of the morning is "Why doesn't virt1000 serve https?" [07:33:45] matanya: yes? [07:34:07] andrewbogott: it is [07:34:18] on port 8140 [07:34:18] true. [07:34:20] you want it on 443 ? [07:34:23] you say apache is running, but doesn't open any connection on port 80/443 [07:34:26] and some other virtual host ? [07:34:28] Yes, it should be a wikitech mirror. [07:34:32] then ports.conf :-) [07:34:43] heh... that is going to be difficult [07:34:58] difficult why? [07:35:14] I mean, not a live mirror. Just another box running the same puppet config. [07:35:15] cause ports.conf seems to be managed by puppetmaster class on this machine [07:35:29] Oh. Well… it works on virt0, lemme see what's happening there. [07:35:37] well you are not confined to ports.conf now that I think about it [07:35:46] the directives can be included in any file [07:35:51] yeah, virt0 is the same, just 8140 [07:36:00] but you are not going to make any friends that way [07:36:14] wait.. isn't wikitech on virt0 ? [07:36:23] yes [07:36:39] So, virt1000 is in eqiad, it will be the wikitech host when we turn off pmtpa [07:37:02] It was, until somewhat recently, running a verison of wikitech. I don't know why it's stopped working. [07:37:10] conf.d/ports-wikitech.conf [07:37:13] on virt0 [07:37:16] that would explain it [07:37:33] which I suppose is not puppetized... [07:37:41] i think you suppose correctly [07:37:50] * andrewbogott sighs [07:38:05] heh... try logging into mchenry :P [07:38:17] I did that on Friday [07:38:20] never again! [07:38:24] akosiaris: any list of not puppertized stuff? [07:38:32] matanya: I 'd wish [07:38:59] anyway, email is a huge project of paravoid. If he wants help he 'll let us know [07:39:33] akosiaris: that was totally it, on virt1000. Thank you! [07:39:38] * andrewbogott puppetizes quick before he forgets [07:39:40] RECOVERY - HTTP on virt1000 is OK: HTTP OK: HTTP/1.1 302 Found - 457 bytes in 0.011 second response time [07:39:42] as well as admins.pp [07:39:45] woo! [07:39:58] andrewbogott: thank you too for puppetizing that :-) [07:41:21] it is much easier to dubug with shell access :) [07:46:07] matanya: yeah, true. [07:46:08] (03PS1) 10Andrew Bogott: puppetize ports-wikitech.conf on wikitech hosts. [operations/puppet] - 10https://gerrit.wikimedia.org/r/112421 [07:46:19] In my case not easy enough though. [07:46:22] akosiaris, ^ [07:46:45] oops, doublequotes! [07:47:17] and no single quotes [07:47:20] andrewbogott: require package php5 ? [07:47:44] akosiaris: copying the pattern from above, for sites-available. [07:47:57] I guess I'm trusting that whoever wrote that knew what they were doing... [07:48:00] this file needs love [07:48:20] Then please require that file [07:48:22] please!!! [07:48:36] hm? require which file? [07:48:47] the sites-available [07:48:55] matanya: it does, but it's also subject to rapid development so not a great candidate for linting this week. [07:49:00] it is making semantically sense [07:49:17] you need the site for those ports to actually serve something [07:49:23] hm, true. [07:49:29] and it is better than php5 [07:49:41] andrewbogott: not lint, modulrize [07:49:53] yes, needs both! [07:49:58] true [07:50:27] yeah, however finishing up with whatever development first might be prudent [07:50:29] (03PS2) 10Andrew Bogott: puppetize ports-wikitech.conf on wikitech hosts. [operations/puppet] - 10https://gerrit.wikimedia.org/r/112421 [07:50:30] matanya: better quotemarks now? [07:50:54] yes, better fix now, than million fixes later [07:50:56] andrewbogott: debug OSM ? [07:51:09] OSM = "OpenStackManager" in this case. [07:51:12] aaaah [07:51:19] not open street map [07:51:28] thanks. I was flumoxed for a moment [07:51:33] Bah, we were here first, should have dibs on the acronym! [07:51:41] But, I'm going to have to start spelling it out I guess. [07:52:10] ahahaha [07:52:15] (03CR) 10Ori.livneh: [C: 032] logstash: Add normalized_message field to all events [operations/puppet] - 10https://gerrit.wikimedia.org/r/112149 (owner: 10BryanDavis) [07:52:22] akosiaris: i will need your help in fixing your -1's on my patches [07:52:35] Anyway… what with that patch going on a production box, can I get a +2? [07:53:36] matanya: aahh i was thinking yesterday about the ganglia/nagios one. I am thinking the best way forward would be to first ask if anyone uses that notes_url thing and kill it if no-one does. I sure have not in all these months [07:53:41] andrewbogott: why is that an erb file, anyway? [07:54:05] ori: Because there's not a good organizational place for it otherwise. [07:54:10] akosiaris: unfortunately I don't have that much time today. I need to finish up on some openstreetmap stuff [07:54:14] files andrewbogott [07:54:20] Felt better sticking it next to its cohorts than making a new diretctory with just that one file in it. [07:54:30] andrewbogott: that's silly; just make a directory [07:54:38] matanya: that is..^ [07:54:41] * andrewbogott scowls [07:54:46] i wonder why i am speaking to myself... [07:55:11] yeah, ok akosiaris thanks. one day we might find time for stuff :) [07:55:42] andrewbogott: this point is actully valid, erb takes more time to compile etc [07:55:56] (03CR) 10Alexandros Kosiaris: [C: 032] puppetize ports-wikitech.conf on wikitech hosts. [operations/puppet] - 10https://gerrit.wikimedia.org/r/112421 (owner: 10Andrew Bogott) [07:55:56] :) [07:56:25] oh... i am not on RT duty anymore :-) [07:57:35] no you are not [07:58:09] if ori had not changed the subject I would have completely forgotten it until someone asked me [07:59:12] andrewbogott: you know, [07:59:27] you could also just do content => "Listen 80\nListen 443" [07:59:48] please avoid that pattern [08:00:15] but not erb files that contain no erb? [08:00:30] not that it does not work, but there are already two ways to populate files, let's not add a third one [08:01:07] ori: you are right there but that thing needs love anyway and I am pretty sure that one andrewbogott is done, matanya is going to really really show his appreciation for it. [08:01:08] four! inline_template('<%= @ports.map("Listen #{port}").join("\n") %>') [08:01:30] and we haven't even gotten to custom puppet ruby functions! :P [08:01:31] So it doesn't really cause harm right now [08:01:39] ori: true true :-) [08:01:50] ori: what are your feelings on stevedore and cliffy? [08:02:14] are those pokemon? [08:02:18] :D [08:02:20] i don't know either [08:02:21] python libraries [08:02:25] * ori googles [08:02:41] also that map thing was wrong above, but nevermind [08:02:43] stevedore is meant to be a consistent approach to the driver/hook/extension model [08:03:17] (03PS1) 10Andrew Bogott: Move ports-wikitech.conf out of templates and into files. [operations/puppet] - 10https://gerrit.wikimedia.org/r/112422 [08:03:19] oh, that's not bad, i could've used that [08:03:26] * ori thanks andrewbogott [08:03:29] cliffy is meant to be a sane way to handle cli actions, subactions, sub sub actions, etc. with drivers and extensions and such [08:03:45] would've been a lot easier if I hadn't tried to amend an already-merged patch :( [08:03:48] twisted provides both, but it only makes sense to use it if you're writing a twisted network daemon [08:03:59] yep [08:04:38] akosiaris: i count 4 already, source (as puppet file server) content (as templates) content (as "some text") and inline functions [08:04:47] I'm considering them for trigger [08:04:57] so that I don't use a custom driver/extension/hook model [08:05:05] i went with https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/master/server/eventlogging/handlers.py#L39 [08:05:09] matanya: yeah ori mentioned the fourth one as well. [08:05:20] yep [08:05:30] oh, skipped that [08:05:34] but it looks like stevedore goes a lot farther [08:05:38] I'm doing something relatively similar [08:05:39] dunno, looks neat at a glance [08:06:00] the names suck btw [08:06:09] I like that it's somewhat standard [08:06:20] they remind me of the two old guys at the puppets [08:06:21] it would make adapting other people's code easier, when necessary [08:06:26] akosiaris: haha [08:06:39] and makes it easier for people to understand a codebase [08:06:49] akosiaris: :D [08:06:52] akosiaris: that's tim and domas usually [08:06:58] hahahaha [08:07:02] hahahahahahaha [08:07:35] well, I'll investigate them for trigger to see if it's worthwhile [08:07:54] I'm not a huge fan of how I'm handling action loading (and I know you aren't either ;) ) [08:09:09] let me know if they're good libs, i'd be interested [08:09:13] * Ryan_Lane nods [08:09:14] will do [08:22:20] PROBLEM - MySQL InnoDB on db1016 is CRITICAL: CHECK_NRPE: Socket timeout after 10 seconds. [08:23:10] RECOVERY - MySQL InnoDB on db1016 is OK: OK longest blocking idle transaction sleeps for 0 seconds [08:28:12] good morning [08:29:21] (03PS1) 10Matanya: webserver: fixing duplicate declaration of apache-mpm [operations/puppet] - 10https://gerrit.wikimedia.org/r/112423 [08:29:32] akosiaris: this one is for you ^ [08:29:36] hi hashar [08:33:51] (03PS2) 10Matanya: webserver: fixing duplicate declaration of apache-mpm [operations/puppet] - 10https://gerrit.wikimedia.org/r/112423 [08:51:34] (03PS1) 10ArielGlenn: module for releases webserver (mobile and mw tarballs) [operations/puppet] - 10https://gerrit.wikimedia.org/r/112424 [08:57:01] (03CR) 10Matanya: [C: 04-1] "I don't like the layout if this module. I think it would be better if you move the system role and the monitoring into a role inside manif" [operations/puppet] - 10https://gerrit.wikimedia.org/r/112424 (owner: 10ArielGlenn) [08:58:17] * yuvipanda pokes hashar with https://gerrit.wikimedia.org/r/#/c/111765/ :) [09:02:09] matanya: what do you want to see parameterized in the webserver class? [09:02:37] apergos: docroot, server_admin [09:02:42] ok thanks [09:02:43] the site name [09:02:44] yuvipanda: follow up with maxsem :-] [09:02:56] yuvipanda: anyone can review / +2 that change to get it deployed on beta. [09:02:57] ? [09:03:00] hashar: you are okay with him +2ing when he's around? [09:03:01] ok [09:03:02] MaxSem: https://gerrit.wikimedia.org/r/#/c/111765/ [09:03:18] MaxSem: that repo has a lot more merges now :) [09:04:25] * MaxSem reads code [09:04:43] yuvipanda: yes :-] [09:04:47] WTF http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/7cadfed0be8e0311b645eac63b0ff370a7e9e4ea/Popups.hooks.php [09:04:49] hashar: ok :) [09:05:11] MaxSem: ? [09:05:17] yuvipanda: I am merely responsible for maintaining the beta infrastructure which is really a service to the developers to stage code before it lands in production. [09:05:19] you're mixing WMF conf stuff with extension conf [09:05:19] there's a patch adding a betafeatures check to that there. [09:05:31] MaxSem: what do you mean? [09:05:37] $wgEnablePopups is unnecessary, misleading, evil [09:05:45] MaxSem: what. that's just a feature flag [09:06:07] it's not [09:06:11] explain [09:06:13] how it is not? [09:06:24] if that is set to false, then absolutely nothing happens. [09:06:32] feature flag allows to disable a part of extension's functionality [09:07:11] WMF config enables/disables extensions explicitly [09:07:43] MaxSem: how does that have anything to do with enabling or disabling it on betalabs? [09:09:00] (03CR) 10Matanya: "proposed fix in https://gerrit.wikimedia.org/r/#/c/112423/" [operations/puppet] - 10https://gerrit.wikimedia.org/r/107567 (owner: 10Matanya) [09:11:06] MaxSem: ? [09:11:08] this extension's present state is a good indication that it wasn't reviewed by anyone who should've reviewed it [09:11:18] meh [09:11:31] do apply to revoke all the reviewers' +2s [09:13:57] MaxSem: do you have a list of people who you considered 'people who should have reviewed it', since apparently that is different from the general +2 list? [09:14:11] Chris Steipp? [09:14:50] for *betalabs*? [09:14:53] meh. fine. [09:14:57] * yuvipanda goes to jump through another hoop [09:20:54] yuvipanda, https://gerrit.wikimedia.org/r/112430 [09:21:32] MaxSem: looking [09:23:07] MaxSem: merged. [09:24:33] (03CR) 10MaxSem: [C: 032] Deploy Extension:Popups on betalabs [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/111765 (owner: 10Yuvipanda) [09:24:42] (03Merged) 10jenkins-bot: Deploy Extension:Popups on betalabs [operations/mediawiki-config] - 10https://gerrit.wikimedia.org/r/111765 (owner: 10Yuvipanda) [09:24:47] MaxSem: :) thanks! [09:25:34] MaxSem: I've poked the people who are responsible for this extension (Design team), they should poke chris earlier today or somesuch. [09:25:46] should definitely go through one before getting deployed deployed, I guess [09:26:48] how much code growth will there be before it's ready for WMF? [09:28:00] MaxSem: I think there are 3 patches under review, and that's about it. [09:28:08] hmm [09:28:16] MaxSem: hmm, 4 actually. 3 CSS changes and a betafeatures hook [09:28:32] eek, so no more JS? [09:28:58] MaxSem: might be applying a class here or there [09:29:26] my main fear was not current JS but that it's in active development and after we deploy something small and safe it will quickly turn into a behemoth [09:30:04] MaxSem: that's true for everything, no? At least this is much better than the current gadget used [09:30:09] (much smaller too, but eh) [09:30:12] heh [09:30:52] MaxSem: I would've liked it to be in VectorBeta, but then people pointed out how this works across skins... [09:36:08] (03PS2) 10Hashar: Tools: Install package supybot [operations/puppet] - 10https://gerrit.wikimedia.org/r/112202 (owner: 10Tim Landscheidt) [09:36:12] (03PS3) 10Tim Landscheidt: Tools: Install package supybot [operations/puppet] - 10https://gerrit.wikimedia.org/r/112202 [09:36:17] (03CR) 10Hashar: [C: 031] Tools: Install package supybot [operations/puppet] - 10https://gerrit.wikimedia.org/r/112202 (owner: 10Tim Landscheidt) [09:46:31] morning [09:48:35] hi paravoid [09:48:47] (03PS2) 10ArielGlenn: module for releases webserver (mobile and mw tarballs) [operations/puppet] - 10https://gerrit.wikimedia.org/r/112424 [09:54:19] (03CR) 10Matanya: [C: 031] module for releases webserver (mobile and mw tarballs) [operations/puppet] - 10https://gerrit.wikimedia.org/r/112424 (owner: 10ArielGlenn) [10:01:32] (03CR) 10Faidon Liambotis: [C: 04-1] "Please don't do access controls inside the module. It's hard to fix admins.pp enough as it is, having to fix it across the board is going " [operations/puppet] - 10https://gerrit.wikimedia.org/r/112424 (owner: 10ArielGlenn) [10:03:26] paravoid: where would you want me to move them, to the role::releases class? and do you mean the groups as well as the accounts? [10:05:55] good point paravoid i think you should just call accounts from the current admins.pp [10:08:05] apergos: yeah, I guess role class or site.pp [10:08:08] apergos: https://gerrit.wikimedia.org/r/#/c/107848/ btw [10:10:28] paravoid: you should get a raise when this is mreged [10:10:37] *merged [10:10:40] lol [10:16:51] (03CR) 10Faidon Liambotis: [C: 04-1] Torrus: add turros to netmon1001 (036 comments) [operations/puppet] - 10https://gerrit.wikimedia.org/r/108314 (owner: 10Matanya) [10:25:00] .names [10:25:06] ha! [10:27:33] (03CR) 10Matanya: Torrus: add turros to netmon1001 (031 comment) [operations/puppet] - 10https://gerrit.wikimedia.org/r/108314 (owner: 10Matanya) [10:28:19] (03PS5) 10Matanya: Torrus: add torrus to netmon1001 [operations/puppet] - 10https://gerrit.wikimedia.org/r/108314 [10:31:51] (03CR) 10Hashar: "Thank you!" (031 comment) [operations/puppet] - 10https://gerrit.wikimedia.org/r/111917 (owner: 10BryanDavis) [10:31:58] paravoid: are you looking for a review on the admins module, are it is not ready yet for that? [10:32:39] (03PS3) 10ArielGlenn: module for releases webserver (mobile and mw tarballs) [operations/puppet] - 10https://gerrit.wikimedia.org/r/112424 [10:32:40] (hint, i think you should use other approach ) [10:34:14] I'm looking for a review of the concept, so far [10:34:17] ideas are welcome [10:34:35] apergos: there's an icinga alarm for snapshot1003's disk space [10:37:01] ok, I'll have a look, thanks [10:41:03] (03PS3) 10Hashar: retab realm.pp [operations/puppet] - 10https://gerrit.wikimedia.org/r/104808 [10:41:10] (03PS3) 10Hashar: realm.pp puppet lint fixes [operations/puppet] - 10https://gerrit.wikimedia.org/r/104809 [10:41:24] (03CR) 10Matanya: "I think a better way to handle the keys would be to use puppetdb with puppet query, (https://forge.puppetlabs.com/dalen/puppetdbquery). I " [operations/puppet] - 10https://gerrit.wikimedia.org/r/107848 (owner: 10Faidon Liambotis) [10:44:38] no, puppetdb is not suitable for this purpose, I have security concerns [10:44:54] ok [10:45:00] keys should be in git, code-reviewable and authenticated [10:45:26] puppetdb, anyone can run a query [10:47:02] could I get three changes in for contint please ? https://gerrit.wikimedia.org/r/#/q/status:open+topic:contint,n,z :D [10:52:37] (03Abandoned) 10Matanya: realm: lint clean [operations/puppet] - 10https://gerrit.wikimedia.org/r/109074 (owner: 10Matanya) [11:03:40] (03PS3) 10Hashar: contint: browsers for testing + xvfb for headless [operations/puppet] - 10https://gerrit.wikimedia.org/r/111209 [11:06:16] (03CR) 10ArielGlenn: [C: 032] contint: browsers for testing + xvfb for headless [operations/puppet] - 10https://gerrit.wikimedia.org/r/111209 (owner: 10Hashar) [11:06:59] (03PS3) 10Hashar: contint: slave-scripts are deployed via git-deploy [operations/puppet] - 10https://gerrit.wikimedia.org/r/111446 [11:08:33] (03CR) 10Phuedx: [C: 031] add shell account for phuedx and add to mortals [operations/puppet] - 10https://gerrit.wikimedia.org/r/112150 (owner: 10Dzahn) [11:08:48] (03CR) 10ArielGlenn: [C: 032] contint: slave-scripts are deployed via git-deploy [operations/puppet] - 10https://gerrit.wikimedia.org/r/111446 (owner: 10Hashar) [11:09:28] (03PS3) 10Hashar: contint: fix slave-scripts deployment on labs [operations/puppet] - 10https://gerrit.wikimedia.org/r/111447 [11:09:37]