[01:03:34] (03PS3) 10Anne Tomasevich: Add local dev flag for MediaSearch [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/635377 [01:24:54] (03CR) 10jerkins-bot: [V: 04-1] Add local dev flag for MediaSearch [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/635377 (owner: 10Anne Tomasevich) [07:32:05] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/637270 (owner: 10L10n-bot) [07:34:11] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/637270 (owner: 10L10n-bot) [14:36:57] (03CR) 10DannyS712: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 32.0.0 [extensions/FileAnnotations] - 10https://gerrit.wikimedia.org/r/637459 (owner: 10Libraryupgrader) [17:48:16] (03CR) 10Eric Gardner: [C: 03+1] "Looks good and works as expected. Just one question about the use of "component v-bind:is"." (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) (owner: 10Anne Tomasevich) [17:51:05] (03CR) 10Eric Gardner: [C: 03+2] Account for indicator in search input padding [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/633235 (https://phabricator.wikimedia.org/T259390) (owner: 10Anne Tomasevich) [18:05:23] (03CR) 10Eric Gardner: [C: 03+2] Improve QuickView image loading experience [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/635894 (https://phabricator.wikimedia.org/T265696) (owner: 10Anne Tomasevich) [18:26:05] (03CR) 10jerkins-bot: [V: 04-1] Account for indicator in search input padding [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/633235 (https://phabricator.wikimedia.org/T259390) (owner: 10Anne Tomasevich) [18:26:56] (03CR) 10Eric Gardner: [C: 03+2] "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/633235 (https://phabricator.wikimedia.org/T259390) (owner: 10Anne Tomasevich) [18:31:17] (03Merged) 10jenkins-bot: Improve QuickView image loading experience [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/635894 (https://phabricator.wikimedia.org/T265696) (owner: 10Anne Tomasevich) [18:39:33] (03CR) 10Anne Tomasevich: "Nice to see the polyfills; I confirmed that this works in IE11 (after a rebase onto master). I left some comments inline, and have a coupl" (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/635644 (https://phabricator.wikimedia.org/T266150) (owner: 10Eric Gardner) [18:52:55] (03Merged) 10jenkins-bot: Account for indicator in search input padding [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/633235 (https://phabricator.wikimedia.org/T259390) (owner: 10Anne Tomasevich) [19:07:09] (03PS9) 10Anne Tomasevich: Add copyable filename to QuickView and CopyTextLayout component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) [19:07:40] (03CR) 10Anne Tomasevich: Add copyable filename to QuickView and CopyTextLayout component (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) (owner: 10Anne Tomasevich) [19:13:00] (03CR) 10Eric Gardner: [C: 03+2] Add copyable filename to QuickView and CopyTextLayout component (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) (owner: 10Anne Tomasevich) [19:24:27] (03CR) 10Eric Gardner: "> 1. If the filter value in the URL is invalid (e.g. imageSize=small), the select list in the JS will be missing a label. We should reset " (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/635644 (https://phabricator.wikimedia.org/T266150) (owner: 10Eric Gardner) [19:30:45] (03CR) 10jerkins-bot: [V: 04-1] Add copyable filename to QuickView and CopyTextLayout component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) (owner: 10Anne Tomasevich) [19:31:30] (03CR) 10Eric Gardner: [C: 03+2] "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) (owner: 10Anne Tomasevich) [19:42:11] (03Merged) 10jenkins-bot: Add copyable filename to QuickView and CopyTextLayout component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) (owner: 10Anne Tomasevich) [19:43:34] (03CR) 10Anne Tomasevich: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/630957 (https://phabricator.wikimedia.org/T261699) (owner: 10Anne Tomasevich) [19:49:59] (03CR) 10Anne Tomasevich: "> Is there anything else besides sorting that needs to be handled as a separate param in the search request, as opposed to being passed in" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/635644 (https://phabricator.wikimedia.org/T266150) (owner: 10Eric Gardner)