[02:04:31] (03PS1) 10Anne Tomasevich: Add horizontal scrolling to tabs on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627638 (https://phabricator.wikimedia.org/T258615) [02:07:19] (03PS2) 10Anne Tomasevich: Add horizontal scrolling to tabs on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627638 (https://phabricator.wikimedia.org/T258615) [02:14:46] (03CR) 10Anne Tomasevich: "This is now ready for review" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627398 (https://phabricator.wikimedia.org/T257699) (owner: 10Anne Tomasevich) [02:28:11] (03CR) 10jerkins-bot: [V: 04-1] Add horizontal scrolling to tabs on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627638 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [10:07:42] (03PS2) 10Jforrester: tests: Actually run this repo's selenium tests in CI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/607271 (https://phabricator.wikimedia.org/T256111) [10:26:04] (03CR) 10jerkins-bot: [V: 04-1] tests: Actually run this repo's selenium tests in CI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/607271 (https://phabricator.wikimedia.org/T256111) (owner: 10Jforrester) [10:53:39] (03CR) 10Cparle: [C: 03+2] Turn fulltext signals back into bool query instead of dis_max [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/626357 (https://phabricator.wikimedia.org/T262522) (owner: 10Matthias Mullie) [10:54:52] (03CR) 10Cparle: [C: 03+2] Don't phrase rescore media search queries [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/626358 (https://phabricator.wikimedia.org/T262522) (owner: 10Matthias Mullie) [11:08:07] (03CR) 10Esanders: [C: 03+2] build: Install eslint and stylelint; drop jsonlint [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/626798 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [11:17:54] (03Merged) 10jenkins-bot: Turn fulltext signals back into bool query instead of dis_max [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/626357 (https://phabricator.wikimedia.org/T262522) (owner: 10Matthias Mullie) [11:17:56] (03Merged) 10jenkins-bot: Don't phrase rescore media search queries [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/626358 (https://phabricator.wikimedia.org/T262522) (owner: 10Matthias Mullie) [11:17:59] (03Merged) 10jenkins-bot: build: Install eslint and stylelint; drop jsonlint [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/626798 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [13:28:52] (03PS3) 10Anne Tomasevich: Add horizontal scrolling to tabs on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627638 (https://phabricator.wikimedia.org/T258615) [13:35:57] (03CR) 10Matthias Mullie: "> Patch Set 3:" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/621518 (https://phabricator.wikimedia.org/T262522) (owner: 10Matthias Mullie) [13:46:08] (03CR) 10jerkins-bot: [V: 04-1] Add horizontal scrolling to tabs on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627638 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [14:11:41] (03CR) 10Anne Tomasevich: [C: 03+2] "Nice, this looks way better now. Glad it was such a simple fix, too. It delays QuickView content for me a bit locally, but it seems like a" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627598 (https://phabricator.wikimedia.org/T259847) (owner: 10Eric Gardner) [14:23:55] (03CR) 10Anne Tomasevich: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627638 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [14:30:40] (03Merged) 10jenkins-bot: Use a higher-resolution thumbnail for Quickview [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627598 (https://phabricator.wikimedia.org/T259847) (owner: 10Eric Gardner) [15:02:08] (03PS5) 10Anne Tomasevich: Add dialog base component and use for QuickView on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622918 (https://phabricator.wikimedia.org/T258615) [15:55:08] (03CR) 10Eric Gardner: "> Patch Set 1: Code-Review+2" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627598 (https://phabricator.wikimedia.org/T259847) (owner: 10Eric Gardner) [17:01:34] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] "No objections in a month, self-merging since it’s a tangible improvement with low risk IMO." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/620367 (owner: 10Lucas Werkmeister (WMDE)) [17:22:23] (03CR) 10Eric Gardner: "Nice work! Looks and works well, and the code for the new Dialog component is really straightforward." (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622918 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [17:23:06] (03Merged) 10jenkins-bot: Optimize MediaWiki clone in `npm install` [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/620367 (owner: 10Lucas Werkmeister (WMDE)) [18:26:56] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MW-1.34-notes, and 2 others: PHP error "non well formed numeric value encountered" from FormatMetadata->formatCoords - https://phabricator.wikimedia.org/T226751 (10Krinkle) 05Resolved→03Open [18:37:33] (03PS6) 10Anne Tomasevich: Add dialog base component and use for QuickView on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622918 (https://phabricator.wikimedia.org/T258615) [18:39:01] (03CR) 10Anne Tomasevich: Add dialog base component and use for QuickView on mobile (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622918 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [19:40:22] 10Multimedia, 10Commons, 10MediaWiki-File-management: Image history is confusing - https://phabricator.wikimedia.org/T5498 (10Krinkle) [19:58:53] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MW-1.34-notes, and 2 others: PHP error "non well formed numeric value encountered" from FormatMetadata->formatCoords - https://phabricator.wikimedia.org/T226751 (10Umherirrender) This was reopened without further information. Does this happen on the s... [20:17:06] (03CR) 10Eric Gardner: [C: 03+2] "Nice use of the Observer component, that thing is turning out to be pretty handy!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627638 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [20:18:04] (03CR) 10Eric Gardner: [C: 03+2] "Both this and the follow-up one for the tabs are good to go in my opinion" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627398 (https://phabricator.wikimedia.org/T257699) (owner: 10Anne Tomasevich) [20:39:58] (03Merged) 10jenkins-bot: Add "Other" tab [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627398 (https://phabricator.wikimedia.org/T257699) (owner: 10Anne Tomasevich) [20:40:00] (03Merged) 10jenkins-bot: Add horizontal scrolling to tabs on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627638 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [20:43:32] (03PS7) 10Eric Gardner: Add dialog base component and use for QuickView on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622918 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [21:06:55] (03CR) 10Eric Gardner: [C: 03+2] Add dialog base component and use for QuickView on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622918 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [21:28:10] (03Merged) 10jenkins-bot: Add dialog base component and use for QuickView on mobile [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/622918 (https://phabricator.wikimedia.org/T258615) (owner: 10Anne Tomasevich) [22:25:42] (03PS1) 10Eric Gardner: Programmatically generate responsive images for QuickView [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627929 (https://phabricator.wikimedia.org/T259847) [22:38:36] (03CR) 10Eric Gardner: "Now that we have the possibility of a Quickview component that can become arbitrarily wide (when the mobile skin is in use), it makes sens" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627929 (https://phabricator.wikimedia.org/T259847) (owner: 10Eric Gardner) [22:52:14] (03CR) 10Eric Gardner: "An alternate approach that could arguably be better-looking would be to use mw.util.parseImageUrl to generate a single image of the same w" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627929 (https://phabricator.wikimedia.org/T259847) (owner: 10Eric Gardner) [23:50:45] (03PS1) 10Anne Tomasevich: Add horizontal scrolling for filters on small screens [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/627936 (https://phabricator.wikimedia.org/T258615)