[09:26:03] (03PS2) 10Matthias Mullie: Also fetch autocomplete suggestions for last word [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598494 (https://phabricator.wikimedia.org/T253506) [09:44:18] (03CR) 10jerkins-bot: [V: 04-1] Also fetch autocomplete suggestions for last word [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598494 (https://phabricator.wikimedia.org/T253506) (owner: 10Matthias Mullie) [14:18:57] (03PS1) 10Matthias Mullie: Use jQuery element instead of node [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598747 (https://phabricator.wikimedia.org/T249556) [14:23:08] (03PS3) 10Matthias Mullie: Also fetch autocomplete suggestions for last word [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598494 (https://phabricator.wikimedia.org/T253506) [14:23:22] (03PS2) 10Matthias Mullie: Only suggest terms up to the word being typed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598495 (https://phabricator.wikimedia.org/T253503) [14:42:59] (03CR) 10jerkins-bot: [V: 04-1] Only suggest terms up to the word being typed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598495 (https://phabricator.wikimedia.org/T253503) (owner: 10Matthias Mullie) [14:46:09] (03PS3) 10Matthias Mullie: Only suggest terms up to the word being typed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598495 (https://phabricator.wikimedia.org/T253503) [15:03:49] (03CR) 10jerkins-bot: [V: 04-1] Only suggest terms up to the word being typed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598495 (https://phabricator.wikimedia.org/T253503) (owner: 10Matthias Mullie) [16:12:08] (03PS4) 10Matthias Mullie: Only suggest terms up to the word being typed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598495 (https://phabricator.wikimedia.org/T253503) [16:44:23] (03PS1) 10Reedy: Fix class/function case mismatch [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598796 (https://phabricator.wikimedia.org/T253628) [16:48:42] (03PS1) 10Reedy: Fix class/function case mismatch [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/598798 (https://phabricator.wikimedia.org/T253628) [16:54:48] (03CR) 10Jforrester: [C: 03+2] Fix class/function case mismatch [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/598798 (https://phabricator.wikimedia.org/T253628) (owner: 10Reedy) [16:55:00] (03CR) 10Jforrester: [C: 03+2] Fix class/function case mismatch [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598796 (https://phabricator.wikimedia.org/T253628) (owner: 10Reedy) [16:58:22] (03Merged) 10jenkins-bot: Fix class/function case mismatch [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/598798 (https://phabricator.wikimedia.org/T253628) (owner: 10Reedy) [17:15:59] (03Merged) 10jenkins-bot: Fix class/function case mismatch [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/598796 (https://phabricator.wikimedia.org/T253628) (owner: 10Reedy) [22:19:52] (03PS1) 10Kaldari: Adding clarification about structured metadata license [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/598867 (https://phabricator.wikimedia.org/T235799) [22:30:14] (03PS1) 10DannyS712: Replace use of `NewRevisionFromEditComplete` hook [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598872 (https://phabricator.wikimedia.org/T250338) [22:31:09] (03PS2) 10DannyS712: Replace use of `NewRevisionFromEditComplete` hook [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598872 (https://phabricator.wikimedia.org/T250338) [22:40:22] (03CR) 10DannyS712: [C: 04-2] "Cannot merge until after flagged revs, see T250338#6167385" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598872 (https://phabricator.wikimedia.org/T250338) (owner: 10DannyS712) [22:55:40] (03PS1) 10Reedy: Move MediaHandlers to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598878 [22:55:42] (03PS1) 10Reedy: Move Hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598879 [22:55:45] (03PS1) 10Reedy: Move JobClasses to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598880 [22:55:48] (03PS1) 10Reedy: Stop conditionally registering hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598881 [22:58:20] (03CR) 10DannyS712: Move Hooks to extension.json (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598879 (owner: 10Reedy) [23:00:08] (03PS2) 10Reedy: Move Hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598879 [23:00:15] (03PS2) 10Reedy: Move JobClasses to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598880 [23:00:19] (03PS2) 10Reedy: Stop conditionally registering hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598881 [23:03:56] (03PS3) 10Reedy: Stop conditionally registering hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598881 [23:04:04] (03CR) 10Jforrester: [C: 03+2] Move MediaHandlers to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598878 (owner: 10Reedy) [23:04:20] (03CR) 10Jforrester: [C: 03+2] Move Hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598879 (owner: 10Reedy) [23:04:36] (03CR) 10Jforrester: [C: 03+2] Move JobClasses to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598880 (owner: 10Reedy) [23:05:07] (03PS4) 10Jforrester: Stop conditionally registering TimedText-related hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598881 (owner: 10Reedy) [23:05:45] (03CR) 10Jforrester: [C: 03+2] Stop conditionally registering TimedText-related hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598881 (owner: 10Reedy) [23:06:19] (03CR) 10Jforrester: [C: 03+2] Fix greys in BetaFeatures icons [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/597831 (owner: 10Esanders) [23:06:38] (03CR) 10Jforrester: [C: 03+2] Clarify MinimumVideoPlayerSize setting is mwembed-specific [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/588449 (https://phabricator.wikimedia.org/T241107) (owner: 10Brion VIBBER) [23:06:55] (03CR) 10Jforrester: [C: 03+2] Parse messages in string context [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598249 (owner: 10Umherirrender) [23:10:26] Reedy: Thank for working on the registration cruft. I was thinking of doing it post-videojs, but now works too. :-) [23:10:45] I saw it and was like nooooooooo [23:11:06] the rest of it in there probably is a bit harder to remove [23:15:47] (03CR) 10jerkins-bot: [V: 04-1] Move JobClasses to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598880 (owner: 10Reedy) [23:19:29] (03CR) 10jerkins-bot: [V: 04-1] Move Hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598879 (owner: 10Reedy) [23:20:10] (03CR) 10jerkins-bot: [V: 04-1] Stop conditionally registering TimedText-related hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598881 (owner: 10Reedy) [23:23:23] (03Merged) 10jenkins-bot: Move MediaHandlers to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598878 (owner: 10Reedy) [23:27:53] (03Merged) 10jenkins-bot: Move Hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598879 (owner: 10Reedy) [23:27:56] (03Merged) 10jenkins-bot: Move JobClasses to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598880 (owner: 10Reedy) [23:27:59] (03Merged) 10jenkins-bot: Fix greys in BetaFeatures icons [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/597831 (owner: 10Esanders) [23:28:02] (03Merged) 10jenkins-bot: Clarify MinimumVideoPlayerSize setting is mwembed-specific [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/588449 (https://phabricator.wikimedia.org/T241107) (owner: 10Brion VIBBER) [23:28:04] Reedy: https://codesearch.wmflabs.org/deployed/?q=wgHooks&i=nope&files=&repos= doesn't entirely make me happy. [23:28:07] (03Merged) 10jenkins-bot: Parse messages in string context [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598249 (owner: 10Umherirrender) [23:29:12] (03CR) 10jerkins-bot: [V: 04-1] Stop conditionally registering TimedText-related hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/598881 (owner: 10Reedy) [23:29:32] James_F: Some scary looking code for sure [23:29:57] The MassMessage hook registration *inside a job* looks epically terrible to me. [23:32:06] What it is doing makes sense [23:32:09] How it's doing it... Does not [23:32:19] Yeah. [23:32:25] I blame lego. [23:32:26] * Reedy eyes legoktm [23:32:29] Hah. Snap [23:32:52] I was carefully *not* pinging him. I need LibUp code review, not side eye, damnit. ;-) [23:34:00] We should just merge and break it [23:34:02] Then he'll appear [23:34:24] Uh-huh. That seems unkind. [23:43:10] Hello [23:44:16] Sometimes I wonder what 2014 me was thinking when I wrote that [23:44:31] Ha.