[01:43:57] (03PS1) 10Matthias Mullie: Separate autocomplete element from entity input widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 [01:44:00] (03PS1) 10Matthias Mullie: Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) [01:46:27] (03CR) 10Matthias Mullie: [C: 04-2] "DO NOT MERGE!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) (owner: 10Matthias Mullie) [02:04:55] (03CR) 10jerkins-bot: [V: 04-1] Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) (owner: 10Matthias Mullie) [02:09:19] (03CR) 10jerkins-bot: [V: 04-1] Separate autocomplete element from entity input widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [02:09:22] (03PS2) 10Matthias Mullie: Separate autocomplete element from entity input widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 [02:10:17] (03PS2) 10Matthias Mullie: Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) [02:30:34] (03CR) 10jerkins-bot: [V: 04-1] Separate autocomplete element from entity input widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [02:30:50] (03CR) 10jerkins-bot: [V: 04-1] Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) (owner: 10Matthias Mullie) [03:40:06] (03PS3) 10Matthias Mullie: Separate autocomplete element from entity input widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 [03:41:02] (03PS3) 10Matthias Mullie: Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) [03:51:23] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [03:54:20] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) (owner: 10Matthias Mullie) [08:29:06] (03Abandoned) 10Addshore: build: Upgrade grunt from 1.0.3 to 1.0.4 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504813 (owner: 10Jforrester) [12:16:40] (03CR) 10Cparle: "Is this ready to merge? Code looks good to me, and it doesn't seem to break anything" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [12:16:51] (03CR) 10Cparle: [C: 03+1] Separate autocomplete element from entity input widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [12:18:48] (03CR) 10Cparle: [C: 03+1] "... also this fixes the issue where if I click into an autocomplete field and then click out of it it gets a red border" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [12:57:10] (03CR) 10Matthias Mullie: "Yes, this one is ready" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [12:57:32] (03CR) 10Cparle: [C: 03+2] Separate autocomplete element from entity input widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [13:22:19] (03Merged) 10jenkins-bot: Separate autocomplete element from entity input widget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566396 (owner: 10Matthias Mullie) [15:22:24] (03PS3) 10Matthias Mullie: Component rerender reconciliation performance refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566130 [15:31:44] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566130 (owner: 10Matthias Mullie) [17:44:24] (03PS4) 10Matthias Mullie: Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) [17:54:10] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) (owner: 10Matthias Mullie) [18:05:55] (03CR) 10jerkins-bot: [V: 04-1] Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) (owner: 10Matthias Mullie) [19:46:29] (03CR) 10Anne Tomasevich: [C: 03+2] "LGTM, this is a nice improvement" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566130 (owner: 10Matthias Mullie) [20:15:19] (03Merged) 10jenkins-bot: Component rerender reconciliation performance refactor [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566130 (owner: 10Matthias Mullie) [20:33:54] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team Workboards (Clinic Duty Team), and 4 others: PHP Warning from /w/thumb.php: "Cannot modify header information - headers already sent" - https://phabricator.wikimedia.org/T225197 (10daniel) 05Open→03Resolved I assume this is reso... [22:52:54] (03PS5) 10Matthias Mullie: Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) [22:52:57] (03PS1) 10Matthias Mullie: Implement setDisabled for all input types [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566615 [22:53:00] (03PS1) 10Matthias Mullie: Use wbmiSupportedDataTypes instead of hardcoded list [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566616 [22:53:03] (03PS1) 10Matthias Mullie: Minor qualifiers refactor for fewer API calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566617 [22:53:41] (03PS6) 10Matthias Mullie: Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) [22:53:55] (03PS2) 10Matthias Mullie: Implement setDisabled for all input types [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566615 [22:54:03] (03PS2) 10Matthias Mullie: Use wbmiSupportedDataTypes instead of hardcoded list [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566616 [22:54:09] (03PS2) 10Matthias Mullie: Minor qualifiers refactor for fewer API calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566617 [23:05:50] (03PS3) 10Matthias Mullie: Minor qualifiers refactor for fewer API calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566617 [23:08:50] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566616 (owner: 10Matthias Mullie) [23:10:35] (03PS7) 10Matthias Mullie: Implement units support for quantity input UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) [23:12:52] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566617 (owner: 10Matthias Mullie) [23:15:59] (03CR) 10jerkins-bot: [V: 04-1] Implement setDisabled for all input types [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566615 (owner: 10Matthias Mullie) [23:16:48] (03PS1) 10Matthias Mullie: Update authors [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566618 [23:16:52] (03CR) 10jerkins-bot: [V: 04-1] Minor qualifiers refactor for fewer API calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566617 (owner: 10Matthias Mullie) [23:17:47] (03CR) 10Matthias Mullie: [C: 03+1] "+1 if you're ok with your name being in here" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566618 (owner: 10Matthias Mullie) [23:18:05] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566397 (https://phabricator.wikimedia.org/T239474) (owner: 10Matthias Mullie) [23:18:36] (03CR) 10jerkins-bot: [V: 04-1] Use wbmiSupportedDataTypes instead of hardcoded list [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566616 (owner: 10Matthias Mullie) [23:20:49] (03CR) 10jerkins-bot: [V: 04-1] Implement setDisabled for all input types [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566615 (owner: 10Matthias Mullie) [23:23:47] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566618 (owner: 10Matthias Mullie) [23:27:12] (03CR) 10jerkins-bot: [V: 04-1] Minor qualifiers refactor for fewer API calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566617 (owner: 10Matthias Mullie) [23:34:17] (03PS4) 10Matthias Mullie: Minor qualifiers refactor for fewer API calls [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566617 [23:38:23] (03PS3) 10Matthias Mullie: Implement setDisabled for all input types [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566615 [23:41:23] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566617 (owner: 10Matthias Mullie) [23:42:42] (03CR) 10Eric Gardner: [C: 03+1] Update authors [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566618 (owner: 10Matthias Mullie) [23:45:34] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/566615 (owner: 10Matthias Mullie)