[00:06:12] (03CR) 10Eric Gardner: "LGTM but would be good to have more documentation on EntityInputWidget to list all the possible config options we care about." (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 (owner: 10Matthias Mullie) [01:53:03] (03CR) 10Eric Gardner: [C: 04-1] Allow users to input coordinates using map UI (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [09:32:35] (03Merged) 10jenkins-bot: Escape labels in HTML output [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558203 (https://phabricator.wikimedia.org/T240773) (owner: 10Matthias Mullie) [09:39:28] (03PS6) 10Matthias Mullie: Consolidate ItemInputWidget and EntityInputWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 [09:44:42] (03CR) 10Matthias Mullie: Consolidate ItemInputWidget and EntityInputWidget (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 (owner: 10Matthias Mullie) [09:58:46] (03CR) 10jerkins-bot: [V: 04-1] Consolidate ItemInputWidget and EntityInputWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 (owner: 10Matthias Mullie) [09:59:49] (03PS7) 10Matthias Mullie: Consolidate ItemInputWidget and EntityInputWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 [10:10:46] 10Multimedia, 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10WorkType-NewFunctionality: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB) - https://phabricator.wikimedia.org/T54687 (10Verdy_p) >>! Dans T54687#574233, @Nikerabbit a écrit : > That may... [10:19:30] (03CR) 10jerkins-bot: [V: 04-1] Consolidate ItemInputWidget and EntityInputWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 (owner: 10Matthias Mullie) [10:25:02] (03PS1) 10Matthias Mullie: Minor JSDoc (-related) cleanup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558449 [10:44:40] (03CR) 10jerkins-bot: [V: 04-1] Minor JSDoc (-related) cleanup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558449 (owner: 10Matthias Mullie) [11:00:04] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] Enable Lua tests [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558130 (owner: 10Matthias Mullie) [11:05:35] (03PS1) 10Matthias Mullie: Fix some easy TODOs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558466 [11:13:36] (03PS1) 10Matthias Mullie: Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 [11:19:49] (03Merged) 10jenkins-bot: Enable Lua tests [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558130 (owner: 10Matthias Mullie) [11:21:29] (03PS8) 10Matthias Mullie: Consolidate ItemInputWidget and EntityInputWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 [11:21:49] (03PS2) 10Matthias Mullie: Minor JSDoc (-related) cleanup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558449 [11:25:52] (03CR) 10jerkins-bot: [V: 04-1] Fix some easy TODOs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558466 (owner: 10Matthias Mullie) [11:26:55] (03PS2) 10Matthias Mullie: Fix some easy TODOs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558466 [11:27:06] (03PS2) 10Matthias Mullie: Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 [11:28:09] (03PS1) 10Matthias Mullie: Register mediainfo-specific EntityIdLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558475 [11:28:18] (03CR) 10Matthias Mullie: [C: 04-1] "WIP" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558475 (owner: 10Matthias Mullie) [11:28:53] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 (owner: 10Matthias Mullie) [11:29:12] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558449 (owner: 10Matthias Mullie) [11:34:26] (03PS1) 10Matthias Mullie: Remove external repo css & assets [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558477 [11:35:40] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558475 (owner: 10Matthias Mullie) [11:40:46] (03CR) 10jerkins-bot: [V: 04-1] Fix some easy TODOs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558466 (owner: 10Matthias Mullie) [11:41:10] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558477 (owner: 10Matthias Mullie) [11:47:47] (03CR) 10jerkins-bot: [V: 04-1] Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 (owner: 10Matthias Mullie) [11:49:25] (03PS3) 10Matthias Mullie: Fix some easy TODOs [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558466 [11:49:43] (03PS3) 10Matthias Mullie: Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 [11:49:56] (03CR) 10jerkins-bot: [V: 04-1] Remove external repo css & assets [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558477 (owner: 10Matthias Mullie) [11:51:50] (03PS2) 10Matthias Mullie: Remove external repo css & assets [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558477 [11:56:50] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558466 (owner: 10Matthias Mullie) [12:00:48] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558477 (owner: 10Matthias Mullie) [12:09:57] (03CR) 10jerkins-bot: [V: 04-1] Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 (owner: 10Matthias Mullie) [12:25:03] (03PS4) 10Matthias Mullie: Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 [12:44:48] (03CR) 10jerkins-bot: [V: 04-1] Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 (owner: 10Matthias Mullie) [15:05:01] (03CR) 10Matthias Mullie: "I looked into fixing the partial map load, but ended up doing a few more changes while I was tracking that down:" (038 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [15:05:12] (03PS11) 10Matthias Mullie: Allow users to input coordinates using map UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [15:08:41] (03PS5) 10Matthias Mullie: Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 [15:18:09] (03CR) 10jerkins-bot: [V: 04-1] Allow users to input coordinates using map UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [15:27:51] (03CR) 10jerkins-bot: [V: 04-1] Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 (owner: 10Matthias Mullie) [15:54:10] (03PS6) 10Matthias Mullie: Remove backward compatibility workarounds that are no longer needed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 [16:00:15] (03CR) 10Matthias Mullie: Allow users to input coordinates using map UI (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [16:01:35] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558469 (owner: 10Matthias Mullie) [16:04:50] (03CR) 10Matthias Mullie: Allow users to input coordinates using map UI (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [16:28:03] (03CR) 10Eric Gardner: Allow users to input coordinates using map UI (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [16:29:35] (03CR) 10Eric Gardner: "I'll do another review pass later today. One thing I realized is that we should probably have a follow-up patch for UploadWizard ready to " [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 (owner: 10Matthias Mullie) [16:39:05] (03CR) 10Jforrester: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [16:41:07] (03PS1) 10Cparle: Fix code smells [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558592 [16:50:26] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558592 (owner: 10Cparle) [16:56:43] (03CR) 10jerkins-bot: [V: 04-1] Fix code smells [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558592 (owner: 10Cparle) [17:02:06] (03CR) 10Matthias Mullie: "> Patch Set 8:" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/554846 (owner: 10Matthias Mullie) [17:11:27] (03PS1) 10Cparle: Fix code smells [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558604 (https://phabricator.wikimedia.org/T240967) [17:13:43] (03PS2) 10Cparle: Fix code smells [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558592 (https://phabricator.wikimedia.org/T240966) [17:18:08] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558604 (https://phabricator.wikimedia.org/T240967) (owner: 10Cparle) [17:20:25] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558592 (https://phabricator.wikimedia.org/T240966) (owner: 10Cparle) [17:27:10] (03CR) 10jerkins-bot: [V: 04-1] Fix code smells [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558604 (https://phabricator.wikimedia.org/T240967) (owner: 10Cparle) [17:29:35] (03CR) 10jerkins-bot: [V: 04-1] Fix code smells [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558592 (https://phabricator.wikimedia.org/T240966) (owner: 10Cparle) [17:38:48] (03CR) 10Jforrester: "Sorry, we're going to have to revert the CI dependency for now (as this breaks Wikibase, see T240971 — note that WB is tested with WBMI an" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [17:47:40] (03CR) 10Matthias Mullie: "> Patch Set 11:" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/556305 (https://phabricator.wikimedia.org/T227116) (owner: 10Eric Gardner) [18:12:03] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Looks good. The CI error is unrelated, as far as I can see." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558604 (https://phabricator.wikimedia.org/T240967) (owner: 10Cparle) [18:31:13] (03Merged) 10jenkins-bot: Fix code smells [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558604 (https://phabricator.wikimedia.org/T240967) (owner: 10Cparle) [18:55:58] (03PS2) 10Anne Tomasevich: Show wbparsevalue errors in the WBMI UI [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558218 (https://phabricator.wikimedia.org/T239857) [19:02:44] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558218 (https://phabricator.wikimedia.org/T239857) (owner: 10Anne Tomasevich) [22:56:18] (03PS1) 10Anne Tomasevich: Show submission errors at the statement panel level [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558717 (https://phabricator.wikimedia.org/T233051) [23:02:55] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558717 (https://phabricator.wikimedia.org/T233051) (owner: 10Anne Tomasevich) [23:05:06] (03Abandoned) 10Anne Tomasevich: Show submission errors at the statement panel level [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/558717 (https://phabricator.wikimedia.org/T233051) (owner: 10Anne Tomasevich)