[06:32:18] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-production-error: PHP error "non well formed numeric value encountered" from FormatMetadata->formatCoords - https://phabricator.wikimedia.org/T226751 (10Marostegui) We have seen something similar, not exactly the same as this reported one, b... [08:27:09] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-production-error: PHP error "non well formed numeric value encountered" from FormatMetadata->formatCoords - https://phabricator.wikimedia.org/T226751 (10Tgr) These are user errors, so FormatMetadata should probably return a StatusValue, but... [09:13:27] (03PS1) 10Thiemo Kreuz (WMDE): Remove problematic count() in MediaInfoPrefetchingTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553041 (https://phabricator.wikimedia.org/T239165) [09:16:34] (03PS1) 10Thiemo Kreuz (WMDE): Replace oldskool @see PHPDoc tags with @inheritDoc [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553044 [11:02:20] (03CR) 10Cparle: [C: 03+2] Remove problematic count() in MediaInfoPrefetchingTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553041 (https://phabricator.wikimedia.org/T239165) (owner: 10Thiemo Kreuz (WMDE)) [11:11:29] (03CR) 10Cparle: [C: 03+2] Replace oldskool @see PHPDoc tags with @inheritDoc [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553044 (owner: 10Thiemo Kreuz (WMDE)) [11:18:49] (03CR) 10Cparle: [C: 03+2] Skip entities already known not to exist [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/549819 (https://phabricator.wikimedia.org/T236948) (owner: 10Matthias Mullie) [11:33:41] (03Merged) 10jenkins-bot: Remove problematic count() in MediaInfoPrefetchingTermLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553041 (https://phabricator.wikimedia.org/T239165) (owner: 10Thiemo Kreuz (WMDE)) [11:42:39] (03Merged) 10jenkins-bot: Replace oldskool @see PHPDoc tags with @inheritDoc [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553044 (owner: 10Thiemo Kreuz (WMDE)) [11:44:46] (03Merged) 10jenkins-bot: Skip entities already known not to exist [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/549819 (https://phabricator.wikimedia.org/T236948) (owner: 10Matthias Mullie) [15:12:27] (03PS1) 10Matthias Mullie: MediaInfo specific Lua modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553128 (https://phabricator.wikimedia.org/T237107) [15:21:30] (03PS3) 10Matthias Mullie: Register mediainfo-specific EntityIdLookup [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/550497 (https://phabricator.wikimedia.org/T236691) [15:22:04] (03CR) 10jerkins-bot: [V: 04-1] MediaInfo specific Lua modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553128 (https://phabricator.wikimedia.org/T237107) (owner: 10Matthias Mullie) [15:26:39] (03PS2) 10Matthias Mullie: MediaInfo specific Lua modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553128 (https://phabricator.wikimedia.org/T237107) [15:38:52] (03CR) 10jerkins-bot: [V: 04-1] MediaInfo specific Lua modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553128 (https://phabricator.wikimedia.org/T237107) (owner: 10Matthias Mullie) [15:42:01] (03PS1) 10Matthias Mullie: Replace map with forEach [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553131 [15:44:37] (03PS1) 10Matthias Mullie: Fix duplicate varname [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/553133 [18:50:07] (03CR) 10Brion VIBBER: Lazy-load, use OOUI dialog in video.js playback mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [19:18:33] brion: Sorry to be difficult… ;-) [19:31:41] (03PS10) 10Brion VIBBER: Lazy-load, use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [19:32:23] James_F: looks like a 0-length setTimeout fixes it, though it irks me to do so, as it fixes the order of some callbacks. lemme test more thoroughly [19:32:29] then can avoid the edge check :D [19:34:23] (03CR) 10Brion VIBBER: Lazy-load, use OOUI dialog in video.js playback mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [19:50:10] (03PS11) 10Brion VIBBER: Lazy-load, use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [19:50:43] brion: If you add `// Support: Edge 12` or whatever above it, it means future devs know why it's there, how to test that it hasn't regressed, and when we can drop it. [19:51:00] (03CR) 10Brion VIBBER: "Now uses lower resolutions for ogv.js (480p for WebAssembly or 240p for JS) which keeps performance cleaner on IE 11 and Safari on slower " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [19:51:18] James_F: ah wise, thanks [19:51:28] Idea stolen from VE's coding practices. [19:53:26] (03PS12) 10Brion VIBBER: Lazy-load, use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [19:54:53] So "just" the IE/Edge scrolling, some i18n, and final testing needed? [19:55:08] * James_F really wants to ship, in case you can't guess. ;-) [19:55:24] yep, the scrolling should be an easy overflow CSS fix and the i18n looks easy [19:55:35] then we can merge it and get more feedback [19:55:46] should be done with this later today i feel :D [19:56:22] Cool. [20:14:07] (03PS13) 10Brion VIBBER: Lazy-load, use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [20:44:03] (03PS14) 10Brion VIBBER: Lazy-load, use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [22:13:13] (03PS15) 10Brion VIBBER: Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [22:15:29] (03PS16) 10Brion VIBBER: Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [22:18:52] (03CR) 10Brion VIBBER: "I've taken this out of WIP mode, I think it's good to go. Please give a shout on any big regressions other than the known one about audio " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [22:19:25] James_F: https://video-testing.wmflabs.org ftw [22:29:40] brion: Testing. Looks good. [22:30:42] woot [22:32:13] (03CR) 10jerkins-bot: [V: 04-1] Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [22:32:30] *twitch* [22:33:47] well those are fixable [22:33:49] :D [22:36:24] (03PS17) 10Brion VIBBER: Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [22:45:04] * James_F grins. [22:53:13] (03CR) 10jerkins-bot: [V: 04-1] Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [22:53:44] (03CR) 10Anne Tomasevich: "Minor style thing: we should probably remove the space between the input and the Add button to match standard components e.g. https://doc." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/551299 (https://phabricator.wikimedia.org/T239154) (owner: 10Eric Gardner) [22:59:48] (03CR) 10Jforrester: Lazy-load JS payload & use OOUI dialog in video.js playback mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [23:12:59] (03PS18) 10Brion VIBBER: Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 [23:13:25] (03CR) 10Brion VIBBER: Lazy-load JS payload & use OOUI dialog in video.js playback mode (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [23:32:42] (03CR) 10jerkins-bot: [V: 04-1] Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [23:33:21] brion: Sorry, stylelint is quite whiny. :-( [23:36:24] (03PS19) 10Jforrester: Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [23:36:39] (03CR) 10Jforrester: [C: 03+2] Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (owner: 10Brion VIBBER) [23:37:39] (03PS20) 10Jforrester: Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [23:37:48] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [23:39:04] (03CR) 10Jforrester: "Replaced by Ic3bc46046, right?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/529819 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [23:39:30] (03CR) 10Jforrester: [C: 03+2] Change default for $wgFFmpegLocation to '/usr/bin/ffmpeg' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550744 (owner: 10Brion VIBBER) [23:44:54] (03CR) 10Brion VIBBER: "Actually I'll revive this with the updated distribution and tack it on after. This'll reduce the actual videojs payload significantly; eve" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/529819 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [23:45:45] (03CR) 10Jforrester: "> Patch Set 2:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/529819 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [23:46:24] wheeeeeeee :D [23:58:55] (03Merged) 10jenkins-bot: Lazy-load JS payload & use OOUI dialog in video.js playback mode [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/550926 (https://phabricator.wikimedia.org/T228339) (owner: 10Brion VIBBER) [23:59:12] wooooooooo [23:59:25] \o/ \o\ \o/ /o/ [23:59:39] ok i feel like i was productive today :D [23:59:50] thanks for the style adjustment James_F ;)