[02:13:03] (03CR) 10MaxSem: [C: 03+2] build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/541949 (owner: 10Jforrester) [02:20:04] (03Merged) 10jenkins-bot: build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/541949 (owner: 10Jforrester) [05:29:46] (03PS4) 10Matthias Mullie: Remove global access to Wikibase datamodel in js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [05:50:51] 10Multimedia, 10Commons, 10MediaWiki-Special-pages: Please let us filter [[Special:ListFiles]] like we can [[Special:NewFiles]]. - https://phabricator.wikimedia.org/T187974 (10DannyS712) [05:50:55] 10Multimedia, 10Commons, 10MediaWiki-Change-tagging, 10MediaWiki-Special-pages: Add tag filter to Special:ListFiles - https://phabricator.wikimedia.org/T192236 (10DannyS712) [06:28:01] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Security, 10Technical-Debt: Provide iframe sandboxing for rich-media extensions (defense in depth) - https://phabricator.wikimedia.org/T169027 (10Bawolff) >>! In T169027#5557850, @Tgr wrote: > Presumably, if the sandbox system mentioned in this task... [06:38:17] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Security, 10Technical-Debt: Provide iframe sandboxing for rich-media extensions (defense in depth) - https://phabricator.wikimedia.org/T169027 (10Bawolff) >>! In T169027#5556002, @Theklan wrote: > It makes sense, yes. Let's assume we have some good... [07:22:49] (03CR) 10Matthias Mullie: "I've added some more detail about the changes that were required, and why it was pretty cumbersome to deal with. The problem is mostly tha" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [08:53:49] (03CR) 10Matthias Mullie: Base CaptionsPanel.js on ComponentWidget (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/528825 (https://phabricator.wikimedia.org/T229011) (owner: 10Cparle) [08:53:58] (03PS13) 10Matthias Mullie: Base CaptionsPanel.js on ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/528825 (https://phabricator.wikimedia.org/T229011) (owner: 10Cparle) [08:54:01] (03PS1) 10Matthias Mullie: Remove widget interdependencies [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542065 [08:54:50] (03CR) 10Matthias Mullie: [C: 03+2] "PS13 = rebase. Landing." (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/528825 (https://phabricator.wikimedia.org/T229011) (owner: 10Cparle) [09:20:16] (03Merged) 10jenkins-bot: Base CaptionsPanel.js on ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/528825 (https://phabricator.wikimedia.org/T229011) (owner: 10Cparle) [09:25:30] (03CR) 10jerkins-bot: [V: 04-1] Remove widget interdependencies [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542065 (owner: 10Matthias Mullie) [09:33:51] (03PS1) 10Matthias Mullie: Fix value-less item rendering [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542069 [09:34:45] (03PS5) 10Matthias Mullie: Remove global access to Wikibase datamodel in js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [09:35:51] (03CR) 10Matthias Mullie: [C: 03+1] "PS4 is just a rebase." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [09:38:52] (03CR) 10Ladsgroup: [C: 03+1] "LGTM" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [09:52:31] (03CR) 10Jakob: "Thanks for the detailed explanation and quick response!" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [10:03:39] (03PS3) 10Matthias Mullie: Lay groundwork for other datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [10:04:22] (03PS6) 10Matthias Mullie: Remove global access to Wikibase datamodel in js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [10:05:07] (03CR) 10Matthias Mullie: [C: 03+1] "Fixed that leftover argument - thanks for spotting that!" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [10:06:12] (03CR) 10Jakob: [C: 03+2] "Yay!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [10:06:52] (03PS2) 10Matthias Mullie: Remove widget interdependencies [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542065 [10:31:55] (03CR) 10jerkins-bot: [V: 04-1] Lay groundwork for other datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [10:37:21] (03Merged) 10jenkins-bot: Remove global access to Wikibase datamodel in js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541553 (https://phabricator.wikimedia.org/T233790) (owner: 10Jakob) [10:54:47] (03PS6) 10Ladsgroup: Use one single module for wikibase.serialization [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/540403 (https://phabricator.wikimedia.org/T234327) [10:56:37] (03CR) 10jerkins-bot: [V: 04-1] Use one single module for wikibase.serialization [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/540403 (https://phabricator.wikimedia.org/T234327) (owner: 10Ladsgroup) [11:01:04] (03CR) 10Ladsgroup: "PS6 is manual rebase only" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/540403 (https://phabricator.wikimedia.org/T234327) (owner: 10Ladsgroup) [11:04:22] (03CR) 10jerkins-bot: [V: 04-1] Use one single module for wikibase.serialization [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/540403 (https://phabricator.wikimedia.org/T234327) (owner: 10Ladsgroup) [11:50:00] (03CR) 10Cparle: [C: 03+2] Remove widget interdependencies [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542065 (owner: 10Matthias Mullie) [12:01:47] (03PS1) 10Cparle: Don't create a 'show x more languages' link if there are none to show [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542091 (https://phabricator.wikimedia.org/T235167) [12:19:10] (03Merged) 10jenkins-bot: Remove widget interdependencies [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542065 (owner: 10Matthias Mullie) [12:28:37] (03CR) 10jerkins-bot: [V: 04-1] Don't create a 'show x more languages' link if there are none to show [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542091 (https://phabricator.wikimedia.org/T235167) (owner: 10Cparle) [12:32:26] (03PS2) 10Cparle: Don't create a 'show x more languages' link if there are none to show [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542091 (https://phabricator.wikimedia.org/T235167) [12:38:42] (03CR) 10Matthias Mullie: "Mostly fine, except for the API call. Follow-up patchset incoming to deal with feedback." (037 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [12:50:16] (03PS4) 10Matthias Mullie: Lay groundwork for other datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [12:50:18] (03PS3) 10Matthias Mullie: Groundwork for other data types support in UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/540977 (owner: 10Eric Gardner) [12:50:25] (03CR) 10jerkins-bot: [V: 04-1] Lay groundwork for other datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [12:50:33] (03CR) 10jerkins-bot: [V: 04-1] Groundwork for other data types support in UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/540977 (owner: 10Eric Gardner) [12:50:40] (03CR) 10jerkins-bot: [V: 04-1] Lay groundwork for other datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [12:57:51] (03PS5) 10Matthias Mullie: Lay groundwork for other datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [13:01:29] (03CR) 10Matthias Mullie: [C: 03+1] "I'm happy with this patch now - my major concern got fixed, and the other changes are a nice improvement/cleanup." (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [13:01:42] (03PS4) 10Matthias Mullie: Groundwork for other data types support in UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/540977 (owner: 10Eric Gardner) [13:05:21] (03Abandoned) 10Matthias Mullie: [WIP] Require wikibase.datamodel dependency instead of all its members [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541315 (owner: 10Matthias Mullie) [13:10:53] (03CR) 10jerkins-bot: [V: 04-1] Lay groundwork for other datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [13:17:17] (03PS6) 10Matthias Mullie: Lay groundwork for other datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [13:39:41] (03CR) 10Matthias Mullie: "(I'll get to this one tomorrow!)" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/540403 (https://phabricator.wikimedia.org/T234327) (owner: 10Ladsgroup) [14:12:17] (03PS1) 10Matthias Mullie: Require captions - if present - to have at least 5 characters [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/542113 (https://phabricator.wikimedia.org/T234756) [14:14:46] (03PS1) 10Matthias Mullie: Don't display 'see more languages' if there are none [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542115 [14:30:53] (03PS1) 10Matthias Mullie: Require captions to have at least 5 characters [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542119 (https://phabricator.wikimedia.org/T234756) [14:34:31] (03CR) 10Matthias Mullie: "Also have doubts about whether or not this should live in this extension (if we at all want to take this further)" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541849 (owner: 10Cparle) [14:34:40] (03CR) 10Eric Gardner: "Latest updates look good to me. I can have a follow-up patch (which will introduce a whitelisted set of allowed property datatypes) up soo" (034 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/541640 (owner: 10Eric Gardner) [14:39:09] (03Abandoned) 10Matthias Mullie: Don't display 'see more languages' if there are none [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542115 (owner: 10Matthias Mullie) [14:39:26] (03CR) 10Matthias Mullie: [C: 03+2] Don't create a 'show x more languages' link if there are none to show [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542091 (https://phabricator.wikimedia.org/T235167) (owner: 10Cparle) [14:56:08] (03CR) 10jerkins-bot: [V: 04-1] Require captions to have at least 5 characters [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542119 (https://phabricator.wikimedia.org/T234756) (owner: 10Matthias Mullie) [15:05:02] (03PS2) 10Matthias Mullie: Require captions to have at least 5 characters [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542119 (https://phabricator.wikimedia.org/T234756) [15:07:05] (03Merged) 10jenkins-bot: Don't create a 'show x more languages' link if there are none to show [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542091 (https://phabricator.wikimedia.org/T235167) (owner: 10Cparle) [15:25:09] 10Multimedia, 10Analytics, 10Discovery-Search, 10Reading-Admin, and 3 others: Image Classification Working Group - https://phabricator.wikimedia.org/T215413 (10Nuria) [15:30:20] (03CR) 10jerkins-bot: [V: 04-1] Require captions to have at least 5 characters [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542119 (https://phabricator.wikimedia.org/T234756) (owner: 10Matthias Mullie) [15:33:53] (03PS3) 10Matthias Mullie: Require captions to have at least 5 characters [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542119 (https://phabricator.wikimedia.org/T234756) [23:16:37] (03PS1) 10Eric Gardner: Enable support for non-item datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542253 [23:18:50] (03Abandoned) 10Eric Gardner: Enable non-item datatypes at both statement and qualifier levels [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/537208 (https://phabricator.wikimedia.org/T233036) (owner: 10Eric Gardner) [23:26:46] (03CR) 10jerkins-bot: [V: 04-1] Enable support for non-item datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542253 (owner: 10Eric Gardner) [23:28:31] (03CR) 10jerkins-bot: [V: 04-1] Enable support for non-item datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/542253 (owner: 10Eric Gardner)