[00:37:14] (03PS1) 10Eric Gardner: Add support for properties with URL datatypes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/535975 (https://phabricator.wikimedia.org/T231995) [07:41:15] James_F: right... i forgot about reparsing being such a pain... [08:07:06] hmm, we really sould split metadata off in its own table and keep track of WHEN we read it... [08:07:15] or a version or something. [08:09:14] hmm. mcr ? [08:24:40] euh... [08:24:49] maybeUpgradeRow() { [08:25:02] if ( $this->mime == 'image/svg' ) { [08:25:07] $upgrade = true; [08:26:37] this smells like a temp hack that has become permanent.. [08:29:16] right, a svg has no metadata reader, we always read directly from the file. [09:04:51] hmm. so what about, we create a postsavehook, that after the save of an article triggers a job to update the metadata of the images included in the page...... [09:05:25] and we create a new hidden metadata field (stripped from output) that keeps track of te date the metadata was written... [09:08:42] that should create a nice pace of updates for things that are actually in use... and then later we can still figure out what is really old and maybe tackle that separately. [11:25:20] (03CR) 10Matthias Mullie: Make unsupported datatypes roundtrip properly (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [11:31:28] (03PS11) 10Matthias Mullie: Make unsupported datatypes roundtrip properly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 [11:39:54] (03CR) 10Matthias Mullie: Make unsupported datatypes roundtrip properly (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [11:48:22] (03CR) 10Cparle: [C: 03+2] Add more tests to confirm 'change' events are emitted consistently [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534162 (owner: 10Matthias Mullie) [11:52:19] (03CR) 10Cparle: [C: 03+2] Add tests for AddPropertyWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534161 (owner: 10Matthias Mullie) [12:02:50] (03CR) 10Cparle: [C: 03+2] Improve StatementWidget test coverage [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534437 (owner: 10Matthias Mullie) [15:17:23] (03CR) 10Cparle: [C: 03+2] Add tests for GlobeCoordinateInputWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534582 (owner: 10Matthias Mullie) [15:17:55] (03CR) 10Cparle: [C: 03+2] Make unsupported datatypes roundtrip properly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [16:00:48] (03PS12) 10Lucas Werkmeister (WMDE): Make unsupported datatypes roundtrip properly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [16:01:02] (03CR) 10Cparle: [C: 03+2] Improve ItemWidget test coverage [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534163 (owner: 10Matthias Mullie) [16:01:23] (03CR) 10Lucas Werkmeister (WMDE): "rebased onto master so that this doesn’t block Ief0a9cbc61 in gate-and-submit, because until that change goes through this one will probab" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [16:04:30] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] "reapplying +2" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [16:05:41] thedj: PostSaveHook for just re-evaluating the meta-data, no special new MCR slot or whatever? Could work. [16:07:07] (03CR) 10Cparle: [C: 03+2] Add more tests for expected QualifierValueInputWidget behavior [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534160 (owner: 10Matthias Mullie) [16:32:28] (03CR) 10jerkins-bot: [V: 04-1] Make unsupported datatypes roundtrip properly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [16:44:53] 10Multimedia, 10MediaViewer, 10Design, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), and 2 others: Clicking the black frame should close Multimediaviewer - https://phabricator.wikimedia.org/T133900 (10Jdlrobson) Do we want to revert https://gerrit.wikimedia.org/r/511343 ? I don't know enough about how 3D f... [17:34:27] (03Merged) 10jenkins-bot: Make unsupported datatypes roundtrip properly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [18:34:43] (03CR) 10jenkins-bot: Make unsupported datatypes roundtrip properly [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534159 (owner: 10Matthias Mullie) [18:42:10] (03PS10) 10Matthias Mullie: Add more tests for expected QualifierValueInputWidget behavior [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/534160 [20:02:04] 10Multimedia, 10Commons, 10MediaWiki-File-management: Make it possible to refresh metadata of files without jumping through crazy hoops - https://phabricator.wikimedia.org/T232779 (10TheDJ) [20:21:55] 10Multimedia, 10Commons, 10MediaWiki-File-management: Make it possible to refresh metadata of files without jumping through crazy hoops - https://phabricator.wikimedia.org/T232779 (10Jdforrester-WMF) Possibly the RevisionDataUpdates hook? [22:35:53] 10Multimedia, 10Commons, 10MediaWiki-File-management: Make it possible to refresh metadata of files without jumping through crazy hoops - https://phabricator.wikimedia.org/T232779 (10Tgr) MCR is for primary data, not derived data. It is a snapshot of what information a user entered at a certain point in time... [22:37:41] 10Multimedia, 10Commons, 10MediaWiki-File-management: Make it possible to refresh metadata of files without jumping through crazy hoops - https://phabricator.wikimedia.org/T232779 (10Jdforrester-WMF) >>! In T232779#5489408, @Tgr wrote: > Any other approach would be a worse fit that would make the invalidatio... [23:24:24] 10Multimedia, 10Commons, 10MediaWiki-File-management: Make it possible to refresh metadata of files without jumping through crazy hoops - https://phabricator.wikimedia.org/T232779 (10Tgr) A maintenance script does not stampede. A multithreaded maintenance script is pretty much the ideal approach, determine h... [23:28:12] 10Multimedia, 10Commons, 10MediaWiki-File-management: Make it possible to refresh metadata of files without jumping through crazy hoops - https://phabricator.wikimedia.org/T232779 (10Jdforrester-WMF) See https://phabricator.wikimedia.org/T32961#2864157 etc. [23:31:43] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), and 3 others: XMPReader::parse exceptions - https://phabricator.wikimedia.org/T118799 (10Jdforrester-WMF) 05Open→03Resolved a:03TheDJ [23:31:47] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-Site-requests: Force a refresh of the EXIF metadata of all jpgs in production once new EXIF code lands - https://phabricator.wikimedia.org/T231393 (10Jdforrester-WMF)