[09:37:09] (03Abandoned) 10Matthias Mullie: Conditionally show external repo notice, and add template method [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/523710 (owner: 10Matthias Mullie) [09:57:17] (03Abandoned) 10Cparle: [WIP] Index MediaInfo labels as separate caption fields [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/519602 (https://phabricator.wikimedia.org/T226722) (owner: 10DCausse) [11:06:48] (03PS3) 10Matthias Mullie: Don't rerender when property or value changes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524786 [11:42:34] 10Multimedia, 10SDC Design, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Multimedia-Current-Work: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10Cparle) @PDrouin-WMF I think this really should be a separate ticket. AFAICS your original acceptance criteria ha... [11:45:36] (03CR) 10Cparle: [C: 03+2] Add ability to parse callback handlers into templates [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524203 (owner: 10Matthias Mullie) [12:05:09] (03Merged) 10jenkins-bot: Add ability to parse callback handlers into templates [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524203 (owner: 10Matthias Mullie) [12:09:08] (03CR) 10Cparle: [C: 04-1] "If I click on 'make prominent', and then press 'escape', the panel stays in the edit state without any cancel or publish buttons. I think " [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524505 (owner: 10Matthias Mullie) [12:10:28] (03CR) 10jenkins-bot: Add ability to parse callback handlers into templates [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524203 (owner: 10Matthias Mullie) [12:17:51] (03PS6) 10Matthias Mullie: License confirmation dialog must handle rejects [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524505 [12:18:20] (03CR) 10Matthias Mullie: "This patch just needed a rebase - the reject handling was introduced in the wikidata links patch (https://gerrit.wikimedia.org/r/c/mediawi" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524505 (owner: 10Matthias Mullie) [12:19:24] (03PS1) 10Matthias Mullie: Also add prominence toggle handler to otherStatementsEnabled html [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 [13:14:05] 10Multimedia, 10UploadWizard: Make an option for the tutorial to be a customizable message (instead of an image) - https://phabricator.wikimedia.org/T228701 (10Aklapper) [13:25:42] 10Multimedia, 10SDC Design, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Multimedia-Current-Work: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10PDrouin-WMF) Hey @Cparle I know this ticket has become rather gnarly, but I don't think the original AC has been... [13:38:53] 10Multimedia, 10SDC Design, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Multimedia-Current-Work: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10Cparle) In the discussion of this ticket we agreed (https://phabricator.wikimedia.org/T224249#5313187) that 'remo... [13:46:14] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for recording votes on depicts suggestions - https://phabricator.wikimedia.org/T228694 (10Tgr) > Should the votes themselves (including negative votes and abstentions) be tracke... [14:19:29] (03CR) 10Cparle: [C: 03+2] Use forEach insteaf of map if we're not returning anything [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524526 (owner: 10Matthias Mullie) [14:38:07] (03CR) 10Matthias Mullie: [C: 04-2] "TBD" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 (owner: 10Matthias Mullie) [14:43:10] (03Merged) 10jenkins-bot: Use forEach insteaf of map if we're not returning anything [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524526 (owner: 10Matthias Mullie) [14:51:02] (03CR) 10jenkins-bot: Use forEach insteaf of map if we're not returning anything [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524526 (owner: 10Matthias Mullie) [14:54:36] (03CR) 10Cparle: [C: 03+2] Also add prominence toggle handler to otherStatementsEnabled html [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [15:12:49] (03PS7) 10Cparle: License confirmation dialog must handle rejects [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524505 (owner: 10Matthias Mullie) [15:15:07] (03CR) 10jerkins-bot: [V: 04-1] Also add prominence toggle handler to otherStatementsEnabled html [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [15:16:17] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for serving images with depicts suggetsions needing confirmation - https://phabricator.wikimedia.org/T228770 (10Mholloway) [15:16:47] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for serving images with depicts suggetsions needing confirmation - https://phabricator.wikimedia.org/T228770 (10Mholloway) [15:16:59] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for serving images with depicts suggetsions needing confirmation - https://phabricator.wikimedia.org/T228770 (10Mholloway) [15:17:01] 10Multimedia, 10UploadWizard: Make an option for the tutorial to be a customizable message (instead of an image) - https://phabricator.wikimedia.org/T228701 (10Magwac) On a second thought, my proposed solution isn't a very good one. The tutorial can be customized per-campaign and restricting it to a single MW... [15:19:15] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for serving images with depicts suggetsions needing confirmation - https://phabricator.wikimedia.org/T228770 (10Mholloway) [15:19:47] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for serving images with depicts suggetsions needing confirmation - https://phabricator.wikimedia.org/T228770 (10Mholloway) [15:30:18] (03CR) 10Cparle: [C: 03+2] Also add prominence toggle handler to otherStatementsEnabled html [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [15:34:11] 10Multimedia, 10Core Platform Team, 10MediaWiki-Uploading, 10Wikimedia-production-error: AssembleUploadChunksJob triggers: SqlBagOStuff: tries to serialize closure - https://phabricator.wikimedia.org/T228749 (10Krinkle) [15:36:22] 10Multimedia, 10Core Platform Team, 10MediaWiki-Uploading, 10Wikimedia-production-error: AssembleUploadChunksJob triggers: SqlBagOStuff: tries to serialize closure - https://phabricator.wikimedia.org/T228749 (10Krinkle) The issue is with the array `$value` being stored, not the method of storage (closure w... [15:36:33] 10Multimedia, 10MediaWiki-Uploading, 10Wikimedia-production-error: AssembleUploadChunksJob triggers: SqlBagOStuff: tries to serialize closure - https://phabricator.wikimedia.org/T228749 (10WDoranWMF) [15:38:20] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for serving images with depicts suggestions needing confirmation - https://phabricator.wikimedia.org/T228770 (10Mholloway) [15:40:37] 10Multimedia, 10MediaWiki-Uploading, 10Core Platform Team (Code Health (TEC13)), 10Core Platform Team Workboards (Clinic Duty Team), 10Wikimedia-production-error: AssembleUploadChunksJob triggers: SqlBagOStuff: tries to serialize closure - https://phabricator.wikimedia.org/T228749 (10Anomie) `setSessionS... [15:50:44] (03PS9) 10Matthias Mullie: Introduce state-driven rerender component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 [15:50:46] (03PS1) 10Matthias Mullie: Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525120 [15:51:35] (03Abandoned) 10Matthias Mullie: Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525120 (owner: 10Matthias Mullie) [15:51:46] (03PS4) 10Matthias Mullie: Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524179 [15:51:55] (03CR) 10Matthias Mullie: [C: 04-2] "TBD" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524179 (owner: 10Matthias Mullie) [15:52:11] (03CR) 10jerkins-bot: [V: 04-1] Also add prominence toggle handler to otherStatementsEnabled html [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [15:58:11] (03CR) 10Matthias Mullie: [C: 03+2] "Unrelated build failure" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [16:12:41] (03CR) 10jerkins-bot: [V: 04-1] Introduce state-driven rerender component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 (owner: 10Matthias Mullie) [16:13:17] (03CR) 10jerkins-bot: [V: 04-1] Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524179 (owner: 10Matthias Mullie) [16:19:04] (03CR) 10jerkins-bot: [V: 04-1] Also add prominence toggle handler to otherStatementsEnabled html [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [16:19:24] 10Multimedia, 10UploadWizard: Some configuration settings are not parsed - https://phabricator.wikimedia.org/T228771 (10Magwac) [16:19:54] 10Multimedia, 10MediaWiki-Uploading, 10Core Platform Team (Code Health (TEC13)), 10Core Platform Team Workboards (Clinic Duty Team), 10Wikimedia-production-error: AssembleUploadChunksJob triggers: SqlBagOStuff: tries to serialize closure - https://phabricator.wikimedia.org/T228749 (10aaron) 959daa2ca44c0... [16:21:03] 10Multimedia, 10UploadWizard: Make an option for the tutorial to be a customizable message (instead of an image) - https://phabricator.wikimedia.org/T228701 (10Magwac) While trying to do this, I encountered a serious bug with how UploadWizard parses its configuration settings, I will have to fix that first. Se... [16:26:48] (03PS1) 10Ostrzyciel: First attempt at making an option to use templates instead of images in the tutorial. Work in progress, has to wait for T228771 to be fixed. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/525124 (https://phabricator.wikimedia.org/T228701) [17:12:12] (03CR) 10Matthias Mullie: [C: 03+2] "Unrelated build failure" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [17:22:02] 10Multimedia, 10UploadWizard: Some configuration settings are not parsed - https://phabricator.wikimedia.org/T228771 (10Magwac) a:05Magwac→03None Nope, after investigating it I concluded I have no idea how to fix it. Looks like solving it elegantly would require a small redesign of how UW handles configura... [17:23:27] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for recording votes on depicts suggestions - https://phabricator.wikimedia.org/T228694 (10Mholloway) It sounds like we might be best off just keeping votes in a MySQL table in t... [17:34:28] (03Merged) 10jenkins-bot: Also add prominence toggle handler to otherStatementsEnabled html [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [17:39:22] (03CR) 10jenkins-bot: Also add prominence toggle handler to otherStatementsEnabled html [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525077 (owner: 10Matthias Mullie) [17:51:23] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for recording votes on depicts suggestions - https://phabricator.wikimedia.org/T228694 (10PDrouin-WMF) Yes, I'd be curious about how feasible it'd be to have than information st... [17:52:30] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for recording votes on depicts suggestions - https://phabricator.wikimedia.org/T228694 (10Mholloway) [18:17:01] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for recording votes on depicts suggestions - https://phabricator.wikimedia.org/T228694 (10Mholloway) I'm beginning to lean against counting abstentions. They won't have any use... [18:22:11] 10Multimedia, 10Machine vision, 10Reading-Infrastructure-Team-Backlog, 10SDC-Statements (Machine-vision-depicts): Design a system for recording votes on depicts suggestions - https://phabricator.wikimedia.org/T228694 (10Mholloway) Out of curiosity, do we plan to allow anon users to vote on depicts suggesti... [18:52:53] brion: can you review https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimedMediaHandler/+/524044/ ? [19:22:07] (03PS1) 10TheDJ: Experiment with webpack and package module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/525145 [19:22:34] (03CR) 10jerkins-bot: [V: 04-1] Experiment with webpack and package module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/525145 (owner: 10TheDJ) [19:23:33] (03PS1) 10Matthias Mullie: Convert NewQualifierWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 [19:24:15] (03PS10) 10Matthias Mullie: Introduce state-driven rerender component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 [19:35:12] (03CR) 10jerkins-bot: [V: 04-1] Introduce state-driven rerender component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 (owner: 10Matthias Mullie) [19:35:40] (03CR) 10jerkins-bot: [V: 04-1] Convert NewQualifierWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 (owner: 10Matthias Mullie) [20:06:26] (03PS11) 10Matthias Mullie: Introduce state-driven rerender component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 [20:06:38] (03CR) 10Matthias Mullie: [C: 04-2] "TBD" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 (owner: 10Matthias Mullie) [20:06:56] (03PS5) 10Matthias Mullie: Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524179 [20:07:06] (03PS2) 10Matthias Mullie: Convert NewQualifierWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 [20:17:06] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Properties lacking a label in the user's language have the fallback language name appended to the fallback label - https://phabricator.wikimedia.org/T228693 (10egardner) @Ramsey-WMF I'll have a patch up... [20:17:47] (03CR) 10jerkins-bot: [V: 04-1] Introduce state-driven rerender component [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524178 (owner: 10Matthias Mullie) [20:18:16] (03CR) 10jerkins-bot: [V: 04-1] Convert AddPropertyWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/524179 (owner: 10Matthias Mullie) [20:18:36] (03CR) 10jerkins-bot: [V: 04-1] Convert NewQualifierWidget to ComponentWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525146 (owner: 10Matthias Mullie) [20:36:11] 10Multimedia, 10Product-Analytics, 10SDC Engineering, 10Patch-For-Review: Explore event logging and metrics for Multilingual file captions - https://phabricator.wikimedia.org/T191081 (10kzimmerman) @Ramsey-WMF any idea about the status of this? was this abandoned tracking? [20:45:08] 10Multimedia, 10WikibaseMediaInfo, 10Multimedia-Current-Work: Existing qualifiers do not appear in read-mode on the file page - https://phabricator.wikimedia.org/T228807 (10MarkTraceur) [20:49:33] 10Multimedia, 10WikibaseMediaInfo, 10Multimedia-Current-Work: InstantCommons images show Structured Data tab, but it does not function - https://phabricator.wikimedia.org/T228808 (10MarkTraceur) [23:41:01] (03PS1) 10Eric Gardner: Handle additional markup returned by requests to wbformatvalue [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525174 (https://phabricator.wikimedia.org/T228693) [23:43:08] (03PS2) 10Eric Gardner: Handle additional markup returned by requests to wbformatvalue [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525174 (https://phabricator.wikimedia.org/T228693) [23:54:37] (03CR) 10jerkins-bot: [V: 04-1] Handle additional markup returned by requests to wbformatvalue [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525174 (https://phabricator.wikimedia.org/T228693) (owner: 10Eric Gardner) [23:56:39] (03CR) 10Eric Gardner: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/525174 (https://phabricator.wikimedia.org/T228693) (owner: 10Eric Gardner)