[08:19:25] <wikibugs>	 (03PS3) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[08:36:31] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[08:46:50] <wikibugs>	 (03PS4) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[09:04:24] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[09:05:27] <wikibugs>	 (03PS5) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[09:20:01] <wikibugs>	 (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester)
[09:22:30] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester)
[09:22:35] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[09:22:55] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester)
[09:30:16] <wikibugs>	 (03PS6) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[09:30:49] <wikibugs>	 (03CR) 10Daimona Eaytoy: [C: 03+1] "Reviewed, unrelated failure" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester)
[09:47:36] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[09:49:04] <wikibugs>	 (03PS7) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[10:06:30] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[10:27:41] <wikibugs>	 (03CR) 10Daimona Eaytoy: "Jeez... Something wrong in OutputPage::getHeadLinksArray, which is a 250 lines method..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[11:03:12] <wikibugs>	 (03PS1) 10Cparle: Delete non-default properties from the DOM after submission [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/522056 (https://phabricator.wikimedia.org/T227106)
[11:05:49] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Delete non-default properties from the DOM after submission [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/522056 (https://phabricator.wikimedia.org/T227106) (owner: 10Cparle)
[11:44:09] <wikibugs>	 (03PS2) 10Cparle: Delete non-default properties from the DOM after submission [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/522056 (https://phabricator.wikimedia.org/T227106)
[11:46:12] <wikibugs>	 10Multimedia, 10MediaViewer, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: MediaViewer selenium tests are failing with "Misconfigured -- Unsupported OS/browser/version/device combo" because our target MacOS has aged out - https://phabricator.wikimedia.org/T214389 (10zeljkofilipi...
[11:46:14] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Delete non-default properties from the DOM after submission [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/522056 (https://phabricator.wikimedia.org/T227106) (owner: 10Cparle)
[12:58:05] <wikibugs>	 10Multimedia, 10MediaViewer, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 4 others: MediaViewer selenium tests are failing with "Misconfigured -- Unsupported OS/browser/version/device combo" because our target MacOS has aged out - https://phabricator.wikimedia.org/T214389 (10zeljkofilipi...
[12:59:08] <wikibugs>	 (03PS16) 10Matthias Mullie: Add Selenium tests targeting Beta Commons [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner)
[12:59:13] <wikibugs>	 (03CR) 10Matthias Mullie: [C: 03+2] Add Selenium tests targeting Beta Commons [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner)
[13:18:04] <wikibugs>	 (03Merged) 10jenkins-bot: Add Selenium tests targeting Beta Commons [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner)
[13:26:04] <wikibugs>	 10Multimedia, 10MediaViewer, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), and 2 others: selenium-MultimediaViewer Jenkins job failures - https://phabricator.wikimedia.org/T227770 (10zeljkofilipin)
[13:57:01] <wikibugs>	 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, and 3 others: Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10egardner) Looks like this has been merged – is this t...
[14:15:37] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] "Argh, we totally missed this, sorry." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/522091 (owner: 10Matthias Mullie)
[14:15:39] <wikibugs>	 (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester)
[14:35:41] <wikibugs>	 (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester)
[14:41:51] <wikibugs>	 (03Merged) 10jenkins-bot: Don't load EL schemas [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/522091 (owner: 10Matthias Mullie)
[14:41:55] <wikibugs>	 (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester)
[14:42:12] <wikibugs>	 (03CR) 10Cparle: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/522056 (https://phabricator.wikimedia.org/T227106) (owner: 10Cparle)
[14:57:02] <wikibugs>	 (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester)
[14:59:08] <wikibugs>	 (03CR) 10jenkins-bot: Don't load EL schemas [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/522091 (owner: 10Matthias Mullie)
[15:20:59] <wikibugs>	 10Multimedia, 10WikibaseMediaInfo, 10Discovery-Search (Current work), 10Multimedia-Current-Work, 10Patch-For-Review: Index captions as description fields not label - https://phabricator.wikimedia.org/T226722 (10Cparle)
[15:47:03] <wikibugs>	 10Multimedia, 10MediaWiki-Special-pages, 10MSSQL: Special:NewFiles query is broken (missing img_size on Mysql, fatal 2x img_timestamp on Mssql) - https://phabricator.wikimedia.org/T227608 (10Krinkle)
[16:32:02] <wikibugs>	 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: "Add a caption" is broken - https://phabricator.wikimedia.org/T227798 (10matthiasmullie)
[16:34:05] <wikibugs>	 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: "Add a caption" is broken - https://phabricator.wikimedia.org/T227798 (10Jdforrester-WMF) Train blocker?
[16:40:02] <wikibugs>	 (03PS1) 10Tpt: Adds some RDF triples from File metadata [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522141
[16:45:05] <wikibugs>	 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: "Add a caption" is broken - https://phabricator.wikimedia.org/T227798 (10Ramsey-WMF) p:05Triage→03High Oooh. Sweet regression :) Let's fix it quickly.
[17:22:59] <wikibugs>	 (03PS2) 10Tpt: Adds some RDF triples from File metadata [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/522141
[18:50:57] <wikibugs>	 (03PS1) 10Fomafix: Get language names from core module 'mediawiki.language.names' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/522165
[19:18:40] <wikibugs>	 (03PS3) 10Eric Gardner: Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458
[19:24:36] <wikibugs>	 (03CR) 10Huji: [C: 04-1] Add help links to special pages (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520472 (https://phabricator.wikimedia.org/T226938) (owner: 10DannyS712)
[19:26:39] <wikibugs>	 (03PS3) 10DannyS712: Add help links to special pages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520472 (https://phabricator.wikimedia.org/T226938)
[19:47:02] <wikibugs>	 (03CR) 10Huji: [C: 03+2] Add help links to special pages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520472 (https://phabricator.wikimedia.org/T226938) (owner: 10DannyS712)
[20:05:46] <wikibugs>	 (03CR) 10Brion VIBBER: [C: 03+2] TimedText: Add a audio captioning plugin for video.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/511106 (https://phabricator.wikimedia.org/T121387) (owner: 10TheDJ)
[20:07:09] <wikibugs>	 (03Merged) 10jenkins-bot: Add help links to special pages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520472 (https://phabricator.wikimedia.org/T226938) (owner: 10DannyS712)
[20:08:16] <wikibugs>	 (03CR) 10Krinkle: [C: 03+2] Get language names from core module 'mediawiki.language.names' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/522165 (owner: 10Fomafix)
[20:09:39] <wikibugs>	 (03CR) 10Jforrester: "👍🏼" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/511106 (https://phabricator.wikimedia.org/T121387) (owner: 10TheDJ)
[20:11:42] <brion>	 \o/
[20:24:34] <wikibugs>	 (03Merged) 10jenkins-bot: TimedText: Add a audio captioning plugin for video.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/511106 (https://phabricator.wikimedia.org/T121387) (owner: 10TheDJ)
[20:26:31] <thedj>	 brion: step by step
[20:26:48] <wikibugs>	 (03Merged) 10jenkins-bot: Get language names from core module 'mediawiki.language.names' [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/522165 (owner: 10Fomafix)
[20:27:56] <thedj>	 wow.. speak of s**t i didn't even know existed in TMH....
[20:27:59] <brion>	 i'll go through the rest of the blockers in a bit, see if it's worth doing a half-measure for the popup size or wait on that
[20:28:21] <brion>	 heh
[20:28:40] <brion>	 that's probably left over from when the frontend was meant to be usable outside mediawiki
[20:29:01] <thedj>	 probably from way before we had proper modules for most of the stuff ;)
[20:29:21] <brion>	 ah the good old days :D
[20:30:26] <thedj>	 in terms of prio, i'm a bit torn between popup and gallery bug actually...
[20:33:07] <wikibugs>	 (03CR) 10TheDJ: "actually.. isn't this a 1.33 JS module ? In that case the extenson.json required version should be upped." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/522165 (owner: 10Fomafix)
[20:38:15] <wikibugs>	 10Multimedia, 10Performance-Team, 10TimedMediaHandler, 10TimedMediaHandler-Player, and 4 others: Replace Kaltura player with Video.js - https://phabricator.wikimedia.org/T100106 (10TheDJ)
[20:39:24] <thedj>	 brion: another issue i sort of see is <audio> and css reflow...
[20:40:08] <brion>	 *nod*. thedj istr we considered using <video> for audio to fix the size more reliably; was that too problematic?
[20:40:16] <thedj>	 it's terrible.. i'm starting to think we need to hide the element, but then we have nothing to give sizing to any longer...
[20:40:21] <brion>	 heh
[20:40:27] <brion>	 we can always <div> around it
[20:40:44] <brion>	 but if the native <audio> UI is larger than the <div> it'll either overflow or reflow i guess...?
[20:40:46] <thedj>	 we did consider video, but we never wrote the code for it.
[20:41:27] <brion>	 simplest thing is to wrap it at a size larger than any known player, and let it overflow if larger to fix the size,maybe
[20:41:38] <thedj>	 (like we'd lose the vjs-audio class, so we would have to provide one ourself, and of course if there is not CSS player, then also the video player is pretty useless at a tiny size...
[20:41:52] <brion>	 yeah, too many minuses to that i think
[20:42:21] <thedj>	 brion: potential problem with wrapping would be the parsoid spec...
[20:42:53] <brion>	 ugh true we'd have to update that with the wrapper maybe :(
[20:42:57] <brion>	 silly elements :D
[20:42:59] <brion>	 (meeting)
[20:43:21] <thedj>	 k. i'll see about working a bit more on php testcases tomorrow evening.
[20:43:41] <wikibugs>	 (03PS4) 10Eric Gardner: Add template and render method to QualifierWidget [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458
[20:45:34] <wikibugs>	 10Multimedia, 10Performance-Team, 10TimedMediaHandler, 10TimedMediaHandler-Player, and 3 others: Replace Kaltura player with Video.js - https://phabricator.wikimedia.org/T100106 (10TheDJ)
[20:46:31] <wikibugs>	 (03CR) 10Eric Gardner: "Latest update achieves visual parity with the previous implementation and also makes the widget template aware of editing state, paving th" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/520458 (owner: 10Eric Gardner)
[21:01:57] <thedj>	 hmm interesting.. thumbtime works in WE2017 preview, but not in the rendered paged...  https://www.mediawiki.org/wiki/Extension:TimedMediaHandler/Tests/Thumbtime
[21:02:15] <wikibugs>	 10Multimedia, 10EasyTimeline, 10Graphs, 10Wikimedia-Extension-setup, and 2 others: Transition all use of EasyTimeline to the Graph extension and decommission it from Wikimedia's servers - https://phabricator.wikimedia.org/T137291 (10Krinkle) Note that while EasyTimeline is limited and feels outdated, it ha...
[21:17:52] <thedj>	 brion: i keep copy pasting things like this all over the place to various instances, so i figured i should centralize them for other people to use: https://www.mediawiki.org/wiki/Extension:TimedMediaHandler/Tests
[21:22:16] <James_F>	 thedj: Fancy.
[21:32:35] <brion>	 nice