[01:02:33] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521755 (owner: 10Jforrester) [01:11:41] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521755 (owner: 10Jforrester) [01:52:42] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/521615 (owner: 10Jforrester) [02:17:10] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/521615 (owner: 10Jforrester) [02:54:04] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/521615 (owner: 10Jforrester) [08:21:44] (03CR) 10Daimona Eaytoy: "I'd have to understand what array element is bringing taint in, first. As for the second issue, I don't get it." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [08:39:18] (03CR) 10Daimona Eaytoy: "Line 333 is unsafe iff $config is unsafe (taint-check probably thinks it is). Line 346's taintedness is probably coming from UploadWizardT" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester) [08:43:49] (03CR) 10TheDJ: "The second is likely just due to the variable name being same as the param name ?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [08:44:58] (03CR) 10Daimona Eaytoy: "> The second is likely just due to the variable name being same as" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [13:46:28] (03CR) 10Zfilipin: "check experimental" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521755 (owner: 10Jforrester) [14:04:47] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521755 (owner: 10Jforrester) [15:21:28] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-General-or-Unknown: Renaming a page in File namespace without a file associated triggers an error - https://phabricator.wikimedia.org/T227590 (10Aklapper) [16:51:33] 10Multimedia, 10SDC General, 10CommRel-Specialists-Support (Apr-Jun-2019): Community Relations support for the depicts statement SDC release - https://phabricator.wikimedia.org/T213764 (10Keegan) 05Open→03Resolved >>! In T213764#5321001, @Elitre wrote: > @keegan Do I understand correctly that our involve... [16:52:20] 10Multimedia, 10SDC General, 10Wikidata, 10CommRel-Specialists-Support (Apr-Jun-2019): Community gadget support for depicts - https://phabricator.wikimedia.org/T217204 (10Keegan) 05Open→03Resolved I'm not aware of anything breaking post-release. [16:52:23] 10Multimedia, 10SDC General, 10CommRel-Specialists-Support (Apr-Jun-2019): Community Relations support for the depicts statement SDC release - https://phabricator.wikimedia.org/T213764 (10Keegan) [17:17:10] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [17:35:16] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [18:10:40] 10Multimedia, 10MediaWiki-extensions-WikibaseRepository, 10StructuredDataOnCommons, 10WikibaseMediaInfo, 10Wikidata: Creating a Commons gallery page incorrectly states "This entity does not exist." - https://phabricator.wikimedia.org/T227699 (10Krinkle) [18:10:45] 10Multimedia, 10MediaWiki-extensions-WikibaseRepository, 10StructuredDataOnCommons, 10WikibaseMediaInfo, 10Wikidata: Creating a Commons gallery page incorrectly states "This entity does not exist." - https://phabricator.wikimedia.org/T227699 (10Krinkle) [19:38:57] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Other-statements-running): Link statement labels with their respective Wikidata urls - https://phabricator.wikimedia.org/T227230 (10Ramsey-WMF) Pam will update this ticket with new designs in the near future... [20:17:45] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Other-statements-running): Link statement labels with their respective Wikidata urls - https://phabricator.wikimedia.org/T227230 (10PDrouin-WMF) Hey Eric, here are the updated designs: {F29732966, size=full... [20:38:52] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Other-statements-running): Link statement labels with their respective Wikidata urls - https://phabricator.wikimedia.org/T227230 (10egardner) @PDrouin-WMF thanks – I'll add the notice bar in a separate patch. [21:41:27] (03PS6) 10Eric Gardner: Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) [21:43:03] (03CR) 10Eric Gardner: "Made a few changes to better respect the parser cache." (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner)