[01:33:30] (03PS1) 10Eric Gardner: Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) [01:33:38] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [01:33:42] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [01:34:32] (03PS2) 10Eric Gardner: Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) [01:34:39] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [01:34:43] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [01:44:26] (03PS3) 10Eric Gardner: Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) [01:51:23] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [02:10:51] (03CR) 10Eric Gardner: [C: 04-1] "First pass at re-working the structured data UI to satisfy the new requirements. I have a few questions regarding the best way to get Wiki" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [06:08:31] (03PS15) 10Matthias Mullie: Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [06:16:11] (03CR) 10Matthias Mullie: "Haven't reviewed any CSS/JS yet, but here's a quick note :)" (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [08:22:20] (03CR) 10Matthias Mullie: [C: 03+2] Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [08:42:16] (03Merged) 10jenkins-bot: Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [08:50:10] (03CR) 10jenkins-bot: Unit tests for CaptionPanel.js [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/517614 (https://phabricator.wikimedia.org/T219500) (owner: 10Cparle) [08:51:52] (03PS4) 10Matthias Mullie: Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [08:52:04] (03CR) 10jerkins-bot: [V: 04-1] Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [08:53:15] (03CR) 10jerkins-bot: [V: 04-1] Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [09:02:42] (03PS5) 10Matthias Mullie: Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [09:11:36] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Refactor UW statements code - https://phabricator.wikimedia.org/T225102 (10matthiasmullie) a:05matthiasmullie→03None [09:19:20] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): Odd behaviour when editing qualifier property type but not value - https://phabricator.wikimedia.org/T226181 (10matthiasmullie) a:05matthiasmullie→03N... [09:20:53] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Multimedia-Current-Work: File page: qualifiers not displayed just after they've been added - https://phabricator.wikimedia.org/T227274 (10matthiasmullie) [09:21:13] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Multimedia-Current-Work: File page: qualifiers not displayed just after they've been added - https://phabricator.wikimedia.org/T227274 (10matthiasmullie) a:05matthiasmullie→03None [09:37:35] (03PS1) 10Matthias Mullie: Rename onDepictsChange [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521447 [09:44:35] (03Abandoned) 10Cparle: Display linked ids for statement qualifiers on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/515039 (https://phabricator.wikimedia.org/T225114) (owner: 10Cparle) [10:01:29] (03CR) 10Cparle: [C: 03+2] Rename onDepictsChange [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521447 (owner: 10Matthias Mullie) [10:09:59] (03CR) 10Matthias Mullie: Add Wikidata links to statement UI elements (034 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [10:20:35] (03Merged) 10jenkins-bot: Rename onDepictsChange [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521447 (owner: 10Matthias Mullie) [10:26:16] (03CR) 10jenkins-bot: Rename onDepictsChange [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521447 (owner: 10Matthias Mullie) [10:32:43] (03PS1) 10Matthias Mullie: Remove old-style qualifiers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521460 [10:33:26] (03CR) 10Matthias Mullie: [C: 04-1] "Do not merge until other statements has been deployed on Commons - until then, the old dropdown-style qualifiers are in use." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521460 (owner: 10Matthias Mullie) [10:36:33] (03PS1) 10Cparle: Confirmation msg for 'remove all' on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521461 (https://phabricator.wikimedia.org/T224249) [10:38:37] (03CR) 10Cparle: "After you click 'cancel' the 'remove all' button stays focused, which it shouldn't. Wasn't obvious to me how to refer to it in the context" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521461 (https://phabricator.wikimedia.org/T224249) (owner: 10Cparle) [10:39:18] (03CR) 10jerkins-bot: [V: 04-1] Remove old-style qualifiers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521460 (owner: 10Matthias Mullie) [10:49:14] (03PS2) 10Matthias Mullie: Remove old-style qualifiers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521460 [10:49:17] (03PS1) 10Matthias Mullie: Remove code paths with no other statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 [10:49:37] (03CR) 10Matthias Mullie: [C: 04-1] "Do not merge until other statements has been deployed on Commons" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 (owner: 10Matthias Mullie) [10:50:04] (03CR) 10Matthias Mullie: [C: 04-1] "Do not merge until other statements has been deployed on Commons - until then, the old dropdown-style qualifiers are in use." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521460 (owner: 10Matthias Mullie) [11:03:46] (03CR) 10Matthias Mullie: [C: 03+2] Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [11:10:07] (03PS2) 10Matthias Mullie: Remove code paths with no other statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 [11:10:30] (03CR) 10Matthias Mullie: [C: 04-1] "Do not merge until other statements has been deployed on Commons" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 (owner: 10Matthias Mullie) [11:11:15] (03CR) 10jerkins-bot: [V: 04-1] Remove code paths with no other statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 (owner: 10Matthias Mullie) [11:22:44] (03Merged) 10jenkins-bot: Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [11:25:10] (03PS15) 10Matthias Mullie: Add Selenium tests targeting Beta Commons [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner) [11:26:51] (03CR) 10Matthias Mullie: "Rebased. Merging in 2 days, unless I hear otherwise." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner) [11:26:55] (03CR) 10Matthias Mullie: [C: 03+1] Add Selenium tests targeting Beta Commons [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner) [11:28:49] (03CR) 10jenkins-bot: Only show 'learn more' link in statement panel if link defined [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521294 (https://phabricator.wikimedia.org/T227226) (owner: 10Cparle) [11:29:57] (03PS3) 10Matthias Mullie: Remove code paths with no other statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 [11:30:12] (03CR) 10jerkins-bot: [V: 04-1] Remove code paths with no other statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 (owner: 10Matthias Mullie) [11:30:19] (03CR) 10jerkins-bot: [V: 04-1] Remove code paths with no other statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 (owner: 10Matthias Mullie) [11:31:36] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Show P-id and Q-id for qualifiers on File page, and link them to wikidata - https://phabricator.wikimedia.org/T225114 (10Cparle) 05Open→03Invalid We're not going to do it this way after all [11:37:08] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): UploadWizard: property panel added via "Add statement" persists when you upload another image - https://phabricator.wikimedia.org/T227106 (10Cparle) a:03Cparle [11:53:54] 10Multimedia, 10MediaWiki-Uploading, 10Patch-For-Review, 10Release-Engineering-Team-TODO (201907): .odb file recognized as application/acad (first type entry in our list) - https://phabricator.wikimedia.org/T35515 (10hashar) I have rebased the patch. Pending review / +2 [11:54:05] 10Multimedia, 10MediaWiki-Uploading, 10Patch-For-Review, 10Release-Engineering-Team-TODO (201907): .odb file recognized as application/acad (first type entry in our list) - https://phabricator.wikimedia.org/T35515 (10hashar) 05Open→03Stalled [11:59:44] (03PS3) 10Matthias Mullie: Remove old-style qualifiers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521460 [12:03:16] (03CR) 10Matthias Mullie: [C: 04-1] "Do not merge until other statements has been deployed on Commons - until then, the old dropdown-style qualifiers are in use." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521460 (owner: 10Matthias Mullie) [12:54:09] 10Multimedia, 10MediaWiki-User-preferences, 10Wikidata, 10Wikidata-Campsite: Use thumbnail preferences for thumbnail of Commons media file - https://phabricator.wikimedia.org/T224189 (10alaa_wmde) [14:18:20] (03PS4) 10Matthias Mullie: Remove code paths with no other statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 [14:42:39] 10Multimedia, 10MediaViewer, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: MediaViewer selenium tests are failing with "Misconfigured -- Unsupported OS/browser/version/device combo" because our target MacOS has aged out - https://phabricator.wikimedia.org/T214389 (10zeljkofilipi... [15:06:57] 10Multimedia, 10Commons, 10MediaWiki-File-management: Moving a File: page without a file onto a deleted file is not possible in Commons - https://phabricator.wikimedia.org/T226922 (10Ankry) This is probably a side effect of T227590. [15:07:02] (03CR) 10Matthias Mullie: [C: 04-1] "Do not merge until other statements has been deployed on Commons." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521467 (owner: 10Matthias Mullie) [16:03:28] 10Multimedia, 10MediaViewer, 10Design, 10Patch-For-Review, and 2 others: Clicking the black frame should close Multimediaviewer - https://phabricator.wikimedia.org/T133900 (10alexhollender) >>! In T133900#5315191, @Jdlrobson wrote: > @alexhollender would you be able to weigh in on this question about the D... [16:12:11] 10Multimedia, 10SDC Design, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), and 2 others: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10Cparle) a:05Cparle→03Edtadros [16:12:59] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): Odd behaviour when editing qualifier property type but not value - https://phabricator.wikimedia.org/T226181 (10Cparle) a:03Edtadros [16:17:07] 10Multimedia, 10MediaWiki-Uploading, 10Patch-For-Review, 10Release-Engineering-Team-TODO (201907): .odb file recognized as application/acad (first type entry in our list) - https://phabricator.wikimedia.org/T35515 (10hashar) 05Stalled→03Resolved [16:24:11] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), 10Multimedia-Current-Work, and 2 others: Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10Cparle) a:05egardner→03Edtadros @Edtadros this is now available... [16:25:53] 10Multimedia, 10MediaViewer, 10Design, 10Patch-For-Review, and 2 others: Clicking the black frame should close Multimediaviewer - https://phabricator.wikimedia.org/T133900 (10Volker_E) +1 to the idea proposed in the task in general. Additionally to the height affordance question above, we should consider t... [16:41:07] 10Multimedia, 10Commons, 10Lexicographical data, 10Wikidata, 10Wikidata-Campsite: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons - https://phabricator.wikimedia.org/T227504 (10Addshore) >>! In T227504#5315015, @Lydia_Pintscher wrote: > It is theoretically possible for so... [17:23:09] 10Multimedia, 10Commons, 10Lexicographical data, 10Wikidata, 10Wikidata-Campsite: Console error "Unknown module: wikibase.experts.Lexeme" on File pages in Commons - https://phabricator.wikimedia.org/T227504 (10MarkTraceur) I believe we want to disable Lexeme statements on Commons for now - so some help f... [18:34:46] 10Multimedia, 10MediaWiki-Uploading, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Release-Engineering-Team-TODO (201907): .odb file recognized as application/acad (first type entry in our list) - https://phabricator.wikimedia.org/T35515 (10Jdforrester-WMF) [19:20:16] (03PS4) 10Eric Gardner: Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) [19:20:27] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [19:20:32] (03CR) 10jerkins-bot: [V: 04-1] Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [19:38:25] (03PS5) 10Eric Gardner: Add Wikidata links to statement UI elements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) [19:40:10] (03CR) 10Eric Gardner: Add Wikidata links to statement UI elements (033 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521394 (https://phabricator.wikimedia.org/T227230) (owner: 10Eric Gardner) [19:56:00] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Performance-Team (Radar): Thumbnail urls should be versioned and sent with Expires headers - https://phabricator.wikimedia.org/T19577 (10Revansx) >>! In T19577#4303752, @Ciencia_Al_Poder wrote: > I use a custom-made extension that adds the file timest... [20:25:08] 10Multimedia, 103D, 10Security-Team-Reviews, 10Patch-For-Review: Security review of 3d2png - https://phabricator.wikimedia.org/T132063 (10sbassett) [20:26:39] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Performance-Team (Radar): Thumbnail urls should be versioned and sent with Expires headers - https://phabricator.wikimedia.org/T19577 (10Ciencia_Al_Poder) >>! In T19577#5318916, @Revansx wrote: > ... I've updated the README.md of the repository with... [20:28:28] 10Multimedia, 103D, 10Security-Team-Reviews: Security review of Extension:3d - https://phabricator.wikimedia.org/T157077 (10sbassett) [21:02:00] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/521615 [21:19:08] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 [21:20:30] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 [21:22:06] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521755 [22:12:02] 10Multimedia, 10MediaWiki-Uploading, 10MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), 10Patch-For-Review, 10Wikimedia-production-error: Upload failed with fatal error: Call to load() on a non-object in UploadBase.php - https://phabricator.wikimedia.org/T208539 (10Krinkle) a:03matthiasmullie //(Re-assigning... [22:13:26] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/521744 (owner: 10Jforrester) [22:27:48] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [23:09:54] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521755 (owner: 10Jforrester) [23:30:57] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521755 (owner: 10Jforrester) [23:36:38] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/521755 (owner: 10Jforrester)