[00:02:20] (03CR) 10Brion VIBBER: Transcode MIDI files to OGG Vorbis and MP3 (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/511015 (https://phabricator.wikimedia.org/T20852) (owner: 10Ebe123) [00:19:58] (03CR) 10Brion VIBBER: Transcode MIDI files to OGG Vorbis and MP3 (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/511015 (https://phabricator.wikimedia.org/T20852) (owner: 10Ebe123) [02:11:02] 10Multimedia, 10Commons, 10SDC Engineering, 10WikibaseMediaInfo, and 3 others: Wikibase Repo prevents page moves in NS 0 on Commons - https://phabricator.wikimedia.org/T224303 (10Abit) Hullo @alaa_wmde , do you have a rough eta for this? Inquiring minds want to tell other inquiring minds :) [04:47:15] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Volker_E) Keeping this open a bit longer to continue discussing the active vs selected... [04:47:25] 10Multimedia, 10OOUI, 10SDC Design: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Volker_E) [04:47:42] 10Multimedia, 10OOUI, 10SDC Design: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Volker_E) a:05Cparle→03Esanders [04:48:04] 10Multimedia, 10SDC Design, 10OOUI (OOUI-0.32.0): Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Volker_E) [06:05:32] 10Multimedia, 10Commons, 10SDC Engineering, 10WikibaseMediaInfo, and 3 others: Wikibase Repo prevents page moves in NS 0 on Commons - https://phabricator.wikimedia.org/T224303 (10WMDE-leszek) @Abit Reallistically not sooner than next week, sorry. This requires some code change, we'll try targeting the next... [08:52:46] (03PS1) 10Aaron Schulz: Clean up ResultWrapper type hints and related code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513049 [09:01:32] (03CR) 10Matthias Mullie: Basic statements data roundtrip tests (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 (owner: 10Matthias Mullie) [09:14:53] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10JeanFred) >>! In T219368#5209487, @Ramsey-WMF wrote: > Need to find a user with campaign creation right... [09:16:11] (03CR) 10Matthias Mullie: "> Patch Set 2:" (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [09:16:15] (03PS3) 10Matthias Mullie: Fix title max length to match backend, and actually validate it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) [09:25:07] 10Multimedia, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Add dedicated "remove" controls to the "Add Statement" input - https://phabricator.wikimedia.org/T224498 (10matthiasmullie) I think Eric is referring to the input field for selecting a new property, like this: {F29270507} [09:26:48] (03CR) 10jerkins-bot: [V: 04-1] Fix title max length to match backend, and actually validate it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [09:27:20] (03CR) 10Matthias Mullie: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [09:40:24] (03CR) 10jerkins-bot: [V: 04-1] Fix title max length to match backend, and actually validate it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [10:00:34] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 3 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Cparle) > If they were the same, this ticket wouldn't exist. sms works for Wikidata labels but not for Commons captions. This is... [11:18:32] (03PS3) 10Cparle: Grey out statements based on type, not config [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512883 (https://phabricator.wikimedia.org/T224461) [11:20:02] (03PS11) 10Matthias Mullie: Add Selenium tests targeting Beta Commons [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner) [11:22:07] (03CR) 10Matthias Mullie: [C: 03+1] "LGTM." (034 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner) [11:22:20] (03CR) 10Matthias Mullie: [C: 03+1] "(nice work, btw)" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner) [11:22:38] (03CR) 10Matthias Mullie: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [11:30:18] (03CR) 10Matthias Mullie: [C: 03+2] Indicate that statements have been submitted on Metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [11:36:31] (03CR) 10jerkins-bot: [V: 04-1] Fix title max length to match backend, and actually validate it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [11:44:44] (03CR) 10Cparle: "This change is ready for review." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512883 (https://phabricator.wikimedia.org/T224461) (owner: 10Cparle) [11:48:29] 10Multimedia, 10MediaWiki-extensions-CollaborationKit, 10TechCom-RFC: RFC: JSON validation - https://phabricator.wikimedia.org/T147137 (10mobrovac) Moving back to backlog due to inactivity. [11:53:54] (03CR) 10jerkins-bot: [V: 04-1] Indicate that statements have been submitted on Metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [12:40:19] 10Multimedia, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Add dedicated "remove" controls to the "Add Statement" input - https://phabricator.wikimedia.org/T224498 (10PDrouin-WMF) Thanks for the visual, @matthiasmullie A trash can should do it - it can be visible/usable until a s... [13:01:40] (03Merged) 10jenkins-bot: Basic statements data roundtrip tests [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 (owner: 10Matthias Mullie) [13:19:14] (03CR) 10jenkins-bot: Basic statements data roundtrip tests [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 (owner: 10Matthias Mullie) [13:45:48] (03PS1) 10Matthias Mullie: Fix vendor versions [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513121 [13:54:45] 10Multimedia, 10SDC Design, 10OOUI (OOUI-0.32.0): Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Esanders) >>>! In T215644#5218397, @Esanders wrote: >> I think in the screenshot at the top, a... [14:26:05] (03CR) 10Krinkle: [C: 03+2] Clean up ResultWrapper type hints and related code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513049 (owner: 10Aaron Schulz) [14:45:56] (03Merged) 10jenkins-bot: Clean up ResultWrapper type hints and related code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513049 (owner: 10Aaron Schulz) [15:29:46] 10Multimedia, 10Analytics, 10Analytics-EventLogging, 10Analytics-Kanban, 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21): Remove deprecated using schema.* syntax from MultimediaViewer - https://phabricator.wikimedia.org/T223284 (10Krinkle) 05Open→03Resolved [15:29:48] (03CR) 10Matthias Mullie: [C: 03+2] "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [15:39:34] (03CR) 10Krinkle: "Three failures:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [15:41:14] (03CR) 10jerkins-bot: [V: 04-1] Indicate that statements have been submitted on Metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [15:53:13] (03CR) 10jerkins-bot: [V: 04-1] Indicate that statements have been submitted on Metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [16:10:24] 10Multimedia, 10SDC-Statements: Allow to middle-click through to the Wikidata item from search results when adding Depicts statements - https://phabricator.wikimedia.org/T224604 (10JeanFred) [16:12:22] 10Multimedia, 10SDC-Statements: Allow to middle-click through to the Wikidata item from search results when adding Depicts statements - https://phabricator.wikimedia.org/T224604 (10LucasWerkmeister) [16:14:58] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10Cparle) [16:17:09] 10Multimedia, 10MediaWiki-extensions-PdfHandler, 10Operations: Error creating PDF on Commons: "convert: no decode delegate for this image format" (fixed in GS 9.07) - https://phabricator.wikimedia.org/T50007 (10MarkAHershberger) >>! In T50007#5208406, @Schtom wrote: > i ran > ` > convert pdffile.pdf test.jp... [16:28:14] 10Multimedia, 10Commons, 10SDC Engineering, 10WikibaseMediaInfo, and 3 others: Wikibase Repo prevents page moves in NS 0 on Commons - https://phabricator.wikimedia.org/T224303 (10Abit) Sweet--looking forward to it. Thanks so much for the update, Mr. Manicki :) [16:44:50] 10Multimedia, 10MediaWiki-extensions-PdfHandler, 10Operations: Error creating PDF on Commons: "convert: no decode delegate for this image format" (fixed in GS 9.07) - https://phabricator.wikimedia.org/T50007 (10Schtom) yes i did. i didn't recognize anything wrong with the image file. i used gnome's image vie... [17:47:01] (03CR) 10Jforrester: [C: 03+2] Fix vendor versions [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513121 (owner: 10Matthias Mullie) [18:00:07] (03CR) 10Eric Gardner: [C: 03+1] "Looks good, just one suggestion below." (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512883 (https://phabricator.wikimedia.org/T224461) (owner: 10Cparle) [18:09:13] (03CR) 10Eric Gardner: "I don't think the Jenkins failures have anything to do with the code in this patch but I'm not sure what to do about them." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [18:18:39] (03CR) 10jerkins-bot: [V: 04-1] Fix vendor versions [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/513121 (owner: 10Matthias Mullie) [18:33:48] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10egardner) Are we sure that we want an auto-suggest UI for the data type selection?... [18:43:14] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10matthiasmullie) They shouldn't be able to search for datatypes, but for 'propertie... [18:46:29] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10matthiasmullie) So basically, the feature here is changing the qualifier property... [18:51:49] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Visually indicate to users that they can't add/edit captions/structured data to protected files - https://phabricator.wikimedia.org/T221732 (10PDrouin-WMF) Made updates, and will be sharing them with the design team for feedback on visual design and styl... [18:59:32] (03Abandoned) 10Jforrester: Use Title->purgeCdn(), not the deprecated ->purgeSquid() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/496982 (owner: 10Jforrester) [19:01:55] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: MultimediaViewer should not update the browser's URL - https://phabricator.wikimedia.org/T68217 (10simon04) 05Open→03Declined Since T64266 has been resolved and the current behavior matches the mobile frontend, I'd close this issue as declined. Feel fr... [19:09:05] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Looks sane. I would +2 this, but would like it more if the people responsible for this codebase merge this." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512969 (owner: 10Umherirrender) [19:12:49] (03CR) 10Jforrester: [C: 03+2] "Good spot. Thanks, both." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512969 (owner: 10Umherirrender) [19:22:31] 10Multimedia, 10SDC Design: Deleting statement panels - https://phabricator.wikimedia.org/T224249 (10Ramsey-WMF) p:05Triage→03Normal [19:45:14] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10egardner) Ah, ok, thanks for the clarification. So as the user types, the auto-c... [20:28:42] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): Quantity qualifier value box is not visible on smartphones - https://phabricator.wikimedia.org/T224624 (10Ramsey-WMF) [20:28:59] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): Quantity qualifier value box is not visible on smartphones - https://phabricator.wikimedia.org/T224624 (10Ramsey-WMF) p:05Triage→03Normal [20:29:34] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): Quantity qualifier value box is not visible on smartphones - https://phabricator.wikimedia.org/T224624 (10Ramsey-WMF) Want to take a whack at this one, @egardner ? :) [20:46:54] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element - https://phabricator.wikimedia.org/T224625 (10Ramsey-WMF) [20:47:37] 10Multimedia, 10MediaViewer, 10I18n, 10Performance: MultimediaViewer should not use moment.js for a single line - https://phabricator.wikimedia.org/T224626 (10simon04) [20:47:41] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): On Firefox, quantity qualifier input boxes show a mini increment/decrement UI element - https://phabricator.wikimedia.org/T224625 (10Ramsey-WMF) p:05Triage→03Normal Maybe another one @egardner can... [20:48:09] 10Multimedia, 10MediaViewer, 10I18n, 10Performance: MultimediaViewer should not use moment.js for a single line - https://phabricator.wikimedia.org/T224626 (10simon04) [20:53:55] 10Multimedia, 10MediaWiki-extensions-CollaborationKit, 10TechCom-RFC: RFC: JSON validation - https://phabricator.wikimedia.org/T147137 (10Krinkle) [20:57:07] 10Multimedia, 10MediaWiki-extensions-CollaborationKit, 10TechCom-RFC: RFC: JSON validation - https://phabricator.wikimedia.org/T147137 (10Krinkle) [20:57:19] 10Multimedia, 10MediaWiki-extensions-CollaborationKit, 10TechCom-RFC: RFC: JSON validation - https://phabricator.wikimedia.org/T147137 (10Krinkle) [21:10:42] (03Merged) 10jenkins-bot: Do not pass argument to TimedTextPage::doRedirectToPageForm [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512969 (owner: 10Umherirrender) [21:30:51] (03PS1) 10Umherirrender: Remove $var = $var assignment [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513220 [21:34:36] (03CR) 10Jforrester: [C: 03+2] "Yup, dates from I34a84bc522; odd." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513220 (owner: 10Umherirrender) [21:51:14] (03Merged) 10jenkins-bot: Remove $var = $var assignment [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513220 (owner: 10Umherirrender) [23:51:21] 10Multimedia, 10Commons, 10Wikimedia-production-error: Database connection error when uploading a file to commons - https://phabricator.wikimedia.org/T220693 (10Krinkle)