[01:53:05] (03CR) 10Jforrester: [C: 03+2] "Giving this a kick." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) (owner: 10Eric Gardner) [02:28:57] (03CR) 10jerkins-bot: [V: 04-1] Ensure that Captions panel is right-aligned in RTL languages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) (owner: 10Eric Gardner) [06:45:35] (03PS2) 10Matthias Mullie: Ensure that Captions panel is right-aligned in RTL languages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) (owner: 10Eric Gardner) [06:45:47] (03CR) 10Matthias Mullie: [C: 03+2] Ensure that Captions panel is right-aligned in RTL languages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) (owner: 10Eric Gardner) [06:46:09] (03PS2) 10Matthias Mullie: Move complicated wikibase test setup into helpers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512712 [06:48:36] (03PS2) 10Matthias Mullie: Basic statements data roundtrip tests [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 [06:56:45] (03CR) 10Matthias Mullie: Other statements on File page (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [07:05:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512848 (owner: 10L10n-bot) [07:08:31] (03CR) 10jerkins-bot: [V: 04-1] Basic statements data roundtrip tests [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 (owner: 10Matthias Mullie) [07:21:12] (03CR) 10jerkins-bot: [V: 04-1] Ensure that Captions panel is right-aligned in RTL languages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) (owner: 10Eric Gardner) [07:30:09] (03CR) 10Matthias Mullie: [C: 03+2] Ensure that Captions panel is right-aligned in RTL languages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) (owner: 10Eric Gardner) [07:31:28] (03CR) 10Matthias Mullie: [C: 03+2] Move complicated wikibase test setup into helpers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512712 (owner: 10Matthias Mullie) [07:46:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/512845 (owner: 10L10n-bot) [08:37:33] (03Merged) 10jenkins-bot: Ensure that Captions panel is right-aligned in RTL languages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) (owner: 10Eric Gardner) [08:37:36] (03CR) 10jerkins-bot: [V: 04-1] Move complicated wikibase test setup into helpers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512712 (owner: 10Matthias Mullie) [08:45:09] (03CR) 10Matthias Mullie: [C: 03+2] Move complicated wikibase test setup into helpers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512712 (owner: 10Matthias Mullie) [08:45:37] (03CR) 10jenkins-bot: Ensure that Captions panel is right-aligned in RTL languages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) (owner: 10Eric Gardner) [09:00:57] (03PS12) 10Cparle: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) [09:10:30] 10Multimedia, 10SDC Engineering, 10I18n, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), and 2 others: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10Maintenance_bot) [09:14:15] (03CR) 10jerkins-bot: [V: 04-1] Move complicated wikibase test setup into helpers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512712 (owner: 10Matthias Mullie) [10:17:35] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): Search: Revise Qualifier popover copy and layout - https://phabricator.wikimedia.org/T219447 (10Cparle) [10:30:30] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Statement-and-keyword-search-power-walking): Non-default statements greyed out - https://phabricator.wikimedia.org/T224461 (10Cparle) [11:09:40] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 3 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Zache) So if we do not want to use `wmgExtraLanguageNames` for SDC (per T222309#5156677) then it needs to be fixed in code too?... [11:24:39] (03PS1) 10Cparle: Grey out statements based on type, not config [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512883 (https://phabricator.wikimedia.org/T224461) [11:24:52] (03CR) 10jerkins-bot: [V: 04-1] Grey out statements based on type, not config [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512883 (https://phabricator.wikimedia.org/T224461) (owner: 10Cparle) [11:24:58] (03CR) 10jerkins-bot: [V: 04-1] Grey out statements based on type, not config [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512883 (https://phabricator.wikimedia.org/T224461) (owner: 10Cparle) [11:27:26] (03CR) 10Matthias Mullie: [C: 03+2] Move complicated wikibase test setup into helpers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512712 (owner: 10Matthias Mullie) [11:30:02] (03PS13) 10Cparle: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) [11:30:05] (03PS2) 10Cparle: Grey out statements based on type, not config [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512883 (https://phabricator.wikimedia.org/T224461) [11:32:06] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Statement-and-keyword-search-power-walking): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10Cparle) [11:34:18] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Statement-and-keyword-search-power-walking): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10Cparle) a:03egardner [11:36:32] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Statement-and-keyword-search-power-walking): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10matthiasmullie) 'string' is also (theoretically) already support... [11:38:47] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Statement-and-keyword-search-power-walking): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10matthiasmullie) [11:49:41] (03CR) 10Matthias Mullie: Other statements on File page (0310 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [11:50:19] (03CR) 10jerkins-bot: [V: 04-1] Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [11:52:05] (03CR) 10Matthias Mullie: Other statements on File page (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [11:55:37] (03Merged) 10jenkins-bot: Move complicated wikibase test setup into helpers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512712 (owner: 10Matthias Mullie) [12:02:00] (03CR) 10jenkins-bot: Move complicated wikibase test setup into helpers [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512712 (owner: 10Matthias Mullie) [12:36:28] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 3 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Nikerabbit) Thinking out loud: I wonder how many sets of supported languages we need? It's of course desirable that each context c... [12:36:58] (03PS14) 10Matthias Mullie: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [12:37:25] (03CR) 10Matthias Mullie: Other statements on File page (0311 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [12:38:45] (03PS15) 10Matthias Mullie: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [12:39:29] (03CR) 10Matthias Mullie: Other statements on File page (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [12:41:04] (03CR) 10Matthias Mullie: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 (owner: 10Matthias Mullie) [12:41:12] (03PS3) 10Matthias Mullie: Basic statements data roundtrip tests [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 [13:02:35] (03CR) 10jerkins-bot: [V: 04-1] Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [13:16:57] 10Multimedia, 10Community-Tech, 10Discovery-Search, 10GeoData, and 7 others: Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated - https://phabricator.wikimedia.org/T224472 (10WMDE-leszek) [13:50:08] (03PS16) 10Matthias Mullie: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [13:51:09] (03CR) 10Matthias Mullie: [C: 03+1] "LGTM now - feel free to merge" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [13:56:07] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, and 2 others: Duplicate custom item title on frontend - https://phabricator.wikimedia.org/T220214 (10Cparle) [13:56:09] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Statement-and-keyword-search-power-walking): Make sure that the order of statements on the File page is correct - https://phabricator.wikimedia.org/T220213 (10Cparle) [13:56:15] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Statement-and-keyword-search-power-walking): Basic Q-item statements (non-depicts) for campaigns - https://phabricator.wikimedia.org/T219408 (10Cparle) [13:56:23] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Statement-and-keyword-search-power-walking): UI for adding statements in UploadWizard (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219407 (10Cparle) [13:56:31] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): Adding qualifiers results in the wrong button being focused - https://phabricator.wikimedia.org/T223916 (10Cparle) [14:00:11] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): Adding qualifiers results in the wrong button being focused - https://phabricator.wikimedia.org/T223916 (10PDrouin-WMF) Works for me! [14:04:56] (03PS2) 10Matthias Mullie: Fix title max length to match backend, and actually validate it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) [14:05:03] (03CR) 10Matthias Mullie: Fix title max length to match backend, and actually validate it (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [14:19:47] (03PS9) 10Matthias Mullie: Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [14:22:15] (03CR) 10Cparle: [C: 03+2] Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [14:36:24] (03CR) 10Matthias Mullie: [C: 03+1] "LGTM - let's just get that removePending call done, and this is ready to merge" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [14:37:01] (03CR) 10Matthias Mullie: [C: 03+2] Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [14:47:51] 10Multimedia, 10Commons, 10SDC Engineering, 10StructuredDataOnCommons, and 2 others: Structured Data table overflows when wikidata label is too long - https://phabricator.wikimedia.org/T221861 (10matthiasmullie) Yes, should be fixed already. Moving to Needs QA for verification. [14:48:02] 10Multimedia, 10Commons, 10SDC Engineering, 10StructuredDataOnCommons, and 2 others: Structured Data table overflows when wikidata label is too long - https://phabricator.wikimedia.org/T221861 (10matthiasmullie) [14:48:49] (03Merged) 10jenkins-bot: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [14:49:20] 10Multimedia, 10Commons, 10SDC Engineering, 10StructuredDataOnCommons, and 2 others: Structured Data table overflows when wikidata label is too long - https://phabricator.wikimedia.org/T221861 (10matthiasmullie) Actually, let's move this to "Verify on Production", since there's nothing new to test, and the... [14:55:13] (03PS4) 10Matthias Mullie: Basic statements data roundtrip tests [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 [14:55:43] (03CR) 10jenkins-bot: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [14:59:34] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [15:02:10] (03Abandoned) 10Matthias Mullie: Remove $wgMediaInfoEnableFilePageDepicts and code for its false path [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/498361 (owner: 10Matthias Mullie) [15:09:37] (03PS10) 10Matthias Mullie: Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [15:09:44] (03CR) 10Matthias Mullie: [C: 03+2] Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [15:10:30] 10Multimedia, 10SDC Design, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), and 2 others: UI for adding statement block on File page (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219383 (10Maintenance_bot) [15:14:20] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)), and 2 others: Replace usage of Title with usage of LinkTarget in File - https://phabricator.wikimedia.org/T214319 (10daniel) [15:38:14] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [15:38:46] (03CR) 10Matthias Mullie: [C: 03+2] Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [15:58:39] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: [Stub] Visually indicate to users that they can't add/edit captions/structured data to protected files - https://phabricator.wikimedia.org/T221732 (10PDrouin-WMF) Problem: when users attempt to edit a protected file page, they only find out after they've... [16:01:05] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Wikimedia-Hackathon-2019, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04): MediaViewer should adopt mediawiki.router - https://phabricator.wikimedia.org/T77258 (10Maintenance_bot) [16:08:14] (03Merged) 10jenkins-bot: Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [16:10:41] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Add php integration tests for Depicts - https://phabricator.wikimedia.org/T220113 (10Maintenance_bot) [16:15:02] (03CR) 10jenkins-bot: Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [16:25:21] 10Multimedia, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Add dedicated "remove" controls to the "Add Statement" input - https://phabricator.wikimedia.org/T224498 (10egardner) [16:26:44] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Add support for geo-coordinate Wikibase datatype - https://phabricator.wikimedia.org/T224060 (10Cparle) [16:27:47] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): [stub] Add "click here to see more" functionality to statement panels - https://phabricator.wikimedia.org/T220459 (10Ramsey-WMF) [16:28:28] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Other-statements-running): Non-default statements greyed out - https://phabricator.wikimedia.org/T224461 (10Cparle) [16:28:39] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Qualifier properties should chosen via autosuggest instead of a dropdown - https://phabricator.wikimedia.org/T224040 (10Cparle) [16:28:53] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, and 2 others: Duplicate custom item title on frontend - https://phabricator.wikimedia.org/T220214 (10Cparle) [16:29:04] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Make sure that the order of statements on the File page is correct - https://phabricator.wikimedia.org/T220213 (10Cparle) [16:29:18] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Basic Q-item statements (non-depicts) for campaigns - https://phabricator.wikimedia.org/T219408 (10Cparle) [16:29:29] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): UI for adding statements in UploadWizard (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219407 (10Cparle) [16:29:40] 10Multimedia, 10SDC Design, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), and 2 others: UI for adding statement block on File page (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219383 (10Cparle) [16:29:52] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Allow editing of non-depicts statement block on File page - https://phabricator.wikimedia.org/T219382 (10Cparle) [17:51:34] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: [Stub] Visually indicate to users that they can't add/edit captions/structured data to protected files - https://phabricator.wikimedia.org/T221732 (10PDrouin-WMF) @Ramsey-WMF pinging for input/acceptance criteria [17:56:58] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10PDrouin-WMF) Volker, I like your furthering of the work. For SDC, I don't think that... [18:03:23] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 3 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Zache) AFAIK. [[https://commons.wikimedia.org/wiki/Special:EntityData/M1227756.json|SDC captions]] are same thing than [[https://w... [18:13:33] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Volker_E) >>! In T215644#5213054, @Esanders wrote: >> the active (as in interaction-re... [18:31:15] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: [Stub] Visually indicate to users that they can't add/edit captions/structured data to protected files - https://phabricator.wikimedia.org/T221732 (10Ramsey-WMF) [18:34:10] 10Multimedia, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Add dedicated "remove" controls to the "Add Statement" input - https://phabricator.wikimedia.org/T224498 (10PDrouin-WMF) Hey @egardner I made a ticket last week that relates to this or either takes care of it: T224249 [18:41:22] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Core Platform Team (Decoupling (CDP2)), and 2 others: Replace usage of Title with usage of LinkTarget in File - https://phabricator.wikimedia.org/T214319 (10daniel) Bushing that back to "later", because we hit some snacks: * Title::getUserCaseDBKey()... [18:52:21] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512749 (owner: 10Umherirrender) [18:52:47] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Esanders) I think in the screenshot at the top, and my screenshots of the OOUI demo pa... [19:13:30] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: [Stub] Visually indicate to users that they can't add/edit captions/structured data to protected files - https://phabricator.wikimedia.org/T221732 (10Ramsey-WMF) Memorializing a conversation Pam and I just had: - We'll go for a thin banner at the to... [19:15:00] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Volker_E) >>! In T215644#5218141, @PDrouin-WMF wrote: > For SDC, I don't think that tr... [19:17:17] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 3 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Nikki) >>! In T222309#5218190, @Zache wrote: > AFAIK. [[https://commons.wikimedia.org/wiki/Special:EntityData/M1227756.json|SDC ca... [19:21:54] 10Multimedia, 10SDC Design, 10Multimedia-Current-Work: Visually indicate to users that they can't add/edit captions/structured data to protected files - https://phabricator.wikimedia.org/T221732 (10Ramsey-WMF) [19:24:12] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Volker_E) >>! In T215644#5218397, @Esanders wrote: > I think in the screenshot at the... [19:27:48] (03Merged) 10jenkins-bot: Declare missing 'input' property on ParseError class [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512749 (owner: 10Umherirrender) [19:42:44] (03PS1) 10Umherirrender: Do not pass argument to TimedTextPage::doRedirectToPageForm [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512969 [19:59:44] (03PS3) 10Eric Gardner: Indicate that statements have been submitted on Metadata step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) [20:00:00] (03CR) 10Eric Gardner: Indicate that statements have been submitted on Metadata step (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/511961 (https://phabricator.wikimedia.org/T222361) (owner: 10Eric Gardner) [20:05:26] 10Multimedia, 10Discovery-Search, 10GeoData, 10GlobalUsage, and 7 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10Krinkle) [20:06:03] 10Multimedia, 10Discovery-Search, 10GeoData, 10GlobalUsage, and 7 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10Krinkle) [20:09:27] 10Multimedia, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Non-depicts statements treated as unsupported on subsequent page visits - https://phabricator.wikimedia.org/T224519 (10egardner) [20:22:22] 10Multimedia, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Non-depicts statements treated as unsupported on subsequent page visits - https://phabricator.wikimedia.org/T224519 (10egardner) Whoops, just saw that @Cparle has already created a ticket for this at T224519 – closing this... [20:22:45] 10Multimedia, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Non-depicts statements treated as unsupported on subsequent page visits - https://phabricator.wikimedia.org/T224519 (10egardner) 05Open→03Declined [21:07:03] (03CR) 10Eric Gardner: "Caught one typo, and also thought I'd ask a few questions to better understand what is going on." (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) (owner: 10Matthias Mullie) [21:54:12] (03PS1) 10Brion VIBBER: Fix regression in subtitles for non-English sites on Commons videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512993 (https://phabricator.wikimedia.org/T224367) [22:10:48] (03CR) 10Jforrester: [C: 03+2] "I'm surprised that Title doesn't have this as a method…" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512993 (https://phabricator.wikimedia.org/T224367) (owner: 10Brion VIBBER) [22:11:45] (03PS1) 10Brion VIBBER: Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513000 (https://phabricator.wikimedia.org/T224522) [22:15:54] (03CR) 10Jforrester: [C: 03+2] Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513000 (https://phabricator.wikimedia.org/T224522) (owner: 10Brion VIBBER) [22:27:35] (03Merged) 10jenkins-bot: Fix regression in subtitles for non-English sites on Commons videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/512993 (https://phabricator.wikimedia.org/T224367) (owner: 10Brion VIBBER) [22:27:54] awwwww yeahhhhhh [22:36:30] (03PS1) 10Jforrester: Fix regression in subtitles for non-English sites on Commons videos [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513007 (https://phabricator.wikimedia.org/T224367) [22:36:45] (03PS1) 10Jforrester: Fix regression in subtitles for non-English sites on Commons videos [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/513008 (https://phabricator.wikimedia.org/T224367) [22:43:58] (03Merged) 10jenkins-bot: Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/513000 (https://phabricator.wikimedia.org/T224522) (owner: 10Brion VIBBER) [22:44:27] (03PS1) 10Jforrester: Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513010 (https://phabricator.wikimedia.org/T224522) [22:44:39] (03PS1) 10Jforrester: Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/513011 (https://phabricator.wikimedia.org/T224522) [22:49:15] (03CR) 10Jforrester: [C: 03+2] Fix regression in subtitles for non-English sites on Commons videos [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/513008 (https://phabricator.wikimedia.org/T224367) (owner: 10Jforrester) [22:49:20] (03CR) 10Jforrester: [C: 03+2] Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/513011 (https://phabricator.wikimedia.org/T224522) (owner: 10Jforrester) [22:49:23] (03CR) 10Jforrester: [C: 03+2] Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513010 (https://phabricator.wikimedia.org/T224522) (owner: 10Jforrester) [22:49:27] (03CR) 10Jforrester: [C: 03+2] Fix regression in subtitles for non-English sites on Commons videos [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513007 (https://phabricator.wikimedia.org/T224367) (owner: 10Jforrester) [22:50:03] wheeeeeeee :D [22:54:46] brion: Such fun. :-) [22:55:06] brion: BTW, what are the remaining blockers, if any, to releasing the VideoJS player as a beta feature? [22:55:46] James_F: I think we want to fix that loads-every-subtitle-language-at-once thing before deployment, but probably could launch as beta feature without that [22:56:07] Oh, yes, let's fix that first. [22:56:10] yeah ;) [22:56:18] * James_F gets back to deploying. [22:56:18] ok i'll push that up to top [22:56:21] thx! [23:05:56] (03Merged) 10jenkins-bot: Fix regression in subtitles for non-English sites on Commons videos [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/513008 (https://phabricator.wikimedia.org/T224367) (owner: 10Jforrester) [23:05:58] (03Merged) 10jenkins-bot: Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.6) - 10https://gerrit.wikimedia.org/r/513011 (https://phabricator.wikimedia.org/T224522) (owner: 10Jforrester) [23:06:01] (03Merged) 10jenkins-bot: Fix fatal in ApiTimedText following redirect pages [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513010 (https://phabricator.wikimedia.org/T224522) (owner: 10Jforrester) [23:06:04] (03Merged) 10jenkins-bot: Fix regression in subtitles for non-English sites on Commons videos [extensions/TimedMediaHandler] (wmf/1.34.0-wmf.7) - 10https://gerrit.wikimedia.org/r/513007 (https://phabricator.wikimedia.org/T224367) (owner: 10Jforrester) [23:10:07] (03CR) 10Eric Gardner: [C: 03+1] "Looks good to me. There certainly are a lot of hoops we have to jump through to test things in isolation though. Maybe in the future some " (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512713 (owner: 10Matthias Mullie) [23:19:11] brion: Once you're done with that, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/511015 looks good to me; not sure if we want to add transcoding tests? [23:20:02] Oh nice! I'll look that over [23:20:26] Transcoding tests are hard since they require the tooling on the CI server I suppose :( [23:31:17] Yes, but it's worth writing them, even if we for now disable them in CI and only run them manually to sanity-check. [23:34:21] (03CR) 10Brion VIBBER: "Just double-checking the audio bitrate setting is correct; otherwise this looks good; will test it out a bit shortly." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/511015 (https://phabricator.wikimedia.org/T20852) (owner: 10Ebe123)