[06:19:51] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, 10RTL: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10Amire80) Where are you testing this? Are you using debug mode? Last time I checked, RTL was more broken in debug mode. [06:40:51] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, 10WMNO-Sami: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Zache) btw, there is already `wbTermsLanguages` variable in mw.config.get() variables initialized in [[https://github.com/wikimed... [10:36:55] (03PS7) 10Cparle: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) [11:03:49] (03CR) 10jerkins-bot: [V: 04-1] Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [11:05:57] (03PS8) 10Cparle: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) [11:09:03] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): [Alpha/Labs] Search bar: Adding a depicts tag changes the size and position of the input field - https://phabricator.wikimedia.org/T218620 (10Cparle) a:05Cparle→03Edtadros [11:28:10] (03CR) 10jerkins-bot: [V: 04-1] Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [11:29:24] (03PS1) 10Cparle: Get languages for ULS from allowed languages for WB terms [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512351 (https://phabricator.wikimedia.org/T222309) [11:30:28] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 2 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Cparle) Good spot @Zache - changed to use `wbTermsLanguages` and sms now appears on my local dev environment [11:46:21] (03CR) 10jerkins-bot: [V: 04-1] Get languages for ULS from allowed languages for WB terms [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512351 (https://phabricator.wikimedia.org/T222309) (owner: 10Cparle) [11:48:34] (03Abandoned) 10Cparle: Get languages for ULS from allowed languages for WB terms [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512351 (https://phabricator.wikimedia.org/T222309) (owner: 10Cparle) [11:50:02] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 2 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Zache) `sms` needs to be configured to the backend also as supported language. For quick testing defining via 'wmgExtraLanguageNam... [12:23:50] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 2 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Cparle) Ok, so if I replace this ` $.extend( languages, mw.config.get( 'wgULSLanguages' ) ); ` with this ` $.extend( languages,... [12:28:00] (03Restored) 10Cparle: Get languages for ULS from allowed languages for WB terms [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512351 (https://phabricator.wikimedia.org/T222309) (owner: 10Cparle) [12:28:11] (03PS2) 10Cparle: Get languages for ULS from allowed languages for WB terms [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512351 (https://phabricator.wikimedia.org/T222309) [12:32:28] 10Multimedia, 10Discovery-Search, 10GeoData, 10GlobalUsage, and 5 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10daniel) So, we have a potential fix, but it doesn't seem to work with wikibas... [12:42:10] 10Multimedia, 10Discovery-Search, 10GeoData, 10GlobalUsage, and 5 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10Marostegui) Adding @Lydia_Pintscher and @Ladsgroup to the thread :-) [14:33:59] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 2 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Yupik) [14:34:25] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 2 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Yupik) [14:41:07] 10Multimedia, 10Language-strategy, 10MediaWiki-Internationalization, 10SDC Engineering, and 2 others: Add the Saami languages to Commons - https://phabricator.wikimedia.org/T224293 (10Yupik) [14:41:24] 10Multimedia, 10Language-strategy, 10MediaWiki-Internationalization, 10SDC Engineering, and 2 others: Add the Saami languages to Commons - https://phabricator.wikimedia.org/T224293 (10Yupik) [14:43:17] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, 10RTL: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10egardner) This is running in a local development environment on my machine. I just switched the language to Hebrew usi... [15:34:51] (03PS9) 10Cparle: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) [15:35:30] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, 10RTL: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10matthiasmullie) That's because the captions panel is inside
, which has `lang="en"`, `d... [15:37:53] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, 10RTL: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10egardner) I'm willing to give that a try and see what the results are locally. Would pulling Captions out of the conte... [15:48:16] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, 10RTL: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10matthiasmullie) Most of that code is somewhere in WikibaseMediaInfoHooks::doBeforePageDisplay (and the various methods... [15:51:58] (03CR) 10jerkins-bot: [V: 04-1] Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [16:31:25] (03PS10) 10Cparle: Other statements on File page [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) [17:00:54] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 2 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Zache) >>! In T222309#5210269, @Cparle wrote: > Is that what we want? Yes [17:11:16] 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 2 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Yupik) (In the parent task, we have the same problem for other Saami languages too. If those could be done as well, I'd really app... [17:33:29] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Esanders) {F29235107,width=600} [17:40:32] 10Multimedia, 10Language-strategy, 10MediaWiki-Internationalization, 10SDC Engineering, and 2 others: Add the Saami languages to Commons - https://phabricator.wikimedia.org/T224293 (10Yupik) [17:49:54] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10PDrouin-WMF) Pinging @Volker_E for feedback. What we have on Commons for tabbed naviga... [18:04:51] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Esanders) Although this task was filed for SDC, we have discussed add frameless suppor... [18:18:45] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10PDrouin-WMF) +1, @Esanders [18:42:00] (03CR) 10Cparle: "This change is ready for review." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle) [18:46:02] (03CR) 10Cparle: "@James I know you're not on my team anymore 10Multimedia, 10SDC Engineering, 10UniversalLanguageSelector, 10WMFI, and 2 others: Language code "sms" not recognized in Commons - https://phabricator.wikimedia.org/T222309 (10Cparle) Ok - there's a patch in there ready for review now, but I don't know what needs to be done to add the language to commons... [19:02:36] (03CR) 10Jforrester: "Why not just use wbTermsLanguages? Won't wgULSLanguages will have values we don't want?" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512351 (https://phabricator.wikimedia.org/T222309) (owner: 10Cparle) [20:55:15] (03PS1) 10Eric Gardner: Ensure that Captions panel is right-aligned in RTL languages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/512435 (https://phabricator.wikimedia.org/T222867) [20:56:43] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, and 2 others: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10egardner) Thanks @matthiasmullie for putting me on the right track. I was able to do exactly what you suggested t... [21:17:03] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, and 2 others: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10egardner) Here is a follow-up question about the layout of the Captions panel contents themselves, when both RTL... [22:08:54] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, and 2 others: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10Volker_E) @egardner I'm pretty sure that the proposed treatment is just exchanging the burden from RTL readers to... [22:20:45] 10Multimedia, 10SDC Engineering, 10I18n, 10Multimedia-Current-Work, and 2 others: Captions Panel alignment and overlapping issues in RTL languages - https://phabricator.wikimedia.org/T222867 (10egardner) I think that there is something to be said for the visual tidiness of this approach, and that using a c... [22:36:02] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Esanders) As suggested in the ticket, bottom-aligned the grey bar so that the widget c... [22:38:02] 10Multimedia, 10OOUI, 10SDC Design, 10Patch-For-Review: Add a frameless design for OOUI's IndexLayout (TabLayout), suitable for use on large, unframed contexts (not dialogs) - https://phabricator.wikimedia.org/T215644 (10Volker_E) Hey @PDrouin-WMF, I'd be very interested to move this forward, as @Esanders... [22:43:16] (03CR) 10Eric Gardner: "Looks good to me – my only point would be to try to get a more descriptive placeholder text for the PropertyInputWidget (since the user is" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510577 (https://phabricator.wikimedia.org/T219383) (owner: 10Cparle)