[05:40:35] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: Display warning when $wgServer's protocol does not match site setup - https://phabricator.wikimedia.org/T223456 (10Tgr) Having a site that's accessible via HTTPS but has `http:` in `$wgServer` is a misconfiguration and will break all kinds of things in not... [06:35:23] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer: Display warning when $wgServer's protocol does not match site setup - https://phabricator.wikimedia.org/T223456 (10Hopefully.Acceptable.Username) I'm happy for the tag to go and to clarify the description. If this can be "fixed" with a MediaWiki-level warn... [08:03:51] 10Multimedia, 10MediaWiki-Uploading, 10UploadWizard: Cannot upload larger JPG/WEBM/GIF files: "An error was encountered when opening the file for ZIP checks" - https://phabricator.wikimedia.org/T223446 (10Aklapper) p:05Normal→03Unbreak! [08:32:05] 10Multimedia, 10UniversalLanguageSelector, 10WMFI, 10WMNO-Sami: Language code "sms" not recognized - https://phabricator.wikimedia.org/T222309 (10Yupik) [08:55:09] (03CR) 10Matthias Mullie: Add Selenium tests targeting Beta Commons (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner) [09:02:15] (03PS1) 10Jforrester: build: Upgrade grunt-banana-checker from 0.6.0 to 0.7.1 and make pass [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510821 [09:02:17] (03PS1) 10Jforrester: build: Upgrade stylelint-config-wikimedia from 0.5.0 to 0.6.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510822 [09:19:46] (03PS1) 10TheDJ: TextHandler: Unbreak parsing API texttrack results [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510825 (https://phabricator.wikimedia.org/T222762) [09:20:46] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade stylelint-config-wikimedia from 0.5.0 to 0.6.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510822 (owner: 10Jforrester) [09:22:43] (03CR) 10Jforrester: [C: 03+2] TextHandler: Unbreak parsing API texttrack results [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510825 (https://phabricator.wikimedia.org/T222762) (owner: 10TheDJ) [09:29:59] (03PS1) 10Jforrester: WebMHandler: Check for Matroska ID3 comment field existing before reading [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510828 (https://phabricator.wikimedia.org/T223445) [09:34:30] (03PS2) 10Jforrester: WebMHandler: Check for Matroska ID3 comment field existing before reading [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510828 (https://phabricator.wikimedia.org/T223445) [09:36:33] 10Multimedia, 10Performance-Team, 10TimedMediaHandler, 10TimedMediaHandler-Player, and 2 others: Replace Kaltura player with Video.js - https://phabricator.wikimedia.org/T100106 (10Jdforrester-WMF) [09:37:49] 10Multimedia, 10MediaWiki-Stakeholders-Group, 10MediaWiki-Uploading: Provide a mechanism for site admins to hide the "This is my own work" checkbox for third party wikis which don't care - https://phabricator.wikimedia.org/T140068 (10Tgr) Merging #mediawiki-stakeholders-group-technical into #mediawiki-stakeh... [09:38:25] (03PS1) 10TheDJ: Player controls: Hide info button on file page [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510832 (https://phabricator.wikimedia.org/T223531) [09:53:29] (03CR) 10jerkins-bot: [V: 04-1] Player controls: Hide info button on file page [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510832 (https://phabricator.wikimedia.org/T223531) (owner: 10TheDJ) [10:01:40] (03Merged) 10jenkins-bot: TextHandler: Unbreak parsing API texttrack results [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510825 (https://phabricator.wikimedia.org/T222762) (owner: 10TheDJ) [10:07:21] (03PS2) 10Jforrester: Player controls: Hide info button on file page [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510832 (https://phabricator.wikimedia.org/T223531) (owner: 10TheDJ) [10:11:17] (03PS1) 10Jforrester: VideoJS: Provide CY and OC languageScripts [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510833 [10:25:40] (03CR) 10Jforrester: [C: 03+2] Player controls: Hide info button on file page [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510832 (https://phabricator.wikimedia.org/T223531) (owner: 10TheDJ) [10:30:34] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): [Alpha/Labs] Search bar: Adding a depicts tag changes the size and position of the input field - https://phabricator.wikimedia.org/T218620 (10matthiasmullie) [10:30:36] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-on-training-wheels): [Alpha/Labs] Search bar: Adding a depicts tag changes the size and position of the input field - https://phabricator.wikimedia.org/T218620 (10matthiasmullie) https://federated-commons.wmflabs.org/wiki... [10:32:26] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Captions mobile improvements - https://phabricator.wikimedia.org/T223432 (10matthiasmullie) I suspect "cancel/publish" should be in the same row as "add a caption" if there's enough space, and drop down below it if the screen b... [10:46:23] (03PS1) 10Jforrester: Rename ApiTestCaseVideoUpload to ApiVideoUploadTestCase [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510842 (https://phabricator.wikimedia.org/T189894) [10:54:05] (03Merged) 10jenkins-bot: Player controls: Hide info button on file page [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510832 (https://phabricator.wikimedia.org/T223531) (owner: 10TheDJ) [11:50:30] 10Multimedia, 10Performance-Team, 10TimedMediaHandler, 10TimedMediaHandler-Player, and 2 others: Replace Kaltura player with Video.js - https://phabricator.wikimedia.org/T100106 (10Jdforrester-WMF) [13:03:41] 10Multimedia, 10UploadWizard, 10Wikimedia-production-error: ErrorException from line 1274 of /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php: PHP Warning: fread() expects parameter 1 to be resource, boolean given - https://phabricator.wikimedia.org/T223448 (10hashar) [13:03:43] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading, 10media-storage: Upload fails at Wikimedia Commons "Internal error: Server failed to store temporary file." - https://phabricator.wikimedia.org/T222994 (10hashar) [13:03:54] 10Multimedia, 10UploadWizard, 10Wikimedia-production-error: ErrorException from line 1274 of /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php: PHP Warning: fread() expects parameter 1 to be resource, boolean given - https://phabricator.wikimedia.org/T223448 (10hashar) [13:03:56] 10Multimedia, 10MediaWiki-Uploading, 10UploadWizard: Cannot upload larger JPG/WEBM/GIF files: "An error was encountered when opening the file for ZIP checks" - https://phabricator.wikimedia.org/T223446 (10hashar) [13:04:29] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading, 10media-storage: Upload fails at Wikimedia Commons "Internal error: Server failed to store temporary file." - https://phabricator.wikimedia.org/T222994 (10hashar) I am pretty sure that is related to the server side exception fil... [13:04:34] 10Multimedia, 10MediaWiki-Uploading, 10UploadWizard: Cannot upload larger JPG/WEBM/GIF files: "An error was encountered when opening the file for ZIP checks" - https://phabricator.wikimedia.org/T223446 (10hashar) I am pretty sure that is related to the server side exception filled at: T223448 I will try to... [13:11:15] 10Multimedia, 10UploadWizard, 10Wikimedia-production-error: ErrorException from line 1274 of /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php: PHP Warning: fread() expects parameter 1 to be resource, boolean given - https://phabricator.wikimedia.org/T223448 (10hashar) [13:17:20] 10Multimedia, 10UploadWizard, 10Patch-For-Review, 10Wikimedia-production-error: ErrorException from line 1274 of /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php: PHP Warning: fread() expects parameter 1 to be resource, boolean given - https://phabricator.wikimedia.org/T223448 (10hashar) 38ec... [13:21:48] matthiasmullie: hi! About the upload verification issue, Sorry I should have identified that exception wayyyy earlier :-( [13:22:29] no worries, I also only just got around to it :p [13:22:44] but it looks like we've mostly come to the same conclusion :p [13:22:55] yeah [13:23:08] then I would guess the error really lies else where and would still have to be figured out ;] [13:23:24] do you want brad to review this change or should we just proceed it with it? [13:23:58] I don't even know how to reproduce it, apparently that would be just about uploading a large file that require the chunked process [13:27:01] UploadWizard will upload async for files larger than 10M [13:28:12] 10Multimedia, 10UploadWizard, 10Patch-For-Review, 10Wikimedia-production-error: ErrorException from line 1274 of /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php: PHP Warning: fread() expects parameter 1 to be resource, boolean given - https://phabricator.wikimedia.org/T223448 (10matthiasmulli... [13:29:35] let's wait a little - I'll first try to reliably reproduce this :p [13:29:49] okkkko ) [13:40:55] (03PS1) 10Matthias Mullie: Fix title max length to match backend, and actually validate it [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/510905 (https://phabricator.wikimedia.org/T208539) [13:54:26] (03CR) 10Eric Gardner: Add Selenium tests targeting Beta Commons (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502904 (https://phabricator.wikimedia.org/T219815) (owner: 10Eric Gardner) [13:59:07] hashar: I manage to reproduce the "An error was encountered when opening the file for ZIP checks." every time in prod (UploadWizard, upload a large file, probably any >10M will do - errors when submitting in step "Describe") [13:59:58] not able to reproduce on beta; can't even get that far - upload process seems stuck otherwise with a big enough file, waiting too long for jobs [14:25:32] Does beta even allow such large files? [14:27:42] matthiasmullie: sorry I was looking at something else :((( [14:27:58] should we just deploy your fix ? [14:29:29] marktraceur: idk - at least beta UW doesn’t stop me from doing so... but it doesn’t succeed :) [14:29:58] Hmph [14:30:46] hashar: I *think* it should work... :p [14:31:13] maybe we should get umherrinder or krinkle (involved in that other patch) to look at it just to have another set of eyes? [14:31:33] well you reproduce it in prod right? [14:31:40] so we can potentially stage it on mwdebug1001 [14:31:48] I can repro on prod, yes [14:31:51] and if all fine roll it [14:32:03] but I can't guarantee it won't have any other side effects I haven't considered :D [14:32:13] I can't even :( [14:32:14] or [14:32:20] we just revert the other patch [14:32:58] that would also work, but then we're back to the original error (although that one didn't occur often) [14:34:11] it would be the safest fix, though [14:35:44] so yeah lets revert [14:35:53] i like safe stuff :] [14:36:12] especially right before the weekend :p [14:40:38] and I found my phan issue [14:40:42] revert dance time :) [14:42:44] hashar: are you reverting right now? [14:42:50] matthiasmullie: yes with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/510923/ [14:42:55] (I need to head out quick, but I can wait another half hour and test) [14:42:59] ok, I'll wait [14:43:20] and cherry picking it to wmf/1.34.0-wmf.5 [14:44:57] matthiasmullie: you might want to +2 the wmf cherry pick https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/510924/ :D [14:45:57] (03PS2) 10Eric Gardner: Captions mobile improvements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510782 (https://phabricator.wikimedia.org/T223432) [14:46:04] there you go [14:46:47] ;:))) [14:47:17] if only I properly paid attention to the logstash spam earlier :/ [14:49:11] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Captions mobile improvements - https://phabricator.wikimedia.org/T223432 (10egardner) Ok, I've updated the patch to make footer behavior consistent between the panels. The footer buttons share a row when there is sufficient spa... [14:49:31] matthiasmullie: I have cherry picked the revert on mwdebug1001 if you want to test [14:49:44] then I guess after that you are safe to head out :] [14:49:52] alright, give me a sec [14:54:28] mwdebug1001 works, mwdebug1002 still fails [14:54:32] the revert fixed it [14:54:33] awesome [14:54:34] go ahead! [14:54:48] I will deploy it as soon as the patch is merged :] [14:55:01] grand [14:55:05] thank you very much! and I guess: have a good week-end ;) [14:56:03] you too! [15:24:55] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading, and 2 others: Upload fails at Wikimedia Commons "Internal error: Server failed to store temporary file." - https://phabricator.wikimedia.org/T222994 (10hashar) [15:25:07] 10Multimedia, 10UploadWizard, 10Patch-For-Review, 10Wikimedia-production-error: ErrorException from line 1274 of /srv/mediawiki/php-1.34.0-wmf.5/includes/upload/UploadBase.php: PHP Warning: fread() expects parameter 1 to be resource, boolean given - https://phabricator.wikimedia.org/T223448 (10hashar) 05O... [15:27:25] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading, and 2 others: Upload fails at Wikimedia Commons "Internal error: Server failed to store temporary file." - https://phabricator.wikimedia.org/T222994 (10hashar) If you tried to uploaded a file larger than 10MBytes, it is uploaded i... [15:27:30] 10Multimedia, 10MediaWiki-Uploading, 10UploadWizard, 10Patch-For-Review: Cannot upload larger JPG/WEBM/GIF files: "An error was encountered when opening the file for ZIP checks" - https://phabricator.wikimedia.org/T223446 (10hashar) If you tried to uploaded a file larger than 10MBytes, it is uploaded in sm... [15:29:59] matthiasmullie: and I got the patch deployed to production. thanks! [15:31:46] cool! [16:42:30] (03PS1) 10Samwilson: Add the mediainfo-term right to the editpage grant [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510946 (https://phabricator.wikimedia.org/T223638) [17:29:12] (03CR) 10Jforrester: [C: 03+2] Add the mediainfo-term right to the editpage grant [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510946 (https://phabricator.wikimedia.org/T223638) (owner: 10Samwilson) [17:50:47] 10Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Technical-Debt: Remove SVG checks - https://phabricator.wikimedia.org/T223649 (10Jdlrobson) [17:58:39] (03Merged) 10jenkins-bot: Add the mediainfo-term right to the editpage grant [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510946 (https://phabricator.wikimedia.org/T223638) (owner: 10Samwilson) [18:07:18] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T222361 (10egardner) @PDrouin-WMF I can take a stab at this if using the already-existing spin... [18:31:02] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T222361 (10PDrouin-WMF) @egardner sounds good! thank you. [18:38:14] 10Multimedia, 10Multimedia-Current-Work: Wikidata icon doesn't align with property link in statements widget when secondary statement label is present - https://phabricator.wikimedia.org/T223655 (10egardner) [18:50:05] (03PS1) 10Eric Gardner: Ensure wikidata icon remains aligned with property link [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/510960 (https://phabricator.wikimedia.org/T223655) [21:31:35] (03CR) 10TheDJ: [C: 03+2] VideoJS: Provide CY and OC languageScripts [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510833 (owner: 10Jforrester) [21:35:07] (03CR) 10TheDJ: [C: 03+2] WebMHandler: Check for Matroska ID3 comment field existing before reading [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510828 (https://phabricator.wikimedia.org/T223445) (owner: 10Jforrester) [21:38:54] (03CR) 10TheDJ: [C: 03+2] Rename ApiTestCaseVideoUpload to ApiVideoUploadTestCase [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510842 (https://phabricator.wikimedia.org/T189894) (owner: 10Jforrester) [21:44:46] 10Multimedia, 10MediaWiki-extensions-VipsScaler, 10Operations, 10Wikimedia-production-error: VipsScaler broken for MediaWiki production (/usr/bin/vips: No such file) - https://phabricator.wikimedia.org/T199938 (10Reedy) [21:47:24] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10Wikimedia-production-error: Undefined index '1' in FormatMetadata::makeFormattedData (Software EXIF metadata) - https://phabricator.wikimedia.org/T178130 (10Reedy) [21:49:21] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MW-1.27-release-notes, 10Wikimedia-production-error: PHP Notice: Undefined offset: 0 in /.../includes/media/FormatMetadata.php on line 1045 - https://phabricator.wikimedia.org/T87572 (10Reedy) [21:51:21] (03Merged) 10jenkins-bot: VideoJS: Provide CY and OC languageScripts [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510833 (owner: 10Jforrester) [22:01:17] (03Merged) 10jenkins-bot: WebMHandler: Check for Matroska ID3 comment field existing before reading [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510828 (https://phabricator.wikimedia.org/T223445) (owner: 10Jforrester) [22:01:21] (03Merged) 10jenkins-bot: Rename ApiTestCaseVideoUpload to ApiVideoUploadTestCase [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/510842 (https://phabricator.wikimedia.org/T189894) (owner: 10Jforrester)