[00:12:26] 10Multimedia: Explore possibilities for users to remove/exclude geo data from EXIF on images - https://phabricator.wikimedia.org/T222675 (10Ramsey-WMF) [00:13:34] 10Multimedia: Explore possibilities for users to remove/exclude geo data from EXIF on images - https://phabricator.wikimedia.org/T222675 (10Ramsey-WMF) [00:13:39] (03CR) 10Bartosz Dziewoński: "Test failure is caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/506897" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [00:14:04] 10Multimedia, 10MediaWiki-Uploading: Option to strip some metadata on upload (GPS/geolocation privacy) - https://phabricator.wikimedia.org/T22326 (10Ramsey-WMF) [00:14:07] 10Multimedia: Explore possibilities for users to remove/exclude geo data from EXIF on images - https://phabricator.wikimedia.org/T222675 (10Ramsey-WMF) [00:14:20] (03CR) 10Jforrester: "> Patch Set 67:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [00:29:23] (03CR) 10Jforrester: "The saving on this is going to go away in a few weeks' time when the config gets switched permanently on (and then removed); not sure it's" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508406 (owner: 10Krinkle) [04:29:25] 10Multimedia, 10Community-Tech, 10Discovery-Search, 10GeoData, and 8 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10aaron) It's the new use of DeferredUpdates::attemptUpdate/addCallableUpdat... [04:46:21] (03CR) 10MaxSem: [C: 03+2] UploadWizardCampaign: Use MediaWikiServices rather than wgParser [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/507731 (owner: 10Jforrester) [05:22:13] (03CR) 10jerkins-bot: [V: 04-1] UploadWizardCampaign: Use MediaWikiServices rather than wgParser [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/507731 (owner: 10Jforrester) [05:54:38] 10Multimedia, 10UniversalLanguageSelector, 10WMNO-Sami: Language code "sms" not recognized - https://phabricator.wikimedia.org/T222309 (10Yupik) Is it safe to assume that everything I've tried to upload before this issue gets fixed will need to be reentered? {F28950597} As I have been and will be uploading a... [06:01:18] 10Multimedia, 10UniversalLanguageSelector, 10WMNO-Sami: Language code "sms" not recognized - https://phabricator.wikimedia.org/T222309 (10Yupik) >>! In T222309#5151548, @jhsoby-WMNO wrote: > On Wikidata this code is available for labels, descriptions and monolingual texts because it is defined in wmgExtraLan... [06:13:42] 10Multimedia, 10SDC Design, 10SDC Engineering, 10UploadWizard, and 3 others: Increase padding between statement blocks on UW - https://phabricator.wikimedia.org/T222485 (10matthiasmullie) a:03matthiasmullie [06:14:44] 10Multimedia, 10SDC Design, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Multimedia-Current-Work, 10Patch-For-Review: Image dimension scaling on UW "Add data" step is wonky [Labs] - https://phabricator.wikimedia.org/T221364 (10matthiasmullie) a:05matthiasmullie→03Edtadros [06:15:05] 10Multimedia, 10SDC Design, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Multimedia-Current-Work, 10Patch-For-Review: Image dimension scaling on UW "Add data" step is wonky [Labs] - https://phabricator.wikimedia.org/T221364 (10matthiasmullie) [06:15:16] 10Multimedia, 10SDC Design, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Multimedia-Current-Work, 10Patch-For-Review: Left rail should not show on Add data step if there's just one file - https://phabricator.wikimedia.org/T222196 (10matthiasmullie) [06:15:30] 10Multimedia, 10SDC Design, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Multimedia-Current-Work, 10Patch-For-Review: Left rail should not show on Add data step if there's just one file - https://phabricator.wikimedia.org/T222196 (10matthiasmullie) a:05matthiasmullie→03Edtadros [06:16:16] (03CR) 10Matthias Mullie: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) (owner: 10Matthias Mullie) [06:16:20] (03CR) 10Matthias Mullie: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) (owner: 10Matthias Mullie) [06:28:23] (03CR) 10jerkins-bot: [V: 04-1] Add padding between statement blocks on UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) (owner: 10Matthias Mullie) [06:47:35] 10Multimedia: Explore possibilities for users to remove/exclude geo data from EXIF on images - https://phabricator.wikimedia.org/T222675 (10revi) Q: >For files that a user has contributed themselves, there should be a file page functionality/button that initiates the deletion of geolocation data from WMF databa... [07:05:41] (03Restored) 10Matthias Mullie: Make it impossible to interact with statements while they're being submitted [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507945 (https://phabricator.wikimedia.org/T221076) (owner: 10Matthias Mullie) [08:40:53] (03CR) 10TheDJ: [C: 03+1] "I haven't been able to actually test any of this recently, but other than that, it gets +2 from me" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [09:14:47] 10Multimedia, 10UniversalLanguageSelector, 10WMNO-Sami: Language code "sms" not recognized - https://phabricator.wikimedia.org/T222309 (10Nikki) >>! In T222309#5163398, @Yupik wrote: > On a side note, who can I ask to fix the palatalization marker in Wikidata in various places: I think it's coming from [[ht... [09:17:17] (03CR) 10Matthias Mullie: [C: 03+2] Make it impossible to interact with statements while they're being submitted [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507945 (https://phabricator.wikimedia.org/T221076) (owner: 10Matthias Mullie) [09:21:55] (03Restored) 10Matthias Mullie: Make it slightly more clear what publishing in describe & metadata does [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507946 (https://phabricator.wikimedia.org/T220429) (owner: 10Matthias Mullie) [09:22:01] (03CR) 10Matthias Mullie: [C: 03+2] Make it slightly more clear what publishing in describe & metadata does [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507946 (https://phabricator.wikimedia.org/T220429) (owner: 10Matthias Mullie) [09:36:13] (03Merged) 10jenkins-bot: Make it slightly more clear what publishing in describe & metadata does [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507946 (https://phabricator.wikimedia.org/T220429) (owner: 10Matthias Mullie) [09:38:40] (03PS1) 10Matthias Mullie: Don't show metadata menu when there's only 1 file [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508526 (https://phabricator.wikimedia.org/T222196) [09:39:01] (03CR) 10Matthias Mullie: [C: 03+2] Centralize a statement's disabled state [extensions/WikibaseMediaInfo] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507947 (owner: 10Matthias Mullie) [09:39:13] (03CR) 10jenkins-bot: Make it slightly more clear what publishing in describe & metadata does [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507946 (https://phabricator.wikimedia.org/T220429) (owner: 10Matthias Mullie) [09:40:05] (03CR) 10Matthias Mullie: [C: 03+2] Don't show metadata menu when there's only 1 file [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508526 (https://phabricator.wikimedia.org/T222196) (owner: 10Matthias Mullie) [09:43:26] (03PS1) 10Matthias Mullie: Limit height of thumbs in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508527 (https://phabricator.wikimedia.org/T221364) [09:43:52] (03PS1) 10Matthias Mullie: Properly initialize content nodes in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508528 [09:44:02] (03CR) 10Matthias Mullie: [C: 03+2] Limit height of thumbs in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508527 (https://phabricator.wikimedia.org/T221364) (owner: 10Matthias Mullie) [09:44:05] (03CR) 10Matthias Mullie: [C: 03+2] Properly initialize content nodes in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508528 (owner: 10Matthias Mullie) [09:56:01] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): [SDOC] There is no link to Wikidata item in depicts: when there is no label in the currently used language - https://phabricator.wikimedia.org/T221676 (10matthiasmullie) [10:01:50] (03Merged) 10jenkins-bot: Don't show metadata menu when there's only 1 file [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508526 (https://phabricator.wikimedia.org/T222196) (owner: 10Matthias Mullie) [10:02:38] (03Merged) 10jenkins-bot: Limit height of thumbs in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508527 (https://phabricator.wikimedia.org/T221364) (owner: 10Matthias Mullie) [10:02:40] (03CR) 10jerkins-bot: [V: 04-1] Properly initialize content nodes in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508528 (owner: 10Matthias Mullie) [10:05:53] (03CR) 10Matthias Mullie: [C: 03+2] Properly initialize content nodes in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508528 (owner: 10Matthias Mullie) [10:05:55] (03CR) 10jenkins-bot: Don't show metadata menu when there's only 1 file [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508526 (https://phabricator.wikimedia.org/T222196) (owner: 10Matthias Mullie) [10:07:27] (03CR) 10jerkins-bot: [V: 04-1] Centralize a statement's disabled state [extensions/WikibaseMediaInfo] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507947 (owner: 10Matthias Mullie) [10:07:29] (03CR) 10jerkins-bot: [V: 04-1] Make it impossible to interact with statements while they're being submitted [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507945 (https://phabricator.wikimedia.org/T221076) (owner: 10Matthias Mullie) [10:07:37] (03CR) 10Matthias Mullie: [C: 03+2] Centralize a statement's disabled state [extensions/WikibaseMediaInfo] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507947 (owner: 10Matthias Mullie) [10:08:13] (03CR) 10jenkins-bot: Limit height of thumbs in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508527 (https://phabricator.wikimedia.org/T221364) (owner: 10Matthias Mullie) [10:09:19] (03CR) 10Matthias Mullie: [V: 03+2 C: 03+2] Properly initialize content nodes in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508528 (owner: 10Matthias Mullie) [10:09:58] (03CR) 10Matthias Mullie: [V: 03+2 C: 03+2] Centralize a statement's disabled state [extensions/WikibaseMediaInfo] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507947 (owner: 10Matthias Mullie) [10:10:26] (03CR) 10Matthias Mullie: [V: 03+2 C: 03+2] Make it impossible to interact with statements while they're being submitted [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507945 (https://phabricator.wikimedia.org/T221076) (owner: 10Matthias Mullie) [10:11:06] (03CR) 10jenkins-bot: Centralize a statement's disabled state [extensions/WikibaseMediaInfo] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507947 (owner: 10Matthias Mullie) [10:12:57] (03CR) 10jenkins-bot: Properly initialize content nodes in metadata step [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508528 (owner: 10Matthias Mullie) [10:15:47] (03CR) 10jenkins-bot: Make it impossible to interact with statements while they're being submitted [extensions/UploadWizard] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507945 (https://phabricator.wikimedia.org/T221076) (owner: 10Matthias Mullie) [10:47:00] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Explore possibilities for users to remove/exclude geo data from EXIF on images - https://phabricator.wikimedia.org/T222675 (10Aklapper) [11:02:06] (03PS2) 10Matthias Mullie: Disable publish button until statements have been added [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508364 (https://phabricator.wikimedia.org/T222482) [11:02:29] (03CR) 10Matthias Mullie: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) (owner: 10Matthias Mullie) [11:02:42] (03PS5) 10Matthias Mullie: Require statement exports from other modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/507567 [11:09:27] (03CR) 10jerkins-bot: [V: 04-1] Require statement exports from other modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/507567 (owner: 10Matthias Mullie) [11:12:46] (03PS6) 10Matthias Mullie: Require statement exports from other modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/507567 [11:13:41] (03CR) 10jerkins-bot: [V: 04-1] Add padding between statement blocks on UW [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508363 (https://phabricator.wikimedia.org/T222485) (owner: 10Matthias Mullie) [11:20:47] (03CR) 10Cparle: "This change is ready for review." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [11:41:09] (03CR) 10jerkins-bot: [V: 04-1] Require statement exports from other modules [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/507567 (owner: 10Matthias Mullie) [11:53:08] 10Multimedia, 10UniversalLanguageSelector, 10WMNO-Sami: Language code "sms" not recognized - https://phabricator.wikimedia.org/T222309 (10Yupik) >>! In T222309#5163647, @Nikki wrote: >>>! In T222309#5163398, @Yupik wrote: >> On a side note, who can I ask to fix the palatalization marker in Wikidata in variou... [13:35:16] (03PS7) 10Cparle: Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [13:38:44] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [13:47:29] James_F: you around? [13:48:09] looks like i18n changes (these 5: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/507946/1/i18n/en.json#201) didn't go through during deployment [13:48:40] (`scap sync` is supposed to rebuild that, right?) [13:49:09] anyway - I suppose fastest way to change those would probably be to alter on-wiki? (Mediawiki: namespace) [13:49:21] I have no permissions, though - could you do (or do you know a better fix) [13:53:53] matthiasmullie: No, i18n rebuild is a once-a-week operation. [13:54:19] oh... :) [13:54:29] matthiasmullie: Yeah, I can create, give me a bit to log in on my phone. [13:54:45] sure, thanks :) [13:54:57] It’ll get rebuilt in a few hours as part of the train. [13:55:06] But I guess you don’t want to wait for that. :-) [13:55:38] I can wait, but I can't speak for the rest :p [13:56:06] but yeah, we'd probably rather not wait, if you can do it :p [14:03:32] matthiasmullie: OK, I've touched all those messages, which means they should work correctly for everyone in a bit. [14:03:42] (Up to five minutes of RL cache.) [14:03:57] sweet thanks! [14:05:22] (03CR) 10Jforrester: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/507731 (owner: 10Jforrester) [14:15:00] (03PS8) 10Cparle: Integration tests for statements [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/502867 (https://phabricator.wikimedia.org/T220113) (owner: 10Ha78na) [14:27:53] (03CR) 10jerkins-bot: [V: 04-1] UploadWizardCampaign: Use MediaWikiServices rather than wgParser [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/507731 (owner: 10Jforrester) [15:48:03] 10Multimedia, 10MediaWiki-Uploading, 10VisualEditor, 10Wikimedia-production-error: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor" - https://phabricator.wikimedia.org/T187491 (10JTannerWMF) The Editing team does not maintain the upload function. [16:18:49] 10Multimedia, 10MediaWiki-Uploading, 10VisualEditor, 10Wikimedia-production-error: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor" - https://phabricator.wikimedia.org/T187491 (10marcella) @MarkTraceur, this looks like a task for your team. If you think that isn't the... [16:29:24] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Statement-and-keyword-search-power-walking): [DO THIS FIRST] Auto-suggest widget that returns P-items limited to 1 or more data types - https://phabricator.wikimedia.org/T219378 (10Cparle) a:03Cparle [17:14:00] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Explore possibilities for users to remove/exclude geo data from EXIF on images - https://phabricator.wikimedia.org/T222675 (10Ramsey-WMF) Still to be determined. The button could kick off an admin review/deletion process. But we m... [17:34:13] (03CR) 10Bartosz Dziewoński: [C: 03+2] "This should go through now, after https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/508616" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [17:59:16] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T222361 (10PDrouin-WMF) I'd like to keep it consistent with the right-justified spinner we alr... [18:04:49] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/508659 [18:16:20] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508663 [18:17:27] 10Multimedia, 10SDC Engineering, 10StructuredDataOnCommons, 10WikibaseMediaInfo, and 2 others: WikibaseMediaInfo serializes empty statements as empty array [] instead of empty object {} in JSON - https://phabricator.wikimedia.org/T222159 (10Ramsey-WMF) [18:24:18] (03Merged) 10jenkins-bot: UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [18:28:53] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/508669 [18:44:26] (03CR) 10jenkins-bot: UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [19:31:10] (03CR) 10Jforrester: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/507731 (owner: 10Jforrester) [19:37:44] (03CR) 10Jforrester: [C: 03+2] "The cut is nigh. Let's land this." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [19:46:08] (03CR) 10MaxSem: [C: 03+2] UploadWizardCampaign: Use MediaWikiServices rather than wgParser [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/507731 (owner: 10Jforrester) [19:54:32] (03Merged) 10jenkins-bot: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [19:55:34] brion: Eek. Yay. [19:56:06] \o/ [19:56:13] let's see if it breaks \o/ [19:56:30] :-) [19:56:58] Next step, enabling the videojs beta feature in production! [19:58:42] :D [20:04:14] (03Merged) 10jenkins-bot: UploadWizardCampaign: Use MediaWikiServices rather than wgParser [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/507731 (owner: 10Jforrester) [20:12:50] (03CR) 10jenkins-bot: UploadWizardCampaign: Use MediaWikiServices rather than wgParser [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/507731 (owner: 10Jforrester) [20:33:41] 10Multimedia, 10SDC Engineering, 10Patch-For-Review: Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel" - https://phabricator.wikimedia.org/T222370 (10PDrouin-WMF) Sounds good to me. [20:35:14] (03CR) 10Jforrester: [C: 03+2] "> Patch Set 1:" (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/507818 (https://phabricator.wikimedia.org/T222370) (owner: 10Esanders) [21:04:01] (03Merged) 10jenkins-bot: Use OO.ui.confirm for discard changes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/507818 (https://phabricator.wikimedia.org/T222370) (owner: 10Esanders) [21:04:52] (03CR) 10jenkins-bot: Use OO.ui.confirm for discard changes [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/507818 (https://phabricator.wikimedia.org/T222370) (owner: 10Esanders) [21:13:44] brion: Hmm. Initial testing on Beta (of files on production Commons) didn't work, but it's all fine with https://en.wikipedia.beta.wmflabs.org/wiki/File:CLD_test.webm where I pasted in some other subtitles. :-) (Both local-on-Commons and cross-wiki work as expected.) [21:14:40] Hmm, it might be confused by something in instant Commons, though I thought k tested that [21:15:12] File a task with example link and I'll poke it. [21:15:27] brion: Also it fetches the subtitles on read, not on play (tsk), and for each of the copies of the video on the page (minor optimisation). [21:15:44] Heh yeah it's awful in that respect for now [21:16:00] Krinkle will be Unhappy™ :-) [21:17:40] Filed. [21:18:27] Well that's work for me to fix then :) [21:22:42] brion: Filed as T222762 and T222763 for you. :-) [21:23:13] tx [21:23:22] agh this new macbook keyboard i hates it [21:23:33] i'm usually at my desk but air conditioning sux in my home office and it's warm today [21:25:00] Come to the office, it's quiet and the air con is great. ;-) [21:25:21] Also yes, newer Mac keyboards aren't great. [21:28:04] i should wander down and visit some time :D [21:28:21] i love the cpu though. oodles faster at compiles and video conversions than my old one [21:28:24] so i live with it [21:35:20] * James_F nods. [21:39:23] James_F: can you add one of those file page links to the task description? always best to know we're testing the same thing :D [21:43:31] brion: It was https://commons.wikimedia.beta.wmflabs.org/wiki/File:CLD_test.webm (the one I faked subs for). [21:54:02] Tx [22:28:59] 10Multimedia, 10SDC Engineering, 10UI-Standardization, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14): Use OO.ui.confirm instead of mw.confirmCloseWindow.trigger when pressing "cancel" - https://phabricator.wikimedia.org/T222370 (10Jdforrester-WMF) New dialog: {F28960312,size=full} [22:30:56] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Epic, and 2 others: Poor/non-functional experience on mobile [Epic] - https://phabricator.wikimedia.org/T221658 (10Ramsey-WMF) [22:31:02] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Statements auto-complete does not work on mobile skin - https://phabricator.wikimedia.org/T221678 (10Ramsey-WMF) 05Open→03Resolved Works on mobile in production now. [22:36:25] 10Multimedia, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC Engineering (Depicts-Crawling), 10SDC-Statements (Depicts-Crawling): Add descriptive text used for depicts on UW to FP also - https://phabricator.wikimedia.org/T216757 (10Ramsey-WMF) 05Open→03Resolved clear on prod [22:36:45] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Upload Wizard depicts heading/label should match what's been updated for File Page - https://phabricator.wikimedia.org/T219944 (10Ramsey-WMF) 05Open→03Resolved All good on production [22:36:46] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10Ramsey-WMF) [22:38:37] 10Multimedia, 10SDC Engineering, 10Wikidata, 10Core Platform Team (MCR), and 3 others: Deploy Structured Data on Commons with arbitrary Statements - https://phabricator.wikimedia.org/T199352 (10Ramsey-WMF) [22:38:45] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10Ramsey-WMF) 05Open→03Resolved Done! yay! [22:40:01] (03PS3) 10Jforrester: Disable publish button until statements have been added [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/508364 (https://phabricator.wikimedia.org/T222482) (owner: 10Matthias Mullie) [22:52:07] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): [Alpha/Labs] Note CC0 license for all structured data on the new UploadWizard "Metadata" step - https://phabricator.wikimedia.org/T216298 (10Ramsey-WMF) 05Open→03Resolved Works on production. [22:52:13] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10Ramsey-WMF) [22:54:18] 10Multimedia, 10SDC Design, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Multimedia-Current-Work, 10Patch-For-Review: Left rail should not show on Add data step if there's just one file - https://phabricator.wikimedia.org/T222196 (10Ramsey-WMF) 05Open→03Resolved The spec on this changed: UploadWizar... [22:56:51] 10Multimedia, 10SDC Design, 10SDC Engineering, 10Epic, and 2 others: Poor/non-functional experience on mobile [Epic] - https://phabricator.wikimedia.org/T221658 (10Ramsey-WMF) [22:56:57] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Multimedia-Current-Work, and 2 others: Statements submitted on mobile don't show up until refresh - https://phabricator.wikimedia.org/T221229 (10Ramsey-WMF) 05Open→03Resolved Fixed on production. [22:58:04] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Walking): Metadata/Add data step right alignment issues - https://phabricator.wikimedia.org/T219947 (10Ramsey-WMF) 05Open→03Resolved Fixed on production. [22:58:06] 10Multimedia, 10SDC General, 10UploadWizard, 10Wikidata, and 3 others: "Depicts walking": Add/edit depicts statements in UploadWizard - https://phabricator.wikimedia.org/T215304 (10Ramsey-WMF)