[00:47:29] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Add basic unit tests for StatementPanel - https://phabricator.wikimedia.org/T221057 (10egardner) [00:49:02] (03PS1) 10Eric Gardner: WIP: Basic unit tests for StatementPanel element [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504225 (https://phabricator.wikimedia.org/T221057) [05:29:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504186 (owner: 10L10n-bot) [05:35:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/504174 (owner: 10L10n-bot) [07:35:29] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Other-statements-running): Duplicate custom item title on frontend - https://phabricator.wikimedia.org/T220214 (10matthiasmullie) a:03matthiasmullie [07:36:07] (03PS3) 10Matthias Mullie: Don't display statement input field when datatype doesn't support it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504028 (https://phabricator.wikimedia.org/T220614) [07:36:09] (03PS1) 10Matthias Mullie: Also render custom statement titles client-size [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504250 (https://phabricator.wikimedia.org/T220214) [07:53:16] (03PS2) 10Matthias Mullie: Also render custom statement titles client-size [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504250 (https://phabricator.wikimedia.org/T220214) [07:57:20] (03PS5) 10Matthias Mullie: Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 [08:05:58] (03CR) 10jerkins-bot: [V: 04-1] Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 (owner: 10Matthias Mullie) [08:06:47] (03CR) 10Matthias Mullie: "Added 2 notes about assuming [0] === depicts." (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504028 (https://phabricator.wikimedia.org/T220614) (owner: 10Matthias Mullie) [08:12:29] (03CR) 10jerkins-bot: [V: 04-1] Also render custom statement titles client-size [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504250 (https://phabricator.wikimedia.org/T220214) (owner: 10Matthias Mullie) [08:47:06] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Allow viewing of statement blocks with unsupported data types - https://phabricator.wikimedia.org/T220613 (10matthiasmullie) a:05matthiasmullie→03Edtadros [08:47:14] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-on-training-wheels): Allow viewing of qualifiers with unsupported data types - https://phabricator.wikimedia.org/T220616 (10matthiasmullie) a:05matthiasmullie→03Edtadros [08:47:26] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, and 2 others: Allow deletion of qualifiers with unsupported data types - https://phabricator.wikimedia.org/T220617 (10matthiasmullie) a:05matthiasmullie→03Edtadros [08:47:42] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, and 2 others: Depicts heading text is cut off on right - https://phabricator.wikimedia.org/T221021 (10matthiasmullie) a:03Edtadros [08:54:00] (03PS3) 10Matthias Mullie: Also render custom statement titles client-size [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504250 (https://phabricator.wikimedia.org/T220214) [08:55:38] (03PS1) 10Matthias Mullie: Remove unneeded joiner [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 [09:07:50] (03PS6) 10Matthias Mullie: Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 [09:19:57] (03CR) 10Cparle: [C: 03+2] Don't display statement input field when datatype doesn't support it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504028 (https://phabricator.wikimedia.org/T220614) (owner: 10Matthias Mullie) [09:44:27] (03Merged) 10jenkins-bot: Don't display statement input field when datatype doesn't support it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504028 (https://phabricator.wikimedia.org/T220614) (owner: 10Matthias Mullie) [09:45:09] (03CR) 10jenkins-bot: Don't display statement input field when datatype doesn't support it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504028 (https://phabricator.wikimedia.org/T220614) (owner: 10Matthias Mullie) [10:36:03] (03PS4) 10Matthias Mullie: Also render custom statement titles client-size [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504250 (https://phabricator.wikimedia.org/T220214) [10:36:17] (03PS7) 10Matthias Mullie: Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 [10:46:12] (03CR) 10jerkins-bot: [V: 04-1] Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 (owner: 10Matthias Mullie) [10:58:52] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: How to deal with other wikis sharing Commons content? - https://phabricator.wikimedia.org/T221070 (10matthiasmullie) [11:10:15] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: We don't want MediaInfo content to show up on wikis sharing Commons files - https://phabricator.wikimedia.org/T221071 (10matthiasmullie) [11:10:33] (03PS1) 10Matthias Mullie: Don't show MediaInfo content unless MediaInfo is installed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504296 (https://phabricator.wikimedia.org/T221071) [11:46:58] (03CR) 10Cparle: [C: 03+2] Also render custom statement titles client-size [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504250 (https://phabricator.wikimedia.org/T220214) (owner: 10Matthias Mullie) [11:56:31] (03PS8) 10Matthias Mullie: Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 [12:02:23] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T221076 (10matthiasmullie) [12:03:29] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T221076 (10matthiasmullie) @PDrouin-WMF or @Ramsey-WMF might have a good idea for how to indicate that statements are being submitted. [12:06:27] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-Walking): UploadWizard's 'add data' step should show files in the same order as other steps - https://phabricator.wikimedia.org/T221077 (10matthiasmullie) [12:10:27] (03Merged) 10jenkins-bot: Also render custom statement titles client-size [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504250 (https://phabricator.wikimedia.org/T220214) (owner: 10Matthias Mullie) [12:11:11] (03CR) 10jenkins-bot: Also render custom statement titles client-size [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504250 (https://phabricator.wikimedia.org/T220214) (owner: 10Matthias Mullie) [12:13:11] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: [EPIC] How to deal with other wikis sharing Commons content? - https://phabricator.wikimedia.org/T221070 (10matthiasmullie) [12:19:18] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: [EPIC] How to deal with other wikis sharing Commons content? - https://phabricator.wikimedia.org/T221070 (10matthiasmullie) Current status: MediaInfo content is included in other wikis. E.g. https://en.wikipedia.org/wiki/File:2019-01-13_Commons_Stru... [12:20:32] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T221076 (10PDrouin-WMF) Using a spinner would keep things consistent -- I keep trying to do a short screen record the upload process, but i... [14:20:45] (03CR) 10Cparle: [C: 03+1] "Some quirk of vagrant is preventing me from testing this properly, but the code looks good to me. @Jforrester @MarkTraceur maybe one of yo" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504296 (https://phabricator.wikimedia.org/T221071) (owner: 10Matthias Mullie) [14:24:10] 10Multimedia, 10Wikidata, 10Multimedia-Current-Work, 10SDC Engineering (Depicts-Crawling), 10SDC-Statements (Depicts-Crawling): Enable federated access to entities and properties from Wikidata to Commons - https://phabricator.wikimedia.org/T214075 (10Lucas_Werkmeister_WMDE) [14:32:43] (03CR) 10Cparle: [C: 03+2] Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 (owner: 10Matthias Mullie) [14:53:41] (03CR) 10jerkins-bot: [V: 04-1] Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 (owner: 10Matthias Mullie) [15:13:08] (03CR) 10Jforrester: [C: 03+2] Don't show MediaInfo content unless MediaInfo is installed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504296 (https://phabricator.wikimedia.org/T221071) (owner: 10Matthias Mullie) [15:13:40] (03PS2) 10Jforrester: captionspanel.less: Remove unneeded selector joiner [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [15:13:44] (03CR) 10Jforrester: [C: 03+2] captionspanel.less: Remove unneeded selector joiner [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [15:16:08] (03CR) 10Matthias Mullie: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 (owner: 10Matthias Mullie) [15:17:45] (03PS2) 10Eric Gardner: WIP: Basic unit tests for StatementPanel element [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504225 (https://phabricator.wikimedia.org/T221057) [15:29:26] (03CR) 10jerkins-bot: [V: 04-1] captionspanel.less: Remove unneeded selector joiner [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [15:31:20] (03CR) 10jerkins-bot: [V: 04-1] WIP: Basic unit tests for StatementPanel element [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504225 (https://phabricator.wikimedia.org/T221057) (owner: 10Eric Gardner) [15:32:30] (03CR) 10jenkins-bot: Rename DepictsWidget to StatementWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/502209 (owner: 10Matthias Mullie) [15:42:30] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [15:47:57] (03CR) 10jerkins-bot: [V: 04-1] Don't show MediaInfo content unless MediaInfo is installed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504296 (https://phabricator.wikimedia.org/T221071) (owner: 10Matthias Mullie) [15:47:59] (03CR) 10jerkins-bot: [V: 04-1] captionspanel.less: Remove unneeded selector joiner [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [16:01:41] (03CR) 10Matthias Mullie: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [16:03:59] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Multimedia-Current-Work, and 2 others: Depicts heading text is cut off on right - https://phabricator.wikimedia.org/T221021 (10PDrouin-WMF) It's no longer cut off for me, @Ha78na [16:09:36] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: 'Items depicts in this File' text sometimes in German - https://phabricator.wikimedia.org/T221017 (10Ha78na) [16:10:58] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: 'Items depicts in this File' text sometimes in German - https://phabricator.wikimedia.org/T221017 (10Ha78na) a:03Ramsey-WMF [16:14:45] (03CR) 10jerkins-bot: [V: 04-1] captionspanel.less: Remove unneeded selector joiner [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [16:15:24] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Multimedia-Current-Work, and 2 others: P and Q links don't display wikidata icon - https://phabricator.wikimedia.org/T219872 (10Ha78na) a:05Edtadros→03Ha78na I've QA'ed this on test commons and it looks good, I see... [16:18:03] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, and 2 others: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state - https://phabricator.wikimedia.org/T219515 (10Ha78na) @PDrouin-WMF Moved this into "verify on p... [16:23:40] (03PS1) 10Matthias Mullie: Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 [16:28:46] (03CR) 10Ha78na: [C: 03+1] Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (owner: 10Matthias Mullie) [16:35:57] (03CR) 10jerkins-bot: [V: 04-1] Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (owner: 10Matthias Mullie) [16:40:59] (03CR) 10Matthias Mullie: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (owner: 10Matthias Mullie) [16:49:56] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Allow viewing of statement blocks with unsupported data types - https://phabricator.wikimedia.org/T220613 (10Ha78na) a:05Edtadros→03Ha78na [16:51:44] 10Multimedia, 10Multimedia-Current-Work: Inconsistent handling of RTL languages in Structured Data UI elements - https://phabricator.wikimedia.org/T221109 (10egardner) [16:52:40] 10Multimedia, 10Multimedia-Current-Work: Inconsistent handling of RTL languages in Structured Data UI elements - https://phabricator.wikimedia.org/T221109 (10egardner) [16:53:25] (03CR) 10jerkins-bot: [V: 04-1] Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (owner: 10Matthias Mullie) [16:57:04] 10Multimedia, 10I18n, 10Multimedia-Current-Work: Inconsistent handling of RTL languages in Structured Data UI elements - https://phabricator.wikimedia.org/T221109 (10Aklapper) [16:57:12] 10Multimedia, 10I18n, 10Multimedia-Current-Work, 10RTL: Inconsistent handling of RTL languages in Structured Data UI elements - https://phabricator.wikimedia.org/T221109 (10Aklapper) [17:01:28] 10Multimedia, 10Multimedia-Current-Work: Cannot edit statements for certain images - https://phabricator.wikimedia.org/T221110 (10Ha78na) [17:01:36] 10Multimedia, 10Multimedia-Current-Work: Cannot edit statements for certain images - https://phabricator.wikimedia.org/T221110 (10Ha78na) a:03matthiasmullie [17:05:12] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: [EPIC] How to deal with other wikis sharing Commons content? - https://phabricator.wikimedia.org/T221070 (10Ha78na) nice --good move on making this! [17:24:53] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: 'Items depicts in this File' text sometimes in German - https://phabricator.wikimedia.org/T221017 (10Ramsey-WMF) p:05Triage→03Normal After a few tests, have been unable to reproduce this on Test commons (with a new upload, with an old upload tha... [17:26:54] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Crawling): Cannot edit statements for certain images - https://phabricator.wikimedia.org/T221110 (10Ramsey-WMF) p:05Triage→03High [17:27:49] (03PS1) 10Cparle: Detach editing controls on diff and historical File pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504383 (https://phabricator.wikimedia.org/T218922) [17:35:14] (03CR) 10Cparle: "Gotta go eat now, but this might need to be merged before tomorrow - without it someone can edit from page history" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504383 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [17:40:03] (03CR) 10jerkins-bot: [V: 04-1] Detach editing controls on diff and historical File pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504383 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [17:43:45] 10Multimedia, 10WikibaseMediaInfo, 10Multimedia-Current-Work: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10MarkTraceur) [17:47:37] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T221076 (10Ramsey-WMF) > We could either replace the entire content (or just the widgets) with some "statements are being published" I've... [17:49:12] 10Multimedia, 10WikibaseMediaInfo, 10Multimedia-Current-Work: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10MarkTraceur) In production: I submitted nine captions for https://commons.wikimedia.org/wiki/File:Sollentuna_kyrka_-_KMB_-_16000200131314.jp... [17:51:47] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T221076 (10PDrouin-WMF) Agree, Ramsey - I've experienced elements still being actionable during the submission process, and it makes it see... [17:52:30] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Multimedia-Current-Work: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10Ramsey-WMF) p:05Triage→03Normal [17:56:31] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Depicts-Walking): UploadWizard should indicate that statements are being submitted - https://phabricator.wikimedia.org/T221076 (10matthiasmullie) @Ramsey-WMF level of effort depends on exactly what we want do do (the devil is in the details), but should be s... [17:57:04] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Multimedia-Current-Work: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10egardner) In my case the panel ended up in a frozen disabled state, where some captions had been submitted and others n... [18:00:03] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Multimedia-Current-Work: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10MarkTraceur) @egardner I'm fascinated by that screenshot, not only because it's inconsistently broken (the best kind of... [18:00:36] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Multimedia-Current-Work: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10egardner) Even the brokenness is broken... [18:28:07] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Multimedia-Current-Work: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10egardner) a:03egardner [18:38:42] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10Ramsey-WMF) The current implementation looks good but I wonder if we need some... [18:49:08] (03PS1) 10Matthias Mullie: Don't remove textInput after having submitted it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504410 (https://phabricator.wikimedia.org/T221123) [18:50:14] (03CR) 10Jforrester: "Yes, that would do it." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504410 (https://phabricator.wikimedia.org/T221123) (owner: 10Matthias Mullie) [18:54:20] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Multimedia-Current-Work, 10Patch-For-Review: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10egardner) a:05egardner→03None [18:55:42] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: We don't want MediaInfo content to show up on wikis sharing Commons files - https://phabricator.wikimedia.org/T221071 (10Ha78na) Seem blocked by failures due to T221111 [18:56:20] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10PDrouin-WMF) What about a tooltip that appears on hover? [18:56:50] (03PS2) 10Matthias Mullie: Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (https://phabricator.wikimedia.org/T221110) [18:58:16] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Cannot edit statements for certain images - https://phabricator.wikimedia.org/T221110 (10Ha78na) Seem blocked by failures due to T221111 [18:59:23] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Multimedia-Current-Work, 10Patch-For-Review: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10matthiasmullie) a:03matthiasmullie [19:01:31] (03CR) 10jerkins-bot: [V: 04-1] Don't remove textInput after having submitted it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504410 (https://phabricator.wikimedia.org/T221123) (owner: 10Matthias Mullie) [19:03:11] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10Ramsey-WMF) >>! In T219381#5116174, @PDrouin-WMF wrote: > What about a tooltip... [19:09:17] (03CR) 10jerkins-bot: [V: 04-1] Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (https://phabricator.wikimedia.org/T221110) (owner: 10Matthias Mullie) [19:09:24] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Handle statements with unsupported properties - https://phabricator.wikimedia.org/T219381 (10PDrouin-WMF) Since it's temporary, whatever is easier should be fine. [20:08:38] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504296 (https://phabricator.wikimedia.org/T221071) (owner: 10Matthias Mullie) [20:08:41] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [20:08:58] (03CR) 10Jforrester: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504383 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [20:09:01] (03CR) 10Jforrester: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504410 (https://phabricator.wikimedia.org/T221123) (owner: 10Matthias Mullie) [20:09:03] (03CR) 10Jforrester: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (https://phabricator.wikimedia.org/T221110) (owner: 10Matthias Mullie) [20:11:05] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501970 (owner: 10Jforrester) [20:36:31] (03CR) 10jerkins-bot: [V: 04-1] Detach editing controls on diff and historical File pages [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504383 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [20:47:32] (03Merged) 10jenkins-bot: Don't show MediaInfo content unless MediaInfo is installed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504296 (https://phabricator.wikimedia.org/T221071) (owner: 10Matthias Mullie) [20:47:34] (03Merged) 10jenkins-bot: captionspanel.less: Remove unneeded selector joiner [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [20:47:36] (03Merged) 10jenkins-bot: WikibaseMediaInfoHooksTest: Make the captions dummy content we check more like reality [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501970 (owner: 10Jforrester) [20:48:26] (03CR) 10jenkins-bot: Don't show MediaInfo content unless MediaInfo is installed [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504296 (https://phabricator.wikimedia.org/T221071) (owner: 10Matthias Mullie) [20:49:06] (03CR) 10jenkins-bot: captionspanel.less: Remove unneeded selector joiner [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504273 (owner: 10Matthias Mullie) [20:49:45] (03CR) 10Jforrester: [C: 03+2] Don't remove textInput after having submitted it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504410 (https://phabricator.wikimedia.org/T221123) (owner: 10Matthias Mullie) [20:49:50] (03CR) 10jenkins-bot: WikibaseMediaInfoHooksTest: Make the captions dummy content we check more like reality [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501970 (owner: 10Jforrester) [20:50:01] (03CR) 10Jforrester: [C: 03+2] Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (https://phabricator.wikimedia.org/T221110) (owner: 10Matthias Mullie) [20:50:50] (03CR) 10Eric Gardner: [C: 03+2] "Looks good, multiple captions now submit in order and all seem to go through correctly." (031 comment) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504410 (https://phabricator.wikimedia.org/T221123) (owner: 10Matthias Mullie) [21:04:44] (03CR) 10Eric Gardner: "recheck" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504225 (https://phabricator.wikimedia.org/T221057) (owner: 10Eric Gardner) [21:14:05] (03Merged) 10jenkins-bot: Don't remove textInput after having submitted it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504410 (https://phabricator.wikimedia.org/T221123) (owner: 10Matthias Mullie) [21:14:07] (03Merged) 10jenkins-bot: Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (https://phabricator.wikimedia.org/T221110) (owner: 10Matthias Mullie) [21:14:36] (03CR) 10Ha78na: [C: 03+1] "I think we should merge this" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504383 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [21:16:07] (03CR) 10Jforrester: Detach editing controls on diff and historical File pages (032 comments) [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504383 (https://phabricator.wikimedia.org/T218922) (owner: 10Cparle) [21:21:44] (03CR) 10jenkins-bot: Don't remove textInput after having submitted it [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504410 (https://phabricator.wikimedia.org/T221123) (owner: 10Matthias Mullie) [21:22:34] (03CR) 10jenkins-bot: Don't use value until having checked there is one [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/504366 (https://phabricator.wikimedia.org/T221110) (owner: 10Matthias Mullie) [21:40:51] 10Multimedia, 10SDC Engineering, 10WikibaseMediaInfo, 10Multimedia-Current-Work, 10Patch-For-Review: Adding multiple captions at once is v broken (Beta Commons) - https://phabricator.wikimedia.org/T221123 (10Ha78na) a:05matthiasmullie→03MarkTraceur [21:41:02] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Cannot edit statements for certain images - https://phabricator.wikimedia.org/T221110 (10Ha78na) a:05matthiasmullie→03Ha78na [21:43:21] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Cannot edit statements for certain images - https://phabricator.wikimedia.org/T221110 (10Ha78na) This is working properly now on Beta again. [21:46:20] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work: Structured fields don't show a notice about IP logging for users who aren't logged in - https://phabricator.wikimedia.org/T218628 (10egardner) It is my understanding that the text is always going to depend o... [21:49:00] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Multimedia-Current-Work, 10Patch-For-Review: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified - https://phabricator.wikimedia.org/T220234 (10egardner) This feature seems t... [21:51:08] 10Multimedia, 10SDC Engineering, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Multimedia-Current-Work, 10Patch-For-Review: We don't want MediaInfo content to show up on wikis sharing Commons files - https://phabricator.wikimedia.org/T221071 (10Ha78na) This is merged now but seems like we can't really ve... [21:57:51] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): Allow viewing of statement blocks with unsupported data types - https://phabricator.wikimedia.org/T220613 (10Ha78na) This seems to be working fine on beta, @matthiasmullie I couldn't figu... [22:11:22] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Multimedia-Current-Work, and 3 others: Match the spacings and paddings with the design spec - https://phabricator.wikimedia.org/T216773 (10Ha78na) @PDrouin-WMF do you think we could close/resolve this ticket now? [22:11:44] 10Multimedia, 10SDC Design, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Multimedia-Current-Work, and 3 others: The panels should use column width (60%) instead of spanning across the entire screen - https://phabricator.wikimedia.org/T216772 (10Ha78na) @PDrouin-WMF Can we considered this finished and clo...