[00:06:42] (03CR) 10Krinkle: [C: 03+2] eslint: Remove general no-underscore-dangle exception [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501425 (owner: 10Jforrester) [00:23:47] (03Merged) 10jenkins-bot: eslint: Remove general no-underscore-dangle exception [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501425 (owner: 10Jforrester) [00:26:35] (03CR) 10jenkins-bot: eslint: Remove general no-underscore-dangle exception [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501425 (owner: 10Jforrester) [07:06:05] (03CR) 10Matthias Mullie: [C: 03+2] Fix 'Discard Changes' and 'Leave Site' alerts [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501047 (https://phabricator.wikimedia.org/T219771) (owner: 10Ha78na) [07:17:50] 10Multimedia, 10Commons, 10MediaWiki-File-management, 10TechCom-RFC, 10Wikimedia-SVG-rendering: Re-evaluate librsvg as SVG renderer on Wikimedia wikis - https://phabricator.wikimedia.org/T40010 (10MoritzMuehlenhoff) resvg is now available in Debian unstable: https://packages.qa.debian.org/r/resvg/news/20... [07:31:51] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-on-training-wheels): [Alpha/Labs] Search bar: keyword and depicts tags appear on top of Qualifier input window - https://phabricator.wikimedia.org/T218630 (10Ramsey-WMF) It's working now. Still a bit... [08:30:29] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Multimedia-Current-Work, and 2 others: Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Cparle) [10:36:28] 10Multimedia, 10Thumbor, 10UploadWizard, 10Multimedia-Current-Work: Flickr UploadWizard fails to fetch thumbnails - https://phabricator.wikimedia.org/T219679 (10matthiasmullie) Added #thumbor tag for additional insight. Can't find anything wrong (or anything relevant having changed recently) in UploadWiza... [10:36:44] 10Multimedia, 10Thumbor, 10UploadWizard, 10Multimedia-Current-Work: Flickr UploadWizard fails to fetch thumbnails - https://phabricator.wikimedia.org/T219679 (10matthiasmullie) a:05matthiasmullie→03None [11:33:41] (03PS1) 10Matthias Mullie: Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) [11:33:51] (03PS2) 10Matthias Mullie: Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) [11:39:45] (03PS3) 10Matthias Mullie: Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) [11:40:07] (03PS4) 10Matthias Mullie: Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) [11:45:15] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): P and Q links don't display wikidata icon - https://phabricator.wikimedia.org/T219872 (10matthiasmullie) a:03matthiasmullie [12:28:26] (03CR) 10Matthias Mullie: [C: 03+2] Fix 'Discard Changes' and 'Leave Site' alerts [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501047 (https://phabricator.wikimedia.org/T219771) (owner: 10Ha78na) [12:37:55] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): UI for adding statement block on File page (Q-items only, no qualifiers) - https://phabricator.wikimedia.org/T219383 (10matthiasmullie) [12:47:30] (03Merged) 10jenkins-bot: Fix 'Discard Changes' and 'Leave Site' alerts [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501047 (https://phabricator.wikimedia.org/T219771) (owner: 10Ha78na) [12:48:45] (03CR) 10jenkins-bot: Fix 'Discard Changes' and 'Leave Site' alerts [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501047 (https://phabricator.wikimedia.org/T219771) (owner: 10Ha78na) [15:17:15] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): [DO THIS FIRST] Auto-suggest widget that returns P-items limited to 1 or more data types - https://phabricator.wikimedia.org/T219378 (10Cparle) [15:32:52] 10Multimedia, 10SDC-Statements (Other-statements-running): Make sure that the order of statements on the File page is correct - https://phabricator.wikimedia.org/T220213 (10Cparle) [15:46:22] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): Duplicate custom item title on frontend - https://phabricator.wikimedia.org/T220214 (10matthiasmullie) [15:46:39] (03PS5) 10Jforrester: Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) (owner: 10Matthias Mullie) [15:48:20] (03CR) 10Jforrester: [C: 03+2] Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) (owner: 10Matthias Mullie) [16:08:46] (03PS2) 10Jforrester: eslint: Remove general one-var and vars-on-top exemptions and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501426 [16:12:33] (03PS6) 10Jforrester: Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) (owner: 10Matthias Mullie) [16:12:46] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) (owner: 10Matthias Mullie) [16:23:57] 10Multimedia, 10MediaWiki-Uploading, 10Patch-For-Review, 10Wikimedia-production-error: Upload failed with fatal error: Call to load() on a non-object in UploadBase.php - https://phabricator.wikimedia.org/T208539 (10Krinkle) Hm.. yeah, I don't know either. The path from the client interaction to this partic... [16:34:40] (03Merged) 10jenkins-bot: Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) (owner: 10Matthias Mullie) [16:35:53] (03PS2) 10Jforrester: eslint: Remove general valid-jsdoc exemption and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501427 [16:36:00] (03CR) 10jenkins-bot: Extract repository name for entities [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501547 (https://phabricator.wikimedia.org/T219872) (owner: 10Matthias Mullie) [16:39:05] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): P and Q links don't display wikidata icon - https://phabricator.wikimedia.org/T219872 (10matthiasmullie) a:05matthiasmullie→03Edtadros [16:42:20] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-Crawling): 'Confirm you want to leave' unload message shown when it shouldn't be - https://phabricator.wikimedia.org/T219771 (10Ha78na) a:05Ha78na→03Edtadros [16:44:10] (03CR) 10Cparle: "It's probably not ok to have a writable dir in here for writing the file into - perhaps use this instead https://www.npmjs.com/package/tmp" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [17:05:16] (03PS1) 10Jforrester: Follow-up a0143594: Production uses 'd' as the interwiki for Wikidata [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501637 (https://phabricator.wikimedia.org/T219872) [17:06:32] (03CR) 10Mooeypoo: [C: 03+2] Follow-up a0143594: Production uses 'd' as the interwiki for Wikidata [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501637 (https://phabricator.wikimedia.org/T219872) (owner: 10Jforrester) [17:08:13] (03CR) 10Zfilipin: "Screenshots and videos are stored in tests/selenium/log, I guess auto-generated files can go there too." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [17:26:25] (03Merged) 10jenkins-bot: Follow-up a0143594: Production uses 'd' as the interwiki for Wikidata [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501637 (https://phabricator.wikimedia.org/T219872) (owner: 10Jforrester) [17:30:19] (03CR) 10jenkins-bot: Follow-up a0143594: Production uses 'd' as the interwiki for Wikidata [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501637 (https://phabricator.wikimedia.org/T219872) (owner: 10Jforrester) [17:36:28] (03CR) 10Ha78na: [C: 03+1] eslint: Remove general one-var and vars-on-top exemptions and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501426 (owner: 10Jforrester) [18:02:37] (03CR) 10Eric Gardner: [C: 03+2] eslint: Remove general one-var and vars-on-top exemptions and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501426 (owner: 10Jforrester) [18:36:00] (03Merged) 10jenkins-bot: eslint: Remove general one-var and vars-on-top exemptions and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501426 (owner: 10Jforrester) [18:37:02] (03CR) 10jenkins-bot: eslint: Remove general one-var and vars-on-top exemptions and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501426 (owner: 10Jforrester) [18:48:28] (03CR) 10Jforrester: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [18:48:31] (03CR) 10Ha78na: [C: 03+2] eslint: Remove general valid-jsdoc exemption and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501427 (owner: 10Jforrester) [18:50:00] (03PS2) 10Jforrester: UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [19:08:46] (03Merged) 10jenkins-bot: eslint: Remove general valid-jsdoc exemption and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501427 (owner: 10Jforrester) [19:09:52] (03CR) 10jenkins-bot: eslint: Remove general valid-jsdoc exemption and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501427 (owner: 10Jforrester) [19:37:35] 10Multimedia, 10SDC General, 10Wikidata, 10Patch-For-Review, and 2 others: Display qualifiers on File page via php - https://phabricator.wikimedia.org/T215933 (10Jdforrester-WMF) I believe that this is technically done (except for design tweaks), but is invisible on Beta until T219181 is complete, is that... [19:45:09] (03PS9) 10Eric Gardner: First selenium test [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [19:48:29] (03CR) 10Eric Gardner: "Updated the patch to use the Node tmp library and rebased off master." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [19:50:31] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): Duplicate custom item title on frontend - https://phabricator.wikimedia.org/T220214 (10Ramsey-WMF) p:05Triage→03High [19:56:49] 10Multimedia, 10MediaWiki-Uploading, 10Patch-For-Review, 10Wikimedia-production-error: Upload failed with fatal error: Call to load() on a non-object in UploadBase.php - https://phabricator.wikimedia.org/T208539 (10MarkTraceur) I'm not entirely certain I follow the example code above (I looked for it in th... [19:58:50] 10Multimedia, 10SDC Engineering, 10SDC-Statements (Other-statements-running): Make sure that the order of statements on the File page is correct - https://phabricator.wikimedia.org/T220213 (10Ramsey-WMF) p:05Triage→03High [20:02:28] 10Multimedia, 10Multimedia-Current-Work: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified - https://phabricator.wikimedia.org/T220234 (10egardner) [20:14:25] (03CR) 10jerkins-bot: [V: 04-1] First selenium test [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [20:18:38] 10Multimedia, 10Multimedia-Current-Work: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified - https://phabricator.wikimedia.org/T220234 (10egardner) According to Git Bisect, it looks like the regression was introduced here: a513113edc80cd9a23ff5404cbd153708a8... [21:09:24] 10Multimedia, 10Multimedia-Current-Work: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified - https://phabricator.wikimedia.org/T220234 (10egardner) Ok, after a little more digging, here is what I think is going on: Currently, the DepictsPanel has a method c... [21:33:38] 10Multimedia, 10Commons, 10MediaWiki-File-management: LocalFile isMissing always returns true regardless of file stat - https://phabricator.wikimedia.org/T220244 (10osorio-juan-microsoft) [21:59:43] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), 10Multimedia-Current-Work, 10Patch-For-Review: Can't save after deleting a statement (and not doing anything else) - https://phabricator.wikimedia.org/T218318 (10Ramsey-WMF) a:05Ramsey-WMF→03PDrouin-WMF Tested and passed on... [22:44:55] 10Multimedia, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) [23:16:53] 10Multimedia, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) I was surprised to see this task open. This also... [23:20:23] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified - https://phabricator.wikimedia.org/T220234 (10Ramsey-WMF) p:05Triage→03High [23:36:33] (03PS1) 10Eric Gardner: Remove guard clause from DepictsPanel.hasChanges() [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501819 (https://phabricator.wikimedia.org/T220234) [23:40:01] (03CR) 10Eric Gardner: "This is a naive solution to https://phabricator.wikimedia.org/T220234#5089550." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501819 (https://phabricator.wikimedia.org/T220234) (owner: 10Eric Gardner) [23:40:52] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified - https://phabricator.wikimedia.org/T220234 (10egardner) a:03egardner [23:41:16] 10Multimedia, 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10JJMC89) [23:49:57] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review: Unable to publish depicts changes after clicking "mark as prominent" when no other values are modified - https://phabricator.wikimedia.org/T220234 (10Ramsey-WMF) @Cparle and @matthiasmullie this might be a big issue we need to... [23:50:27] (03CR) 10Jforrester: [C: 03+2] "Rescuing from C+2 hell after jenkins/zuul/gearman/something fell over." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501767 (owner: 10L10n-bot) [23:50:33] (03CR) 10Jforrester: [C: 03+2] "Rescuing from C+2 hell after jenkins/zuul/gearman/something fell over." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501773 (owner: 10L10n-bot)