[00:04:48] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10egardner) Ok, I have a test for file uploads *almost* working, but there are... [00:05:52] (03CR) 10Eric Gardner: [C: 04-1] "This solution mostly works but there is one problem with the image upload test that still needs to be solved." [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [00:10:08] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10Jdforrester-WMF) I'd recommend just having a few files in the repo that we up... [00:12:57] (03CR) 10jerkins-bot: [V: 04-1] First selenium test [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [00:52:42] (03PS2) 10VolkerE: build: Upgrade eslint-config-wikimedia from 0.10.1 to 0.11.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/501112 (owner: 10Jforrester) [00:54:31] (03CR) 10VolkerE: [C: 03+2] build: Upgrade eslint-config-wikimedia from 0.10.1 to 0.11.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/501112 (owner: 10Jforrester) [01:10:58] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia from 0.10.1 to 0.11.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/501112 (owner: 10Jforrester) [04:03:30] (03CR) 10Jforrester: [C: 03+2] Remove some obsolete return values from non-abort hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/500983 (owner: 10Krinkle) [04:04:14] (03CR) 10Jforrester: [C: 03+2] Use onParserTestGlobals instead of wgWikimediaJenkinsCI [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/500984 (https://phabricator.wikimedia.org/T200650) (owner: 10Krinkle) [04:15:16] (03Merged) 10jenkins-bot: Remove some obsolete return values from non-abort hooks [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/500983 (owner: 10Krinkle) [04:20:09] (03Merged) 10jenkins-bot: Use onParserTestGlobals instead of wgWikimediaJenkinsCI [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/500984 (https://phabricator.wikimedia.org/T200650) (owner: 10Krinkle) [07:09:33] 10Multimedia, 10Commons: Global usage not working on Commons? - https://phabricator.wikimedia.org/T220075 (10Ramsey-WMF) [07:12:01] 10Multimedia, 10Commons: Global usage not working on Commons? - https://phabricator.wikimedia.org/T220075 (10Ramsey-WMF) [07:12:04] 10Multimedia, 10Commons, 10GlobalUsage: Global usage outdated - https://phabricator.wikimedia.org/T219964 (10Ramsey-WMF) [07:12:31] 10Multimedia, 10Commons: Global usage not working on Commons? - https://phabricator.wikimedia.org/T220075 (10Ramsey-WMF) [07:12:33] 10Multimedia, 10GlobalUsage: GlobalUsage duplicates Commons usage to en.wikipedia.org section with broken links - https://phabricator.wikimedia.org/T218778 (10Ramsey-WMF) [07:15:03] 10Multimedia, 10Commons: Global usage not working on Commons? - https://phabricator.wikimedia.org/T220075 (10Ramsey-WMF) p:05Triage→03High [11:37:25] (03PS1) 10Matthias Mullie: Submit caption calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501188 [11:37:27] (03PS1) 10Matthias Mullie: Don't submit baserevid for captions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501189 (https://phabricator.wikimedia.org/T219677) [11:37:59] 10Multimedia, 10StructuredDataOnCommons, 10UploadWizard, 10Multimedia-Current-Work, 10Patch-For-Review: During UploadWizard process, issue with Captions blocked the process - https://phabricator.wikimedia.org/T219677 (10matthiasmullie) So this edit conflict was caused by `FlickreviewR 2` bot being fast e... [13:02:16] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501295 (owner: 10L10n-bot) [13:22:54] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501295 (owner: 10L10n-bot) [13:32:46] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, and 2 others: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state - https://phabricator.wikimedia.org/T219515 (10Edtadros) === Test Result **Status:** ❓Need More... [13:37:18] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, and 2 others: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state - https://phabricator.wikimedia.org/T219515 (10Cparle) @Edtadros yep I reckon so [13:43:28] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, and 2 others: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state - https://phabricator.wikimedia.org/T219515 (10Edtadros) @Cparle thanks...updating the test resu... [13:48:13] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, and 2 others: Clicking 'make prominent' while depicts form is submitting gets the form into a weird state - https://phabricator.wikimedia.org/T219515 (10Edtadros) a:05Edtadros→03Ramsey-WMF [14:09:53] 10Multimedia: Add php integration tests for Depicts - https://phabricator.wikimedia.org/T220113 (10Ha78na) [14:12:44] 10Multimedia, 10Multimedia-Current-Work: Add php integration tests for Depicts - https://phabricator.wikimedia.org/T220113 (10Ha78na) [14:12:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501302 (owner: 10L10n-bot) [14:14:51] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), 10Multimedia-Current-Work, 10Patch-For-Review: Top-to-bottom order of primary/prominent depicts values should change on publish - https://phabricator.wikimedia.org/T219292 (10Ha78na) a:03Edtadros [14:20:04] 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Multimedia-Current-Work, and 2 others: Basic depicts support for campaigns in UploadWizard - https://phabricator.wikimedia.org/T219368 (10Edtadros) a:05Edtadros→03Cparle Reassigning to @cparle to add "newbie" QA steps. [14:41:36] (03CR) 10Ha78na: [C: 03+1] Don't submit baserevid for captions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501189 (https://phabricator.wikimedia.org/T219677) (owner: 10Matthias Mullie) [14:49:35] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, 10SDC-Statements (Depicts-on-training-wheels): [Alpha/Labs] Search bar: keyword and depicts tags appear on top of Qualifier input window - https://phabricator.wikimedia.org/T218630 (10matthiasmullie) That might've been becaus... [15:37:20] (03CR) 10Brion VIBBER: "Marking back as WIP as there's some fixes yet to do" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [15:50:31] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10egardner) There has been some discussion about whether some of these tests be... [15:51:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501295 (owner: 10L10n-bot) [16:59:13] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10SDC-Statements (Depicts-Crawling): Add php integration tests for Depicts - https://phabricator.wikimedia.org/T220113 (10Ramsey-WMF) p:05Triage→03Normal [17:28:46] (03CR) 10Brion VIBBER: [C: 03+2] "Looks correct; it shouldn't be running any transcodes during unit testing anyway." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/500984 (https://phabricator.wikimedia.org/T200650) (owner: 10Krinkle) [17:31:35] (03CR) 10Jforrester: "> Patch Set 2: Code-Review+2" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/500984 (https://phabricator.wikimedia.org/T200650) (owner: 10Krinkle) [19:00:47] (03CR) 10Jforrester: [C: 03+2] "Oops." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501188 (owner: 10Matthias Mullie) [19:01:08] (03CR) 10Jforrester: [C: 03+2] Don't submit baserevid for captions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501189 (https://phabricator.wikimedia.org/T219677) (owner: 10Matthias Mullie) [19:15:33] (03Merged) 10jenkins-bot: Submit caption calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501188 (owner: 10Matthias Mullie) [19:15:35] (03Merged) 10jenkins-bot: Don't submit baserevid for captions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501189 (https://phabricator.wikimedia.org/T219677) (owner: 10Matthias Mullie) [19:21:06] (03CR) 10jenkins-bot: Submit caption calls [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501188 (owner: 10Matthias Mullie) [19:24:15] (03CR) 10jenkins-bot: Don't submit baserevid for captions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/501189 (https://phabricator.wikimedia.org/T219677) (owner: 10Matthias Mullie) [21:17:58] (03CR) 10Brion VIBBER: "(inline reply re apiqueryvideoinof & InstantCommons)" (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [21:39:34] (03PS1) 10Jforrester: eslint: Remove general no-underscore-dangle exception [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501425 [21:39:35] (03PS1) 10Jforrester: eslint: Remove general one-var and vars-on-top exemptions and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501426 [21:39:38] (03PS1) 10Jforrester: eslint: Remove general valid-jsdoc exemption and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501427 [21:54:55] (03CR) 10jerkins-bot: [V: 04-1] eslint: Remove general one-var and vars-on-top exemptions and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501426 (owner: 10Jforrester) [22:06:39] (03CR) 10jerkins-bot: [V: 04-1] eslint: Remove general valid-jsdoc exemption and make pass [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501427 (owner: 10Jforrester) [22:28:37] (03PS8) 10Eric Gardner: First selenium test [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [22:32:59] (03CR) 10Eric Gardner: "I've added a node-based random image generation tool per Cormac's suggestion, and that solves my problems with duplicate images being reje" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [22:34:03] 10Multimedia, 10SDC Engineering, 10Multimedia-Current-Work, 10Patch-For-Review, and 2 others: Create integration tests to cover potential issues with editing and uploading on Commons - https://phabricator.wikimedia.org/T219815 (10egardner) Ok – random image generation in Node has been added as of patchset... [22:38:44] (03CR) 10Jforrester: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [22:43:53] (03CR) 10jerkins-bot: [V: 04-1] UploadWizard: Use OO.ui.SelectFileWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/499494 (owner: 10Esanders) [22:45:01] (03CR) 10jerkins-bot: [V: 04-1] First selenium test [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/500935 (https://phabricator.wikimedia.org/T219815) (owner: 10Cparle) [22:53:18] (03CR) 10Eric Gardner: [C: 03+1] "I think this all looks good – nice work!" [extensions/WikibaseMediaInfo] - 10https://gerrit.wikimedia.org/r/501047 (https://phabricator.wikimedia.org/T219771) (owner: 10Ha78na)